craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D41558
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
hintonda added a comment.
ping...
Repository:
rCXX libc++
https://reviews.llvm.org/D41248
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kosarev created this revision.
kosarev added reviewers: rjmccall, hfinkel.
kosarev added a project: clang.
We only do this for the new format as the old format does not allow to
represent accesses to aggregates. This patch significantly improves TBAA
coverage on -O1 builds.
Repository:
rL LL
Author: d0k
Date: Sun Dec 24 04:46:22 2017
New Revision: 321425
URL: http://llvm.org/viewvc/llvm-project?rev=321425&view=rev
Log:
Make helpers static. No functionality change.
Modified:
cfe/trunk/lib/AST/ASTContext.cpp
Modified: cfe/trunk/lib/AST/ASTContext.cpp
URL:
http://llvm.org/viewvc/l
Sure, thanks for the report.
Best regards,
Alexey Bataev
24 дек. 2017 г., в 8:27, Maxim Kuvyrkov написал(а):
>> On Dec 23, 2017, at 12:01 AM, Alexey Bataev via cfe-commits
>> wrote:
>>
>> Author: abataev
>> Date: Fri Dec 22 13:01:52 2017
>> New Revision: 321386
>>
>> URL:
>> https://nam04
Author: abataev
Date: Sun Dec 24 06:18:33 2017
New Revision: 321427
URL: http://llvm.org/viewvc/llvm-project?rev=321427&view=rev
Log:
[OPENMP] Fix the tests for 32bits targets, NFC.
Modified:
cfe/trunk/test/OpenMP/teams_distribute_parallel_for_num_threads_codegen.cpp
cfe/trunk/test/OpenM
coby created this revision.
coby added a reviewer: craig.topper.
Herald added a subscriber: mgorny.
added intrinsics support for bitalg instructions, matching a similar work on
the backend (https://reviews.llvm.org/D40222)
Repository:
rC Clang
https://reviews.llvm.org/D41564
Files:
includ
dim accepted this revision.
dim added a comment.
This revision is now accepted and ready to land.
Yes, please. Rather sooner than later, the warning itself can be fixed
post-6.0.0.
Repository:
rC Clang
https://reviews.llvm.org/D41512
___
cfe-co
Author: d0k
Date: Sun Dec 24 08:24:20 2017
New Revision: 321429
URL: http://llvm.org/viewvc/llvm-project?rev=321429&view=rev
Log:
[AST] Inline CompoundStmt contents into the parent allocation.
Saves a pointer on every CompoundStmt.
Modified:
cfe/trunk/include/clang/AST/Stmt.h
cfe/trunk/l
Author: d0k
Date: Sun Dec 24 08:24:11 2017
New Revision: 321428
URL: http://llvm.org/viewvc/llvm-project?rev=321428&view=rev
Log:
[AST] Convert AttributedStmt to llvm::TrailingObjects.
No functionality change intended.
Modified:
cfe/trunk/include/clang/AST/Stmt.h
cfe/trunk/lib/AST/Stmt.c
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D41512
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dim added a comment.
Actually, having thought about it a little more, if the warning is "rather
broken", or even "completely broken", depending on one's point of view, then
maybe it is better not have it under `-Wextra` either? E.g. somebody has to
ask for the warning specifically, using `-Wta
aaron.ballman added inline comments.
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:161
+
+ const SmallVector& getCheckNames() const {
+assert(isNolintFound());
aaron.ballman wrote:
> The `&` should bind to the right. However, instead of returning th
On Sun, Dec 24, 2017 at 11:45 AM, Dimitry Andric via Phabricator
wrote:
> dim added a comment.
>
> Actually, having thought about it a little more, if the warning is "rather
> broken", or even "completely broken", depending on one's point of view, then
> maybe it is better not have it under `-We
> On Dec 23, 2017, at 12:01 AM, Alexey Bataev via cfe-commits
> wrote:
>
> Author: abataev
> Date: Fri Dec 22 13:01:52 2017
> New Revision: 321386
>
> URL: http://llvm.org/viewvc/llvm-project?rev=321386&view=rev
> Log:
> [OPENMP] Captured arguments of the capturable clauses by value.
>
> If th
lebedev.ri added a comment.
In https://reviews.llvm.org/D41512#963743, @dim wrote:
> Actually, having thought about it a little more, if the warning is "rather
> broken", or even "completely broken", depending on one's point of view, then
> maybe it is better not have it under `-Wextra` either?
aaron.ballman accepted this revision.
aaron.ballman added a subscriber: dblaikie.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Aside from a documentation nit, this LGTM. However, you should wait to commit
until after you can safely regenerate the AST matcher doc
faisalv added a comment.
I think this looks good enough to commit - do you have commit privileges - or
do you need one of us to commit it for you?
thank you!
https://reviews.llvm.org/D40381
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
changyu added a comment.
I don't have commit privilege. And also there's one more problem we might want
to address first.
Thank you.
Comment at: lib/Parse/ParseTemplate.cpp:181
+TemplateParameterList *TPL = ParamLists[0];
+if (TPL->getLAngleLoc().getLocWithOffset(1) =
hamzasood created this revision.
hamzasood added reviewers: rsmith, bruno, boris.
Diagnose attempts to export declarations with internal linkage, as mentioned in
`[dcl.module.interface]p2` in the Modules TS.
I would've liked to add a FixIt hint to remove the static keyword if present,
but I cou
faisalv added inline comments.
Comment at: lib/Parse/ParseTemplate.cpp:181
+TemplateParameterList *TPL = ParamLists[0];
+if (TPL->getLAngleLoc().getLocWithOffset(1) == TPL->getRAngleLoc()) {
+ Diag(TPL->getTemplateLoc(),
changyu wrote:
> There's one
lebedev.ri updated this revision to Diff 128113.
lebedev.ri edited the summary of this revision.
lebedev.ri added a comment.
In https://reviews.llvm.org/D41512#963743, @dim wrote:
> We now still have to explicitly use `-Wno-tautological-constant-compare`
> everywhere. :-(
OTOH, thank you for b
lebedev.ri updated this revision to Diff 128114.
lebedev.ri added a comment.
Rebased.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D36836
Files:
LICENSE.TXT
clang-tidy/CMakeLists.txt
clang-tidy/plugin/CMakeLists.txt
clang-tidy/sonarsource/CMakeLists.txt
clang-tidy/so
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D41564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
saar.raz created this revision.
saar.raz added reviewers: hubert.reinterpretcast, rsmith, nwilson, changyu,
faisalv.
Herald added a subscriber: cfe-commits.
- Associated constraints (requires clauses, currently) are now enforced when
instantiating/specializing templates and when considering part
saar.raz updated this revision to Diff 128121.
saar.raz added a comment.
Reverted to original constraint parsing code.
https://reviews.llvm.org/D41217
Files:
include/clang/AST/DeclTemplate.h
include/clang/AST/ExprCXX.h
include/clang/AST/RecursiveASTVisitor.h
include/clang/Basic/Diagnost
rsmith added inline comments.
Comment at: include/clang/Basic/DiagnosticGroups.td:439
def TautologicalUnsignedZeroCompare :
DiagGroup<"tautological-unsigned-zero-compare">;
def TautologicalUnsignedEnumZeroCompare :
DiagGroup<"tautological-unsigned-enum-zero-compare">;
+def Ta
> On Dec 21, 2017, at 16:39, Alex L wrote:
>
>
>
>> On 21 December 2017 at 12:34, James Y Knight wrote:
>> I totally agree with moving towards eliminating the -m-version-min
>> flags, it's much better to put it in the target, and will clean up a lot of
>> cruft in the driver, eventually.
>>
changyu updated this revision to Diff 128123.
changyu marked 2 inline comments as done.
https://reviews.llvm.org/D40381
Files:
include/clang/AST/DeclTemplate.h
include/clang/AST/RecursiveASTVisitor.h
include/clang/Basic/DeclNodes.td
include/clang/Basic/DiagnosticParseKinds.td
include/cl
changyu added a comment.
I moved some template param checks from
`Parser::ParseTemplateDeclarationOrSpecialization` to
`Parser::ParseConceptDefinition` and `Sema::ActOnConceptDefinition`.
Comment at: lib/Parse/ParseTemplate.cpp:181
+TemplateParameterList *TPL = ParamLists
This revision was automatically updated to reflect the committed changes.
Closed by commit rL321435: [libcxx] Suppress unused warning on apple. (authored
by dhinton, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D41248
Files:
libcxx/trunk/src/experimental/filesystem/operation
Author: dhinton
Date: Sun Dec 24 21:33:42 2017
New Revision: 321435
URL: http://llvm.org/viewvc/llvm-project?rev=321435&view=rev
Log:
[libcxx] Suppress unused warning on apple.
Summary:
This warning is already suppressed on non-apple platforms, so
this change just suppresses it on apple as well.
vladimir.plyashkun added a comment.
@ilya-biryukov
Yes, this is exactly what i need.
Unfortunately, `-ivfsoverlay` in the compile commands works for the compiler
invocation, but it doesn't work for tooling.
E.g. this call:
clang-tidy -checks=* -- -ivfsoverlay=
has no effect.
Repository:
33 matches
Mail list logo
