r321504 - [X86] Don't accidentally enable PKU on cannon lake and icelake or CLWB on cannonlake.

2017-12-27 Thread Craig Topper via cfe-commits
Author: ctopper Date: Wed Dec 27 14:26:01 2017 New Revision: 321504 URL: http://llvm.org/viewvc/llvm-project?rev=321504&view=rev Log: [X86] Don't accidentally enable PKU on cannon lake and icelake or CLWB on cannonlake. We have cannonlake and icelake inheriting from skylake server in a switch us

r321503 - [X86] Test that -march=skx enables PKU.

2017-12-27 Thread Craig Topper via cfe-commits
Author: ctopper Date: Wed Dec 27 14:26:00 2017 New Revision: 321503 URL: http://llvm.org/viewvc/llvm-project?rev=321503&view=rev Log: [X86] Test that -march=skx enables PKU. Modified: cfe/trunk/test/Preprocessor/predefined-arch-macros.c Modified: cfe/trunk/test/Preprocessor/predefined-arch-m

r321502 - [X86] Enable avx512vpopcntdq and clwb for icelake.

2017-12-27 Thread Craig Topper via cfe-commits
Author: ctopper Date: Wed Dec 27 14:25:59 2017 New Revision: 321502 URL: http://llvm.org/viewvc/llvm-project?rev=321502&view=rev Log: [X86] Enable avx512vpopcntdq and clwb for icelake. Per table 1-1 of the October 2017 edition of Intel® Architecture Instruction Set Extensions and Future Features

[PATCH] D41538: [analyzer] Fix some checker's output plist not containing the checker name #2

2017-12-27 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun updated this revision to Diff 128240. xazax.hun marked 5 inline comments as done. xazax.hun added a comment. - Address review comments. https://reviews.llvm.org/D41538 Files: include/clang/StaticAnalyzer/Core/BugReporter/BugType.h lib/StaticAnalyzer/Checkers/MallocChecker.cpp li

[PATCH] D41538: [analyzer] Fix some checker's output plist not containing the checker name #2

2017-12-27 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added inline comments. Comment at: include/clang/StaticAnalyzer/Core/BugReporter/BugType.h:54 +// initialization. +if (getCheckName().empty() && Checker) { + Check = Checker->getCheckName(); a.sidorin wrote: > Possibly I am missing the cont

[PATCH] D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment

2017-12-27 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:424 +// This method is not const, because it fills cache on first demand. +// It is possible to fill cache in constructor or make cache volatile +// and make this method const, but they se

Re: r320942 - [ASTImporter] Support importing FunctionTemplateDecl and CXXDependentScopeMemberExpr

2017-12-27 Thread Aleksei Sidorin via cfe-commits
Hello Peter, I've recommitted the patch after attempt to fix it (rL321492). Please tell me if you see any issue. Thank you. 20.12.2017 12:05, Aleksei Sidorin пишет: Thank you, Peter! I'll take a look. Unfortunately, there were no any buildbot e-mail complains about it so I didn't even notic

[PATCH] D41538: [analyzer] Fix some checker's output plist not containing the checker name #2

2017-12-27 Thread Aleksei Sidorin via Phabricator via cfe-commits
a.sidorin added a comment. Hello Gabor, For me, this patch looks much better than previous. I have some questions inline. Comment at: include/clang/StaticAnalyzer/Core/BugReporter/BugType.h:40 public: - BugType(class CheckName check, StringRef name, StringRef cat) - :

[PATCH] D39457: [OPENMP] Current status of OpenMP support.

2017-12-27 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev updated this revision to Diff 128238. ABataev added a comment. Updated status of `target (update|enter data|exit data)` directives. Marked that support for cuda devices is not ready yet. Repository: rC Clang https://reviews.llvm.org/D39457 Files: docs/OpenMPSupport.rst docs/index

[PATCH] D41179: [Sema] Diagnose template specializations with C linkage

2017-12-27 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff added a comment. In https://reviews.llvm.org/D41179#964526, @faisalv wrote: > In https://reviews.llvm.org/D41179#964522, @miyuki wrote: > > > In https://reviews.llvm.org/D41179#957992, @sepavloff wrote: > > > > > Classes do not have language linkage according to 10.5p1, just as > > >

r321495 - [OPENMP] Support for `depend` clauses on `target enter|exit data`.

2017-12-27 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Wed Dec 27 10:49:38 2017 New Revision: 321495 URL: http://llvm.org/viewvc/llvm-project?rev=321495&view=rev Log: [OPENMP] Support for `depend` clauses on `target enter|exit data`. Added codegen for `depend` clauses on `target enter|exit data` directives. Added: cfe/trunk

r321494 - [NFC] Small const correctness fix

2017-12-27 Thread Hamza Sood via cfe-commits
Author: hamzasood Date: Wed Dec 27 10:05:29 2017 New Revision: 321494 URL: http://llvm.org/viewvc/llvm-project?rev=321494&view=rev Log: [NFC] Small const correctness fix Modified: cfe/trunk/lib/Sema/SemaLookup.cpp Modified: cfe/trunk/lib/Sema/SemaLookup.cpp URL: http://llvm.org/viewvc/llvm-

r321493 - [OPENMP] Support for `depend` clauses on `target data update`.

2017-12-27 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Wed Dec 27 09:58:32 2017 New Revision: 321493 URL: http://llvm.org/viewvc/llvm-project?rev=321493&view=rev Log: [OPENMP] Support for `depend` clauses on `target data update`. Added codegen for `depend` clauses on `target data update` directives. Added: cfe/trunk/test/Op

r321492 - [ASTImporter] Support importing FunctionTemplateDecl and CXXDependentScopeMemberExpr

2017-12-27 Thread Aleksei Sidorin via cfe-commits
Author: a.sidorin Date: Wed Dec 27 09:04:42 2017 New Revision: 321492 URL: http://llvm.org/viewvc/llvm-project?rev=321492&view=rev Log: [ASTImporter] Support importing FunctionTemplateDecl and CXXDependentScopeMemberExpr * Also introduces ImportTemplateArgumentListInfo facility (A. Sidorin) Thi

[PATCH] D41179: [Sema] Diagnose template specializations with C linkage

2017-12-27 Thread Faisal Vali via Phabricator via cfe-commits
faisalv added a comment. In https://reviews.llvm.org/D41179#964522, @miyuki wrote: > In https://reviews.llvm.org/D41179#957992, @sepavloff wrote: > > > Classes do not have language linkage according to 10.5p1, just as > > templates, so this code is valid. > > > > It looks like defining tem

[PATCH] D41179: [Sema] Diagnose template specializations with C linkage

2017-12-27 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. In https://reviews.llvm.org/D41179#957992, @sepavloff wrote: > Classes do not have language linkage according to 10.5p1, just as > templates, so this code is valid. > > It looks like defining templates inside extern "C" blocks is OK. Currently both Clang and GCC d

[PATCH] D41179: [Sema] Diagnose template specializations with C linkage

2017-12-27 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki updated this revision to Diff 128234. miyuki added a comment. Factored out template language linkage check into a separate function https://reviews.llvm.org/D41179 Files: lib/Sema/SemaTemplate.cpp test/SemaTemplate/class-template-spec.cpp test/SemaTemplate/function-template-special

[PATCH] D41168: [X86] Lowering X86 avx512 sqrt intrinsics to IR

2017-12-27 Thread Uriel Korach via Phabricator via cfe-commits
uriel.k updated this revision to Diff 128232. uriel.k retitled this revision from "[X86][avx512] Lowering X86 avx512 sqrt intrinsics to IR" to "[X86] Lowering X86 avx512 sqrt intrinsics to IR". uriel.k edited the summary of this revision. uriel.k added a comment. now takes care of sqrt with round

[PATCH] D41500: ananas: Add shared library support

2017-12-27 Thread Ed Schouten via Phabricator via cfe-commits
ed added inline comments. Comment at: lib/Driver/ToolChains/Ananas.cpp:93 CmdArgs.push_back(Args.MakeArgString(ToolChain.GetFilePath("crti.o"))); -CmdArgs.push_back(Args.MakeArgString(ToolChain.GetFilePath("crtbegin.o"))); +if (Args.hasArg(options::OPT_shared) || Arg

[PATCH] D41535: Add -vfsoverlay option for Clang-Tidy

2017-12-27 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun added a comment. FYI, i've create revision to support `ivfsoverlay` option in Tooling: https://reviews.llvm.org/D41594 Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41535 ___ cfe-commits mailing list cfe-commits

[PATCH] D41512: [Sema] -Wtautological-constant-compare is too good. Cripple it.

2017-12-27 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri updated this revision to Diff 128226. lebedev.ri edited the summary of this revision. lebedev.ri added a comment. Herald added a subscriber: mehdi_amini. - Give `warn_tautological_constant_compare` it's own flag `-Wtautological-type-limit-compare`. I'm not happy about that name, but i

[PATCH] D41594: Support `ivfsoverlay` option in Tooling

2017-12-27 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun created this revision. vladimir.plyashkun added reviewers: bkramer, alexfh, ilya-biryukov. vladimir.plyashkun added a project: clang. Herald added a subscriber: klimek. Previously, this argument had no effect, since it didn't proceeded. For more information, check this review: h

[PATCH] D41557: [x86][icelake][vbmi2]

2017-12-27 Thread coby via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL321487: [x86][icelake][vbmi2] (authored by coby, committed by ). Changed prior to commit: https://reviews.llvm.org/D41557?vs=128172&id=128221#toc Repository: rL LLVM https://reviews.llvm.org/D41557

r321487 - [x86][icelake][vbmi2]

2017-12-27 Thread Coby Tayree via cfe-commits
Author: coby Date: Wed Dec 27 03:25:07 2017 New Revision: 321487 URL: http://llvm.org/viewvc/llvm-project?rev=321487&view=rev Log: [x86][icelake][vbmi2] added vbmi2 feature recognition added intrinsics support for vbmi2 instructions _mm[128,256,512]_mask[z]_compress_epi[16,32] _mm[128,256,512]_mas

[PATCH] D41012: [OpenMP] Further adjustments of nvptx runtime functions

2017-12-27 Thread Jonas Hahnfeld via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL321486: [OpenMP] Further adjustments of nvptx runtime functions (authored by Hahnfeld, committed by ). Changed prior to commit: https://reviews.llvm.org/D41012?vs=126159&id=128217#toc Repository: rL

r321486 - [OpenMP] Further adjustments of nvptx runtime functions

2017-12-27 Thread Jonas Hahnfeld via cfe-commits
Author: hahnfeld Date: Wed Dec 27 02:39:56 2017 New Revision: 321486 URL: http://llvm.org/viewvc/llvm-project?rev=321486&view=rev Log: [OpenMP] Further adjustments of nvptx runtime functions Pass in default value of 1, similar to previous commit r318836. Differential Revision: https://reviews.ll

[PATCH] D41558: [x86][icelake][vnni]

2017-12-27 Thread coby via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL321484: [x86][icelake][vnni] (authored by coby, committed by ). Changed prior to commit: https://reviews.llvm.org/D41558?vs=128099&id=128216#toc Repository: rL LLVM https://reviews.llvm.org/D41558

r321484 - [x86][icelake][vnni]

2017-12-27 Thread Coby Tayree via cfe-commits
Author: coby Date: Wed Dec 27 02:37:51 2017 New Revision: 321484 URL: http://llvm.org/viewvc/llvm-project?rev=321484&view=rev Log: [x86][icelake][vnni] added vnni feature recognition added intrinsics support for VNNI instructions _mm256_mask_dpbusd_epi32 _mm256_maskz_dpbusd_epi32 _mm256_dpbusd_epi

[PATCH] D41564: [x86][icelake][bitalg]

2017-12-27 Thread coby via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL321483: [x86][icelake][bitalg] (authored by coby, committed by ). Changed prior to commit: https://reviews.llvm.org/D41564?vs=128109&id=128213#toc Repository: rL LLVM https://reviews.llvm.org/D41564

r321483 - [x86][icelake][bitalg]

2017-12-27 Thread Coby Tayree via cfe-commits
Author: coby Date: Wed Dec 27 02:01:00 2017 New Revision: 321483 URL: http://llvm.org/viewvc/llvm-project?rev=321483&view=rev Log: [x86][icelake][bitalg] added bitalg feature recognition added intrinsics support for bitalg instructions _mm512_popcnt_epi16 _mm512_mask_popcnt_epi16 _mm512_maskz_popc

Re: r321482 - [hotfix]

2017-12-27 Thread Richard Smith via cfe-commits
Hi Coby, please include a brief description of your commit on the first line of the commit message -- that's all that shows up on the commits list and in the summary view of some repository tools. On 27 Dec 2017 09:23, "Coby Tayree via cfe-commits" < cfe-commits@lists.llvm.org> wrote: Author: cob

r321482 - [hotfix]

2017-12-27 Thread Coby Tayree via cfe-commits
Author: coby Date: Wed Dec 27 01:22:34 2017 New Revision: 321482 URL: http://llvm.org/viewvc/llvm-project?rev=321482&view=rev Log: [hotfix] fixinig test failures as seen here: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/22791/steps/test/logs/stdio which resu

[PATCH] D41573: [x86][icelake][vpclmulqdq]

2017-12-27 Thread coby via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL321480: [x86][icelake][vpclmulqdq] (authored by coby, committed by ). Changed prior to commit: https://reviews.llvm.org/D41573?vs=128183&id=128210#toc Repository: rL LLVM https://reviews.llvm.org/D4

r321480 - [x86][icelake][vpclmulqdq]

2017-12-27 Thread Coby Tayree via cfe-commits
Author: coby Date: Wed Dec 27 01:00:31 2017 New Revision: 321480 URL: http://llvm.org/viewvc/llvm-project?rev=321480&view=rev Log: [x86][icelake][vpclmulqdq] added vpclmulqdq feature recognition added intrinsics support for vpclmulqdq instructions _mm256_clmulepi64_epi128 _mm512_clmulepi64_epi

[PATCH] D41583: [x86][icelake][vaes]

2017-12-27 Thread coby via Phabricator via cfe-commits
coby closed this revision. coby added a comment. closed by commit https://reviews.llvm.org/rC321474 (https://reviews.llvm.org/rL321474) Repository: rC Clang https://reviews.llvm.org/D41583 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41582: [x86][icelake][gfni]

2017-12-27 Thread coby via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC321477: [x86][icelake][gfni] (authored by coby, committed by ). Changed prior to commit: https://reviews.llvm.org/D41582?vs=128168&id=128207#toc Repository: rC Clang https://reviews.llvm.org/D41582

r321477 - [x86][icelake][gfni]

2017-12-27 Thread Coby Tayree via cfe-commits
Author: coby Date: Wed Dec 27 00:37:47 2017 New Revision: 321477 URL: http://llvm.org/viewvc/llvm-project?rev=321477&view=rev Log: [x86][icelake][gfni] added gfni feature recognition added intrinsics support for gfni instructions _mm_gf2p8affineinv_epi64_epi8 _mm_mask_gf2p8affineinv_epi64_epi8

r321474 - [x86][icelake][vaes]

2017-12-27 Thread Coby Tayree via cfe-commits
Author: coby Date: Wed Dec 27 00:16:54 2017 New Revision: 321474 URL: http://llvm.org/viewvc/llvm-project?rev=321474&view=rev Log: [x86][icelake][vaes] added vaes feature recognition added intrinsics support for vaes instructions, matching a similar work on the backend (D40078) _mm256_aesenc_ep