patcheng created this revision.
Herald added subscribers: cfe-commits, sunfish, aheejin, jgravelle-google,
sbc100, dschuff, jfb.
Herald added a reviewer: EricWF.
Referenced implementation from Fuchsia and Darwin Toolchain.
Still only support CST_Libcxx.
Now checks that the argument is really '-
ahatanak updated this revision to Diff 129397.
ahatanak added a comment.
In CXXRecordDecl::addedMember, set HasTrivialSpecialMembersForCall if
Method->isTrivialForCall() returns true. This fixes a bug where
CXXRecordDecl::hasNonTrivialDestructorForCall would return false for the
implicit destr
Author: phosek
Date: Wed Jan 10 23:05:38 2018
New Revision: 322260
URL: http://llvm.org/viewvc/llvm-project?rev=322260&view=rev
Log:
Revert "[Driver] Update default sanitizer blacklist location"
This reverts commit r322258: broke the dfsan build.
Added:
cfe/trunk/test/Driver/Inputs/resource_
Author: phosek
Date: Wed Jan 10 22:42:12 2018
New Revision: 322258
URL: http://llvm.org/viewvc/llvm-project?rev=322258&view=rev
Log:
Reland "[Driver] Update default sanitizer blacklist location"
This is related to moving the sanitizer blacklists to share/
subdirectory.
Differential Revision: htt
adriweb added a comment.
@rjmccall any ETA for a commit as requested by @jacobly?
Repository:
rC Clang
https://reviews.llvm.org/D40569
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
mclow.lists added inline comments.
Comment at:
test/std/experimental/filesystem/fs.op.funcs/fs.op.remove/remove.pass.cpp:67
non_empty_dir,
-file_in_bad_dir,
+// file_in_bad_dir, // produces "St13exception_ptruncaught_exceptions
not yet implemented"
This revision was automatically updated to reflect the committed changes.
Closed by commit rC322253: [Fuchsia] Remove LLDB from the toolchain
distribution (authored by phosek, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41929?vs=129377&id=129393#toc
Repository:
rC Clan
Author: phosek
Date: Wed Jan 10 20:25:30 2018
New Revision: 322253
URL: http://llvm.org/viewvc/llvm-project?rev=322253&view=rev
Log:
[Fuchsia] Remove LLDB from the toolchain distribution
This is currently not being used so disable it to reduce toolchain size.
Differential Revision: https://revie
TyanNN marked 2 inline comments as done.
TyanNN added inline comments.
Comment at:
test/std/experimental/filesystem/fs.op.funcs/fs.op.remove/remove.pass.cpp:67
non_empty_dir,
-file_in_bad_dir,
+// file_in_bad_dir, // produces "St13exception_ptruncaught_e
Author: phosek
Date: Wed Jan 10 20:17:57 2018
New Revision: 322252
URL: http://llvm.org/viewvc/llvm-project?rev=322252&view=rev
Log:
[Fuchsia] Use llvm-objcopy as objcopy on non-Darwin hosts
llvm-objcopy already supports all the necessary functionality for ELF.
Differential Revision: https://rev
This revision was automatically updated to reflect the committed changes.
Closed by commit rC322252: [Fuchsia] Use llvm-objcopy as objcopy on non-Darwin
hosts (authored by phosek, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D41930
Files:
cmake/caches/Fuchsia-stage2.cmake
phosek added a comment.
In https://reviews.llvm.org/D41930#972923, @emaste wrote:
> The title is more correctly "non-Apple hosts"? I.e., building on FreeBSD will
> also use llvm-objcopy.
That's a good point, updated.
Repository:
rC Clang
https://reviews.llvm.org/D41930
rsmith added inline comments.
Comment at: clang/lib/Lex/Lexer.cpp:2012-2015
+// Skip escaped characters. Escaped newlines will already be processed by
+// getAndAdvanceChar.
+if (C == '\\')
+ C = getAndAdvanceChar(CurPtr, Result);
You can just d
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun.
Herald added subscribers: cfe-commits, a.sidorin, rnkovacs, szepet.
As suggested by Gabor in https://reviews.llvm.org/D41800, replace `{}` with `=
default` for `ProgramPoint` default constructors.
Repository:
rC Clang
http
rsmith added a comment.
In https://reviews.llvm.org/D41423#968587, @vsapsai wrote:
> OSS-Fuzz classifies the bug as medium severity security issue
Well, you should probably fix it to not do that. Any sane threat model
involving a C++ compiler should assume that if you can feed the compiler
ar
NoQ added inline comments.
Comment at: test/Analysis/cxxnewexpr-callback-inline.cpp:31-32
+// CHECK-NEXT: PostStmt
+// CHECK-NEXT: PreCall (foo)
+// CHECK-NEXT: PostCall (foo)
This ensures that there are no other callbacks after `PostStmt`, in
particular that th
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet.
Herald added subscribers: cfe-commits, rnkovacs, eraman.
Even if we later change how these callbacks work (as in
http://lists.llvm.org/pipermail/cfe-dev/2017-December/056314.html), i wanted
rsmith created this revision.
rsmith added reviewers: aaron.ballman, delesley, dblaikie.
Herald added a subscriber: sanjoy.
In C++17, guaranteed copy elision means that there isn't necessarily a
constructor call when a local variable is initialized by a function call that
returns a `scoped_locka
vsapsai marked an inline comment as done.
vsapsai added inline comments.
Comment at: clang/lib/Lex/Lexer.cpp:2026
+
+if (C == 0) {
NulCharacter = CurPtr-1;
vsapsai wrote:
> dexonsmith wrote:
> > vsapsai wrote:
> > > dexonsmith wrote:
> > > > Should thi
vsapsai marked 2 inline comments as done.
vsapsai added inline comments.
Comment at: clang/lib/Lex/Lexer.cpp:2026
+
+if (C == 0) {
NulCharacter = CurPtr-1;
dexonsmith wrote:
> vsapsai wrote:
> > dexonsmith wrote:
> > > Should this check still be skippe
vsapsai updated this revision to Diff 129379.
vsapsai added a comment.
- Add a test for null character in string/character literals.
https://reviews.llvm.org/D41423
Files:
clang/lib/Lex/Lexer.cpp
clang/test/Lexer/null-character-in-literal.c
clang/unittests/Lex/LexerTest.cpp
Index: clang
Author: ctopper
Date: Wed Jan 10 17:38:02 2018
New Revision: 322247
URL: http://llvm.org/viewvc/llvm-project?rev=322247&view=rev
Log:
[X86][Sema] Range check the constant argument for the vpshld/vpshrd builtins to
ensure it fits in 8-bits.
Modified:
cfe/trunk/lib/Sema/SemaChecking.cpp
cf
Author: ctopper
Date: Wed Jan 10 17:38:00 2018
New Revision: 322246
URL: http://llvm.org/viewvc/llvm-project?rev=322246&view=rev
Log:
[X86] Fix vpshrd builtins to require an ICE for their constant argument to
match vpshld.
Modified:
cfe/trunk/include/clang/Basic/BuiltinsX86.def
Modified: cf
Author: ctopper
Date: Wed Jan 10 17:37:57 2018
New Revision: 322244
URL: http://llvm.org/viewvc/llvm-project?rev=322244&view=rev
Log:
[X86][Sema] Remove constant range checks on on builtins that take a char.
The constant is already reduced to 8-bits by the time we get here and the
checks were ju
Author: ctopper
Date: Wed Jan 10 17:37:59 2018
New Revision: 322245
URL: http://llvm.org/viewvc/llvm-project?rev=322245&view=rev
Log:
[X86] Make -mavx512f imply -mfma and -mf16c in the frontend like it does in the
backend.
Similarly, make -mno-fma and -mno-f16c imply -mno-avx512f.
Withou this
emaste added a comment.
The title is more correctly "non-Apple hosts"? I.e., building on FreeBSD will
also use llvm-objcopy.
Repository:
rC Clang
https://reviews.llvm.org/D41930
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
phosek created this revision.
phosek added reviewers: mcgrathr, jakehehrlich.
Herald added subscribers: cfe-commits, mgorny.
llvm-objcopy already supports all the necessary functionality for ELF.
Repository:
rC Clang
https://reviews.llvm.org/D41930
Files:
cmake/caches/Fuchsia-stage2.cmake
phosek created this revision.
phosek added reviewers: mcgrathr, jakehehrlich.
Herald added subscribers: cfe-commits, mgorny.
This is currently not being used so disable it to reduce toolchain size.
Repository:
rC Clang
https://reviews.llvm.org/D41929
Files:
cmake/caches/Fuchsia-stage2.cmak
Hello everyone,
Below are some buildbot numbers for the last week of 12/31/2017 - 1/06/2018.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from gree
Hello everyone,
Below are some buildbot numbers for the week of 12/24/2017 - 12/30/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to
az marked 8 inline comments as done.
az added inline comments.
Comment at: clang/include/clang/Basic/arm_fp16.td:58
+class IInst : Inst {}
+
+// ARMv8.2-A FP16 intrinsics.
SjoerdMeijer wrote:
> There's a little bit of duplication here: the definitions above are t
GorNishanov requested changes to this revision.
GorNishanov added a comment.
This revision now requires changes to proceed.
Thank you for doing this change!
Comment at: lib/Sema/SemaCoroutine.cpp:475
+// Create a static_cast\(expr).
+static Expr *castForMoving(Sema &S, Expr *
mclow.lists added inline comments.
Comment at:
test/std/experimental/filesystem/fs.op.funcs/fs.op.remove/remove.pass.cpp:67
non_empty_dir,
-file_in_bad_dir,
+// file_in_bad_dir, // produces "St13exception_ptruncaught_exceptions
not yet implemented"
vsapsai added inline comments.
Comment at: clang/lib/CodeGen/CGCall.cpp:2321
+ ArgI.getCoerceToType() ==
+ ConvertType(isPromoted ? Ty : Arg->getType()) &&
ArgI.getDirectOffset() == 0) {
ahatanak wrote:
> Maybe a comment explainin
dschuff accepted this revision.
dschuff added a comment.
This revision is now accepted and ready to land.
The code LGTM. If there are objections to the scheme overall they can go in
tool-conventions.
Repository:
rC Clang
https://reviews.llvm.org/D41923
NoQ updated this revision to Diff 129369.
NoQ added a comment.
Rebase (getter rename).
https://reviews.llvm.org/D41406
Files:
include/clang/StaticAnalyzer/Core/Checker.h
include/clang/StaticAnalyzer/Core/CheckerManager.h
lib/StaticAnalyzer/Checkers/CheckerDocumentation.cpp
lib/StaticAna
NoQ updated this revision to Diff 129367.
NoQ added a comment.
Rebase (fix minor conflict).
https://reviews.llvm.org/D41266
Files:
lib/StaticAnalyzer/Core/ExprEngineCXX.cpp
lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp
test/Analysis/NewDelete-checker-test.cpp
test/Analysis/new-cto
Hello everyone,
LLVM buildmaster will be updated and restarted after 6 PM Pacific time
today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: phosek
Date: Wed Jan 10 16:12:02 2018
New Revision: 322242
URL: http://llvm.org/viewvc/llvm-project?rev=322242&view=rev
Log:
Revert "[Driver] Update default sanitizer blacklist location"
This reverts commit r322233: this is breaking dfsan tests.
Added:
cfe/trunk/test/Driver/Inputs/re
az updated this revision to Diff 129360.
https://reviews.llvm.org/D41792
Files:
clang/include/clang/Basic/BuiltinsNEON.def
clang/include/clang/Basic/CMakeLists.txt
clang/include/clang/Basic/arm_fp16.td
clang/include/clang/Basic/arm_neon.td
clang/include/clang/Basic/arm_neon_incl.td
cl
ahatanak updated this revision to Diff 129359.
ahatanak marked an inline comment as done.
ahatanak added a comment.
In EmitCallArg and EmitParmDecl, use the existing code for Microsoft C++ ABI to
determine whether the argument should be destructed in the callee. Also, add a
test case that checks
NoQ updated this revision to Diff 129365.
NoQ added a comment.
Rebase.
Add a FIXME to bring back the cast in the conservative case.
https://reviews.llvm.org/D41250
Files:
lib/StaticAnalyzer/Core/ExprEngineCXX.cpp
lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp
test/Analysis/new-ctor-
devnexen updated this revision to Diff 129364.
https://reviews.llvm.org/D41809
Files:
lib/Driver/ToolChains/FreeBSD.cpp
Index: lib/Driver/ToolChains/FreeBSD.cpp
===
--- lib/Driver/ToolChains/FreeBSD.cpp
+++ lib/Driver/ToolChains/
mclow.lists added a comment.
I like the fact that you've removed the extra test that you've added.
However, I think that modifying the tests as you've done is more work than is
needed.
I *suspect* that all you need to do is to move a couple of test cases from the
"calls which should fail" to the
NoQ updated this revision to Diff 129362.
NoQ added a comment.
Rename getters and setters for the new state trait (i.e. "push" -> "set", etc.,
because we no longer have a stack).
Also make them static, so that it was potentially possible to access them from
elsewhere, eg. from `CallEvent`, if d
Author: vsapsai
Date: Wed Jan 10 15:37:29 2018
New Revision: 322240
URL: http://llvm.org/viewvc/llvm-project?rev=322240&view=rev
Log:
[Lex] Inline a variable in test in preparation for more similar tests. NFC.
Modified:
cfe/trunk/unittests/Lex/LexerTest.cpp
Modified: cfe/trunk/unittests/Lex/
sbc100 updated this revision to Diff 129352.
sbc100 added a comment.
update tests
Repository:
rC Clang
https://reviews.llvm.org/D41923
Files:
lib/Driver/ToolChains/WebAssembly.cpp
test/Driver/wasm-toolchain.c
Index: test/Driver/wasm-toolchain.c
=
sbc100 created this revision.
Herald added subscribers: cfe-commits, sunfish, aheejin, jgravelle-google,
dschuff, jfb.
See: https://github.com/WebAssembly/tool-conventions/issues/35
Repository:
rC Clang
https://reviews.llvm.org/D41923
Files:
lib/Driver/ToolChains/WebAssembly.cpp
Index:
dexonsmith added inline comments.
Comment at: clang/lib/Lex/Lexer.cpp:2026
+
+if (C == 0) {
NulCharacter = CurPtr-1;
vsapsai wrote:
> dexonsmith wrote:
> > Should this check still be skipped (in an `else if` of the `C == '\\'`
> > check)?
> I agree it
vsk created this revision.
vsk added reviewers: rsmith, aaron.ballman, faisalv.
When parsing C++ type construction expressions with list initialization,
forward the locations of the braces to Sema.
Without these locations, the code coverage pass crashes on the given test
case, because the pass re
Author: rsmith
Date: Wed Jan 10 15:08:26 2018
New Revision: 322236
URL: http://llvm.org/viewvc/llvm-project?rev=322236&view=rev
Log:
In C++17, when instantiating an out-of-line definition of an inline static data
member, don't forget to instantiate the initializer too.
Modified:
cfe/trunk/lib
Author: phosek
Date: Wed Jan 10 14:59:00 2018
New Revision: 322233
URL: http://llvm.org/viewvc/llvm-project?rev=322233&view=rev
Log:
Reland "[Driver] Update default sanitizer blacklist location"
This is related to moving the sanitizer blacklists to share/
subdirectory.
Differential Revision: htt
vsapsai marked an inline comment as done.
vsapsai added inline comments.
Comment at: clang/lib/Lex/Lexer.cpp:2014-2015
+// getAndAdvanceChar.
+if (C == '\\')
+ C = getAndAdvanceChar(CurPtr, Result);
+
dexonsmith wrote:
> If `CurPtr` is already equal
ahatanak added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:11700
+}
+ }
+
ahatanak wrote:
> rsmith wrote:
> > rjmccall wrote:
> > > I think it's correct not to call CheckDestructorAccess and
> > > DiagnoseUseOfDecl here, since according to the standa
vsapsai updated this revision to Diff 129346.
vsapsai added a comment.
- Remove rdar link from the comment per review.
Also rebased on top of master so diff between diffs can be noisy.
https://reviews.llvm.org/D41423
Files:
clang/lib/Lex/Lexer.cpp
clang/unittests/Lex/LexerTest.cpp
Index:
ahatanak updated this revision to Diff 129345.
ahatanak marked 2 inline comments as done.
ahatanak added a comment.
Partially revert the changes I made to CodeGenFunction::EmitParmDecl add IRGen
test case for exception handling.
https://reviews.llvm.org/D41039
Files:
include/clang/AST/ASTCon
Author: phosek
Date: Wed Jan 10 14:20:03 2018
New Revision: 38
URL: http://llvm.org/viewvc/llvm-project?rev=38&view=rev
Log:
[libunwind] Set up .arcconfig to point to new Diffusion UNW repository
See http://lists.llvm.org/pipermail/cfe-dev/2017-November/056032.html
for related discussion
This revision was automatically updated to reflect the committed changes.
Closed by commit rL38: [libunwind] Set up .arcconfig to point to new
Diffusion UNW repository (authored by phosek, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm
benhamilton accepted this revision.
benhamilton added a comment.
This revision is now accepted and ready to land.
Too funny. I'll abandon https://reviews.llvm.org/D41917.
Repository:
rUNW libunwind
https://reviews.llvm.org/D41918
___
cfe-commits
eandrews added a comment.
Thanks for the review Reid. Sorry for the delay in my response. I was OOO.
I am not sure if a new attribute is necessary. __ attribute __(used) is already
supported in Clang. While this attribute can be used to retain static
constants, it would require the user to modi
devnexen updated this revision to Diff 129329.
https://reviews.llvm.org/D41809
Files:
lib/Driver/ToolChains/FreeBSD.cpp
Index: lib/Driver/ToolChains/FreeBSD.cpp
===
--- lib/Driver/ToolChains/FreeBSD.cpp
+++ lib/Driver/ToolChains/
This revision was automatically updated to reflect the committed changes.
Closed by commit rCRT31: [MSan] Enable use-after-dtor instrumentation by
default. (authored by morehouse, committed by ).
Herald added a subscriber: Sanitizers.
Changed prior to commit:
https://reviews.llvm.org/D37860
Author: morehouse
Date: Wed Jan 10 12:27:48 2018
New Revision: 31
URL: http://llvm.org/viewvc/llvm-project?rev=31&view=rev
Log:
[MSan] Enable use-after-dtor instrumentation by default.
Summary:
Enable the compile-time flag -fsanitize-memory-use-after-dtor by
default. Note that the run-tim
modocache added a comment.
Thanks, will do next time :)
Repository:
rC Clang
https://reviews.llvm.org/D41912
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: modocache
Date: Wed Jan 10 12:23:45 2018
New Revision: 30
URL: http://llvm.org/viewvc/llvm-project?rev=30&view=rev
Log:
[Driver] Test for correct '--version' suggestion
Summary:
The `llvm::OptTable::findNearest` bug fixed in
https://reviews.llvm.org/D41873 manifested itself as the
This revision was automatically updated to reflect the committed changes.
Closed by commit rC30: [Driver] Test for correct '--version'
suggestion (authored by modocache, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41912?vs=129314&id=129321#toc
Repository:
rC Clang
Eugene.Zelenko added inline comments.
Comment at: docs/ReleaseNotes.rst:63
+
+ The usage of ``goto`` has been discouraged for a long time and is diagnosed
+ with this check.
I think will be good idea to reformulate this statement and its copy in
documentation.
morehouse added a comment.
PTAL. Patch has been updated.
https://reviews.llvm.org/D37860
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
morehouse updated this revision to Diff 129318.
morehouse added a comment.
- Enable use-after-dtor instrumentation by default.
- Make sanitize-no-dtor-callback.cpp test fail with UAD instrumentation.
- Update test cases to reflect new default.
https://reviews.llvm.org/D37860
Files:
clang/incl
v.g.vassilev accepted this revision.
v.g.vassilev added a comment.
This revision is now accepted and ready to land.
LGMT! We can rely on post-commit reviews for changes like this one.
Repository:
rC Clang
https://reviews.llvm.org/D41912
___
cfe-c
modocache created this revision.
modocache added reviewers: v.g.vassilev, teemperor, ruiu, jroelofs, yamaguchi.
The `llvm::OptTable::findNearest` bug fixed in
https://reviews.llvm.org/D41873 manifested itself as the following
erroneous message when invoking Clang:
clang -version
clang-6.0: er
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Looks great. @dcoughlin: would you approve the warning message text?
Maybe actually we could print out the exact numbers that cause the bit shift to
overflow, since we do have them when we check.
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, mgorny, klimek.
Not enabled because we need a threadsafe way to change VFS working directories.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41911
Files:
clang
NoQ added a comment.
In https://reviews.llvm.org/D35110#969782, @baloghadamsoftware wrote:
> Strange, but modifying the tests from `m n` to `m - n
> 0` does not help. The statement `if (m - n 0)` does not store a
> range for `m - n` in the constraint manager. With the other patch which
> a
saar.raz created this revision.
saar.raz added reviewers: hubert.reinterpretcast, rsmith, nwilson, changyu,
faisalv.
Herald added a subscriber: cfe-commits.
Added support for constraint satisfaction checking and partial ordering of
constraints in constrained partial specialization and function t
NoQ added a comment.
In https://reviews.llvm.org/D35109#969712, @baloghadamsoftware wrote:
> In https://reviews.llvm.org/D35109#969109, @NoQ wrote:
>
> > I guess it'd be an `-analyzer-config` flag. You can add it to the
> > `AnalyzerOptions` object, which has access to these flags and can be
>
saar.raz updated this revision to Diff 129306.
saar.raz added a comment.
- Better handling of diagnostics in ConceptSpecializationExprs, correctly
written to and read from module files.
- Modified Error messages according to some user feedback
Updating D41569: Summary:
=
dexonsmith requested changes to this revision.
dexonsmith added inline comments.
This revision now requires changes to proceed.
Comment at: clang/lib/Lex/Lexer.cpp:2014-2015
+// getAndAdvanceChar.
+if (C == '\\')
+ C = getAndAdvanceChar(CurPtr, Result);
+
---
Author: pcc
Date: Wed Jan 10 10:16:58 2018
New Revision: 322201
URL: http://llvm.org/viewvc/llvm-project?rev=322201&view=rev
Log:
libcxx: Stop providing a definition of __GLIBC_PREREQ.
An application may determine whether the C standard library is glibc
by testing whether __GLIBC_PREREQ is define
saar.raz updated this revision to Diff 129297.
saar.raz added a comment.
- Fixed wrong if that would cause valid instantiated requires clauses to not be
accepted.
Repository:
rC Clang
https://reviews.llvm.org/D41284
Files:
include/clang/AST/DeclTemplate.h
include/clang/AST/RecursiveASTV
This revision was automatically updated to reflect the committed changes.
Closed by commit rL322199: [clangd] Pass Context to onDiagnosticsReady callback
(authored by ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D41907
Files:
Author: ibiryukov
Date: Wed Jan 10 09:59:27 2018
New Revision: 322199
URL: http://llvm.org/viewvc/llvm-project?rev=322199&view=rev
Log:
[clangd] Pass Context to onDiagnosticsReady callback
Reviewers: sammccall
Reviewed By: sammccall
Subscribers: klimek, cfe-commits
Differential Revision: https
malaperle updated this revision to Diff 129293.
malaperle added a comment.
Revert an unintentional white space change.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D38639
Files:
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
clangd/Protocol.h
clangd/SourceCode.cpp
clangd/
malaperle updated this revision to Diff 129292.
malaperle added a comment.
Store map in PremableData and copy it on reparse.
Convert SourceLoc to Position when comparing with include Positions.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D38639
Files:
clangd/ClangdUnit.cpp
malaperle added inline comments.
Comment at: clangd/ClangdUnit.cpp:113
+ CppFilePreambleCallbacks(IncludeReferenceMap &IRM)
+ : IRM(IRM) {}
ilya-biryukov wrote:
> malaperle wrote:
> > ilya-biryukov wrote:
> > > ilya-biryukov wrote:
> > > > Let's create a
ilya-biryukov created this revision.
ilya-biryukov added a reviewer: sammccall.
Herald added a subscriber: klimek.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41907
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdServer.cpp
clangd/ClangdServer.h
TyanNN added inline comments.
Comment at:
test/std/experimental/filesystem/fs.op.funcs/fs.op.remove/remove.pass.cpp:67
non_empty_dir,
-file_in_bad_dir,
+// file_in_bad_dir, // produces "St13exception_ptruncaught_exceptions
not yet implemented"
};
-
TyanNN updated this revision to Diff 129280.
TyanNN added a comment.
Fix remove and remove_all error resetting. Move test to the appropriate files
and fix old tests.
https://reviews.llvm.org/D41830
Files:
src/experimental/filesystem/operations.cpp
test/std/experimental/filesystem/fs.op.fun
alexfh added a comment.
It looks like the latest patch was lost. I'll see whether it still applies
cleanly...
https://reviews.llvm.org/D38284
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
Author: marshall
Date: Wed Jan 10 08:25:04 2018
New Revision: 322196
URL: http://llvm.org/viewvc/llvm-project?rev=322196&view=rev
Log:
Fix misspelled macro name - thanks to and...@ispras.ru for the catch
Modified:
libcxx/trunk/test/std/algorithms/alg.nonmodifying/alg.search/search.pass.cpp
M
ilya-biryukov added inline comments.
Comment at: clangd/index/SymbolCollector.cpp:80
+: decl(unless(isExpansionInMainFile())),
+hasDeclContext(anyOf(namespaceDecl(),
translationUnitDecl(),
+*D, *ASTCtx)
tbourvon marked 4 inline comments as done.
tbourvon added a comment.
(By the way, credits go to @Abpostelnicu for the latest changes regarding
MaximumLineLength interop with clang-format options)
Comment at: clang-tidy/readability/UnnecessaryIntermediateVarCheck.cpp:376
+/
tbourvon updated this revision to Diff 129278.
tbourvon added a comment.
Add retrieval of MaximumLineLength from clang-format options, otherwise
defaults to 80.
Also add unit tests around the limit case for the line length.
https://reviews.llvm.org/D37014
Files:
clang-tidy/readability/CMakeL
Author: ioeric
Date: Wed Jan 10 07:11:26 2018
New Revision: 322194
URL: http://llvm.org/viewvc/llvm-project?rev=322194&view=rev
Log:
Add a missing dependency for r322192
Modified:
clang-tools-extra/trunk/clangd/CMakeLists.txt
Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt
URL:
http
Author: ioeric
Date: Wed Jan 10 06:57:58 2018
New Revision: 322193
URL: http://llvm.org/viewvc/llvm-project?rev=322193&view=rev
Log:
[clangd] Add more filters for collected symbols.
Summary:
o We only collect symbols in namespace or translation unit scopes.
o Add an option to only collect symbols
This revision was automatically updated to reflect the committed changes.
Closed by commit rL322193: [clangd] Add more filters for collected symbols.
(authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D41823
Files:
cla
ioeric added inline comments.
Comment at: clangd/index/SymbolCollector.cpp:80
+: decl(unless(isExpansionInMainFile())),
+hasDeclContext(anyOf(namespaceDecl(),
translationUnitDecl(),
+*D, *ASTCtx)
---
ioeric updated this revision to Diff 129275.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- Merge branch 'master' of http://llvm.org/git/clang-tools-extra into collector
- Address review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41823
Files:
This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Closed by commit rCTE322191: [clangd] Add static index for the global code
completion. (authored by hokein, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41668
Author: hokein
Date: Wed Jan 10 06:44:34 2018
New Revision: 322191
URL: http://llvm.org/viewvc/llvm-project?rev=322191&view=rev
Log:
[clangd] Add static index for the global code completion.
Summary:
Use the YAML-format symbols (generated by the global-symbol-builder tool) to
do the global code c
1 - 100 of 118 matches
Mail list logo
