[PATCH] D42493: [clang-format] Fix ObjC message arguments formatting.

jolesiak added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:419 StartsObjCMethodExpr = true; + Left->ParameterCount = 0; Contexts.back().ColonIsObjCMethodExpr = true; benhamilton wrote: > What does this line do? Seems

[PATCH] D42395: [clang-format] Fix bug where -dump-config failed on ObjC header

krasimir accepted this revision. krasimir added inline comments. This revision is now accepted and ready to land. Comment at: test/Format/lit.local.cfg:1 +# Suffixes supported by clang-format. +config.suffixes = ['.c', '.cc', '.cpp', '.h', '.m', '.mm', '.java', '.js', ---

[PATCH] D42575: [clangd] Better handling symbols defined in macros.

ioeric added inline comments. Comment at: clangd/index/SymbolCollector.cpp:108 +std::string PrintableLoc(SourceLocation Loc, SourceManager &SM) { + if (Loc.isInvalid()) `PrintLoc`? `PrintableLoc` sounds like a checker for whether a location is printable. ==

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan marked 4 inline comments as done. yvvan added a comment. @ilya-biryukov Thanks a lot for you comments and for the provided code replacement. I'm checking now how it works and will continue addressing other comments. https://reviews.llvm.org/D41537 __

[PATCH] D42638: [clangd] Add a fallback directory for collected symbols with relative paths.

ioeric created this revision. ioeric added reviewers: hokein, sammccall. Herald added subscribers: cfe-commits, jkorous-apple, ilya-biryukov, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42638 Files: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp clangd/in

[PATCH] D42174: [clangd] Refactored threading in ClangdServer

ilya-biryukov added inline comments. Comment at: clangd/ClangdServer.h:177 +/// preambles and ASTs) for opened files. +class Scheduler { +public: ilya-biryukov wrote: > ilya-biryukov wrote: > > sammccall wrote: > > > sammccall wrote: > > > > This class has import

[PATCH] D41720: [clang-tidy] Add a -show-color flag.

aaron.ballman added inline comments. Comment at: clang-tidy/tool/ClangTidyMain.cpp:150-152 +Show color diagnostics. If not specified, +defaults to on when a color-capable terminal +is detected.)"), itessier wrote: > itessier wrote: > > aaron.ballman wrote: > > >

[PATCH] D42419: [clangd] Use new URI with scheme support in place of the existing LSP URI

ioeric updated this revision to Diff 131775. ioeric added a comment. - Merge remote-tracking branch 'origin/master' into uri Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42419 Files: clangd/ClangdLSPServer.cpp clangd/Protocol.cpp clangd/Protocol.h clangd/URI.cpp cla

[PATCH] D42623: [clang-tidy] Add a Lexer util to get the source text of a statement

aaron.ballman added inline comments. Comment at: clang-tidy/utils/LexerUtils.cpp:39 +Optional getStmtText(const Stmt* Statement, const SourceManager& SM) { + if (!Statement) { +return llvm::NoneType(); You should elide the curly braces here. =

[PATCH] D42577: [Lexer] Support adding working directory to relative search dir for #include shortening in HeaderSearch.

bkramer accepted this revision. bkramer added inline comments. This revision is now accepted and ready to land. Comment at: include/clang/Lex/HeaderSearch.h:708 + /// + /// \param WorkingDir If non-empty, this will be prepend to search directory + /// paths that are relative.

[PATCH] D42174: [clangd] Refactored threading in ClangdServer

sammccall added a subscriber: hokein. sammccall added inline comments. Comment at: clangd/ClangdServer.h:177 +/// preambles and ASTs) for opened files. +class Scheduler { +public: ilya-biryukov wrote: > ilya-biryukov wrote: > > ilya-biryukov wrote: > > > sammccal

r323647 - [Lexer] Support adding working directory to relative search dir for #include shortening in HeaderSearch.

Author: ioeric Date: Mon Jan 29 05:21:23 2018 New Revision: 323647 URL: http://llvm.org/viewvc/llvm-project?rev=323647&view=rev Log: [Lexer] Support adding working directory to relative search dir for #include shortening in HeaderSearch. Reviewers: bkramer Subscribers: mgorny, hintonda, cfe-com

[PATCH] D42639: [clang-move] Clever on handling header file which includes itself.

hokein created this revision. hokein added a reviewer: ioeric. Herald added a subscriber: klimek. Previously, we assume only old.cc includes "old.h", which would introduce incorrect fixes for the cases where old.h also includes `#include "old.h"` Although it should not be occurred in real projec

[PATCH] D42577: [Lexer] Support adding working directory to relative search dir for #include shortening in HeaderSearch.

This revision was automatically updated to reflect the committed changes. Closed by commit rL323647: [Lexer] Support adding working directory to relative search dir for #include… (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.l

[PATCH] D42577: [Lexer] Support adding working directory to relative search dir for #include shortening in HeaderSearch.

This revision was automatically updated to reflect the committed changes. Closed by commit rC323647: [Lexer] Support adding working directory to relative search dir for #include… (authored by ioeric, committed by ). Changed prior to commit: https://reviews.llvm.org/D42577?vs=131777&id=131781#to

[PATCH] D42577: [Lexer] Support adding working directory to relative search dir for #include shortening in HeaderSearch.

ioeric updated this revision to Diff 131777. ioeric marked 2 inline comments as done. ioeric added a comment. - Addressed review comments. Repository: rC Clang https://reviews.llvm.org/D42577 Files: include/clang/Lex/HeaderSearch.h lib/Lex/HeaderSearch.cpp unittests/Lex/CMakeLists.txt

[PATCH] D42624: [clang-tidy] Add a utility Matcher to match the next statement within a statement sequence

aaron.ballman added inline comments. Comment at: clang-tidy/utils/Matchers.h:16 +#include "clang/ASTMatchers/ASTMatchFinder.h" +#include "clang/Analysis/CFG.h" This will require linking in the clangAnalysis library as well; are we sure we want to take on this

[PATCH] D42640: [clangd] Prototype: collect symbol #include & insert #include in global code completion.

ioeric created this revision. Herald added subscribers: cfe-commits, hintonda, jkorous-apple, ilya-biryukov, mgorny, klimek. o Collect suitable #include paths for index symbols. This also does smart mapping for STL symbols and IWYU pragma. o For global code completion, add a command for insertin

[PATCH] D42641: [MinGW] Emit typeinfo locally for dllimported classes without key functions

mstorsjo created this revision. mstorsjo added reviewers: rnk, majnemer, compnerd, smeenai. This fixes building Qt as shared libraries with clang in MinGW mode; previously subclasses of the QObjectData class (in other DLLs than the base DLL) failed to find the typeinfo symbols (that neither were

[PATCH] D42641: [MinGW] Emit typeinfo locally for dllimported classes without key functions

mstorsjo updated this revision to Diff 131783. mstorsjo added a comment. Remove a few accidentally leftover parts of the new testcase. https://reviews.llvm.org/D42641 Files: lib/CodeGen/CGVTables.cpp test/CodeGenCXX/dllimport-missing-key.cpp test/CodeGenCXX/dllimport-rtti.cpp test/CodeG

[PATCH] D42638: [clangd] Add a fallback directory for collected symbols with relative paths.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:41 +llvm::cl::desc( +"For symbols' file paths that cannot be resolved to absolute "

[PATCH] D42642: [CUDA] Detect installation in PATH

Hahnfeld created this revision. Hahnfeld added reviewers: jlebar, tra. Herald added a subscriber: cfe-commits. If the CUDA toolkit is not installed to its default locations in /usr/local/cuda, the user is forced to specify --cuda-path. This is tedious and the driver can be smarter if well-known to

[clang-tools-extra] r323652 - [clangd] Fixed null deference on invalid compile commands.

Author: ibiryukov Date: Mon Jan 29 06:30:28 2018 New Revision: 323652 URL: http://llvm.org/viewvc/llvm-project?rev=323652&view=rev Log: [clangd] Fixed null deference on invalid compile commands. Code building the AST expected that construction of CompilerInstance always succeeds. This is not the

[PATCH] D42644: [asan] Intercept std::rethrow_exception indirectly.

robot created this revision. robot added a reviewer: cryptoad. robot added a project: Sanitizers. Herald added subscribers: Sanitizers, llvm-commits, hintonda, mgorny, kubamracek. Fixes Bug 32434 See https://bugs.llvm.org/show_bug.cgi?id=32434 Short summary: std::rethrow_exception does not use _

[PATCH] D42419: [clangd] Use new URI with scheme support in place of the existing LSP URI

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Can you also remove the URI-encoding hack from the VSCode client? Comment at: clangd/Protocol.cpp:35 +} +auto Resolved = URI::resolve(*U); +if (!Resolved) {

[PATCH] D42638: [clangd] Add a fallback directory for collected symbols with relative paths.

ioeric updated this revision to Diff 131799. ioeric marked 3 inline comments as done. ioeric added a comment. - Addressed review comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42638 Files: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp clangd/index/Symbo

[PATCH] D42638: [clangd] Add a fallback directory for collected symbols with relative paths.

ioeric added inline comments. Comment at: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:41 +llvm::cl::desc( +"For symbols' file paths that cannot be resolved to absolute " +"paths (i.e. in-memory VFS without absolute paths), " sammc

[clang-tools-extra] r323658 - [clangd] Add a fallback directory for collected symbols with relative paths.

Author: ioeric Date: Mon Jan 29 07:13:29 2018 New Revision: 323658 URL: http://llvm.org/viewvc/llvm-project?rev=323658&view=rev Log: [clangd] Add a fallback directory for collected symbols with relative paths. Reviewers: hokein, sammccall Subscribers: klimek, ilya-biryukov, jkorous-apple, cfe-co

[PATCH] D42638: [clangd] Add a fallback directory for collected symbols with relative paths.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE323658: [clangd] Add a fallback directory for collected symbols with relative paths. (authored by ioeric, committed by ). Changed prior to commit: https://reviews.llvm.org/D42638?vs=131799&id=131800#t

[PATCH] D42638: [clangd] Add a fallback directory for collected symbols with relative paths.

This revision was automatically updated to reflect the committed changes. Closed by commit rL323658: [clangd] Add a fallback directory for collected symbols with relative paths. (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.ll

[PATCH] D42419: [clangd] Use new URI with scheme support in place of the existing LSP URI

ioeric updated this revision to Diff 131802. ioeric marked an inline comment as done. ioeric added a comment. - addressed review comments; removed URI hack in vscode extenstion. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42419 Files: clangd/ClangdLSPServer.cpp clangd/Pr

[PATCH] D42419: [clangd] Use new URI with scheme support in place of the existing LSP URI

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE323660: [clangd] Use new URI with scheme support in place of the existing LSP URI (authored by ioeric, committed by ). Changed prior to commit: https://reviews.llvm.org/D42419?vs=131802&id=131803#toc

[clang-tools-extra] r323660 - [clangd] Use new URI with scheme support in place of the existing LSP URI

Author: ioeric Date: Mon Jan 29 07:37:46 2018 New Revision: 323660 URL: http://llvm.org/viewvc/llvm-project?rev=323660&view=rev Log: [clangd] Use new URI with scheme support in place of the existing LSP URI Summary: o Replace the existing clangd::URI with a wrapper of FileURI which also carries a

[PATCH] D42366: [CodeGen] Fix generation of TBAA tags for may-alias accesses

kosarev added inline comments. Comment at: lib/CodeGen/CodeGenTBAA.h:67 /* BaseType= */ nullptr, /* AccessType= */ nullptr, - /* Offset= */ 0, /* Size= */ 0); + /* Offset= */ 0, /* Size= */ UINT64_MAX);

[PATCH] D42578: [AMDGPU] Add ds_fadd, ds_fmin, ds_fmax builtins functions

arsenm added inline comments. Comment at: include/clang/Basic/BuiltinsAMDGPU.def:96-98 +BUILTIN(__builtin_amdgcn_ds_fadd, "ff*3fiib", "nc") +BUILTIN(__builtin_amdgcn_ds_fmin, "ff*3fiib", "nc") +BUILTIN(__builtin_amdgcn_ds_fmax, "ff*3fiib", "nc") These are definit

[PATCH] D42645: New simple Checker for mmap calls

devnexen created this revision. devnexen added reviewers: dcoughlin, dergachev.a. devnexen created this object with visibility "All Users". Herald added subscribers: cfe-commits, hintonda, mgorny. This new checker tests if both PROT_WRITE and PROT_EXEC have been set. Repository: rC Clang http

Re: [clang-tools-extra] r323149 - [clangd] Drop ~destructor completions - rarely helpful and work inconsistently

Any chance of making this a really low priority completion? (maybe just leaving in a FIXME or expected-fail check of some kind if it's not practical to implement it right now) For those handful of times when you actually want to do this. On Mon, Jan 22, 2018 at 1:06 PM Sam McCall via cfe-commits <

[PATCH] D16403: Add scope information to CFG

m.ostapenko added a comment. Hi Artem, In https://reviews.llvm.org/D16403#989451, @NoQ wrote: > Hmm. @m.ostapenko @szepet @mgehre - I think it might be a good time to figure > out if `ScopeBegin`/`ScopeEnd`, `LoopEntrance`/`LoopExit`, `LifetimeEnds`, > `AutomaticObjectDtor` elements work nicel

[PATCH] D16403: Add scope information to CFG

m.ostapenko added a comment. Actually upload the files. F5792949: CFG-scopes-destructors-loopexit.dot F5792948: CFG-scopes-loopexit-lifetime.dot Repository: rL LLVM https://reviews.llvm.org/D16403 ___

[PATCH] D42645: New simple Checker for mmap calls

jroelofs added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp:1 +// MmapWriteExecChecker.cpp - Check for the prot argument +// Needs one of these at the top: ``` //===- MmapWriteExecChecker.cpp - Check the mmap prot argument -

r323664 - [analyzer] Fix -x language argument for C preprocessed sources

Author: jroelofs Date: Mon Jan 29 08:37:53 2018 New Revision: 323664 URL: http://llvm.org/viewvc/llvm-project?rev=323664&view=rev Log: [analyzer] Fix -x language argument for C preprocessed sources clang's -x option doesn't accept c-cpp-output as a language (even though 463eb6ab was merged, the d

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 131813. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp Index: lib/StaticAnalyzer/Checkers

r323665 - [scan-build] Add an option to skip overriding CC and CXX make vars

Author: jroelofs Date: Mon Jan 29 08:49:34 2018 New Revision: 323665 URL: http://llvm.org/viewvc/llvm-project?rev=323665&view=rev Log: [scan-build] Add an option to skip overriding CC and CXX make vars Autoconf and some other systems tend to add essential compilation options to CC (e.g. -std=gnu9

[PATCH] D42645: New simple Checker for mmap calls

devnexen added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp:10 +// +// This checker detects a common memory allocation security flaw. +// Suppose 'unsigned int n' comes from an untrusted source. If the jroelofs wrote: > This c

[PATCH] D42641: [MinGW] Emit typeinfo locally for dllimported classes without key functions

majnemer added inline comments. Comment at: lib/CodeGen/CGVTables.cpp:887-888 + if (CGM.getTriple().isWindowsGNUEnvironment() && RD->hasAttr()) +return true; + Maybe a comment like "VTables of classes declared as dllimport are always considered to be ext

[PATCH] D42645: New simple Checker for mmap calls

jroelofs added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp:1 +// MmapWriteExecChecker.cpp - Check for the prot argument +// jroelofs wrote: > Needs one of these at the top: > > ``` > //===- MmapWriteExecChecker.cpp - Check t

[PATCH] D42493: [clang-format] Fix ObjC message arguments formatting.

benhamilton added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:419 StartsObjCMethodExpr = true; + Left->ParameterCount = 0; Contexts.back().ColonIsObjCMethodExpr = true; jolesiak wrote: > benhamilton wrote: > > What do

[PATCH] D42639: [clang-move] Clever on handling header file which includes itself.

ioeric added inline comments. Comment at: clang-move/ClangMove.cpp:708 +// Find old.h includes "old.h". +if (AbsoluteOldHeader == AbsoluteOldHeader) { + OldHeaderIncludeRangeInHeader = IncludeFilenameRange; This check is always true? ==

[PATCH] D42343: [coroutines] Fix application of NRVO to Coroutine "Gro" or return object.

GorNishanov accepted this revision. GorNishanov added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D42343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D42645: New simple Checker for mmap calls

a.sidorin added a comment. Hello David, Do you have any results of this checker on the real code? If yes, could you please share them? There are also some inline comments regarding implementation. Comment at: lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp:42 + +void Mma

r323668 - [clang-format] Fix bug where -dump-config failed on ObjC header

Author: benhamilton Date: Mon Jan 29 09:36:43 2018 New Revision: 323668 URL: http://llvm.org/viewvc/llvm-project?rev=323668&view=rev Log: [clang-format] Fix bug where -dump-config failed on ObjC header Summary: `clang-format -dump-config path/to/file.h` never passed anything for the Code paramete

[PATCH] D42395: [clang-format] Fix bug where -dump-config failed on ObjC header

This revision was automatically updated to reflect the committed changes. benhamilton marked an inline comment as done. Closed by commit rC323668: [clang-format] Fix bug where -dump-config failed on ObjC header (authored by benhamilton, committed by ). Changed prior to commit: https://reviews.l

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

benhamilton requested changes to this revision. benhamilton added inline comments. This revision now requires changes to proceed. Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:115 + +bool prefixedPropertyNameMatches(const llvm::StringRef &PropertyName, +

[PATCH] D42614: AST: support ObjC lifetime qualifiers in MS ABI

compnerd added a comment. Hmm, the only thing that we could fake would be namespaces on the parameter types. Is that better? I'm not tied to re-using the existing mangling. Repository: rC Clang https://reviews.llvm.org/D42614 ___ cfe-commits m

[PATCH] D42649: [clang-format] Add more tests for ObjC protocol list formatting behavior

benhamilton created this revision. benhamilton added reviewers: krasimir, jolesiak. Herald added subscribers: cfe-commits, klimek. The existing unit tests in FormatTestObjC.cpp didn't fully cover all the cases for protocol confirmance list formatting. This extends the unit tests to more cases of

[PATCH] D42578: [AMDGPU] Add ds_fadd, ds_fmin, ds_fmax builtins functions

dfukalov updated this revision to Diff 131820. dfukalov added a comment. fixed builtins descriptions Repository: rC Clang https://reviews.llvm.org/D42578 Files: include/clang/Basic/BuiltinsAMDGPU.def test/CodeGenOpenCL/builtins-amdgcn-vi.cl Index: test/CodeGenOpenCL/builtins-amdgcn-vi.

Re: [clang-tools-extra] r323149 - [clangd] Drop ~destructor completions - rarely helpful and work inconsistently

On Mon, Jan 29, 2018 at 5:31 PM, David Blaikie wrote: > Any chance of making this a really low priority completion? > (Just for clarity - this is a postfilter in clangd only, we haven't changed the behavior of the Sema or libclang APIs) We certainly have considered downranking such items, maybe

[PATCH] D42650: [clang-format] New format param BinPackObjCProtocolList

benhamilton created this revision. benhamilton added reviewers: krasimir, jolesiak, stephanemoore. This is an alternative approach to https://reviews.llvm.org/D42014 after some investigation by stephanemoore@ and myself. Previously, the format parameter `BinPackParameters` controlled both C funct

[PATCH] D42014: Disable BinPackArguments and BinPackParameters in Google Objective-C style ⚙️

benhamilton added a comment. Check out https://reviews.llvm.org/D42650 for an alternative approach. https://reviews.llvm.org/D42014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42493: [clang-format] Fix ObjC message arguments formatting.

jolesiak updated this revision to Diff 131825. jolesiak added a comment. - Add comment explaining ParameterCount reset. Repository: rC Clang https://reviews.llvm.org/D42493 Files: lib/Format/ContinuationIndenter.cpp lib/Format/FormatToken.h lib/Format/TokenAnnotator.cpp unittests/For

[PATCH] D42614: AST: support ObjC lifetime qualifiers in MS ABI

rjmccall added a comment. In https://reviews.llvm.org/D42614#990808, @compnerd wrote: > Hmm, the only thing that we could fake would be namespaces on the parameter > types. Is that better? I'm not tied to re-using the existing mangling. I'm just worried about re-using the existing mangling c

[PATCH] D42614: AST: support ObjC lifetime qualifiers in MS ABI

compnerd added a comment. Yeah, Im afraid I cannot definitely say that will never be sensible. I think I would, in fact, prefer an alternative. I'm just not sure what is a good viable alternative, especially since we are constrained in what the grammar accepts. The desugaring of the `id` and

[PATCH] D42493: [clang-format] Fix ObjC message arguments formatting.

benhamilton accepted this revision. benhamilton added a comment. shipit Repository: rC Clang https://reviews.llvm.org/D42493 ___ cfe-commits mailing

[libclc] r323677 - math.h: Set HAVE_HW_FMA32 based on compiler provided macro

Author: jvesely Date: Mon Jan 29 11:05:08 2018 New Revision: 323677 URL: http://llvm.org/viewvc/llvm-project?rev=323677&view=rev Log: math.h: Set HAVE_HW_FMA32 based on compiler provided macro Fixes sin/cos piglits on non-FMA capable asics. Bugzilla: https://bugs.llvm.org/show_bug.cgi?id=35983 R

Re: [libclc] r323677 - math.h: Set HAVE_HW_FMA32 based on compiler provided macro

On Mon, Jan 29, 2018 at 10:05 PM, Jan Vesely via cfe-commits wrote: > Author: jvesely > Date: Mon Jan 29 11:05:08 2018 > New Revision: 323677 > > URL: http://llvm.org/viewvc/llvm-project?rev=323677&view=rev > Log: > math.h: Set HAVE_HW_FMA32 based on compiler provided macro > > Fixes sin/cos pigli

[PATCH] D42651: [clang-format] Disable some text proto delimiters and functions for google style

krasimir created this revision. krasimir added a reviewer: sammccall. Herald added subscribers: cfe-commits, klimek. This disables some of the most commonly used text proto delimiters and functions for google style until we resolve several style options for that style. In particular, wheter there

r323678 - [clang-format] Disable some text proto delimiters and functions for google style

Author: krasimir Date: Mon Jan 29 11:28:05 2018 New Revision: 323678 URL: http://llvm.org/viewvc/llvm-project?rev=323678&view=rev Log: [clang-format] Disable some text proto delimiters and functions for google style Summary: This disables some of the most commonly used text proto delimiters and f

[PATCH] D42651: [clang-format] Disable some text proto delimiters and functions for google style

This revision was automatically updated to reflect the committed changes. Closed by commit rL323678: [clang-format] Disable some text proto delimiters and functions for google style (authored by krasimir, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://revi

r323679 - [NFC] Fixup comment with function name, actually incorrect name!

Author: erichkeane Date: Mon Jan 29 11:33:20 2018 New Revision: 323679 URL: http://llvm.org/viewvc/llvm-project?rev=323679&view=rev Log: [NFC] Fixup comment with function name, actually incorrect name! Modified: cfe/trunk/lib/Sema/SemaOverload.cpp Modified: cfe/trunk/lib/Sema/SemaOverload.cp

[PATCH] D42408: [clang-format] Align preprocessor comments with #

krasimir added inline comments. Comment at: unittests/Format/FormatTest.cpp:2613 Style)); - // FIXME: The comment indent corrector in TokenAnnotator gets thrown off by - // preprocessor indentation. - EXPECT_EQ("#if 1\n" -" // comment\n" -

Re: [clang-tools-extra] r323149 - [clangd] Drop ~destructor completions - rarely helpful and work inconsistently

Fair - maybe just a comment in the test case (and/or the source code that handles this) saying "hey, let's make sure dtors aren't here - but if/when there's support for a low priority completion group, these should appear there" or the like. On Mon, Jan 29, 2018 at 9:49 AM Sam McCall wrote: > On

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42641: [MinGW] Emit typeinfo locally for dllimported classes without key functions

mstorsjo added inline comments. Comment at: lib/CodeGen/CGVTables.cpp:887-888 + if (CGM.getTriple().isWindowsGNUEnvironment() && RD->hasAttr()) +return true; + majnemer wrote: > Maybe a comment like "VTables of classes declared as dllimport are always >

r323684 - [clang-format] Add more tests for ObjC protocol list formatting behavior

Author: benhamilton Date: Mon Jan 29 12:01:49 2018 New Revision: 323684 URL: http://llvm.org/viewvc/llvm-project?rev=323684&view=rev Log: [clang-format] Add more tests for ObjC protocol list formatting behavior Summary: The existing unit tests in FormatTestObjC.cpp didn't fully cover all the case

[PATCH] D42642: [CUDA] Detect installation in PATH

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Some linux distributions integrate CUDA into the standard directory structure. I.e. binaries go into /usr/bin, headers into /usr/include, bitcode goes somewhere else, etc. ptxas will be found, but w

[PATCH] D42649: [clang-format] Add more tests for ObjC protocol list formatting behavior

This revision was automatically updated to reflect the committed changes. Closed by commit rL323684: [clang-format] Add more tests for ObjC protocol list formatting behavior (authored by benhamilton, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.l

[PATCH] D42649: [clang-format] Add more tests for ObjC protocol list formatting behavior

This revision was automatically updated to reflect the committed changes. Closed by commit rC323684: [clang-format] Add more tests for ObjC protocol list formatting behavior (authored by benhamilton, committed by ). Changed prior to commit: https://reviews.llvm.org/D42649?vs=131821&id=131840#to

[PATCH] D42650: [clang-format] New format param BinPackObjCProtocolList

benhamilton updated this revision to Diff 131841. benhamilton added a comment. Rebase Repository: rC Clang https://reviews.llvm.org/D42650 Files: include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp lib/Format/Format.cpp unittests/Format/FormatTestObjC.cpp Index: unitte

[PATCH] D42642: [CUDA] Detect installation in PATH

jlebar added a comment. Can we document this behavior in https://llvm.org/docs/CompileCudaWithLLVM.html (in the LLVM repo)? Totally fine if you want to do this in a separate patch. Repository: rC Clang https://reviews.llvm.org/D42642 ___ cfe-co

[PATCH] D41553: Support parsing double square-bracket attributes in ObjC

aaron.ballman updated this revision to Diff 131860. aaron.ballman added a comment. Updates based on review feedback. https://reviews.llvm.org/D41553 Files: include/clang/Basic/Attr.td include/clang/Parse/Parser.h lib/Parse/ParseObjc.cpp lib/Parse/Parser.cpp test/Misc/ast-dump-attr.m

[PATCH] D41553: Support parsing double square-bracket attributes in ObjC

aaron.ballman marked 5 inline comments as done. aaron.ballman added inline comments. Comment at: lib/Parse/ParseObjc.cpp:1434 MaybeParseGNUAttributes(paramAttrs); - ArgInfo.ArgAttrs = paramAttrs.getList(); } rjmccall wrote: > ObjC parameter syn

[libcxx] r323694 - Minor updated to the main libcxx page; add a link to the deprecation page

Author: marshall Date: Mon Jan 29 13:28:46 2018 New Revision: 323694 URL: http://llvm.org/viewvc/llvm-project?rev=323694&view=rev Log: Minor updated to the main libcxx page; add a link to the deprecation page Modified: libcxx/trunk/www/index.html Modified: libcxx/trunk/www/index.html URL: h

[PATCH] D42642: [CUDA] Detect installation in PATH

Hahnfeld added a comment. In https://reviews.llvm.org/D42642#990976, @tra wrote: > Some linux distributions integrate CUDA into the standard directory > structure. I.e. binaries go into /usr/bin, headers into /usr/include, bitcode > goes somewhere else, etc. ptxas will be found, but we would st

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

Wizard updated this revision to Diff 131869. Wizard added a comment. resolve comments and fix some logic Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42464 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp docs/clang-tidy/checks/objc-property-declaration.rst test/clan

[PATCH] D42642: [CUDA] Detect installation in PATH

tra added a comment. In https://reviews.llvm.org/D42642#991127, @Hahnfeld wrote: > In https://reviews.llvm.org/D42642#990976, @tra wrote: > > > Some linux distributions integrate CUDA into the standard directory > > structure. I.e. binaries go into /usr/bin, headers into /usr/include, > > bitco

r323696 - [analyzer] [NFC] Remove unused method visitItemsInWorkList

Author: george.karpenkov Date: Mon Jan 29 13:44:49 2018 New Revision: 323696 URL: http://llvm.org/viewvc/llvm-project?rev=323696&view=rev Log: [analyzer] [NFC] Remove unused method visitItemsInWorkList Differential Revision: https://reviews.llvm.org/D42562 Modified: cfe/trunk/include/clang/S

r323697 - [analyzer] Use stable filenames in analyzer testing infrastructure

Author: george.karpenkov Date: Mon Jan 29 13:45:07 2018 New Revision: 323697 URL: http://llvm.org/viewvc/llvm-project?rev=323697&view=rev Log: [analyzer] Use stable filenames in analyzer testing infrastructure Makes finding the right file in test results easier. Differential Revision: https://re

Re: r323485 - [Driver] Add an -fexperimental-isel driver option to enable/disable GlobalISel.

Hi Hans, Can we have this for the 6.0 branch? I'm also going to send a patch to add the release notes clang and LLVM about this flag and GISel being enabled at -O0. Cheers, Amara On 25 January 2018 at 16:27, Amara Emerson via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: aemerson >

Re: [PATCH] [analyzer] Fix -x language argument for C preprocessed sources

r323664 On Mon, Jan 15, 2018 at 8:35 AM, Jonathan Roelofs wrote: > LGTM. Would you like me to commit it for you? > > > Jon > > > On 1/14/18 3:50 AM, Paul Fertser wrote: > >> clang's -x option doesn't accept c-cpp-output as a language (even though >> 463eb6ab was merged, the driver still doesn't

[PATCH] D41553: Support parsing double square-bracket attributes in ObjC

rjmccall added inline comments. Comment at: lib/Parse/ParseObjc.cpp:1434 MaybeParseGNUAttributes(paramAttrs); - ArgInfo.ArgAttrs = paramAttrs.getList(); } aaron.ballman wrote: > rjmccall wrote: > > ObjC parameter syntax is really its own weird

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

benhamilton accepted this revision. benhamilton added inline comments. This revision is now accepted and ready to land. Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:123 + size_t Start = PropertyName.find_first_of('_'); + assert(Start != llvm::StringRef::npos); + au

Re: [clang-tools-extra] r323658 - [clangd] Add a fallback directory for collected symbols with relative paths.

Hello Eric, It look like some of your recent commits broke the test on one of our builders: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast . . . Failing Tests (1): Extra Tools Unit Tests :: clangd/./ClangdTests.exe/SymbolCollectorTest.SymbolRelativeWithFallb

[PATCH] D42660: [PR32482] Fix bitfield layout for -mms-bitfield and pragma pack

arphaman created this revision. arphaman added reviewers: ahatanak, rjmccall. Herald added a subscriber: jkorous-apple. Clang currently generates wrong record layout for `-mms-bitfield` and `#pragma pack`. https://godbolt.org/g/nQ4rVW shows how MSVC and GCC generate different layout to Clang. T

[PATCH] D41885: [libcxxabi][demangler] Improve handling of variadic templates

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM once you clean up the `#if 0`. Comment at: src/cxa_demangle.cpp:260-261 + +#if 0 + void dump() const { +char *Buffer = static_cast(std::malloc(1024)); -

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

Wizard updated this revision to Diff 131877. Wizard marked 2 inline comments as done. Wizard added a comment. add more tests Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42464 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp docs/clang-tidy/checks/objc-property-declara

[clang-tools-extra] r323703 - [clangd] Fix r323658 test failure on windows.

Author: ioeric Date: Mon Jan 29 14:28:08 2018 New Revision: 323703 URL: http://llvm.org/viewvc/llvm-project?rev=323703&view=rev Log: [clangd] Fix r323658 test failure on windows. Modified: clang-tools-extra/trunk/unittests/clangd/SymbolCollectorTests.cpp clang-tools-extra/trunk/unittests/

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

benhamilton accepted this revision. benhamilton added a comment. Thanks! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42464 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

Re: [clang-tools-extra] r323658 - [clangd] Add a fallback directory for collected symbols with relative paths.

Thanks Galina! r323703 should fix this. On Mon, Jan 29, 2018 at 11:09 PM Galina Kistanova wrote: > Hello Eric, > > It look like some of your recent commits broke the test on one of our > builders: > > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast > . . . > Fa

[PATCH] D42578: [AMDGPU] Add ds_fadd, ds_fmin, ds_fmax builtins functions

b-sumner added a comment. Should we expect that the last 3 arguments have any effect? Do we want to test to ensure they have the expected effects? Repository: rC Clang https://reviews.llvm.org/D42578 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D41318: Start setting dso_local in clang

espindola updated this revision to Diff 131878. espindola added a comment. Rebased. Ping https://reviews.llvm.org/D41318 Files: clang/lib/CodeGen/CGDecl.cpp clang/lib/CodeGen/CGVTT.cpp clang/lib/CodeGen/CGVTables.cpp clang/lib/CodeGen/CodeGenModule.cpp clang/lib/CodeGen/CodeGenModule.

  1   2   >