mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM. Do you need me to commit this?
https://reviews.llvm.org/D41629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
jakehehrlich accepted this revision.
jakehehrlich added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D43404
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325446: [X86] Add 'sahf' CPU feature to frontend
(authored by dim, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D43394
Files:
cfe/trunk/inclu
Author: dim
Date: Sat Feb 17 13:04:35 2018
New Revision: 325446
URL: http://llvm.org/viewvc/llvm-project?rev=325446&view=rev
Log:
[X86] Add 'sahf' CPU feature to frontend
Summary:
Make clang accept `-msahf` (and `-mno-sahf`) flags to activate the
`+sahf` feature for the backend, for bug 36028 (In
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D43394
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lg. Thanks!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43429
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
dim updated this revision to Diff 134808.
dim added a comment.
Remove the `__LAHFSAHF__` predefined macro.
Repository:
rC Clang
https://reviews.llvm.org/D43394
Files:
include/clang/Driver/Options.td
lib/Basic/Targets/X86.cpp
lib/Basic/Targets/X86.h
test/CodeGen/attr-target-x86.c
Ind
khuttun updated this revision to Diff 134802.
khuttun added a comment.
I changed the checker to use hasAnyName. Checking for `unique_ptr::release()`
and all the `empty()` functions is removed.
The checker doesn't report any warnings from LLVM + clang codebases now.
https://reviews.llvm.org/D41
aaron.ballman added inline comments.
Comment at: clang-tidy/fuchsia/AddVisibilityCheck.cpp:68
+ diag(MatchedDecl->getLocStart(),
+ "visibility attribute not set for specified function")
+ << MatchedDecl
jakehehrlich wrote:
> aaron.ballman
lebedev.ri added a comment.
Ping.
Repository:
rC Clang
https://reviews.llvm.org/D43162
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
asb added a comment.
In https://reviews.llvm.org/D43105#1003709, @efriedma wrote:
> So you want int128_t for compiler-rt itself, so you can use the soft-float
> implementation, but you want to make int128_t opt-in to avoid the possibility
> of someone getting a link error trying to link code bu
lebedev.ri added a comment.
Nice work!
It will be great to have a replacement for doxygen, which is actually modern
and usable.
Some review notes for some of the code below:
Comment at: clang-doc/ClangDocBinary.cpp:17
+
+enum BlockIds {
+ NAMESPACE_BLOCK_ID = bitc::FIRST_APP
lebedev.ri added a comment.
It will be good to have the tests for generators.
Comment at: clang-doc/generators/Generators.h:28
+public:
+ Generator(std::unique_ptr &IS, StringRef Root, StringRef Format) :
IS(IS), Root(Root), Format(Format) {};
+ virtual ~Generator() {};
lebedev.ri added a comment.
I don't know the protocol, but i think it might be a good idea
to add a new entry to `CODE_OWNERS.TXT` for `clang-doc`?
`clang-doc` going to be quite distinctive, and bigger/complicated
than what already is in `clang-tools-extra`.
https://reviews.llvm.org/D41102
_
kimgr added a comment.
Peanut gallery observation: there was a discussion on the Boost list years and
years ago where someone made the case that `if (x != nullptr) delete x;` was
measurably faster than just calling `delete x;` I can't find it now, but I
think it might have been in the context o
kimgr added a comment.
Herald added a subscriber: kristof.beyls.
Ping! It would be nice to get some traction on this.
https://reviews.llvm.org/D31696
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
Hahnfeld added a comment.
Let's start with the obvious points:
1. The latest patch clearly wasn't run through `clang-format`.
2. It only has some 90 lines of context which makes it look like you deleted
quite some code when browsing through the history.
3. This patch is still large, did you at l
Hahnfeld added a comment.
Looking more closely at the patch, this doesn't seem to look into the `lib` /
`lib64` next to the compiler. I'm not sure if `LIBRARY_PATH` is set for every
installation, so I think we should add this one to catch the obvious case. This
probably needs some attention for
Hi Alexey,
I think that's mostly my test case from PR35348?
Am 2018-02-16 22:23, schrieb Alexey Bataev via cfe-commits:
Author: abataev
Date: Fri Feb 16 13:23:23 2018
New Revision: 325391
URL: http://llvm.org/viewvc/llvm-project?rev=325391&view=rev
Log:
[OPENMP] Do not emit messages for templa
ahh added a comment.
On my workstation's checkout of head, one test fails (Clang ::
Driver/response-file.c) both with and without this change; everything else
appears to pass.
I believe that between the tests I add to delete.cpp and the ones that are
already there (and destroying-delete.cpp) w
ahh created this revision.
ahh added a reviewer: rsmith.
Herald added a subscriber: cfe-commits.
[expr.delete] is pretty crystal clear that it's OK to invoke a
deallocation-function on a nullptr delete-expression:
"If the value of the operand of the delete-expression is a null
pointer value, it i
21 matches
Mail list logo
