This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC327347: [analyzer] NFC: Move the code for setting temp
object lifetime into method. (authored by dergachev, committed by )
Author: dergachev
Date: Mon Mar 12 16:36:12 2018
New Revision: 327348
URL: http://llvm.org/viewvc/llvm-project?rev=327348&view=rev
Log:
[analyzer] Support temporaries conjured by conservatively evaluated functions.
Properly perform destruction and lifetime extension of such temporaries.
C++ obje
This revision was automatically updated to reflect the committed changes.
Closed by commit rC327348: [analyzer] Support temporaries conjured by
conservatively evaluated functions. (authored by dergachev, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D44131
Files:
lib/StaticA
aaron.ballman added a comment.
Can you regenerate the patch using the same paths as
https://reviews.llvm.org/D43248?id=136811? When I try to do a diff between what
was accepted & committed and the current patch, Phabricator gets confused
because the paths are too different from one another.
h
Author: dergachev
Date: Mon Mar 12 16:52:36 2018
New Revision: 327352
URL: http://llvm.org/viewvc/llvm-project?rev=327352&view=rev
Log:
[CFG] [analyzer] Don't add construction context to a return-by-reference call.
Call expressions that return objects by an lvalue reference or an rvalue
reference
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC327352: [CFG] [analyzer] Don't add construction context
to a return-by-reference call. (authored by dergachev, committed b
compnerd closed this revision.
compnerd added a comment.
SVN r327336. Addressed comments in SVN r327351, because I forgot to
incorporate them in the first try.
Repository:
rL LLVM
https://reviews.llvm.org/D44327
___
cfe-commits mailing list
cfe
jdenny updated this revision to Diff 138111.
jdenny added a comment.
OK, this diff has the svn paths, and I've rebased to a more recent master.
https://reviews.llvm.org/D43248
Files:
trunk/include/clang/AST/Attr.h
trunk/include/clang/Basic/Attr.td
trunk/lib/AST/ExprConstant.cpp
trunk/li
aaron.ballman added inline comments.
Comment at: clang-tidy/cert/CERTTidyModule.cpp:40
// DCL
-CheckFactories.registerCheck(
-"cert-dcl21-cpp");
+CheckFactories.registerCheck("cert-dcl21-cpp");
CheckFactories.registerCheck("cert-dcl50-cpp");
jdenny updated this revision to Diff 138113.
jdenny added a comment.
Well, that didn't work. Here's another attempt at getting the paths right.
https://reviews.llvm.org/D43248
Files:
cfe/trunk/include/clang/AST/Attr.h
cfe/trunk/include/clang/Basic/Attr.td
cfe/trunk/lib/AST/ExprConstant.c
aaron.ballman added a comment.
It seems like there are some other changes than just the serialize and
deserialize that I'm not opposed to, but am wondering why they're needed. It
seems some functions are now `getFoo()` calls and it seems like some
declarations moved around. Are those intended a
Author: dyung
Date: Mon Mar 12 17:41:44 2018
New Revision: 327354
URL: http://llvm.org/viewvc/llvm-project?rev=327354&view=rev
Log:
Add missing "env" so that test added in r327322 passes on Windows bots.
Modified:
cfe/trunk/test/Index/reparsed-live-issue.cpp
Modified: cfe/trunk/test/Index/re
jdenny added a comment.
In https://reviews.llvm.org/D43248#1035466, @aaron.ballman wrote:
> It seems like there are some other changes than just the serialize and
> deserialize that I'm not opposed to, but am wondering why they're needed. It
> seems some functions are now `getFoo()` calls
The
jdenny added inline comments.
Comment at: cfe/trunk/test/Frontend/ast-attr.cpp:1-2
+// %S/../Sema/attr-print.cpp exercises many different attributes, so we reuse
+// it here to check -emit-ast for attributes.
+
aaron.ballman wrote:
> Can you move this below the R
simark created this revision.
Herald added subscribers: cfe-commits, ioeric, jkorous-apple, ilya-biryukov,
mgorny, klimek.
This patch moves the draft manager closer to the edge of Clangd, from
ClangdServer to ClangdLSPServer. This will make it easier to implement
incremental document sync, by ma
simark added a comment.
I uploaded a new patch that moves the draft store to ClangdLSPServer, that
implements what you suggested.
https://reviews.llvm.org/D44408
I will update the incremental sync patch once that patch is in.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D442
aaron.ballman added a comment.
In https://reviews.llvm.org/D43248#1035477, @jdenny wrote:
> In https://reviews.llvm.org/D43248#1035466, @aaron.ballman wrote:
>
> > It seems like there are some other changes than just the serialize and
> > deserialize that I'm not opposed to, but am wondering why
jdenny added inline comments.
Comment at: cfe/trunk/test/Frontend/ast-attr.cpp:1-2
+// %S/../Sema/attr-print.cpp exercises many different attributes, so we reuse
+// it here to check -emit-ast for attributes.
+
aaron.ballman wrote:
> jdenny wrote:
> > aaron.ballm
aaron.ballman added inline comments.
Comment at: cfe/trunk/test/Frontend/ast-attr.cpp:5
+// RUN: %clang -emit-ast -o %t.ast %S/../Sema/attr-print.cpp
+// RUN: %clang_cc1 %t.ast -ast-print | FileCheck %S/../Sema/attr-print.cpp
Just to verify my understanding, this
jdenny added inline comments.
Comment at: cfe/trunk/test/Frontend/ast-attr.cpp:5
+// RUN: %clang -emit-ast -o %t.ast %S/../Sema/attr-print.cpp
+// RUN: %clang_cc1 %t.ast -ast-print | FileCheck %S/../Sema/attr-print.cpp
aaron.ballman wrote:
> Just to verify my und
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with the test comments fixed up.
Comment at: cfe/trunk/test/Frontend/ast-attr.cpp:5
+// RUN: %clang -emit-ast -o %t.ast %S/../Sema/attr-print.cpp
+// RUN:
jdenny added a comment.
In https://reviews.llvm.org/D43248#1035509, @aaron.ballman wrote:
> LGTM with the test comments fixed up.
Thanks! I'll commit tomorrow.
https://reviews.llvm.org/D43248
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
jloser created this revision.
jloser added reviewers: EricWF, matthew.
Herald added subscribers: cfe-commits, christof.
[libc++] Fix Container::insert(value_type const&) tests
Several unit tests meaning to test the behavior of lvalue insertion incorrectly
pass rvalues. Fixes bug 27394.
Reposi
rtrieu added a comment.
> I believe you were around this code last, so can you remember why it was
> there?
Yes, that's an early exit to speed up the check. You can remove that check and
add a test case for it.
This was a little confusing for me, so let's refactor it a little. These
chang
101 - 124 of 124 matches
Mail list logo
