aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM with the test comments fixed up. ================ Comment at: cfe/trunk/test/Frontend/ast-attr.cpp:5 +// RUN: %clang -emit-ast -o %t.ast %S/../Sema/attr-print.cpp +// RUN: %clang_cc1 %t.ast -ast-print | FileCheck %S/../Sema/attr-print.cpp ---------------- jdenny wrote: > aaron.ballman wrote: > > Just to verify my understanding, this test is checking the serialization > > and deserialization? > That's right, and it failed without the other changes in this revision > because alloc_size's second argument serialized/deserialized as 0 when it was > actually invalid (that is, unspecified). Of course, this test is more > thorough than just exercising alloc_size. Perfect, thank you! https://reviews.llvm.org/D43248 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
