[PATCH] D44724: [Fuchsia] Don't install libc++, libc++abi or libunwind on Darwin

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. Lgtm with some more comments Repository: rC Clang https://reviews.llvm.org/D44724 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44727: [RISCV] Implement getTargetDefines, handleTargetFeatures and hasFeature for RISCVTargetInfo

kito-cheng created this revision. kito-cheng added reviewers: asb, apazos. Herald added subscribers: cfe-commits, shiva0217, niosHD, sabuasal, jordy.potman.lists, simoncook, johnrusso, rbar. kito-cheng added a dependency: D44189: [RISCV] Verify the input value of -march=. This patch implement ge

[PATCH] D44724: [Fuchsia] Don't install libc++, libc++abi or libunwind on Darwin

phosek updated this revision to Diff 139249. phosek retitled this revision from "[Fuchsia] Avoid using static ABI library with libc++ on Darwin" to "[Fuchsia] Don't install libc++, libc++abi or libunwind on Darwin". phosek edited the summary of this revision. phosek added a comment. Done, they'r

[PATCH] D44725: [analyzer] NFC: Move construction context allocation into a helper method.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. It is tedious to allocate and then placement-new the construction context, so i added a tiny variadic template to improve readability. Repo

[PATCH] D44597: [CFG] [analyzer] Add C++17-specific variable and return value construction contexts.

NoQ updated this revision to Diff 139245. NoQ added a comment. Address review comments. https://reviews.llvm.org/D44597 Files: include/clang/Analysis/CFG.h include/clang/Analysis/ConstructionContext.h lib/Analysis/CFG.cpp lib/Analysis/ConstructionContext.cpp lib/StaticAnalyzer/Core/Ex

[PATCH] D44724: [Fuchsia] Avoid using static ABI library with libc++ on Darwin

mcgrathr added a comment. When targetting Darwin we should really not be even compiling libc++/libc++abi and certainly should not have anything else compiling against their headers since at runtime the system libraries will be used and so things better compile against the system headers that ma

[clang-tools-extra] r328069 - Revert "[lit] Adding config initialization to lit tests in clang-tools-extra"

Author: phosek Date: Tue Mar 20 19:28:22 2018 New Revision: 328069 URL: http://llvm.org/viewvc/llvm-project?rev=328069&view=rev Log: Revert "[lit] Adding config initialization to lit tests in clang-tools-extra" This reverts commit r328060 because a test that was inteded to run on Windows but neve

[PATCH] D44724: [Fuchsia] Avoid using static ABI library with libc++ on Darwin

phosek created this revision. phosek added reviewers: mcgrathr, jakehehrlich. Herald added subscribers: cfe-commits, mgorny. Herald added a reviewer: EricWF. Building libc++ with static ABI library on Darwin is not currently supported. Repository: rC Clang https://reviews.llvm.org/D44724 Fil

[PATCH] D44723: Set dso_local when clearing dllimport

espindola created this revision. espindola added reviewers: rnk, echristo. https://reviews.llvm.org/D44723 Files: lib/CodeGen/CodeGenModule.cpp test/CodeGenCXX/dllimport.cpp Index: test/CodeGenCXX/dllimport.cpp === --- test/Cod

[PATCH] D44721: [analyzer] Enable c++-temp-dtor-inlining by default?

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. Remaining temporary-destructor-inlining-related false positives i've seen so far are caused by classes with unions; i'll try to improve upon

[PATCH] D44712: Set dso_local on runtime variables

espindola closed this revision. espindola added a comment. r328068 https://reviews.llvm.org/D44712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r328068 - Set dso_local on runtime variables.

Author: rafael Date: Tue Mar 20 18:30:16 2018 New Revision: 328068 URL: http://llvm.org/viewvc/llvm-project?rev=328068&view=rev Log: Set dso_local on runtime variables. Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp cfe/trunk/test/CodeGenCXX/ubsan-vtable-checks.cpp Modified: cfe/trunk

[PATCH] D44557: [analyzer] CStringChecker.cpp - Code refactoring on bug report.

NoQ added a comment. In https://reviews.llvm.org/D44557#1042792, @MTC wrote: > In https://reviews.llvm.org/D44557#1042357, @NoQ wrote: > > > Sorry, one moment, i'm seeing a few regressions after the previous > > refactoring but i didn't look at them closely yet to provide a reproducer. > > I'll

r328067 - Revert r326782 "[analyzer] CStringChecker.cpp: Remove the duplicated check...".

Author: dergachev Date: Tue Mar 20 17:57:37 2018 New Revision: 328067 URL: http://llvm.org/viewvc/llvm-project?rev=328067&view=rev Log: Revert r326782 "[analyzer] CStringChecker.cpp: Remove the duplicated check...". It seems that the refactoring was causing a functional change and some warnings h

[PATCH] D44281: [analyzer] Suppress more MallocChecker positives in reference counting pointer destructors.

This revision was automatically updated to reflect the committed changes. Closed by commit rC328066: [analyzer] Suppress more MallocChecker positives in smart pointer destructors. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D44281 Files: lib/StaticA

r328066 - [analyzer] Suppress more MallocChecker positives in smart pointer destructors.

Author: dergachev Date: Tue Mar 20 17:49:47 2018 New Revision: 328066 URL: http://llvm.org/viewvc/llvm-project?rev=328066&view=rev Log: [analyzer] Suppress more MallocChecker positives in smart pointer destructors. r326249 wasn't quite enough because we often run out of inlining stack depth limit

[PATCH] D44589: [Sema] Make deprecation fix-it replace all multi-parameter ObjC method slots.

vsapsai marked 3 inline comments as done. vsapsai added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7207-7217 +} else { + FixIts.push_back(FixItHint::CreateInsertion( + SelectorLocs[I], SelectorSlotNames[I])); +

[PATCH] D44589: [Sema] Make deprecation fix-it replace all multi-parameter ObjC method slots.

vsapsai updated this revision to Diff 139233. vsapsai added a comment. Address review comments: - Replace `auto` with explicit type. - Use `llvm::makeArrayRef`. - Remove curly braces around single-statement elses. https://reviews.llvm.org/D44589 Files: clang/include/clang/Basic/SourceLocatio

[PATCH] D44646: Sema: in msvc compatibility mode, don't allow forceinline on variadics

DHowett-MSFT added inline comments. Comment at: test/Sema/ms-forceinline-on-variadic.cpp:14 +__builtin_va_end(ap); +} + efriedma wrote: > compnerd wrote: > > DHowett-MSFT wrote: > > > compnerd wrote: > > > > Would be nice to have a second test that uses the M

[libcxx] r328064 - Implement LWG3034: P0767R1 breaks previously-standard-layout types

Author: marshall Date: Tue Mar 20 17:36:05 2018 New Revision: 328064 URL: http://llvm.org/viewvc/llvm-project?rev=328064&view=rev Log: Implement LWG3034: P0767R1 breaks previously-standard-layout types Added: libcxx/trunk/test/std/strings/basic.string/char.bad.fail.cpp libcxx/trunk/test/s

[PATCH] D44712: Set dso_local on runtime variables

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D44712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r328063 - [Analysis] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

Author: eugenezelenko Date: Tue Mar 20 17:14:43 2018 New Revision: 328063 URL: http://llvm.org/viewvc/llvm-project?rev=328063&view=rev Log: [Analysis] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC). Modified: cfe/trunk/include/clang/Analysis/Analyses

[PATCH] D44720: [clangd] Simplify fuzzy matcher (sequence alignment) by removing some condition checks.

MaskRay added a comment. Brings some goodies from https://github.com/cquery-project/cquery/blob/master/src/fuzzy_match.cc (what I plagiarized from clangd) Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44720 ___ cfe-commits mailin

[PATCH] D44281: [analyzer] Suppress more MallocChecker positives in reference counting pointer destructors.

NoQ updated this revision to Diff 139231. NoQ added a comment. - fix `auto`. - don't use regexs yet because it's clean enough anyway; maybe later. https://reviews.llvm.org/D44281 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/NewDelete-atomics.cpp Index: test/Analysis/

[PATCH] D44720: [clangd] Simplify fuzzy matcher (sequence alignment) by removing some condition checks.

MaskRay created this revision. MaskRay added a reviewer: sammccall. Herald added subscribers: cfe-commits, ioeric, jkorous-apple, ilya-biryukov, klimek. Also rename `matchBonus` and `skipPenalty` to uniform `{match,miss}Score` in addition form. Repository: rCTE Clang Tools Extra https://rev

Re: r328040 - Set dso_local on string literals.

Joerg Sonnenberger via cfe-commits writes: > On Tue, Mar 20, 2018 at 08:42:55PM -, Rafael Espindola via cfe-commits > wrote: >> Author: rafael >> Date: Tue Mar 20 13:42:55 2018 >> New Revision: 328040 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=328040&view=rev >> Log: >> Set dso_loca

[PATCH] D44619: [CodeGen] Add cleanup scope to EmitInlinedInheritingCXXConstructorCall

rsmith added inline comments. Comment at: lib/CodeGen/CGClass.cpp:2183 ApplyInlineDebugLocation DebugScope(*this, GD); + RunCleanupsScope CleanupScope(*this); Please add a test to ensure that we still destroy function parameters in the right order and at t

[clang-tools-extra] r328060 - [lit] Adding config initialization to lit tests in clang-tools-extra

Author: juliehockett Date: Tue Mar 20 16:22:50 2018 New Revision: 328060 URL: http://llvm.org/viewvc/llvm-project?rev=328060&view=rev Log: [lit] Adding config initialization to lit tests in clang-tools-extra Adding the config initialization to clang-tools-extra so that tests that use REQUIRES, UN

[PATCH] D44708: [test] Adding config initialization to lit tests in clang-tools-extra

This revision was automatically updated to reflect the committed changes. Closed by commit rL328060: [lit] Adding config initialization to lit tests in clang-tools-extra (authored by juliehockett, committed by ). Herald added subscribers: llvm-commits, klimek. Changed prior to commit: https://r

[PATCH] D44646: Sema: in msvc compatibility mode, don't allow forceinline on variadics

efriedma added inline comments. Comment at: test/Sema/ms-forceinline-on-variadic.cpp:14 +__builtin_va_end(ap); +} + compnerd wrote: > DHowett-MSFT wrote: > > compnerd wrote: > > > Would be nice to have a second test that uses the Microsoft definitions > > >

[libcxx] r328059 - Implement LWG3035: std::allocator's constructors should be constexpr.

Author: marshall Date: Tue Mar 20 16:02:53 2018 New Revision: 328059 URL: http://llvm.org/viewvc/llvm-project?rev=328059&view=rev Log: Implement LWG3035: std::allocator's constructors should be constexpr. Added: libcxx/trunk/test/std/utilities/memory/default.allocator/allocator.ctor.pass.cpp

[PATCH] D44646: Sema: in msvc compatibility mode, don't allow forceinline on variadics

compnerd added inline comments. Comment at: test/Sema/ms-forceinline-on-variadic.cpp:14 +__builtin_va_end(ap); +} + DHowett-MSFT wrote: > compnerd wrote: > > Would be nice to have a second test that uses the Microsoft definitions > > (`char *` and the offset

[PATCH] D43957: Fixing issue where a space was not added before a global namespace variable when SpacesInParentheses is set

dpayne updated this revision to Diff 139212. dpayne added a comment. Adding a unit test for formatting a global namespace var with SpacesInParentheses enabled. Repository: rC Clang https://reviews.llvm.org/D43957 Files: lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.cpp Ind

[PATCH] D44671: [libcxx] Enable static libcxxabi linking on Darwin

compnerd added a reviewer: dexonsmith. compnerd added a comment. I want to get Duncan's input on this. I don't think that this is a supported configuration for macOS. Repository: rCXX libc++ https://reviews.llvm.org/D44671 ___ cfe-commits maili

[libcxx] r328054 - Implement LWG 3039 and 3041 - 'Treating Unnecessary decay'.

Author: marshall Date: Tue Mar 20 15:37:37 2018 New Revision: 328054 URL: http://llvm.org/viewvc/llvm-project?rev=328054&view=rev Log: Implement LWG 3039 and 3041 - 'Treating Unnecessary decay'. Modified: libcxx/trunk/include/future libcxx/trunk/include/thread Modified: libcxx/trunk/incl

r328053 - [Modules] Honor -fmodule-name when handling private framework modules

Author: bruno Date: Tue Mar 20 15:36:39 2018 New Revision: 328053 URL: http://llvm.org/viewvc/llvm-project?rev=328053&view=rev Log: [Modules] Honor -fmodule-name when handling private framework modules When skipping building the module for a private framework module, LangOpts.CurrentModule isn't

[PATCH] D44708: [test] Adding config initialization to lit tests in clang-tools-extra

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. As per https://github.com/llvm-project/llvm-project-20170507/search?utf8=%E2%9C%93&q=LIT_SITE_CFG_IN_FOOTER&type= this substitution already exists in most of the repos. I don't see why

[PATCH] D44619: [CodeGen] Add cleanup scope to EmitInlinedInheritingCXXConstructorCall

smeenai added a comment. Thanks Reid. I still need to look into why this is causing some existing tests to crash, but I'll also adjust the test. Repository: rC Clang https://reviews.llvm.org/D44619 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D44708: [test] Adding config initialization to lit tests in clang-tools-extra

lebedev.ri added a comment. Nice catch! I wonder how many more `test/lit.site.cfg.in` are silently partially non-functional because they don't have that substitution... I also have an idea why it might not have worked for you - are you building clang-tools-extra repo separately manually, not as

Re: r328040 - Set dso_local on string literals.

On Tue, Mar 20, 2018 at 08:42:55PM -, Rafael Espindola via cfe-commits wrote: > Author: rafael > Date: Tue Mar 20 13:42:55 2018 > New Revision: 328040 > > URL: http://llvm.org/viewvc/llvm-project?rev=328040&view=rev > Log: > Set dso_local on string literals. I wonder if unnamed_addr shouldn'

[PATCH] D44712: Set dso_local on runtime variables

espindola created this revision. espindola added reviewers: rnk, echristo, eli.friedman. https://reviews.llvm.org/D44712 Files: lib/CodeGen/CodeGenModule.cpp test/CodeGenCXX/ubsan-vtable-checks.cpp Index: test/CodeGenCXX/ubsan-vtable-checks.cpp ==

[PATCH] D44706: Delete BuiltinCC

espindola closed this revision. espindola added a comment. r328050 https://reviews.llvm.org/D44706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r328051 - Change ImplicitConverionKind comments to refer to C++ stable names[NFC]

Author: erichkeane Date: Tue Mar 20 15:05:01 2018 New Revision: 328051 URL: http://llvm.org/viewvc/llvm-project?rev=328051&view=rev Log: Change ImplicitConverionKind comments to refer to C++ stable names[NFC] Modified: cfe/trunk/include/clang/Sema/Overload.h Modified: cfe/trunk/include/clang

r328050 - Delete BuiltinCC. NFC.

Author: rafael Date: Tue Mar 20 15:02:57 2018 New Revision: 328050 URL: http://llvm.org/viewvc/llvm-project?rev=328050&view=rev Log: Delete BuiltinCC. NFC. It is always identical to RuntimeCC. Modified: cfe/trunk/lib/CodeGen/ABIInfo.h cfe/trunk/lib/CodeGen/CGExprComplex.cpp cfe/trunk

[PATCH] D44710: Set dso_local on builtin functions

espindola created this revision. espindola added reviewers: rnk, echristo. With https://reviews.llvm.org/D44706 we can just forward to CreateRuntimeFunction. https://reviews.llvm.org/D44710 Files: lib/CodeGen/CodeGenModule.cpp test/CodeGen/mingw-long-double.c Index: test/CodeGen/mingw-lo

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added a comment. After much digging, it looks like the lit config is never initialized in clang-tools-extra like it is in the other projects. REQUIRES et.al. work properly once that's in there (see D44708 ). Once that lands I'll reland this and *hop

[PATCH] D44706: Delete BuiltinCC

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D44706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D44708: [test] Adding config initialization to lit tests in clang-tools-extra

juliehockett created this revision. juliehockett added reviewers: alexfh, mgorny. juliehockett added a project: clang-tools-extra. Adding the config initialization (the footer) to clang-tools-extra so that tests that use REQUIRES, UNSUPPORTED, and XFAIL based on platform or target triple work pr

r328048 - Add CHECKs for a few declarations. NFC.

Author: rafael Date: Tue Mar 20 14:54:14 2018 New Revision: 328048 URL: http://llvm.org/viewvc/llvm-project?rev=328048&view=rev Log: Add CHECKs for a few declarations. NFC. We were just missing test coverage for this. Modified: cfe/trunk/test/CodeGen/mingw-long-double.c Modified: cfe/trunk/

r328047 - [format] Eliminate global destructors.

Author: d0k Date: Tue Mar 20 14:52:19 2018 New Revision: 328047 URL: http://llvm.org/viewvc/llvm-project?rev=328047&view=rev Log: [format] Eliminate global destructors. Modified: cfe/trunk/lib/Format/BreakableToken.cpp cfe/trunk/lib/Format/Format.cpp Modified: cfe/trunk/lib/Format/Breaka

[PATCH] D44706: Delete BuiltinCC

espindola created this revision. espindola added reviewers: rnk, echristo. It is always identical to RuntimeCC. https://reviews.llvm.org/D44706 Files: lib/CodeGen/ABIInfo.h lib/CodeGen/CGExprComplex.cpp lib/CodeGen/CodeGenModule.cpp lib/CodeGen/CodeGenTypeCache.h lib/CodeGen/TargetInf

[PATCH] D44692: [clang-format] Don't insert space between r_paren and 'new' in ObjC decl

stephanemoore accepted this revision. stephanemoore added a comment. This revision is now accepted and ready to land. Makes sense to me. Repository: rC Clang https://reviews.llvm.org/D44692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r328044 - [Driver] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

Author: eugenezelenko Date: Tue Mar 20 14:08:59 2018 New Revision: 328044 URL: http://llvm.org/viewvc/llvm-project?rev=328044&view=rev Log: [Driver] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC). Modified: cfe/trunk/include/clang/Driver/Action.h

[PATCH] D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

jdemeule added inline comments. Comment at: clang-apply-replacements/include/clang-apply-replacements/Tooling/ApplyReplacements.h:75 +/// \brief Deduplicate, check for conflicts, and convert all Replacements stored +/// in \c TUs to AtomicChange. If conflicts occur, no Replacem

Re: r328006 - [NVPTX] Make tensor load/store intrinsics overloaded.

Sorry, I was just missing "git pull" in the llvm repo. Cheers, Rafael Artem Belevich writes: > Thanks for the heads up. > > Which buildbot shows the failure? I don't see the failure on the cuda > buildbot, nor do I see it on my machine locally. > > It may be due to llvm/clang being out of sync.

[PATCH] D44689: Set dso_local on string literals

espindola closed this revision. espindola added a comment. r328040 https://reviews.llvm.org/D44689 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r328041 - [format] Initialize regex lazily

Author: d0k Date: Tue Mar 20 13:43:12 2018 New Revision: 328041 URL: http://llvm.org/viewvc/llvm-project?rev=328041&view=rev Log: [format] Initialize regex lazily No need to pay for this on program startup, and also no need to destroy it on process end. Modified: cfe/trunk/lib/Format/Namespa

r328040 - Set dso_local on string literals.

Author: rafael Date: Tue Mar 20 13:42:55 2018 New Revision: 328040 URL: http://llvm.org/viewvc/llvm-project?rev=328040&view=rev Log: Set dso_local on string literals. Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp cfe/trunk/test/CodeGen/c-strings.c cfe/trunk/test/CodeGen/string-lit

Re: r328006 - [NVPTX] Make tensor load/store intrinsics overloaded.

Thanks for the heads up. Which buildbot shows the failure? I don't see the failure on the cuda buildbot, nor do I see it on my machine locally. It may be due to llvm/clang being out of sync. The commit had changes for both sides and if clang and llvm are out of sync, you may see this kind of erro

[PATCH] D44539: [Sema][Objective-C] Add check to warn when property of objc type has assign attribute

benhamilton added a comment. > Isn't it better to have unsafe_unretained there? That is a good question for the author of that property attribute. I'm not sure of the entire history. Repository: rC Clang https://reviews.llvm.org/D44539 ___ cfe-

r328038 - [AArch64] Add vmulxh_lane fp16 vector intrinsic

Author: az Date: Tue Mar 20 13:37:31 2018 New Revision: 328038 URL: http://llvm.org/viewvc/llvm-project?rev=328038&view=rev Log: [AArch64] Add vmulxh_lane fp16 vector intrinsic https://reviews.llvm.org/D44591 Modified: cfe/trunk/include/clang/Basic/arm_neon.td cfe/trunk/lib/CodeGen/CGBui

Re: r328006 - [NVPTX] Make tensor load/store intrinsics overloaded.

With this clang/test/CodeGen/builtins-nvptx-sm_70.cu is crashing: lib/IR/Instructions.cpp:299: void llvm::CallInst::init(llvm::FunctionType *, llvm::Value *, ArrayRef, ArrayRef, const llvm::Twine &): Assertion `(i >= FTy->getNumParams()|| FTy->getParamType(i) == Args[i]->getType()) && "Calling a f

[PATCH] D44539: [Sema][Objective-C] Add check to warn when property of objc type has assign attribute

QF5690 added a comment. > I think the problem is there are valid places to use assign on object types > (especially delegates). Isn't it better to have unsafe_unretained there? I thought unsafe_unretained keyword is introduced specifically for that kinds of things. Ok, here is my last point :)

[PATCH] D44688: Set dso_local for runtime functions

espindola closed this revision. espindola added a comment. 328036 https://reviews.llvm.org/D44688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44688: Set dso_local for runtime functions

espindola added a comment. In https://reviews.llvm.org/D44688#1043575, @rnk wrote: > lgtm > > We don't assume these are `dso_local` on Linux, right? Depends on shouldAssumeDSOLocal. We do if there is no -fPIC or -fPIE for example. https://reviews.llvm.org/D44688 __

r328036 - Set dso_local for runtime function.

Author: rafael Date: Tue Mar 20 13:27:30 2018 New Revision: 328036 URL: http://llvm.org/viewvc/llvm-project?rev=328036&view=rev Log: Set dso_local for runtime function. This is another case where there is special logic for adding dllimport and so we cannot use setGVProperties. Modified: cfe/

[PATCH] D44694: [clang-tidy] Use :doc: for check links in Release Notes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43766: [clang-tidy][modernize-make-unique] Checks c++14 flag before using std::make_unique

ftingaud added a comment. Hi, Yes please! https://reviews.llvm.org/D43766 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44539: [Sema][Objective-C] Add check to warn when property of objc type has assign attribute

benhamilton added a comment. I think the problem is there are valid places to use assign on object types (especially delegates). There are a lot of special cases to deal with here, and it's really up to each team to decide the rules for when assign on object types are OK, so I don't think a co

[PATCH] D43967: [ASTImporter] Add test helper Fixture

martong added inline comments. Comment at: unittests/AST/ASTImporterTest.cpp:198 + Language ToLang, StringRef Identifier = "declToImport") { +ArgVector FromArgs = getBasicRunOptionsForLanguage(FromLang), + ToArgs = getBasicRunOptionsForLanguage(T

[PATCH] D43967: [ASTImporter] Add test helper Fixture

martong updated this revision to Diff 139181. martong marked 14 inline comments as done. martong added a comment. Update based on Alexei's comments. - Use createVirtualFile in testImport - Add minimal style changes - Use DeclCounter - Add hasFieldOrder matcher - Add parameterized tests Reposito

[PATCH] D44539: [Sema][Objective-C] Add check to warn when property of objc type has assign attribute

QF5690 added a comment. In https://reviews.llvm.org/D44539#1041993, @benhamilton wrote: > I wonder if this wouldn't be better as a clang-tidy check: > > https://github.com/llvm-mirror/clang-tools-extra/tree/master/clang-tidy/objc Border between clang-tidy checks and compiler diagnostics is not

[PATCH] D44695: [clang-format] Partially revert r322749, replacing array with DenseSet

benhamilton added a comment. > One way in which DenseSet is better is that it supports StringRefs - we don't > have to define hash. Seems like the lack of this override in core LLVM > suggests that unordered_set is not commonly used with StringRefs. Makes sense, thanks. Repository: rC Clang

[PATCH] D44602: [clang-tidy] readability-function-size: add VariableThreshold param.

aaron.ballman added inline comments. Comment at: test/clang-tidy/readability-function-size.cpp:207-212 +void variables_8() { + int a, b; + struct A { +A(int c, int d); + }; +} lebedev.ri wrote: > aaron.ballman wrote: > > lebedev.ri wrote: > > > aaron.ballm

[PATCH] D44695: [clang-format] Partially revert r322749, replacing array with DenseSet

krasimir added a comment. One way in which `DenseSet` is better is that it supports `StringRef`s - we don't have to define `hash`. Seems like the lack of this override in core LLVM suggests that `unordered_set` is not commonly used with `StringRef`s. Repository: rC Clang https://reviews.llv

[PATCH] D44673: Make positionToOffset return llvm::Expected

simark added inline comments. Comment at: clangd/SourceCode.h:24 -/// Turn a [line, column] pair into an offset in Code. -size_t positionToOffset(llvm::StringRef Code, Position P); +/// Turn a [line, column] pair into an offset in Code according to the LSP +/// definition of a

[PATCH] D44695: [clang-format] Partially revert r322749, replacing array with DenseSet

benhamilton added a comment. I'm fine with whichever approach we use, but I'll defer to @krasimir here. (I'm not fully sure why `llvm::DenseSet` is better than `std::unsorted_set`, but I'm sure you and @krasimir understand the subtleties better than I do.) Repository: rC Clang https://revie

[PATCH] D44688: Set dso_local for runtime functions

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm We don't assume these are `dso_local` on Linux, right? https://reviews.llvm.org/D44688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D44689: Set dso_local on string literals

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D44689 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44597: [CFG] [analyzer] Add C++17-specific variable and return value construction contexts.

george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land. LGTM, subject to minor nits Comment at: include/clang/Analysis/CFG.h:172 /// by value. This, like constructor, requires a construction context, which -//

[PATCH] D44602: [clang-tidy] readability-function-size: add VariableThreshold param.

lebedev.ri added inline comments. Comment at: test/clang-tidy/readability-function-size.cpp:207-212 +void variables_8() { + int a, b; + struct A { +A(int c, int d); + }; +} aaron.ballman wrote: > lebedev.ri wrote: > > aaron.ballman wrote: > > > lebedev.ri

[PATCH] D44695: [clang-format] Partially revert r322749, replacing array with DenseSet

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. I wouldn't say that this is more maintainable, but I'm not the maintainer of clang-format. Repository: rC Clang https://reviews.llvm.org/D44695 ___

[PATCH] D44632: [clang-format] Add a few more Core Graphics identifiers to ObjC heuristic

krasimir added inline comments. Comment at: lib/Format/Format.cpp:1450 // Keep this array sorted, since we are binary searching over it. static constexpr llvm::StringLiteral FoundationIdentifiers[] = { "CGFloat", jolesiak wrote: > benhamilton w

[PATCH] D44602: [clang-tidy] readability-function-size: add VariableThreshold param.

aaron.ballman added inline comments. Comment at: test/clang-tidy/readability-function-size.cpp:207-212 +void variables_8() { + int a, b; + struct A { +A(int c, int d); + }; +} lebedev.ri wrote: > aaron.ballman wrote: > > lebedev.ri wrote: > > > aaron.ballm

[PATCH] D44695: [clang-format] Partially revert r322749, replacing array with DenseSet

krasimir created this revision. Herald added subscribers: cfe-commits, klimek. The array + binary_search requires the initializer list of identifiers to be sorted. I can imagine how this list might change frequently while the support for ObjectiveC improves (https://reviews.llvm.org/D44632). The a

[PATCH] D44672: [CodeGen] Disable UBSan for coroutine functions

vsk added a comment. The "Cannot represent a difference across sections" error is almost certainly related to -fsanitize=function. Time permitting, could you file a separate PR for that and attach the IR? It'd be great to know whether the issue reproduces without coroutines involved. Also, cou

[PATCH] D44602: [clang-tidy] readability-function-size: add VariableThreshold param.

lebedev.ri added inline comments. Comment at: test/clang-tidy/readability-function-size.cpp:207-212 +void variables_8() { + int a, b; + struct A { +A(int c, int d); + }; +} aaron.ballman wrote: > lebedev.ri wrote: > > aaron.ballman wrote: > > > I think the

[PATCH] D44602: [clang-tidy] readability-function-size: add VariableThreshold param.

aaron.ballman added inline comments. Comment at: test/clang-tidy/readability-function-size.cpp:207-212 +void variables_8() { + int a, b; + struct A { +A(int c, int d); + }; +} lebedev.ri wrote: > aaron.ballman wrote: > > I think the current behavior here i

[PATCH] D44694: [clang-tidy] Use :doc: for check links in Release Notes

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: alexfh, hokein, aaron.ballman. Eugene.Zelenko added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. I learned from https://reviews.llvm.org/D44636 of shorter links to documentation, which could be used for C

[PATCH] D44602: [clang-tidy] readability-function-size: add VariableThreshold param.

lebedev.ri added inline comments. Comment at: test/clang-tidy/readability-function-size.cpp:207-212 +void variables_8() { + int a, b; + struct A { +A(int c, int d); + }; +} aaron.ballman wrote: > I think the current behavior here is correct and the previou

[PATCH] D44602: [clang-tidy] readability-function-size: add VariableThreshold param.

aaron.ballman added inline comments. Comment at: test/clang-tidy/readability-function-size.cpp:207-212 +void variables_8() { + int a, b; + struct A { +A(int c, int d); + }; +} I think the current behavior here is correct and the previous behavior was inco

[PATCH] D44671: [libcxx] Enable static libcxxabi linking on Darwin

phosek updated this revision to Diff 139163. phosek marked an inline comment as done. Repository: rCXX libc++ https://reviews.llvm.org/D44671 Files: libcxx/CMakeLists.txt Index: libcxx/CMakeLists.txt === --- libcxx/CMakeLists.

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

aaron.ballman added inline comments. Comment at: clang-tidy/bugprone/ParentVirtualCallCheck.cpp:128 + diag(Member->getQualifierLoc().getSourceRange().getBegin(), + "'%0' is a grand-parent's method, not parent's. Did you mean %1?") + << CalleeName << ParentsStr

[PATCH] D44541: [OpenMP][Clang] Move device global stack init before master-workers split

ABataev added a comment. LG Repository: rC Clang https://reviews.llvm.org/D44541 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r328007 - Basic: support PreserveMost and PreserveAll on Windows ARM

Author: compnerd Date: Tue Mar 20 10:33:26 2018 New Revision: 328007 URL: http://llvm.org/viewvc/llvm-project?rev=328007&view=rev Log: Basic: support PreserveMost and PreserveAll on Windows ARM Do not ignore these calling conventions on Windows ARM. They are used by the swift runtime for certain

[PATCH] D44541: [OpenMP][Clang] Move device global stack init before master-workers split

gtbercea updated this revision to Diff 139159. gtbercea added a comment. Fix test. Repository: rC Clang https://reviews.llvm.org/D44541 Files: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp test/OpenMP/nvptx_data_sharing.cpp test/OpenMP/nvptx_target_teams_distribute_parallel_for_generic_mode_co

[PATCH] D44646: Sema: in msvc compatibility mode, don't allow forceinline on variadics

DHowett-MSFT added inline comments. Comment at: test/Sema/ms-forceinline-on-variadic.cpp:1 +// RUN: %clang_cc1 -emit-llvm -o - -triple i686-windows -verify -fms-extensions %s \ +// RUN:| FileCheck %s compnerd wrote: > Personally, I prefer the fully c

[PATCH] D44673: Make positionToOffset return llvm::Expected

simark updated this revision to Diff 139157. simark marked 9 inline comments as done. simark added a comment. Herald added a subscriber: mgorny. Address review comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44673 Files: clangd/ClangdServer.cpp clangd/SourceCode.cpp

[PATCH] D44435: Add the module name to __cuda_module_ctor and __cuda_module_dtor for unique function names

SimeonEhrig added inline comments. Comment at: unittests/CodeGen/IncrementalProcessingTest.cpp:176-178 + +// In CUDA incremental processing, a CUDA ctor or dtor will be generated for +// every statement if a fatbinary file exists. tra wrote: > SimeonEhrig wrote:

[PATCH] D44692: [clang-format] Don't insert space between r_paren and 'new' in ObjC decl

benhamilton created this revision. benhamilton added reviewers: djasper, jolesiak. Herald added subscribers: cfe-commits, klimek. Previously, clang-format would insert a space between the closing parenthesis and 'new' in the following valid Objective-C declaration: + (instancetype)new; This wa

  1   2   >