As a near term fix, I've tried to shorten the path in r334574. Let's
see if the bot likes it.
On Wed, Jun 13, 2018 at 6:34 AM, Galina Kistanova via cfe-commits
wrote:
> That could be the case. However, the bot shall not be left red.
>
> Hans, could you revert the patch for now, till the problem w
Author: hans
Date: Tue Jun 12 23:48:40 2018
New Revision: 334574
URL: http://llvm.org/viewvc/llvm-project?rev=334574&view=rev
Log:
crash-report-modules.m: Shorten path length to make Windows bot happy
Modified:
cfe/trunk/test/Driver/crash-report-modules.m
Modified: cfe/trunk/test/Driver/cras
sammccall added a comment.
@ilya-biryukov ping. I'm excited about this change :-)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47950
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
sammccall updated this revision to Diff 151104.
sammccall added a comment.
Fix completion tests. (Simplify a bit - no need to re-test all the nuances of
fuzzy matching there).
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47950
Files:
clangd/FuzzyMatch.cpp
clangd/FuzzyMatc
Author: void
Date: Tue Jun 12 23:33:59 2018
New Revision: 334573
URL: http://llvm.org/viewvc/llvm-project?rev=334573&view=rev
Log:
Remove extraneous semicolon.
Modified:
cfe/trunk/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp
Modified: cfe/trunk/lib/StaticAnalyzer/Core/BugReporterVisitors.
Author: sammccall
Date: Tue Jun 12 23:25:36 2018
New Revision: 334572
URL: http://llvm.org/viewvc/llvm-project?rev=334572&view=rev
Log:
[clangd] Log completion context type. NFC
Modified:
clang-tools-extra/trunk/clangd/CodeComplete.cpp
Modified: clang-tools-extra/trunk/clangd/CodeComplete.cp
sammccall added a comment.
Generally LG.
I guess you might be able to test this by starting with a/compile_flags.txt and
a/b/x.cc, and then adding a/b/compile_flags.txt?
Comment at: clangd/ClangdLSPServer.h:38
llvm::Optional CompileCommandsDir,
-
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334569: [Sema] When the address of a member function is used
as a template (authored by ahatanak, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D36918?vs=148334&id=151102#toc
Reposi
Author: ahatanak
Date: Tue Jun 12 22:26:23 2018
New Revision: 334569
URL: http://llvm.org/viewvc/llvm-project?rev=334569&view=rev
Log:
[Sema] When the address of a member function is used as a template
argument, use the context in which it is used for checking its
accessibility.
This fixes PR3289
craig.topper updated this revision to Diff 151100.
craig.topper added a comment.
Inline assembly implementations.
https://reviews.llvm.org/D47672
Files:
lib/Headers/immintrin.h
lib/Headers/intrin.h
test/CodeGen/ms-intrinsics.c
Index: test/CodeGen/ms-intrinsics.c
=
That could be the case. However, the bot shall not be left red.
Hans, could you revert the patch for now, till the problem would be
addressed on all the Windows bots one way or another, please?
I can take a look at my bots later this week.
Thanks
Galina
On Tue, Jun 12, 2018 at 1:52 PM, Reid Kle
compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.
x86-Linux-only test is good. LG with the discussed changes.
Comment at: src/DwarfInstructions.hpp:195
}
+else if (i == (int)cieInfo.returnAddressRegiste
Well, that was wrong. There are more install-cxx-headers targets that
the cache distribution implicitly depends on.
Is there a reason for your cxx-headers -> cxx_headers change? If
there is, should the other cxx-headers targets change as well? If
not, can we revert it?
I'll try to reproduce in
pcc updated this revision to Diff 151090.
pcc added a comment.
Herald added subscribers: steven_wu, kubamracek, mehdi_amini.
- Address TODOs
https://reviews.llvm.org/D47567
Files:
clang/docs/ControlFlowIntegrity.rst
clang/docs/LTOVisibility.rst
clang/include/clang/Basic/Sanitizers.def
c
Author: rsmith
Date: Tue Jun 12 19:06:28 2018
New Revision: 334565
URL: http://llvm.org/viewvc/llvm-project?rev=334565&view=rev
Log:
Fix crash emitting transparent list initializer for a large aggregate.
Modified:
cfe/trunk/lib/CodeGen/CGExprAgg.cpp
cfe/trunk/test/CodeGenCXX/value-init.cp
morehouse added a comment.
Where is the fuzz target?
Comment at: tools/clang-fuzzer/proto-to-llvm/loop_proto_to_llvm.cpp:33
+int ptr_ctr = 0;
+int val_ctr = 0;
+
I'd suggest wrapper functions that return unused variable names, so your code
below won't need to
george.karpenkov added subscribers: aaron.ballman, alexfh.
george.karpenkov added a comment.
Herald added a subscriber: mikhail.ramalho.
Getting there! Sorry for the delay. Would it be possible to rewrite the
remaining imperative code using matchers?
đź‘Ť on defining your own matcher. However, that
craig.topper added a comment.
I'll give the inline assembly a shot.
Repository:
rC Clang
https://reviews.llvm.org/D47672
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334561: [CUDA][HIP] Allow CUDA __global__ functions to have
amdgpu kernel attributes (authored by yaxunl, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://review
Author: yaxunl
Date: Tue Jun 12 16:58:59 2018
New Revision: 334561
URL: http://llvm.org/viewvc/llvm-project?rev=334561&view=rev
Log:
[CUDA][HIP] Allow CUDA __global__ functions to have amdgpu kernel attributes
There are HIP applications e.g. Tensorflow 1.3 using amdgpu kernel attributes,
however
Author: george.karpenkov
Date: Tue Jun 12 16:53:54 2018
New Revision: 334560
URL: http://llvm.org/viewvc/llvm-project?rev=334560&view=rev
Log:
[analyzer] Do not crash in the visitor when the function is given more
arguments than it has parameters
rdar://40335545
Differential Revision: https://r
emmettneyman updated this revision to Diff 151066.
emmettneyman added a comment.
- fixed proto_to_cxx.cpp
Repository:
rC Clang
https://reviews.llvm.org/D48106
Files:
tools/clang-fuzzer/CMakeLists.txt
tools/clang-fuzzer/cxx_loop_proto.proto
tools/clang-fuzzer/proto-to-cxx/loop_proto_to_
craig.topper added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:10071
+ // is _MM_FROUND_CUR_DIRECTION
+ if (cast(Ops[4])->getZExtValue() != 4)
+UsesNonDefaultRounding = true;
GBuella wrote:
> efriedma wrote:
> > Given we're ignoring f
emmettneyman updated this revision to Diff 151063.
emmettneyman added a comment.
- removed unneeded file
Repository:
rC Clang
https://reviews.llvm.org/D48106
Files:
tools/clang-fuzzer/CMakeLists.txt
tools/clang-fuzzer/cxx_loop_proto.proto
tools/clang-fuzzer/proto-to-cxx/loop_proto_to_c
emmettneyman created this revision.
emmettneyman added reviewers: kcc, vitalybuka, morehouse.
Herald added subscribers: cfe-commits, mgorny.
implemented proto_to_llvm
- also removed div and mod to eliminate UB
Repository:
rC Clang
https://reviews.llvm.org/D48106
Files:
tools/clang-fuzzer/
rsmith accepted this revision.
rsmith added a comment.
LGTM with one change.
Comment at: clang/include/clang/Basic/LangOptions.def:292
+BENIGN_LANGOPT(ForceEmitVTables, 1, 0,
+ "whether to emit all vtables")
I don't think this is benign or even
ethanhs added a comment.
In https://reviews.llvm.org/D47672#1128863, @rnk wrote:
> In https://reviews.llvm.org/D47672#1128308, @hans wrote:
>
> > It sounds like adding proper support for HLE prefixes is a largeish project.
> >
> > ctopper, rnk: Do you think it would be worth adding inline asm ver
Meinersbur added inline comments.
Comment at: lib/Sema/SemaOverload.cpp:6194
static SmallVector
getOrderedEnableIfAttrs(const FunctionDecl *Function) {
SmallVector Result;
nicholas wrote:
> This function shouldn't be necessary any more. All it's doing now is
nicholas added inline comments.
Comment at: lib/Sema/SemaOverload.cpp:6194
static SmallVector
getOrderedEnableIfAttrs(const FunctionDecl *Function) {
SmallVector Result;
This function shouldn't be necessary any more. All it's doing now is making an
unnecess
Author: ormris
Date: Tue Jun 12 15:22:35 2018
New Revision: 334554
URL: http://llvm.org/viewvc/llvm-project?rev=334554&view=rev
Log:
[analyzer] Ensure that loop widening does not invalidate references
Loop widening can invalidate a reference. If the analyzer attempts to visit the
destructor to a
ormris added a comment.
Hmm... I'll take a look.
Repository:
rC Clang
https://reviews.llvm.org/D47044
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NoQ accepted this revision.
NoQ added a comment.
I'm still curious whether this also works:
void foo() {
const A &x = B();
bar();
}
void bar() {
for (int i = 0; i < 10; ++i) {}
}
Though we can land this patch and deal with this later.
Repository:
rC Clang
https://revi
ormris marked an inline comment as done.
ormris added a comment.
Sounds good. I'll go ahead and commit this. Thanks for the review!
Repository:
rC Clang
https://reviews.llvm.org/D47044
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
ormris updated this revision to Diff 151046.
ormris added a comment.
Remove unneeded header
Repository:
rC Clang
https://reviews.llvm.org/D47044
Files:
lib/StaticAnalyzer/Core/LoopWidening.cpp
test/Analysis/loop-widening-preserve-reference-type.cpp
Index: test/Analysis/loop-widening-pr
Meinersbur created this revision.
Meinersbur added reviewers: hfinkel, TylerNowicki, ABataev, thakis, rjmccall,
george.burgess.iv, nicholas, nlewycky.
Herald added subscribers: atanasyan, zzheng.
... instead of prepending it at the beginning (the original behavior since
implemented in r122535 20
george.karpenkov accepted this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.
Looks good to me, apart from the nit on an unused header.
Comment at: lib/StaticAnalyzer/Core/LoopWidening.cpp:21
#include "clang/StaticAnalyzer/Core/Pat
ormris updated this revision to Diff 151043.
ormris added a comment.
- Use match function iterators rather than a callback class
- Update test
Repository:
rC Clang
https://reviews.llvm.org/D47044
Files:
lib/StaticAnalyzer/Core/LoopWidening.cpp
test/Analysis/loop-widening-preserve-referen
MarcoFalke updated this revision to Diff 151038.
MarcoFalke added a comment.
In python2.7:
TypeError: 'encoding' is an invalid keyword argument for this function
So remove it for now.
https://reviews.llvm.org/D48098
Files:
tools/clang-format/clang-format-diff.py
Index: tools/clang-format/c
MarcoFalke created this revision.
Repository:
rC Clang
https://reviews.llvm.org/D48098
Files:
tools/clang-format/clang-format-diff.py
Index: tools/clang-format/clang-format-diff.py
===
--- tools/clang-format/clang-format-diff.
Hey Petr,
FYI: clang has cmake caches that listed cxx-headers as a dependency;
I fixed that in:
r334550 [CMake][Darwin] Match cxx-headers -> cxx_headers libcxx target rename.
-Ahmed
On Mon, Jun 11, 2018 at 11:58 PM, Petr Hosek via cfe-commits
wrote:
> Author: phosek
> Date: Mon Jun 11 23:58:06
Author: ab
Date: Tue Jun 12 14:27:36 2018
New Revision: 334550
URL: http://llvm.org/viewvc/llvm-project?rev=334550&view=rev
Log:
[CMake][Darwin] Match cxx-headers -> cxx_headers libcxx target rename.
This was changed in r334477.
Modified:
cfe/trunk/cmake/caches/Apple-stage2.cmake
Modified:
leonardchan abandoned this revision.
leonardchan added a comment.
No longer setting fractional and integral bits at configure time. These values
are set and checked in TargetInfo.
Repository:
rC Clang
https://reviews.llvm.org/D47030
___
cfe-comm
rnk added a comment.
In https://reviews.llvm.org/D47988#1127432, @smeenai wrote:
> Any idea why we would see inlining in one case and not the other? i686 vs.
> x86-64 doesn't make any difference, and neither does -Os vs. -O1 vs. -O2.
My theory is that the inliner is attempting to avoid inlinin
leonardchan added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:89
+ // corresponding unsaturated types.
+ unsigned char ShortAccumFBits, ShortAccumIBits;
+ unsigned char AccumFBits, AccumIBits;
ebevhan wrote:
> leonardchan wrote:
> > ebevhan w
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D48053
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
leonardchan updated this revision to Diff 151016.
leonardchan marked 9 inline comments as done.
Repository:
rC Clang
https://reviews.llvm.org/D46915
Files:
include/clang/AST/ASTContext.h
include/clang/AST/Expr.h
include/clang/AST/OperationKinds.def
include/clang/AST/RecursiveASTVisitor
Author: george.karpenkov
Date: Tue Jun 12 13:51:19 2018
New Revision: 334542
URL: http://llvm.org/viewvc/llvm-project?rev=334542&view=rev
Log:
[analyzer] [NFC] Remove "removeInvalidation" from visitor API
removeInvalidation is a very problematic API, as it makes suppression
order-dependent.
Moreo
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334541: [analyzer] [NFC] Move ::dump methods from
BugReporter.cpp to PathDiagnostics.cpp (authored by george.karpenkov, committed
by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334542: [analyzer] [NFC] Remove
"removeInvalidation" from visitor API (authored by george.karpenkov,
committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334542: [analyzer] [NFC] Remove
"removeInvalidation" from visitor API (authored by george.karpenkov,
committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews.llv
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334540: [analyzer] [NFC] Remove most usages of getEndPath
(authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews.llvm.org/D48042?
Author: george.karpenkov
Date: Tue Jun 12 13:51:01 2018
New Revision: 334541
URL: http://llvm.org/viewvc/llvm-project?rev=334541&view=rev
Log:
[analyzer] [NFC] Move ::dump methods from BugReporter.cpp to PathDiagnostics.cpp
BugReporter.cpp is already severely overloaded, and those dump methods
ar
Author: george.karpenkov
Date: Tue Jun 12 13:50:44 2018
New Revision: 334540
URL: http://llvm.org/viewvc/llvm-project?rev=334540&view=rev
Log:
[analyzer] [NFC] Remove most usages of getEndPath
getEndPath is a problematic API, because it's not clear when it's called
(hint: not always at the end of
The length of that path is about 257, or very near MAX_PATH, which suggests
that the version of rm you are using does not tolerate deep paths. This has
been a long standing problem, and our solution to it was to install a
special version of rm.exe on all of our buildbots that reliably handles
long
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
That should work. Thanks!
https://reviews.llvm.org/D47996
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
Author: maskray
Date: Tue Jun 12 13:44:11 2018
New Revision: 334539
URL: http://llvm.org/viewvc/llvm-project?rev=334539&view=rev
Log:
Work around false -Wmissing-braces warning from old clang which has been fixed
in r314838
Modified:
cfe/trunk/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp
Hello Hans,
The test Driver/crash-report-modules.m still fails on one of windows
builder:
http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/10221
. . .
Failing Tests (1):
Clang :: Driver/crash-report-modules.m
Please have a look?
Thanks
Galina
On Tue, Jun
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334531: [AArch64] Support reserving x20 register (authored
by phosek, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews.llvm.org/D46552?vs=150601&id=151006
Author: phosek
Date: Tue Jun 12 13:00:50 2018
New Revision: 334531
URL: http://llvm.org/viewvc/llvm-project?rev=334531&view=rev
Log:
[AArch64] Support reserving x20 register
Register x20 is a callee-saved register which may be used for other
purposes in certain contexts, for example to hold speci
ormris added inline comments.
Comment at: lib/StaticAnalyzer/Core/LoopWidening.cpp:89
+new Callback(LCtx, MRMgr, ITraits));
+ Finder.matchAST(ASTCtx);
+
NoQ wrote:
> ormris wrote:
> > ormris wrote:
> > > NoQ wrote:
> > > > NoQ wrote:
> > > >
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/LoopWidening.cpp:89
+new Callback(LCtx, MRMgr, ITraits));
+ Finder.matchAST(ASTCtx);
+
ormris wrote:
> ormris wrote:
> > NoQ wrote:
> > > NoQ wrote:
> > > > george.karpenkov wrote
ormris added inline comments.
Comment at: lib/StaticAnalyzer/Core/LoopWidening.cpp:89
+new Callback(LCtx, MRMgr, ITraits));
+ Finder.matchAST(ASTCtx);
+
ormris wrote:
> NoQ wrote:
> > NoQ wrote:
> > > george.karpenkov wrote:
> > > > ormris wr
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334527: [clang-format] Fix crash while reflowing backslash
in comments (authored by krasimir, committed by ).
Changed pri
Author: krasimir
Date: Tue Jun 12 12:33:15 2018
New Revision: 334527
URL: http://llvm.org/viewvc/llvm-project?rev=334527&view=rev
Log:
[clang-format] Fix crash while reflowing backslash in comments
Summary:
The added test case was currently crashing with an assertion:
```
krasimir@krasimir> cat t
sammccall added a comment.
Sorry for the delay on this change. There's a bunch of complexity in this
problem that I haven't seen how to slice through:
1. the signals needed seem like a weird fit for the Symbol*Signals structs for
some reason (maybe my misdesign)
2. the inconsistency between how
krasimir created this revision.
Herald added a subscriber: cfe-commits.
The added test case was currently crashing with an assertion:
Repository:
rC Clang
https://reviews.llvm.org/D48089
Files:
lib/Format/BreakableToken.cpp
unittests/Format/FormatTestComments.cpp
Index: unittests/Forma
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334526: [analyzer] [NFC] Now let's have only one place
for diagnostics generation (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334525: [analyzer] [NFC] Unify Minimal and Extensive
diagnostics. (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews.llvm.org
sammccall added a comment.
Not ignoring this patch: the implementation LG, whether it's the right design
depends on where https://reviews.llvm.org/D47935 ends up I think.
(I suspect this is what we want, is there any urgency to landing this part?)
Repository:
rCTE Clang Tools Extra
https://r
Author: george.karpenkov
Date: Tue Jun 12 12:08:17 2018
New Revision: 334526
URL: http://llvm.org/viewvc/llvm-project?rev=334526&view=rev
Log:
[analyzer] [NFC] Now let's have only one place for diagnostics generation
Differential Revision: https://reviews.llvm.org/D47808
Modified:
cfe/trunk/
Author: george.karpenkov
Date: Tue Jun 12 12:08:00 2018
New Revision: 334525
URL: http://llvm.org/viewvc/llvm-project?rev=334525&view=rev
Log:
[analyzer] [NFC] Unify Minimal and Extensive diagnostics.
Once we removed AlternateExtensive, I've looked closer into the
difference between Minimal and E
On Tue, Jun 12, 2018 at 4:43 AM Hans Wennborg wrote:
> Actually, maybe switching the order from "not env ... %clang" to "env
> ... not %clang" might work...
>
Thanks, I was going to try that next.
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rkirsling updated this revision to Diff 150984.
rkirsling added a comment.
Addressed feedback—thank you for the review!
Repository:
rC Clang
https://reviews.llvm.org/D46024
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Format/TokenAnn
tra added a comment.
Last comment in the bug pointed out that those overloads should be constexpr in
c++14. Maybe in a separate patch, though.
https://bugs.llvm.org/show_bug.cgi?id=37753#c5
https://reviews.llvm.org/D48036
___
cfe-commits mailing l
GBuella added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:10071
+ // is _MM_FROUND_CUR_DIRECTION
+ if (cast(Ops[4])->getZExtValue() != 4)
+UsesNonDefaultRounding = true;
efriedma wrote:
> Given we're ignoring floating-point exceptions
smeenai added a comment.
In https://reviews.llvm.org/D47233#1129810, @DHowett-MSFT wrote:
> In https://reviews.llvm.org/D47233#1129207, @rjmccall wrote:
>
> > In https://reviews.llvm.org/D47233#1129110, @smeenai wrote:
> >
> > > WinObjC does this wrapping, for example.
> >
> >
> > I see. The ide
Author: zturner
Date: Tue Jun 12 10:43:52 2018
New Revision: 334518
URL: http://llvm.org/viewvc/llvm-project?rev=334518&view=rev
Log:
Refactor ExecuteAndWait to take StringRefs.
This simplifies some code which had StringRefs to begin with, and
makes other code more complicated which had const cha
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/GlobalCompilationDatabase.cpp:137
+ // 'It' may be invalid at this point, recompute it.
+ It = Cached.find(File);
+ if (It != Cached.end())
--
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
Thank you.
https://reviews.llvm.org/D47958
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334517: [clang-format] Discourage breaks in submessage
entries, hard rule (authored by krasimir, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D4
Author: krasimir
Date: Tue Jun 12 10:26:31 2018
New Revision: 334517
URL: http://llvm.org/viewvc/llvm-project?rev=334517&view=rev
Log:
[clang-format] Discourage breaks in submessage entries, hard rule
Summary:
Currently clang-format allows this for text protos:
```
submessage:
{ key: 'aaa
krasimir updated this revision to Diff 150980.
krasimir added a comment.
- Split-up the if-condition
Repository:
rC Clang
https://reviews.llvm.org/D48063
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestProto.cpp
unittests/Format/FormatTestTextProto.cpp
Index: unittests
klimek accepted this revision.
klimek added a comment.
In https://reviews.llvm.org/D46024#1129350, @hans wrote:
> In https://reviews.llvm.org/D46024#1121242, @rkirsling wrote:
>
> > FWIW, please note that this space-before-brace style is not specific to
> > WebKit; CppCoreGuidelines exhibits it
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Format/TokenAnnotator.cpp:3104
if (Left.is(tok::colon) && Left.isOneOf(TT_DictLiteral, TT_ObjCMethodExpr)) {
if ((Style.Language == FormatSt
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ioeric.
These have few signals other than being keywords, so the boost is high.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48083
Files:
cla
djasper added a comment.
You are right that this behavior is what the code authors, but also many other
people, like to have and so it is what is engrained in clang-format. There are
likely about a million things that fall into the same category. Now we might
find that the current default is ac
DHowett-MSFT added a comment.
In https://reviews.llvm.org/D47233#1129207, @rjmccall wrote:
> In https://reviews.llvm.org/D47233#1129110, @smeenai wrote:
>
> > WinObjC does this wrapping, for example.
>
>
> I see. The idea of creating the type descriptors and mangled names ad-hoc
> for the catch
lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.
Looks good to me, but you probably want a bit for a second opinion.
https://reviews.llvm.org/D47435
___
cfe-commits mailing list
cfe-comm
aaron.ballman added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:925
+ case Builtin::BI__builtin_signbitl:
if (SemaBuiltinFPClassification(TheCall, 1))
return ExprError();
lebedev.ri wrote:
> The name of the function is unfortunate given th
aaron.ballman updated this revision to Diff 150967.
aaron.ballman marked 5 inline comments as done.
aaron.ballman added a comment.
Updating based on review feedback.
https://reviews.llvm.org/D47435
Files:
lib/Sema/SemaChecking.cpp
test/Sema/builtins.c
Index: test/Sema/builtins.c
=
tobiasvk updated this revision to Diff 150965.
tobiasvk added a comment.
- Rebase for current tree
- Fix -flto -save-temps which the previous patch broke
https://reviews.llvm.org/D34156
Files:
clang/include/clang/Frontend/CodeGenOptions.def
clang/lib/CodeGen/BackendUtil.cpp
clang/lib/Code
ebevhan added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:89
+ // corresponding unsaturated types.
+ unsigned char ShortAccumFBits, ShortAccumIBits;
+ unsigned char AccumFBits, AccumIBits;
leonardchan wrote:
> ebevhan wrote:
> > I suspect it'
gtbercea updated this revision to Diff 150947.
gtbercea added a comment.
Added separate test.
Repository:
rC Clang
https://reviews.llvm.org/D47394
Files:
include/clang/Driver/Action.h
include/clang/Driver/Compilation.h
include/clang/Driver/Driver.h
include/clang/Driver/Options.td
i
Typz added a comment.
In https://reviews.llvm.org/D42787#1127790, @djasper wrote:
> The normal rule for formatting options apply. If you can dig up a public
> style guide and a project of reasonable size where it is used, we can add an
> option.
I don't want to be rude, but it seems to me tha
lebedev.ri added a comment.
The checking by itself looks sane-ish, but i don't have any reasonable
knowledge in this area.
Comment at: lib/Sema/SemaChecking.cpp:925
+ case Builtin::BI__builtin_signbitl:
if (SemaBuiltinFPClassification(TheCall, 1))
return ExprError
Author: erichkeane
Date: Tue Jun 12 06:59:32 2018
New Revision: 334503
URL: http://llvm.org/viewvc/llvm-project?rev=334503&view=rev
Log:
Fix overload resolution between Ptr-To-Member and Bool
As reported here (https://bugs.llvm.org/show_bug.cgi?id=19808)
and discovered independently when looking
aaron.ballman added a comment.
Ping
Repository:
rC Clang
https://reviews.llvm.org/D47435
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thakis added a comment.
What's the status here? The MS STL has this feature under _HAS_NODISCARD and
it's super useful.
Repository:
rCXX libc++
https://reviews.llvm.org/D45179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
erichkeane updated this revision to Diff 150934.
erichkeane marked an inline comment as done.
erichkeane added a comment.
Add error checking to perform copy init.
https://reviews.llvm.org/D48053
Files:
lib/Sema/SemaChecking.cpp
test/SemaCXX/builtins-overflow.cpp
Index: lib/Sema/SemaChecki
erichkeane added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:228
+ S.getASTContext(), Ty, /*consume*/ false);
+ Arg = S.PerformCopyInitialization(Entity, SourceLocation(), Arg);
+ TheCall->setArg(2, Arg.get());
efriedma wrote:
> Is i
1 - 100 of 130 matches
Mail list logo
