srhines abandoned this revision.
srhines added a comment.
Removed this in favor of the suggestions here. Setting the
CMAKE_FIND_ROOT_PATH_MODE* variables does make this properly hermetic.
Repository:
rC Clang
https://reviews.llvm.org/D48459
___
arphaman created this revision.
arphaman added a reviewer: dexonsmith.
There's a bug in libclang in which it tries to evaluate a statement cursor as a
declaration cursor, because that statement still has a pointer to the
declaration parent. This patch fixes it.
rdar://3477
Repository:
Author: epilk
Date: Fri Jul 6 18:50:20 2018
New Revision: 336478
URL: http://llvm.org/viewvc/llvm-project?rev=336478=rev
Log:
[Sema] Emit -Wincomplete-implementation for partial methods.
Fixes rdar://40634455
Modified:
cfe/trunk/lib/Sema/SemaDeclObjC.cpp
chandlerc resigned from this revision.
chandlerc added a comment.
I don't have any problem with this patch's code in theory but:
1. The question of whether this macro approach is better or worse than
FreeBSD's or MUSL's seems a question for libc++ maintainers, not me.
2. The question of whether
Author: rtrieu
Date: Fri Jul 6 17:17:25 2018
New Revision: 336475
URL: http://llvm.org/viewvc/llvm-project?rev=336475=rev
Log:
Check returned type is valid before using it.
Add a .isNull() check to returned QualType. Fixes PR38077
Modified:
cfe/trunk/lib/Sema/SemaCXXScopeSpec.cpp
apazos added a comment.
Hi Aaron, I have commit rights and will commit if after Alex and other RISC-V
colleagues get a chance to review too.
https://reviews.llvm.org/D48412
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
efriedma updated this revision to Diff 154471.
efriedma retitled this revision from "[WIP] Diagnose invalid cv-qualifiers for
friend decls." to "Diagnose invalid cv-qualifiers for friend decls.".
efriedma edited the summary of this revision.
efriedma added a comment.
Updated to handle the
anniecherk updated this revision to Diff 154470.
anniecherk added a comment.
Updated according to Julie's suggestions, mostly adjusted formatting.
https://reviews.llvm.org/D48395
Files:
clang-tools-extra/clang-doc/ClangDoc.cpp
clang-tools-extra/clang-doc/ClangDoc.h
Author: ctopper
Date: Fri Jul 6 15:46:52 2018
New Revision: 336472
URL: http://llvm.org/viewvc/llvm-project?rev=336472=rev
Log:
[X86] When creating a select for scalar masked sqrt and div builtins make sure
we optimize the all ones mask case.
This case occurs in the intrinsic headers so we
leonardchan added inline comments.
Comment at: lib/Basic/FixedPoint.cpp:40
+ if (DstWidth > Val.getBitWidth())
+Val = Val.extend(DstWidth);
+ if (Upscaling)
ebevhan wrote:
> leonardchan wrote:
> > ebevhan wrote:
> > > It should be possible to replace this
leonardchan updated this revision to Diff 154465.
leonardchan marked 4 inline comments as done.
Repository:
rC Clang
https://reviews.llvm.org/D48661
Files:
include/clang/AST/ASTContext.h
include/clang/Basic/FixedPoint.h
include/clang/Basic/TargetInfo.h
lib/AST/ASTContext.cpp
Author: paquette
Date: Fri Jul 6 15:24:56 2018
New Revision: 336471
URL: http://llvm.org/viewvc/llvm-project?rev=336471=rev
Log:
[MachineOutliner] Properly pass -moutline along to the toolchain
This moves the LTO-specific code for outlining from ToolChains/Clang.cpp to
ToolChains/Darwin.cpp.
Quuxplusone added inline comments.
Comment at: libcxx/include/memory:1470
+decltype(_VSTD::declval<_Alloc>().construct(_VSTD::declval<_Pointer>(),
+_VSTD::declval<_Args>())),
+void
vsapsai
lebedev.ri added a comment.
Some drive-by nits.
General observation: this is kinda large.
I would //personally// split split off the codegen part into a second patch.
Comment at: include/clang/AST/Decl.h:2212-2213
+ bool isCPUDispatchMultiVersion() const;
+ bool
Author: ctopper
Date: Fri Jul 6 15:08:43 2018
New Revision: 336470
URL: http://llvm.org/viewvc/llvm-project?rev=336470=rev
Log:
[X86] Add missing scalar fma intrinsics with rounding, but no mask.
We had the mask versions of the rounding intrinsics, but not one without
masking.
Also change the
simark added a comment.
I found something fishy. There is this code in FileManager.cpp:
if (UFE.File)
if (auto RealPathName = UFE.File->getName())
UFE.RealPathName = *RealPathName;
The real path is obtained from `UFE.File->getName()`. In the `RealFile`
implementation, it returns
erichkeane created this revision.
erichkeane added reviewers: rsmith, aaron.ballman, mibintc, mikerice, Manna.
As listed in the above PRs, vector_size doesn't allow
dependent types/values. This patch introduces a new
DependentVectorType to handle a VectorType that has a dependent
size or type.
erichkeane added a comment.
Bump!
https://reviews.llvm.org/D47474
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsapsai added inline comments.
Comment at: libcxx/include/memory:1470
+decltype(_VSTD::declval<_Alloc>().construct(_VSTD::declval<_Pointer>(),
+_VSTD::declval<_Args>())),
+void
Quuxplusone
This revision was automatically updated to reflect the committed changes.
Closed by commit rC336468: [ASTMatchers] A matcher for Objective-C
@autoreleasepool (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
Author: george.karpenkov
Date: Fri Jul 6 14:36:04 2018
New Revision: 336468
URL: http://llvm.org/viewvc/llvm-project?rev=336468=rev
Log:
[ASTMatchers] A matcher for Objective-C @autoreleasepool
Differential Revision: https://reviews.llvm.org/D48910
Modified:
Author: abataev
Date: Fri Jul 6 14:13:41 2018
New Revision: 336467
URL: http://llvm.org/viewvc/llvm-project?rev=336467=rev
Log:
[OPENMP] Fix PR38026: Link -latomic when -fopenmp is used.
On Linux atomic constructs in OpenMP require libatomic library. Patch
links libatomic when -fopenmp is used.
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM! Do you need me to commit on your behalf, or do you have commit privileges?
https://reviews.llvm.org/D48412
___
cfe-commits
apazos updated this revision to Diff 154447.
apazos added a comment.
Thanks Aaron, I appreciate you taking the time to review.
I have updated the test and removed the warning as discussed.
https://reviews.llvm.org/D48412
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
vsapsai added a comment.
In https://reviews.llvm.org/D47687#1136351, @Higuoxing wrote:
> Sorry, It seems a little bit difficult for me to add a proper fix-it hint for
> expressions in macros, because I cannot find the exact position of the last
> char of the token on right hand side of
Author: abataev
Date: Fri Jul 6 12:35:42 2018
New Revision: 336460
URL: http://llvm.org/viewvc/llvm-project?rev=336460=rev
Log:
[OPENMP] Make clauses closing loc point to right bracket.
For some of the clauses the closing location erroneously points to the
beginning of the next clause rather
bruno added a comment.
Herald added a subscriber: dexonsmith.
Ping!
https://reviews.llvm.org/D48685
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
QF5690 added inline comments.
Comment at: lib/Sema/SemaObjCProperty.cpp:2554
+ PropertyTy->isObjCRetainableType() &&
+ !PropertyTy->isObjCClassType()) {
+Diag(Loc, diag::warn_objc_property_assign_on_object);
rjmccall wrote:
> Please use
simark updated this revision to Diff 154422.
simark marked an inline comment as done.
simark added a comment.
- Use StringRef in InMemoryNode::getStatus
- Remove unused variable in TEST_F(InMemoryFileSystemTest, StatusName)
Repository:
rC Clang
https://reviews.llvm.org/D48903
Files:
martong updated this revision to Diff 154421.
martong added a comment.
Fix indentation
Repository:
rC Clang
https://reviews.llvm.org/D47632
Files:
include/clang/AST/ASTImporter.h
include/clang/AST/ASTStructuralEquivalence.h
include/clang/AST/DeclBase.h
lib/AST/ASTImporter.cpp
Szelethus marked 3 inline comments as done.
Szelethus added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:691
+StringRef getVariableName(const FieldDecl *Field) {
+ // If \p Field is a captured lambda variable, Field->getName() will
Szelethus updated this revision to Diff 154420.
Szelethus added a comment.
Finding the correct captured variable now works with
`FieldDecl::getFieldIndex()`.
https://reviews.llvm.org/D48291
Files:
lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp
martong updated this revision to Diff 154418.
martong added a comment.
- Rebase from master
- Enable some disabled tests
- Update the isUsed flag
- Add a new config `Minimal` to the structural eq check, so lldb tests can pass
now
- Return with a bool value and use LLVM_NODISCARD in CreateDecl
-
ldionne added inline comments.
Comment at: libcxx/include/streambuf:261
-_LIBCPP_ALWAYS_INLINE
+_LIBCPP_INLINE_VISIBILITY
void __pbump(streamsize __n) { __nout_ += __n; }
This one was marked as `_LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY` instead
ldionne updated this revision to Diff 154415.
ldionne added a comment.
This revision to the patch fixes a problem where __pbump had been applied
_LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY instead of _LIBCPP_INLINE_VISIBILITY,
which caused the symbols exported in the ABI to change and broke the CI.
ioeric updated this revision to Diff 154414.
ioeric added a comment.
- Another minor cleanup.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49028
Files:
clangd/index/SymbolCollector.cpp
clangd/index/SymbolCollector.h
unittests/clangd/SymbolCollectorTests.cpp
Index:
ioeric updated this revision to Diff 154413.
ioeric added a comment.
- Some cleanup.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49028
Files:
clangd/index/SymbolCollector.cpp
clangd/index/SymbolCollector.h
unittests/clangd/SymbolCollectorTests.cpp
Index:
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ilya-biryukov.
This is not enabled in the global-symbol-builder or dynamic index yet.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49028
Files:
simark added a comment.
In https://reviews.llvm.org/D49008#1154196, @sammccall wrote:
> @simark - is it OK if I pick this up?
Yes, totally fine. I didn't have time to follow up on my patch, and I think
you did a great job here. I tested it, and I see that my main pain point was
addressed.
sammccall updated this revision to Diff 154402.
sammccall added a comment.
rebase
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49008
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/ClangdUnit.cpp
clangd/CodeComplete.cpp
clangd/Compiler.cpp
Szelethus updated this revision to Diff 154398.
Szelethus added a comment.
MemberPointerTypes are regarded as primitive types from now. I agree with @NoQ,
it makes so much more sense this way :)
https://reviews.llvm.org/D48325
Files:
hokein added a comment.
still LGTM.
The diff contains unrelated changes now.
Comment at: clangd/tool/ClangdMain.cpp:104
+llvm::cl::values(clEnumVal(Logger::Error, "Error messages only"),
+ clEnumVal(Logger::Info, "High level execution tracing"),
+
hokein added a comment.
Herald added a subscriber: omtcyfz.
The code looks good. I'll let Ben take a final look.
Comment at: lib/Basic/VirtualFileSystem.cpp:485
+ /// \p Status::Name in the return value, to mimic the behavior of \p
RealFile.
+ Status getStatus(std::string
sammccall added inline comments.
Comment at: clangd/tool/ClangdMain.cpp:104
+llvm::cl::values(clEnumVal(Logger::Error, "Error messages only"),
+ clEnumVal(Logger::Info, "High level execution tracing"),
+ clEnumVal(Logger::Debug, "Low
sammccall updated this revision to Diff 154391.
sammccall added a comment.
Herald added a subscriber: mgorny.
Name debug->verbose
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49008
Files:
clang-tidy/cert/CERTTidyModule.cpp
clang-tidy/cert/CMakeLists.txt
Szelethus added a comment.
Polite ping ^-^
https://reviews.llvm.org/D48436
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Nice, look good.
Comment at: clangd/tool/ClangdMain.cpp:104
+llvm::cl::values(clEnumVal(Logger::Error, "Error messages only"),
+
ioeric updated this revision to Diff 154390.
ioeric added a comment.
- removed Undefined parameter.
Repository:
rC Clang
https://reviews.llvm.org/D48961
Files:
include/clang/Index/IndexDataConsumer.h
include/clang/Index/IndexSymbol.h
include/clang/Index/IndexingAction.h
aaron.ballman added inline comments.
Comment at: test/Sema/riscv-interrupt-attr.c:23
+ // expected-note
{{repeated RISC-V 'interrupt' attribute is here}}
+__attribute__((interrupt("user"))) void foo8() {}
Author: sammccall
Date: Fri Jul 6 04:50:49 2018
New Revision: 336431
URL: http://llvm.org/viewvc/llvm-project?rev=336431=rev
Log:
[clangd] Make SymbolOrigin an enum class, rather than a plain enum.
I never intended to define namespace pollution like clangd::AST, clangd::Unknown
etc. Oops!
ioeric updated this revision to Diff 154388.
ioeric marked 6 inline comments as done.
ioeric added a comment.
- addressed review comments.
Repository:
rC Clang
https://reviews.llvm.org/D48961
Files:
include/clang/Index/IndexDataConsumer.h
include/clang/Index/IndexSymbol.h
ioeric added inline comments.
Comment at: include/clang/Index/IndexDataConsumer.h:48
/// \returns true to continue indexing, or false to abort.
- virtual bool handleMacroOccurence(const IdentifierInfo *Name,
-const MacroInfo *MI,
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/Quality.cpp:48
+ if (R.ShadowDecl) {
+const auto Loc = SourceMgr.getSpellingLoc(R.ShadowDecl->getLocation());
+if
This revision was automatically updated to reflect the committed changes.
Closed by commit rC336429: [Driver,AArch64] Add support for -mcpu=native.
(authored by fhahn, committed by ).
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D48931
Files:
Author: fhahn
Date: Fri Jul 6 03:49:59 2018
New Revision: 336429
URL: http://llvm.org/viewvc/llvm-project?rev=336429=rev
Log:
[Driver,AArch64] Add support for -mcpu=native.
This patches adds support for passing -mcpu=native for AArch64. It will
get turned into the host CPU name, before we get
omtcyfz updated this revision to Diff 154383.
omtcyfz marked 10 inline comments as done.
omtcyfz added a comment.
Address the comments, add a couple of FIXMEs for the future.
https://reviews.llvm.org/D49012
Files:
clang-tools-extra/clangd/Quality.cpp
sammccall added a comment.
This borrows from https://reviews.llvm.org/D44226 (log levels) which got
stalled for various reasons (@simark - is it OK if I pick this up?).
It doesn't actually split the LSP messages vs LSP message names into different
levels, but that's a simple followup.
ioeric added a comment.
Nice!
Just one caveat regarding locations in addition to Sam's comments :)
Comment at: clang-tools-extra/clangd/Quality.cpp:48
+ if (R.ShadowDecl) {
+const auto Loc = SourceMgr.getSpellingLoc(R.ShadowDecl->getLocation());
+if
sammccall added a comment.
Nice! Mostly just a few nits.
Comment at: clang-tools-extra/unittests/clangd/QualityTests.cpp:83
+
+namespace foo {
+class Bar {};
nit: can we have slightly more descriptive names here as this is a long test?
e.g. `namespace
This revision was automatically updated to reflect the committed changes.
Closed by commit rC336427: [SemaCodeComplete] Expose a method to create
CodeCompletionString for macros. (authored by ioeric, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48973?vs=154370=154380#toc
Author: ioeric
Date: Fri Jul 6 02:43:57 2018
New Revision: 336427
URL: http://llvm.org/viewvc/llvm-project?rev=336427=rev
Log:
[SemaCodeComplete] Expose a method to create CodeCompletionString for macros.
Summary:
The method only takes PPreprocessor and don't require structures that
might not
omtcyfz updated this revision to Diff 154379.
omtcyfz added a comment.
Add const qualifier to UsingShadowDecl in unit tests.
https://reviews.llvm.org/D49012
Files:
clang-tools-extra/clangd/Quality.cpp
clang-tools-extra/unittests/clangd/QualityTests.cpp
omtcyfz updated this revision to Diff 154377.
omtcyfz added a comment.
Remove comments from TestTU.cpp, both functions are properly documented in the
corresponding header.
https://reviews.llvm.org/D49012
Files:
clang-tools-extra/clangd/Quality.cpp
omtcyfz created this revision.
omtcyfz added reviewers: ioeric, sammccall, ilya-biryukov.
omtcyfz added a project: clang-tools-extra.
Herald added subscribers: jkorous, MaskRay.
Having `using qualified::name;` for some symbol is an important signal for
clangd code completion as the user is more
sammccall added inline comments.
Comment at: include/clang/Index/IndexDataConsumer.h:48
/// \returns true to continue indexing, or false to abort.
- virtual bool handleMacroOccurence(const IdentifierInfo *Name,
-const MacroInfo *MI,
GBuella requested review of this revision.
GBuella added a comment.
Well, apparently the test fails with the typo fix.
There is no `declare dllimport void @_ZSt9terminatev()` line that could be
matched for `CHECK-DYNAMIC-IA-DAG`.
Repository:
rC Clang
https://reviews.llvm.org/D48921
yvvan created this revision.
yvvan added a reviewer: nathawes.
Herald added subscribers: ioeric, ilya-biryukov.
Should be compatible with the current index format accepted by clangd
https://reviews.llvm.org/D49010
Files:
include/clang/Index/IndexRecordReader.h
sammccall created this revision.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ioeric, javed.absar,
ilya-biryukov.
log() is split into four functions:
- elog()/log()/vlog() have different severity levels, allowing filtering
- dlog() is a lazy macro which uses LLVM_DEBUG - it logs to
ioeric updated this revision to Diff 154370.
ioeric added a comment.
- Merged with orgin/master
Repository:
rC Clang
https://reviews.llvm.org/D48973
Files:
include/clang/Sema/CodeCompleteConsumer.h
lib/Sema/SemaCodeComplete.cpp
Index: lib/Sema/SemaCodeComplete.cpp
sammccall added a comment.
Thanks for the explanation!
Repository:
rC Clang
https://reviews.llvm.org/D48973
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric updated this revision to Diff 154369.
ioeric added a comment.
- Addressed review comments.
Repository:
rC Clang
https://reviews.llvm.org/D48973
Files:
include/clang/Sema/CodeCompleteConsumer.h
lib/Sema/SemaCodeComplete.cpp
Index: lib/Sema/SemaCodeComplete.cpp
ioeric added inline comments.
Comment at: include/clang/Sema/CodeCompleteConsumer.h:921
bool IncludeBriefComments);
+ CodeCompletionString *
+ CreateCodeCompletionStringForMacro(Preprocessor ,
sammccall wrote:
>
ioeric added a comment.
Thanks for the review!
In https://reviews.llvm.org/D48961#1152999, @sammccall wrote:
> I worry this is a trap: the indexing infrastructure here is designed so you
> can run it as a frontendaction, on an ASTUnit, or by passing a set of top
> level decls.
> However the
ioeric updated this revision to Diff 154367.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- Addressed review comments. Expose create a PPCallbacks for indexing macros.
Repository:
rC Clang
https://reviews.llvm.org/D48961
Files:
include/clang/Index/IndexDataConsumer.h
martong accepted this revision.
martong added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rC Clang
https://reviews.llvm.org/D48941
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: ctopper
Date: Fri Jul 6 00:14:47 2018
New Revision: 336417
URL: http://llvm.org/viewvc/llvm-project?rev=336417=rev
Log:
[X86] Implement _builtin_ia32_vfmaddss and _builtin_ia32_vfmaddsd with native
IR using llvm.fma intrinsic.
This generates some extra zeroing currently, but we should
Author: hans
Date: Thu Jul 5 23:54:16 2018
New Revision: 336415
URL: http://llvm.org/viewvc/llvm-project?rev=336415=rev
Log:
[ms] Fix mangling of string literals used to initialize arrays larger or
smaller than the literal
A Chromium developer reported a bug which turned out to be a mangling
This revision was automatically updated to reflect the committed changes.
hans marked 2 inline comments as done.
Closed by commit rC336415: [ms] Fix mangling of string literals used to
initialize arrays larger or… (authored by hans, committed by ).
Changed prior to commit:
WimLeflere added a comment.
Who can merge these changes?
Or does this happen automatically?
Repository:
rC Clang
https://reviews.llvm.org/D48827
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
hans marked 3 inline comments as done.
hans added inline comments.
Comment at: lib/AST/MicrosoftMangle.cpp:3198
+ ->getSize()
+ .getZExtValue();
+
thakis wrote:
> nit: Also do `unsigned StingByteLength =
baloghadamsoftware marked an inline comment as not done.
baloghadamsoftware added inline comments.
Comment at: test/Analysis/invalidated-iterator.cpp:32
+ *i0; // expected-warning{{Invalidated iterator accessed}}
+}
whisperity wrote:
> This might not be
baloghadamsoftware updated this revision to Diff 154358.
baloghadamsoftware marked 2 inline comments as done.
baloghadamsoftware added a comment.
Re-upload because of a mistake.
https://reviews.llvm.org/D32747
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
baloghadamsoftware accepted this revision.
baloghadamsoftware added a comment.
This revision is now accepted and ready to land.
LGTM! But wait for Artem's acceptance before submitting.
Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:311
+if
baloghadamsoftware updated this revision to Diff 154357.
baloghadamsoftware added a comment.
Updated according to the comments.
https://reviews.llvm.org/D32747
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/IteratorChecker.cpp
84 matches
Mail list logo
