hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:108
return;
+ if (const auto *Ctor = dyn_cast(Function)) {
+for (const auto *Init : Ctor->in
ioeric updated this revision to Diff 158941.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- address review comments.
Repository:
rC Clang
https://reviews.llvm.org/D50189
Files:
lib/Tooling/Core/Lookup.cpp
unittests/Tooling/LookupTest.cpp
Index: unittests/Tooling/Look
ioeric added inline comments.
Comment at: lib/Tooling/Core/Lookup.cpp:139
+const NamespaceDecl *NS = *I;
+auto LookupRes = NS->lookup(DeclarationName(&AST.Idents.get(Head)));
+if (!LookupRes.empty()) {
ilya-biryukov wrote:
> This will not take using n
ilya-biryukov added a comment.
Thanks for the change! Overall LG, mostly NITs about the tests.
Comment at: clangd/CodeComplete.cpp:959
bool Incomplete = false; // Would more be available with a higher limit?
- llvm::Optional Filter; // Initialized once Sema runs.
- s
SjoerdMeijer added a comment.
Hi Eli, thanks for the feedback.
> Yes, this logic should be in TargetParser, not here. Trying to rewrite the
> target features afterwards is messy at best. (Actually, the target feature
> list generated by TargetParser probably shouldn't contain the string "crypto
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D50189
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
bogden created this revision.
bogden added a reviewer: SjoerdMeijer.
Herald added a reviewer: javed.absar.
Herald added subscribers: cfe-commits, chrib, kristof.beyls.
v8.4-A adds a few fp16 instructions that can optionally be implemented
in CPUs of v8.2-A and above.
This patch adds a feature to
mprobst created this revision.
mprobst added a reviewer: krasimir.
Previously, clang-format would avoid breaking before the first `{`
found, but then happily break before subsequent '{'s on the line. This
change fixes that by looking for the first location that has no opening
curly, if any.
Repo
mprobst updated this revision to Diff 158946.
mprobst added a comment.
Also handle multiple numbered list tokens.
Repository:
rC Clang
https://reviews.llvm.org/D50230
Files:
lib/Format/BreakableToken.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Format/FormatTestJS.cpp
===
Szelethus marked 2 inline comments as done.
Szelethus added a comment.
It looks like I won't be back in office until Monday, so I can't finish this
one until then :(
>> but I haven't seen the current version of the checker crash due to pointer
>> chasing.
>
> @NoQ saw quite a few crashes durin
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338832: Fully qualify the renamed symbol if the shortened
name is ambiguous. (authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D
Author: ioeric
Date: Fri Aug 3 02:16:07 2018
New Revision: 338832
URL: http://llvm.org/viewvc/llvm-project?rev=338832&view=rev
Log:
Fully qualify the renamed symbol if the shortened name is ambiguous.
Summary:
For example, when renaming `a::b::x::foo` to `y::foo` below, replacing
`x::foo()` with
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
Great! Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D50230
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338837: clang-format: [JS] don't break comments before
any '{' (authored by mprobst, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50230?vs=158946&id=158957#toc
Repository:
rC Cl
Author: mprobst
Date: Fri Aug 3 02:34:41 2018
New Revision: 338837
URL: http://llvm.org/viewvc/llvm-project?rev=338837&view=rev
Log:
clang-format: [JS] don't break comments before any '{'
Summary:
Previously, clang-format would avoid breaking before the first `{`
found, but then happily break be
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338839: clang-format-diff: Make it work with python3 too
(authored by krasimir, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D48098?vs=15286
Author: krasimir
Date: Fri Aug 3 03:04:58 2018
New Revision: 338839
URL: http://llvm.org/viewvc/llvm-project?rev=338839&view=rev
Log:
clang-format-diff: Make it work with python3 too
Summary: It is not necessary, but would be nice if the script run on python3 as
well (as opposed to only python2
Merged in r338845. Thanks!
On Thu, Aug 2, 2018 at 10:48 PM, Richard Smith wrote:
> (+Hans) +1
>
> On Thu, 2 Aug 2018 at 11:37, Martin Storsjö via cfe-commits
> wrote:
>>
>> Hans,
>>
>> I think this commit should be merged to the 7.0 release branch; the first
>> half of the GCC workaround made it
Hi Martin,
On Fri, 3 Aug 2018 at 10:34, Martin Probst via cfe-commits
wrote:
> clang-format: [JS] don't break comments before any '{'
This looks like it's triggered a bunch of infinite loops in Clang's
unittests. For example:
http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/
On Fri, Aug 3, 2018 at 12:20 AM Reka Kovacs via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rkovacs
> Date: Thu Aug 2 15:19:57 2018
> New Revision: 338775
>
> URL: http://llvm.org/viewvc/llvm-project?rev=338775&view=rev
> Log:
> [analyzer] Add a safety check to InnerPointerChecker.
Author: karka
Date: Fri Aug 3 02:13:15 2018
New Revision: 338831
URL: http://llvm.org/viewvc/llvm-project?rev=338831&view=rev
Log:
Fix unused variable warning in tablegen generated code
Modified:
cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp
Modified: cfe/trunk/utils/TableGen/ClangAttrEmitt
Author: hans
Date: Fri Aug 3 04:33:00 2018
New Revision: 338860
URL: http://llvm.org/viewvc/llvm-project?rev=338860&view=rev
Log:
Creating release directory for release_700.
Added:
libcxxabi/tags/RELEASE_700/
___
cfe-commits mailing list
cfe-commi
Author: hans
Date: Fri Aug 3 04:32:47 2018
New Revision: 338858
URL: http://llvm.org/viewvc/llvm-project?rev=338858&view=rev
Log:
Creating release directory for release_700.
Added:
libcxx/tags/RELEASE_700/
___
cfe-commits mailing list
cfe-commits@
Author: hans
Date: Fri Aug 3 04:32:56 2018
New Revision: 338859
URL: http://llvm.org/viewvc/llvm-project?rev=338859&view=rev
Log:
Creating release candidate rc1 from release_700 branch
Added:
libcxx/tags/RELEASE_700/rc1/ (props changed)
- copied from r338858, libcxx/branches/release_
Author: hans
Date: Fri Aug 3 04:33:05 2018
New Revision: 338861
URL: http://llvm.org/viewvc/llvm-project?rev=338861&view=rev
Log:
Creating release candidate rc1 from release_700 branch
Added:
libcxxabi/tags/RELEASE_700/rc1/
- copied from r338860, libcxxabi/branches/release_70/
___
Author: hans
Date: Fri Aug 3 04:34:07 2018
New Revision: 338873
URL: http://llvm.org/viewvc/llvm-project?rev=338873&view=rev
Log:
Creating release candidate rc1 from release_700 branch
Added:
libunwind/tags/RELEASE_700/rc1/
- copied from r338872, libunwind/branches/release_70/
___
Author: hans
Date: Fri Aug 3 04:34:02 2018
New Revision: 338872
URL: http://llvm.org/viewvc/llvm-project?rev=338872&view=rev
Log:
Creating release directory for release_700.
Added:
libunwind/tags/RELEASE_700/
___
cfe-commits mailing list
cfe-commi
aaronpuchert added inline comments.
Comment at: test/SemaCXX/warn-thread-safety-analysis.cpp:4081-4085
+ void unlockExclusive() EXCLUSIVE_UNLOCK_FUNCTION(mu_) {
+mu_.Unlock();
+ }
+
+ void unlockShared() SHARED_UNLOCK_FUNCTION(mu_) {
aaron.ballman wrote:
>
devnexen added a comment.
ping :)
Repository:
rC Clang
https://reviews.llvm.org/D49873
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
devnexen added a comment.
ping :)
Repository:
rC Clang
https://reviews.llvm.org/D49906
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Fri, 3 Aug 2018 at 11:47, Tim Northover wrote:
> On Fri, 3 Aug 2018 at 10:34, Martin Probst via cfe-commits
> wrote:
> > clang-format: [JS] don't break comments before any '{'
>
> This looks like it's triggered a bunch of infinite loops in Clang's
> unittests.
I've just taken a look at the no
Author: tnorthover
Date: Fri Aug 3 05:19:22 2018
New Revision: 338879
URL: http://llvm.org/viewvc/llvm-project?rev=338879&view=rev
Log:
Revert "clang-format: [JS] don't break comments before any '{'"
This reverts commit r338837, it introduced an infinite loop on all bots.
Modified:
cfe/trun
lewis-revill created this revision.
lewis-revill added reviewers: asb, simoncook, edward-jones.
Herald added subscribers: cfe-commits, rkruppe, the_o, brucehoult,
MartinMosbeck, rogfer01, mgrang, zzheng, jrtc27, shiva0217, kito-cheng, niosHD,
sabuasal, apazos, johnrusso, rbar.
Extends r338385 to
lewis-revill added a comment.
I've submitted a patch to address Simon's issues in
https://reviews.llvm.org/D50246
Repository:
rC Clang
https://reviews.llvm.org/D46822
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
Thanks for the prompt fix, it solved the problem.
In case you want to add a regression test, this is what I came up with:
$ cat test-isCalledOnStringObject.cc
char *c();
class B {};
void d() {
B g, *h;
*(void **)&h = c() + 1;
*h = g;
}
$ ./clang-tidy -checks=-*,clang-analyzer* test-isCalledO
erichkeane added a comment.
In https://reviews.llvm.org/D48100#1186654, @Meinersbur wrote:
> I have two approaches to tackle the wrong marker order:
> https://reviews.llvm.org/D50215 and https://reviews.llvm.org/D50216. IMHO
> both are too invasive to be justified for the small issue.
I think
erichkeane added a comment.
IMO, I think this (and the next 2 numerically), show to me that we have too
much dependence on the order of attributes, which all of these show is not a
reliable thing to count on. I quite dislike this as well, and think this is
going to lead us to chasing these sam
Sorry about that, yes, that was me. Thanks for reverting!
Tim Northover schrieb am Fr., 3. Aug. 2018 um
14:19 Uhr:
> On Fri, 3 Aug 2018 at 11:47, Tim Northover
> wrote:
> > On Fri, 3 Aug 2018 at 10:34, Martin Probst via cfe-commits
> > wrote:
> > > clang-format: [JS] don't break comments befor
Author: erichkeane
Date: Fri Aug 3 06:01:32 2018
New Revision: 338884
URL: http://llvm.org/viewvc/llvm-project?rev=338884&view=rev
Log:
[NFC] Silence unused variable warning in Attr.td/AttrParsedAttrImpl.inc
Modified:
cfe/trunk/include/clang/Basic/Attr.td
Modified: cfe/trunk/include/clang/B
mprobst created this revision.
mprobst added a reviewer: krasimir.
Herald added a subscriber: cfe-commits.
Previously, clang-format would avoid breaking before the first `{`
found, but then happily break before subsequent '{'s on the line. This
change fixes that by looking for the first location t
This causes a warning:
gen/clang/include/clang/Sema/AttrParsedAttrImpl.inc:1050:12: warning:
expression result unused [-Wunused-value]
return S, false;
^
On Fri, Aug 3, 2018 at 9:01 AM Erich Keane via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: erichkeane
> Date: Fr
I'm getting this warning from the mac linker after this commit:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool:
warning same member name (libclangDriver.RISCV.o) in output file used for
input files: obj/clang/lib/Driver/ToolChains/Arch/libclangDriver
Hmm… I thought this was a pretty clever one. Again, that didn’t show up in my
older GCC :/
Any thoughts on how I can silence this AND the other warning?
From: Nico Weber [mailto:tha...@chromium.org]
Sent: Friday, August 3, 2018 6:16 AM
To: Keane, Erich
Cc: cfe-commits
Subject: Re: r338884 -
lewis-revill updated this revision to Diff 158994.
lewis-revill added a comment.
Modified test which assumed the path to C++ includes was determined without use
of the sysroot path.
Repository:
rC Clang
https://reviews.llvm.org/D50246
Files:
lib/Driver/ToolChains/RISCV.cpp
lib/Driver/To
Author: erichkeane
Date: Fri Aug 3 06:23:04 2018
New Revision: 338886
URL: http://llvm.org/viewvc/llvm-project?rev=338886&view=rev
Log:
[NFC] Fix unused expression warning introduced in r338884
Modified:
cfe/trunk/include/clang/Basic/Attr.td
Modified: cfe/trunk/include/clang/Basic/Attr.td
U
lebedev.ri created this revision.
lebedev.ri added reviewers: vsk, rsmith, rjmccall, Sanitizers.
lebedev.ri added a project: Sanitizers.
C and C++ are interesting languages. They are statically typed, but weakly.
The implicit conversions are allowed. This is nice, allows to write code
while balanc
Thanks for the heads up! I repro’ed both in Godbolt, and saw that clang
suggests wrapping in a void-cast, so I’ve done that.
From: Nico Weber [mailto:tha...@chromium.org]
Sent: Friday, August 3, 2018 6:16 AM
To: Keane, Erich
Cc: cfe-commits
Subject: Re: r338884 - [NFC] Silence unused variable
xbolva00 added a comment.
Nico Webber (cfe-commits)
"I'm getting this warning from the mac linker after this commit:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool:
warning same member name (libclangDriver.RISCV.o) in output file used for
input f
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338887: [AST][NFC] Small doc update for DeclContext
(authored by brunoricci, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D49790
Files:
include/clang/AST/DeclBase.h
Index: include
theraven updated this revision to Diff 158997.
theraven added a comment.
- Address Dustin's review comments.
Repository:
rC Clang
https://reviews.llvm.org/D50144
Files:
include/clang/Driver/Options.td
lib/AST/MicrosoftMangle.cpp
lib/CodeGen/CGBlocks.cpp
lib/CodeGen/CGException.cpp
mboehme added a comment.
Any comments?
https://reviews.llvm.org/D49911, on which this relies, is now ready to land.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49910
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
erichkeane added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:1008
+ // We ignore conversions to/from pointer and/or bool.
+ if (!(SrcType->isIntegerType() && DstType->isIntegerType()))
+return;
I'd rather !SrcType->isInt || !DestType->isInt
lebedev.ri added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:2004
+if (auto *ICE = dyn_cast(CE)) {
+ if (CGF.SanOpts.hasOneOf(SanitizerKind::ImplicitConversion) &&
+ !ICE->isPartOfExplicitCast()) {
erichkeane wrote:
> Is this an er
erichkeane added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:2004
+if (auto *ICE = dyn_cast(CE)) {
+ if (CGF.SanOpts.hasOneOf(SanitizerKind::ImplicitConversion) &&
+ !ICE->isPartOfExplicitCast()) {
lebedev.ri wrote:
> erichkeane wr
Author: erichkeane
Date: Fri Aug 3 06:51:35 2018
New Revision: 338889
URL: http://llvm.org/viewvc/llvm-project?rev=338889&view=rev
Log:
[NFCI] My attempt to fix a warning in r338886 broke the build! Fix it.
Clang format got the best of me... it introduced spaces around something
in a table-genn
Such filename fix could be part of https://reviews.llvm.org/D50246
pi 3. 8. 2018 o 15:17 Nico Weber napísal(a):
> I'm getting this warning from the mac linker after this commit:
>
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool:
> warning same mem
Author: brunoricci
Date: Fri Aug 3 06:31:20 2018
New Revision: 338887
URL: http://llvm.org/viewvc/llvm-project?rev=338887&view=rev
Log:
[AST][NFC] Small doc update for DeclContext
Factored out from https://reviews.llvm.org/D49729
following @erichkeane comments.
* Add missing classes in the list
Author: brunoricci
Date: Fri Aug 3 06:13:05 2018
New Revision: 338885
URL: http://llvm.org/viewvc/llvm-project?rev=338885&view=rev
Log:
Test commit
Modified:
cfe/trunk/lib/AST/DeclBase.cpp
Modified: cfe/trunk/lib/AST/DeclBase.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/D
Author: brunoricci
Date: Fri Aug 3 06:47:12 2018
New Revision: 33
URL: http://llvm.org/viewvc/llvm-project?rev=33&view=rev
Log:
[AST][NFC] Add missing doc for ObjCMethodDecl and ObjCContainerDecl
Add a comment in ObjCMethodDecl and ObjCContainerDecl stating that
we store some bits in Obj
kadircet updated this revision to Diff 159000.
kadircet marked 8 inline comments as done.
kadircet added a comment.
Fixed discussions
https://reviews.llvm.org/D50193
Files:
clangd/CodeComplete.cpp
clangd/CodeComplete.h
clangd/Diagnostics.cpp
clangd/Protocol.h
clangd/SourceCode.cpp
c
Author: mprobst
Date: Fri Aug 3 06:58:33 2018
New Revision: 338890
URL: http://llvm.org/viewvc/llvm-project?rev=338890&view=rev
Log:
clang-format: [JS] don't break comments before any '{'
Summary:
Previously, clang-format would avoid breaking before the first `{`
found, but then happily break be
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338890: clang-format: [JS] don't break comments before
any '{' (authored by mprobst, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50249?vs=158993&id=159001#toc
Repository:
rC Cl
On Fri, Aug 3, 2018 at 8:53 AM, Erich Keane via Phabricator
wrote:
> erichkeane added a comment.
>
> In https://reviews.llvm.org/D48100#1186654, @Meinersbur wrote:
>
>> I have two approaches to tackle the wrong marker order:
>> https://reviews.llvm.org/D50215 and https://reviews.llvm.org/D50216.
> As a possible idea (that may or may not work): the Attr object itself has a
> SourceRange on it; perhaps a solution is to keep the > attributes in sorted
> order within DeclBase::addAttr() based on the SourceRanges passed in?
Interestingly, I think I came up with that idea in a comment on D502
mboehme marked an inline comment as done.
mboehme added a comment.
Any further comments? This is marked ready to land, but I've made some
non-trivial changes since then, so I didn't just want to land this.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49918
lebedev.ri updated this revision to Diff 159004.
lebedev.ri marked 5 inline comments as done.
lebedev.ri added a comment.
Address most of @erichkeane review notes.
Repository:
rC Clang
https://reviews.llvm.org/D50250
Files:
docs/ReleaseNotes.rst
docs/UndefinedBehaviorSanitizer.rst
incl
lebedev.ri added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:1008
+ // We ignore conversions to/from pointer and/or bool.
+ if (!(SrcType->isIntegerType() && DstType->isIntegerType()))
+return;
erichkeane wrote:
> I'd rather !SrcType->isInt ||
aaron.ballman added a reviewer: rsmith.
aaron.ballman added a comment.
Are you going to propose adding this attribute to libc++, or is this expected
to only work with UDTs?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49910
___
c
erichkeane added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:1008
+ // We ignore conversions to/from pointer and/or bool.
+ if (!(SrcType->isIntegerType() && DstType->isIntegerType()))
+return;
lebedev.ri wrote:
> erichkeane wrote:
> > I'd rat
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: test/SemaCXX/warn-thread-safety-analysis.cpp:4081-4085
+ void unlockExclusive() EXCLUSIVE_UNLOCK_FUNCTION(mu_) {
+mu_.Unlock();
+ }
+
+
Author: erichkeane
Date: Fri Aug 3 07:24:34 2018
New Revision: 338893
URL: http://llvm.org/viewvc/llvm-project?rev=338893&view=rev
Log:
revert r338831 - Fix unused variable warning in tablegen generated code
No longer necessary thanks to r338889 (and friends).
Modified:
cfe/trunk/utils/Tabl
mboehme updated this revision to Diff 159007.
mboehme marked an inline comment as done.
mboehme added a comment.
Various changes in response to review comments.
Repository:
rC Clang
https://reviews.llvm.org/D49911
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
lib/S
mboehme marked 2 inline comments as done.
mboehme added a comment.
Thanks for the review!
In https://reviews.llvm.org/D49911#1186185, @aaron.ballman wrote:
> The attribute itself is looking reasonable aside from some minor nits, but
> this should not be committed until the clang-tidy functional
avt77 added a comment.
In https://reviews.llvm.org/D47196#1186460, @efriedma wrote:
> "0.0040" is four milliseconds? You're probably crediting time incorrectly,
> somehow. Can you tell which FrontendTimeRAII the time is coming from?
Not sure I understand you. What do you like to know exactly
On Fri, Aug 3, 2018 at 10:09 AM, Keane, Erich wrote:
>> As a possible idea (that may or may not work): the Attr object itself has a
>> SourceRange on it; perhaps a solution is to keep the > attributes in sorted
>> order within DeclBase::addAttr() based on the SourceRanges passed in?
>
> Interest
Author: gyiu
Date: Fri Aug 3 07:36:44 2018
New Revision: 338895
URL: http://llvm.org/viewvc/llvm-project?rev=338895&view=rev
Log:
Fix asm label testcase flaw
- Testcase attempts to (not) grep 'g0' in output to ensure asm symbol is
properly renamed, but g0 is too generic and can be part of the
simark created this revision.
Herald added subscribers: cfe-commits, arphaman, jkorous, ioeric, ilya-biryukov.
This patch adds tests for the two ways of changing build configuration
(pointing to a particular compile_commands.json):
- Through the workspace/didChangeConfiguration notification.
- Th
simark added a comment.
This was not tested on windows yet.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50255
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
I suspect you're right about that. Hopefully it would be easy enough.
Unfortunately, SourceLocation doesn't have an operator<, which kind of stinks.
I suspect that it'll be a non-trivial thing to do, since it is actually
possible to have attributes added with empty source-locations in some cas
mboehme added a comment.
In https://reviews.llvm.org/D49910#1187455, @aaron.ballman wrote:
> Are you going to propose adding this attribute to libc++, or is this expected
> to only work with UDTs?
I don't have any experience contributing to libc++, but I think this would make
sense.
The chec
lewis-revill added a comment.
@xbolva00 In my opinion this is an issue for another revision. Personally I
would choose to rename/move the other RISCV driver file to something along the
lines of RISCVLinux, however I think it is best for @asb to decide since he is
the code owner for the RISC-V b
baloghadamsoftware created this revision.
baloghadamsoftware added a reviewer: NoQ.
Herald added subscribers: mikhail.ramalho, a.sidorin, dkrupp, rnkovacs, szepet,
whisperity.
Herald added a reviewer: george.karpenkov.
Currently, the default (range-based) constrain manager supports symbolic
expr
Author: jvesely
Date: Fri Aug 3 08:14:08 2018
New Revision: 338898
URL: http://llvm.org/viewvc/llvm-project?rev=338898&view=rev
Log:
amdgcn: Use __constant AS for amdgcn builtins.
Fixes build after clang r338707.
Reviewer: matthew.arsena...@amd.com
Signed-off-by: Jan Vesely
Modified:
libcl
baloghadamsoftware updated this revision to Diff 159012.
baloghadamsoftware edited the summary of this revision.
baloghadamsoftware added a comment.
Completely rewritten: works correctly for modular arithmetic (multiplication),
works correctly for truncation (division), only uses integers, no flo
baloghadamsoftware added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:388
+// template parameters for different containers. So we can safely
+// assume that passing iterators of different containers as arguments
+// whose type replaces
baloghadamsoftware added a comment.
In https://reviews.llvm.org/D32859##inline-360206, @NoQ wrote:
> I do not immediately understand what is this useful for. At least tests don't
> look like they make use of these offset manipulations(?)
>
> Without full understanding, i wonder: when we overwrit
Author: scott.linder
Date: Fri Aug 3 08:50:52 2018
New Revision: 338899
URL: http://llvm.org/viewvc/llvm-project?rev=338899&view=rev
Log:
[OpenCL] Always emit alloca in entry block for enqueue_kernel builtin
Ensures the statically sized alloca is not converted to DYNAMIC_STACKALLOC
later because
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338899: [OpenCL] Always emit alloca in entry block for
enqueue_kernel builtin (authored by scott.linder, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews
asavonic created this revision.
asavonic added reviewers: Anastasia, yaxunl.
Herald added a subscriber: cfe-commits.
Negative arguments in kernel attributes are silently bitcast'ed to
unsigned, for example:
__attribute__((reqd_work_group_size(1, -1, 1)))
__kernel void k() {}
is a complete eq
alexfh accepted this revision.
alexfh added a comment.
Still LG
Comment at: test/clang-tidy/bugprone-use-after-move.cpp:1141
+A a1;
+if (A a2= std::move(a1)) {
+ std::move(a2);
nit: clang-format this, please.
Repository:
rCTE Clang Tools Extra
ilya-biryukov added inline comments.
Comment at: clangd/CodeComplete.cpp:286
+Completion.FixIts.push_back(
+toTextEdit(FixIt, ASTCtx.getSourceManager(), {}));
+ }
IIRC LangOptions are actually important when running lexer (that is used
i
ilya-biryukov added a comment.
This revision got 'reopened' and is now in the list of accepted revision.
Should we close it again?
Repository:
rC Clang
https://reviews.llvm.org/D48903
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
simark requested review of this revision.
simark added a comment.
In https://reviews.llvm.org/D48903#1187596, @ilya-biryukov wrote:
> This revision got 'reopened' and is now in the list of accepted revision.
> Should we close it again?
It got reverted a second time because it was breaking a te
sdmitriev updated this revision to Diff 159028.
sdmitriev added a comment.
Replaced std::sort with llvm::sort. Added a test for offload target
registration code for two offload targets.
https://reviews.llvm.org/D50218
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
test/OpenMP/openmp_offload_regist
bricci created this revision.
bricci added reviewers: erichkeane, rsmith, rnk.
bricci added a project: clang.
Herald added a subscriber: cfe-commits.
DeclarationNameTable currently hold 3 void * to
FoldingSet, FoldingSet
and FoldingSet.
CXXSpecialName, CXXLiteralOperatorIdName and
CXXDeductionGu
lebedev.ri added a project: clang.
lebedev.ri added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:1008
+ // We ignore conversions to/from pointer and/or bool.
+ if (!(SrcType->isIntegerType() && DstType->isIntegerType()))
+return;
erichkeane wro
erichkeane added a comment.
On the face, this seems to be a nice patch. Removing extra allocations and
replacing them with the stack is a good thing IMO. This is clearly an example
of PIMPL, which while it has its advantages, performance is typically a hit.
My 2 concerns with this are:
1- Th
kristina accepted this revision as: kristina.
kristina added a comment.
This revision is now accepted and ready to land.
Seems something that's not easy to test or reproduce even with VS (the plugin
itself is 3rd party if I understand right) but it looks sane.
Repository:
rC Clang
https://re
shuaiwang updated this revision to Diff 159037.
shuaiwang marked 2 inline comments as done.
shuaiwang added a comment.
Add comments explaining CXXCtorInitializer check
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50102
Files:
clang-tidy/performance/UnnecessaryValueParamChec
arphaman updated this revision to Diff 159036.
arphaman added a comment.
Always capitalize the diagnostic's message.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50154
Files:
clangd/Diagnostics.cpp
test/clangd/capitalize-diagnostics.test
test/clangd/diagnostics.test
t
1 - 100 of 217 matches
Mail list logo
