[PATCH] D51292: [clang-rename] Update documentation

kbobyrev updated this revision to Diff 162643. kbobyrev added a comment. Add missing `_` after the link. https://reviews.llvm.org/D51292 Files: clang-tools-extra/docs/clang-rename.rst Index: clang-tools-extra/docs/clang-rename.rst

[PATCH] D51292: [clang-rename] Update documentation

kbobyrev created this revision. kbobyrev added reviewers: ioeric, ilya-biryukov. Herald added a subscriber: kadircet. Clangd has way better editor support compared to the ad-hoc integration I created before and we should point users to Clangd mentioning that they could still use standalone tool

[PATCH] D51287: [clangd] Use TRUE iterator instead of complete posting list

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D51287 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D51291: [clangd] *Prototype* Support multiple #include headers in one symbol.

ioeric added a comment. @sammccall The code still needs cleanup but should be useful for providing high-level feedback, which I would like to get before moving further. Thanks! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51291 _

[PATCH] D51291: [clangd] *Prototype* Support multiple #include headers in one symbol.

ioeric created this revision. ioeric added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Currently, a symbol can have only one #include header attached, which might not work well if the symbol can be imported via different #incl

[PATCH] D50462: Try building complete AST after a fatal error was emitted if further diagnostics are expected

Dmitry.Kozhevnikov added a comment. When lookin through the list of the fatal errors, I think there are different categories: 1. "Scary" ones - "module was relocated", "invalid vfs overlay file", we probably shouldn't try to recover from it 2. "User" errors (include not found, too many errors)

[PATCH] D50462: Try building complete AST after a fatal error was emitted if further diagnostics are expected

ilya-biryukov added a comment. Sorry for chiming in, wanted to add my 2 cents to the conversation. In https://reviews.llvm.org/D50462#1206203, @vsapsai wrote: > What about having a mode that treats missing header as non-fatal error? > Because I believe there are cases where there is no sense to

[PATCH] D51287: [clangd] Use TRUE iterator instead of complete posting list

kbobyrev created this revision. kbobyrev added a reviewer: ilya-biryukov. kbobyrev added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. kbobyrev edited the summary of this revision. Stop using `$$$` (empty) trigram and generating a posting list with a

r340727 - Try to fix this clang driver test case after r340709.

Author: chandlerc Date: Mon Aug 27 01:49:20 2018 New Revision: 340727 URL: http://llvm.org/viewvc/llvm-project?rev=340727&view=rev Log: Try to fix this clang driver test case after r340709. If any of the bots complain about this, I'll just revert. This test case is essentially trying to test the

Re: r340709 - [Driver] Change MipsLinux default linker from "lld" to "ld.lld"

Build bots have been broken all day, so I'm trying a speculative fix in r340727. If this doesn't work, i'll just revert all of this. On Sun, Aug 26, 2018 at 3:51 PM Chandler Carruth wrote: > FYI, test cases also seem to need updating: > > http://lab.llvm.org:8011/builders/clang-ppc64le-linux/bui

[PATCH] D50766: Fix false positive unsequenced access and modification warning in array subscript expression.

stryku updated this revision to Diff 162630. stryku added a comment. Added missing semicolon. https://reviews.llvm.org/D50766 Files: lib/Sema/SemaChecking.cpp test/SemaCXX/warn-unsequenced-cxx17.cpp test/SemaCXX/warn-unsequenced.cpp Index: test/SemaCXX/warn-unsequenced.cpp =

Re: [PATCH] D49840: [AST] Add MatchFinder::matchSubtree

On Mon, Aug 6, 2018 at 4:47 PM Gabor Marton via Phabricator < revi...@reviews.llvm.org> wrote: > martong added a comment. > > Ping. > > Manuel, I still don't see how could we apply `match(anyOf(node), > hasDescendant(node))` to the problem of general subtree traversal. > (I'd like to have support

[PATCH] D51221: [clangd] Some nitpicking around the new split (preamble/main) dynamic index

ilya-biryukov added a comment. Thanks for the cleanups, mostly NITs from my side. Comment at: clangd/ClangdServer.cpp:81 - SymbolIndex &index() const { return *MergedIndex; } + SymbolIndex &index() { return *MergedIndex; } Maybe return `const SymbolIndex&

[PATCH] D51258: Extract parseBindID method

klimek added inline comments. Comment at: lib/ASTMatchers/Dynamic/Parser.cpp:362 +bool Parser::parseBindID(std::string &BindID, TokenInfo &CloseToken) { + // Parse .bind("foo") CloseToken seems to not be used afterwards either here or in the follow-up patch?

[PATCH] D51259: Allow binding to NamedValue resulting from let expression

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang https://reviews.llvm.org/D51259 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

[PATCH] D51261: Add preload option to clang-query

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D44609: [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

klimek added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1307 + (Style.BraceWrapping.BeforeLambdaBody && Current.Next != nullptr && +Current.Next->is(TT_LambdaLSquare))); State.Stack.back().IsInsideObjCArrayLiteral = klimek w

<    1   2