[PATCH] D51789: [clang] Add the exclude_from_explicit_instantiation attribute

ldionne added a comment. I'm thinking about this some more, and I'm wondering whether it would be a viable solution to just exclude members marked with hidden visibility from explicit template instantiations (and declarations thereof). I thought I had been convinced by Hubert

[PATCH] D52193: RFC: [clang] Multithreaded compilation support

zturner added a subscriber: aganea. zturner added a comment. In an ideal world yes, but the reality is that many people still use MSBuild, and in that world /MP presumably helps quite a bit. And given that many people already depend on this functionality of cl, it’s a potential showstopper for

Re: [PATCH] D52193: RFC: [clang] Multithreaded compilation support

In an ideal world yes, but the reality is that many people still use MSBuild, and in that world /MP presumably helps quite a bit. And given that many people already depend on this functionality of cl, it’s a potential showstopper for migrating if we don’t support it. That said, if the benefit

r342470 - cl-options.c: Fix negative -cfguard check

Author: hans Date: Tue Sep 18 06:07:55 2018 New Revision: 342470 URL: http://llvm.org/viewvc/llvm-project?rev=342470=rev Log: cl-options.c: Fix negative -cfguard check Modified: cfe/trunk/test/Driver/cl-options.c Modified: cfe/trunk/test/Driver/cl-options.c URL:

[PATCH] D50949: lambdas in modules: handle lambdas in .pcm [de]serialization

elsteveogrande updated this revision to Diff 165948. elsteveogrande added a comment. Rebase atop updated dependency https://reviews.llvm.org/D50948. Small cleanups to this diff. Repository: rC Clang https://reviews.llvm.org/D50949 Files: include/clang/AST/DeclCXX.h

[PATCH] D50948: lambdas in modules: change storage for LambdaDefinitionData

elsteveogrande updated this revision to Diff 165947. elsteveogrande added a comment. Rebase past dependency commit C341499, fix a conflict Repository: rC Clang https://reviews.llvm.org/D50948 Files: include/clang/AST/DeclCXX.h lib/AST/DeclCXX.cpp lib/Serialization/ASTReaderDecl.cpp

[PATCH] D52222: [clangd] Merge ClangdServer::DynamicIndex into FileIndex. NFC.

sammccall added inline comments. Comment at: clangd/index/FileIndex.h:77 + /// Update symbols from main file \p Path with symbols in \p TopLevelDecls. + void updateMain(PathRef Path, ASTContext , + std::shared_ptr PP, sammccall wrote: > can't

[PATCH] D52200: Thread safety analysis: Handle ObjCIvarRefExpr in SExprBuilder::translate

aaron.ballman added a reviewer: rjmccall. aaron.ballman added a comment. Adding a reviewer who knows more about ObjC than I do. Comment at: include/clang/Analysis/Analyses/ThreadSafetyCommon.h:400 til::SExpr *translateMemberExpr(const MemberExpr *ME, CallingContext *Ctx); +

[PATCH] D52179: [clang-tidy] Replace redundant checks with an assert().

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:551-552 if (Decl->isMain() || !Decl->isUserProvided() || -

[PATCH] D52230: [clang-tidy] use CHECK-NOTES in tests for bugprone-macro-repeated-side-effects

JonasToth created this revision. JonasToth added reviewers: alexfh, aaron.ballman, hokein. Herald added subscribers: cfe-commits, xazax.hun. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52230 Files: test/clang-tidy/bugprone-macro-repeated-side-effects.c Index:

[PATCH] D52229: [clang-tidy] use CHECK-NOTES in tests for bugprone suspicious-enum-usage

JonasToth created this revision. JonasToth added reviewers: alexfh, aaron.ballman, hokein. Herald added subscribers: cfe-commits, xazax.hun. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52229 Files: test/clang-tidy/bugprone-suspicious-enum-usage-strict.cpp

[PATCH] D52187: [clang-tidy] use CHECK-NOTES in bugprone-unused-return-value

This revision was automatically updated to reflect the committed changes. Closed by commit rL342468: [clang-tidy] use CHECK-NOTES in bugprone-unused-return-value (authored by JonasToth, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[clang-tools-extra] r342468 - [clang-tidy] use CHECK-NOTES in bugprone-unused-return-value

Author: jonastoth Date: Tue Sep 18 04:49:20 2018 New Revision: 342468 URL: http://llvm.org/viewvc/llvm-project?rev=342468=rev Log: [clang-tidy] use CHECK-NOTES in bugprone-unused-return-value Reviewers: aaron.ballman, alexfh, hokein Reviewed By: alexfh Subscribers: xazax.hun, cfe-commits

[PATCH] D52228: [clang-tidy] use CHECK-NOTES in tests for bugprone-use-after-move

JonasToth created this revision. JonasToth added reviewers: alexfh, aaron.ballman, hokein. Herald added subscribers: cfe-commits, xazax.hun. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52228 Files: test/clang-tidy/bugprone-use-after-move.cpp Index:

[PATCH] D52187: [clang-tidy] use CHECK-NOTES in bugprone-unused-return-value

JonasToth updated this revision to Diff 165926. JonasToth added a comment. - shorten warning checks Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52187 Files: test/clang-tidy/bugprone-unused-return-value-custom.cpp test/clang-tidy/bugprone-unused-return-value.cpp Index:

[PATCH] D52226: [clangd] Remove override result handling logic from clangd

kadircet created this revision. kadircet added reviewers: ioeric, ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay. kadircet added a dependency: D52225: [clang] Implement Override Suggestions in Sema.. Since we plan to move handling of override suggestions to Sema

[PATCH] D52222: [clangd] Merge ClangdServer::DynamicIndex into FileIndex. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rL342460: [clangd] Merge ClangdServer::DynamicIndex into FileIndex. NFC. (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D5

[PATCH] D52222: [clangd] Merge ClangdServer::DynamicIndex into FileIndex. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE342460: [clangd] Merge ClangdServer::DynamicIndex into FileIndex. NFC. (authored by ioeric, committed by ). Changed prior to commit: https://reviews.llvm.org/D5?vs=165918=165923#toc Repository:

[clang-tools-extra] r342460 - [clangd] Merge ClangdServer::DynamicIndex into FileIndex. NFC.

Author: ioeric Date: Tue Sep 18 03:30:44 2018 New Revision: 342460 URL: http://llvm.org/viewvc/llvm-project?rev=342460=rev Log: [clangd] Merge ClangdServer::DynamicIndex into FileIndex. NFC. Summary: FileIndex now provides explicit interfaces for preamble and main file updates. This avoids

[PATCH] D52222: [clangd] Merge ClangdServer::DynamicIndex into FileIndex. NFC.

sammccall added inline comments. Comment at: clangd/index/FileIndex.h:121 std::pair indexAST(ASTContext , std::shared_ptr PP, llvm::ArrayRef URISchemes = {}); ioeric wrote: > sammccall wrote: > > indexPreamble would be clearer I think. > What about

[PATCH] D52186: [clang-tidy] use CHECK-NOTES in bugprone-forwarding-reference-overload

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE342459: [clang-tidy] use CHECK-NOTES in bugprone-forwarding-reference-overload (authored by JonasToth, committed by ). Changed prior to commit: https://reviews.llvm.org/D52186?vs=165806=165920#toc

[PATCH] D52186: [clang-tidy] use CHECK-NOTES in bugprone-forwarding-reference-overload

This revision was automatically updated to reflect the committed changes. Closed by commit rL342459: [clang-tidy] use CHECK-NOTES in bugprone-forwarding-reference-overload (authored by JonasToth, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D52222: [clangd] Merge ClangdServer::DynamicIndex into FileIndex. NFC.

ioeric added inline comments. Comment at: clangd/index/FileIndex.h:121 std::pair indexAST(ASTContext , std::shared_ptr PP, llvm::ArrayRef URISchemes = {}); sammccall wrote: > indexPreamble would be clearer I think. What about `indexHeaderSymbols`?

[PATCH] D52225: [clang] Implement Override Suggestions in Sema.

kadircet created this revision. kadircet added reviewers: ioeric, ilya-biryukov. Herald added a subscriber: cfe-commits. In clangd we had a new type of completion suggestions for cpp class/struct/unions that will show override signatures for virtual methods in base classes. This patch implements

[PATCH] D52222: [clangd] Merge ClangdServer::DynamicIndex into FileIndex. NFC.

ioeric updated this revision to Diff 165918. ioeric marked 6 inline comments as done. ioeric added a comment. - addressed review comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D5 Files: clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/index/FileIndex.cpp

[clang-tools-extra] r342459 - [clang-tidy] use CHECK-NOTES in bugprone-forwarding-reference-overload

Author: jonastoth Date: Tue Sep 18 03:21:33 2018 New Revision: 342459 URL: http://llvm.org/viewvc/llvm-project?rev=342459=rev Log: [clang-tidy] use CHECK-NOTES in bugprone-forwarding-reference-overload Reviewers: aaron.ballman, alexfh, hokein Reviewed By: alexfh Subscribers: xazax.hun,

[PATCH] D52178: [clang-tidy] use CHECK-NOTES in tests for bugprone-argument-comment

This revision was automatically updated to reflect the committed changes. Closed by commit rL342458: [clang-tidy] use CHECK-NOTES in tests for bugprone-argument-comment (authored by JonasToth, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D52178: [clang-tidy] use CHECK-NOTES in tests for bugprone-argument-comment

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE342458: [clang-tidy] use CHECK-NOTES in tests for bugprone-argument-comment (authored by JonasToth, committed by ). Changed prior to commit: https://reviews.llvm.org/D52178?vs=165784=165916#toc

[clang-tools-extra] r342458 - [clang-tidy] use CHECK-NOTES in tests for bugprone-argument-comment

Author: jonastoth Date: Tue Sep 18 03:15:15 2018 New Revision: 342458 URL: http://llvm.org/viewvc/llvm-project?rev=342458=rev Log: [clang-tidy] use CHECK-NOTES in tests for bugprone-argument-comment Summary: This patch uses CHECK-NOTES for the tests. Its part of an effort to test *ALL* generated

[PATCH] D51989: [clangd] dexp tool uses llvm::cl to parse its flags.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE342456: [clangd] dexp tool uses llvm::cl to parse its flags. (authored by sammccall, committed by ). Herald added a subscriber: mgorny. Changed prior to commit:

[clang-tools-extra] r342456 - [clangd] dexp tool uses llvm::cl to parse its flags.

Author: sammccall Date: Tue Sep 18 02:49:57 2018 New Revision: 342456 URL: http://llvm.org/viewvc/llvm-project?rev=342456=rev Log: [clangd] dexp tool uses llvm::cl to parse its flags. Summary: We can use cl::ResetCommandLineParser() to support different types of command-lines, as long as we're

Re: [clang-tools-extra] r342388 - [Clang-Tidy: modernize] Fix for modernize-redundant-void-arg: complains about variable cast to void

Nope, that's fine. See my previous email. On Mon, Sep 17, 2018 at 3:18 PM IdrissRio wrote: > Yes I have already make the fix commit. It was an error in the tests. > > > https://github.com/llvm-mirror/clang-tools-extra/commit/77ed1cd838a249d6134de9a6bdbe17ef46ecf946 > > > Now on my Mac it

[PATCH] D52178: [clang-tidy] use CHECK-NOTES in tests for bugprone-argument-comment

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52178 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52186: [clang-tidy] use CHECK-NOTES in bugprone-forwarding-reference-overload

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52186 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52187: [clang-tidy] use CHECK-NOTES in bugprone-unused-return-value

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG with a comment. Comment at: test/clang-tidy/bugprone-unused-return-value.cpp:81 std::async(std::launch::async, increment, 42); - // CHECK-MESSAGES: [[@LINE-1]]:3:

[PATCH] D52222: [clangd] Merge ClangdServer::DynamicIndex into FileIndex. NFC.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Glorious! Think the APIs could be simplified/clarified a little further, but up to you. Comment at: clangd/index/FileIndex.cpp:24 +indexSymbols(ASTContext ,

[clang-tools-extra] r342453 - [clangd] Update code completion for #include completions in r342449

Author: sammccall Date: Tue Sep 18 02:08:28 2018 New Revision: 342453 URL: http://llvm.org/viewvc/llvm-project?rev=342453=rev Log: [clangd] Update code completion for #include completions in r342449 Modified: clang-tools-extra/trunk/clangd/CodeComplete.cpp Modified:

[clang-tools-extra] r342452 - [clangd] Adapt API change after 342451.

Author: ioeric Date: Tue Sep 18 01:52:14 2018 New Revision: 342452 URL: http://llvm.org/viewvc/llvm-project?rev=342452=rev Log: [clangd] Adapt API change after 342451. Modified: clang-tools-extra/trunk/clangd/FindSymbols.cpp clang-tools-extra/trunk/clangd/XRefs.cpp

[PATCH] D52098: [Index] Add an option to collect macros from preprocesor.

This revision was automatically updated to reflect the committed changes. Closed by commit rL342451: [Index] Add an option to collect macros from preprocesor. (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D52098

r342451 - [Index] Add an option to collect macros from preprocesor.

Author: ioeric Date: Tue Sep 18 01:51:08 2018 New Revision: 342451 URL: http://llvm.org/viewvc/llvm-project?rev=342451=rev Log: [Index] Add an option to collect macros from preprocesor. Summary: Also added unit tests for the index library; lit+c-index-test is painful... Reviewers:

[PATCH] D52076: [CodeComplete] Add completions for filenames in #include directives.

This revision was automatically updated to reflect the committed changes. Closed by commit rL342449: [CodeComplete] Add completions for filenames in #include directives. (authored by sammccall, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D52076: [CodeComplete] Add completions for filenames in #include directives.

This revision was automatically updated to reflect the committed changes. Closed by commit rC342449: [CodeComplete] Add completions for filenames in #include directives. (authored by sammccall, committed by ). Changed prior to commit: https://reviews.llvm.org/D52076?vs=165787=165904#toc

r342449 - [CodeComplete] Add completions for filenames in #include directives.

Author: sammccall Date: Tue Sep 18 01:40:41 2018 New Revision: 342449 URL: http://llvm.org/viewvc/llvm-project?rev=342449=rev Log: [CodeComplete] Add completions for filenames in #include directives. Summary: The dir component ("somedir" in #include ) is considered fixed. We append "foo" to each

[PATCH] D52076: [CodeComplete] Add completions for filenames in #include directives.

sammccall added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:8057 + if (!(Filename.endswith(".h") || Filename.endswith(".hh") || +Filename.endswith(".H") || Filename.endswith(".hpp") || +Filename.endswith(".inc")))

[PATCH] D52098: [Index] Add an option to collect macros from preprocesor.

ioeric added inline comments. Comment at: unittests/Index/IndexTests.cpp:61 +S.Roles = Roles; +if (MI) + S.Info = getSymbolInfoForMacro(*MI); ilya-biryukov wrote: > ioeric wrote: > > ilya-biryukov wrote: > > > Can this actually happen? It seems

[PATCH] D52222: [clangd] Merge ClangdServer::DynamicIndex into FileIndex. NFC.

ioeric created this revision. ioeric added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. FileIndex now provides explicit interfaces for preamble and main file updates. This avoids growing parameter list when preamble and main

[PATCH] D52193: RFC: [clang] Multithreaded compilation support

hans added a comment. In https://reviews.llvm.org/D52193#1237468, @zturner wrote: > What about the timings of clang-cl without /MP? And one using Ninja rather than msbuild. I think the real question is whether we want clang and clang-cl to do this. I'm not sure we do as it adds complexity

[PATCH] D51214: [clangd] Add options to enable/disable fixits and function argument snippets.

ilya-biryukov added a comment. Maybe commit only an option to enable function arg snippets for now (found myself wanting this option today :-))? The fixes would also be nice, but since they never work... Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51214

[PATCH] D52076: [CodeComplete] Add completions for filenames in #include directives.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/Sema/SemaCodeComplete.cpp:8057 + if (!(Filename.endswith(".h") || Filename.endswith(".hh") || +

[PATCH] D52079: [Sema] Do not load macros from preamble when LoadExternal is false.

ilya-biryukov added a comment. Maybe add a test? There is `test/Index/complete-pch-skip.cpp` that checks similar things for AST completions, adding macros there should be trivial. Repository: rC Clang https://reviews.llvm.org/D52079 ___

[PATCH] D52098: [Index] Add an option to collect macros from preprocesor.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: include/clang/Index/IndexingAction.h:59 /// Recursively indexes \p Decls. -/// Note that this does not index macros. -void

[PATCH] D52058: Add Parameters to DW_AT_name Attribute of Template Variables

JDevlieghere added a comment. Generally this looks good, but I'd like for the other to have a look first (at this and the other patch) before accepting. Comment at: lib/CodeGen/CGDebugInfo.cpp:1783 + if (auto *TS = dyn_cast(VL)) { +if

[clang-tools-extra] r342445 - [pp-trace] Remove unused using directives

Author: maskray Date: Mon Sep 17 23:57:58 2018 New Revision: 342445 URL: http://llvm.org/viewvc/llvm-project?rev=342445=rev Log: [pp-trace] Remove unused using directives Modified: clang-tools-extra/trunk/pp-trace/PPTrace.cpp Modified: clang-tools-extra/trunk/pp-trace/PPTrace.cpp URL:

<    1   2