kristina added subscribers: rsmith, kristina.
kristina added reviewers: t.p.northover, rsmith.
kristina added a comment.
Accepted blocking differential https://reviews.llvm.org/D52149, updated
reviewers to include ARM code owner and @rsmith.
Repository:
rC Clang
https://reviews.llvm.org/D527
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric,
ilya-biryukov, mgorny.
So we don't have to run "check-clang-tools" (which builds and tests all
clang tools) to verify our clangd-related change. It'd save wait
sammccall added a comment.
Thanks for doing this!
Sorry for the dumb questions, I don't get cmake.
Comment at: test/CMakeLists.txt:36
set(CLANG_TOOLS_TEST_DEPS
# For the clang-apply-replacements test that uses clang-rename.
can we add all of clangd to thi
hokein marked an inline comment as done.
hokein added inline comments.
Comment at: test/CMakeLists.txt:36
set(CLANG_TOOLS_TEST_DEPS
# For the clang-apply-replacements test that uses clang-rename.
sammccall wrote:
> can we add all of clangd to this list with
Author: ioeric
Date: Mon Oct 1 01:50:49 2018
New Revision: 343448
URL: http://llvm.org/viewvc/llvm-project?rev=343448&view=rev
Log:
[clangd] Fix header mapping for std::string. NFC
Some implementation has std::string declared in .
Modified:
clang-tools-extra/trunk/clangd/index/CanonicalIncl
kadircet added a comment.
ping
Repository:
rC Clang
https://reviews.llvm.org/D52225
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
steveire added a comment.
I'll take care of it in a few days and commit it myself. Thanks!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52334
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Awesome! Please do remove that duplication if it's easy.
Comment at: test/CMakeLists.txt:36
set(CLANG_TOOLS_TEST_DEPS
# For the clang-apply-replacements test that
ioeric added inline comments.
Comment at: lib/Sema/SemaCodeComplete.cpp:1603
+ const CodeCompletionContext &CCContext,
+ CodeCompletionBuilder &Builder, Sema &S) {
+ const auto *CR = llvm::dyn_cast(S.CurContext);
--
takuto.ikuta updated this revision to Diff 167682.
takuto.ikuta added a comment.
Extract inline function export check to function
https://reviews.llvm.org/D51340
Files:
clang/include/clang/Basic/LangOptions.h
clang/include/clang/Driver/CC1Options.td
clang/include/clang/Driver/CLCompatOpti
takuto.ikuta updated this revision to Diff 167683.
takuto.ikuta added a comment.
Update comment for Sema::ActOnFinishInlineFunctionDef
https://reviews.llvm.org/D51340
Files:
clang/include/clang/Basic/LangOptions.h
clang/include/clang/Driver/CC1Options.td
clang/include/clang/Driver/CLCompa
takuto.ikuta added a comment.
Thank you for review!
In https://reviews.llvm.org/D51340#1246508, @hans wrote:
> The static local stuff still makes me nervous. How much does Chromium break
> if we just ignore the problem? And how does -fvisibility-inlines-hidden
> handle the issue?
I'm not sur
sammccall created this revision.
sammccall added a reviewer: ioeric.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ilya-biryukov.
- Corpus avoids having to pass size to the true iterator, and (soon) any
iterator that might optimize down to true.
- Shorten names of
takuto.ikuta added inline comments.
Comment at: clang/lib/Sema/SemaDecl.cpp:12624
+ isa(D)) {
+CXXMethodDecl *MD = dyn_cast(D);
+CXXRecordDecl *Class = MD->getParent();
hans wrote:
> Hmm, now we're adding an AST walk over all inline methods which pro
hokein updated this revision to Diff 167689.
hokein marked 2 inline comments as done.
hokein added a comment.
Remove clangd-binary dep in check-clang-tools, and use check-clangd.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52710
Files:
test/CMakeLists.txt
Index: test/CMa
hokein added inline comments.
Comment at: test/CMakeLists.txt:76
-set(llvm_utils
- FileCheck count not
- )
-
-foreach(t ${llvm_utils})
- if(TARGET ${t})
-list(APPEND CLANG_TOOLS_TEST_DEPS ${t})
- endif()
-endforeach()
-
+macro(add_llvm_utils_deps deps)
+ set(llvm_utils
sammccall added inline comments.
Comment at: test/CMakeLists.txt:76
-set(llvm_utils
- FileCheck count not
- )
-
-foreach(t ${llvm_utils})
- if(TARGET ${t})
-list(APPEND CLANG_TOOLS_TEST_DEPS ${t})
- endif()
-endforeach()
-
+macro(add_llvm_utils_deps deps)
+ set(llvm_ut
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: llvm-commits, mgorny.
Address fixme in r301762. And would simplify the cmake file in
clang-tools-extra.
Repository:
rL LLVM
https://reviews.llvm.org/D52713
Files:
cmake/modules/AddLLVM.cmake
Index
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: kadircet, ioeric, ilya-biryukov, mgorny.
clang tools require clang headers to work on real project, e.g. when we
build clangd via `ninja clangd`, we expect the binary can run on
real-world project (without
hokein updated this revision to Diff 167692.
hokein added a comment.
Remove llvm util dependencies (we move it to add_lit_target().
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52710
Files:
test/CMakeLists.txt
Index: test/CMakeLists.txt
===
sammccall accepted this revision.
sammccall added a comment.
Awesome, thanks!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52710
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
sammccall created this revision.
sammccall added a reviewer: ioeric.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ilya-biryukov.
This makes it suitable for logging (which immediately found a bug, to
be fixed in the next patch...)
Repository:
rCTE Clang Tools Ex
Author: sammccall
Date: Mon Oct 1 03:42:51 2018
New Revision: 343453
URL: http://llvm.org/viewvc/llvm-project?rev=343453&view=rev
Log:
[clangd] Query dex index using query-style trigrams, not identifier-style
trigrams
Modified:
clang-tools-extra/trunk/clangd/index/dex/Dex.cpp
Modified: cla
JonasToth updated this revision to Diff 167696.
JonasToth added a comment.
- remove spurious change in fixithintutils
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51949
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/IsolateDeclarationCheck.cpp
clang
peter.smith added a comment.
I think that you may be better off posting a RFC to llvm-dev to get discussion
on the best approach here. It would also be good to step back a bit and
consider the requirements, as it stands it looks like this might be a solution
for just one particular multilib lay
baloghadamsoftware added a comment.
Since modifications of the infrastructure are always error-prone I tried to
generate tests to have full coverage for smaller numbers. However for full
coverage I need type `signed char` and `unsigned char`, but these tests failed
because of this bug: Bug 3913
kadircet updated this revision to Diff 167700.
kadircet marked 6 inline comments as done.
kadircet added a comment.
- Address comments.
Repository:
rC Clang
https://reviews.llvm.org/D52225
Files:
include/clang/Sema/CodeCompleteConsumer.h
lib/Sema/SemaCodeComplete.cpp
test/CodeCompletio
kadircet added inline comments.
Comment at: lib/Sema/SemaCodeComplete.cpp:1639
+llvm::raw_string_ostream OS(OverrideSignature);
+CodeCompletionResult CCR(Method, 0);
+PrintingPolicy Policy =
ioeric wrote:
> Could you add comments explainin
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lg
Comment at: lib/Sema/SemaCodeComplete.cpp:1639
+llvm::raw_string_ostream OS(OverrideSignature);
+CodeCompletionResult CCR(Method, 0);
+PrintingPoli
Author: sammccall
Date: Mon Oct 1 04:56:42 2018
New Revision: 343457
URL: http://llvm.org/viewvc/llvm-project?rev=343457&view=rev
Log:
[CodeComplete] #include completion treats -I as non-system (require header-like
extension).
Modified:
cfe/trunk/lib/Sema/SemaCodeComplete.cpp
cfe/trunk/
alexfh added inline comments.
Comment at: test/clang-tidy/performance-move-constructor-init.cpp:115-117
+ // CHECK-NOTES: 7:1: note: FIX-IT applied suggested code changes
+ // CHECK-NOTES: 113:28: note: FIX-IT applied suggested code changes
+ // CHECK-NOTES: 113:29: note: FIX-
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
Comment at: test/clang-tidy/misc-misplaced-const.c:18
+ // CHECK-NOTES: :[[@LINE-1]]:12: warning: 'i3' declared with a
const-qualified typedef type; results i
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
> when we build clangd via ninja clangd, we expect the binary can run on
> real-world project
FWIW, I don't particularly have this expectation - I expect to be able to run
the tests, an
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added a subscriber: jsji.
This also fixes a crash of code completion on `#include "./^"`.
Repository:
rC Clang
https://reviews.llvm.org/D52721
Files:
lib/Lex/PPDirectives.cpp
test/Preprocessor/include-nonalpha-no-cr
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
So far the change doesn't look really helpful. Are you going to use the
function from code where no `ASTContext` is available? Can you give an example?
Repository:
rCTE Clang Tool
alexfh added inline comments.
Comment at: clang-tidy/tool/clang-tidy-diff.py:123-130
if args.fix:
command.append('-fix')
if args.checks != '':
command.append('-checks=' + quote + args.checks + quote)
if args.quiet:
command.append('-quiet')
if args.build
Author: hokein
Date: Mon Oct 1 05:16:38 2018
New Revision: 343459
URL: http://llvm.org/viewvc/llvm-project?rev=343459&view=rev
Log:
Build clang-headers when building clang tools.
Summary:
clang tools require clang headers to work on real project, e.g. when we
build clangd via `ninja clangd`, we
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343459: Build clang-headers when building clang tools.
(authored by hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D52714
Files:
cfe/tr
sammccall added inline comments.
Comment at: lib/Lex/PPDirectives.cpp:1891
StringRef OriginalFilename = Filename;
if (!File) {
+while (!Filename.empty() && !isAlphanumeric(Filename.front())) {
everything in this block is guarded by !Filename
kristina added a reviewer: kristina.
kristina added a comment.
Able to reproduce easily:
clang-8: /SourceCache/llvm-trunk-8.0/include/llvm/ADT/StringRef.h:143: char
llvm::StringRef::front() const: Assertion `!empty()' failed.
Will try it with patches applied in a moment.
Repository:
rC Cl
ilya-biryukov added a comment.
> I would call it a requirement instead of an assumption. The replay must be
> exactly the same (even the file stats and reads). If Clang reads the file in
> replay which was only stat()ed during compilation, it indicates
> non-determinism or something wrong (in c
kadircet updated this revision to Diff 167708.
kadircet marked 4 inline comments as done.
kadircet added a comment.
- Fix a bug and address comments.
Repository:
rC Clang
https://reviews.llvm.org/D52225
Files:
include/clang/Sema/CodeCompleteConsumer.h
lib/Sema/SemaCodeComplete.cpp
test
kadircet added inline comments.
Comment at: lib/Sema/SemaCodeComplete.cpp:1639
+llvm::raw_string_ostream OS(OverrideSignature);
+CodeCompletionResult CCR(Method, 0);
+PrintingPolicy Policy =
ioeric wrote:
> kadircet wrote:
> > ioeric wrote
kristina added inline comments.
Comment at: lib/Lex/PPDirectives.cpp:1892
if (!File) {
-while (!isAlphanumeric(Filename.front())) {
+while (!Filename.empty() && !isAlphanumeric(Filename.front())) {
Filename = Filename.drop_front();
--
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52687
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
JonasToth added inline comments.
Comment at: test/clang-tidy/performance-move-constructor-init.cpp:115-117
+ // CHECK-NOTES: 7:1: note: FIX-IT applied suggested code changes
+ // CHECK-NOTES: 113:28: note: FIX-IT applied suggested code changes
+ // CHECK-NOTES: 113:29: note: F
kristina added inline comments.
Comment at: lib/Lex/PPDirectives.cpp:1892
if (!File) {
-while (!isAlphanumeric(Filename.front())) {
+while (!Filename.empty() && !isAlphanumeric(Filename.front())) {
Filename = Filename.drop_front();
--
JonasToth added inline comments.
Comment at: test/clang-tidy/misc-misplaced-const.c:18
+ // CHECK-NOTES: :[[@LINE-1]]:12: warning: 'i3' declared with a
const-qualified typedef type; results in the type being 'int *const' instead of
'const int *'
+ // CHECK-NOTES: :[[@LINE-14]
JonasToth added a comment.
This patch is related to https://reviews.llvm.org/D51949
To isolate variable declarations (split `int * p, v;` up) it is necessary to do
a lot of work with source location and requires some forward and backwards
lexing. The functions there just use the LangOpts and th
ilya-biryukov added a comment.
This is awesome! Can't wait for it to land!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52710
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
donat.nagy created this revision.
donat.nagy added a reviewer: NoQ.
Herald added subscribers: cfe-commits, Szelethus, mikhail.ramalho, a.sidorin,
szepet, eraman, xazax.hun.
Herald added a reviewer: george.karpenkov.
StdCLibraryFunctionsChecker models the evaluation of several well-known
functions
donat.nagy abandoned this revision.
donat.nagy added a comment.
I submitted a new patch, which moves stdCLibraryFunctions to apiModeling
(https://reviews.llvm.org/D52722).
Repository:
rC Clang
https://reviews.llvm.org/D52423
___
cfe-commits mail
hokein added a comment.
Need someone stamps on https://reviews.llvm.org/D52713 before landing this
patch :)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52710
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lg
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52226
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
(again I'd just inline this into three `add_dependencies` calls, but up to you)
Repository:
rL LLVM
https://reviews.llvm.org/D52713
___
kadircet updated this revision to Diff 167717.
kadircet added a comment.
- Add a fixme on limitation.
Repository:
rC Clang
https://reviews.llvm.org/D52225
Files:
include/clang/Sema/CodeCompleteConsumer.h
lib/Sema/SemaCodeComplete.cpp
test/CodeCompletion/overrides.cpp
Index: test/CodeC
kadircet updated this revision to Diff 167718.
kadircet added a comment.
rebase & ping
Repository:
rC Clang
https://reviews.llvm.org/D52301
Files:
include/clang/AST/PrettyPrinter.h
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/AST/TypePrinter.cpp
lib/Fron
alexfh added inline comments.
Comment at: test/clang-tidy/misc-misplaced-const.c:18
+ // CHECK-NOTES: :[[@LINE-1]]:12: warning: 'i3' declared with a
const-qualified typedef type; results in the type being 'int *const' instead of
'const int *'
+ // CHECK-NOTES: :[[@LINE-14]]:1
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
In https://reviews.llvm.org/D36836#1249971, @JonasToth wrote:
> Anything new here? Is there a LLVM foundation lawyer or something like that
> we can ask?
I didn't notice any substa
steveire added a comment.
inlining this into three `add_dependencies` calls would remove the `if
(TARGET)` conditions. Are those dependencies conditionally built?
Repository:
rL LLVM
https://reviews.llvm.org/D52713
___
cfe-commits mailing list
c
janosimas added a comment.
I was thinking about the usage of `--` and `-extra-arg`, don't they do the same
thing?
To be honest, for me, the current behavior of `--` doesn't make much sense. If
there is a use case for `-extra-arg-before` and `-extra-arg`, they are much
more clearer in intent.
Fo
hokein added a comment.
In https://reviews.llvm.org/D52713#1250947, @steveire wrote:
> inlining this into three `add_dependencies` calls would remove the `if
> (TARGET)` conditions. Are those dependencies conditionally built?
Yeah, I believe these targets are built conditionally, see
https://
Author: plyster
Date: Mon Oct 1 06:47:43 2018
New Revision: 343472
URL: http://llvm.org/viewvc/llvm-project?rev=343472&view=rev
Log:
Add support for unified_shared_memory clause on requires directive
Modified:
cfe/trunk/include/clang/AST/OpenMPClause.h
cfe/trunk/include/clang/AST/Recursi
hokein updated this revision to Diff 167724.
hokein marked an inline comment as done.
hokein added a comment.
Update the code.
Repository:
rC Clang
https://reviews.llvm.org/D52721
Files:
lib/Lex/PPDirectives.cpp
test/Preprocessor/include-nonalpha-no-crash.c
Index: test/Preprocessor/inc
hokein added inline comments.
Comment at: lib/Lex/PPDirectives.cpp:1891
StringRef OriginalFilename = Filename;
if (!File) {
+while (!Filename.empty() && !isAlphanumeric(Filename.front())) {
sammccall wrote:
> everything in this block is guar
LukeCheeseman updated this revision to Diff 167723.
LukeCheeseman added a comment.
- Introduce the -mbranch-protection option. This is to be used for both pointer
authentication and branch protection security features.
- The branch protection compiler support will follow later
- The options ava
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343473: Move llvm util dependencies from clang-tools-extra
to add_lit_target. (authored by hokein, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D52713
Files:
llvm/trunk/cmake/modules
Author: hokein
Date: Mon Oct 1 07:02:02 2018
New Revision: 343474
URL: http://llvm.org/viewvc/llvm-project?rev=343474&view=rev
Log:
[clangd] Add "check-clangd" target
Summary:
So we don't have to run "check-clang-tools" (which builds and tests all
clang tools) to verify our clangd-related change
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343474: [clangd] Add "check-clangd" target
(authored by hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D52710
Files:
clang-tools-extra/
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Lex/PPDirectives.cpp:1895
+auto CorrectTypoFilename = [](llvm::StringRef Filename) {
+ while (!Filename.empty() && !isAlphanumeric(
kristina added a comment.
Have you tested that build is successful and obviously the FileCheck test
should pass now? What sort of behavior does this produce when you attempt to
use an invalid path like that now when compiling with clang? Just a predecessor
diagnostic?
I'm updating software on
kristina added inline comments.
Comment at: lib/Lex/PPDirectives.cpp:1898
+ }
+ if (Filename.empty())
+return Filename;
sammccall wrote:
> simplify the logic by merging with the while loop? (and drop the assert)
I thought the assert
sammccall added inline comments.
Comment at: lib/Lex/PPDirectives.cpp:1898
+ }
+ if (Filename.empty())
+return Filename;
kristina wrote:
> sammccall wrote:
> > simplify the logic by merging with the while loop? (and drop the assert)
Szelethus added a comment.
Ping ^-^
https://reviews.llvm.org/D51531
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kristina accepted this revision.
kristina added a comment.
Yes I think the clangd crash will have to go in another diff, but this fixes
the crash in clang, which is pretty good in itself. I don't build clangd at the
moment and have no buildbot available so I can try to look into it later if you
kristina added a comment.
Please make sure it builds after you update the revision, I usually do it
myself but it'll take too long on my desktop and I accidentally broke the
hypervisor on my buildbot so can't do it this time.
Comment at: lib/Lex/PPDirectives.cpp:1898
+
gtbercea abandoned this revision.
gtbercea added a comment.
In https://reviews.llvm.org/D29660#1250333, @Hahnfeld wrote:
> Going through my list of reviews, this patch was reverted because of memory
> leaks in other changes. However, I don't think we need this anymore because
> Clang is raising
Author: abataev
Date: Mon Oct 1 07:26:31 2018
New Revision: 343479
URL: http://llvm.org/viewvc/llvm-project?rev=343479&view=rev
Log:
[OPENMP] Fix enum identifier, NFC.
Modified:
cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp
Modified: cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp
URL:
http://llvm.org/vie
hokein updated this revision to Diff 167737.
hokein marked 3 inline comments as done.
hokein added a comment.
Address review comments.
Repository:
rC Clang
https://reviews.llvm.org/D52721
Files:
lib/Lex/PPDirectives.cpp
test/Preprocessor/include-nonalpha-no-crash.c
Index: test/Preproce
hokein added a comment.
I verified this patch is passed all clang tests (`ninja check-clang`).
Repository:
rC Clang
https://reviews.llvm.org/D52721
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
yaxunl added a comment.
this seems to be duplicate of https://reviews.llvm.org/D51857
Is HIP github ready for this change?
Repository:
rC Clang
https://reviews.llvm.org/D52673
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
Author: hokein
Date: Mon Oct 1 07:38:43 2018
New Revision: 343481
URL: http://llvm.org/viewvc/llvm-project?rev=343481&view=rev
Log:
[Preprocessor] Fix a crash when handling non-alpha include header.
Summary: the crash is casued by an assertion in StringRef.
(llvm::StringRef::front() const: Asser
This revision was automatically updated to reflect the committed changes.
Closed by commit rC343481: [Preprocessor] Fix a crash when handling non-alpha
include header. (authored by hokein, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52721?vs=167737&id=167738#toc
Reposito
Author: abataev
Date: Mon Oct 1 07:40:06 2018
New Revision: 343483
URL: http://llvm.org/viewvc/llvm-project?rev=343483&view=rev
Log:
[OPENMP] Simplify code, NFC.
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
URL:
http://ll
ashi1 updated this revision to Diff 167741.
ashi1 added a comment.
Added diff with full context. Also, I need to find replacements for few
functions in HIP github before this can be submitted.
https://reviews.llvm.org/D52673
Files:
lib/Driver/ToolChains/HIP.cpp
test/Driver/hip-device-libs.
krasimir added a comment.
In https://reviews.llvm.org/D52676#1250124, @oleg.smolsky wrote:
> In https://reviews.llvm.org/D52676#1250071, @krasimir wrote:
>
> > In https://reviews.llvm.org/D52676#1249828, @oleg.smolsky wrote:
> >
> > > In https://reviews.llvm.org/D52676#1249784, @krasimir wrote:
>
danzimm added a comment.
@steveire can you land this for me? I don't have commit access
Repository:
rC Clang
https://reviews.llvm.org/D52664
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
Comment at: clang-tidy/tool/clang-tidy-diff.py:123-130
if args.fix:
command.append('-fix')
if args.checks != '':
command.append('-checks=' + quo
yaxunl added a comment.
In https://reviews.llvm.org/D52377#1242547, @tra wrote:
> Overall the patch look OK. I'll take a closer look on Monday.
>
> Which mode do you expect will be most commonly used for HIP by default? With
> this patch we'll have two different ways to do similar things in HIP
javed.absar added inline comments.
Comment at: include/clang/Frontend/CodeGenOptions.h:117
+ enum SignReturnAddressKeyValue { AKey, BKey };
+
Perhaps a line of comment on each enum-value would be useful (much like the
code around).
https://reviews.llvm.org/
sammccall created this revision.
sammccall added a reviewer: hokein.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ioeric, ilya-biryukov.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52726
Files:
clangd/index/Serialization.cpp
clangd/index/de
LukeCheeseman added inline comments.
Comment at: include/clang/Frontend/CodeGenOptions.h:117
+ enum SignReturnAddressKeyValue { AKey, BKey };
+
javed.absar wrote:
> Perhaps a line of comment on each enum-value would be useful (much like the
> code around).
I'
baloghadamsoftware created this revision.
baloghadamsoftware added reviewers: flx, alexfh, aaron.ballman, lebedev.ri.
baloghadamsoftware added a project: clang-tools-extra.
New option added to these three checks to be able to silence false positives on
types that are intentionally passed by value
Author: sammccall
Date: Mon Oct 1 09:07:03 2018
New Revision: 343488
URL: http://llvm.org/viewvc/llvm-project?rev=343488&view=rev
Log:
[Basic] Update clang tests (really testing sys::fs) that broke with r343460
Modified:
cfe/trunk/unittests/Basic/VirtualFileSystemTest.cpp
Modified: cfe/trun
krasimir updated this revision to Diff 167749.
krasimir added a comment.
- Add more tests and tidy-up
Repository:
rC Clang
https://reviews.llvm.org/D52448
Files:
lib/Format/ContinuationIndenter.cpp
unittests/Format/FormatTestRawStrings.cpp
Index: unittests/Format/FormatTestRawStrings.cp
mclow.lists accepted this revision.
mclow.lists added a comment.
Ok. I'm fine with this. Thanks for your patience.
Repository:
rL LLVM
https://reviews.llvm.org/D52401
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
oleg.smolsky added a comment.
In https://reviews.llvm.org/D52676#1250124, @oleg.smolsky wrote:
> In https://reviews.llvm.org/D52676#1250071, @krasimir wrote:
>
> > In https://reviews.llvm.org/D52676#1249828, @oleg.smolsky wrote:
> >
> > > In https://reviews.llvm.org/D52676#1249784, @krasimir wrot
Author: abataev
Date: Mon Oct 1 09:20:57 2018
New Revision: 343492
URL: http://llvm.org/viewvc/llvm-project?rev=343492&view=rev
Log:
[OPENMP][NVPTX] Handle `requires datasharing` flag correctly with
lightweight runtime.
The datasharing flag must be set to `1` when executing SPMD-mode compatible
Lekensteyn requested changes to this revision.
Lekensteyn added a comment.
This revision now requires changes to proceed.
The functionality looks correct to me, but could you include some tests in
test/Driver/ and test/Preprocessor/ just to be sure?
test/Driver/debug-prefix-map.c and test/CodeGen
1 - 100 of 232 matches
Mail list logo
