Quuxplusone updated this revision to Diff 175011.
Quuxplusone added a comment.
Change `1 <<` to `size_t(1) <<` in one last place. @EricWF ping.
Repository:
rCXX libc++
https://reviews.llvm.org/D47358
Files:
include/experimental/memory_resource
src/experimental/memory_resource.cpp
test
dberris accepted this revision.
dberris added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D54784
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
This revision was automatically updated to reflect the committed changes.
Closed by commit rC347444: [Driver] Support XRay on Fuchsia (authored by
phosek, committed by ).
Herald added a subscriber: mgorny.
Changed prior to commit:
https://reviews.llvm.org/D52160?vs=165706&id=175009#toc
Reposit
Author: phosek
Date: Wed Nov 21 18:36:47 2018
New Revision: 347444
URL: http://llvm.org/viewvc/llvm-project?rev=347444&view=rev
Log:
[Driver] Support XRay on Fuchsia
This enables support for XRay in Fuchsia Clang driver.
Differential Revision: https://reviews.llvm.org/D52160
Added:
cfe/tru
kallisti5 added a comment.
Indeed. I agree the _GLIBCXX_USE_FLOAT128 is misplaced there. That comes from
config.h in libstdc++. That's working around an issue in Haiku's build
(libstdc++ is built by gcc, but then we try and use it with clang later)
I can remove that.
Is the __FLOAT128__ desi
Szelethus added a comment.
I also have some very neat ideas how the split up should go, but I'd like to
mature the idea in my head for just a bit longer.
Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:24-27
+// It also has a boolean "Optimistic" checker option
Szelethus created this revision.
Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, rnkovacs.
Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy,
mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, whisperity.
I'm in the process of splitting this checker into multi
kristina added a comment.
Linux, Solaris and OpenBSD also define it where appropriate, it depends on the
target. This is why it's much easier to review when full context (diff with `-U
9`) is provided, and means that it has a much lower change of `patch` doing
something unexpected.
Reposi
js requested changes to this revision.
js added inline comments.
This revision now requires changes to proceed.
Comment at: lib/Basic/Targets/OSTargets.h:262
+ Builder.defineMacro("__FLOAT128__");
+ Builder.defineMacro("_GLIBCXX_USE_FLOAT128");
+}
j
js added inline comments.
Comment at: lib/Basic/Targets/OSTargets.h:262
+ Builder.defineMacro("__FLOAT128__");
+ Builder.defineMacro("_GLIBCXX_USE_FLOAT128");
+}
This seems weird. Shouldn't by stdlibc++ and not by the compiler?
Repository:
rC Cl
kristina added a reviewer: kristina.
kristina added a comment.
Do you mind resubmitting those with context? Also I would suggest asking Tom
Stellard as he's in charge of handling cherrypicking patches to go into
releases once the major rolls over and I think we're pretty close (?) to 7.0.1.
Re
kallisti5 added a comment.
Thanks smeenai! Any chance of this one getting into 7.x.x? It's technically
a bug fix... I think it's the last major hurdle to Haiku compiling (easily)
with clang vs gcc.
Repository:
rC Clang
https://reviews.llvm.org/D53696
_
If it's not too late, could we have this as part of 7.0.1? (You'll also
need to cherry-pick the initial reversion in r338602.) 7.0 hits assertion
failures for pretty basic memcpy cases on windows-msvc targets, and this
patch fixes that.
% cat /tmp/reduced.c
void *memcpy(void *, const void *, __SIZ
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric,
ilya-biryukov.
Currently, there's no way of knowing about header files
using compilation database, since it doesn't contain header files as entries.
Us
mgrang created this revision.
mgrang added reviewers: asb, apazos.
Herald added subscribers: jocewei, PkmX, rkruppe, the_o, brucehoult,
MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng,
niosHD, sabuasal, simoncook, johnrusso, rbar.
Some of these tests break if the RIS
Szelethus added a comment.
Herald added subscribers: gamesh411, baloghadamsoftware.
Polite ping :)
Repository:
rC Clang
https://reviews.llvm.org/D54436
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
phosek added a comment.
I have already reverted the change as r347430 after seeing the failure on
sanitizer bots.
Repository:
rC Clang
https://reviews.llvm.org/D54805
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
MaskRay added a comment.
In https://reviews.llvm.org/D54805#1305749, @pcc wrote:
> Unfortunately it looks like the Android NDK uses some ancient version of gold
> that doesn't support `--push-state`, so we probably can't rely on being able
> to use it.
>
> http://lab.llvm.org:8011/builders/sa
ubsan added a comment.
The ABI breakage was already there, in the difference between GCC and Clang
- if one compiles against libc++ with gcc, it is not compatible with things
that are compiled with clang. I frankly think that being ABI compatible
with gcc (and correct according to the standard)
ldionne added subscribers: dexonsmith, ldionne.
ldionne added a comment.
I'm surprised that nobody discussed the potential for ABI breakage of this
change, which changes the result of the `alignof` operator. I'm trying to
evaluate what to do in libc++ as a result of this change (now
`std::align
Author: phosek
Date: Wed Nov 21 13:59:39 2018
New Revision: 347430
URL: http://llvm.org/viewvc/llvm-project?rev=347430&view=rev
Log:
Revert "[Driver] Use --push/pop-state with Sanitizer link deps"
This reverts commit r347413: older versions of ld.gold that are used
by Android don't support --push
pcc added a comment.
Unfortunately it looks like the Android NDK uses some ancient version of gold
that doesn't support `--push-state`, so we probably can't rely on being able to
use it.
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-android/builds/17287/steps/run%20lit%20tests%20%5Bi6
Charusso added a comment.
In https://reviews.llvm.org/D53076#1305209, @Szelethus wrote:
> In the meanwhile we managed to figure out where the problem lays, so if
> you're interested, I'm going to document it here.
>
> The patch attempts to solve this by inspecting the actual condition, and
> tr
Author: abataev
Date: Wed Nov 21 13:04:34 2018
New Revision: 347425
URL: http://llvm.org/viewvc/llvm-project?rev=347425&view=rev
Log:
[OPENMP][NVPTX]Emit default locations as constant with undefined mode.
For the NVPTX target default locations should be emitted as constants +
additional info must
Author: void
Date: Wed Nov 21 12:45:00 2018
New Revision: 347419
URL: http://llvm.org/viewvc/llvm-project?rev=347419&view=rev
Log:
Update call to EvaluateAsInt() to the new syntax.
Modified:
clang-tools-extra/trunk/clang-tidy/bugprone/MisplacedWideningCastCheck.cpp
clang-tools-extra/trunk
Author: void
Date: Wed Nov 21 12:44:18 2018
New Revision: 347417
URL: http://llvm.org/viewvc/llvm-project?rev=347417&view=rev
Log:
Re-Reinstate 347294 with a fix for the failures.
Don't try to emit a scalar expression for a non-scalar argument to
__builtin_constant_p().
Third time's a charm!
Ad
This revision was automatically updated to reflect the committed changes.
Closed by commit rC347413: [Driver] Use --push/pop-state with Sanitizer link
deps (authored by phosek, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D54805?vs=174952&id=174966#toc
Repository:
rC Cla
Author: phosek
Date: Wed Nov 21 12:33:12 2018
New Revision: 347413
URL: http://llvm.org/viewvc/llvm-project?rev=347413&view=rev
Log:
[Driver] Use --push/pop-state with Sanitizer link deps
Sanitizer runtime link deps handling passes --no-as-needed because of
PR15823, but it never undoes it and thi
This revision was automatically updated to reflect the committed changes.
Closed by commit rC347411: [OPENMP] Refactor code for parsing omp declare
target directive and its clauses… (authored by kli, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D54708?vs=174627&id=174963#to
Author: kli
Date: Wed Nov 21 12:15:57 2018
New Revision: 347411
URL: http://llvm.org/viewvc/llvm-project?rev=347411&view=rev
Log:
[OPENMP] Refactor code for parsing omp declare target directive and its clauses
(NFC)
This patch refactor the code for parsing omp declare target directive and
it
thakis added a comment.
(From a user point of view, I have no idea what "CTAD" means, and I sometimes
work on a C++ compiler.)
Repository:
rC Clang
https://reviews.llvm.org/D54565
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
richard.barton.arm added a comment.
Hi @nickdesaulniers - thanks for the clarification. I was suffering from some
PEBCAK of my own when I thought the commits were not on master. Thanks for
these patches - a great help.
Repository:
rC Clang
https://reviews.llvm.org/D53210
ilya-biryukov updated this revision to Diff 174960.
ilya-biryukov added a comment.
- Remove accidentally added qualifiers
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52311
Files:
clangd/AST.cpp
clangd/AST.h
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd
Author: abataev
Date: Wed Nov 21 11:41:10 2018
New Revision: 347409
URL: http://llvm.org/viewvc/llvm-project?rev=347409&view=rev
Log:
[OPENMP]Fix handling of the LCVs in loop-based directives.
Loop-control variables with the default data-sharing attributes should
not be captured in the OpenMP reg
ilya-biryukov added inline comments.
Comment at: clangd/FindSymbols.cpp:190
+ index::SymbolInfo SymInfo = index::getSymbolInfo(&ND);
+ SymbolKind SK = indexSymbolKindToSymbolKind(SymInfo.Kind);
sammccall wrote:
> may want to add a FIXME here: per the tests, i
ilya-biryukov updated this revision to Diff 174958.
ilya-biryukov marked 15 inline comments as done.
ilya-biryukov added a comment.
- Address comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52311
Files:
clangd/AST.cpp
clangd/AST.h
clangd/ClangdLSPServer.cpp
clan
This revision was automatically updated to reflect the committed changes.
Closed by commit rL347408: [OPENMP] remove redundant MapTypeModifierSpecified
flag in ParseOpenMP.cpp (NFC) (authored by kli, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://revie
Author: kli
Date: Wed Nov 21 11:38:53 2018
New Revision: 347408
URL: http://llvm.org/viewvc/llvm-project?rev=347408&view=rev
Log:
[OPENMP] remove redundant MapTypeModifierSpecified flag in ParseOpenMP.cpp (NFC)
Whether the map type modifier is specified or not, the flag
MapTypeModifierSpecif
morehouse accepted this revision.
morehouse added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D54805
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL347405: [OPENMP] Support relational-op != (not-equal) as one
of the canonical (authored by kli, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.or
Author: kli
Date: Wed Nov 21 11:10:48 2018
New Revision: 347405
URL: http://llvm.org/viewvc/llvm-project?rev=347405&view=rev
Log:
[OPENMP] Support relational-op != (not-equal) as one of the canonical
forms of random access iterator
In OpenMP 4.5, only 4 relational operators are supported: <,
Szelethus added a comment.
Ping, @xazax.hun, any objections?
https://reviews.llvm.org/D52795
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
phosek created this revision.
phosek added reviewers: vitalybuka, morehouse.
Herald added subscribers: cfe-commits, jfb.
Sanitizer runtime link deps handling passes --no-as-needed because of
PR15823, but it never undoes it and this flag may affect other libraries
that come later on the link line.
erichkeane updated this revision to Diff 174950.
erichkeane added a subscriber: grooverdan.
erichkeane added a comment.
Fix @rsmith s comments, rebase on the big CPUDispatch refactor.
https://reviews.llvm.org/D51650
Files:
include/clang/AST/Decl.h
include/clang/Basic/Attr.td
include/clang
Quuxplusone added a comment.
In https://reviews.llvm.org/D50119#1303720, @rjmccall wrote:
> In https://reviews.llvm.org/D50119#1303662, @Quuxplusone wrote:
>
> > >> I still believe it is impossible to implement `std::optional` with only
> > >> `[[maybe_trivially_relocatable]]`.
> > >
> > > This
leonardchan added a comment.
@ebevhan Any more comments on this patch?
Repository:
rC Clang
https://reviews.llvm.org/D53738
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: jgorbe
Date: Wed Nov 21 09:49:37 2018
New Revision: 347402
URL: http://llvm.org/viewvc/llvm-project?rev=347402&view=rev
Log:
Mark lambda decl as invalid if a captured variable has an invalid type.
This causes the compiler to crash when trying to compute a layout for
the lambda closure typ
sammccall added a comment.
Thanks for sending this! Broadly looks good, a few details to work out. I think
the biggest one is multiple symbols which you've flagged.
> I'd like to ask for early feedback - what's still missing is relevant client
> capability.
I'm actually not 100% sure that's ne
donat.nagy marked 6 inline comments as done.
donat.nagy added a comment.
An example of duplicated code in Clang (it appears in
llvm/tools/clang/lib/Frontend/Rewrite/RewriteMacros.cpp starting from line 128):
// If this is a #warning directive or #pragma mark (GNU extensions),
// comment the
jgorbe updated this revision to Diff 174944.
jgorbe added a comment.
Folded the two test cases (capturing an invalid type and capturing an invalid
array type) into a single file.
https://reviews.llvm.org/D54550
Files:
clang/lib/Sema/SemaExpr.cpp
clang/test/SemaCXX/lambda-invalid-capture.cp
donat.nagy updated this revision to Diff 174943.
donat.nagy added a comment.
Implement suggested improvements
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54757
Files:
clang-tidy/bugprone/BranchCloneCheck.cpp
clang-tidy/bugprone/BranchCloneCheck.h
clang-tidy/bugprone/Bu
JonasToth updated this revision to Diff 174942.
JonasToth added a comment.
- Merge branch 'master' into check_const
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45444
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.cpp
mgorny added inline comments.
Comment at: test/CMakeLists.txt:76
+# Add lit test dependencies.
+set(llvm_utils_deps
+ FileCheck count not
Nitpicking a bit but I think it would be better to uppercase it for consistency.
Comment at: test/CMakeLi
hokein added a comment.
The code is not polished yet, I'd like to get some high-level comments before
moving further.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54796
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
djasper added a comment.
Does this also work for _asm and __asm?
Repository:
rC Clang
https://reviews.llvm.org/D54795
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
astrelni marked 5 inline comments as done.
astrelni added a comment.
Sorry for the long delay.
I've reworked the template instantiation stuff a little bit yet again. Going to
still come back and comment with results of profiling but I think now this
shouldn't be much slower than if the template
astrelni updated this revision to Diff 174931.
https://reviews.llvm.org/D53830
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/UpgradeDurationConversionsCheck.cpp
clang-tidy/abseil/UpgradeDurationConversionsCheck.h
docs/ReleaseNotes.rst
Quuxplusone added a comment.
In https://reviews.llvm.org/D54565#1304740, @rsmith wrote:
> In the past, we've been resistant to adding more fine-grained compat
> warnings, because we don't want to encourage subsetting the language (which
> sounds like exactly what you're trying to do here). We g
ioeric updated this revision to Diff 174929.
ioeric added a comment.
- remove unused include
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54800
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/URI.cpp
clangd/URI.h
clangd/index
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ilya-biryukov.
Instead of passing around a list of supported URI schemes in clangd, we
expose an interface to convert a path to URI using any compatible s
jkorous created this revision.
jkorous added reviewers: sammccall, arphaman, benlangmuir.
Herald added subscribers: cfe-commits, kadircet, dexonsmith, MaskRay, ioeric,
ilya-biryukov.
Hi,
I implemented `textDocument/cursorInfo` method based on consensus in
https://reviews.llvm.org/D54529.
I'd li
whisperity added a comment.
In https://reviews.llvm.org/D54757#1305306, @Eugene.Zelenko wrote:
> In https://reviews.llvm.org/D54757#1305114, @whisperity wrote:
>
> > Bar the previous comments, I really like this. The test suite is massive
> > and well-constructed. Do we know of any real-world fi
hokein added a comment.
In https://reviews.llvm.org/D52713#1305291, @mgorny wrote:
> This particular build method uses system-wide installation of these tools.
Sounds fair enough. I sent you two patches to move this back to
clang-tools-extra.
Repository:
rL LLVM
https://reviews.llvm.org/D
hokein created this revision.
hokein added a reviewer: mgorny.
Part of revert r343473
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54798
Files:
test/CMakeLists.txt
Index: test/CMakeLists.txt
===
--- test/CMak
Eugene.Zelenko added a comment.
In https://reviews.llvm.org/D54757#1305114, @whisperity wrote:
> Bar the previous comments, I really like this. The test suite is massive and
> well-constructed. Do we know of any real-world findings, maybe even from LLVM?
GCC 7 introduced -Wduplicated-branches,
baloghadamsoftware added a comment.
In https://reviews.llvm.org/D54466#1297887, @NoQ wrote:
> > I marked this patch as WIP because I could not create a test-case for it.
> > However in real projects this patch seems to reduce false positives
> > significantly.
>
> False positives are hard to re
AlexeySachkov updated this revision to Diff 174919.
AlexeySachkov retitled this revision from "[OpenCL][NFC] Improve test coverage
of test/Index/opencl-types.cl" to "[OpenCL] Launch opencl-types.cl test only on
x86".
AlexeySachkov edited the summary of this revision.
AlexeySachkov added a comment
baloghadamsoftware updated this revision to Diff 174917.
baloghadamsoftware retitled this revision from "[Analyzer] [WIP] Iterator
Checkers - Use the base region of C++ Base Object Regions (recursively) for
iterators stored in a region" to "[Analyzer] Iterator Checkers - Use the region
of the to
mgorny added a comment.
This particular build method uses system-wide installation of these tools.
Repository:
rL LLVM
https://reviews.llvm.org/D52713
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
uweigand added a comment.
In https://reviews.llvm.org/D53157#1305233, @kpn wrote:
> In https://reviews.llvm.org/D53157#1304347, @uweigand wrote:
>
> > But given that there is still infrastructure missing in the IR optimizers,
> > I also think that at least in the first implementation, we probabl
hokein created this revision.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ioeric, javed.absar, ilya-biryukov.
This is a quick prototype (with hacky implementation).
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54796
Files:
clangd/ClangdLSPS
ilya-biryukov added inline comments.
Comment at: clangd/ClangdServer.h:232
+ /// addDocument. Used to avoid races when sending diagnostics to the clients.
+ static Key DocVersionKey;
sammccall wrote:
> I'm not sure using context here buys much: there aren't m
ilya-biryukov updated this revision to Diff 174914.
ilya-biryukov marked an inline comment as done.
ilya-biryukov added a comment.
- Merge the diagnostics callback into ParsingCallbacks
- updateWithDiags(File, getInputs(File...)) -> updateWithDiags(File, ...)
Repository:
rCTE Clang Tools Extra
krasimir created this revision.
Herald added a subscriber: cfe-commits.
r346756 refined clang-format to not treat the `[` in `asm (...: [] ..)` as an
ObjCExpr. However that's not enough, as we might have a comma-separated list of
such clobbers as in the newly added test.
This updates the detection
martong added a comment.
Herald added a subscriber: gamesh411.
That's a good point. I agree, we should check some bits (calling convention
bits) but not all (e.g. noreturn bit). I am going to create another patch which
replaces this.
Repository:
rC Clang
https://reviews.llvm.org/D53699
_
kpn added a comment.
In https://reviews.llvm.org/D53157#1304347, @uweigand wrote:
> But given that there is still infrastructure missing in the IR optimizers, I
> also think that at least in the first implementation, we probably should go
> with the original approach and just use constrained in
hokein added a subscriber: chapuni.
hokein added a comment.
Hi @mgorny, sorry for the trouble it might cause.
In https://reviews.llvm.org/D52713#1305164, @mgorny wrote:
> I would like to request reverting this. It's established standard within LLVM
> to explicitly specify the dependencies the p
Szelethus added a comment.
In the meanwhile we managed to figure out where the problem lays, so if you're
interested, I'm going to document it here.
The problem this patch attempts to solve is that `ConditionBRVisitor` adds
event pieces to the bugpath when the state has changed from the previou
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clangd/TUScheduler.cpp:598
+if (!isCancelled(I->Ctx))
+ continue;
+// Cancelled reads are moved to the front of the queue and run
Author: nico
Date: Wed Nov 21 04:49:22 2018
New Revision: 347390
URL: http://llvm.org/viewvc/llvm-project?rev=347390&view=rev
Log:
Revert 347366, its prerequisite 347364 got reverted.
Modified:
clang-tools-extra/trunk/clang-tidy/bugprone/MisplacedWideningCastCheck.cpp
clang-tools-extra/tr
Author: nico
Date: Wed Nov 21 04:47:43 2018
New Revision: 347389
URL: http://llvm.org/viewvc/llvm-project?rev=347389&view=rev
Log:
Revert r347364 again, the fix was incomplete.
Modified:
cfe/trunk/include/clang/AST/Expr.h
cfe/trunk/lib/AST/ASTImporter.cpp
cfe/trunk/lib/AST/Expr.cpp
nemanjai created this revision.
nemanjai added reviewers: hfinkel, jsji, wuzish.
Herald added subscribers: kristina, kbarton.
A number of builtins in altivec.h load/store vectors from pointers to scalar
types. Currently they just cast the pointer to a vector pointer, but
expressions like that ha
mgorny added a comment.
I would like to request reverting this. It's established standard within LLVM
to explicitly specify the dependencies the particular test suite relies on.
This change causes the `-DLLVM_OCAML_OUT_OF_TREE=1` to start wrongly depending
on additional test utility targets, ca
martong marked an inline comment as done.
martong added inline comments.
Herald added a reviewer: shafik.
Herald added a subscriber: gamesh411.
Comment at: lib/AST/ASTImporter.cpp:7716
}
}
balazske wrote:
> This can be simplified by removing brace character
martong updated this revision to Diff 174897.
martong marked an inline comment as done.
martong removed a reviewer: shafik.
martong removed a subscriber: gamesh411.
martong added a comment.
Herald added a reviewer: shafik.
- Better style without braces
Repository:
rC Clang
https://reviews.llv
martong updated this revision to Diff 174893.
martong marked 4 inline comments as done.
martong added a comment.
Herald added a reviewer: shafik.
Herald added a subscriber: gamesh411.
- Minor style changes and rename a function
Repository:
rC Clang
https://reviews.llvm.org/D53655
Files:
in
martong added inline comments.
Comment at: lib/AST/DeclBase.cpp:1469
assert(Pos != Map->end() && "no lookup entry for decl");
-if (Pos->second.getAsVector() || Pos->second.getAsDecl() == ND)
+// Remove the decl only if it is contained.
+if ((Pos->
whisperity added a comment.
Bar the previous comments, I really like this. The test suite is massive and
well-constructed. Do we know of any real-world findings, maybe even from LLVM?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54757
__
phosek created this revision.
phosek added a reviewer: dberris.
Herald added a subscriber: cfe-commits.
XRay runtime link deps handling passes --no-as-needed, but it never
undoes it and this flag may affect other libraries that come later on
the link line. To avoid this, wrap XRay link deps in --p
89 matches
Mail list logo
