[PATCH] D55698: [MinGW] Produce a vtable and RTTI for dllexported classes without a key function

This revision was automatically updated to reflect the committed changes. Closed by commit rL349256: [MinGW] Produce a vtable and RTTI for dllexported classes without a key function (authored by mstorsjo, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://

r349256 - [MinGW] Produce a vtable and RTTI for dllexported classes without a key function

Author: mstorsjo Date: Sat Dec 15 00:08:11 2018 New Revision: 349256 URL: http://llvm.org/viewvc/llvm-project?rev=349256&view=rev Log: [MinGW] Produce a vtable and RTTI for dllexported classes without a key function This matches what GCC does in these situations. This fixes compiling Qt in debug

r349259 - [libclang] Add dependency on clangSerialization to unbreak -DBUILD_SHARED_LIBS=1 build after rC349237

Author: maskray Date: Sat Dec 15 00:54:06 2018 New Revision: 349259 URL: http://llvm.org/viewvc/llvm-project?rev=349259&view=rev Log: [libclang] Add dependency on clangSerialization to unbreak -DBUILD_SHARED_LIBS=1 build after rC349237 Frontend headers have undefined reference on the symbol `cl

[PATCH] D55734: Refactoring GenericTaintChecker.cpp

boga95 created this revision. boga95 added reviewers: gerazo, xazax.hun, Szelethus, a_sidorin, dcoughlin, george.karpenkov. Herald added subscribers: cfe-commits, rnkovacs. Use a more optimal data structure to represent taint propagation rules. Repository: rC Clang https://reviews.llvm.org/D

[PATCH] D55734: [analyzer] Refactoring GenericTaintChecker.cpp

kristina added a comment. If you don't mind, please submit diffs with full context (`diff -U9` or something alike depending on what you use). It makes it much easier to review patches. Also the formatting looks really off in some places where 4 spaces are used. Also another nitpick, nested

[PATCH] D55734: [analyzer] Refactoring GenericTaintChecker.cpp

Szelethus added a comment. Could you please reupload with full context? :) https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55734/new/ https://reviews.llvm.org/D55734 ___

[PATCH] D54918: [analyzer] Apply clang-format to GenericTaintChecker.cpp

Szelethus added a comment. Please don't mind me intruding. If you create a patch for the Clang Static Analyzer, please add "[analyzer]" in the revision title, because many of us are automatically subscribed to those patches. Also, upload patches with full context. https://llvm.org/docs/Phabricat

[PATCH] D55683: [analyzer] Tests for scan-build?

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. I don't really use `scan-build`, so I can't barrage you with suggestions, but the patch looks great. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55683/

[PATCH] D55730: [analyzer] MoveChecker Pt.9: Add a "peaceful" mode in which it finds only 100% authentic bugs.

Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MoveChecker.cpp:29 namespace { - struct RegionState { Somewhat unrelated, but the size of this anonymous namespace is far too great. Comment at: lib/StaticAnalyzer/Check

[PATCH] D55734: [analyzer] Refactoring GenericTaintChecker.cpp

boga95 updated this revision to Diff 178351. boga95 added a comment. Upload diff with full context. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55734/new/ https://reviews.llvm.org/D55734 Files: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp Index: lib/StaticAnalyzer/Checkers/

[PATCH] D55734: [analyzer] Refactoring GenericTaintChecker.cpp

Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:210-230 + TaintPropagationRule Rule = + llvm::StringSwitch(Name) + .Case("atoi", TaintPropagationRule({0}, {ReturnValueIndex})) + .Case("atol", TaintPropagatio

[PATCH] D55734: [analyzer] Refactoring GenericTaintChecker.cpp

boga95 added a comment. I use std::move which is in the ``. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55734/new/ https://reviews.llvm.org/D55734 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

[PATCH] D54429: [analyzer] Creating standard Sphinx documentation

Szelethus added a comment. That I think sounds great! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54429/new/ https://reviews.llvm.org/D54429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[PATCH] D54918: [analyzer] Apply clang-format to GenericTaintChecker.cpp

Szelethus accepted this revision. Szelethus added a comment. Hmm, actually, if you're doing changes all over the file in the followup patches, it shouldn't matter much. Let's just wait a couple days for ppl to object, now that they are subscribed. Repository: rC Clang CHANGES SINCE LAST ACT

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

MyDeveloperDay updated this revision to Diff 178355. MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added a comment. - Rebase - Reduce false-positives by not adding [[nodiscard]] to functions if the class has mutable fields (removed as known issues) and add tests CHANGES SINCE

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: docs/clang-tidy/checks/modernize-use-nodiscard.rst:23 +Such functions have no means of altering any state or passing values other than +via the return type. Unless the member functi

[PATCH] D55697: [analyzer] Assume that we always have a SubEngine available

This revision was automatically updated to reflect the committed changes. Closed by commit rC349266: [analyzer] Assume that we always have a SubEngine available (authored by xazax, committed by ). Changed prior to commit: https://reviews.llvm.org/D55697?vs=178204&id=178357#toc Repository: rC

r349266 - [analyzer] Assume that we always have a SubEngine available

Author: xazax Date: Sat Dec 15 05:20:33 2018 New Revision: 349266 URL: http://llvm.org/viewvc/llvm-project?rev=349266&view=rev Log: [analyzer] Assume that we always have a SubEngine available The removed codepath was dead. Differential Revision: https://reviews.llvm.org/D55697 Modified: cfe

[PATCH] D55737: [Utils] Attempt to fix clang.natvis following "[AST] Various optimizations in DeclarationName(Table)"

riccibruno created this revision. riccibruno added a reviewer: aaron.ballman. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. `[AST] Various optimizations in DeclarationName(Table)` changed how `DeclarationName`s are represented. Therefore `clang.natvis` needs to be upd

r349274 - [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp

Author: szelethus Date: Sat Dec 15 07:44:05 2018 New Revision: 349274 URL: http://llvm.org/viewvc/llvm-project?rev=349274&view=rev Log: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp Renaming collectCheckers to getEnabledCheckers Changing the functionality to acquire all en

[PATCH] D55734: [analyzer] Refactoring GenericTaintChecker.cpp

boga95 updated this revision to Diff 178368. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55734/new/ https://reviews.llvm.org/D55734 Files: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp Index: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp =

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

MyDeveloperDay updated this revision to Diff 178367. MyDeveloperDay added a comment. -Refactor the checker to remove the llvm::any_of by using a QualType ast-matcher with hasAnyParameter(hasType(x)) - i.e. ...unless(hasAnyParameter(hasType(isNonConstReferenceOrPointer(... -Reduce the SNR ra

[PATCH] D54401: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp

Szelethus closed this revision. Szelethus added a comment. Commited in rC349274 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54401/new/ https://reviews.llvm.org/D54401 ___ cfe-commits mailing list cfe-c

r349275 - [analyzer][NFC] Move CheckerRegistry from the Core directory to Frontend

Author: szelethus Date: Sat Dec 15 08:23:51 2018 New Revision: 349275 URL: http://llvm.org/viewvc/llvm-project?rev=349275&view=rev Log: [analyzer][NFC] Move CheckerRegistry from the Core directory to Frontend ClangCheckerRegistry is a very non-obvious, poorly documented, weird concept. It derives

[PATCH] D54436: [analyzer][NFC] Move CheckerRegistry from the Core directory to Frontend

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL349275: [analyzer][NFC] Move CheckerRegistry from the Core directory to Frontend (authored by Szelethus, committed by ). H

r349278 - Fix a compilation error in examples/

Author: szelethus Date: Sat Dec 15 09:12:38 2018 New Revision: 349278 URL: http://llvm.org/viewvc/llvm-project?rev=349278&view=rev Log: Fix a compilation error in examples/ Modified: cfe/trunk/examples/analyzer-plugin/MainCallChecker.cpp Modified: cfe/trunk/examples/analyzer-plugin/MainCallC

r349279 - Link examples/clang-interpreter against clangSerialization

Author: szelethus Date: Sat Dec 15 10:03:15 2018 New Revision: 349279 URL: http://llvm.org/viewvc/llvm-project?rev=349279&view=rev Log: Link examples/clang-interpreter against clangSerialization Modified: cfe/trunk/examples/clang-interpreter/CMakeLists.txt Modified: cfe/trunk/examples/clang-

r349280 - [analyzer][NFC] Merge ClangCheckerRegistry to CheckerRegistry

Author: szelethus Date: Sat Dec 15 10:11:49 2018 New Revision: 349280 URL: http://llvm.org/viewvc/llvm-project?rev=349280&view=rev Log: [analyzer][NFC] Merge ClangCheckerRegistry to CheckerRegistry Now that CheckerRegistry lies in Frontend, we can finally eliminate ClangCheckerRegistry. Fortunate

[PATCH] D54437: [analyzer][NFC] Merge ClangCheckerRegistry to CheckerRegistry

This revision was automatically updated to reflect the committed changes. Closed by commit rL349280: [analyzer][NFC] Merge ClangCheckerRegistry to CheckerRegistry (authored by Szelethus, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D55734: [analyzer] Refactoring GenericTaintChecker.cpp

Szelethus added a comment. Hmm, I find the revision title and summary a little vague -- I'd expect a revision called "Refactoring" not to feature any funcitonal change, yet you changed how variadic functions are handled. Please - Keep purely formatting changes to your earlier revision, and reba

[PATCH] D55658: Avoid Decl::getASTContext in hot paths where possible, Part 1

vsk added a comment. Thanks for working on this :). It’d be interesting to see some pre/post patch compile time numbers on CTMark. Naive/strawman alternative here, but: what’s the impact on peak RSS and compile time of just storing an ASTContext pointer in Decl/DeclContext? If it’s not out of

[PATCH] D54823: [analyzer][MallocChecker][NFC] Document and reorganize some functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL349281: [analyzer][MallocChecker][NFC] Document and reorganize some functions (authored by Szelethus, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

r349281 - [analyzer][MallocChecker][NFC] Document and reorganize some functions

Author: szelethus Date: Sat Dec 15 10:34:00 2018 New Revision: 349281 URL: http://llvm.org/viewvc/llvm-project?rev=349281&view=rev Log: [analyzer][MallocChecker][NFC] Document and reorganize some functions This patch merely reorganizes some things, and features no functional change. In detail:

[PATCH] D54834: [analyzer][MallocChecker] Improve warning messages on double-delete errors

Szelethus added a comment. In D54834#1315475 , @NoQ wrote: > Thanks, nice catch! > > It seems that the `ReportDoubleDelete()` thing was never used for reporting > double-delete, but it was used for some strange check when a destructor is > called. It w

[PATCH] D54834: [analyzer][MallocChecker] Improve warning messages on double-delete errors

Szelethus marked 2 inline comments as done. Szelethus added inline comments. Comment at: test/Analysis/NewDelete-checker-test.cpp:380 delete foo; delete foo; // expected-warning {{Attempt to delete released memory}} } Right here. Comment

r349283 - [analyzer][MallocChecker] Improve warning messages on double-delete errors

Author: szelethus Date: Sat Dec 15 10:41:37 2018 New Revision: 349283 URL: http://llvm.org/viewvc/llvm-project?rev=349283&view=rev Log: [analyzer][MallocChecker] Improve warning messages on double-delete errors Differential Revision: https://reviews.llvm.org/D54834 Modified: cfe/trunk/lib/St

[PATCH] D55658: Avoid Decl::getASTContext in hot paths where possible, Part 1

riccibruno added a comment. In D55658#1332240 , @vsk wrote: > Thanks for working on this :). It’d be interesting to see some pre/post patch > compile time numbers on CTMark. > > Naive/strawman alternative here, but: what’s the impact on peak RSS and > co

[PATCH] D54834: [analyzer][MallocChecker] Improve warning messages on double-delete errors

This revision was automatically updated to reflect the committed changes. Closed by commit rC349283: [analyzer][MallocChecker] Improve warning messages on double-delete errors (authored by Szelethus, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D548

[PATCH] D55658: Avoid Decl::getASTContext in hot paths where possible, Part 1

vsk added a comment. In D55658#1332249 , @riccibruno wrote: > In D55658#1332240 , @vsk wrote: > > > Thanks for working on this :). It’d be interesting to see some pre/post > > patch compile time numbers on CTMark.

Clang-format - always break after colon

Hi all, Recently we have started using clang-format in our project. However, the it clang-format does not support breaking after colon in constructor init list, which we find very useful. When we always break after colon, it is pretty clear - you always know the arguments are placed below the cons

[PATCH] D55734: [analyzer] Refactoring GenericTaintChecker.cpp

boga95 updated this revision to Diff 178373. boga95 added a comment. Rebase patch on the earlier version. Remove unnecessary inline specifiers. Fix typo. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55734/new/ https://reviews.llvm.org/D55734 Files: lib/StaticAnalyzer/Checkers/Gener

[clang-tools-extra] r349288 - Fix a lit test failure after MallocChecker changes

Author: szelethus Date: Sat Dec 15 16:00:18 2018 New Revision: 349288 URL: http://llvm.org/viewvc/llvm-project?rev=349288&view=rev Log: Fix a lit test failure after MallocChecker changes Modified: clang-tools-extra/trunk/test/clang-tidy/static-analyzer.cpp Modified: clang-tools-extra/trunk/t

[PATCH] D55730: [analyzer] MoveChecker Pt.9: Add a "peaceful" mode in which it finds only 100% authentic bugs.

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MoveChecker.cpp:188-195 + void setAggressiveness(StringRef Str) { +Aggressiveness = +llvm::StringSwitch(Str) +.Case("KnownsOnly", AK_KnownsOnly) +.Case("KnownsAndLocals", AK_Kn

[PATCH] D55741: Implementation Feature Test Macros for P0722R3

ckennelly created this revision. ckennelly added a reviewer: rsmith. Herald added a subscriber: cfe-commits. P1353R0, adopted in San Diego, specified an implementation feature test macro for destroying delete (P0722R3). The implementation of the feature (https://reviews.llvm.org/rL315662) is not