[PATCH] D57219: [Fixed Point Arithmetic] Fixed Point Comparisons

bjope added inline comments. Comment at: clang/test/Frontend/fixed_point_comparisons.c:2 +// RUN: %clang_cc1 -ffixed-point -triple x86_64-unknown-linux-gnu -S -emit-llvm %s -o - | FileCheck %s --check-prefixes=CHECK,SIGNED +// RUN: %clang_cc1 -ffixed-point -triple x86_64-unknown

r352610 - [clang] [Driver] [NetBSD] Append -rpath for shared compiler-rt runtimes

Author: mgorny Date: Wed Jan 30 00:20:24 2019 New Revision: 352610 URL: http://llvm.org/viewvc/llvm-project?rev=352610&view=rev Log: [clang] [Driver] [NetBSD] Append -rpath for shared compiler-rt runtimes Append appropriate -rpath when using shared compiler-rt runtimes, e.g. '-fsanitize=address -

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

MaskRay added a comment. > This segment is not supported at all on NetBSD (stack is always > non-executable), and the option is meant to be used to disable emitting it. The string `.note.GNU-stack` takes only a few bytes in `.shstrtab` and a few for an `Elf64_Shdr` instance. Are there any tools

[PATCH] D57303: [ToolChains] [NetBSD] Append -rpath for shared compiler-rt runtimes

This revision was automatically updated to reflect the committed changes. Closed by commit rL352610: [clang] [Driver] [NetBSD] Append -rpath for shared compiler-rt runtimes (authored by mgorny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llv

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

mgorny added a comment. Besides our verbose purists? Not that I'm aware of. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56554/new/ https://reviews.llvm.org/D56554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

Re: [clang-tools-extra] r352494 - [clangd] Interfaces for writing code tweaks

Hi Ilya, I've no idea why, but when I compile this commit with gcc (7.4.0) the test fixits-command.test fails, and the output from clangd is rather different from when I compile it with clang (3.6.0). So I run build-all/bin/clangd -lit-test < /data/repo/master/llvm-master/tools/clang/tools/ex

Re: [clang-tools-extra] r352494 - [clangd] Interfaces for writing code tweaks

Hi Mikael, I suspect an undefined value creeps in for protocol capabilities, given that we have responses in different formats. I'll investigate, thanks for the report! On Wed, Jan 30, 2019 at 12:05 PM Mikael Holmén wrote: > Hi Ilya, > > I've no idea why, but when I compile this commit with gcc

[PATCH] D52150: [clang-format] BeforeHash added to IndentPPDirectives

geleji added a comment. I would find this useful too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52150/new/ https://reviews.llvm.org/D52150 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang-tools-extra] r352612 - [clangd] Fix a use after move

Author: ibiryukov Date: Wed Jan 30 01:39:01 2019 New Revision: 352612 URL: http://llvm.org/viewvc/llvm-project?rev=352612&view=rev Log: [clangd] Fix a use after move Introduced in r352494. Modified: clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp Modified: clang-tools-extra/trunk/clangd/

[PATCH] D57325: [clangd] Collect macros in static index.

kadircet added inline comments. Comment at: unittests/clangd/BackgroundIndexTests.cpp:128 runFuzzyFind(Idx, ""), UnorderedElementsAre(Named("common"), Named("A_CC"), Named("g"), AllOf(Named("f_b"), Declared(), Not(Defined(); -

Re: [clang-tools-extra] r352494 - [clangd] Interfaces for writing code tweaks

Should be fixed by r352612, let me know if it pops up again. This was a use after move, probably gcc and clang prefer different evaluation order, hence the difference in behaviours. On Wed, Jan 30, 2019 at 12:12 PM Ilya Biryukov wrote: > Hi Mikael, > > I suspect an undefined value creeps in for

Re: [clang-tools-extra] r352494 - [clangd] Interfaces for writing code tweaks

On 1/30/19 10:41 AM, Ilya Biryukov wrote: > Should be fixed by r352612, let me know if it pops up again. > This was a use after move, probably gcc and clang prefer different > evaluation order, hence the difference in behaviours. Awesome! Now it passes also when I compile with gcc. Thanks, Mik

[PATCH] D56927: Disable PIC/PIE for MSP430 target

grimar added a comment. What I noticed, this seems to introduce the first test case in `test\CodeGen\MSP430` folder which uses `clang`. All the others use `llc`. Is it OK? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56927/new/ https://reviews.llvm.org/D56927

[PATCH] D57055: [RISCV] Mark TLS as supported

asb added a comment. Could you add a test for this? I'm not sure if this is best done with a test that uses __has_feature or otherwise (I note other targets don't seem to have similar tests currently), but I think it would be handy. Repository: rC Clang CHANGES SINCE LAST ACTION https://r

[PATCH] D56927: Disable PIC/PIE for MSP430 target

grimar added a comment. Oh sorry, I looked in the wrong folder, my previous comment was not correct. So, this patch adds a test to `test\CodeGen` when we have `test\CodeGen\MSP430` folder. And `test\CodeGen` does not have any tests now at all. So I **guess** the correct way would probably be: 1

[PATCH] D56927: Disable PIC/PIE for MSP430 target

grimar added a comment. Ok, please ignore my comments above. I applied the patch and found it creates the test in `llvm\tools\clang\test\CodeGen` and not in `llvm\test\CodeGen`. Was confused by phab, sorry for the noise. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D56909: [clang-format] Fix line parsing for noexcept lambdas

hultman added a comment. Ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56909/new/ https://reviews.llvm.org/D56909 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D57388: [clangd] Implement textDocument/declaration from LSP 3.14

hokein added a comment. Looks good overall, most are nits. > textDocument/definition now returns a definition if one is found, otherwise > the declaration. It no longer returns declaration + definition if they are > distinct. > textDocument/declaration returns the best declaration we can find.

[PATCH] D57442: [OpenGL] Fix test on PPC after r352540

ioeric created this revision. ioeric added a reviewer: bkramer. Herald added a subscriber: Anastasia. Specify -triple like test/SemaOpenCL/logical-ops.cl. Otherwise, this test fails on PPC. Repository: rC Clang https://reviews.llvm.org/D57442 Files: test/SemaOpenCL/format-strings-fixit.cl

r352617 - [OpenCL] Add generic addr space to the return of implicit assignment.

Author: stulova Date: Wed Jan 30 03:18:08 2019 New Revision: 352617 URL: http://llvm.org/viewvc/llvm-project?rev=352617&view=rev Log: [OpenCL] Add generic addr space to the return of implicit assignment. When creating the prototype of implicit assignment operators the returned reference to the cl

[PATCH] D57101: [OpenCL] Add generic addr space to the return of implicit assignment

This revision was automatically updated to reflect the committed changes. Closed by commit rL352617: [OpenCL] Add generic addr space to the return of implicit assignment. (authored by stulova, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

[PATCH] D57442: [OpenGL] Fix test on PPC after r352540

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57442/new/ https://reviews.llvm.org/D57442 ___ cfe-commits ma

[PATCH] D57442: [OpenGL] Fix test on PPC after r352540

Anastasia accepted this revision. Anastasia added a comment. LGTM! Thanks. Interesting, that test has been committed in Dec. Can you please fix the title in the commit message `[OpenGL]` -> `[OpenCL]`. We are not working on OpenGL yet. :) Repository: rL LLVM CHANGES SINCE LAST ACTION htt

[PATCH] D57442: [OpenGL] Fix test on PPC after r352540

This revision was automatically updated to reflect the committed changes. Closed by commit rL352618: [OpenGL] Fix test on PPC after r352540 (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57

r352618 - [OpenGL] Fix test on PPC after r352540

Author: ioeric Date: Wed Jan 30 03:24:04 2019 New Revision: 352618 URL: http://llvm.org/viewvc/llvm-project?rev=352618&view=rev Log: [OpenGL] Fix test on PPC after r352540 Summary: Specify -triple like test/SemaOpenCL/logical-ops.cl. Otherwise, this test fails on PPC. Reviewers: bkramer Subscri

[PATCH] D57325: [clangd] Collect macros in static index.

hokein marked an inline comment as done. hokein added inline comments. Comment at: unittests/clangd/BackgroundIndexTests.cpp:128 runFuzzyFind(Idx, ""), UnorderedElementsAre(Named("common"), Named("A_CC"), Named("g"), AllOf(Named("f_b"), D

r352620 - [HIP] Fix size_t for MSVC environment

Author: yaxunl Date: Wed Jan 30 04:26:54 2019 New Revision: 352620 URL: http://llvm.org/viewvc/llvm-project?rev=352620&view=rev Log: [HIP] Fix size_t for MSVC environment In 64 bit MSVC environment size_t is defined as unsigned long long. In single source language like HIP, data layout should be

[PATCH] D56318: [HIP] Fix size_t for MSVC environment

This revision was automatically updated to reflect the committed changes. Closed by commit rC352620: [HIP] Fix size_t for MSVC environment (authored by yaxunl, committed by ). Changed prior to commit: https://reviews.llvm.org/D56318?vs=184245&id=184274#toc Repository: rC Clang CHANGES SINCE

[PATCH] D55782: Fix isInSystemMacro to handle pasted token

serge-sans-paille updated this revision to Diff 184275. serge-sans-paille added a comment. Patch updated to take into account @rsmith remarks. Test case added as an illustration. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55782/new/ https://reviews.llvm.org/D

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

enyquist added a comment. Looks fine to me, although I confess I did not build and run it because I don't have the time to set up the environment again, took a few hours last time I built from scratch (side note, if there's an easy way to speed up llvm/clang compilation up I'd love to hear it :

[PATCH] D55782: Fix isInSystemMacro to handle pasted token

serge-sans-paille marked 2 inline comments as done. serge-sans-paille added inline comments. Comment at: include/clang/Basic/SourceManager.h:1458-1460 + // This happens when the macro is the result of a paste, in that case + // its spelling is the scratch mem

[PATCH] D57419: [ASTDump] Move Decl node dumping to TextNodeDumper

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! It's nice to see this piece going in! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57419/new/ https://reviews.llvm.org/D57419 _

[PATCH] D56928: Support attribute used in member funcs of class templates

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some formatting nits. Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:2184 + if (const MemberSpecializationInfo *MSInfo = +

[PATCH] D55878: [Driver] Use --hash-style=gnu instead of both on FreeBSD

kib added a comment. I do not like this. The change makes binaries linked by the default toolchain on FreeBSD, non-standard compliant. Several hundred bytes is not too high cost to pay for not having issues with all tools still not adapted to GNU hash (and never be). Repository: rC Clang

[PATCH] D57086: Ignore trailing NullStmts in StmtExprs for GCC compatibility

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Stmt.h:1259 + // the index of the last one. + unsigned getLastNonNullStmt() const { +assert(!body_empty() && "getLastNonNullStmt"); How about `getIndexOfLastNonNullStmt()` since it doe

r352622 - [clang-format] Fix line parsing for noexcept lambdas

Author: benhamilton Date: Wed Jan 30 05:54:32 2019 New Revision: 352622 URL: http://llvm.org/viewvc/llvm-project?rev=352622&view=rev Log: [clang-format] Fix line parsing for noexcept lambdas Summary: > $ echo "int c = [b]() mutable noexcept { return [&b] { return b++; }(); }();" > |clang-format

[PATCH] D56909: [clang-format] Fix line parsing for noexcept lambdas

benhamilton added a comment. Herald added a subscriber: llvm-commits. So sorry for the delay. I've landed this diff as rC352622 . Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56909/new/ https://reviews.llvm.org/D56909 __

[PATCH] D56909: [clang-format] Fix line parsing for noexcept lambdas

This revision was automatically updated to reflect the committed changes. Closed by commit rL352622: [clang-format] Fix line parsing for noexcept lambdas (authored by benhamilton, committed by ). Changed prior to commit: https://reviews.llvm.org/D56909?vs=182514&id=184281#toc Repository: rL

[PATCH] D57267: [AST] Factor out the logic of the various Expr::Ignore*

aaron.ballman added inline comments. Comment at: lib/AST/Expr.cpp:2562 +static Expr *IgnoreImpCastsSingleStep(Expr *E) { + if (auto *ICE = dyn_cast_or_null(E)) +return ICE->getSubExpr(); riccibruno wrote: > aaron.ballman wrote: > > Do we really need to accep

[clang-tools-extra] r352624 - [clangd] Drop fixes if replying with tweaks resulted in an error

Author: ibiryukov Date: Wed Jan 30 06:24:17 2019 New Revision: 352624 URL: http://llvm.org/viewvc/llvm-project?rev=352624&view=rev Log: [clangd] Drop fixes if replying with tweaks resulted in an error This should not happen in normal operation, as it implies that the diagnostics with some availab

[PATCH] D57032: [SemaCXX] Param diagnostic matches overload logic

modocache updated this revision to Diff 184284. modocache added a comment. Thanks, @cpplearner! You're absolutely right. I got confused because I didn't realize that the method `FunctionProtoType::getUnqualifiedType` was being used from within `Sema::FunctionParamTypesAreEqual`, not `QualType::

[PATCH] D56650: [lld] [ELF] Support customizing behavior on target triple

krytarowski added a comment. @rui we need some resolution here. We have stronger feelings from the community to customize the linker directly based on detected triple. At least other !GNU platforms will benefit from it too (at least FreeBSD, OpenBSD and other BSD derivations like mentioned Cher

[PATCH] D57450: [RISCV] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for RV32/RV64 targets with atomics

asb created this revision. asb added reviewers: jfb, jyknight, wmi. Herald added subscribers: jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, apazos, simoncook, johnrusso, rbar. This ensures that libcalls

[PATCH] D57242: [RISCV] Specify MaxAtomicInlineWidth for RISC-V

asb added a comment. Thanks Lewis, I actually had a patch for this which I forgot to clean up and submit. I've done so now: D57450 . That adds tests, and sets MaxAtomicInlineWidth and MaxAtomicPromoteWidth conditionally based on whether the target has the atomic

[PATCH] D57452: [ASTDumper][OpenMP] CapturedDecl has a 'nothrow' bit

lebedev.ri created this revision. lebedev.ri added reviewers: aaron.ballman, steveire. lebedev.ri added projects: OpenMP, clang. Herald added a subscriber: guansong. Was trying to understand how complicated it would be to write a clang-tidy `openmp-exception-escape`-ish check once D57100

[PATCH] D57452: [ASTDumper][OpenMP] CapturedDecl has a 'nothrow' bit

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57452/new/ https://reviews.llvm.org/D57452 ___ cfe-commits ma

[PATCH] D57452: [ASTDumper][OpenMP] CapturedDecl has a 'nothrow' bit

lebedev.ri added a comment. In D57452#1377140 , @ABataev wrote: > LG Thank you for the review. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57452/new/ https://reviews.llvm.org/D57452

r352631 - [ASTDumper][OpenMP] CapturedDecl has a 'nothrow' bit

Author: lebedevri Date: Wed Jan 30 07:41:20 2019 New Revision: 352631 URL: http://llvm.org/viewvc/llvm-project?rev=352631&view=rev Log: [ASTDumper][OpenMP] CapturedDecl has a 'nothrow' bit Summary: Was trying to understand how complicated it would be to write a clang-tidy `openmp-exception-escape

[PATCH] D57452: [ASTDumper][OpenMP] CapturedDecl has a 'nothrow' bit

This revision was automatically updated to reflect the committed changes. Closed by commit rL352631: [ASTDumper][OpenMP] CapturedDecl has a 'nothrow' bit (authored by lebedevri, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D57452?vs=

Re: r352631 - [ASTDumper][OpenMP] CapturedDecl has a 'nothrow' bit

On Wed, Jan 30, 2019 at 10:41 AM Roman Lebedev via cfe-commits wrote: > > Author: lebedevri > Date: Wed Jan 30 07:41:20 2019 > New Revision: 352631 > > URL: http://llvm.org/viewvc/llvm-project?rev=352631&view=rev > Log: > [ASTDumper][OpenMP] CapturedDecl has a 'nothrow' bit > > Summary: > Was tryi

Re: r352631 - [ASTDumper][OpenMP] CapturedDecl has a 'nothrow' bit

On Wed, Jan 30, 2019 at 6:46 PM Aaron Ballman wrote: > > On Wed, Jan 30, 2019 at 10:41 AM Roman Lebedev via cfe-commits > wrote: > > > > Author: lebedevri > > Date: Wed Jan 30 07:41:20 2019 > > New Revision: 352631 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=352631&view=rev > > Log: > >

Re: r352631 - [ASTDumper][OpenMP] CapturedDecl has a 'nothrow' bit

On Wed, Jan 30, 2019 at 10:49 AM Roman Lebedev wrote: > > On Wed, Jan 30, 2019 at 6:46 PM Aaron Ballman wrote: > > > > On Wed, Jan 30, 2019 at 10:41 AM Roman Lebedev via cfe-commits > > wrote: > > > > > > Author: lebedevri > > > Date: Wed Jan 30 07:41:20 2019 > > > New Revision: 352631 > > > > >

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

VelocityRa added a comment. In D28462#1376710 , @enyquist wrote: > Looks fine to me, although I confess I did not build and run it because I > don't have the time to set up the environment again, took a few hours last > time I built from scratch (side no

[PATCH] D57419: [ASTDump] Move Decl node dumping to TextNodeDumper

lebedev.ri added a comment. Needs rebasing for rL352631 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57419/new/ https://reviews.llvm.org/D57419 ___ cfe-commits mailing list cfe-c

[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Looked this over once more. To me this looks pretty straight-forward. The caching seems ok, too. As long as `ExceptionAnalyzer` does not outlive it's `TU`, everything should be fine. @b

[PATCH] D57343: lit: Let lit.util.which() return a normcase()ed path

thakis added a comment. zturner: ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57343/new/ https://reviews.llvm.org/D57343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[PATCH] D57343: lit: Let lit.util.which() return a normcase()ed path

zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. I think it's possible to detect the case insensitivity of the file system itself, rather than relying on the operating system which as you point out is neither necessary nor sufficient to id

[PATCH] D57162: [DEBUG_INFO][NVPTX] Generate correct data about variable address class.

probinson added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:4235 CGM.getContext().getTargetAddressSpace(D->getType()); +if (CGM.getLangOpts().CUDA && CGM.getLangOpts().CUDAIsDevice) { + if (D->hasAttr()) Can a variable have one of t

[PATCH] D57458: [docs][mips] Clang 8.0 Release notes

atanasyan created this revision. atanasyan added reviewers: hans, petarj, abeserminji, smaksimovic. Herald added subscribers: arichardson, sdardis. MIPS specific part of Clang 8.0 Release notes. Feel free to add more notes if I miss something. Repository: rC Clang https://reviews.llvm.org/D5

[PATCH] D56932: [Driver] [NetBSD] Pass default library search paths to linker

ruiu added a comment. Looks good but I'm probably not the right person to approve a change to this file. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56932/new/ https://reviews.llvm.org/D56932 ___ cfe-commits maili

[PATCH] D57458: [docs][mips] Clang 8.0 Release notes

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Looks good from my perspective. Let me know if you'd like me to commit, otherwise go and commit directly to the branch when you're ready. Repository: rC Clang CHANGES SINCE LAST ACTION https

[PATCH] D53329: Generate DIFile with main program if source is not available

yonghong-song abandoned this revision. yonghong-song added a comment. Abandon this patch as the proposed fix is not correct. I have put relative information in the bug https://bugs.llvm.org/show_bug.cgi?id=40170. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5332

[PATCH] D57162: [DEBUG_INFO][NVPTX] Generate correct data about variable address class.

tra added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:4235 CGM.getContext().getTargetAddressSpace(D->getType()); +if (CGM.getLangOpts().CUDA && CGM.getLangOpts().CUDAIsDevice) { + if (D->hasAttr()) probinson wrote: > Can a variable

[PATCH] D57464: Generalize method overloading on addr spaces to C++

Anastasia created this revision. Anastasia added reviewers: rjmccall, ebevhan. Here is my attempt to generalize the earlier work on method overloading with address spaces https://reviews.llvm.org/D55850 to work in C++ mode (not just OpenCL!). This implementation doesn't apply yet to templated a

[PATCH] D55673: [darwin] parse the SDK settings from SDKSettings.json if it exists and pass in the -target-sdk-version to the compiler and backend

tra added a comment. Would that be OK to use target_sdk_version to pass *CUDA* SDK version to the CC1 compilations? I have upcoming changes that need to know the version to generate correct glue IR for CUDA. The driver currently figures out detected CUDA version in lib/Driver/ToolChains/Cuda.cp

[PATCH] D56650: [lld] [ELF] Support customizing behavior on target triple

ruiu added a comment. Kamil, I understand how adding `--target` option to the linker would make target-specific customization easier, but that's as I said not acceptable by design in lld. The code we have for FreeBSD just sets one bit in the output file, and that's fundamentally different from

[PATCH] D55673: [darwin] parse the SDK settings from SDKSettings.json if it exists and pass in the -target-sdk-version to the compiler and backend

arphaman added a comment. In D55673#1377404 , @tra wrote: > Would that be OK to use target_sdk_version to pass *CUDA* SDK version to the > CC1 compilations? > I have upcoming changes that need to know the version to generate correct > glue IR for CUDA.

[PATCH] D56650: [lld] [ELF] Support customizing behavior on target triple

mgorny added a comment. I think the main concern is that if we link `ld -> ld.lld`, gcc will no longer work out of the box. So we would have to repeat all the logic in gcc and in any other compiler that calls `ld` directly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56650/new/ http

[PATCH] D57427: [CodeGen][ObjC] Fix assert on calling `__builtin_constant_p` with ObjC objects.

vsapsai updated this revision to Diff 184334. vsapsai added a comment. - Add in the test `-disable-llvm-passes` and relax FileCheck expectations to accept alloca-store-load. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57427/new/ https://reviews.llvm.org/D57427 Files: clang/lib/Cod

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Eugene.Zelenko added inline comments. Comment at: clang-tidy/abseil/AbseilTidyModule.cpp:61 +"abseil-wrap-unique"); + + } Unnecessary empty line. Comment at: clang-tidy/abseil/WrapUniqueCheck.cpp:10 + +#include +#include "WrapUniqueCh

[PATCH] D56650: [lld] [ELF] Support customizing behavior on target triple

ruiu added a comment. But that's only adding missing `-L` and perhaps a few more, no? That doesn't seem too hard to do in gcc. I don't want to repeat what compiler drivers do in the linker. Also, even with this patch, you need to make a change to gcc to pass `--target` parameter to the linker,

Re: r352610 - [clang] [Driver] [NetBSD] Append -rpath for shared compiler-rt runtimes

Merged to 8.0 in r352650. On Wed, Jan 30, 2019 at 3:20 AM Michal Gorny via cfe-commits wrote: > > Author: mgorny > Date: Wed Jan 30 00:20:24 2019 > New Revision: 352610 > > URL: http://llvm.org/viewvc/llvm-project?rev=352610&view=rev > Log: > [clang] [Driver] [NetBSD] Append -rpath for shared com

[PATCH] D56650: [lld] [ELF] Support customizing behavior on target triple

mgorny added a comment. In D56650#1377494 , @ruiu wrote: > But that's only adding missing `-L` and perhaps a few more, no? That doesn't > seem too hard to do in gcc. Probably not, provided nobody will block it. I'm not the one opposed to it. > I don't

[PATCH] D52339: Support enums with a fixed underlying type in all language modes

arphaman added a comment. Herald added a subscriber: jkorous. @erik.pilkington the change to make `objc_fixed_enum` true in non-ObjC mode turned out to be problematic for our adoption. Could you please fix it before LLVM8 is wrapped up so that we don't ship this extension as on by default for a

[PATCH] D53076: [analyzer] Enhance ConditionBRVisitor to write out more information

Charusso added a comment. Thanks you @NoQ! Luckily it is rely on `ProgramPoints` now. The only problem as I see the mentioned Z3-test, where I have no idea what happened. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53076/new/ https://reviews.llvm.org/D53076 ___

[PATCH] D52339: Support enums with a fixed underlying type in all language modes

arphaman added a comment. We could introduce a new extension flag like `c_fixed_enum` that can be set for all language modes. `objc_fixed_enum` should apply to ObjC only. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52339/new/ https://reviews.llvm.org/D52339

[libunwind] r352654 - [CMake] Use correct visibility for linked libraries in CMake

Author: phosek Date: Wed Jan 30 11:27:26 2019 New Revision: 352654 URL: http://llvm.org/viewvc/llvm-project?rev=352654&view=rev Log: [CMake] Use correct visibility for linked libraries in CMake When linking library dependencies, we shouldn't need to export linked libraries to dependents. We shoul

[PATCH] D56650: [lld] [ELF] Support customizing behavior on target triple

ruiu added a comment. If you still need to patch GNU ld, it doesn't seems like this patch makes things easier for you. (But even if this would make it easier for you, this patch's approach is not okay by design though.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56650/new/ https://

r352655 - [ASTDump] Move Decl node dumping to TextNodeDumper

Author: steveire Date: Wed Jan 30 11:32:48 2019 New Revision: 352655 URL: http://llvm.org/viewvc/llvm-project?rev=352655&view=rev Log: [ASTDump] Move Decl node dumping to TextNodeDumper Reviewers: aaron.ballman Subscribers: jfb, cfe-commits Differential Revision: https://reviews.llvm.org/D57419

[PATCH] D57419: [ASTDump] Move Decl node dumping to TextNodeDumper

This revision was automatically updated to reflect the committed changes. Closed by commit rL352655: [ASTDump] Move Decl node dumping to TextNodeDumper (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D57419?vs=184

[PATCH] D57419: [ASTDump] Move Decl node dumping to TextNodeDumper

steveire added a comment. In D57419#1377187 , @lebedev.ri wrote: > Needs rebasing for rL352631 . Thanks. Rebased and re-tested. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57419/new/

r352656 - [ASTDump] NFC: Inline vestigial methods

Author: steveire Date: Wed Jan 30 11:41:04 2019 New Revision: 352656 URL: http://llvm.org/viewvc/llvm-project?rev=352656&view=rev Log: [ASTDump] NFC: Inline vestigial methods This was a porting aid. Modified: cfe/trunk/lib/AST/ASTDumper.cpp Modified: cfe/trunk/lib/AST/ASTDumper.cpp URL: ht

r352657 - [ASTDump] Rename methods which are conceptually Visits

Author: steveire Date: Wed Jan 30 11:49:49 2019 New Revision: 352657 URL: http://llvm.org/viewvc/llvm-project?rev=352657&view=rev Log: [ASTDump] Rename methods which are conceptually Visits This is consistent with the TextNodeDumper, and is the appropriate name for the traverser class which will

[libunwind] r352658 - Revert "[CMake] Use correct visibility for linked libraries in CMake"

Author: phosek Date: Wed Jan 30 11:51:18 2019 New Revision: 352658 URL: http://llvm.org/viewvc/llvm-project?rev=352658&view=rev Log: Revert "[CMake] Use correct visibility for linked libraries in CMake" This reverts commit r352654: this broke libcxx and sanitizer bots. Modified: libunwind/tr

r352661 - [ASTDump] Re-arrange method declarations to group Visit together

Author: steveire Date: Wed Jan 30 12:03:47 2019 New Revision: 352661 URL: http://llvm.org/viewvc/llvm-project?rev=352661&view=rev Log: [ASTDump] Re-arrange method declarations to group Visit together This will make follow-up commits easier to review. Modified: cfe/trunk/lib/AST/ASTDumper.cpp

r352663 - [ASTDump] Make method definition order matches declaration order

Author: steveire Date: Wed Jan 30 12:06:52 2019 New Revision: 352663 URL: http://llvm.org/viewvc/llvm-project?rev=352663&view=rev Log: [ASTDump] Make method definition order matches declaration order This will make follow-up changes easier to review. Modified: cfe/trunk/lib/AST/ASTDumper.cpp

[PATCH] D56650: [lld] [ELF] Support customizing behavior on target triple

krytarowski added a comment. If we pass flags from clang, we sacrifice: - lld usable as a standalone executable - gcc capable to use lld as a functional linker - clang driver not capable to call unpatched gnu ld/gold as we grow local flags to workaroud the customization (such as -z nognustack) -

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57353: [clang-tidy] Add the abseil-duration-double-conversion check

hwright marked 2 inline comments as done. hwright added inline comments. Comment at: docs/clang-tidy/checks/abseil-duration-double-conversion.rst:20 + + + // Original - Conversion to integer and back again MyDeveloperDay wrote: > hwright wrote: > > Eugene.Zelenk

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyu2 updated this revision to Diff 184349. jyu2 marked an inline comment as done. jyu2 added a comment. Change test for BE IR change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/ https://reviews.llvm.org/D56571 Files: include/clang/AST/Expr.h include/clang/AST/ExprCXX.h

r352665 - Add a new builtin: __builtin_dynamic_object_size

Author: epilk Date: Wed Jan 30 12:34:53 2019 New Revision: 352665 URL: http://llvm.org/viewvc/llvm-project?rev=352665&view=rev Log: Add a new builtin: __builtin_dynamic_object_size This builtin has the same UI as __builtin_object_size, but has the potential to be evaluated dynamically. It is mean

r352664 - Add a 'dynamic' parameter to the objectsize intrinsic

Author: epilk Date: Wed Jan 30 12:34:35 2019 New Revision: 352664 URL: http://llvm.org/viewvc/llvm-project?rev=352664&view=rev Log: Add a 'dynamic' parameter to the objectsize intrinsic This is meant to be used with clang's __builtin_dynamic_object_size. When 'true' is passed to this parameter, t

[PATCH] D56650: [lld] [ELF] Support customizing behavior on target triple

krytarowski added a comment. In D56650#1377546 , @ruiu wrote: > If you still need to patch GNU ld, it doesn't seems like this patch makes > things easier for you. (But even if this would make it easier for you, this > patch's approach is not okay by desi

[PATCH] D56760: Add a new builtin: __builtin_dynamic_object_size

This revision was automatically updated to reflect the committed changes. Closed by commit rL352665: Add a new builtin: __builtin_dynamic_object_size (authored by epilk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56760?vs=181923&i

r352669 - [OPENMP]Fix PR40536: Do not emit __kmpc_push_target_tripcount if not

Author: abataev Date: Wed Jan 30 12:49:52 2019 New Revision: 352669 URL: http://llvm.org/viewvc/llvm-project?rev=352669&view=rev Log: [OPENMP]Fix PR40536: Do not emit __kmpc_push_target_tripcount if not required. Function __kmpc_push_target_tripcount should be emitted only if the offloading entry

[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

baloghadamsoftware added a comment. In D57100#1373440 , @JonasToth wrote: > @baloghadamsoftware Do you see any problems with the refactoring, especially > the new `FunctionDecl*`-Caching is not exactly a refactoring. If you have any > thoughts on that wo

r352672 - Don't define __has_feature(objc_fixed_enum) in non-objc mode

Author: epilk Date: Wed Jan 30 13:14:08 2019 New Revision: 352672 URL: http://llvm.org/viewvc/llvm-project?rev=352672&view=rev Log: Don't define __has_feature(objc_fixed_enum) in non-objc mode This is only a formal language feature in ObjC, otherwise its just an extension. Making this change was

[PATCH] D52339: Support enums with a fixed underlying type in all language modes

erik.pilkington added a comment. In D52339#1377527 , @arphaman wrote: > @erik.pilkington the change to make `objc_fixed_enum` true in non-ObjC mode > turned out to be problematic for our adoption. Could you please fix it before > LLVM8 is wrapped up so t

Re: r352672 - Don't define __has_feature(objc_fixed_enum) in non-objc mode

Hans, can you cherry-pick this into LLVM 8? Thanks! On 1/30/19 1:14 PM, Erik Pilkington via cfe-commits wrote: Author: epilk Date: Wed Jan 30 13:14:08 2019 New Revision: 352672 URL: http://llvm.org/viewvc/llvm-project?rev=352672&view=rev Log: Don't define __has_feature(objc_fixed_enum) in non-

[PATCH] D57458: [docs][mips] Clang 8.0 Release notes

This revision was automatically updated to reflect the committed changes. Closed by commit rL352675: [docs][mips] Clang 8.0 Release notes (authored by atanasyan, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D57458?vs=184309&id=184358

  1   2   >