[PATCH] D48116: [libclang] Allow skipping warnings from all included files

nik added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48116/new/ https://reviews.llvm.org/D48116 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41005/new/ https://reviews.llvm.org/D41005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D53866: [Preamble] Stop circular inclusion of main file when building preamble

nik added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53866/new/ https://reviews.llvm.org/D53866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D58514: Avoid needlessly copying blocks that initialize or are assigned to local auto variables to the heap

rjmccall added a comment. I see, alright. Comment at: lib/CodeGen/CGObjC.cpp:3215 +if (be->getBlockDecl()->canAvoidCopyToHeap()) + return value; + Can this just be a case in `ARCRetainExprEmitter`? I think that should subsume both this and the logic

[PATCH] D58514: Avoid needlessly copying blocks that initialize or are assigned to local auto variables to the heap

ahatanak updated this revision to Diff 187904. ahatanak added a comment. Remove the code that is needed to check whether the address of a local variable is taken. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58514/new/ https://reviews.llvm.org/D58514 Files:

[PATCH] D58514: Avoid needlessly copying blocks that initialize or are assigned to local auto variables to the heap

ahatanak added a comment. For assignment, the optimization isn't performed if the local variable isn't declared in the scope that introduced the block (see the code and comment in SemaExpr.cpp). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58514/new/

[PATCH] D55250: [clangd] Enhance macro hover to see full definition

malaperle updated this revision to Diff 187902. malaperle added a comment. Remove Markdown support. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55250/new/ https://reviews.llvm.org/D55250 Files: clangd/XRefs.cpp

[PATCH] D55250: [clangd] Enhance macro hover to see full definition

malaperle marked an inline comment as done. malaperle added inline comments. Comment at: clangd/ClangdLSPServer.cpp:816 +// If the client supports Markdown, convert from plaintext here. +if (*H && HoverSupportsMarkdown) { +

[PATCH] D58514: Avoid needlessly copying blocks that initialize or are assigned to local auto variables to the heap

rjmccall added a comment. The correctness condition here is solely that we cannot allow the block literal to go out of scope before the variable that it is assigned to. (Local block literals with captures have lifetimes like C compound literals: until the end of the enclosing block, rather

[PATCH] D57896: Variable names rule

lattner added a comment. I can understand Zach's position here, but LLDB has historically never conformed to the general LLVM naming or other conventions due to its heritage. It should not be taken as precedent that the rest of the project should follow. In any case, I think that it is best

[PATCH] D58164: Block+lambda: allow reference capture

rjmccall added a comment. I agree. There should just never be a copy expression if the capture is of reference type, and there should therefore be no need to special-case that in IRGen. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58164/new/

r354651 - revert r354615: [HIP] change kernel stub name

Author: yaxunl Date: Thu Feb 21 20:20:12 2019 New Revision: 354651 URL: http://llvm.org/viewvc/llvm-project?rev=354651=rev Log: revert r354615: [HIP] change kernel stub name It caused regressions. Differential Revision: https://reviews.llvm.org/D58518 Modified:

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

smeenai accepted this revision. smeenai added reviewers: beanz, phosek. smeenai added a comment. This revision is now accepted and ready to land. LGTM, though I generally prefer functions to macros. Comment at: clang/lib/Headers/CMakeLists.txt:127 -# Generate arm_neon.h

[PATCH] D16351: [FIX] Bug 25404 - Crash on typedef in OpenCL 2.0

arsenm added a comment. Herald added subscribers: jdoerfert, jfb, yaxunl, wdng. Is this still needed? The bug is still open CHANGES SINCE LAST ACTION https://reviews.llvm.org/D16351/new/ https://reviews.llvm.org/D16351 ___ cfe-commits mailing

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

tstellar created this revision. tstellar added reviewers: chandlerc, smeenai, mgorny. Herald added a project: clang. Herald added a subscriber: cfe-commits. Replace cut and pasted code with cmake macros and reduce the number of install commands. This fixes an issue where the headers were being

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

jacob-keller added a comment. In regards to whether clang-format should support this feature, I think it's pretty clear that a large number of users want it to. The tool already supports formatting various other definitions in a similar manner, including variables and struct members. So I

[PATCH] D56990: Bugfix for Replacement of tied operand of inline asm

efriedma added inline comments. Comment at: test/Sema/inline-asm-x86-constraint.c:2 +// REQUIRES: x86-registered-target +// RUN: %clang_cc1 %s -o %t +typedef unsigned char __attribute__((vector_size(8))) _m64u8; Test belongs in test/CodeGen. Please use

[PATCH] D57835: Fix -ftime-report with -x ir

arsenm added a comment. Herald added a subscriber: jdoerfert. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57835/new/ https://reviews.llvm.org/D57835 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

hubert.reinterpretcast added a comment. In D18360#1406455 , @apaprocki wrote: > @hubert.reinterpretcast Yes, this patch is available under the new license. Thank you, @apaprocki. We will be splitting this into updated and more granular patches.

Buildbot numbers for the week of 02/10/2019 - 02/16/2019

Hello everyone, Below are some buildbot numbers for the last week of 02/10/2019 - 02/16/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from

Buildbot numbers for the week of 02/03/2019 - 02/09/2019

Hello everyone, Below are some buildbot numbers for the week of 02/03/2019 - 02/09/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

[PATCH] D52956: Support `-fno-visibility-inlines-hidden`

smeenai added a comment. You should ask the reviewers to commit it in your behalf. You can request commit access after you've had a few patches accepted and committed. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52956/new/ https://reviews.llvm.org/D52956

[PATCH] D52956: Support `-fno-visibility-inlines-hidden`

andrewjcg added a comment. Herald added a project: clang. Sorry for the delay here, but this should be ready to go. As this is my first accepted diff to LLVM, should I follow https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access to get commit access, or is there some other process

[PATCH] D58368: [analyzer] MIGChecker: Implement bug reporter visitors.

Charusso added a comment. In D58368#1406490 , @NoQ wrote: > Address comments. > > @Charusso: I agreed not to rush for D58367 > and implemented an old-style visitor here instead :) Thanks you! I wanted to accept it when

[PATCH] D58531: [clang] Specify type of pthread_create builtin

jrtc27 added a comment. A separate point is whether it makes sense to be emitting this warning in the first place for `GE_Missing_type`. I'd argue that, if we don't know the type of the builtin, we should never emit the warning, since otherwise we always emit the warning even for legitimate

[PATCH] D58529: [analyzer] MIGChecker: Enable by default.

NoQ closed this revision. NoQ added a comment. Committed as rC354644 but i forgot to update the link as usual. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58529/new/ https://reviews.llvm.org/D58529

r354644 - [analyzer] MIGChecker: Enable by default as `osx.MIG'.

Author: dergachev Date: Thu Feb 21 16:18:46 2019 New Revision: 354644 URL: http://llvm.org/viewvc/llvm-project?rev=354644=rev Log: [analyzer] MIGChecker: Enable by default as `osx.MIG'. With r354643, the checker is feature-rich and polished enough. rdar://problem/35380337 Differential

[PATCH] D58397: [analyzer] MIGChecker: Pour more data into the checker.

This revision was automatically updated to reflect the committed changes. Closed by commit rL354643: [analyzer] MIGChecker: Add support for more APIs. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r354643 - [analyzer] MIGChecker: Add support for more APIs.

Author: dergachev Date: Thu Feb 21 16:15:14 2019 New Revision: 354643 URL: http://llvm.org/viewvc/llvm-project?rev=354643=rev Log: [analyzer] MIGChecker: Add support for more APIs. Add more "consuming" functions. For now only vm_deallocate() was supported. Add a non-zero value that isn't an

[PATCH] D58392: [analyzer] MIGChecker: Fix false negatives for releases in automatic destructors.

This revision was automatically updated to reflect the committed changes. Closed by commit rL354642: [analyzer] MIGChecker: Fix an FN when the object is released in a destructor. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[PATCH] D58530: Add PragmaHandler for MSVC pragma execution_character_set

sigatrev created this revision. sigatrev added reviewers: cfe-commits, rnk. Herald added subscribers: jdoerfert, jsji, kbarton, nemanjai. Herald added a project: clang. __pragma(execution_character_set(push, "UTF-8")) is used in TraceLoggingProvider.h. This commit implements a no-op handler for

[PATCH] D58531: [clang] Specify type of pthread_create builtin

jrtc27 created this revision. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. Currently, pthread_create's type string is empty, so GetBuiltinType fails and any header declaring it gives a -Wbuiltin-requires-header warning, which gives a false-positive when including

[PATCH] D58366: [analyzer] MIGChecker: Make use of the server routine annotation.

NoQ closed this revision. NoQ added a comment. Committed as rC354638 but i screwed up the link in the commit message. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58366/new/ https://reviews.llvm.org/D58366

r354642 - [analyzer] MIGChecker: Fix an FN when the object is released in a destructor.

Author: dergachev Date: Thu Feb 21 16:09:56 2019 New Revision: 354642 URL: http://llvm.org/viewvc/llvm-project?rev=354642=rev Log: [analyzer] MIGChecker: Fix an FN when the object is released in a destructor. When a MIG server routine argument is released in an automatic destructor, the Static

[PATCH] D58368: [analyzer] MIGChecker: Implement bug reporter visitors.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL354641: [analyzer] MIGChecker: Improve intermediate diagnostic notes. (authored by dergachev, committed by ). Herald

r354641 - [analyzer] MIGChecker: Improve intermediate diagnostic notes.

Author: dergachev Date: Thu Feb 21 16:06:30 2019 New Revision: 354641 URL: http://llvm.org/viewvc/llvm-project?rev=354641=rev Log: [analyzer] MIGChecker: Improve intermediate diagnostic notes. Add a BugReporterVisitor for highlighting the events of deallocating a parameter. All such events are

r354638 - [analyzer] MIGChecker: Take advantage of the mig_server_routine annotation.

Author: dergachev Date: Thu Feb 21 16:02:47 2019 New Revision: 354638 URL: http://llvm.org/viewvc/llvm-project?rev=354638=rev Log: [analyzer] MIGChecker: Take advantage of the mig_server_routine annotation. r354530 has added a new function/block/message attribute "mig_server_routine" that

[PATCH] D57558: [analyzer] MIGChecker: A checker for Mach Interface Generator calling convention.

This revision was automatically updated to reflect the committed changes. Closed by commit rC354635: [analyzer] MIGChecker: A checker for Mach Interface Generator conventions. (authored by dergachev, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit:

r354635 - [analyzer] MIGChecker: A checker for Mach Interface Generator conventions.

Author: dergachev Date: Thu Feb 21 15:55:28 2019 New Revision: 354635 URL: http://llvm.org/viewvc/llvm-project?rev=354635=rev Log: [analyzer] MIGChecker: A checker for Mach Interface Generator conventions. This checker detects use-after-free bugs in (various forks of) the Mach kernel that are

[PATCH] D58529: [analyzer] MIGChecker: Enable by default.

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58529/new/ https://reviews.llvm.org/D58529 ___

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

tmroeder marked an inline comment as done. tmroeder added inline comments. Comment at: lib/AST/ASTImporter.cpp:6160 + // condition-dependent. + bool CondIsTrue = false; + if (!E->isConditionDependent()) tmroeder wrote: > aaron.ballman wrote: > > tmroeder

[PATCH] D58529: [analyzer] MIGChecker: Enable by default.

NoQ added a comment. The TODOs for future polishing are: - Add a second `trackExpressionValue()` visitor to track argument values as they're copied around. - Introduce annotations for deallocator functions so that we no longer had to hardcode them and users could annotate their consuming

[PATCH] D58529: [analyzer] MIGChecker: Enable by default.

NoQ created this revision. NoQ added a reviewer: dcoughlin. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. NoQ added a comment. The TODOs for future polishing are: - Add a

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

aaron.ballman added inline comments. Comment at: lib/AST/ASTImporter.cpp:6160 + // condition-dependent. + bool CondIsTrue = false; + if (!E->isConditionDependent()) tmroeder wrote: > a_sidorin wrote: > > aaron.ballman wrote: > > > tmroeder wrote: > > > >

[PATCH] D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor.

NoQ updated this revision to Diff 187877. NoQ added a comment. Unblock the unrelated MIGChecker patches by untangling them from this core change. This patch will land after them and now includes an update to the checker that demonstrates the use of (and, well, tests) the new API. Comments were

[PATCH] D57226: [Fixed Point] [AST] Add an AST serialization code for fixed-point literals.

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. Herald added a project: clang. LGTM. Everything still seems to work on my end after applying this diff. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D58397: [analyzer] MIGChecker: Pour more data into the checker.

NoQ updated this revision to Diff 187876. NoQ added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58397/new/ https://reviews.llvm.org/D58397 Files: clang/lib/StaticAnalyzer/Checkers/MIGChecker.cpp clang/test/Analysis/mig.mm Index:

[PATCH] D58392: [analyzer] MIGChecker: Fix false negatives for releases in automatic destructors.

NoQ updated this revision to Diff 187875. NoQ added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58392/new/ https://reviews.llvm.org/D58392 Files: clang/lib/StaticAnalyzer/Checkers/MIGChecker.cpp clang/test/Analysis/mig.mm Index: clang/test/Analysis/mig.mm

[PATCH] D58368: [analyzer] MIGChecker: Implement bug reporter visitors.

NoQ updated this revision to Diff 187873. NoQ marked an inline comment as done. NoQ added a comment. Address comments. @Charusso: I agreed not to rush for D58367 and implemented an old-style visitor here instead :) CHANGES SINCE LAST ACTION

[PATCH] D58366: [analyzer] MIGChecker: Make use of the server routine annotation.

NoQ updated this revision to Diff 187872. NoQ added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58366/new/ https://reviews.llvm.org/D58366 Files: clang/lib/StaticAnalyzer/Checkers/MIGChecker.cpp clang/test/Analysis/mig.mm Index: clang/test/Analysis/mig.mm

[PATCH] D58368: [analyzer] MIGChecker: Implement bug reporter visitors.

NoQ marked 3 inline comments as done. NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MIGChecker.cpp:47 REGISTER_TRAIT_WITH_PROGRAMSTATE(ReleasedParameter, bool); Charusso wrote: > `;` is not necessary. Addressed in the earlier

r354633 - Use _Q as MS ABI mangling for char8_t.

Author: rsmith Date: Thu Feb 21 15:04:35 2019 New Revision: 354633 URL: http://llvm.org/viewvc/llvm-project?rev=354633=rev Log: Use _Q as MS ABI mangling for char8_t. Thanks to Yuriy Solodkyy for letting us know the mangling here. Modified: cfe/trunk/lib/AST/MicrosoftMangle.cpp

[PATCH] D58523: [OpenMP 5.0] Parsing/sema support for to and from clauses with mapper modifier

lildmh updated this revision to Diff 187869. lildmh marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58523/new/ https://reviews.llvm.org/D58523 Files: include/clang/AST/OpenMPClause.h include/clang/Basic/DiagnosticParseKinds.td

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous marked an inline comment as done. jkorous added a comment. Fixed closing of FD. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58418/new/ https://reviews.llvm.org/D58418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57896: Variable names rule

probinson added a comment. In D57896#1406412 , @MyDeveloperDay wrote: > In D57896#1406407 , @zturner wrote: > > > If I read the post correctly, it was actually agreeing with me (because it > > said "to reinforce

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous updated this revision to Diff 187868. jkorous added a comment. - handle errors returned by close CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58418/new/ https://reviews.llvm.org/D58418 Files: clang/include/clang/DirectoryWatcher/DirectoryWatcher.h clang/lib/CMakeLists.txt

[PATCH] D58397: [analyzer] MIGChecker: Pour more data into the checker.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MIGChecker.cpp:125 + // See if there's an annotated method in the superclass. + if (const auto *MD = dyn_cast(D)) dcoughlin wrote: > Perhaps we

[PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

apaprocki added a comment. @hubert.reinterpretcast Yes, this patch is available under the new license. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D18360/new/ https://reviews.llvm.org/D18360 ___ cfe-commits mailing list

[PATCH] D57716: [CUDA][HIP] Check calling convention based on function target

tra added inline comments. Comment at: test/SemaCUDA/amdgpu-windows-vectorcall.cu:3 + +// expected-no-diagnostics +template tra wrote: > It may be good to add a check where we *would* expect to see the diagnostics. > It may be good to add a check where we

[PATCH] D58523: [OpenMP 5.0] Parsing/sema support for to and from clauses with mapper modifier

lildmh marked 12 inline comments as done. lildmh added inline comments. Comment at: lib/AST/OpenMPClause.cpp:1469 void OMPClausePrinter::VisitOMPFromClause(OMPFromClause *Node) { if (!Node->varlist_empty()) { ABataev wrote: > Better to split this patch

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

tmroeder marked an inline comment as done. tmroeder added inline comments. Comment at: lib/AST/ASTImporter.cpp:6160 + // condition-dependent. + bool CondIsTrue = false; + if (!E->isConditionDependent()) a_sidorin wrote: > aaron.ballman wrote: > > tmroeder

[PATCH] D58478: [index-while-building] FileIndexRecord

jkorous marked 3 inline comments as done. jkorous added a comment. Done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58478/new/ https://reviews.llvm.org/D58478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D58478: [index-while-building] FileIndexRecord

jkorous updated this revision to Diff 187863. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58478/new/ https://reviews.llvm.org/D58478 Files: clang/include/clang/Index/DeclOccurrence.h clang/lib/Index/CMakeLists.txt clang/lib/Index/FileIndexRecord.cpp

[PATCH] D57112: [ASTTypeTraits] OMPClause handling

lebedev.ri added a comment. Maybe ping @klimek then? :) In D57112#1400046 , @alexfh wrote: > In D57112#1399516 , @lebedev.ri > wrote: > > > Ping @hokein / @alexfh (as per git blame). > > Not sure who is best

[PATCH] D57896: Variable names rule

MyDeveloperDay added a comment. In D57896#1406407 , @zturner wrote: > If I read the post correctly, it was actually agreeing with me (because it > said "to reinforce your point...". Meaning that something such as > `lowerCaseCamel` would be the third

[PATCH] D57896: Variable names rule

zturner added a comment. In D57896#1406401 , @probinson wrote: > In D57896#1406353 , @MyDeveloperDay > wrote: > > > I can't argue with anything you say.. but I guess to reinforce your point > > introducing what

[PATCH] D57716: [CUDA][HIP] Check calling convention based on function target

yaxunl updated this revision to Diff 187862. yaxunl added a comment. Herald added a subscriber: jdoerfert. Revised by Artem's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57716/new/ https://reviews.llvm.org/D57716 Files: lib/Sema/SemaDeclAttr.cpp

[PATCH] D57896: Variable names rule

probinson added a comment. In D57896#1406353 , @MyDeveloperDay wrote: > I can't argue with anything you say.. but I guess to reinforce your point > introducing what is effectively a 3rd style would likely cause even more > jarring... Zach isn't

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous added a comment. Thanks for taking a look Michał! I'll try to address the rest of your comments asap. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58418/new/ https://reviews.llvm.org/D58418 ___ cfe-commits mailing list

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous updated this revision to Diff 187860. jkorous marked 2 inline comments as done. jkorous added a comment. - handle EINTR - assert we are reading whole INotifyEvents CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58418/new/ https://reviews.llvm.org/D58418 Files:

r354626 - [clang-cl] Whitelist -fbracket-depth=123 in clang-cl

Author: rnk Date: Thu Feb 21 13:53:12 2019 New Revision: 354626 URL: http://llvm.org/viewvc/llvm-project?rev=354626=rev Log: [clang-cl] Whitelist -fbracket-depth=123 in clang-cl Users apparently need it when expanding large quantities of macros. Fixes PR38685 Modified:

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

a_sidorin added inline comments. Comment at: lib/AST/ASTImporter.cpp:6160 + // condition-dependent. + bool CondIsTrue = false; + if (!E->isConditionDependent()) aaron.ballman wrote: > tmroeder wrote: > > aaron.ballman wrote: > > > a_sidorin wrote: > > > >

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

riccibruno added a comment. Oh and I think that you will also have to update the serialization code/de-serialization code in `ASTReaderDecl.cpp` / `ASTWriterDecl.cpp`. You might also have to update `TreeTransform` but I am less familiar with this. CHANGES SINCE LAST ACTION

[PATCH] D58526: AMDGPU: Don't emit debugger subtarget features

arsenm closed this revision. arsenm added a comment. r354624 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58526/new/ https://reviews.llvm.org/D58526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r354624 - AMDGPU: Don't emit debugger subtarget features

Author: arsenm Date: Thu Feb 21 13:31:43 2019 New Revision: 354624 URL: http://llvm.org/viewvc/llvm-project?rev=354624=rev Log: AMDGPU: Don't emit debugger subtarget features Keep the flag around for compatability. Modified: cfe/trunk/lib/Driver/ToolChains/AMDGPU.cpp

[PATCH] D57896: Variable names rule

MyDeveloperDay added a comment. In D57896#1406336 , @zturner wrote: > ... I can't argue with anything you say.. but I guess to reinforce your point introducing what is effectively a 3rd style would likely cause even more jarring... Repository: rG

[PATCH] D58478: [index-while-building] FileIndexRecord

Eugene.Zelenko added inline comments. Comment at: clang/include/clang/Index/DeclOccurrence.h:1 +//===--- DeclOccurrence.h - An occurrence of a decl within a file - C++ -*-===// +// Tag should contain *- C++ -*, so you could remove dashes at beginning and equal

[PATCH] D58477: [Driver] Fix float ABI default for Android ARMv8.

This revision was automatically updated to reflect the committed changes. Closed by commit rL354622: [Driver] Fix float ABI default for Android ARMv8. (authored by danalbert, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

riccibruno added a comment. If this bit is relevant to function parameters, why is `getIsArgumentModified` in `VarDecl` and not in `ParamVarDecl` ? What you can do is move the relevant methods to `ParamVarDecl`, and stash the bit in `ParmVarDeclBitfields`. Comment at:

[PATCH] D57896: Variable names rule

zturner added a comment. In D57896#1405334 , @MyDeveloperDay wrote: > In D57896#1402280 , @zturner wrote: > > > Since someone already accepted this, I suppose I should mark require > > changes to formalize my

r354622 - [Driver] Fix float ABI default for Android ARMv8.

Author: danalbert Date: Thu Feb 21 13:13:03 2019 New Revision: 354622 URL: http://llvm.org/viewvc/llvm-project?rev=354622=rev Log: [Driver] Fix float ABI default for Android ARMv8. Summary: Android doesn't regress back to soft float after ARMv7 :) Reviewers: srhines, pirama Reviewed By:

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous updated this revision to Diff 187850. jkorous added a comment. - license - end-of-include-guard comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58418/new/ https://reviews.llvm.org/D58418 Files: clang/include/clang/DirectoryWatcher/DirectoryWatcher.h

[PATCH] D58526: AMDGPU: Don't emit debugger subtarget features

arsenm updated this revision to Diff 187849. arsenm added a comment. Undelete run line CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58526/new/ https://reviews.llvm.org/D58526 Files: lib/Driver/ToolChains/AMDGPU.cpp test/Driver/amdgpu-features.c Index:

[PATCH] D58526: AMDGPU: Don't emit debugger subtarget features

kzhuravl accepted this revision. kzhuravl added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58526/new/ https://reviews.llvm.org/D58526 ___ cfe-commits mailing list

[PATCH] D58518: [HIP] change kernel stub name

tra added a comment. In D58518#1406274 , @t-tye wrote: > To clarify, I am saying that the stub does have a different name since it is > conceptually part of the implementation of doing the call to the device > function implementation, and is not in fact

[PATCH] D58478: [index-while-building] FileIndexRecord

jkorous added a comment. Thanks Eugene. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58478/new/ https://reviews.llvm.org/D58478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D58478: [index-while-building] FileIndexRecord

jkorous updated this revision to Diff 187848. jkorous marked 5 inline comments as done. jkorous added a comment. - license - remove auto CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58478/new/ https://reviews.llvm.org/D58478 Files: clang/include/clang/Index/DeclOccurrence.h

[PATCH] D58314: [Driver] Sync ARM behavior between clang-as and gas.

danalbert marked 3 inline comments as done. danalbert added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:389 +std::string DefaultFPU = getDefaultFPUName(Triple); +if (DefaultFPU != "") { + if

r354621 - [Fixed Point Arithmetic] Fixed Point Comparisons

Author: leonardchan Date: Thu Feb 21 12:50:09 2019 New Revision: 354621 URL: http://llvm.org/viewvc/llvm-project?rev=354621=rev Log: [Fixed Point Arithmetic] Fixed Point Comparisons This patch implements fixed point comparisons with other fixed point types and integers. This also provides

[PATCH] D57219: [Fixed Point Arithmetic] Fixed Point Comparisons

This revision was automatically updated to reflect the committed changes. Closed by commit rC354621: [Fixed Point Arithmetic] Fixed Point Comparisons (authored by leonardchan, committed by ). Changed prior to commit: https://reviews.llvm.org/D57219?vs=184886=187847#toc Repository: rC Clang

[PATCH] D58526: AMDGPU: Don't emit debugger subtarget features

kzhuravl added inline comments. Comment at: test/Driver/amdgpu-features.c:4 // CHECK-MAMDGPU-DEBUGGER-ABI-0-0: the clang compiler does not support '-mamdgpu-debugger-abi=0.0' - -// RUN: %clang -### -target amdgcn -x cl -S -emit-llvm -mcpu=kaveri -mamdgpu-debugger-abi=1.0 %s

[PATCH] D58526: AMDGPU: Don't emit debugger subtarget features

arsenm created this revision. arsenm added reviewers: yaxunl, kzhuravl, t-tye. Herald added subscribers: jdoerfert, tpr, dstuttard, nhaehnle, wdng, jvesely. Keep the flag around for compatability. https://reviews.llvm.org/D58526 Files: lib/Driver/ToolChains/AMDGPU.cpp

[PATCH] D58525: [clangd] Don't attach FixIt to the source code in macro.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric. Herald added a project: clang. We are less certain it is the correct fix. Also, clang doesn't apply FixIt to the source code in macro. Repository: rCTE

[PATCH] D58518: [HIP] change kernel stub name

This revision was automatically updated to reflect the committed changes. Closed by commit rC354615: [HIP] change kernel stub name (authored by yaxunl, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D58518?vs=187815=187840#toc Repository: rC

[PATCH] D57219: [Fixed Point Arithmetic] Fixed Point Comparisons

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. No, this LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57219/new/ https://reviews.llvm.org/D57219 ___

[PATCH] D58518: [HIP] change kernel stub name

t-tye added a comment. To clarify, I am saying that the stub does have a different name since it is conceptually part of the implementation of doing the call to the device function implementation, and is not in fact the the device function being called itself. However, when we generate code

r354615 - [HIP] change kernel stub name

Author: yaxunl Date: Thu Feb 21 12:12:16 2019 New Revision: 354615 URL: http://llvm.org/viewvc/llvm-project?rev=354615=rev Log: [HIP] change kernel stub name Add .stub to kernel stub function name so that it is different from kernel name in device code. This is necessary to let debugger find

[PATCH] D58523: [OpenMP 5.0] Parsing/sema support for to and from clauses with mapper modifier

ABataev added inline comments. Comment at: include/clang/Basic/OpenMPKinds.def:585 +// Modifiers for 'to' and 'from' clause. +OPENMP_TO_FROM_MODIFIER_KIND(mapper) + Maybe, better to split it. There must be separate modifiers for `from` clause and for `to`

[PATCH] D58518: [HIP] change kernel stub name

tra added a comment. In D58518#1406202 , @t-tye wrote: > Yes this relates to supporting the debugger. > > For the same function being present on both host and device, having the same > name is correct as the debugger must set a breakpoint at both places.

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

hokein added a comment. In D58345#1401907 , @sammccall wrote: > In D58345#1401213 , @hokein wrote: > > > In D58345#1401040 , @ioeric wrote: > > > > > Looks great! Thanks for

  1   2   3   >