jacob-keller added a comment.

In regards to whether clang-format should support this feature, I think it's 
pretty clear that a large number of users want it to. The tool already supports 
formatting various other definitions in a similar manner, including variables 
and struct members. So I don't see how a similar features which aligns 
consecutive macros is something which doesn't make sense.

Additionally, because the formatting will *undo* such formatting if done 
manually, it means that the existing source code formatting this way cannot be 
handled via clang-format. In my case, it essentially means that I cannot use 
clang-format to enforce the style guidelines, as the macros definitions are 
aligned.

Additionally, aligning a series of macros makes sense because it helps improve 
readability, and is thus something that I'd rather not lose if I were to switch 
to using clang-format without the feature.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D28462/new/

https://reviews.llvm.org/D28462



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to