[PATCH] D58724: [gnustep-objc] Make the GNUstep v2 ABI work for Windows DLLs.

DHowett-MSFT added inline comments. Comment at: clang/lib/CodeGen/CGObjCGNU.cpp:1231 +break; + +auto Storage = llvm::GlobalValue::DefaultStorageClass; After we get the `ObjCInterfaceDecl`, we have to make sure it's the one corresponding to

r355176 - Fix file headers. NFC

Author: maskray Date: Thu Feb 28 22:49:51 2019 New Revision: 355176 URL: http://llvm.org/viewvc/llvm-project?rev=355176=rev Log: Fix file headers. NFC Modified: cfe/trunk/lib/ARCMigrate/TransEmptyStatementsAndDealloc.cpp cfe/trunk/lib/ARCMigrate/TransformActions.cpp

r355175 - [Sema][ObjC] Allow silencing -Wobjc-designated-initializers warnings by

Author: ahatanak Date: Thu Feb 28 22:43:20 2019 New Revision: 355175 URL: http://llvm.org/viewvc/llvm-project?rev=355175=rev Log: [Sema][ObjC] Allow silencing -Wobjc-designated-initializers warnings by declaring an unavailable method in the subclass's extension that overrides the designated

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev marked an inline comment as done. anton-afanasyev added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:23 #include "clang/Sema/Lookup.h" +#include "clang/Sema/SemaInternal.h" #include "clang/Sema/Template.h" RKSimon

[PATCH] D58791: [build] Rename clang-headers to clang-resource-headers

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58791/new/ https://reviews.llvm.org/D58791

[PATCH] D57986: [ProfileData] Sort FuncData before iteration to remove non-determinism

mgrang updated this revision to Diff 188843. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57986/new/ https://reviews.llvm.org/D57986 Files: lib/ProfileData/InstrProfWriter.cpp Index: lib/ProfileData/InstrProfWriter.cpp

[PATCH] D58147: [CodeGen] Fix calling llvm.var.annotation outside of a basic block.

This revision was automatically updated to reflect the committed changes. Closed by commit rL355166: [CodeGen] Fix calling llvm.var.annotation outside of a basic block. (authored by vsapsai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D58147: [CodeGen] Fix calling llvm.var.annotation outside of a basic block.

vsapsai added a comment. Thanks for the review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58147/new/ https://reviews.llvm.org/D58147 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r355166 - [CodeGen] Fix calling llvm.var.annotation outside of a basic block.

Author: vsapsai Date: Thu Feb 28 18:15:39 2019 New Revision: 355166 URL: http://llvm.org/viewvc/llvm-project?rev=355166=rev Log: [CodeGen] Fix calling llvm.var.annotation outside of a basic block. When we have an annotated local variable after a function returns, we generate IR that fails

[PATCH] D58807: [CodeGen] COMDAT-fold block descriptors

DHowett-MSFT created this revision. DHowett-MSFT added a project: clang. Herald added a subscriber: cfe-commits. Without this change, linking multiple objects containing block descriptors together on Windows will generate duplicate symbol errors. Repository: rG LLVM Github Monorepo

[PATCH] D57986: [ProfileData] Sort FuncData before iteration to remove non-determinism

mgrang updated this revision to Diff 188824. mgrang retitled this revision from "[ProfileData] Remove non-determinism: Change DenseMap to MapVector" to "[ProfileData] Sort FuncData before iteration to remove non-determinism". mgrang added a reviewer: dblaikie. Herald added a subscriber:

[PATCH] D58791: [build] Rename clang-headers to clang-resource-headers

smeenai created this revision. smeenai added reviewers: beanz, phosek, tstellar, rnk, dim. Herald added subscribers: openmp-commits, Sanitizers, jdoerfert, javed.absar, mgorny. Herald added a reviewer: serge-sans-paille. Herald added projects: clang, Sanitizers, LLDB, OpenMP, LLVM. The current

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

MyDeveloperDay added a comment. > ClamAV recently started using clang-format. We published this blog post > about how we're using it: > https://blog.clamav.net/2019/02/clamav-adopts-clang-format.html One of the > things I called out in the blog post is that we really want this feature, and

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

micah-s added a comment. In D28462#1413332 , @MyDeveloperDay wrote: > Would you please consider logging your struct example from your blog at > https://bugs.llvm.org, I see a large number of people using clang format > on/off in github for this and

[PATCH] D57898: CodeGen: Fix PR40605 by splitting constant struct initializers

jfb accepted this revision. jfb added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57898/new/ https://reviews.llvm.org/D57898 ___ cfe-commits mailing list

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous updated this revision to Diff 188808. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58418/new/ https://reviews.llvm.org/D58418 Files: clang/include/clang/DirectoryWatcher/DirectoryWatcher.h clang/lib/CMakeLists.txt clang/lib/DirectoryWatcher/CMakeLists.txt

[PATCH] D55964: [clang-format][TableGen] Don't add spaces around items in square braces.

This revision was automatically updated to reflect the committed changes. Closed by commit rC355158: [clang-format][TableGen] Dont add spaces around items in square braces. (authored by rupprecht, committed by ). Changed prior to commit: https://reviews.llvm.org/D55964?vs=188765=188807#toc

r355158 - [clang-format][TableGen] Don't add spaces around items in square braces.

Author: rupprecht Date: Thu Feb 28 16:12:18 2019 New Revision: 355158 URL: http://llvm.org/viewvc/llvm-project?rev=355158=rev Log: [clang-format][TableGen] Don't add spaces around items in square braces. Summary: clang-formatting wants to add spaces around items in square braces, e.g. [1, 2] ->

[PATCH] D55170: [clang-format]: Add NonEmptyParentheses spacing option

MyDeveloperDay added a comment. sorry to be critical, just trying to help get traction on your review... Comment at: lib/Format/TokenAnnotator.cpp:65 -const FormatToken = *CurrentToken->Previous; // The '<'. +const FormatToken = *CurrentToken->Previous; // The

[PATCH] D58797: [Sema] Add some compile time _FORTIFY_SOURCE diagnostics

erik.pilkington created this revision. erik.pilkington added reviewers: george.burgess.iv, rsmith, aaron.ballman. Herald added subscribers: jdoerfert, dexonsmith, jkorous. Herald added a project: clang. These diagnose overflowing calls to subset of fortifiable functions. Some functions, like

[PATCH] D55170: [clang-format]: Add NonEmptyParentheses spacing option

MyDeveloperDay added a comment. Hi @reuk, I'm trying to go over old reviews and see if they are still desired, I stumbled on your review and want to see if its still important. Here is some initial feedback. I know its ironic that the clang-format code isn't clang-formatted itself, but it

[PATCH] D58729: Emit boxed expression as a compile-time constant if the expression inside the parentheses is a string literal

ahatanak added inline comments. Comment at: lib/Sema/SemaExprObjC.cpp:534 +NSStringPointer, NSStringPointer); +return new (Context) ObjCBoxedExpr(SL, BoxedType, nullptr, SR); + } rjmccall wrote: > ahatanak wrote: > > rjmccall wrote: > >

[PATCH] D58729: Emit boxed expression as a compile-time constant if the expression inside the parentheses is a string literal

ahatanak updated this revision to Diff 188794. ahatanak marked 4 inline comments as done. ahatanak added a comment. Address review comments. - Preserve sugar when creating an `ObjCBoxedExpr` in `Sema::BuildObjCBoxedExpr`. - Add a test case to test/SemaObjC/boxing-illegal.m that shows clang

[PATCH] D58091: Customize warnings for missing built-in type

bcain added a comment. In D58091#1409584 , @jdoerfert wrote: > I did address the comments but I will wait until I hear back on the "warning > vs warning + note question". ... > I do not have strong feelings about this, either way is fine with me. >

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

RKSimon added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:23 #include "clang/Sema/Lookup.h" +#include "clang/Sema/SemaInternal.h" #include "clang/Sema/Template.h" anton-afanasyev wrote: > RKSimon wrote: > > nfc change? > What do

[libunwind] r355142 - [CMake][libunwind] Define add_target_flags which is missing

Author: phosek Date: Thu Feb 28 13:38:59 2019 New Revision: 355142 URL: http://llvm.org/viewvc/llvm-project?rev=355142=rev Log: [CMake][libunwind] Define add_target_flags which is missing It's use was introduced in r353084 but its definition is missing. Differential Revision:

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous updated this revision to Diff 188783. jkorous added a comment. - fix the linux implementation - clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58418/new/ https://reviews.llvm.org/D58418 Files: clang/include/clang/DirectoryWatcher/DirectoryWatcher.h

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev marked 3 inline comments as done. anton-afanasyev added a comment. Ok, I'm to add tests and reviewers. Comment at: clang/lib/Sema/Sema.cpp:113 + llvm::TimeTraceProfilerEnd(); +} S->DiagnoseNonDefaultPragmaPack( RKSimon

[PATCH] D58743: Handle built-in when importing SourceLocation and FileID

shafik added a comment. In D58743#1413249 , @lebedev.ri wrote: > Is there a test missing here? This origin of this fix is the LLDB expression parsing issue. We were not able to reduce to a test we could put in `ASTImpoterTest.cpp` but we have a LLDB

[clang-tools-extra] r355132 - [clang-tidy] add OverrideMacro to modernize-use-override check

Author: paulhoad Date: Thu Feb 28 12:00:48 2019 New Revision: 355132 URL: http://llvm.org/viewvc/llvm-project?rev=355132=rev Log: [clang-tidy] add OverrideMacro to modernize-use-override check Summary: The usefulness of **modernize-use-override** can be reduced if you have to live in an

[PATCH] D58236: Make address space conversions a bit stricter.

efriedma added a comment. > I think trying to reject code that is doing something dangerous is a good > thing! Refusing to compile code which is suspicious, but not forbidden by the specification, will likely cause compatibility issues; there are legitimate reasons to use casts which look

[PATCH] D57087: [clang-tidy] add OverrideMacro to modernize-use-override check

This revision was automatically updated to reflect the committed changes. Closed by commit rL355132: [clang-tidy] add OverrideMacro to modernize-use-override check (authored by paulhoad, committed by ). Herald added a project: LLVM. Changed prior to commit:

[PATCH] D58724: [gnustep-objc] Make the GNUstep v2 ABI work for Windows DLLs.

DHowett-MSFT added inline comments. Comment at: clang/lib/CodeGen/CGObjCGNU.cpp:188 + StringRef SymbolPrefix() { +return CGM.getTriple().isOSBinFormatCOFF() ? "_" : "._"; theraven wrote: > DHowett-MSFT wrote: > > theraven wrote: > > > DHowett-MSFT wrote:

[PATCH] D58724: [gnustep-objc] Make the GNUstep v2 ABI work for Windows DLLs.

theraven marked 2 inline comments as done. theraven added inline comments. Comment at: clang/lib/CodeGen/CGObjCGNU.cpp:188 + StringRef SymbolPrefix() { +return CGM.getTriple().isOSBinFormatCOFF() ? "_" : "._"; DHowett-MSFT wrote: > theraven wrote: > >

[PATCH] D55964: [clang-format][TableGen] Don't add spaces around items in square braces.

MyDeveloperDay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55964/new/ https://reviews.llvm.org/D55964 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D55964: [clang-format][TableGen] Don't add spaces around items in square braces.

rupprecht updated this revision to Diff 188765. rupprecht added a comment. Rebase after NFC commit rC355123 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55964/new/ https://reviews.llvm.org/D55964 Files:

[PATCH] D56943: [clang-format][NFC] Allow getLLVMStyle() to take a language

This revision was automatically updated to reflect the committed changes. Closed by commit rL355123: [clang-format][NFC] Allow getLLVMStyle() to take a language (authored by rupprecht, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r355123 - [clang-format][NFC] Allow getLLVMStyle() to take a language

Author: rupprecht Date: Thu Feb 28 11:16:45 2019 New Revision: 355123 URL: http://llvm.org/viewvc/llvm-project?rev=355123=rev Log: [clang-format][NFC] Allow getLLVMStyle() to take a language Summary: getLLVMStyle() sets the default style, but doesn't take the language as a parameter, so can't

[PATCH] D58742: [WebAssembly] Remove uses of ThreadModel

sbc100 added a comment. In D58742#1413979 , @sunfish wrote: > Wasm gives users reasons to want -mthread-model single that other > architectures don't, even when -matomics is enabled by default. > > When shared memory is used, wasm requires modules to

[PATCH] D57112: [ASTTypeTraits] OMPClause handling

lebedev.ri added a comment. ping @klimek @hokein thanks. The fun of of the code that is so well separated that no one touches it for years and thus can't review patches for it :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57112/new/

[PATCH] D58724: [gnustep-objc] Make the GNUstep v2 ABI work for Windows DLLs.

DHowett-MSFT added inline comments. Comment at: clang/lib/CodeGen/CGObjCGNU.cpp:188 + StringRef SymbolPrefix() { +return CGM.getTriple().isOSBinFormatCOFF() ? "_" : "._"; theraven wrote: > DHowett-MSFT wrote: > > Should this be `SymbolPrefix()` or

[PATCH] D58742: [WebAssembly] Remove uses of ThreadModel

sunfish added a comment. Wasm gives users reasons to want -mthread-model single that other architectures don't, even when -matomics is enabled by default. When shared memory is used, wasm requires modules to declare a max memory size, which is a burden on applications that want to use dynamic

[PATCH] D58742: [WebAssembly] Remove uses of ThreadModel

sbc100 added a comment. In D58742#1413077 , @sunfish wrote: > This is still a little confusing to me. -matomic is supposed to be a > subtarget flag, stating that the wasm implementation we will run on supports > atomic instructions. -mthread-model posix

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

RKSimon added a comment. Ideally I think you need more clang/frontend experts reviewers - many of us on the reviewers list tend to work mainly in llvm. Test cases would be good as well - even if its just basic sanity tests for command line args etc. Comment at:

[PATCH] D58742: [WebAssembly] Remove uses of ThreadModel

This revision was automatically updated to reflect the committed changes. Closed by commit rLLD355112: [WebAssembly] Remove uses of ThreadModel (authored by tlively, committed by ). Changed prior to commit: https://reviews.llvm.org/D58742?vs=188634=188758#toc Repository: rLLD LLVM Linker

r355112 - [WebAssembly] Remove uses of ThreadModel

Author: tlively Date: Thu Feb 28 10:39:08 2019 New Revision: 355112 URL: http://llvm.org/viewvc/llvm-project?rev=355112=rev Log: [WebAssembly] Remove uses of ThreadModel Summary: In the clang UI, replaces -mthread-model posix with -matomics as the source of truth on threading. In the backend,

[PATCH] D58737: [InstrProf] Use separate comdat group for data and counters

vsk added a comment. In D58737#1412846 , @rnk wrote: > Oops, forgot to respond to this... > > In D58737#1412734 , @vsk wrote: > > > I'm confused by this wording re: comdats in the LangRef: "All global > > objects

[PATCH] D56924: Special case ObjCPropertyDecl for printing

dgoldman added a comment. friendly ping, think this is good to go now Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56924/new/ https://reviews.llvm.org/D56924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57087: [clang-tidy] add OverrideMacro to modernize-use-override check

JonasToth accepted this revision. JonasToth added a comment. LGTM Comment at: clang-tidy/modernize/UseOverrideCheck.cpp:196 + ReplacementText = " " + OverrideSpelling + " "; +} } else if (GetText(Tokens.back(), Sources) == "ABSTRACT") {

[PATCH] D58743: Handle built-in when importing SourceLocation and FileID

shafik updated this revision to Diff 188753. shafik marked 7 inline comments as done. shafik added a comment. Addressed comments on formatting and missing changes to the `Import_New` version of the code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58743/new/

[PATCH] D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions

JonasToth added a comment. In D58731#1413888 , @MyDeveloperDay wrote: > @JonasToth I left a comment in the commit needed to fix the index.rst, which > I don't think your later review fixes, sphinx complained about the rst file > being an unreferenced

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

riccibruno accepted this revision. riccibruno added a comment. This revision is now accepted and ready to land. Looks good, hopefully this time it will stick. thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57914/new/ https://reviews.llvm.org/D57914

[PATCH] D57087: [clang-tidy] add OverrideMacro to modernize-use-override check

MyDeveloperDay updated this revision to Diff 188752. MyDeveloperDay added a comment. rebase after D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions change as this was previous accepted I will land shortly, but I'd appreciate a quick

[clang-tools-extra] r355108 - [clang-tidy] fix documentation link in list of clang-tidy checks

Author: jonastoth Date: Thu Feb 28 09:53:51 2019 New Revision: 355108 URL: http://llvm.org/viewvc/llvm-project?rev=355108=rev Log: [clang-tidy] fix documentation link in list of clang-tidy checks Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/list.rst Modified:

[PATCH] D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions

MyDeveloperDay added a comment. @JonasToth I left a comment in the commit needed to fix the index.rst, which I don't think your later review fixes, sphinx complained about the rst file being an unreferenced octtree https://reviews.llvm.org/rG5fbeff797a9dba504f08f14c4fa59b6f1076fe72#inline-2691

[PATCH] D52150: [clang-format] BeforeHash added to IndentPPDirectives

MyDeveloperDay added a comment. While we wait for code review I've landed this currently unaccepted clang-format revision into https://github.com/mydeveloperday/clang-experimental/releases for those wishing to try/test or provide feedback CHANGES SINCE LAST ACTION

[PATCH] D58494: [ASTImporter] Handle redecl chain of FunctionTemplateDecls

martong added a comment. @shafik, Could you please take a look? I have run the LLDB tests on our macOS and I could not discover any regression. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58494/new/ https://reviews.llvm.org/D58494

[PATCH] D17741: adds __FILE_BASENAME__ builtin macro

kristina added a comment. If the author is still missing at the end of next week, any objections to me resubmitting a similar patch that just implements `__FILE_NAME__` or `__BASE_NAME__` (Need a few more opinions here I guess, personally I think `__FILE_NAME__` makes more sense)? I'll carve

[PATCH] D58346: [Sema] Change addr space diagnostics in casts to follow C++ style

rjmccall added a comment. Hmm. Yeah, Embedded C allows these casts, so contra my previous comment, I think we can't make them ill-formed outside of OpenCL mode. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58346/new/ https://reviews.llvm.org/D58346

[PATCH] D58502: [ASTImporter] Fix redecl failures of Class and ClassTemplate

martong added a comment. @shafik, Could you please take a look? I have run the LLDB tests on our macOS and I could not discover any regression. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58502/new/ https://reviews.llvm.org/D58502

r355106 - Partial revert of r353952: [HIP] Handle compile -m options and propagate into LLC

Author: yaxunl Date: Thu Feb 28 09:08:26 2019 New Revision: 355106 URL: http://llvm.org/viewvc/llvm-project?rev=355106=rev Log: Partial revert of r353952: [HIP] Handle compile -m options and propagate into LLC Remove comments and tests about passing -mcode-object-v3 to driver since it does not

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

tstellar updated this revision to Diff 188749. tstellar added a comment. Fix an issue with the generated arm headers that I discovered after doing some more testing. Also, remove comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58537/new/

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau marked 2 inline comments as done. pgousseau added inline comments. Comment at: include/clang/Basic/Sanitizers.h:29 +class hash_code; +} riccibruno wrote: > pgousseau wrote: > > riccibruno wrote: > > > What ? You are forward-declaring `hash_code` here

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau updated this revision to Diff 188748. pgousseau added a comment. Change `hash_value()` declaration's location as suggested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57914/new/ https://reviews.llvm.org/D57914 Files: include/clang/Basic/Attr.td

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

riccibruno added inline comments. Comment at: include/clang/Basic/Sanitizers.h:29 +class hash_code; +} pgousseau wrote: > riccibruno wrote: > > What ? You are forward-declaring `hash_code` here and using it as a value a > > few lines later. Just include

[PATCH] D58724: [gnustep-objc] Make the GNUstep v2 ABI work for Windows DLLs.

theraven marked 2 inline comments as done. theraven added inline comments. Comment at: clang/lib/CodeGen/CGObjCGNU.cpp:188 + StringRef SymbolPrefix() { +return CGM.getTriple().isOSBinFormatCOFF() ? "_" : "._"; DHowett-MSFT wrote: > Should this be

[clang-tools-extra] r355102 - [clang-tidy] redirection in list of checks adjusted

Author: jonastoth Date: Thu Feb 28 07:56:40 2019 New Revision: 355102 URL: http://llvm.org/viewvc/llvm-project?rev=355102=rev Log: [clang-tidy] redirection in list of checks adjusted Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/list.rst Modified:

[PATCH] D40988: Clang-format: add finer-grained options for putting all arguments on one line

russellmcc added a comment. Bump! Would really appreciate any feedback on this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D40988/new/ https://reviews.llvm.org/D40988 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau marked an inline comment as done. pgousseau added inline comments. Comment at: include/clang/Basic/Sanitizers.h:29 +class hash_code; +} riccibruno wrote: > What ? You are forward-declaring `hash_code` here and using it as a value a > few lines

[PATCH] D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range

russellmcc added a comment. Herald added a subscriber: jdoerfert. Bump! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54881/new/ https://reviews.llvm.org/D54881 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r355100 - [clang-tidy] include cppcoreguidelines-explicit-virtual-functions in list of checks and fix redirection

Author: jonastoth Date: Thu Feb 28 07:47:10 2019 New Revision: 355100 URL: http://llvm.org/viewvc/llvm-project?rev=355100=rev Log: [clang-tidy] include cppcoreguidelines-explicit-virtual-functions in list of checks and fix redirection Modified:

[clang-tools-extra] r355098 - [clang-tidy] documentation fixing the actual correct file

Author: jonastoth Date: Thu Feb 28 07:39:47 2019 New Revision: 355098 URL: http://llvm.org/viewvc/llvm-project?rev=355098=rev Log: [clang-tidy] documentation fixing the actual correct file Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/abseil-time-subtraction.rst Modified:

[clang-tools-extra] r355097 - [clang-tidy] tryfix documenation continued

Author: jonastoth Date: Thu Feb 28 07:28:36 2019 New Revision: 355097 URL: http://llvm.org/viewvc/llvm-project?rev=355097=rev Log: [clang-tidy] tryfix documenation continued Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/abseil-duration-subtraction.rst Modified:

[PATCH] D57906: [CTU] Do not allow different CPP dialects in CTU

This revision was automatically updated to reflect the committed changes. martong marked an inline comment as done. Closed by commit rC355096: [CTU] Do not allow different CPP dialects in CTU (authored by martong, committed by ). Changed prior to commit:

r355096 - [CTU] Do not allow different CPP dialects in CTU

Author: martong Date: Thu Feb 28 07:24:59 2019 New Revision: 355096 URL: http://llvm.org/viewvc/llvm-project?rev=355096=rev Log: [CTU] Do not allow different CPP dialects in CTU Summary: If CPP dialects are different then return with error. Consider this STL code: template struct

[PATCH] D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions

JonasToth added a comment. Thank you for the patch! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58731/new/ https://reviews.llvm.org/D58731 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r355095 - [clang-tidy] another issue in documentation, double empty line seemed to confuse code-block

Author: jonastoth Date: Thu Feb 28 07:18:54 2019 New Revision: 355095 URL: http://llvm.org/viewvc/llvm-project?rev=355095=rev Log: [clang-tidy] another issue in documentation, double empty line seemed to confuse code-block Modified:

[PATCH] D57906: [CTU] Do not allow different CPP dialects in CTU

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM! I think we should commit this as is for now but maybe adding a TODO comment to summarize the problem would be nice. Maybe we could have an isSameDialect or similar method within

[clang-tools-extra] r355094 - [clang-tidy] attempt to fix documentation build-error

Author: jonastoth Date: Thu Feb 28 07:01:17 2019 New Revision: 355094 URL: http://llvm.org/viewvc/llvm-project?rev=355094=rev Log: [clang-tidy] attempt to fix documentation build-error Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/abseil-time-subtraction.rst Modified:

[PATCH] D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL355093: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions (authored by JonasToth, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[clang-tools-extra] r355093 - [clang-tidy] added cppcoreguidelines-explicit-virtual-functions

Author: jonastoth Date: Thu Feb 28 06:55:12 2019 New Revision: 355093 URL: http://llvm.org/viewvc/llvm-project?rev=355093=rev Log: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions Addresses the bugzilla bug #30397. (https://bugs.llvm.org/show_bug.cgi?id=30397)

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

riccibruno requested changes to this revision. riccibruno added inline comments. This revision now requires changes to proceed. Comment at: include/clang/Basic/Sanitizers.h:29 +class hash_code; +} What ? You are forward-declaring `hash_code` here and using it

[PATCH] D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions

MyDeveloperDay added a comment. In D58731#1413695 , @alexfh wrote: > In D58731#1413552 , @JonasToth wrote: > > > In D58731#1413498 , > > @MyDeveloperDay wrote: > > > > > In

[PATCH] D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions

alexfh added a comment. In D58731#1413552 , @JonasToth wrote: > In D58731#1413498 , @MyDeveloperDay > wrote: > > > In D58731#1413476 , @lewmpk wrote: > > > > > I'm happy to

[PATCH] D58743: Handle built-in when importing SourceLocation and FileID

balazske added inline comments. Comment at: include/clang/AST/ASTImporter.h:342 // FIXME: Remove this version. -FileID Import(FileID); +FileID Import(FileID, bool isBuiltin=false); teemperor wrote: > `IsBuiltin`, not `isBuiltin` `IsBuiltin =

[PATCH] D58781: Added missing license headers

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE355092: Added missing license headers (authored by gribozavr, committed by ). Changed prior to commit: https://reviews.llvm.org/D58781?vs=188726=188731#toc Repository: rCTE Clang Tools Extra

[clang-tools-extra] r355092 - Added missing license headers

Author: gribozavr Date: Thu Feb 28 06:01:11 2019 New Revision: 355092 URL: http://llvm.org/viewvc/llvm-project?rev=355092=rev Log: Added missing license headers Reviewers: ioeric Subscribers: jkorous, arphaman, kadircet, cfe-commits Tags: #clang Differential Revision:

[PATCH] D58782: Use ArrayRef::copy, instead of copying data manually

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE355091: Use ArrayRef::copy, instead of copying data manually (authored by gribozavr, committed by ). Changed prior to commit: https://reviews.llvm.org/D58782?vs=188729=188730#toc Repository: rCTE

[PATCH] D58782: Use ArrayRef::copy, instead of copying data manually

lebedev.ri added a comment. Would it please be possible to write actual commit / DR titles, i.e. include appropriate `[tag]`s into them, and ideally proper commit messages, too? It really clutters -commit list listing otherwise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] r355091 - Use ArrayRef::copy, instead of copying data manually

Author: gribozavr Date: Thu Feb 28 06:00:26 2019 New Revision: 355091 URL: http://llvm.org/viewvc/llvm-project?rev=355091=rev Log: Use ArrayRef::copy, instead of copying data manually Reviewers: ioeric Subscribers: jkorous, arphaman, kadircet, cfe-commits Tags: #clang Differential Revision:

[PATCH] D58782: Use ArrayRef::copy, instead of copying data manually

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58782/new/ https://reviews.llvm.org/D58782

[PATCH] D58781: Added missing license headers

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. lg. thanks!!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58781/new/ https://reviews.llvm.org/D58781

[PATCH] D58782: Use ArrayRef::copy, instead of copying data manually

gribozavr created this revision. gribozavr added a reviewer: ioeric. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58782 Files: clang-tools-extra/clangd/index/Ref.cpp Index:

[PATCH] D58778: Moved Ref into its own header and implementation file

This revision was automatically updated to reflect the committed changes. gribozavr marked an inline comment as done. Closed by commit rL355090: Moved Ref into its own header and implementation file (authored by gribozavr, committed by ). Herald added subscribers: llvm-commits, ilya-biryukov.

[PATCH] D58781: Added missing license headers

gribozavr created this revision. gribozavr added a reviewer: ioeric. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58781 Files: clang-tools-extra/clangd/ExpectedTypes.cpp

[clang-tools-extra] r355090 - Moved Ref into its own header and implementation file

Author: gribozavr Date: Thu Feb 28 05:49:25 2019 New Revision: 355090 URL: http://llvm.org/viewvc/llvm-project?rev=355090=rev Log: Moved Ref into its own header and implementation file Reviewers: ioeric Subscribers: mgorny, jkorous, mgrang, arphaman, kadircet, cfe-commits Tags: #clang

[PATCH] D58778: Moved Ref into its own header and implementation file

gribozavr marked 2 inline comments as done. gribozavr added inline comments. Comment at: clang-tools-extra/clangd/index/Ref.cpp:1 +#include "Ref.h" + ioeric wrote: > License? Added. Comment at:

[PATCH] D58778: Moved Ref into its own header and implementation file

gribozavr updated this revision to Diff 188724. gribozavr marked 2 inline comments as done. gribozavr added a comment. Added a missing include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58778/new/ https://reviews.llvm.org/D58778 Files:

[PATCH] D58609: [clang-tidy] bugprone-string-integer-assignment: Reduce false positives.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE355089: [clang-tidy] bugprone-string-integer-assignment: Reduce false positives. (authored by courbet, committed by ). Changed prior to commit: https://reviews.llvm.org/D58609?vs=188690=188722#toc

[PATCH] D58609: [clang-tidy] bugprone-string-integer-assignment: Reduce false positives.

courbet added a comment. Thanks. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58609/new/ https://reviews.llvm.org/D58609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   >