[PATCH] D58797: [Sema] Add some compile time _FORTIFY_SOURCE diagnostics

nickdesaulniers added a comment. This is causing false positive warnings for the Linux kernel: https://github.com/ClangBuiltLinux/linux/issues/423 :( https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/fs/statfs.c#n128 Consider this untested case: if (sizeof(buf) == s

[PATCH] D42034: [clang-format] In tests, expected code should be format-stable

mzeren-vmw added inline comments. Comment at: cfe/trunk/unittests/Format/FormatTest.cpp:78 EXPECT_EQ(Expected.str(), format(Code, Style)); if (Style.Language == FormatStyle::LK_Cpp) { // Objective-C++ is a superset of C++, so everything checked for C++ --

[PATCH] D59377: Frontend: Remove CompilerInstance::VirtualFileSystem, NFC

jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59377/new/ https://reviews.llvm.org/D59377 ___ cfe-commits mailing list cfe-commits

[PATCH] D47358: : Implement {un,}synchronized_pool_resource.

Quuxplusone updated this revision to Diff 191815. Quuxplusone added a comment. Herald added a subscriber: jdoerfert. Rebased. Added `_NOEXCEPT` to `upstream_resource()` and `options()` (this is OK per [res.on.exception.handling]/5). Repository: rCXX libc++ CHANGES SINCE LAST ACTION https:/

[PATCH] D59407: [clangd] Add RelationSlab

nridge marked 8 inline comments as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/index/Index.h:43 +public: + using value_type = std::pair>; + using const_iterator = std::vector::const_iterator; kadircet wrote: > nridge wrote: > > kadi

[PATCH] D47111: : Implement monotonic_buffer_resource.

Quuxplusone updated this revision to Diff 191814. Quuxplusone added a comment. Herald added a subscriber: jdoerfert. Rebased on master. Added `_NOEXCEPT` to the `resource()` method (this is OK per [res.on.exception.handling]/5). @ckennelly ping! Repository: rCXX libc++ CHANGES SINCE LAST AC

[PATCH] D40988: Clang-format: add finer-grained options for putting all arguments on one line

russellmcc added a comment. Yes, I don’t have commit access and would need someone else to land the patch. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D40988/new/ https://reviews.llvm.org/D40988 ___ cfe-commits mailing list cfe-c

[PATCH] D59665: Call to HandleNameConflict in VisitEnumDecl mistakeningly using Name instead of SearchName

a_sidorin added a subscriber: davide. a_sidorin added a comment. Hi Shafik, Honestly, I was always wondering what does HandleNameConflict actually do. Its implementation in ASTImporter is trivial and I don't see any of its overrides in LLDB code too. Why do we check its result to be non-empty i

[PATCH] D59673: [Driver] Allow setting the DWO name DWARF attribute separately

aaronpuchert updated this revision to Diff 191813. aaronpuchert added a comment. Use llvm-dwarfdump to inspect debug info, remove unneeded flags. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59673/new/ https://reviews.llvm.org/D59673 Files: include/clang/Basi

[PATCH] D59673: [Driver] Allow setting the DWO name DWARF attribute separately

aaronpuchert added a comment. In D59673#1438716 , @dblaikie wrote: > Use llvm-dwarfdump rather than llvm-objdump to dump the contents of the > debug_info section and test the dwo_name there (rather than dumping hex) I didn't know about llvm-dwarfdump, I

[PATCH] D59631: [AArch64] Support selecting TPIDR_EL[1-3] as the thread base

philip.derrin updated this revision to Diff 191800. philip.derrin edited the summary of this revision. philip.derrin added a comment. Merged -mtpidr= with existing AArch32 option -mtp= CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59631/new/ https://reviews.llvm.org/D59631 Files: cla

[PATCH] D59631: [AArch64] Support selecting TPIDR_EL[1-3] as the thread base

philip.derrin removed a reviewer: olista01. philip.derrin added a comment. In D59631#1437744 , @olista01 wrote: > Is there an existing compiler which this option is trying to be compatible > with? GCC for AArch64 doesn't currently have an option for this,

r356724 - This test assumes that -rtlib defaults to libgcc. But that isn't true in the face of -DCLANG_DEFAULT_RTLIB=compiler-rt.

Author: saugustine Date: Thu Mar 21 16:30:50 2019 New Revision: 356724 URL: http://llvm.org/viewvc/llvm-project?rev=356724&view=rev Log: This test assumes that -rtlib defaults to libgcc. But that isn't true in the face of -DCLANG_DEFAULT_RTLIB=compiler-rt. Subscribers: dberris, jdoerfert, llvm-c

[PATCH] D40988: Clang-format: add finer-grained options for putting all arguments on one line

jkorous added a comment. @russellmcc the patch has been approved by @MyDeveloperDay https://reviews.llvm.org/D40988#1430502 Do you mean you don't have commit access and need someone to land the patch on your behalf? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D40988/new/ https://revi

[PATCH] D57965: Clean up ObjCPropertyDecl printing

jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. LGTM. Thanks for working on this! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57965/new/ https://reviews.llvm.org/D57965 ___

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous marked an inline comment as done. jkorous added a comment. In D58418#1431765 , @thakis wrote: > In D58418#1431399 , @jkorous wrote: > > > In D58418#1430630 , @thakis

[PATCH] D59629: [clang-format] correctly format protobuf fields named "enum".

dchai added a comment. I don't have commit access; can someone please merge this on my behalf? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59629/new/ https://reviews.llvm.org/D59629 ___ cfe-commits mailing list cfe

[PATCH] D59655: [AArch64] Split the neon.addp intrinsic into integer and fp variants

This revision was automatically updated to reflect the committed changes. Closed by commit rL356722: [AArch64] Split the neon.addp intrinsic into integer and fp variants. (authored by aemerson, committed by ). Changed prior to commit: https://reviews.llvm.org/D59655?vs=191774&id=191792#toc Rep

r356722 - [AArch64] Split the neon.addp intrinsic into integer and fp variants.

Author: aemerson Date: Thu Mar 21 15:31:37 2019 New Revision: 356722 URL: http://llvm.org/viewvc/llvm-project?rev=356722&view=rev Log: [AArch64] Split the neon.addp intrinsic into integer and fp variants. This is the result of discussions on the list about how to deal with intrinsics which requir

[PATCH] D59673: [Driver] Allow setting the DWO name DWARF attribute separately

dblaikie added a comment. Pleasue include mention of the bug (PR40276) in the commit message & clarify that while this is useful for some remote compilation models, it's not strictly necessary/the only way to do it (a remote compilation model that keeps relative paths and uses compilation-dir i

[PATCH] D59673: [Driver] Allow setting the DWO name DWARF attribute separately

aaronpuchert created this revision. aaronpuchert added reviewers: dblaikie, echristo. Herald added subscribers: cfe-commits, jdoerfert, aprantl. Herald added a project: clang. With Split DWARF the resulting object file (then called skeleton CU) contains the file name of another ("DWO") file with t

[PATCH] D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range

russellmcc added a comment. Sorry for the ambiguity. I meant, "running clang-format on the changed lines locally was not enough". I'll edit the description to clarify. To go in more detail, let's imagine you changed line 3. You run clang-format locally on line 3, but because of the bug fixed

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

riccibruno added a comment. Friendly ping. One thing I am wondering about is whether `MemoryLocation` and `getMemoryLocation` is duplicating something that is already present somewhere else. It feels like something similar should already exist but I can't find anything (but that is not saying m

[PATCH] D40988: Clang-format: add finer-grained options for putting all arguments on one line

russellmcc added a comment. Ping! Still looking for help on this - I definitely don't want to diminish the complexity of this code, and would really appreciate any help getting this in. I've already apologized for the gap from feedback in July 2018 to response in October - and I'm happy to ag

[PATCH] D59650: [NFC] ExceptionEscapeCheck: small refactoring

JonasToth added inline comments. Comment at: clang-tidy/utils/ExceptionAnalyzer.cpp:226 +ExceptionAnalyzer::ExceptionInfo +ExceptionAnalyzer::analyzeBoilerplate(const T *Node) { + ExceptionInfo ExceptionList; lebedev.ri wrote: > Please bikeshed on the name. I do

[PATCH] D59650: [NFC] ExceptionEscapeCheck: small refactoring

lebedev.ri marked an inline comment as done. lebedev.ri added inline comments. Comment at: clang-tidy/utils/ExceptionAnalyzer.cpp:226 +ExceptionAnalyzer::ExceptionInfo +ExceptionAnalyzer::analyzeBoilerplate(const T *Node) { + ExceptionInfo ExceptionList; Please

[PATCH] D59650: [NFC] ExceptionEscapeCheck: small refactoring

lebedev.ri updated this revision to Diff 191782. lebedev.ri added a comment. Keep templated function out of the public interface. In D59650#1438603 , @JonasToth wrote: > > Looks like pointless code duplication that is easily avoidable. > > True, but I wou

[PATCH] D59466: [clang-tidy] openmp-exception-escape - a new check

lebedev.ri updated this revision to Diff 191783. lebedev.ri added a comment. Rebased for D59650 changes, NFC. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59466/new/ https://reviews.llvm.org/D59466 Files: clang-

[PATCH] D59670: [Sema] Fix an assert when a block captures a constexpr local

erik.pilkington created this revision. erik.pilkington added reviewers: rjmccall, rsmith. Herald added subscribers: dexonsmith, jkorous. Herald added a project: clang. `MarkVarDeclODRUsed` indirectly calls `captureInBlock`, which creates a copy expression. The copy expression is insulated in it's

[PATCH] D59650: [NFC] ExceptionEscapeCheck: small refactoring

JonasToth added a comment. > Looks like pointless code duplication that is easily avoidable. True, but I would prefer the refactoring to be private then (so the template stuff with the boilerplate) and a simple overloading interface dispatching to the templated stuff. In the end I think the pub

[PATCH] D59665: Call to HandleNameConflict in VisitEnumDecl mistakeningly using Name instead of SearchName

shafik added a comment. I was not able to come up with a test that would detect this issue using either `clang-import-test` nor via any of the methods used in `ASTImpoterTest.cpp`. I created a regression test on the lldb side, which should pass once this is committed: https://reviews.llvm.org/

[PATCH] D59655: [AArch64] Split the neon.addp intrinsic into integer and fp variants

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59655/new/ https://reviews.llvm.org/D59655 ___

[PATCH] D59665: Call to HandleNameConflict in VisitEnumDecl mistakeningly using Name instead of SearchName

shafik created this revision. shafik added reviewers: teemperor, martong, a_sidorin. Herald added a subscriber: rnkovacs. https://reviews.llvm.org/D51633 added error handling to the `ASTNodeImporter::VisitEnumDecl(...)` for the conflicting names case. This could lead to erroneous return of an er

r356715 - [OPENMP]Fix a warning about unused variable, NFC.

Author: abataev Date: Thu Mar 21 13:52:04 2019 New Revision: 356715 URL: http://llvm.org/viewvc/llvm-project?rev=356715&view=rev Log: [OPENMP]Fix a warning about unused variable, NFC. Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntimeNVPT

[PATCH] D59655: [AArch64] Split the neon.addp intrinsic into integer and fp variants

aemerson updated this revision to Diff 191774. aemerson added a comment. Simplify logic and don't try to upgrade if IR is invalid. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59655/new/ https://reviews.llvm.org/D59655 Files: clang/lib/CodeGen/

r356712 - Improve the diagnostic for #include_next occurring in a file not found

Author: rsmith Date: Thu Mar 21 13:42:13 2019 New Revision: 356712 URL: http://llvm.org/viewvc/llvm-project?rev=356712&view=rev Log: Improve the diagnostic for #include_next occurring in a file not found in the include path. Instead of making the incorrect claim that the included file has an abso

[PATCH] D59650: [NFC] ExceptionEscapeCheck: small refactoring

lebedev.ri added a comment. In D59650#1438515 , @JonasToth wrote: > Why not having normal overloads? The analysis for `Stmt` is implemented with > the private methods. Explicit template specialization is a bit overkill and > so easily understood (but not

[PATCH] D59566: [X86] Correct the value of MaxAtomicInlineWidth for pre-586 cpus

This revision was automatically updated to reflect the committed changes. Closed by commit rL356709: [X86] Correct the value of MaxAtomicInlineWidth for pre-586 cpus (authored by ctopper, committed by ). Herald added a project: LLVM. Changed prior to commit: https://reviews.llvm.org/D59566?vs=1

r356710 - [OPENMP] Simplify codegen for allocate directive on local variables.

Author: abataev Date: Thu Mar 21 13:36:16 2019 New Revision: 356710 URL: http://llvm.org/viewvc/llvm-project?rev=356710&view=rev Log: [OPENMP] Simplify codegen for allocate directive on local variables. Simplified codegen for the allocate directive for local variables, initial implementation of t

r356709 - [X86] Correct the value of MaxAtomicInlineWidth for pre-586 cpus

Author: ctopper Date: Thu Mar 21 13:36:08 2019 New Revision: 356709 URL: http://llvm.org/viewvc/llvm-project?rev=356709&view=rev Log: [X86] Correct the value of MaxAtomicInlineWidth for pre-586 cpus Use the new cx8 feature flag that was added to the backend to represent support for cmpxchg8b. Us

[libunwind] r356708 - Bump version to 8.0.1

Author: tstellar Date: Thu Mar 21 13:32:00 2019 New Revision: 356708 URL: http://llvm.org/viewvc/llvm-project?rev=356708&view=rev Log: Bump version to 8.0.1 Modified: libunwind/branches/release_80/CMakeLists.txt Modified: libunwind/branches/release_80/CMakeLists.txt URL: http://llvm.org/vie

[PATCH] D59650: [NFC] ExceptionEscapeCheck: small refactoring

JonasToth added a comment. Why not having normal overloads? The analysis for `Stmt` is implemented with the private methods. Explicit template specialization is a bit overkill and so easily understood (but not too complex in this case either).l Repository: rCTE Clang Tools Extra CHANGES SIN

[PATCH] D59279: [Analyzer] Checker for non-determinism caused by iteration of unordered container of pointers

mgrang added a comment. In D59279#1438500 , @rnkovacs wrote: > In D59279#1427017 , @mgrang wrote: > > > Following are the assumptions/limitations of this patch: > > > > 1. The assumption is that iteration of order

[PATCH] D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.

teemperor updated this revision to Diff 191765. teemperor retitled this revision from "[ASTImporter] Allow adding a import strategy to the ASTImporter" to "[ASTImporter] Add an ImportInternal method to allow customizing Import behavior.". teemperor edited the summary of this revision. teemperor a

[PATCH] D59655: [AArch64] Split the neon.addp intrinsic into integer and fp variants

efriedma added a comment. The IR at this Comment at: llvm/lib/IR/AutoUpgrade.cpp:574 + if (ArgTy->getElementType()->isFloatingPointTy()) { +auto fArgs = F->getFunctionType()->params(); +Type *Tys[] = {fArgs[0], fArgs[1]}; aemerson wrote: >

[PATCH] D59523: Thread Safety: also look at ObjC methods

aaronpuchert added inline comments. Comment at: lib/Analysis/ThreadSafetyCommon.cpp:283-285 + if (isa(D) + ? (cast(D)->getCanonicalDecl() == Canonical) + : (cast(D)->getCanonicalDecl() == Canonical)) { aaron.ballman wrote: > Also so

Re: r356222 - [analyzer] Support C++17 aggregates with bases without constructors.

This one seems to be fixed by the second patch and is looks similar to the testcase that's already there - https://reviews.llvm.org/D59622 Different backtraces are moderately expected :) On 3/21/19 6:58 AM, Alexander Kornienko wrote: Thanks for the fix! Meanwhile, I found a couple of code sampl

[PATCH] D59279: [Analyzer] Checker for non-determinism caused by iteration of unordered container of pointers

rnkovacs added a comment. In D59279#1427017 , @mgrang wrote: > Following are the assumptions/limitations of this patch: > > 1. The assumption is that iteration of ordered containers of pointers is > not non-deterministic. > Could you please explain wh

[PATCH] D35068: [analyzer] Detect usages of unsafe I/O functions

NoQ added a comment. Herald added a subscriber: Charusso. There seems to be a crash in this code. @koldaniel, would you like to take a look? https://bugs.llvm.org/show_bug.cgi?id=41185 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D35068/new/ https://reviews.llvm.

[PATCH] D59624: [Driver] Pass -malign-double from the driver to the cc1 command line

This revision was automatically updated to reflect the committed changes. Closed by commit rL356706: [Driver] Pass -malign-double from the driver to the cc1 command line (authored by ctopper, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to c

r356706 - [Driver] Pass -malign-double from the driver to the cc1 command line

Author: ctopper Date: Thu Mar 21 13:07:24 2019 New Revision: 356706 URL: http://llvm.org/viewvc/llvm-project?rev=356706&view=rev Log: [Driver] Pass -malign-double from the driver to the cc1 command line -malign-double is currently only implemented in the -cc1 interface. But its declared in Optio

[PATCH] D59656: [CodeGen][ObjC] Annotate calls to objc_retainAutoreleasedReturnValue with notail on x86-64

This revision was automatically updated to reflect the committed changes. Closed by commit rL356705: [CodeGen][ObjC] Annotate calls to objc_retainAutoreleasedReturnValue (authored by ahatanak, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D59655: [AArch64] Split the neon.addp intrinsic into integer and fp variants

aemerson marked an inline comment as done. aemerson added inline comments. Comment at: llvm/lib/IR/AutoUpgrade.cpp:574 + if (ArgTy->getElementType()->isFloatingPointTy()) { +auto fArgs = F->getFunctionType()->params(); +Type *Tys[] = {fArgs[0], fArgs[1]}; ---

r356705 - [CodeGen][ObjC] Annotate calls to objc_retainAutoreleasedReturnValue

Author: ahatanak Date: Thu Mar 21 12:59:49 2019 New Revision: 356705 URL: http://llvm.org/viewvc/llvm-project?rev=356705&view=rev Log: [CodeGen][ObjC] Annotate calls to objc_retainAutoreleasedReturnValue with notail on x86-64. On x86-64, the epilogue code inserted before the tail jump blocks the

[PATCH] D59076: [coroutines][PR40978] Emit error for co_yield within catch block

riccibruno added a comment. This is causing https://bugs.llvm.org/show_bug.cgi?id=41171. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59076/new/ https://reviews.llvm.org/D59076 ___ cfe-commits mailing list cfe-commi

r356704 - Refactor handling of #include directives to cleanly separate the

Author: rsmith Date: Thu Mar 21 12:44:17 2019 New Revision: 356704 URL: http://llvm.org/viewvc/llvm-project?rev=356704&view=rev Log: Refactor handling of #include directives to cleanly separate the "skipped header because it should be imported as a module" cases from the "skipped header because of

[PATCH] D59656: [CodeGen][ObjC] Annotate calls to objc_retainAutoreleasedReturnValue with notail on x86-64

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59656/new/ https://reviews.llvm.org/D59656 ___ cfe-commi

r356702 - [OPENMP]Codegen support for allocate directive on global variables.

Author: abataev Date: Thu Mar 21 12:35:27 2019 New Revision: 356702 URL: http://llvm.org/viewvc/llvm-project?rev=356702&view=rev Log: [OPENMP]Codegen support for allocate directive on global variables. For the global variables the allocate directive must specify only the predefined allocator. Thi

[PATCH] D59566: [X86] Correct the value of MaxAtomicInlineWidth for pre-586 cpus

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM > This is needed to get the LLONG_LOCK_FREE macro to be 2 on i586 and greater. Not sure these tests are really valuable, given we plan to change that immediately after this is merged

Re: r356700 - [clang][OpenMP] Fix another test when using libgomp.

Thank you for the fix. I remembered of the yesterday's fix, but either forgot about it here, or incorrectly recalled this code would be relying on the yesterday's code (as in, no fix would be needed.) Roman. On Thu, Mar 21, 2019 at 10:11 PM Jordan Rupprecht via cfe-commits wrote: > > Author: ru

[PATCH] D59655: [AArch64] Split the neon.addp intrinsic into integer and fp variants

efriedma added inline comments. Comment at: llvm/lib/IR/AutoUpgrade.cpp:574 + if (ArgTy->getElementType()->isFloatingPointTy()) { +auto fArgs = F->getFunctionType()->params(); +Type *Tys[] = {fArgs[0], fArgs[1]}; This code is weird... you're

[PATCH] D59656: [CodeGen][ObjC] Annotate calls to objc_retainAutoreleasedReturnValue with notail on x86-64

ahatanak updated this revision to Diff 191761. ahatanak marked an inline comment as done. ahatanak added a comment. Rename function. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59656/new/ https://reviews.llvm.org/D59656 Files: lib/CodeGen/CGObjC.cpp lib/Co

r356700 - [clang][OpenMP] Fix another test when using libgomp.

Author: rupprecht Date: Thu Mar 21 12:13:22 2019 New Revision: 356700 URL: http://llvm.org/viewvc/llvm-project?rev=356700&view=rev Log: [clang][OpenMP] Fix another test when using libgomp. Similarly to r356614, -fopenmp=libomp needs to be used for some omp-related AST matching. Modified: cf

r356699 - [OPENMP]Simplify the check for the predefined allocators, NFC.

Author: abataev Date: Thu Mar 21 12:05:07 2019 New Revision: 356699 URL: http://llvm.org/viewvc/llvm-project?rev=356699&view=rev Log: [OPENMP]Simplify the check for the predefined allocators, NFC. Previously implemented check required the reevaluation of the already evaluated predefined allocator

[PATCH] D59656: [CodeGen][ObjC] Annotate calls to objc_retainAutoreleasedReturnValue with notail on x86-64

rjmccall added inline comments. Comment at: lib/CodeGen/TargetInfo.h:161 + /// marked as 'notail'. + virtual bool noTailCallARCRetainRV() const { +return false; `shouldSuppressTailCallsOfRetainAutoreleasedReturnValue()`? Repository: rC Clang CHANGES SI

[PATCH] D59655: [AArch64] Split the neon.addp intrinsic into integer and fp variants

aemerson added a comment. I've put up a langref change as a separate review: D59657 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59655/new/ https://reviews.llvm.org/D59655 _

[PATCH] D59647: [CUDA][HIP] Warn shared var initialization

jlebar added a comment. > By default it is still treated as error, therefore no behavior change of > clang. Oh, I see, you already did what I'd suggested. :) That's better. I think this needs to be made *much scarier* though. "Maybe race condition" doesn't capture the danger here -- you can

[PATCH] D59647: [CUDA][HIP] Warn shared var initialization

jlebar requested changes to this revision. jlebar added a comment. This revision now requires changes to proceed. I agree with Art. The fact that nvcc allows this is broken. If you want a flag that makes this error a warning, that might work for me. The flag should probably say "unsafe" or "I

[PATCH] D59647: [CUDA][HIP] Warn shared var initialization

tra added a comment. This looks like one of the things we should *not* do as it affects correctness -- non-trivial constructor may be arbitrarily complex and the per-TU flag to enable this behavior is way too coarse, IMO. On the other hand, I can believe that someone somewhere did write the code

[PATCH] D59656: [CodeGen][ObjC] Annotate calls to objc_retainAutoreleasedReturnValue with notail on x86-64

ahatanak added a comment. There are existing test cases that test notail isn't added to calls on targets that aren't x86-64 (for example, test/CodeGenObjC/arc-arm.m), so I didn't write a new one. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59656/new/ https://

[PATCH] D59656: [CodeGen][ObjC] Annotate calls to objc_retainAutoreleasedReturnValue with notail on x86-64

ahatanak created this revision. ahatanak added reviewers: rjmccall, erik.pilkington. ahatanak added a project: clang. Herald added subscribers: dexonsmith, jkorous. On x86-64, the epilogue code inserted before the tail jump blocks the autoreleased return optimization. ARC optimizer unconditional

[PATCH] D59603: [PR40707][PR41011][OpenCL] Allow addr space spelling without double underscore in C++ mode

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59603/new/ https://reviews.llvm.org/D59603 ___ cfe-commits mailing list cfe-comm

[PATCH] D59655: [AArch64] Split the neon.addp intrinsic into integer and fp variants

aemerson updated this revision to Diff 191745. aemerson added a comment. Minor test tweak. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59655/new/ https://reviews.llvm.org/D59655 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/aarch

[PATCH] D59624: [Driver] Pass -malign-double from the driver to the cc1 command line

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59624/new/ https://reviews.llvm.org/D59624 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D59655: [AArch64] Split the neon.addp intrinsic into integer and fp variants

aemerson created this revision. aemerson added reviewers: paquette, eli.friedman, t.p.northover. aemerson added projects: LLVM, clang. Herald added subscribers: Petar.Avramovic, hiraditya, kristof.beyls, javed.absar. This is the result of discussions on the list about how to deal with intrinsics

[PATCH] D59639: [clangd] Print template arguments helper

ioeric added inline comments. Comment at: clang/lib/AST/TypePrinter.cpp:1640 + +static void printArgument(const TemplateArgumentLoc &A, + const PrintingPolicy &PP, llvm::raw_ostream &OS) { It's unclear to me what the new behavior is with

[PATCH] D59567: [X86] Add __popcntd and __popcntq to ia32intrin.h to match gcc and icc. Remove popcnt feature flag from _popcnt32/_popcnt64 and move to ia32intrin.h to match gcc

This revision was automatically updated to reflect the committed changes. Closed by commit rC356689: [X86] Add __popcntd and __popcntq to ia32intrin.h to match gcc and icc. Remove… (authored by ctopper, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm

[PATCH] D59640: [clangd] Add TemplateArgumentList into Symbol

ioeric added a comment. should we update YAML? Comment at: clang-tools-extra/clangd/index/Symbol.h:48 + /// non-specializations. Example: "" + llvm::StringRef TemplateArgumentList; /// The location of the symbol's definition, if one was found. How about `

r356689 - [X86] Add __popcntd and __popcntq to ia32intrin.h to match gcc and icc. Remove popcnt feature flag from _popcnt32/_popcnt64 and move to ia32intrin.h to match gcc

Author: ctopper Date: Thu Mar 21 10:43:53 2019 New Revision: 356689 URL: http://llvm.org/viewvc/llvm-project?rev=356689&view=rev Log: [X86] Add __popcntd and __popcntq to ia32intrin.h to match gcc and icc. Remove popcnt feature flag from _popcnt32/_popcnt64 and move to ia32intrin.h to match gcc

[PATCH] D59639: [clangd] Print template arguments helper

ioeric added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:88 static const TemplateArgumentList * getTemplateSpecializationArgs(const NamedDecl &ND) { if (auto *Func = llvm::dyn_cast(&ND)) can we unify this with `getTemplateSpecializationArgL

[PATCH] D57464: Generalize method overloading on addr spaces to C++

Anastasia added a comment. > I think I would lean towards the latter since it means less fudging around > with a whole bunch of unrelated methods. Do @rjmccall or @rsmith have any > further opinions on this? Ok, I can change the patch to prototype this approach. I might need some example tes

r356686 - [X86] Use the CPUKind enum from PROC_ALIAS to directly get the CPUKind in fillValidCPUList.

Author: ctopper Date: Thu Mar 21 10:33:20 2019 New Revision: 356686 URL: http://llvm.org/viewvc/llvm-project?rev=356686&view=rev Log: [X86] Use the CPUKind enum from PROC_ALIAS to directly get the CPUKind in fillValidCPUList. We were using getCPUKind which translates the string to the enum also

[PATCH] D58236: Make address space conversions a bit stricter.

Anastasia added a comment. In D58236#1437690 , @ebevhan wrote: > Any more input on this? > > I could redo the patch to simply fix the bug and not make the conversions > stricter, if that's preferable. I was playing a bit with some examples of enum with

[PATCH] D59627: [clang-format] Keep protobuf "package" statement on one line

dchai updated this revision to Diff 191734. dchai added a comment. Use "isOneOf" instead of two calls to "is". Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59627/new/ https://reviews.llvm.org/D59627 Files: lib/Format/TokenAnnotator.cpp unittests/Format/Form

[PATCH] D59466: [clang-tidy] openmp-exception-escape - a new check

lebedev.ri updated this revision to Diff 191727. lebedev.ri added a reviewer: gribozavr. lebedev.ri added a comment. Rebased, NFC. Split base ExceptionEscapeCheck refactoring into D59650 . Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https:/

[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new check

lebedev.ri updated this revision to Diff 191726. lebedev.ri marked 4 inline comments as done. lebedev.ri edited the summary of this revision. lebedev.ri added a reviewer: gribozavr. lebedev.ri added a comment. Rebased, NFC. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https:

[PATCH] D57571: [clang-tidy] A new OpenMP module

lebedev.ri updated this revision to Diff 191724. lebedev.ri added a comment. Rebased, NFC. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57571/new/ https://reviews.llvm.org/D57571 Files: clang-tidy/CMakeLists.txt clang-tidy/ClangTidyForceLinker

[PATCH] D59650: [NFC] ExceptionEscapeCheck: small refactoring

lebedev.ri created this revision. lebedev.ri added reviewers: baloghadamsoftware, JonasToth, gribozavr. lebedev.ri added a project: clang-tools-extra. Herald added a subscriber: rnkovacs. Herald added a project: clang. D59466 wants to analyse the `Stmt`, and `Exc

[PATCH] D59440: add steps to preprocess file and reduce command line args

akhuang added a comment. @arichardson Will add you next time, sorry I didn't do so on this one! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59440/new/ https://reviews.llvm.org/D59440 ___ cfe-commits mailing list cf

r356679 - [AST] OMPStructuredBlockTest: two matchers were promoted into ASTMatchers.h

Author: lebedevri Date: Thu Mar 21 08:50:54 2019 New Revision: 356679 URL: http://llvm.org/viewvc/llvm-project?rev=356679&view=rev Log: [AST] OMPStructuredBlockTest: two matchers were promoted into ASTMatchers.h Modified: cfe/trunk/unittests/AST/OMPStructuredBlockTest.cpp Modified: cfe/trunk

[PATCH] D59647: [CUDA][HIP] Warn shared var initialization

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a project: clang. In many cases the default constructor of a class contains initializer of data members, which allows concise code. The class may be instantiated as global or automatic variables in device code, which is total

[PATCH] D59639: [clangd] Print template arguments helper

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:26 +llvm::Optional> +getTemplateSpecializationArgLocs(const NamedDecl &ND) { + if (auto *Func = llvm::dyn_cast(&ND)) { Functions should be static, not in anonymous namespace. See

[PATCH] D59463: [ASTMatchers][OpenMP] OpenMP Structured-block-related matchers

This revision was automatically updated to reflect the committed changes. Closed by commit rL356676: [ASTMatchers][OpenMP] OpenMP Structured-block-related matchers (authored by lebedevri, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commi

[PATCH] D57112: [ASTTypeTraits][ASTMatchers][OpenMP] OMPClause handling

This revision was automatically updated to reflect the committed changes. Closed by commit rL356675: [ASTTypeTraits][ASTMatchers][OpenMP] OMPClause handling (authored by lebedevri, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: ht

[PATCH] D59453: [ASTMatchers][OpenMP] Add base ompExecutableDirective() matcher.

This revision was automatically updated to reflect the committed changes. Closed by commit rL356674: [ASTMatchers][OpenMP] Add base ompExecutableDirective() matcher. (authored by lebedevri, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

r356676 - [ASTMatchers][OpenMP] OpenMP Structured-block-related matchers

Author: lebedevri Date: Thu Mar 21 08:33:35 2019 New Revision: 356676 URL: http://llvm.org/viewvc/llvm-project?rev=356676&view=rev Log: [ASTMatchers][OpenMP] OpenMP Structured-block-related matchers Summary: Exposes to the for ASTMatchers the interface/modelling of OpenMP structured-block. Revi

r356677 - [ASTMatcher] Add clang-query disclaimer to two more matchers that take enum

Author: lebedevri Date: Thu Mar 21 08:33:43 2019 New Revision: 356677 URL: http://llvm.org/viewvc/llvm-project?rev=356677&view=rev Log: [ASTMatcher] Add clang-query disclaimer to two more matchers that take enum As we have figured out in https://reviews.llvm.org/D57112 and https://bugs.llvm.org/s

r356675 - [ASTTypeTraits][ASTMatchers][OpenMP] OMPClause handling

Author: lebedevri Date: Thu Mar 21 08:33:24 2019 New Revision: 356675 URL: http://llvm.org/viewvc/llvm-project?rev=356675&view=rev Log: [ASTTypeTraits][ASTMatchers][OpenMP] OMPClause handling Summary: `OMPClause` is the base class, it is not descendant from **any** other class, therefore for it t

r356674 - [ASTMatchers][OpenMP] Add base ompExecutableDirective() matcher.

Author: lebedevri Date: Thu Mar 21 08:33:10 2019 New Revision: 356674 URL: http://llvm.org/viewvc/llvm-project?rev=356674&view=rev Log: [ASTMatchers][OpenMP] Add base ompExecutableDirective() matcher. Summary: A simple matcher for `OMPExecutableDirective` Stmt type. Split off from D57113. Review

[PATCH] D59528: [clang-tidy] Expand modular headers for PPCallbacks

alexfh added a comment. Thank you for the review! I hope I covered all the points. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59528/new/ https://reviews.llvm.org/D59528 ___ cfe-commits mailing list

  1   2   >