r359654 - lib/Header: Fix Visual Studio builds try #2

Author: tstellar Date: Tue Apr 30 23:18:03 2019 New Revision: 359654 URL: http://llvm.org/viewvc/llvm-project?rev=359654&view=rev Log: lib/Header: Fix Visual Studio builds try #2 Summary: This is a follow up to r355253 and a better fix than the first attempt which was r359257. We can't install a

[PATCH] D61220: lib/Header: Fix Visual Studio builds try #2

This revision was automatically updated to reflect the committed changes. Closed by commit rL359654: lib/Header: Fix Visual Studio builds try #2 (authored by tstellar, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1485607 , @jakehehrlich wrote: > The linker doesn't look at section permissions. In fact the only thing it > even looks at the section index for is to check for alignment for copy > relocations which is something most p

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1485610 , @jakehehrlich wrote: > > Wanted to mention, from my testing with yaml2obj, I needed the section > > flags (SHF_EXECINSTR, SHF_WRITE, SHF_ALLOC, etc) otherwise nm was spitting > > the wrong thing. How are you g

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'

hintonda added a comment. Ping. Is this the direction you'd like to go? Or would you prefer something else? thanks... don Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60629/new/ https://reviews.llvm.org/D60629 __

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Dosi-Dough added a comment. Gentle ping Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.org/D57435 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D61270: [CommandLine] Enable Grouping for short options by default. Part 4 of 5

hintonda added a comment. In D61270#1483661 , @MaskRay wrote: > Thank you for the patch series! > > > This is consistent with GNU getopt behavior. > > This is not GNU specific :) It is POSIX Utility Syntax Guidelines 5 > http://pubs.opengroup.org/online

[PATCH] D59924: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

jsji added inline comments. Comment at: lib/Headers/ppc_wrappers/mmintrin.h:3 + * + * Permission is hereby granted, free of charge, to any person obtaining a copy + * of this software and associated documentation files (the "Software"), to deal jsji wrote: > Mas

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1485611 , @jakehehrlich wrote: > Oh and "ifo" is a good name. I still would like to keep the clang flag as -emit-ifso; the intermediate unmerged files are analogous to object files but the final result should be somet

[PATCH] D60974: Clang IFSO driver action.

jakehehrlich added a comment. > Wanted to mention, from my testing with yaml2obj, I needed the section flags > (SHF_EXECINSTR, SHF_WRITE, SHF_ALLOC, etc) otherwise nm was spitting the > wrong thing. How are you going to handle those? I'm not sure what you mean. yaml2obj is a different tool that

[PATCH] D60974: Clang IFSO driver action.

jakehehrlich added a comment. Oh and "ifo" is a good name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D61350: [clang-tidy] New check calling out uses of +new in Objective-C code

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/google/AvoidNSObjectNewCheck.cpp:29 + +bool isMessageExpressionInsideMacro(const ObjCMessageExpr *Expr) { + SourceLocation ReceiverLocation = Expr->getReceiverRange().getBegin(); Plea

[PATCH] D60974: Clang IFSO driver action.

jakehehrlich added a comment. The linker doesn't look at section permissions. In fact the only thing it even looks at the section index for is to check for alignment for copy relocations which is something most people don't even use. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1485552 , @jakehehrlich wrote: > Well I think it should be a seperate tool but because the code inside > llvm-elfabi isn't a library yet (though it is written to be used like one) we > can do that by adding a symlink an

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1483479 , @jakehehrlich wrote: > In D60974#1483380 , @plotfi wrote: > > > Also, curious on the lack of denoting the sections and which symbols go in > > which sections? Do you jus

[PATCH] D61357: SemaOverload: Complete candidates before emitting the error, to ensure diagnostics emitted (or suppressed) during completion don't interfere with the overload notes

dblaikie created this revision. dblaikie added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Because diagnostics and their notes are not connected at the API level, if the error message for an overload is emitted, then the overload candidates are comple

[PATCH] D61357: SemaOverload: Complete candidates before emitting the error, to ensure diagnostics emitted (or suppressed) during completion don't interfere with the overload notes

dblaikie added a comment. Oh, @rsmith - if there's any better/different testing (if you can figure out how to reduce the test case down further, now that we know the cause - or if you'd like testing for other codepaths I've touched in this patch) I'm all ears. (also naming/API wrangling - my ch

[PATCH] D60974: Clang IFSO driver action.

jakehehrlich added a comment. Well I think it should be a seperate tool but because the code inside llvm-elfabi isn't a library yet (though it is written to be used like one) we can do that by adding a symlink and changing the behavior of the underlying binary to present as a different tool. Ma

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1485417 , @jakehehrlich wrote: > Background: > There are two parts to this. TextAPI is a public interface of textual > representations for these sorts of files that already exists in llvm. There > exist ELF and MachO t

[PATCH] D59924: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

rjmccall added a subscriber: chandlerc. rjmccall added a comment. @chandlerc, I hate to do this to you, but licensing question. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59924/new/ https://reviews.llvm.org/D59924 ___

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

rjmccall added a comment. Hmm. You know, there's another case where the destructor can be called even for a non-array: if constructing the object requires a temporary, I believe an exception thrown from that temporary's destructor is supposed to go back and destroy the variable. (This is, sad

[PATCH] D61280: Variable auto-init: don't initialize aggregate padding of all aggregates

jfb added a comment. Follow-up test fix in http://llvm.org/r359636 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61280/new/ https://reviews.llvm.org/D61280 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

r359636 - Fix auto-init test

Author: jfb Date: Tue Apr 30 16:27:28 2019 New Revision: 359636 URL: http://llvm.org/viewvc/llvm-project?rev=359636&view=rev Log: Fix auto-init test r359628 changed the initialization of padding to follow C, but I didn't update the C++ tests. Modified: cfe/trunk/test/CodeGenCXX/auto-var-ini

[PATCH] D61318: [Sema] Prevent binding references with mismatching address spaces to temporaries

rjmccall added inline comments. Comment at: lib/Sema/SemaInit.cpp:4836 + if (T1Quals.hasAddressSpace()) { +if (!T1Quals.isAddressSpaceSupersetOf(cv1T1IgnoreAS.getQualifiers())) { + Sequence.SetFailed( Isn't `cv1T1IgnoreAS.getQualifiers()` always `LangAS

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

axzhang added a comment. Pinging for visibility. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55044/new/ https://reviews.llvm.org/D55044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D61338: [WebAssembly] Use the "wasm32-wasi" triple in tests

This revision was automatically updated to reflect the committed changes. Closed by commit rC359630: [WebAssembly] Use the "wasm32-wasi" triple in tests (authored by djg, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61338/new/ https://reviews.llvm

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

erik.pilkington updated this revision to Diff 197477. erik.pilkington added a comment. Add a try/catch block to the docs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61165/new/ https://reviews.llvm.org/D61165 Files: clang/include/clang/Basic/AttrDocs.td clang/lib/CodeGen/CGDeclCX

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

richard.townsend.arm added inline comments. Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1106 + +FI.getReturnInfo().setInReg(isAArch64 && !IsSizeGreaterThan128(RD)); efriedma wrote: > richard.townsend.arm wrote: > > efriedma wrote: > > > richard.townsend.arm

[PATCH] D61147: [Sema][ObjC] Disable -Wunused-parameter for ObjC methods

ahatanak added a comment. In D61147#1479932 , @rjmccall wrote: > I would also recommend that you go fix the warning to never fire on virtual > C++ methods. I tried building clang/llvm with -Wunused-parameter turned on and there are lots of places wher

r359630 - [WebAssembly] Use the "wasm32-wasi" triple in tests

Author: djg Date: Tue Apr 30 16:06:07 2019 New Revision: 359630 URL: http://llvm.org/viewvc/llvm-project?rev=359630&view=rev Log: [WebAssembly] Use the "wasm32-wasi" triple in tests Similar to https://reviews.llvm.org/D61334, update clang tests to use the "wasm32-wasi" triple, removing the "-musl

[PATCH] D61147: [Sema][ObjC] Disable -Wunused-parameter for ObjC methods

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61147/new/ https://reviews.llvm.org/D61147 ___

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

Rakete added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:2579 +assert( +!ES.getExpr() || +CXXConstructorDeclBits.HasTrailingExplicitSpecifier && Your or needs parens or the disambiguation is wrong. Com

[PATCH] D61280: Variable auto-init: don't initialize aggregate padding of all aggregates

This revision was automatically updated to reflect the committed changes. Closed by commit rC359628: Variable auto-init: don't initialize aggregate padding of all aggregates (authored by jfb, committed by ). Changed prior to commit: https://reviews.llvm.org/D61280?vs=197188&id=197476#toc Repos

[PATCH] D61280: Variable auto-init: don't initialize aggregate padding of all aggregates

jfb added a comment. This seems uncontroversial, I'm happy to make follow-up change if you have suggestions. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61280/new/ https://reviews.llvm.org/D61280 ___ cfe-commits m

[PATCH] D61147: [Sema][ObjC] Disable -Wunused-parameter for ObjC methods

ahatanak updated this revision to Diff 197469. ahatanak retitled this revision from "[Sema][ObjC] Add a flavor of -Wunused-parameter that doesn't diagnose unused parameters of ObjC methods" to "[Sema][ObjC] Disable -Wunused-parameter for ObjC methods". ahatanak edited the summary of this revision

r359628 - Variable auto-init: don't initialize aggregate padding of all aggregates

Author: jfb Date: Tue Apr 30 15:56:53 2019 New Revision: 359628 URL: http://llvm.org/viewvc/llvm-project?rev=359628&view=rev Log: Variable auto-init: don't initialize aggregate padding of all aggregates Summary: C guarantees that brace-init with fewer initializers than members in the aggregate wi

[PATCH] D60974: Clang IFSO driver action.

jakehehrlich added a comment. Background: There are two parts to this. TextAPI is a public interface of textual representations for these sorts of files that already exists in llvm. There exist ELF and MachO textual representations currently. llvm-elfabi is a tool for 1) Creating Stubs 2) Creat

[PATCH] D61269: [CommandLine] Change help output to prefix long options with `--` instead of `-`. NFC . Part 3 of 5

hintonda updated this revision to Diff 197466. hintonda added a comment. - Refactor and fix additional dashes in error messages and tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61269/new/ https://reviews.llvm.org/D61269 Files: clang/test

[PATCH] D60937: [clangd] Fix code completion of macros defined in the preamble region of the main file.

sammccall added a comment. Ping :-) Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60937/new/ https://reviews.llvm.org/D60937 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

jfb added a comment. In D61165#1479937 , @rjmccall wrote: > Are you sure these are the right semantics for `nodestroy`? I think there's > a reasonable argument that we should not destroy previous elements of a > `nodestroy` array just because an element

[PATCH] D60605: [clangd] Revamp textDocument/onTypeFormatting.

sammccall added a comment. In D60605#1483729 , @ilya-biryukov wrote: > Found today: I'm not able to reproduce this, can you give a complete example? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60605/new/

[PATCH] D61350: New clang-tidy check calling out uses of +new in Objective-C code

mwyman created this revision. mwyman added reviewers: benhamilton, hokein. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Google's Objective-C style guide forbids calling or overriding +new to instantiate objects. This check warns on violations. Style guide referen

[PATCH] D61274: [Sema][AST] Explicit visibility for OpenCL/CUDA kernels/variables

yaxunl added inline comments. Comment at: lib/AST/Decl.cpp:738 + (isa(D) && D->hasAttr()) || + (isa(D) && D->hasAttr())) { +Visibility Vis = LV.getVisibility(); we also need this for `__constant__` variables. Repository: rC Clang CHANGES SINCE

[PATCH] D61349: [clangd] Standard library mapping: prefer "primary" versions of functions over variants.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D61349 Files: clangd/StdSymbolMap.inc clangd/

r359623 - Remove two unnecessary wrappers of canPassInRegisters

Author: rnk Date: Tue Apr 30 15:23:20 2019 New Revision: 359623 URL: http://llvm.org/viewvc/llvm-project?rev=359623&view=rev Log: Remove two unnecessary wrappers of canPassInRegisters These extra layers aren't necessary. Modified: cfe/trunk/lib/CodeGen/CGCXXABI.cpp cfe/trunk/lib/CodeGen/

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

rnk added inline comments. Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:55-56 + bool passClassIndirect(const CXXRecordDecl *RD) const { +return !canCopyArgument(RD); + } These are both trivial wrappers for `RD->canPassInRegisters()` which has the real log

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1484744 , @jakehehrlich wrote: > > Does llvm-elfabi consume your proposed Schema format? Has it landed yet? > > No, I just proposed it and explained my reasoning. If you wanted to add this > format to TextAPI that would

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

erik.pilkington updated this revision to Diff 197453. erik.pilkington added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61165/new/ https://reviews.llvm.org/D61165 Files: clang/include/clang/Basic/AttrDocs.td clang/lib/CodeGen/CGDeclCXX.cpp cl

[PATCH] D51329: [Attribute/Diagnostics] Print macro if definition is an attribute declaration

leonardchan added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:257-262 + bool AttrStartIsInMacro = + (StartLoc.isMacroID() && Lexer::isAtStartOfMacroExpansion( + StartLoc, SrcMgr, PP.getLangOpts())); + bool At

[PATCH] D51329: [Attribute/Diagnostics] Print macro if definition is an attribute declaration

leonardchan updated this revision to Diff 197454. leonardchan marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51329/new/ https://reviews.llvm.org/D51329 Files: clang/include/clang/AST/ASTContext.h clang/include/cl

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

efriedma added inline comments. Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1106 + +FI.getReturnInfo().setInReg(isAArch64 && !IsSizeGreaterThan128(RD)); richard.townsend.arm wrote: > efriedma wrote: > > richard.townsend.arm wrote: > > > I'm not sure what th

[PATCH] D44387: [x86] Introduce the pconfig/encl[u|s|v] intrinsics

vsapsai added a comment. Having in bitcode something like `@llvm.x86.encls.64` is better than inline assembly because we understand the meaning of the bitcode while we don't parse assembly and have a very limited understanding of what it is doing. The use case we need to support is basically

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

xbolva00 added inline comments. Comment at: clang/include/clang/AST/DeclBase.h:1534 /// 25 bits to fit in the remaining availible space. /// Note that this makes CXXConstructorDeclBitfields take Small typo + update comment CHANGES SINCE LAST ACTION

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

richard.townsend.arm added inline comments. Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1106 + +FI.getReturnInfo().setInReg(isAArch64 && !IsSizeGreaterThan128(RD)); efriedma wrote: > richard.townsend.arm wrote: > > I'm not sure what the IsSizeGreaterThan128

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

efriedma added inline comments. Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1106 + +FI.getReturnInfo().setInReg(isAArch64 && !IsSizeGreaterThan128(RD)); richard.townsend.arm wrote: > I'm not sure what the IsSizeGreaterThan128 check is doing here - if the >

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

rsmith added a comment. This is great, thank you so much! Comment at: clang/include/clang/AST/DeclBase.h:1539-1541 +uint64_t NumCtorInitializers : 64 - NumDeclContextBits - +NumFunctionDeclBits - +/*Other used bits in CXXConstructorDecl*/ 3;

[PATCH] D61345: Allow 'CodeGenObjC/illegal-UTF8.m' test for 32-bit targets.

vvereschaka created this revision. vvereschaka added a project: clang. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. The 'CodeGenObjC/illegal-UTF8.m' get failed with Clang built with 32-bit targets only (as example ARM-only) with the following error: error: unable to create

[PATCH] D61142: Set LoopInterleaved in the PassManagerBuilder.

This revision was automatically updated to reflect the committed changes. Closed by commit rC359616: Set LoopInterleaved in the PassManagerBuilder. (authored by asbirlea, committed by ). Changed prior to commit: https://reviews.llvm.org/D61142?vs=196696&id=197445#toc Repository: rC Clang CH

r359616 - Set LoopInterleaved in the PassManagerBuilder.

Author: asbirlea Date: Tue Apr 30 14:29:23 2019 New Revision: 359616 URL: http://llvm.org/viewvc/llvm-project?rev=359616&view=rev Log: Set LoopInterleaved in the PassManagerBuilder. Summary: Corresponds to D61030. Subscribers: jlebar, cfe-commits, llvm-commits Tags: #clang Differential Revisio

[PATCH] D51329: [Attribute/Diagnostics] Print macro if definition is an attribute declaration

rsmith added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:257-262 + bool AttrStartIsInMacro = + (StartLoc.isMacroID() && Lexer::isAtStartOfMacroExpansion( + StartLoc, SrcMgr, PP.getLangOpts())); + bool AttrEnd

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

mgrang updated this revision to Diff 197436. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60349/new/ https://reviews.llvm.org/D60349 Files: include/clang/AST/DeclCXX.h include/clang/CodeGen/CGFunctionInfo.h lib/CodeGen/CGCall.cpp lib/CodeGen/MicrosoftCXXABI.cpp lib/Sema/SemaDe

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

richard.townsend.arm added inline comments. Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1106 + +FI.getReturnInfo().setInReg(isAArch64 && !IsSizeGreaterThan128(RD)); I'm not sure what the IsSizeGreaterThan128 check is doing here - if the return type is over

[PATCH] D59885: [Lex] Allow to consume tokens while preprocessing

rsmith added a comment. I'd like to understand more about the intended use cases of this functionality. What information do clients want? Comment at: clang/lib/Lex/Preprocessor.cpp:870-900 + TokenSource Source; do { +Source = TokenSource(); + switch (CurLexerKind)

[PATCH] D61274: [Sema][AST] Explicit visibility for OpenCL/CUDA kernels/variables

rjmccall added a comment. Okay. So it sounds like this should either be a device-only rule, with no warning in mixed-mode languages like CUDA, or we should take a different approach. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61274/new/ https://reviews.llvm

[PATCH] D61280: Variable auto-init: don't initialize aggregate padding of all aggregates

jfb added a comment. In D61280#1485115 , @rjmccall wrote: > I don't think the implication is supposed to be that padding is > zero-initialized or not depending on where in the aggregate it appears, but > it doesn't really matter, I don't think we're argu

[PATCH] D61304: [OpenCL][PR41609] Deduce static data members to __global addr space

rjmccall added a comment. Presumably a similar rule would apply to thread-locals if you supported them. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61304/new/ https://reviews.llvm.org/D61304 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D61280: Variable auto-init: don't initialize aggregate padding of all aggregates

rjmccall added a comment. I don't think the implication is supposed to be that padding is zero-initialized or not depending on where in the aggregate it appears, but it doesn't really matter, I don't think we're arguing about the goal of this patch. Repository: rC Clang CHANGES SINCE LAST A

[PATCH] D61280: Variable auto-init: don't initialize aggregate padding of all aggregates

jfb added a comment. In D61280#1485073 , @rjmccall wrote: > IIRC, C says *members* are initialized as if they were in static storage, > which might mean that their interior padding should be zeroed, but I don't > think says anything about the padding in

[PATCH] D60930: [codeview] Fix symbol names for dynamic initializers and atexit stubs

rjmccall added a comment. In Swift we basically shove *everything* through our corresponding linkage-entity structure, so I'm not opposed to the basic idea. That said, it's unfortunate that this needs to be raised to the AST level. Also, you have really been contributing to this project far to

[PATCH] D61338: [WebAssembly] Use the "wasm32-wasi" triple in tests

sunfish created this revision. sunfish added reviewers: dschuff, sbc100, aheejin. Herald added a subscriber: jgravelle-google. Herald added a project: clang. Similar to https://reviews.llvm.org/D61334, update clang tests to use the "wasm32-wasi" triple, removing the "-musl" environment and omitti

[PATCH] D61280: Variable auto-init: don't initialize aggregate padding of all aggregates

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM, I think this makes sense. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61280/new/ https://reviews.llvm.org/D61280 _

[PATCH] D61280: Variable auto-init: don't initialize aggregate padding of all aggregates

rjmccall added a comment. IIRC, C says *members* are initialized as if they were in static storage, which might mean that their interior padding should be zeroed, but I don't think says anything about the padding in the enclosing aggregate. But I think zero-initializing padding is probably the

[PATCH] D60848: [Parser] Avoid correcting delayed typos in array subscript multiple times.

vsapsai updated this revision to Diff 197421. vsapsai added a comment. - Add a test case with `-disable-free`. Thanks for the suggestion, Erik. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60848/new/ https://reviews.llvm.org/D60848 Files: clang/lib/Parse/ParseExpr.cpp clang/test/

[PATCH] D38061: Set AnonymousTagLocations false for ASTContext if column info is expected not to be used

dblaikie added a comment. In D38061#1484568 , @wenlei wrote: > In D38061#1484486 , @dblaikie wrote: > > > Seems like the right thing would be for the DWARF code that wants a > > rendered type name to pass its own p

[PATCH] D61335: [LibTooling] Add support to Transformer for composing rules as an ordered choice.

ymandel created this revision. ymandel added a reviewer: ilya-biryukov. Herald added a project: clang. This revision adds a new kind of rewrite rule, `CompositeRewriteRule`, which composes multiple subrules into a new rule that allows ordered-choice among its subrules. With this feature, users can

[PATCH] D51329: [Attribute/Diagnostics] Print macro if definition is an attribute declaration

leonardchan updated this revision to Diff 197416. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51329/new/ https://reviews.llvm.org/D51329 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/RecursiveASTVisitor.h clang/include/

[PATCH] D50515: Re-push "[Option] Fix PR37006 prefix choice in findNearest"

thakis added a comment. I think I figured it out. r359604 should fix the bug that caused this to be reverted twice. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50515/new/ https://reviews.llvm.org/D50515 ___ cfe-com

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++

phosek marked an inline comment as not done. phosek added a subscriber: rsmith. phosek added inline comments. Comment at: libunwind/CMakeLists.txt:190 if(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND NOT APPLE) - set(DEFAULT_INSTALL_PREFIX lib${LLVM_LIBDIR_SUFFIX}/clang/${CLANG_VERSI

[PATCH] D51329: [Attribute/Diagnostics] Print macro if definition is an attribute declaration

leonardchan added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:257-262 + bool AttrStartIsInMacro = + (StartLoc.isMacroID() && Lexer::isAtStartOfMacroExpansion( + StartLoc, SrcMgr, PP.getLangOpts())); + bool At

[PATCH] D51329: [Attribute/Diagnostics] Print macro if definition is an attribute declaration

leonardchan updated this revision to Diff 197415. leonardchan marked 17 inline comments as done. leonardchan removed a reviewer: martong. Herald added a reviewer: martong. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51329/new/ https://reviews.llvm.

[PATCH] D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux

This revision was automatically updated to reflect the committed changes. Closed by commit rL359603: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux (authored by phosek, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: ht

[PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

martong marked 2 inline comments as done. martong added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lang/c/modules/main.c:8 int b; -} FILE; +} MYFILE; In TestCmodules.py we have `import Darwin` and then `expr *fopen("/dev/zero", "w")`

r359603 - [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux

Author: phosek Date: Tue Apr 30 12:35:14 2019 New Revision: 359603 URL: http://llvm.org/viewvc/llvm-project?rev=359603&view=rev Log: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux When compiler-rt is selected as the runtime library for Linux targets use its crtbegin.o/crtend.o impleme

[PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

martong created this revision. martong added reviewers: shafik, teemperor, jingham, clayborg, a_sidorin. Herald added subscribers: lldb-commits, cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added projects: clang, LLDB. With LLDB we use localUncac

[PATCH] D44387: [x86] Introduce the pconfig/encl[u|s|v] intrinsics

craig.topper added a comment. Your understanding is correct. As far as testing I think the existing testing in the original patches is sufficient. I'm not sure I understand how a target specific intrinsic that only works on x86 in the bitcode is substantially better than inline assembly. Do y

[PATCH] D44387: [x86] Introduce the pconfig/encl[u|s|v] intrinsics

vsapsai added a comment. Thanks for the insightful explanation, Craig. As far as I understand, implementing intrinsics with builtins is possible but it is more complex and wasn't providing enough value to prefer it over inline assembly. If that is correct, I'd like to revive the abandoned imple

r359598 - Add requires amdgpu-registered-target for amdgpu-float16.cpp

Author: yaxunl Date: Tue Apr 30 12:06:15 2019 New Revision: 359598 URL: http://llvm.org/viewvc/llvm-project?rev=359598&view=rev Log: Add requires amdgpu-registered-target for amdgpu-float16.cpp Modified: cfe/trunk/test/CodeGenCXX/amdgpu-float16.cpp Modified: cfe/trunk/test/CodeGenCXX/amdgpu-

[PATCH] D61220: lib/Header: Fix Visual Studio builds try #2

smeenai accepted this revision. smeenai added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61220/new/ https://reviews.llvm.org/D61220 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D50515: Re-push "[Option] Fix PR37006 prefix choice in findNearest"

thakis added a comment. vitalybuka told me that this should repro things locally: mkdir /tmp/bot cd /tmp/bot svn checkout https://llvm.org/svn/llvm-project/zorg BUILDBOT_CLOBBER= BUILDBOT_REVISION=YOUR_REV zorg/trunk/zorg/buildbot/builders/sanitizers/buildbot_fast.sh 2>&1 | tee buildlog

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++

jdenny added a comment. In D59168#1484754 , @phosek wrote: > It's the `LIBCXX_ABI_VERSION` CMake option, see > https://github.com/llvm/llvm-project/blob/master/libcxx/CMakeLists.txt#L121 Thanks. Comment at: libunwind/CMakeLists.txt:1

[PATCH] D60907: [OpenMP] Add math functions support in OpenMP offloading

tra added a comment. In D60907#1484756 , @jdoerfert wrote: > I actually don't want to preinclude anything and my arguments are (mostly) > for the OpenMP offloading code path not necessarily Cuda. > Maybe to clarify, what I want is: > > 1. Make sure the `

[PATCH] D38061: Set AnonymousTagLocations false for ASTContext if column info is expected not to be used

dblaikie added a comment. Seems like the right thing would be for the DWARF code that wants a rendered type name to pass its own printing policy, rather than changing some relatively global one. (though also I have my doubts about the whole approach - macro expansion can change the line number

[PATCH] D38061: Set AnonymousTagLocations false for ASTContext if column info is expected not to be used

wenlei added a comment. In D38061#1484486 , @dblaikie wrote: > Seems like the right thing would be for the DWARF code that wants a rendered > type name to pass its own printing policy, rather than changing some > relatively global one. > > (though also I

r359594 - AMDGPU: Enable _Float16

Author: yaxunl Date: Tue Apr 30 11:35:37 2019 New Revision: 359594 URL: http://llvm.org/viewvc/llvm-project?rev=359594&view=rev Log: AMDGPU: Enable _Float16 Added: cfe/trunk/test/CodeGenCXX/amdgpu-float16.cpp Modified: cfe/trunk/lib/Basic/Targets/AMDGPU.cpp Modified: cfe/trunk/lib/Basic/

[PATCH] D60907: [OpenMP] Add math functions support in OpenMP offloading

jdoerfert added a comment. In D60907#1484529 , @hfinkel wrote: > In D60907#1483660 , @jdoerfert wrote: > > > In D60907#1483615 , @hfinkel wrote: > > > > > In D60907#1479370 <

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++

phosek added a comment. In D59168#1484467 , @jdenny wrote: > In D59168#1480801 , @phosek wrote: > > > In D59168#1480428 , @jdenny wrote: > > > > > It seems we have roughly th

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++

phosek marked an inline comment as done. phosek added inline comments. Comment at: libunwind/CMakeLists.txt:190 if(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND NOT APPLE) - set(DEFAULT_INSTALL_PREFIX lib${LLVM_LIBDIR_SUFFIX}/clang/${CLANG_VERSION}/${LLVM_DEFAULT_TARGET_TRIPLE}/) -

[PATCH] D50515: Re-push "[Option] Fix PR37006 prefix choice in findNearest"

thakis added a comment. Herald added a project: LLVM. I re-landed this to get access to the msan output, since the link above has long expired. Here's the new link: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/31821/steps/check-clang%20msan/logs/stdio Sadly, the bot outp

[PATCH] D60974: Clang IFSO driver action.

jakehehrlich added a comment. > Does llvm-elfabi consume your proposed Schema format? Has it landed yet? No, I just proposed it and explained my reasoning. If you wanted to add this format to TextAPI that would be acceptable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D61015: [LibTooling] Change Transformer's TextGenerator to a partial function.

ymandel added a comment. In D61015#1484669 , @thakis wrote: > This breaks a test: > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap-msan/builds/12112/steps/check-llvm%20check-clang%20stage3%2Fmsan/logs/stdio > > [--] 1 test f

  1   2   >