[clang-tools-extra] r363034 - [clangd] Fix gcc warning by removing extra "; "

Author: uabelho Date: Mon Jun 10 23:02:01 2019 New Revision: 363034 URL: http://llvm.org/viewvc/llvm-project?rev=363034&view=rev Log: [clangd] Fix gcc warning by removing extra ";" Modified: clang-tools-extra/trunk/clangd/Format.cpp Modified: clang-tools-extra/trunk/clangd/Format.cpp URL: h

[PATCH] D62244: [AMDGPU] Enable the implicit arguments for HIP (CLANG)

cdevadas updated this revision to Diff 203975. cdevadas added a comment. simplified the check in the test case. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62244/new/ https://reviews.llvm.org/D62244 Files: lib/CodeGen/TargetInfo.cpp test/CodeGenCUDA/amdgpu

[PATCH] D59919: [Attributor] Deduce "returned" argument attribute

jdoerfert updated this revision to Diff 203973. jdoerfert added a comment. Update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59919/new/ https://reviews.llvm.org/D59919 Files: clang/test/CodeGenOpenCL/as_type.cl llvm/include/llvm/Trans

[PATCH] D62831: [CodeGen][ObjC] Add attribute "arc_retain_agnostic" to ObjC globals that are retain-agnostic

ahatanak added a comment. I agree. Something like `arc_inert` is probably a better name in this case for the reason you mentioned. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62831/new/ https://reviews.llvm.org/D62831 ___

[libclc] r363031 - Creating release candidate rc2 from release_801 branch

Author: tstellar Date: Mon Jun 10 21:00:01 2019 New Revision: 363031 URL: http://llvm.org/viewvc/llvm-project?rev=363031&view=rev Log: Creating release candidate rc2 from release_801 branch Added: libclc/tags/RELEASE_801/rc2/ - copied from r363030, libclc/branches/release_80/ _

[libunwind] r363031 - Creating release candidate rc2 from release_801 branch

Author: tstellar Date: Mon Jun 10 21:00:01 2019 New Revision: 363031 URL: http://llvm.org/viewvc/llvm-project?rev=363031&view=rev Log: Creating release candidate rc2 from release_801 branch Added: libunwind/tags/RELEASE_801/rc2/ - copied from r363030, libunwind/branches/release_80/ ___

[PATCH] D62831: [CodeGen][ObjC] Add attribute "arc_retain_agnostic" to ObjC globals that are retain-agnostic

gottesmm added a comment. This is exactly what I was imagining! This will enable the frontend to opt into this optimization without having to touch the optimizer. One nit: can we use a different name than "arc_retain_agnostic". Have you considered something like "arc_inert"? My fear is that at

[libunwind] r363030 - Merging r360862:

Author: tstellar Date: Mon Jun 10 20:47:50 2019 New Revision: 363030 URL: http://llvm.org/viewvc/llvm-project?rev=363030&view=rev Log: Merging r360862: r360862 | mstorsjo | 2019-05-15 23:49:20 -0700 (Wed, 15 May 2019) | 12 l

[PATCH] D44865: [libc++] Implement P0608R3 - A sane variant converting constructor

lichray marked 2 inline comments as done. lichray added inline comments. Comment at: test/std/utilities/variant/variant.variant/variant.assign/T.pass.cpp:130 { using V = std::variant; static_assert(!std::is_assignable::value, "ambiguous"); mclow.lis

[PATCH] D44865: [libc++] Implement P0608R3 - A sane variant converting constructor

lichray updated this revision to Diff 203966. lichray added a comment. Add fail tests Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44865/new/ https://reviews.llvm.org/D44865 Files: include/variant test/std/utilities/variant/variant.variant/variant.assign

[PATCH] D62988: Add an attribute to allow fields of non-trivial types in C unions

ahatanak added a comment. In D62988#1537082 , @rjmccall wrote: > Does this lead to C/C++ ABI mismatches? Should we just honor this in C++ as > well by ignoring it when deciding to delete special members? Is taking such > a general name a good idea if i

[PATCH] D44865: [libc++] Implement P0608R3 - A sane variant converting constructor

zoecarver added inline comments. Comment at: include/variant:1128 +template +struct __overload +: __overload_bool<__overload<_Types...>, bool const volatile> {}; EricWF wrote: > Do we even support volatile types in variant? [[ http://eel.is/c++draft/variant.

[PATCH] D44865: [libc++] Implement P0608R3 - A sane variant converting constructor

EricWF added inline comments. Comment at: include/variant:1128 +template +struct __overload +: __overload_bool<__overload<_Types...>, bool const volatile> {}; Do we even support volatile types in variant? Repository: rCXX libc++ CHANGES SINCE LAST ACTIO

[PATCH] D63118: [analyzer] DeadStores: Add a crude suppression files generated by DriverKit IIG.

NoQ created this revision. NoQ added a reviewer: dcoughlin. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. IIG is a replacement for MIG in DriverKit: IIG is autogener

[PATCH] D63117: [analyzer] RetainCount: Add support for OSRequiredCast().

NoQ created this revision. NoQ added a reviewer: dcoughlin. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. It's a new API for custom RTTI in Apple IOKit/DriverKit fra

[PATCH] D63093: [analyzer] WIP: MallocChecker: Release temporary CXXNewExpr

NoQ added a comment. In such cases i recommend starting with writing down a test. Like in TDD: first test, //then// code. The general direction doesn't seem reasonable to me; it introduces some pattern-matching for a specific scenario, but it's unclear why is this scenario a problem on its own

[PATCH] D63080: [analyzer] Track indices of arrays

NoQ added a comment. Whoa, this looks like a much needed improvement, i'm glad that you found it! Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1681 +trackExpressionValue( +LVNode, Arr->getIdx(), report, EnableNullFPSuppression); + --

[PATCH] D62883: [analyzer] Track conditions of terminator statements on which the reported node depends on

NoQ added a comment. In D62883#1536894 , @Szelethus wrote: > I'm not sure how long it'll take for me to figure out what's wrong, but these > numbers are so ridiculous, I suspect a programming error rather then an > algorithmic issue. > > edit: I seem to

[PATCH] D63086: [analyzer][NoStoreFuncVisitor][NFC] Move methods out-of-line, turn some to static functions

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thx for the cleanup! Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:340 +private: + /// Attempts to find the region of interest in a given CXX decl, + /// by e

[PATCH] D62926: [analyzer] ReturnVisitor: Bypass everything to see inlined calls

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:842-849 + if (Optional CEE = Node->getLocationAs()) if (CEE->getCalleeContext()->getCallSite() == S) break; - if (auto SP = Node->getLocationAs()) -i

[PATCH] D62978: [analyzer] ReturnVisitor: Handle unknown ReturnStmts better

NoQ added inline comments. Comment at: clang/test/Analysis/diagnostics/find_last_store.c:9 void no_find_last_store() { - c *e = d(); // expected-note{{Calling 'd'}} - // expected-note@-1{{Returning from 'd'}} - // expected-note@-2{{'e' initialized here

[PATCH] D33672: [analyzer] INT50-CPP. Do not cast to an out-of-range enumeration checker

NoQ added a comment. Herald added a subscriber: Charusso. Herald added a project: clang. Hey, i'm seeing a crash in this checker, would you like to look at it? It looks as if you're not being careful about dereferences/lvalue-to-rvalue-casts so it tries to compare `&e` to `e1`. **$ `cat repro.c

[PATCH] D62363: [X86] Enable intrinsics that convert float and bf16 data to each other

This revision was automatically updated to reflect the committed changes. Closed by commit rL363018: [X86] Enable intrinsics that convert float and bf16 data to each other (authored by pengfei, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

r363018 - [X86] Enable intrinsics that convert float and bf16 data to each other

Author: pengfei Date: Mon Jun 10 18:17:28 2019 New Revision: 363018 URL: http://llvm.org/viewvc/llvm-project?rev=363018&view=rev Log: [X86] Enable intrinsics that convert float and bf16 data to each other Scalar version : _mm_cvtsbh_ss , _mm_cvtness_sbh Vector version: _mm512_cvtpbh_ps , _mm256_

[PATCH] D62225: [clang][NewPM] Fixing -O0 tests that are broken under new PM

chandlerc requested changes to this revision. chandlerc added a comment. This revision now requires changes to proceed. I think this ultimately needs to be split up into smaller patches. A bunch of these things can be landed independently. Here is my first cut at things to split out, each one in

[PATCH] D62888: [NewPM] Port Sancov

chandlerc requested changes to this revision. chandlerc added a comment. This revision now requires changes to proceed. I would just change this to have the module pass loop over the functions -- that seems like it'll be much cleaner. As it is, I'm not seeing where the loop actually happens. But

[PATCH] D63108: [OpenMP] Add support for handling declare target to clause when unified memory is required

gtbercea created this revision. gtbercea added reviewers: ABataev, AlexEichenberger, caomhin. Herald added subscribers: cfe-commits, jdoerfert, guansong. Herald added a project: clang. This patch adds support for the handling of the variables under the declare target to clause. The variables in

[PATCH] D63101: [Frontend] SetUpDiagnosticLog should handle unowned diagnostic consumer in the compiler

This revision was automatically updated to reflect the committed changes. Closed by commit rL363009: [Frontend] SetUpDiagnosticLog should handle unowned diagnostic consumer (authored by arphaman, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

r363009 - [Frontend] SetUpDiagnosticLog should handle unowned diagnostic consumer

Author: arphaman Date: Mon Jun 10 16:32:42 2019 New Revision: 363009 URL: http://llvm.org/viewvc/llvm-project?rev=363009&view=rev Log: [Frontend] SetUpDiagnosticLog should handle unowned diagnostic consumer in the compiler The function SetUpDiagnosticLog that was called from createDiagnostics did

r363007 - Revert r362994 & co "[analyzer][tests] Add normalize_plist to replace diff_plist"

Author: rnk Date: Mon Jun 10 16:25:43 2019 New Revision: 363007 URL: http://llvm.org/viewvc/llvm-project?rev=363007&view=rev Log: Revert r362994 & co "[analyzer][tests] Add normalize_plist to replace diff_plist" Reverts r362998, r362996, and r362994 because the tests do not pass on Windows due t

[PATCH] D59744: Fix i386 ABI "__m64" type bug

rjmccall added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:1005 bool IsMCUABI; + bool IsLinuxABI; unsigned DefaultNumRegisterParameters; mgorny wrote: > Maybe replace the two booleans with something alike `IsPassInMMXRegABI`? And > while at it

[PATCH] D63072: [clang] Fixing incorrect implicit deduction guides (PR41549)

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63072/new/ https://reviews.llvm.org/D63072 ___ cfe-commits mailing list cfe-commit

[PATCH] D62988: Add an attribute to allow fields of non-trivial types in C unions

rjmccall added a reviewer: rsmith. rjmccall added a comment. Does this lead to C/C++ ABI mismatches? Should we just honor this in C++ as well by ignoring it when deciding to delete special members? Is taking such a general name a good idea if it's language-specific? Richard, thoughts? Repos

[PATCH] D50360: [Concepts] Requires Expressions

rsmith added inline comments. Comment at: include/clang/AST/DeclCXX.h:2051 +/// \code +/// template requires requires (T t) { {t++} -> Regular }; +/// \endcode The semicolon here is in the wrong place (should be before the final `}`, not after). ==

[PATCH] D62975: Require stdcall etc parameters to be complete on ODR use

This revision was automatically updated to reflect the committed changes. Closed by commit rL363000: Require stdcall etc parameters to be complete on ODR use (authored by rnk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

r363000 - Require stdcall etc parameters to be complete on ODR use

Author: rnk Date: Mon Jun 10 15:53:12 2019 New Revision: 363000 URL: http://llvm.org/viewvc/llvm-project?rev=363000&view=rev Log: Require stdcall etc parameters to be complete on ODR use Functions using stdcall, fastcall, or vectorcall with C linkage mangle in the size of the parameter pack. Calc

[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

rjmccall added inline comments. Comment at: lib/Sema/TreeTransform.h:5363 +if (ResultType.getAddressSpace() != LangAS::Default && +(ResultType.getAddressSpace() != LangAS::opencl_private)) { SemaRef.Diag(TL.getReturnLoc().getBeginLoc(), Anastas

[PATCH] D62413: [OpenCL][PR41727] Prevent ICE on global dtors

rjmccall added inline comments. Comment at: lib/CodeGen/CGDeclCXX.cpp:132 + Argument = CGM.getTargetCodeGenInfo().performAddrSpaceCast( + CGM, Addr.getPointer(), SrcAS, LangAS::opencl_global, DestTy); Anastasia wrote: > rjmccall wrote: > > Should

[PATCH] D62951: [analyzer][tests] Use normalize_plist in place of diff_plist (`tail` cases)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL362998: [analyzer][tests] Use normalize_plist in place of diff_plist (`tail` cases) (authored by hubert.reinterpretcast, c

r362998 - [analyzer][tests] Use normalize_plist in place of diff_plist (`tail` cases)

Author: hubert.reinterpretcast Date: Mon Jun 10 15:40:35 2019 New Revision: 362998 URL: http://llvm.org/viewvc/llvm-project?rev=362998&view=rev Log: [analyzer][tests] Use normalize_plist in place of diff_plist (`tail` cases) Summary: The `%diff_plist` lit substitution invokes `diff` with a non-po

[PATCH] D62950: [analyzer][tests] Use normalize_plist in place of diff_plist (`cat` cases)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL362996: [analyzer][tests] Use normalize_plist in place of diff_plist (`cat` cases) (authored by hubert.reinterpretcast, co

[PATCH] D63101: [Frontend] SetUpDiagnosticLog should handle unowned diagnostic consumer in the compiler

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63101/new/ https://reviews.llvm.org/D63101 ___ cfe-commits mailing list cfe-com

r362996 - [analyzer][tests] Use normalize_plist in place of diff_plist (`cat` cases)

Author: hubert.reinterpretcast Date: Mon Jun 10 15:37:31 2019 New Revision: 362996 URL: http://llvm.org/viewvc/llvm-project?rev=362996&view=rev Log: [analyzer][tests] Use normalize_plist in place of diff_plist (`cat` cases) Summary: The `%diff_plist` lit substitution invokes `diff` with a non-por

[PATCH] D62949: [analyzer][tests] Add normalize_plist to replace diff_plist

This revision was automatically updated to reflect the committed changes. Closed by commit rL362994: [analyzer][tests] Add normalize_plist to replace diff_plist (authored by hubert.reinterpretcast, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository:

[PATCH] D63101: [Frontend] SetUpDiagnosticLog should handle unowned diagnostic consumer in the compiler

arphaman added a subscriber: cfe-commits. arphaman added a comment. + cue-commits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63101/new/ https://reviews.llvm.org/D63101 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

r362994 - [analyzer][tests] Add normalize_plist to replace diff_plist

Author: hubert.reinterpretcast Date: Mon Jun 10 15:33:34 2019 New Revision: 362994 URL: http://llvm.org/viewvc/llvm-project?rev=362994&view=rev Log: [analyzer][tests] Add normalize_plist to replace diff_plist Summary: The `%diff_plist` lit substitution invokes `diff` with a non-portable `-I` opti

[PATCH] D63041: [PlistSupport] Produce a newline to end plist output files

This revision was automatically updated to reflect the committed changes. Closed by commit rL362992: [PlistSupport] Produce a newline to end plist output files (authored by hubert.reinterpretcast, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository:

r362992 - [PlistSupport] Produce a newline to end plist output files

Author: hubert.reinterpretcast Date: Mon Jun 10 15:30:57 2019 New Revision: 362992 URL: http://llvm.org/viewvc/llvm-project?rev=362992&view=rev Log: [PlistSupport] Produce a newline to end plist output files Summary: As suggested in the review of D62949, this patch updates the plist output to hav

[PATCH] D44865: [libc++] Implement P0608R3 - A sane variant converting constructor

mclow.lists added a comment. The patch looks fine to me, but I think you should consider making a couple of `T.fail.cpp` tests, and check to make sure you get the "right error". Comment at: test/std/utilities/variant/variant.variant/variant.assign/T.pass.cpp:130 { usi

[PATCH] D63029: [CUDA] Fix grep pattern in cuda-types.cu

This revision was automatically updated to reflect the committed changes. hubert.reinterpretcast marked an inline comment as done. Closed by commit rL362991: [CUDA] Fix grep pattern in cuda-types.cu (authored by hubert.reinterpretcast, committed by ). Herald added a project: LLVM. Herald added a s

r362991 - [CUDA] Fix grep pattern in cuda-types.cu

Author: hubert.reinterpretcast Date: Mon Jun 10 15:28:20 2019 New Revision: 362991 URL: http://llvm.org/viewvc/llvm-project?rev=362991&view=rev Log: [CUDA] Fix grep pattern in cuda-types.cu Summary: vertical-line is not a BRE special character. POSIX.1-2017 XBD Section 9.3.2 indicates that the i

[PATCH] D62156: [Sema][PR41730] Diagnose addr space mismatch while constructing objects

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, LGTM. Comment at: test/SemaCXX/address-space-ctor.cpp:11 +//expected-note@-6{{candidate constructor (the implicit move constructor) not viable: no known conversion

[PATCH] D63092: [Frontend] Use executable path when creating invocation from cmdline

phosek added a comment. One more thing, do you think it's reasonable to use `llvm::sys::findProgramByName(Args[0])`instead of `Args[0]` when creating the driver instance? One of the failure modes I ran into is the case where the generated compilation database would contain just the executable n

[PATCH] D60233: [clang-scan-deps] initial outline of the tool that runs preprocessor to find dependencies over a JSON compilation database

aganea accepted this revision. aganea added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/ClangScanDeps/Inputs/regular_cdb.json:4 + "directory": "DIR", + "command": "clang -c DIR/regular_cdb.cpp -IInputs -MD -MF DIR/regular_cdb.d", +

[PATCH] D44865: [libc++] Implement P0608R3 - A sane variant converting constructor

mclow.lists added a comment. In D44865#1051228 , @EricWF wrote: > This LGTM. > > Also I would like @mclow.lists input about applying this DR early since LWG > hasn't commented on it yet. Even though LWG didn't vote it out as a DR; that's what it is, and

[PATCH] D63092: [Frontend] Use executable path when creating invocation from cmdline

phosek added a comment. In D63092#1536774 , @sammccall wrote: > `argv[0]` does carry important information though, I think this will break a > lot of things. It's... concerning that no tests broke. > > For example, if it's `clang` or `g++` or `clang-cl` t

[PATCH] D62883: [analyzer] Track conditions of terminator statements on which the reported node depends on

Szelethus added a comment. I implemented the fixes you commented on, but during evaluation it turned out that my visitor eats ram for breakfast, and then goes for seconds. I mean, like 5-30x the normal memory consumption, and the same for analysis speed. I counted the number of concurrent insta

[PATCH] D63098: [CodeComplete] Allow completing enum values within case statements, and insert 'case' as a fixit.

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added a project: clang. Herald added a subscriber: cfe-commits. There are a few alternative ways to expose this. The most obvious is a RK_Pattern, but it seems to have some triggering problems. Consider a completion

[PATCH] D62888: [NewPM] Port Sancov

leonardchan added a comment. *ping* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62888/new/ https://reviews.llvm.org/D62888 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang-tools-extra] r362978 - [clangd] Remove old hidden -use-dex-index flag

Author: sammccall Date: Mon Jun 10 13:38:16 2019 New Revision: 362978 URL: http://llvm.org/viewvc/llvm-project?rev=362978&view=rev Log: [clangd] Remove old hidden -use-dex-index flag Modified: clang-tools-extra/trunk/clangd/ClangdServer.h clang-tools-extra/trunk/clangd/tool/ClangdMain.cpp

[PATCH] D63092: [Frontend] Use executable path when creating invocation from cmdline

sammccall added a comment. Herald added a subscriber: ormris. `argv[0]` does carry important information though, I think this will break a lot of things. It's... concerning that no tests broke. For example, if it's `clang` or `g++` or `clang-cl` then that affects how command lines are parsed (r

[PATCH] D60233: [clang-scan-deps] initial outline of the tool that runs preprocessor to find dependencies over a JSON compilation database

arphaman added inline comments. Comment at: clang/test/ClangScanDeps/Inputs/regular_cdb.json:4 + "directory": "DIR", + "command": "clang -c DIR/regular_cdb.cpp -IInputs -MD -MF DIR/regular_cdb.d", + "file": "DIR/regular_cdb.cpp" aganea wrote: > Is `-MD -MF` re

[PATCH] D60233: [clang-scan-deps] initial outline of the tool that runs preprocessor to find dependencies over a JSON compilation database

arphaman updated this revision to Diff 203887. arphaman marked 3 inline comments as done. arphaman added a comment. - Add test for `-j2` to exercise multi threading. - Add `InitLLVM`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60233/new/ https://reviews.llvm.org/D60233 Files: clan

[PATCH] D63093: [analyzer] WIP: MallocChecker: Release temporary CXXNewExpr

Charusso planned changes to this revision. Charusso added a comment. This is heavily WIP as sometimes we have to release a `new` after we return it or a constructor did something with that. The direction is okay? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6309

[PATCH] D63093: [analyzer] WIP: MallocChecker: Release temporary CXXNewExpr

Charusso created this revision. Charusso added reviewers: NoQ, xazax.hun, ravikandhadai, baloghadamsoftware, Szelethus. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet. - Repository: rC Clang https://re

[PATCH] D63092: [Frontend] Use executable path when creating invocation from cmdline

phosek created this revision. phosek added reviewers: ilya-biryukov, sammccall, bkramer, echristo. Herald added subscribers: cfe-commits, kadircet. Herald added a project: clang. Args[0] isn't necessarily a correct path, it may not even be the path to the compiler, for example when using tools lik

[PATCH] D63041: [PlistSupport] Produce a newline to end plist output files

NoQ accepted this revision. NoQ added a comment. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63041/new/ https://reviews.llvm.org/D63041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D62978: [analyzer] ReturnVisitor: Handle unknown ReturnStmts better

Charusso added a comment. In D62978#1533558 , @NoQ wrote: > Ah, that positive! Positive == true positive, not false positive, I got it. > No, i don't think this is a valid way to suppress it. Bought me, they are worth to report. The misleading reports

[PATCH] D63091: [clangd] Add a capability to enable completions with fixes.

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D63091 Files: clangd/ClangdLSPServer.cpp clang

[PATCH] D62978: [analyzer] ReturnVisitor: Handle unknown ReturnStmts better

Charusso updated this revision to Diff 203876. Charusso retitled this revision from "[analyzer] ReturnVisitor: Handle non-null ReturnStmts" to "[analyzer] ReturnVisitor: Handle unknown ReturnStmts better". Charusso edited the summary of this revision. Charusso added a comment. - The report was to

[PATCH] D63062: [clang-format] Added New Style Rule: BitFieldDeclsOnSeparateLines

MyDeveloperDay requested changes to this revision. MyDeveloperDay added inline comments. This revision now requires changes to proceed. Comment at: docs/ClangFormatStyleOptions.rst:194 +**BitFieldDeclsOnSeparateLines** (``bool``) + If ``true``, Align Bitfield Declarations on s

[PATCH] D59919: [Attributor] Deduce "returned" argument attribute

jdoerfert added a comment. In D59919#1535643 , @nicholas wrote: > > CHANGED: build-libcalls NumNoUnwind > > 4526 -> 3382 ( -25.276%) > > Why did the number of nounwinds drop? I rerun the experiment with

[PATCH] D63089: [clang] Warn on implicit boolean casts in more contexts (PR34180)

xbolva00 added a comment. Thanks ! You can check and take tests from my older patch https://reviews.llvm.org/D58878 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63089/new/ https://reviews.llvm.org/D63089 ___

[PATCH] D62926: [analyzer] ReturnVisitor: Bypass everything to see inlined calls

Charusso marked 2 inline comments as done. Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:842-849 + if (Optional CEE = Node->getLocationAs()) if (CEE->getCalleeContext()->getCallSite() == S) break; -

[PATCH] D62926: [analyzer] ReturnVisitor: Bypass everything to see inlined calls

Charusso updated this revision to Diff 203874. Charusso retitled this revision from "[analyzer] ReturnVisitor: Bypass constructing objects to see inlined calls" to "[analyzer] ReturnVisitor: Bypass everything to see inlined calls". Charusso added a comment. - The most generic approach. CHANGES

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

Meinersbur requested changes to this revision. Meinersbur added a comment. This revision now requires changes to proceed. In D61446#1533076 , @serge-sans-paille wrote: > That's what I tried to do when always adding Polly.cpp to PollyCore, but it > doesn'

[PATCH] D63089: [clang] Warn on implicit boolean casts in more contexts (PR34180)

m4tx created this revision. m4tx added reviewers: lebedev.ri, rsmith, klimek. Herald added a project: clang. Herald added a subscriber: cfe-commits. int x; return x = 5; For a code like above, GCC produces a warning suggesting using parentheses about the assignment. This change makes clang p

[PATCH] D63088: [clang-tidy] misc-unused-parameters: don't comment out parameter name for C code

mgehre updated this revision to Diff 203873. mgehre added a comment. Fix rewrapped comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63088/new/ https://reviews.llvm.org/D63088 Files: clang-tools-extra/clang-tidy/misc/UnusedParametersCheck.cp

[PATCH] D63088: [clang-tidy] misc-unused-parameters: don't comment out parameter name for C code

mgehre created this revision. mgehre added reviewers: klimek, ilya-biryukov, lebedev.ri, aaron.ballman. Herald added a subscriber: xazax.hun. Herald added a project: clang. The fixit `int square(int /*num*/)` yields `error: parameter name omitted` for C code. Enable it only for C++ code. Reposi

[PATCH] D63086: [analyzer][NoStoreFuncVisitor][NFC] Move methods out-of-line, turn some to static functions

Szelethus created this revision. Szelethus added reviewers: NoQ, dcoughlin, xazax.hun, rnkovacs, Charusso, baloghadamsoftware. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. I personally foun

[PATCH] D61749: [clang-tidy] initial version of readability-static-const-method

mgehre added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61749/new/ https://reviews.llvm.org/D61749 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D63085: Provide a fix-it hint for -Wswitch, which adds missing cases. If there are >3 cases, the inserted text will contain newlines so it will not be shown in console output (but will be appl

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Lifted the helper for spelling one scope from another from SemaCodeComplete -> AST, to reuse it. It should be usef

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

rnk added a subscriber: dexonsmith. rnk added a comment. Personally, I think it's safe to do this. I believe this "4.2.1" compat thing was something Apple added as part of their switch from GCC, and then llvm-gcc, over to Clang, and I think most of the code they care about probably doesn't rely

[PATCH] D62962: Clang implementation of sizeless types

jfb added inline comments. Comment at: test/Sema/sizeless-1.c:66 + _Static_assert(__atomic_always_lock_free(1, &local_int8) == __atomic_always_lock_free(1, incomplete_ptr), ""); + _Static_assert(__atomic_always_lock_free(2, &local_int8) == __atomic_always_lock_free(2, incompl

[PATCH] D63072: [clang] Fixing incorrect implicit deduction guides (PR41549)

Tyker updated this revision to Diff 203862. Tyker added a comment. fixed the issue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63072/new/ https://reviews.llvm.org/D63072 Files: clang/lib/Sema/SemaTemplate.cpp clang/test/SemaCXX/cxx1z-class-template-argument-deduction.cpp Index

[PATCH] D62962: Clang implementation of sizeless types

rsandifo-arm marked 2 inline comments as done. rsandifo-arm added inline comments. Comment at: test/Sema/sizeless-1.c:66 + _Static_assert(__atomic_always_lock_free(1, &local_int8) == __atomic_always_lock_free(1, incomplete_ptr), ""); + _Static_assert(__atomic_always_lock_free(

[PATCH] D63062: [clang-format] Added New Style Rule: BitFieldDeclsOnSeparateLines

Manikishan updated this revision to Diff 203860. Manikishan marked 4 inline comments as done. Manikishan added a comment. Updated unittest Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63062/new/ https://reviews.llvm.org/D63062 Files: docs/ClangFormatStyleOpti

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

beanz added inline comments. Comment at: llvm/cmake/modules/AddLLVM.cmake:812 +# llvm::PassPluginLibraryInfo ${entry_point}(); +add_custom_target(LLVM_PLUGINS) # target used to hold global properties referencable from generator-expression +function(register_llvm_extension

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

lildmh marked an inline comment as done. lildmh added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8729 +/// \code +/// void .omp_mapper...(void *rt_mapper_handle, +/// void *base, void *begin, ABataev wro

[PATCH] D62960: SVE opaque type for C intrinsics demo

erik.pilkington added inline comments. Comment at: lib/AST/ItaniumMangle.cpp:2680 +break; +#include "clang/Basic/AArch64SVEACLETypes.def" } jfb wrote: > @rjmccall you probably should review this part. Sorry for the drive by comment, but: All of these mangl

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8729 +/// \code +/// void .omp_mapper...(void *rt_mapper_handle, +/// void *base, void *begin, lildmh wrote: > ABataev wrote: > > lildmh wrote: >

[PATCH] D63041: [PlistSupport] Produce a newline to end plist output files

xingxue accepted this revision. xingxue added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63041/new/ https://reviews.llvm.org/D63041 ___ cfe-commits

[PATCH] D62960: SVE opaque type for C intrinsics demo

jfb added subscribers: rjmccall, jfb. jfb added a comment. Tests? Comment at: lib/AST/ItaniumMangle.cpp:2680 +break; +#include "clang/Basic/AArch64SVEACLETypes.def" } @rjmccall you probably should review this part. Repository: rC Clang CHANGES SINCE

[PATCH] D62962: Clang implementation of sizeless types

jfb added inline comments. Comment at: test/Sema/sizeless-1.c:66 + _Static_assert(__atomic_always_lock_free(1, &local_int8) == __atomic_always_lock_free(1, incomplete_ptr), ""); + _Static_assert(__atomic_always_lock_free(2, &local_int8) == __atomic_always_lock_free(2, incompl

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

lildmh marked an inline comment as done. lildmh added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8729 +/// \code +/// void .omp_mapper...(void *rt_mapper_handle, +/// void *base, void *begin, ABataev wro

[PATCH] D61027: Fix crash on switch conditions of non-integer types in templates

eandrews updated this revision to Diff 203854. eandrews edited the summary of this revision. eandrews added a reviewer: rsmith. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61027/new/ https://reviews.llvm.org/D61027 Files: lib/AST/Expr.cpp lib/Sema/SemaChecking.cpp test/SemaTempla

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8729 +/// \code +/// void .omp_mapper...(void *rt_mapper_handle, +/// void *base, void *begin, lildmh wrote: > ABataev wrote: > > lildmh wrote: >

[PATCH] D63018: [X86] Attempt to make the Intel core CPU inheritance a little more readable and maintainable

This revision was automatically updated to reflect the committed changes. Closed by commit rL362965: [X86] Attempt to make the Intel core CPU inheritance a little more readable and… (authored by ctopper, committed by ). Herald added a project: LLVM. Changed prior to commit: https://reviews.llvm

r362965 - [X86] Attempt to make the Intel core CPU inheritance a little more readable and maintainable

Author: ctopper Date: Mon Jun 10 09:59:28 2019 New Revision: 362965 URL: http://llvm.org/viewvc/llvm-project?rev=362965&view=rev Log: [X86] Attempt to make the Intel core CPU inheritance a little more readable and maintainable The recently added cooperlake CPU has made our already ugly switch st

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

lildmh marked an inline comment as done. lildmh added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8729 +/// \code +/// void .omp_mapper...(void *rt_mapper_handle, +/// void *base, void *begin, ABataev wro

  1   2   >