Re: [PATCH] D61909: Add Clang shared library with C++ exports

libclangcpp ? I think it is a pretty common pattern. On debian, apt-cache search 'lib.*cpp'  returns a bunch of libraries (libhdf5-cpp, libroscpp2d, libjsonrpccpp-dev, libmysqlcppconn7v5, libsvncpp3, libtercpp0v5, libyaml-cpp-dev, etc) S Le 02/07/2019 à 01:22, Chris Bieneman a écrit : The

[PATCH] D63920: [CTU] Add support for virtual functions

baloghadamsoftware added a comment. Try to set analyzer option `IPAMode` to something different from its default value which is `dynamic-bifurcate` in the test file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63920/new/ https://reviews.llvm.org

[PATCH] D63482: [clang-tidy] Fix the YAML created for checks like modernize-pass-by-value

gribozavr added inline comments. Comment at: clang/include/clang/Tooling/ReplacementsYaml.h:35 +: FilePath(""), Offset(0), Length(0), ReplacementText("") { + size_t lineBreakPos = ReplacementText.find('\n'); + while (lineBreakPos != std::string::npos) {

[PATCH] D63482: [clang-tidy] Fix the YAML created for checks like modernize-pass-by-value

yvvan marked an inline comment as done. yvvan added inline comments. Comment at: clang/include/clang/Tooling/ReplacementsYaml.h:35 +: FilePath(""), Offset(0), Length(0), ReplacementText("") { + size_t lineBreakPos = ReplacementText.find('\n'); + while (lineBreak

[PATCH] D61809: [BPF] Preserve debuginfo array/union/struct type/access index

yonghong-song updated this revision to Diff 207475. yonghong-song added a comment. reword the lang doc for builtin_preserve_access_index() to be more user focused treat using builtin_preserve_access_index() without -g or in nested way as compiler errors Repository: rC Clang CHANGES SINCE LAS

[PATCH] D56650: [lld] [ELF] Support customizing behavior on target triple

MaskRay requested changes to this revision. MaskRay added a comment. > krytarowski: The discussion is ongoing since 2017 and we have an impasse. > >> peter.smith: I think this might be better raised on lllvm-dev as I suspect >> that we need to give this wider visibility. I'm not totally opposed

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

MaskRay added a comment. This patch makes sense to me. It can benefit other OS/environment as well. Comment at: lld/ELF/Driver.cpp:357 + + // default + return GnuStackKind::NoExec; This is obvious. The comment can be removed. CHANGES SINCE LAST ACTION htt

[PATCH] D59254: [RFC] Implementation of Clang randstruct

connorkuehl added a comment. In D59254#1565961 , @jfb wrote: > Do you intend on moving this forward? It seems like a Good Thing overall, and > I'd love to help review some more. Yes. I'm sorry it's been in limbo so long. I haven't touched base with the

[PATCH] D64058: [cxx2a] P0624R2 fix: only lambdas with no lambda-capture are default-constructible and assignable.

logan-5 created this revision. logan-5 added reviewers: rsmith, dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a fix for rG864949 which only disabled default construction and assignment for lambdas with capture-defaults, where the C++2a draft disables th

[PATCH] D59254: [RFC] Implementation of Clang randstruct

jfb added a comment. Do you intend on moving this forward? It seems like a Good Thing overall, and I'd love to help review some more. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59254/new/ https://reviews.llvm.org/D59254 _

[PATCH] D62888: [NewPM] Port Sancov

chandlerc added a comment. The used thing still seems like there is an underlynig bug here. See below. (Also a tiny nit, but that isn't the interesting part.) Comment at: llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp:206 + +std::string getSectionStart(const Triple

[PATCH] D62888: [NewPM] Port Sancov

leonardchan added a comment. ping @chandlerc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62888/new/ https://reviews.llvm.org/D62888 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D64056: [analyzer] exploded-graph-rewriter: Implement a dark color scheme.

This revision was automatically updated to reflect the committed changes. Closed by commit rL364882: [analyzer] exploded-graph-rewriter: Implement a dark color scheme. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to c

[PATCH] D64051: [analyzer] exploded-graph-rewriter: Improve program point dumps.

This revision was automatically updated to reflect the committed changes. Closed by commit rL364881: [analyzer] exploded-graph-rewriter: Improve program point dumps. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

[PATCH] D64047: [analyzer] exploded-graph-rewriter: Add support for objects under construction.

This revision was automatically updated to reflect the committed changes. Closed by commit rL364880: [analyzer] exploded-graph-rewriter: Add support for objects under construction. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chang

r364882 - [analyzer] exploded-graph-rewriter: Implement a dark color scheme.

Author: dergachev Date: Mon Jul 1 19:17:56 2019 New Revision: 364882 URL: http://llvm.org/viewvc/llvm-project?rev=364882&view=rev Log: [analyzer] exploded-graph-rewriter: Implement a dark color scheme. Addresses a popular request. Activated via --dark. Differential Revision: https://reviews.llv

r364881 - [analyzer] exploded-graph-rewriter: Improve program point dumps.

Author: dergachev Date: Mon Jul 1 19:17:53 2019 New Revision: 364881 URL: http://llvm.org/viewvc/llvm-project?rev=364881&view=rev Log: [analyzer] exploded-graph-rewriter: Improve program point dumps. - Take advantage of the stmt_point_kind. - Dump block IDs for BlockEntrance nodes. - Don't dump

r364880 - [analyzer] exploded-graph-rewriter: Add support for objects under construction.

Author: dergachev Date: Mon Jul 1 19:17:50 2019 New Revision: 364880 URL: http://llvm.org/viewvc/llvm-project?rev=364880&view=rev Log: [analyzer] exploded-graph-rewriter: Add support for objects under construction. This trait is Environment-like, so there was a chance to re-use a lot of code. D

[PATCH] D63503: cmake: Add CLANG_LINK_CLANG_DYLIB option

tstellar added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63503/new/ https://reviews.llvm.org/D63503 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D64056: [analyzer] exploded-graph-rewriter: Implement a dark color scheme.

NoQ updated this revision to Diff 207462. NoQ added a comment. Softer background color. F9446167: Screen Shot 2019-07-01 at 7.02.51 PM.png CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64056/new/ https://reviews.llvm.org/D64056 Files: clang/test/

[PATCH] D64056: [analyzer] exploded-graph-rewriter: Implement a dark color scheme.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. I really like that, thanks you! When you spend tons of time it is good for your eyes and that dark theme is very cool in 2019. Comment at: clang/utils/analyzer/exploded-

[PATCH] D64056: [analyzer] exploded-graph-rewriter: Implement a dark color scheme.

NoQ updated this revision to Diff 207461. NoQ added a comment. Unforget a test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64056/new/ https://reviews.llvm.org/D64056 Files: clang/test/Analysis/exploded-graph-rewriter/edge.dot clang/test/Analysis/exploded-graph-rewriter/empty.dot

[PATCH] D64051: [analyzer] exploded-graph-rewriter: Improve program point dumps.

NoQ added a comment. In D64051#1565806 , @Charusso wrote: > I like the idea about color tones, it is great we have a huge palette, just I > still feels like it pretty well made for a dark theme. > Are you sure about the white background? Okay. D64056 <

[PATCH] D64056: [analyzer] exploded-graph-rewriter: Implement a dark color scheme.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet. Herald added a project: clang. **`$ utils/analyzer/exploded-graph-rew

[PATCH] D63915: [analyzer] ReturnValueChecker: Model the guaranteed boolean return value of function calls

Charusso updated this revision to Diff 207458. Charusso added a comment. - I do not like `Optional` anymore. - More simple notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63915/new/ https://reviews.llvm.org/D63915 Files: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td

[PATCH] D63915: [analyzer] ReturnValueChecker: Model the guaranteed boolean return value of function calls

Charusso marked 2 inline comments as done. Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ReturnValueChecker.cpp:82 + +Out << '\'' << Name << "' always returns " +<< (*Value ? "true" : "false"); NoQ wrote: > Char

[PATCH] D63915: [analyzer] ReturnValueChecker: Model the guaranteed boolean return value of function calls

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ReturnValueChecker.cpp:82 + +Out << '\'' << Name << "' always returns " +<< (*Value ? "true" : "false"); Charusso wrote: > NoQ wrote: > > Let's mention the class name as

[PATCH] D63915: [analyzer] ReturnValueChecker: Model the guaranteed boolean return value of function calls

Charusso updated this revision to Diff 207456. Charusso marked 11 inline comments as done. Charusso added a comment. - Fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63915/new/ https://reviews.llvm.org/D63915 Files: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td clang/

[PATCH] D63915: [analyzer] ReturnValueChecker: Model the guaranteed boolean return value of function calls

Charusso added a comment. In D63915#1563049 , @NoQ wrote: > Aha, nice, thanks for adding a description, it is a very good thing to do. > Like, every commit should be obvious. In some of my patches I have not added a description because they are so tiny

[PATCH] D64047: [analyzer] exploded-graph-rewriter: Add support for objects under construction.

Charusso accepted this revision. Charusso marked an inline comment as done. Charusso added a comment. Thanks for testing it! Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:76 +self.stmt_id = json_ek['stmt_id'] if 'stmt_id' in json_ek \ +else jso

[PATCH] D64047: [analyzer] exploded-graph-rewriter: Add support for objects under construction.

NoQ updated this revision to Diff 207448. NoQ added a comment. No longer crashes on seeing `CXXCtorInitializer`s. Test added. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64047/new/ https://reviews.llvm.org/D64047 Files: clang/test/Analysis/exploded-graph-rewriter/constraints.dot

[PATCH] D64051: [analyzer] exploded-graph-rewriter: Improve program point dumps.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. Are you alright with the namings? Those are randomly came out from my head and may you know some better one. I like the idea about color tones, it is great we have a huge palette, just I

[PATCH] D64051: [analyzer] exploded-graph-rewriter: Improve program point dumps.

NoQ added a comment. Ugly compound statement dumps that have been prevented: F9445982: Screen Shot 2019-07-01 at 5.52.51 PM.png Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64051/new/ https://reviews.llvm.org/D64051 _

[PATCH] D64051: [analyzer] exploded-graph-rewriter: Improve program point dumps.

NoQ created this revision. NoQ added a reviewer: Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. - Take advantage of the stmt_point_kind. - Dump block IDs for BlockEnt

[PATCH] D64048: [TargetParser][ARM] Account dependencies when processing target features

labrinea created this revision. labrinea added reviewers: llvm-commits, ostannard. Herald added subscribers: cfe-commits, dmgreen, hiraditya, kristof.beyls, javed.absar. Herald added projects: clang, LLVM. Teaches `ARM::appendArchExtFeatures` to account dependencies when processing target featur

[PATCH] D64047: [analyzer] exploded-graph-rewriter: Add support for objects under construction.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. SSS! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64047/new/ https://reviews.llvm.org/D64047 ___ cfe-commit

[PATCH] D64047: [analyzer] exploded-graph-rewriter: Add support for objects under construction.

NoQ created this revision. NoQ added a reviewer: Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. This trait is Environment-like, so there was a chance to re-use a lot

[PATCH] D64030: [analyzer] Support kfree in MallocChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rL364875: [analyzer] Support kfree in MallocChecker (authored by Nathan-Huckleberry, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

r364875 - [analyzer] Support kfree in MallocChecker

Author: nathan-huckleberry Date: Mon Jul 1 16:29:10 2019 New Revision: 364875 URL: http://llvm.org/viewvc/llvm-project?rev=364875&view=rev Log: [analyzer] Support kfree in MallocChecker Summary: kmalloc is freed with kfree in the linux kernel. kmalloc support was added in r204832, but kfree was

[PATCH] D63936: [clang][Driver][ARM] Favor -mfpu over default CPU features

labrinea updated this revision to Diff 207436. labrinea added a comment. I've split the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63936/new/ https://reviews.llvm.org/D63936 Files: clang/lib/Driver/ToolChains/Arch/ARM.cpp clang/test/

Re: [PATCH] D61909: Add Clang shared library with C++ exports

The question is, what *should* it be called. While yes, the 's' in 'so' is shared, the "dylib" and "dll" extensions on Darwin and Windows have the same meaning too. The problem is libclang.so is already taken. I'm not attached to the name in any way, so I'm open to suggestions. We do have docu

[PATCH] D61909: Add Clang shared library with C++ exports

tstellar added a comment. In D61909#1563678 , @sylvestre.ledru wrote: > For now, it isn't part of the debian packaging. > > https://salsa.debian.org/pkg-llvm-team/llvm-toolchain/blob/snapshot/debian/rules#L563 > it is removed as packaging phase as I ha

r364871 - [analyzer] exploded-graph-rewriter: NFC: Add a forgotten test file.

Author: dergachev Date: Mon Jul 1 16:06:08 2019 New Revision: 364871 URL: http://llvm.org/viewvc/llvm-project?rev=364871&view=rev Log: [analyzer] exploded-graph-rewriter: NFC: Add a forgotten test file. This fell off of r364865. Added: cfe/trunk/test/Analysis/exploded-graph-rewriter/dynamic

[PATCH] D63968: [analyzer] Fix target region invalidation when returning into a ctor initializer.

This revision was automatically updated to reflect the committed changes. Closed by commit rL364870: [analyzer] Fix invalidation when returning into a ctor initializer. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1565632 , @jfb wrote: > In D60974#1565621 , @plotfi wrote: > > > In D60974#1565577 , @jfb wrote: > > > > > Looking at the code quickly, I'm

[PATCH] D64041: [analyzer] exploded-graph-rewriter: Add support for dynamic types.

NoQ added a comment. rC364871 . Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64041/new/ https://reviews.llvm.org/D64041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D62557: [analyzer] Modernize CStringChecker to use CallDescriptions.

This revision was automatically updated to reflect the committed changes. Closed by commit rL364868: [analyzer] CStringChecker: Modernize to use CallDescriptions. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit

[PATCH] D63956: [analyzer] NonnullGlobalConstants: Don't be confused with a _Nonnull attribute.

This revision was automatically updated to reflect the committed changes. Closed by commit rL364869: [analyzer] NonnullGlobalConstants: Don't be confused by a _Nonnull attribute. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D62556: [analyzer] NFC: CallDescription: Implement describing C library functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rL364867: [analyzer] NFC: CallDescription: Implement describing C library functions. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pr

[PATCH] D62441: [analyzer] NFC: Introduce a convenient CallDescriptionMap class.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL364866: [analyzer] NFC: Add a convenient CallDescriptionMap class. (authored by dergachev, committed by ). Herald added a

[PATCH] D64041: [analyzer] exploded-graph-rewriter: Add support for dynamic types.

This revision was automatically updated to reflect the committed changes. Closed by commit rL364865: [analyzer] exploded-graph-rewriter: Add support for dynamic types. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to c

[PATCH] D64041: [analyzer] exploded-graph-rewriter: Add support for dynamic types.

NoQ added a comment. Ugh, forgot to `git add` the actual test. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64041/new/ https://reviews.llvm.org/D64041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D63965: [analyzer] exploded-graph-rewriter: Add support for program point tags.

This revision was automatically updated to reflect the committed changes. Closed by commit rL364864: [analyzer] exploded-graph-rewriter: Implement program point tags. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to co

[PATCH] D64041: [analyzer] exploded-graph-rewriter: Add support for dynamic types.

NoQ updated this revision to Diff 207427. NoQ added a comment. Remove the TODO. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64041/new/ https://reviews.llvm.org/D64041 Files: clang/test/Analysis/exploded-graph-rewriter/constraints.dot clang/test/Analysis/exploded-graph-rewriter/co

[PATCH] D51262: Implement P0553 and P0556

mclow.lists closed this revision. mclow.lists added a comment. Committed as revision 364862 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51262/new/ https://reviews.llvm.org/D51262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

r364867 - [analyzer] NFC: CallDescription: Implement describing C library functions.

Author: dergachev Date: Mon Jul 1 16:02:07 2019 New Revision: 364867 URL: http://llvm.org/viewvc/llvm-project?rev=364867&view=rev Log: [analyzer] NFC: CallDescription: Implement describing C library functions. When matching C standard library functions in the checker, it's easy to forget that th

r364866 - [analyzer] NFC: Add a convenient CallDescriptionMap class.

Author: dergachev Date: Mon Jul 1 16:02:03 2019 New Revision: 364866 URL: http://llvm.org/viewvc/llvm-project?rev=364866&view=rev Log: [analyzer] NFC: Add a convenient CallDescriptionMap class. It encapsulates the procedure of figuring out whether a call event corresponds to a function that's mo

r364869 - [analyzer] NonnullGlobalConstants: Don't be confused by a _Nonnull attribute.

Author: dergachev Date: Mon Jul 1 16:02:14 2019 New Revision: 364869 URL: http://llvm.org/viewvc/llvm-project?rev=364869&view=rev Log: [analyzer] NonnullGlobalConstants: Don't be confused by a _Nonnull attribute. The NonnullGlobalConstants checker models the rule "it doesn't make sense to make a

r364870 - [analyzer] Fix invalidation when returning into a ctor initializer.

Author: dergachev Date: Mon Jul 1 16:02:18 2019 New Revision: 364870 URL: http://llvm.org/viewvc/llvm-project?rev=364870&view=rev Log: [analyzer] Fix invalidation when returning into a ctor initializer. Due to RVO the target region of a function that returns an object by value isn't necessarily

r364865 - [analyzer] exploded-graph-rewriter: Add support for dynamic types.

Author: dergachev Date: Mon Jul 1 16:01:59 2019 New Revision: 364865 URL: http://llvm.org/viewvc/llvm-project?rev=364865&view=rev Log: [analyzer] exploded-graph-rewriter: Add support for dynamic types. Slightly cleanup emission of horizontal lines and unhardcode the title for generic maps. Diff

r364868 - [analyzer] CStringChecker: Modernize to use CallDescriptions.

Author: dergachev Date: Mon Jul 1 16:02:10 2019 New Revision: 364868 URL: http://llvm.org/viewvc/llvm-project?rev=364868&view=rev Log: [analyzer] CStringChecker: Modernize to use CallDescriptions. This patch uses the new CDF_MaybeBuiltin flag to handle C library functions. It's mostly an NFC/ref

r364864 - [analyzer] exploded-graph-rewriter: Implement program point tags.

Author: dergachev Date: Mon Jul 1 16:01:55 2019 New Revision: 364864 URL: http://llvm.org/viewvc/llvm-project?rev=364864&view=rev Log: [analyzer] exploded-graph-rewriter: Implement program point tags. Keep them on a separate line for more visibility. Differential Revision: https://reviews.llvm.

[PATCH] D60974: Clang IFSO driver action.

jfb added subscribers: arphaman, ributzka, Bigcheese. jfb added a comment. In D60974#1565621 , @plotfi wrote: > In D60974#1565577 , @jfb wrote: > > > Looking at the code quickly, I'm not sure that this should be in

[PATCH] D64044: [clang][Driver][ARM] NFC: Remove unused function parameter

labrinea created this revision. labrinea added reviewers: ostannard, simon_tatham, cfe-commits. Herald added subscribers: kristof.beyls, javed.absar. Herald added a project: clang. Removes a vector reference that was added by D62998 , since the preexisting functio

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1565577 , @jfb wrote: > Looking at the code quickly, I'm not sure that this should be in clang > itself. It sounds like a better fit for a clang-based tool, and not clang. > Why does it need to be part of clang? @jfb I

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1565570 , @bruno wrote: > > I am currently working on the next part of clang interface stubs that will > > take the interface stubs per compilation unit and merge them into one text > > stub (which will be used by someth

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1565577 , @jfb wrote: > Looking at the code quickly, I'm not sure that this should be in clang > itself. It sounds like a better fit for a clang-based tool, and not clang. > Why does it need to be part of clang? In D

[PATCH] D51262: Implement P0553 and P0556

EricWF accepted this revision. EricWF added inline comments. This revision is now accepted and ready to land. Comment at: libcxx/include/bit:240 +else if constexpr (sizeof(_Tp) <= sizeof(unsigned long)) +return __clz(static_cast(__t)) + - (numeric_limits:

[PATCH] D64030: [analyzer] Support kfree in MallocChecker

Szelethus accepted this revision. Szelethus added a comment. Nice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64030/new/ https://reviews.llvm.org/D64030 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D64041: [analyzer] exploded-graph-rewriter: Add support for dynamic types.

NoQ updated this revision to Diff 207420. NoQ added a comment. Bring back a few forgotten ``s. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64041/new/ https://reviews.llvm.org/D64041 Files: clang/test/Analysis/exploded-graph-rewriter/constraints.dot clang/test/Analysis/exploded-gr

[PATCH] D60974: Clang IFSO driver action.

jfb added a comment. Looking at the code quickly, I'm not sure that this should be in clang itself. It sounds like a better fit for a clang-based tool, and not clang. Why does it need to be part of clang? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D64041: [analyzer] exploded-graph-rewriter: Add support for dynamic types.

Charusso accepted this revision. Charusso marked an inline comment as done. Charusso added a comment. This revision is now accepted and ready to land. Nice, the end of that huge work is getting closer. Thanks! Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:229 +

[PATCH] D60974: Clang IFSO driver action.

bruno added a comment. > I am currently working on the next part of clang interface stubs that will > take the interface stubs per compilation unit and merge them into one text > stub (which will be used by something like llvm-elfabi to generate a stubbed > out ELF .so file). I was using llvm

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1565544 , @jfb wrote: > In D60974#1565541 , @plotfi wrote: > > > In D60974#1565527 , @jfb wrote: > > > > > In D60974#1565517

[PATCH] D64041: [analyzer] exploded-graph-rewriter: Add support for dynamic types.

NoQ created this revision. NoQ added a reviewer: Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Slightly cleanup emission of ``s and unhardcode the title for generic

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. @ymandel @jfb Thanks for reaching out on this. Apologies for missing this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 ___ cfe-c

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1565544 , @jfb wrote: > In D60974#1565541 , @plotfi wrote: > > > In D60974#1565527 , @jfb wrote: > > > > > In D60974#1565517

[PATCH] D60974: Clang IFSO driver action.

jfb added a comment. In D60974#1565541 , @plotfi wrote: > In D60974#1565527 , @jfb wrote: > > > In D60974#1565517 , @jfb wrote: > > > > > In D60974#1565054

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1565527 , @jfb wrote: > In D60974#1565517 , @jfb wrote: > > > In D60974#1565054 , @plotfi wrote: > > > > > So I think I know what may be goi

[PATCH] D60974: Clang IFSO driver action.

jfb added a comment. In D60974#1565517 , @jfb wrote: > In D60974#1565054 , @plotfi wrote: > > > So I think I know what may be going on on your end. The llvm-readelf in > > your path I believe might be the wrong lll

[PATCH] D60974: Clang IFSO driver action.

jfb added a comment. In D60974#1565054 , @plotfi wrote: > So I think I know what may be going on on your end. The llvm-readelf in your > path I believe might be the wrong lllvm-readelf (llvm-readelf-7). Are you > sure you built llvm-readelf from git? P

r364855 - Fix breakage introduced by D60974

Author: jfb Date: Mon Jul 1 14:57:31 2019 New Revision: 364855 URL: http://llvm.org/viewvc/llvm-project?rev=364855&view=rev Log: Fix breakage introduced by D60974 D60974 added tests which incorrectly assume that llvm-readelf is available. This is a bad assumption, it should instead declare the

[PATCH] D63943: ObjC: Squeeze in one more bit for the count of protocols in 'id' types

jordan_rose added a comment. Yeah, I'll write one. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63943/new/ https://reviews.llvm.org/D63943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D63943: ObjC: Squeeze in one more bit for the count of protocols in 'id' types

jfb added a comment. DO you have a test for that many protocols? That way when we add a diagnostic we know it won't fail. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63943/new/ https://reviews.llvm.org/D63943 ___

[PATCH] D63753: [Sema] Instead of rejecting C unions with non-trivial fields, detect attempts to destruct/initialize/copy them.

rjmccall added inline comments. Comment at: lib/Sema/SemaExpr.cpp:16218 +checkNonTrivialCUnion(E->getType(), E->getExprLoc(), + Sema::NTCUC_LValueToRValueVolatile); + ahatanak wrote: > rjmccall wrote: > > ahatanak wrote: > > > rjmccal

[PATCH] D62557: [analyzer] Modernize CStringChecker to use CallDescriptions.

NoQ updated this revision to Diff 207407. NoQ added a comment. Remove more dead code!~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62557/new/ https://reviews.llvm.org/D62557 Files: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp clang/test/Analysis/string.c Index: clang/tes

[PATCH] D62556: [analyzer] NFC: CallDescription: Implement describing C library functions.

NoQ updated this revision to Diff 207406. NoQ added a comment. Rebase! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62556/new/ https://reviews.llvm.org/D62556 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h clang/lib/StaticAnalyzer/Core/CallEvent.cpp cla

[PATCH] D59922: [Attributor] Deduce "no-capture" argument attribute

jdoerfert added a comment. @hfinkel ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59922/new/ https://reviews.llvm.org/D59922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D64034: [c++] Implement categorizing pointer-to-bool as narrowing conversions

lichray created this revision. lichray added reviewers: rsmith, EricWF. lichray added a project: clang. Herald added a subscriber: cfe-commits. This change implements an upcoming Core issue to categorize boolean conversions from pointer and pointer-to-member as (always) narrowing conversion (you

[PATCH] D63915: [analyzer] ReturnValueChecker: Model the guaranteed boolean return value of function calls

NoQ added inline comments. Comment at: clang/unittests/StaticAnalyzer/CallDescriptionTest.cpp:36 -const bool *LookupResult = CDM.lookup(*Call); +Optional LookupResult = CDM.lookup(*Call); // Check that we've found the function in the map I updated

[PATCH] D62441: [analyzer] NFC: Introduce a convenient CallDescriptionMap class.

NoQ updated this revision to Diff 207403. NoQ marked 5 inline comments as done. NoQ added a comment. Address comments. Improve the tests so that they failed when not all requested functions were found - it's pretty crude as it only checks that the number of hits is correct, but, i guess, that's

[PATCH] D62441: [analyzer] NFC: Introduce a convenient CallDescriptionMap class.

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:1060 +public: + const static unsigned NoArgRequirement = std::numeric_limits::max(); + Charusso wrote: > What about `Optional<>`? When I first met that fun

[PATCH] D60974: Clang IFSO driver action.

ymandel added a comment. `ninja install` did the trick. Thanks for your help! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 ___ cfe-commits mailing list cfe-

[PATCH] D51262: Implement P0553 and P0556

mclow.lists marked 2 inline comments as done. mclow.lists added inline comments. Comment at: libcxx/include/bit:203 +template +inline _LIBCPP_INLINE_VISIBILITY constexpr +enable_if_t<__bitop_unsigned_integer<_Tp>::value, _Tp> EricWF wrote: > Why the explicit inli

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

rjmccall added inline comments. Comment at: include/llvm/IR/IRBuilder.h:259 +return DefaultConstrainedRounding.getValue(); + } + kpn wrote: > rjmccall wrote: > > Okay, so what are the invariants here now? It looks like, in order to > > enable constrained f

[PATCH] D63623: [clang-tidy] new check: bugprone-posix-return

jcai19 updated this revision to Diff 207401. jcai19 added a comment. Update CHECK-MESSAGES messages accordingly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63623/new/ https://reviews.llvm.org/D63623 Files: clang-tools-extra/clang-tidy/bugpron

[PATCH] D63623: [clang-tidy] new check: bugprone-posix-return

gribozavr accepted this revision. gribozavr added a comment. Thanks! Do you have commit access? Do you want me to commit this patch for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63623/new/ https://reviews.llvm.org/D63623 ___

[PATCH] D63954: Add lifetime categories attributes

mgehre updated this revision to Diff 207400. mgehre added a comment. - Add newline at end of file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63954/new/ https://reviews.llvm.org/D63954 Files: clang/include/clang/Basic/Attr.td clang/include/c

[PATCH] D63623: [clang-tidy] new check: bugprone-posix-return

jcai19 updated this revision to Diff 207398. jcai19 marked 2 inline comments as done. jcai19 added a comment. Update warning messages. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63623/new/ https://reviews.llvm.org/D63623 Files: clang-tools-ex

[PATCH] D63623: [clang-tidy] new check: bugprone-posix-return

jcai19 updated this revision to Diff 207397. jcai19 added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63623/new/ https://reviews.llvm.org/D63623 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp clan

  1   2   3   >