[PATCH] D64608: [OpenCL] Make TableGen'd builtin tables and helper functions static

Pierre added a comment. Hello Tom, Thank you for adding me, the changes seem correct to me. There is a new version of the tablegen builtin functions that makes these tables static/const. It still needs some work, so I thing it's relevant to make this change in the meantime : https://reviews.llv

[PATCH] D64613: [clangd] Type hierarchy: don't resolve parents if the client only asked for children

kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1238 Optional Result = - getTypeAncestors(*CXXRD, AST.getASTContext(), RPSet); + getTypeAncestors(*CXXRD, AST.getASTContext(), RPSet, ResolveParents); if (!Result) havi

[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

sbc100 added a comment. I wonder if `__tls_base` should be allocated by the embedder (or by the parent/creator thread). Then it could be an *immutable* global import that is allocated up front. I guess `__stack_pointer` should be treated in the same way (except mutable). I don't want to bl

[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

sbc100 added a comment. Its really great to see this change BTW! Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64537/new/ https://reviews.llvm.org/D64537 ___ cfe-commits mailing list cfe-commi

[PATCH] D64617: [clangd] Added highlighting for members and methods

jvikstrom created this revision. jvikstrom added reviewers: hokein, sammccall, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Added highlighting for members and methods. Repository: rG LLVM Github Monorepo https://rev

[PATCH] D64565: [clangd] Don't run the prepare for tweaks that are disabled.

hokein updated this revision to Diff 209429. hokein added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64565/new/ https://reviews.llvm.org/D64565 Files: clang-tools-extra/clangd/ClangdServer.cpp clang-tools-extra/

[clang-tools-extra] r365882 - [clangd] Don't run the prepare for tweaks that are disabled.

Author: hokein Date: Fri Jul 12 01:50:20 2019 New Revision: 365882 URL: http://llvm.org/viewvc/llvm-project?rev=365882&view=rev Log: [clangd] Don't run the prepare for tweaks that are disabled. Summary: Previously, we ran the prepare, even for the tweaks that are disabled. Reviewers: sammccall

[PATCH] D64565: [clangd] Don't run the prepare for tweaks that are disabled.

This revision was automatically updated to reflect the committed changes. Closed by commit rL365882: [clangd] Don't run the prepare for tweaks that are disabled. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

Re: r365825 - [clang-shlib] Fix clang-shlib for PRIVATE dependencies

On Thu, 11 Jul 2019 at 22:20, Shoaib Meenai via cfe-commits wrote: > > Author: smeenai > Date: Thu Jul 11 14:20:38 2019 > New Revision: 365825 > > URL: http://llvm.org/viewvc/llvm-project?rev=365825&view=rev > Log: > [clang-shlib] Fix clang-shlib for PRIVATE dependencies > > Any static library wit

[PATCH] D64448: gsl::Owner/gsl::Pointer: Add implicit annotations for some std types

gribozavr added a comment. In D64448#1581866 , @mgehre wrote: > I didn't know whether they would differ, but the test tells me that they > don't differ significantly (i.e. in introducing new techniques). Okay -- I would prefer if you intentionally looke

[PATCH] D64554: [CrossTU] Add a function to retrieve original source location.

martong added a comment. > This patch can be treated as part of a bigger change that is needed to > improve macro expansion handliong at plist generation. @balazske Could you please prepare the upcoming patch and put that on the Stack. I think that may ease the work of the reviewers if they cou

[PATCH] D64614: [clangd] Mark type hierarchy as a supported feature in the docs

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/docs/clangd/Features.rst:264 +-++--+ -| Type hierarchy |

[PATCH] D64617: [clangd] Added highlighting for members and methods

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG from my side Comment at: clang-tools-extra/clangd/SemanticHighlighting.h:28 Variable = 0, + MemberVariable, Function, nit: clang calls these

[clang-tools-extra] r365885 - [clangd] Move the expandAuto tweak from global namespace into annoymous namespace.

Author: hokein Date: Fri Jul 12 02:38:53 2019 New Revision: 365885 URL: http://llvm.org/viewvc/llvm-project?rev=365885&view=rev Log: [clangd] Move the expandAuto tweak from global namespace into annoymous namespace. Modified: clang-tools-extra/trunk/clangd/refactor/tweaks/ExpandAutoType.cpp

[PATCH] D64617: [clangd] Added highlighting for members and methods

hokein added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:44 + bool VisitMemberExpr(MemberExpr *ME) { +if (const CXXMethodDecl *MD = +dyn_cast(ME->getMemberDecl())) { nit: this can be simplified like ``` if (co

[PATCH] D64624: [clangd] Added highlighting to enum constants.

jvikstrom created this revision. jvikstrom added reviewers: hokein, sammccall, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. VSCode does not have a scope for enum constants. So they were placed under "constant.other.enum

[PATCH] D64624: [clangd] Added highlighting to enum constants.

hokein added a comment. mostly good. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:122 } +if(isa(D)) { + addToken(Loc, HighlightingKind::EnumConstant); nit: clang-format. Comment at: clang-tools-extra/clangd/Sema

[PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

martong added a comment. @shafik @jingham This is a polite Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61333/new/ https://reviews.llvm.org/D61333 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D64562: [clangd] Fixed toHalfOpenFileRange

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/SourceCode.cpp:261 + if (!Lexer::getRawToken(Loc, TheTok, SM, LangOpts)) { +if (TheTok.is(tok::greatergreater)) + ret

r365887 - [JSONCompilationDatabase] Strip distcc/ccache/gomacc wrappers from parsed commands.

Author: sammccall Date: Fri Jul 12 03:11:40 2019 New Revision: 365887 URL: http://llvm.org/viewvc/llvm-project?rev=365887&view=rev Log: [JSONCompilationDatabase] Strip distcc/ccache/gomacc wrappers from parsed commands. Summary: It's common to use compiler wrappers by setting CC="gomacc clang++"

[clang-tools-extra] r365888 - [clangd] Prioritize indexing of files that share a basename with the open file.

Author: sammccall Date: Fri Jul 12 03:18:42 2019 New Revision: 365888 URL: http://llvm.org/viewvc/llvm-project?rev=365888&view=rev Log: [clangd] Prioritize indexing of files that share a basename with the open file. Summary: In practice, opening Foo.h will still often result in Foo.cpp making the

[PATCH] D62888: [NewPM] Port Sancov

abrachet marked an inline comment as done. abrachet added inline comments. Comment at: llvm/trunk/lib/Transforms/Instrumentation/SanitizerCoverage.cpp:1022-1026 +SanitizerCoverage::getSectionStart(const std::string &Section) const { + return getSectionStartImpl(TargetTriple, Se

[PATCH] D64627: [clangd] Suppress unwritten scopes when expanding auto.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. otherwise the replacement will break the code. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64627 F

[PATCH] D64628: [CrossTU] Test change only: improve ctu-main.c

balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp. Herald added a project: clang. New lines are added to test ctu-main.c to make code execute when a function with invalid source range is encountered on bug path with NoStoreFuncVisitor. Repository

[PATCH] D64083: [OpenCL][Sema] Improve address space support for blocks

Anastasia added inline comments. Comment at: cfe/trunk/lib/Sema/SemaExprCXX.cpp:4229 +LangAS AddrSpaceR = +RHSType->getAs()->getPointeeType().getAddressSpace(); +CastKind Kind = rjmccall wrote: > Anastasia wrote: > > rjmccall wrote: > > > Anastasi

[PATCH] D64083: [OpenCL][Sema] Improve address space support for blocks

mantognini marked 2 inline comments as done. mantognini added inline comments. Comment at: cfe/trunk/lib/Sema/SemaExprCXX.cpp:4229 +LangAS AddrSpaceR = +RHSType->getAs()->getPointeeType().getAddressSpace(); +CastKind Kind = Anastasia wrote: > rjmc

[clang-tools-extra] r365894 - [clangd] Fixed toHalfOpenFileRange

Author: sureyeaah Date: Fri Jul 12 04:42:31 2019 New Revision: 365894 URL: http://llvm.org/viewvc/llvm-project?rev=365894&view=rev Log: [clangd] Fixed toHalfOpenFileRange Summary: - Fixed toHalfOpenFileRange to work for macros as well as template instantiations - Added unit tests Breaking test c

[PATCH] D64562: [clangd] Fixed toHalfOpenFileRange

This revision was automatically updated to reflect the committed changes. Closed by commit rL365894: [clangd] Fixed toHalfOpenFileRange (authored by SureYeaah, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.or

[PATCH] D64569: [OpenCL] Improve destructor support in C++ for OpenCL

Anastasia added inline comments. Comment at: clang/lib/CodeGen/CGExprCXX.cpp:117-118 + llvm::Type *NewType = CGM.getTypes().ConvertType(DstTy); + This = getTargetHooks().performAddrSpaceCast(*this, This, SrcAS, DstAS, +

[PATCH] D62413: [OpenCL][PR41727] Prevent ICE on global dtors

Anastasia updated this revision to Diff 209463. Anastasia added a comment. Generate NULL for pointer param of __cxa_atexit on mismatching addr spaces CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62413/new/ https://reviews.llvm.org/D62413 Files: lib/CodeGen/CGDeclCXX.cpp lib/CodeGe

[PATCH] D62413: [OpenCL][PR41727] Prevent ICE on global dtors

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/CodeGen/CGDeclCXX.cpp:132 + Argument = CGM.getTargetCodeGenInfo().performAddrSpaceCast( + CGM, Addr.getPointer(), SrcAS, LangAS::opencl_global, DestTy); r

Re: [clang-tools-extra] r365867 - [clangd] Implement typeHierarchy/resolve for subtypes

Hi Nathan, This is causing a test failure on Windows: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/26909 Please can you take a look? Thanks Russ [ RUN ] Subtypes.LazyResolution Preamble for file C:\clangd-test\TestTU.cpp cannot be reused. Attempt

[PATCH] D64563: Updated the signature for some stack related intrinsics (CLANG)

cdevadas updated this revision to Diff 209467. cdevadas added a comment. Added alloca address space. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64563/new/ https://reviews.llvm.org/D64563 Files: lib/CodeGen/CGBuiltin.cpp lib/CodeGen/CGException.cpp test/CodeGen/builtin-sponentr

[PATCH] D64062: Remove both -dumpversion and __VERSION__

sylvestre.ledru updated this revision to Diff 209473. sylvestre.ledru added a comment. Keep -dumpversion Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64062/new/ https://reviews.llvm.org/D64062 Files: docs/ClangCommandLineReference.rst docs/LanguageExtension

[PATCH] D64062: Remove both -dumpversion and __VERSION__

sylvestre.ledru updated this revision to Diff 209474. sylvestre.ledru added a comment. Actually remove it Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64062/new/ https://reviews.llvm.org/D64062 Files: docs/LanguageExtensions.rst docs/ReleaseNotes.rst lib/

r365898 - [Driver] Delete dead code

Author: maskray Date: Fri Jul 12 06:21:58 2019 New Revision: 365898 URL: http://llvm.org/viewvc/llvm-project?rev=365898&view=rev Log: [Driver] Delete dead code Modified: cfe/trunk/lib/Driver/ToolChains/Arch/Mips.cpp cfe/trunk/lib/Driver/ToolChains/Clang.cpp Modified: cfe/trunk/lib/Driver

[clang-tools-extra] r365899 - Revert "[clangd] Implement typeHierarchy/resolve for subtypes"

Author: russell_gallop Date: Fri Jul 12 06:35:58 2019 New Revision: 365899 URL: http://llvm.org/viewvc/llvm-project?rev=365899&view=rev Log: Revert "[clangd] Implement typeHierarchy/resolve for subtypes" Causing test failure on Windows bot This reverts commit 5b9484e559d44bd923fc290e335891b1dd2e

[PATCH] D56563: [clang-tidy] add options documentation to readability-identifier-naming checker

lebedev.ri added a comment. Herald added a project: LLVM. Is this doc supposed to be autogenerated somehow? I believe `MacroDefinitionCase` (D21020 ) is missing from it, maybe others. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5

[PATCH] D64062: Remove __VERSION__

sylvestre.ledru added a comment. @rnk Should be good this time :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64062/new/ https://reviews.llvm.org/D64062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier

rkgibson2 created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64632 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTest.cpp Index: clang/unittests/Format/Forma

r365901 - Delete dead stores

Author: maskray Date: Fri Jul 12 07:04:34 2019 New Revision: 365901 URL: http://llvm.org/viewvc/llvm-project?rev=365901&view=rev Log: Delete dead stores Modified: cfe/trunk/lib/CodeGen/CGCoroutine.cpp cfe/trunk/lib/Lex/Lexer.cpp cfe/trunk/lib/Sema/SemaDecl.cpp cfe/trunk/lib/Static

[PATCH] D64634: [clangd] Fix duplicate highlighting tokens appearing in initializer lists

jvikstrom created this revision. jvikstrom added reviewers: hokein, sammccall, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, mgrang, jkorous, MaskRay. Herald added a project: clang. The RecursiveASTVisitor sometimes visits exprs in initializer lists twice. Added dedup

[PATCH] D64635: [CrossTU] Added CTU argument to diagnostic consumer create fn.

balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp. Herald added a project: clang. The PListDiagnosticConsumer needs a new CTU parameter that is passed through the create functions. Repository: rC Clang https://reviews.llvm.org/D64635 Files:

r365902 - cmake: Add INSTALL_WITH_TOOLCHAIN option to add_*_library macros

Author: tstellar Date: Fri Jul 12 07:40:18 2019 New Revision: 365902 URL: http://llvm.org/viewvc/llvm-project?rev=365902&view=rev Log: cmake: Add INSTALL_WITH_TOOLCHAIN option to add_*_library macros Summary: This will simplify the macros by allowing us to remove the hard-coded list of libraries

[PATCH] D64580: cmake: Add INSTALL_WITH_TOOLCHAIN option to add_*_library macros

This revision was automatically updated to reflect the committed changes. Closed by commit rL365902: cmake: Add INSTALL_WITH_TOOLCHAIN option to add_*_library macros (authored by tstellar, committed by ). Changed prior to commit: https://reviews.llvm.org/D64580?vs=209285&id=209482#toc Reposito

Re: [clang-tools-extra] r365867 - [clangd] Implement typeHierarchy/resolve for subtypes

Hi Nathan, I've reverted this to get the bot green(er). Regards Russ On Fri, 12 Jul 2019 at 13:32, Russell Gallop wrote: > Hi Nathan, > This is causing a test failure on Windows: > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/26909 > > Please can yo

Re: r365887 - [JSONCompilationDatabase] Strip distcc/ccache/gomacc wrappers from parsed commands.

Hi Sam, This is hitting a test failure on a Windows bot: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/26916 Please could you take a look? Thanks Russ On Fri, 12 Jul 2019 at 11:11, Sam McCall via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Aut

[PATCH] D56661: [clang-tidy] Fix incorrect array name generation in cppcoreguidelines-pro-bounds-constant-array-index

Quolyk updated this revision to Diff 209485. Quolyk added a comment. Herald added a subscriber: wuzish. Herald added a project: clang. Update. Solution is not elegant, because DeclRef->BaseRange somehow has zero length. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://r

[PATCH] D64638: [CrossTU] Fix plist macro expansion if macro in other file.

balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp. Herald added a project: clang. When cross TU analysis is used it is possible that a macro expansion is generated for a macro that is defined (and used) in other than the main translation unit. To g

[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/Sema/TreeTransform.h:5363 +if (ResultType.getAddressSpace() != LangAS::Default && +(ResultType.getAddressSpace() != LangAS::opencl_private)) { SemaRef.Diag(TL.getReturn

r365905 - cmake: Fix install of libclang-cpp.so when LLVM_INSTALL_TOOLCHAIN_ONLY=ON

Author: tstellar Date: Fri Jul 12 08:11:28 2019 New Revision: 365905 URL: http://llvm.org/viewvc/llvm-project?rev=365905&view=rev Log: cmake: Fix install of libclang-cpp.so when LLVM_INSTALL_TOOLCHAIN_ONLY=ON Summary: If CLANG_LINK_CLANG_DYLIB is also enabled, then this library needs to be instal

[PATCH] D64400: [OpenCL][PR42390] Deduce addr space for templ specialization

Anastasia added a comment. In D64400#1582142 , @rjmccall wrote: > There are some code paths that I think are common between the parser and > template instantiation, like `BuildPointerType` and `BuildReferenceType`, but > if you want to do context-sensiti

[PATCH] D64582: cmake: Fix install of libclang_shared.so when LLVM_INSTALL_TOOLCHAIN_ONLY=ON

This revision was automatically updated to reflect the committed changes. Closed by commit rL365905: cmake: Fix install of libclang-cpp.so when LLVM_INSTALL_TOOLCHAIN_ONLY=ON (authored by tstellar, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prio

r365906 - Revert "[JSONCompilationDatabase] Strip distcc/ccache/gomacc wrappers from parsed commands."

Author: russell_gallop Date: Fri Jul 12 08:15:56 2019 New Revision: 365906 URL: http://llvm.org/viewvc/llvm-project?rev=365906&view=rev Log: Revert "[JSONCompilationDatabase] Strip distcc/ccache/gomacc wrappers from parsed commands." New test is failing on Windows bot This reverts commit 9c0391

[PATCH] D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier

benhamilton added a comment. Thanks for the fix. One question: how does the real Clang parser deal with this case? Is it something that's actually ambiguous in the ObjC++ grammar, I wonder? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64632/new/

[PATCH] D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier

benhamilton added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:400-413 while (AttrTok && !AttrTok->startsSequence(tok::r_square, tok::r_square)) { // ObjC message send. We assume nobody will use : in a C++11 attribute // specifier parameter,

[PATCH] D64635: [CrossTU] Added CTU argument to diagnostic consumer create fn.

Szelethus added reviewers: NoQ, Szelethus. Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64635/new/ https://reviews.llvm.org/D64635

[PATCH] D64638: [CrossTU] Fix plist macro expansion if macro in other file.

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64638/new/ https://reviews.llvm.org/D64638 ___

Re: r365887 - [JSONCompilationDatabase] Strip distcc/ccache/gomacc wrappers from parsed commands.

Hi Sam, I've reverted to get the bot green again. Regards Russ On Fri, 12 Jul 2019 at 15:52, Russell Gallop wrote: > Hi Sam, > > This is hitting a test failure on a Windows bot: > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/26916 > > Please could y

Re: r365825 - [clang-shlib] Fix clang-shlib for PRIVATE dependencies

Oops, sorry about the breakage. Chris, aren't BUILD_SHARED_LIBS and the combined Clang dylib incompatible? Should we disable building the latter if the former is set? From: Alex Bradbury Date: Friday, July 12, 2019 at 2:02 AM To: Shoaib Meenai Cc: cfe-commits Subject: Re: r365825 - [clang-shl

[PATCH] D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier

rkgibson2 marked an inline comment as done. rkgibson2 added a comment. In D64632#1582793 , @benhamilton wrote: > Thanks for the fix. One question: how does the real Clang parser deal with > this case? Is it something that's actually ambiguous in the ObjC+

[PATCH] D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier

rkgibson2 updated this revision to Diff 209496. rkgibson2 added a comment. Respond to comments and change detection method Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64632/new/ https://reviews.llvm.org/D64632 Files: clang/lib/Format/TokenAnno

[PATCH] D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier

aaron.ballman added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:389 bool isCpp11AttributeSpecifier(const FormatToken &Tok) { if (!Style.isCpp() || !Tok.startsSequence(tok::l_square, tok::l_square)) return false; Clang has a fea

Re: r365825 - [clang-shlib] Fix clang-shlib for PRIVATE dependencies

One of the benefits of the object library approach for generating the clang dylib is that it was compatible with BUILD_SHARED_LIBS. We had lots of issues with libLLVM where people using BUILD_SHARED_LIBS would make changes that broke it, so I was trying to make the clang dylib in a way that it c

Re: r365825 - [clang-shlib] Fix clang-shlib for PRIVATE dependencies

See https://reviews.llvm.org/D58418#1577670. More generally it would appear for any static library with a PRIVATE dependency though. I guess an alternative would be to use the LINK_LIBRARIES property (which should be free of generator expressions, I believe) to propagate dependencies instead of

r365909 - [clang-format][tests] Explicitly specify style in some tests

Author: r.stahl Date: Fri Jul 12 08:56:18 2019 New Revision: 365909 URL: http://llvm.org/viewvc/llvm-project?rev=365909&view=rev Log: [clang-format][tests] Explicitly specify style in some tests Summary: This fixes broken tests when doing an out-of-source build that picks up a random .clang-form

[PATCH] D61001: [clang-format][tests] Explicitly specify style in some tests

This revision was automatically updated to reflect the committed changes. r.stahl marked an inline comment as done. Closed by commit rGf625a8a250b3: [clang-format][tests] Explicitly specify style in some tests (authored by r.stahl). Changed prior to commit: https://reviews.llvm.org/D61001?vs=19

[PATCH] D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier

rkgibson2 updated this revision to Diff 209504. rkgibson2 added a comment. Update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64632/new/ https://reviews.llvm.org/D64632 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Forma

Re: r365825 - [clang-shlib] Fix clang-shlib for PRIVATE dependencies

Ah! I see what is going on here. This is kinda a silliness of CMake. `PRIVATE` linkage for a static archive is silly, and shouldn't be possible. All link dependencies for static archives are really `INTERFACE` dependencies, and it looks like CMake is doing something kinda silly instead of produc

[PATCH] D64628: [CrossTU] Test change only: improve ctu-main.c

Szelethus added a comment. Hmmm, did this result in an assertion? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64628/new/ https://reviews.llvm.org/D64628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D64329: [Clangd] Fixed SelectionTree bug for macros

SureYeaah updated this revision to Diff 209506. SureYeaah added a comment. Added a test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64329/new/ https://reviews.llvm.org/D64329 Files: clang-tools-extra/clangd/Selection.cpp clang-tools-ext

[PATCH] D64579: [clang-shlib] Fix clang-shlib for PRIVATE dependencies

brzycki added a comment. Hello @smeenai , this commit causes LLVM to fail to build when set set `-D BUILD_SHARED_LIBS=ON`. Here is the failing CMake and Ninja invocation: /tools/build/cmake-3.14.5/bin/cmake \ -G Ninja \ -D CMAKE_MAKE_PROGRAM=/tools/build/ninja-1.9.0/ninja \

[PATCH] D63975: Warn when ScopeDepthOrObjCQuals overflows

Mordante marked an inline comment as done. Mordante added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:6587 +return; + } + rjmccall wrote: > Mordante wrote: > > rjmccall wrote: > > > Comment indentation. > > > > > > Should we do this w

[PATCH] D64617: [clangd] Added highlighting for members and methods

jvikstrom updated this revision to Diff 209510. jvikstrom added a comment. Removed addToken for Exprs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64617/new/ https://reviews.llvm.org/D64617 Files: clang-tools-extra/clangd/SemanticHighlighting.

[PATCH] D64617: [clangd] Added highlighting for members and methods

jvikstrom updated this revision to Diff 209509. jvikstrom marked 6 inline comments as done. jvikstrom added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64617/new/ https://reviews.llvm.org/D64617 Files: clang-tool

[PATCH] D63975: Warn when ScopeDepthOrObjCQuals overflows

Mordante updated this revision to Diff 209513. Mordante added a comment. Moved the test out of the loop as suggested by rjmccall. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63975/new/ https://reviews.llvm.org/D63975 Files: clang/include/clang/AST/Decl.h clang/include/clang/Basic

[PATCH] D64624: [clangd] Added highlighting to enum constants.

jvikstrom updated this revision to Diff 209514. jvikstrom marked 2 inline comments as done. jvikstrom added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64624/new/ https://reviews.llvm.org/D64624 Files: clang-tools-

[PATCH] D64597: CodeGet: Init 32bit pointers with 0xFFFFFFFF

hubert.reinterpretcast added a comment. In D64597#1581605 , @pcc wrote: > The problem with `0x` on 32-bit is that it is likely to be a valid > address. > > When I discussed this with JF I proposed a pointer initialization of > `0x` which

[PATCH] D64597: CodeGet: Init 32bit pointers with 0xFFFFFFFF

pcc added a comment. In D64597#1582944 , @hubert.reinterpretcast wrote: > In D64597#1581605 , @pcc wrote: > > > The problem with `0x` on 32-bit is that it is likely to be a valid > > address. > > > > When

[PATCH] D64597: CodeGet: Init 32bit pointers with 0xFFFFFFFF

jfb added a comment. In D64597#1582944 , @hubert.reinterpretcast wrote: > In D64597#1581605 , @pcc wrote: > > > The problem with `0x` on 32-bit is that it is likely to be a valid > > address. > > > > When

[PATCH] D64644: Fixes a clang frontend assertion failure (bug 35682)

Mordante created this revision. Mordante added a reviewer: rsmith. Mordante added a project: clang. This fixes bug 35682. I was not able to easily generate a test-case so I haven't been able to add unit tests. I'll update the bug in bugzilla with some additional information. Repository: rG

[PATCH] D64644: Fixes a clang frontend assertion failure (bug 35682)

lebedev.ri added a comment. Test? Comment at: clang/lib/Sema/SemaTemplate.cpp:726 +return ExprError(); + else +return DependentScopeDeclRefExpr::Create(Context, std::move(QualifierLoc), no else after return Repository: rG LLVM Github Monorepo CHAN

r365919 - Dump actual line numbers when dumping the AST to JSON.

Author: aaronballman Date: Fri Jul 12 09:53:57 2019 New Revision: 365919 URL: http://llvm.org/viewvc/llvm-project?rev=365919&view=rev Log: Dump actual line numbers when dumping the AST to JSON. The "line" attribute is now the physical line within the source file for the location. A "presumedLine

[PATCH] D64597: CodeGet: Init 32bit pointers with 0xFFFFFFFF

hubert.reinterpretcast added a comment. In D64597#1582950 , @jfb wrote: > On 32-bit platforms the only region that's likely to trap is the zero page. > This seems to be the best choice, but platforms with other regions should be > able to tune this value

[PATCH] D64644: Fixes a clang frontend assertion failure (bug 35682)

Mordante marked 2 inline comments as done. Mordante added a comment. Thanks for feedback. I'll whether I can find a way to generate a nice test case. Comment at: clang/lib/Sema/SemaTemplate.cpp:726 +return ExprError(); + else +return DependentScopeDeclRefExpr::Create(C

[PATCH] D64646: [OPENMP]Add support for analysis of if clauses.

ABataev created this revision. ABataev added a reviewer: NoQ. Herald added subscribers: jdoerfert, jfb, guansong. Herald added a project: clang. Added support for analysis of if clauses in the OpenMP directives to be able to check for the use of uninitialized variables. Repository: rC Clang h

Re: r365825 - [clang-shlib] Fix clang-shlib for PRIVATE dependencies

Hmm, I thought CMake did something more sensible with PRIVATE/INTERFACE/PUBLIC dependencies on static libraries, but now I’m not so sure… I’m continuing to investigate more, but I’ll revert in the meantime. From: on behalf of Chris Bieneman Date: Friday, July 12, 2019 at 9:08 AM To: Shoaib Mee

r365921 - CodeGet: Init 32bit pointers with 0xFFFFFFFF

Author: vitalybuka Date: Fri Jul 12 10:21:55 2019 New Revision: 365921 URL: http://llvm.org/viewvc/llvm-project?rev=365921&view=rev Log: CodeGet: Init 32bit pointers with 0x Summary: Patch makes D63967 effective for 32bit platforms and improves pattern initialization there. It cuts size o

[PATCH] D64597: CodeGet: Init 32bit pointers with 0xFFFFFFFF

This revision was automatically updated to reflect the committed changes. Closed by commit rL365921: CodeGet: Init 32bit pointers with 0x (authored by vitalybuka, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

[PATCH] D64607: [clang-tidy] Fix crash on end location inside macro

Nathan-Huckleberry updated this revision to Diff 209524. Nathan-Huckleberry added a comment. - Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64607/new/ https://reviews.llvm.org/D64607 Files: clang-tools-extra/clang-tidy/bugprone/BranchC

Re: r365825 - [clang-shlib] Fix clang-shlib for PRIVATE dependencies

Reverted in r365922. From: on behalf of Chris Bieneman Date: Friday, July 12, 2019 at 9:08 AM To: Shoaib Meenai Cc: Alex Bradbury , cfe-commits Subject: Re: r365825 - [clang-shlib] Fix clang-shlib for PRIVATE dependencies Ah! I see what is going on here. This is kinda a silliness of CMake. `P

r365922 - Revert [clang-shlib] Fix clang-shlib for PRIVATE dependencies

Author: smeenai Date: Fri Jul 12 10:23:35 2019 New Revision: 365922 URL: http://llvm.org/viewvc/llvm-project?rev=365922&view=rev Log: Revert [clang-shlib] Fix clang-shlib for PRIVATE dependencies This reverts r365825 (git commit 3173c60f96c3ccfc17d403a192ae58e720153c23) This is breaking BUILD_SH

[PATCH] D63975: Warn when ScopeDepthOrObjCQuals overflows

rjmccall added a comment. Thanks. It's good to have a lambda test, but that one isn't actually testing the lambda path — the place the diagnostic will trigger is just the normal function-prototype path, just originally within a lambda. You can do something like this: template int foo(T &&

Re: [PATCH] D64579: [clang-shlib] Fix clang-shlib for PRIVATE dependencies

Sorry about the breakage. I reverted it in r365922. On 7/12/19, 9:12 AM, "Brian Rzycki via Phabricator" wrote: brzycki added a comment. Hello @smeenai , this commit causes LLVM to fail to build when set set `-D BUILD_SHARED_LIBS=ON`. Here is the failing CMake and Ninja invocation

[PATCH] D63975: Warn when ScopeDepthOrObjCQuals overflows

rjmccall added a comment. (Blocks don't actually allow default arguments, but apparently we still parse them, so we should test that path.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63975/new/ https://reviews.llvm.org/D63975 ___ cfe-co

Re: [clang-tools-extra] r365867 - [clangd] Implement typeHierarchy/resolve for subtypes

Thanks. Is there a way to trigger a run of the bots on a patch prior to comitting it? Nate From: Russell Gallop Sent: July 12, 2019 2:46 PM To: Nathan Ridge Cc: cfe-commits Subject: Re: [clang-tools-extra] r365867 - [clangd] Implement typeHierarchy/reso

[PATCH] D64308: [clangd] Implement typeHierarchy/resolve for subtypes

nridge reopened this revision. nridge marked an inline comment as done. nridge added a comment. This revision is now accepted and ready to land. This was backed out due to a Windows test failure. Seems to be related to the hint path having a different format on Windows. I guess I should not hard-

[PATCH] D62413: [OpenCL][PR41727] Prevent ICE on global dtors

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Current patch LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62413/new/ https://reviews.llvm.org/D62413 ___ cfe-commits mailing

[PATCH] D62413: [OpenCL][PR41727] Prevent ICE on global dtors

rjmccall added a comment. If you're interested in working on this, great. I actually think there's zero reason to emit a non-null argument here on any target unless we're going to use the destructor as the function pointer — but we can do that on every Itanium target, so we should. So where w

[PATCH] D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier

benhamilton accepted this revision. benhamilton added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64632/new/ https://reviews.llvm.org/D64632 __

  1   2   3   >