[PATCH] D65453: Improve the accuracy of the Clang call graph analysis

NoQ accepted this revision. NoQ edited reviewers, added: NoQ; removed: dergachev.a. NoQ added a comment. This will slightly skew Static Analyzer exploration order, not necessarily in a good way, as default arguments and (sometimes) default initializers are not modeled properly. But this doesn't

Re: r368348 - Fix up fd limit diagnosis code

Let me know if the problem persists after r368475. Someone else filed https://bugs.llvm.org/show_bug.cgi?id=42948 as well. On Thu, Aug 8, 2019 at 11:34 PM Martin Storsjö wrote: > This change broke compiling Qt. > > A repro case looks like this: > > mkdir -p fake-qtincl/5.13.1/QtCore/private >

[PATCH] D65974: Update test to explicitly test with -fintegrated-as and -fno-integrated-as and to expect warnings when appropriate.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368474: Update test to explicity test with -fintegrated-as and -fno-integrated-as and… (authored by dyung, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

r368475 - Don't diagnose errors when a file matches an include component

Author: rnk Date: Fri Aug 9 12:49:14 2019 New Revision: 368475 URL: http://llvm.org/viewvc/llvm-project?rev=368475=rev Log: Don't diagnose errors when a file matches an include component This regressed in r368322, and was reported as PR42948 and on the mailing list. The fix is to ignore the

r368474 - Update test to explicity test with -fintegrated-as and -fno-integrated-as and to expect warnings when appropriate.

Author: dyung Date: Fri Aug 9 12:47:18 2019 New Revision: 368474 URL: http://llvm.org/viewvc/llvm-project?rev=368474=rev Log: Update test to explicity test with -fintegrated-as and -fno-integrated-as and to expect warnings when appropriate. Reviewed by: thakis Differential Revision:

Re: r368348 - Fix up fd limit diagnosis code

Thanks for taking care of this. I think having a list of "allowed" error codes is more robust long-term than having an explicit list of unexpected error codes, even though if it requires some short-term whack-a-mole. The original change landed after the 9.0 branch, so we have some time for

Re: r368348 - Fix up fd limit diagnosis code

I'll add std::errc::not_a_directory to the list of ignored errors. On Thu, Aug 8, 2019 at 11:34 PM Martin Storsjö wrote: > This change broke compiling Qt. > > A repro case looks like this: > > mkdir -p fake-qtincl/5.13.1/QtCore/private > touch fake-qtincl/5.13.1/QtCore/private/qglobal_p.h >

[PATCH] D65974: Update test to explicitly test with -fintegrated-as and -fno-integrated-as and to expect warnings when appropriate.

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. lgtm Thanks. I moved your new description into the (previously still stale) revision title and put in a new description. lgtm. Repository: rC Clang CHANGES SINCE LAST ACTION

r368471 - CodeGen: ensure 8-byte aligned String Swift CF ABI

Author: compnerd Date: Fri Aug 9 12:29:05 2019 New Revision: 368471 URL: http://llvm.org/viewvc/llvm-project?rev=368471=rev Log: CodeGen: ensure 8-byte aligned String Swift CF ABI CFStrings should be 8-byte aligned when built for the Swift CF runtime ABI as the atomic CF info field must be

Re: r368459 - Fix a build bot failure and multiple warnings instances for range base for loops

I reverted but I cannot reproduce this locally on a linux box. Is there any way to get more information from the build bot (like preprocessed files?)? On Fri, 9 Aug 2019 at 11:38, Gábor Horváth wrote: > Hmm, strange. Looking into it! If I do not manage to find the root cause > in a few minutes

r368463 - Revert Even more warnings utilizing gsl::Owner/gsl::Pointer annotations

Author: xazax Date: Fri Aug 9 12:01:23 2019 New Revision: 368463 URL: http://llvm.org/viewvc/llvm-project?rev=368463=rev Log: Revert Even more warnings utilizing gsl::Owner/gsl::Pointer annotations This reverts r368454 (git commit 7c3c8ba8daf40534e09f6fe8701b723e25e4e2dc) Modified:

r368462 - Revert Fix a build bot failure and multiple warnings instances for range base for loops

Author: xazax Date: Fri Aug 9 11:58:09 2019 New Revision: 368462 URL: http://llvm.org/viewvc/llvm-project?rev=368462=rev Log: Revert Fix a build bot failure and multiple warnings instances for range base for loops This reverts r368459 (git commit 2bf522aea62e4fb653cacb68072167d25149099e)

[PATCH] D65987: [clang-doc] Generate HTML links for children namespaces/records

DiegoAstiazaran marked 2 inline comments as done. DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:250 + // The resulting path is "../../../A/B/D" instead of a "../D". It is correct + // but it would be better to have the shorter

[PATCH] D65912: [clang-tidy] Add new check for math constants

aaron.ballman added a comment. In D65912#1623393 , @Eugene.Zelenko wrote: > In D65912#1623375 , @ZaMaZaN4iK > wrote: > > > > ... then I have a script that runs clang-tidy over all the compilation > > > units in

Re: r368459 - Fix a build bot failure and multiple warnings instances for range base for loops

Hmm, strange. Looking into it! If I do not manage to find the root cause in a few minutes I will revert! On Fri, 9 Aug 2019 at 11:32, Jonas Devlieghere wrote: > I think this is causing a stage2 failure: > >

[PATCH] D65912: [clang-tidy] Add new check for math constants

Eugene.Zelenko added a comment. In D65912#1623375 , @ZaMaZaN4iK wrote: > > ... then I have a script that runs clang-tidy over all the compilation > > units in a compilation database > > Can you share this script please? :) run-clang-tidy.py which is

[PATCH] D65974: Driver: Don't warn about assembler flags being unused when not assembling AND not using the integrated assembler

dyung added a comment. In D65974#1623368 , @thakis wrote: > Something like "fix test for out-of-tree targets that don't enable the > internal assembler by default by explicitly passing -fintegrated-as > everywhere" or something like that. Thanks. I

Re: r368459 - Fix a build bot failure and multiple warnings instances for range base for loops

I think this is causing a stage2 failure: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/124/consoleFull#-95886206949ba4694-19c4-4d7e-bec5-911270d8a58c On Fri, Aug 9, 2019 at 10:41 AM Gabor Horvath via cfe-commits wrote: > > Author: xazax > Date: Fri Aug 9 10:42:41 2019 > New

[PATCH] D65912: [clang-tidy] Add new check for math constants

ZaMaZaN4iK added a comment. > ... then I have a script that runs clang-tidy over all the compilation units > in a compilation database Can you share this script please? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65912/new/

[PATCH] D65974: Driver: Don't warn about assembler flags being unused when not assembling AND not using the integrated assembler

thakis added a comment. Something like "fix test for out-of-tree targets that don't enable the internal assembler by default by explicitly passing -fintegrated-as everywhere" or something like that. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65974/new/

[PATCH] D65974: Driver: Don't warn about assembler flags being unused when not assembling AND not using the integrated assembler

thakis added a comment. Can you update the patch description to say what the patch does? With that, lgtm :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65974/new/ https://reviews.llvm.org/D65974 ___ cfe-commits

[PATCH] D65987: [clang-doc] Generate HTML links for children namespaces/records

DiegoAstiazaran marked 2 inline comments as done. DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:250 + // The resulting path is "../../../A/B/D" instead of a "../D". It is correct + // but it would be better to have the shorter

[PATCH] D65974: Driver: Don't warn about assembler flags being unused when not assembling AND not using the integrated assembler

dyung added a comment. Actually it seems your original change already implemented that, so I think only the updated test change that I made is needed. Let me know if you disagree with that. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65974/new/

[PATCH] D65993: [NFC][clang] Adding argument based Phase list filtering to getComplicationPhases

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3220 - phases::ID FinalPhase; { Arg *FinalPhaseArg; @aaron.ballman How's this look to you now? I have another NFC patch coming up that will

[PATCH] D65629: cfi-icall: Allow the jump table to be optionally made non-canonical.

eugenis added inline comments. Comment at: clang/test/CodeGen/cfi-icall-canonical-jump-tables.c:15 +// CHECK: define void @g({{.*}} [[ATTR2:#[0-9]+]] +__attribute__((cfi_jump_table_canonical)) void g() {} + would it be more natural to spell it

[PATCH] D65974: Driver: Don't warn about assembler flags being unused when not assembling AND not using the integrated assembler

dyung added a comment. Oh, I just re-read your comments and realized that we should claim the Wa_COMMA and Xassembler arguments, I'll reinstate the change to just claim those. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65974/new/

[PATCH] D65993: [NFC][clang] Adding argument based Phase list filtering to getComplicationPhases

plotfi updated this revision to Diff 214408. plotfi added a comment. using llvm::copy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65993/new/ https://reviews.llvm.org/D65993 Files: clang/include/clang/Driver/Types.h

[PATCH] D65974: Driver: Don't warn about assembler flags being unused when not assembling AND not using the integrated assembler

dyung marked an inline comment as done. dyung added a comment. In D65974#1623140 , @thakis wrote: > Thanks! Looks like the change to the cpp file got lost? I only see the test > change now. Yes, I abandoned that change as I thought you said it was

[PATCH] D65483: [clang-doc] Add link to source code in file definitions

This revision was automatically updated to reflect the committed changes. Closed by commit rL368460: [clang-format] Add link to source code in file definitions (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[clang-tools-extra] r368460 - [clang-format] Add link to source code in file definitions

Author: diegoastiazaran Date: Fri Aug 9 10:49:41 2019 New Revision: 368460 URL: http://llvm.org/viewvc/llvm-project?rev=368460=rev Log: [clang-format] Add link to source code in file definitions Two command line options have been added to clang-doc. --repository= - URL of repository

[PATCH] D65993: [NFC][clang] Adding argument based Phase list filtering to getComplicationPhases

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/lib/Driver/Types.cpp:313-315 +for (auto Phase : PhaseList) + if (Phase <= phases::Preprocess) +P.push_back(Phase); aaron.ballman wrote: > How about: > >

[PATCH] D65912: [clang-tidy] Add new check for math constants

aaron.ballman added a comment. In D65912#1623293 , @ZaMaZaN4iK wrote: > > My point regarding statistics is that the check needs to pull its own > > weight -- if it doesn't find many true positives, it's not of much value to > > a broad community, or if

[PATCH] D65993: [NFC][clang] Adding argument based Phase list filtering to getComplicationPhases

plotfi added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3220 - unsigned LastPLSize = 0; - for (auto : Inputs) { -types::ID InputType = I.first; -const Arg *InputArg = I.second; + { +Arg *FinalPhaseArg; aaron.ballman wrote: > Why

[PATCH] D65993: [NFC][clang] Adding argument based Phase list filtering to getComplicationPhases

plotfi updated this revision to Diff 214403. plotfi marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65993/new/ https://reviews.llvm.org/D65993 Files: clang/include/clang/Driver/Types.h clang/lib/Driver/Driver.cpp

r368459 - Fix a build bot failure and multiple warnings instances for range base for loops

Author: xazax Date: Fri Aug 9 10:42:41 2019 New Revision: 368459 URL: http://llvm.org/viewvc/llvm-project?rev=368459=rev Log: Fix a build bot failure and multiple warnings instances for range base for loops Modified: cfe/trunk/lib/Sema/SemaInit.cpp

[PATCH] D65912: [clang-tidy] Add new check for math constants

ZaMaZaN4iK added a comment. > My point regarding statistics is that the check needs to pull its own weight > -- if it doesn't find many true positives, it's not of much value to a broad > community, or if it has a lot of false positives, we may need to tweak the > check before releasing it to

[PATCH] D65986: Allow setting the VFS to 'real' mode instead of default 'physical'

jfb marked an inline comment as done. jfb added a comment. In D65986#1623283 , @Bigcheese wrote: > This fix works, but we could also use openat to get around max path length > issues. Windows also has an API that can be used similarly. Given the type

[PATCH] D65986: Allow setting the VFS to 'real' mode instead of default 'physical'

Bigcheese added a comment. This fix works, but we could also use openat to get around max path length issues. Windows also has an API that can be used similarly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65986/new/

[PATCH] D57165: [FileManager] Revert r347205 to avoid PCH file-descriptor leak.

sammccall added a comment. Herald added a subscriber: ormris. Renamed in rL368455 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57165/new/ https://reviews.llvm.org/D57165 ___

r368455 - Rename PCH/leakfiles test so it runs on bots.

Author: sammccall Date: Fri Aug 9 10:13:56 2019 New Revision: 368455 URL: http://llvm.org/viewvc/llvm-project?rev=368455=rev Log: Rename PCH/leakfiles test so it runs on bots. Added: cfe/trunk/test/PCH/leakfiles.test Removed: cfe/trunk/test/PCH/leakfiles Removed:

[PATCH] D65127: Even more warnings utilizing gsl::Owner/gsl::Pointer annotations

This revision was automatically updated to reflect the committed changes. Closed by commit rL368454: Even more warnings utilizing gsl::Owner/gsl::Pointer annotations (authored by xazax, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

r368454 - Even more warnings utilizing gsl::Owner/gsl::Pointer annotations

Author: xazax Date: Fri Aug 9 10:11:32 2019 New Revision: 368454 URL: http://llvm.org/viewvc/llvm-project?rev=368454=rev Log: Even more warnings utilizing gsl::Owner/gsl::Pointer annotations Differential Revision: https://reviews.llvm.org/D65127 Modified: cfe/trunk/lib/Sema/SemaInit.cpp

[PATCH] D65986: Allow setting the VFS to 'real' mode instead of default 'physical'

jfb marked 2 inline comments as done. jfb added inline comments. Comment at: clang/test/Driver/vfsmode.py:47 +# exceed PATH_MAX. +assert os.path.exists(file_relative_path) +assert not os.path.exists(os.path.join(absolute, filename)) bruno wrote: > If you want to

[PATCH] D65986: Allow setting the VFS to 'real' mode instead of default 'physical'

jfb updated this revision to Diff 214397. jfb added a comment. - Document asserts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65986/new/ https://reviews.llvm.org/D65986 Files: clang/include/clang/Driver/Driver.h

[PATCH] D65986: Allow setting the VFS to 'real' mode instead of default 'physical'

bruno accepted this revision. bruno added a comment. LGTM Comment at: clang/test/Driver/vfsmode.py:47 +# exceed PATH_MAX. +assert os.path.exists(file_relative_path) +assert not os.path.exists(os.path.join(absolute, filename)) If you want to make this even more

[PATCH] D65986: Allow setting the VFS to 'real' mode instead of default 'physical'

jfb marked 4 inline comments as done. jfb added inline comments. Comment at: clang/include/clang/Driver/Options.td:2010 HelpText<"Overlay the virtual filesystem described by file over the real file system">; +def ivfsmode : Joined<["-"], "ivfsmode=">, Group,

[PATCH] D65986: Allow setting the VFS to 'real' mode instead of default 'physical'

jfb marked an inline comment as done. jfb added a comment. In D65986#1622447 , @sammccall wrote: > Tagging D62271 and @Bigcheese as this was > the change that switched the default in Driver. (My motivation for D58169 >

[PATCH] D65986: Allow setting the VFS to 'real' mode instead of default 'physical'

jfb marked 2 inline comments as done. jfb added inline comments. Comment at: clang/test/Driver/vfsmode.py:4 + +# UNSUPPORTED: system-windows + labath wrote: > jfb wrote: > > I'm not sure what the best way to test this on Windows would be, and > > without a

[PATCH] D65975: [NewPM][PassInstrumentation] IR printing support from clang driver

yamauchi added a comment. In D65975#1621892 , @twoh wrote: > @fedor.sergeev @yamauchi I saw your discussions over llvm-dev mailing list > regarding IR printing with the new pass manager, and though this might be the > reason why IR printing is not

[PATCH] D65912: [clang-tidy] Add new check for math constants

aaron.ballman added a comment. In D65912#1623076 , @ZaMaZaN4iK wrote: > @aaron.ballman Sure. I agree with you that epsilon should be configurable. I > think we can collect some statistics later. Now I am going to work on > implementation and tests.

[PATCH] D65987: [clang-doc] Generate HTML links for children namespaces/records

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:250 + // The resulting path is "../../../A/B/D" instead of a "../D". It is correct + // but it would be better to have the shorter version. StringRef Dir = Directory;

[PATCH] D66018: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature

krisb created this revision. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. krisb added reviewers: SjoerdMeijer, ostannard, labrinea, dnsampaio. '+crypto' means '+aes' and '+sha2' for arch >= ARMv8 when they were not disabled explicitly.

[PATCH] D65483: [clang-doc] Add link to source code in file definitions

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65483/new/ https://reviews.llvm.org/D65483 ___ cfe-commits mailing list

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

andrew.w.kaylor added a comment. In D62731#1623114 , @mibintc wrote: > @andrew.w.kaylor Thanks Andy. Reminder -- in a private document you > indicated to me that -fp-speculation=safe corresponds to the maytrap setting > for the exception argument.

[PATCH] D65629: cfi-icall: Allow the jump table to be optionally made non-canonical.

pcc added a reviewer: eugenis. pcc added a comment. Thanks for the confirmation Kees. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65629/new/ https://reviews.llvm.org/D65629 ___ cfe-commits mailing

[PATCH] D65974: Driver: Don't warn about assembler flags being unused when not assembling AND not using the integrated assembler

thakis added a comment. Thanks! Looks like the change to the cpp file got lost? I only see the test change now. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65974/new/ https://reviews.llvm.org/D65974 ___

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc added a comment. In D62731#1620174 , @andrew.w.kaylor wrote: > I'm not entirely caught up on this review. I've only read the most recent > comments, but I think I've got enough context to comment on the metadata > arguments. > > Based only on

[PATCH] D64931: Change X86 datalayout for three address spaces that specify pointer sizes.

arsenm added a comment. In D64931#1622039 , @lebedev.ri wrote: > In D64931#1622038 , @akhuang wrote: > > > @lebedev.ri The test case datalayout strings were changed because somewhere > > llvm asserts that the

[PATCH] D65120: More warnings regarding gsl::Pointer and gsl::Owner attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rL368446: More warnings regarding gsl::Pointer and gsl::Owner attributes (authored by xazax, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D65994: Extended FPOptions with new attributes

kpn added a comment. In D65994#1622840 , @aaron.ballman wrote: > In general, this seems reasonable, but is missing test code. The IRBuilder does have a strict FP mode setting now. When strict mode is enabled the (implemented) constrained intrinsics

r368446 - More warnings regarding gsl::Pointer and gsl::Owner attributes

Author: xazax Date: Fri Aug 9 08:16:35 2019 New Revision: 368446 URL: http://llvm.org/viewvc/llvm-project?rev=368446=rev Log: More warnings regarding gsl::Pointer and gsl::Owner attributes Differential Revision: https://reviews.llvm.org/D65120 Modified: cfe/trunk/lib/Sema/SemaInit.cpp

[PATCH] D65997: Add options rounding and exceptions to pragma fp

kpn added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3151 +value ``dynamic`` informs the compiler that it must not assume particular +rounding mode. This option is experimental, compiler does not guarantee to +process it in all cases.

[PATCH] D66014: Avoid unnecessary enum range check on LValueToRValue casts

chrish_ericsson_atx created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. EnumCastOutOfRangeChecker should not perform enum range checks on LValueToRValue casts, since this type of cast does not actually change the underlying type. Performing the

[PATCH] D65912: [clang-tidy] Add new check for math constants

ZaMaZaN4iK added a comment. @aaron.ballman Sure. I agree with you that epsilon should be configurable. I think we can collect some statistics later. Now I am going to work on implementation and tests. Later, of course, will be good to run the check on some codebases. I will be happy to hear

[PATCH] D65996: [clangd] Highlighting auto variables as the deduced type.

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:143 + const auto Deduced = AT->getDeducedType(); + if (Deduced.isNull()) +return true;

[PATCH] D65906: [clang-scan-deps] Fix edge cases in the minimizer

aganea added a comment. In D65906#1622209 , @arphaman wrote: > @aganea These are not just any invisible characters that you have, this is > the UTF8 BOM. Clang's Lexer skips over them if they're in the beginning of > the file (`Lexer::InitLexer`). The

[PATCH] D65996: [clangd] Highlighting auto variables as the deduced type.

jvikstrom updated this revision to Diff 214373. jvikstrom added a comment. Removed ending whitespace on a line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65996/new/ https://reviews.llvm.org/D65996 Files:

[PATCH] D65996: [clangd] Highlighting auto variables as the deduced type.

jvikstrom updated this revision to Diff 214372. jvikstrom marked 3 inline comments as done. jvikstrom added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65996/new/ https://reviews.llvm.org/D65996 Files:

[PATCH] D65912: [clang-tidy] Add new check for math constants

aaron.ballman added a comment. In D65912#1622963 , @ZaMaZaN4iK wrote: > > One thing I would be interested in knowing is how often the check behaves > > when run over some large, real-world code bases. Does it catch any true > > positives? Does it have

[PATCH] D65993: [NFC][clang] Adding argument based Phase list filtering to getComplicationPhases

aaron.ballman added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3220 - unsigned LastPLSize = 0; - for (auto : Inputs) { -types::ID InputType = I.first; -const Arg *InputArg = I.second; + { +Arg *FinalPhaseArg; Why do you need this

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc

kristof.beyls added a comment. I've just added a few fly-by nits; I'm afraid I didn't do an in-depth review. Comment at: llvm/lib/Target/ARM/ARMExpandPseudoInsts.cpp:1156 MachineInstr = *MBBI; + LLVM_DEBUG(dbgs() << "ARMExpandPseudo::ExpandMI: " << MI << "\n");

[PATCH] D65127: Even more warnings utilizing gsl::Owner/gsl::Pointer annotations

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaInit.cpp:6581 +if (!Callee->getIdentifier()) { + auto OO = Callee->getOverloadedOperator(); + return OO ==

[PATCH] D65912: [clang-tidy] Add new check for math constants

ZaMaZaN4iK added a comment. > One thing I would be interested in knowing is how often the check behaves > when run over some large, real-world code bases. Does it catch any true > positives? Does it have false positives? I have no such statistics for this check. But I have statistics for

[PATCH] D44672: [CodeGen] Disable UBSan for coroutine functions

modocache updated this revision to Diff 214370. modocache added a comment. Thanks for the review, @vsk! Sorry it took me so long to update this diff. In the mailing list discussion, http://lists.llvm.org/pipermail/llvm-dev/2018-March/121925.html, you mentioned that I should use an allow-list

[PATCH] D65996: [clangd] Highlighting auto variables as the deduced type.

hokein added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:153 +// "auto" keyword other than using an offset. +Loc = Loc.getLocWithOffset(9); + Deduced.getTypePtr()->dump(); The heuristic using here is

[PATCH] D65877: [libTooling] In Transformer, generalize `applyFirst` to admit rules with incompatible matchers.

gribozavr added inline comments. Comment at: clang/lib/Tooling/Refactoring/Transformer.cpp:85 // the implicit relationship of Type and QualType. static bool isBaseOf(ASTNodeKind A, ASTNodeKind B) { static auto TypeKind = ASTNodeKind::getFromNodeKind(); I'd

[PATCH] D65998: [clangd] Added the vscode SemanticHighlighting feature code but did not enable it in the client.

jvikstrom updated this revision to Diff 214364. jvikstrom marked 4 inline comments as done. jvikstrom added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65998/new/ https://reviews.llvm.org/D65998 Files:

[PATCH] D65998: [clangd] Added the vscode SemanticHighlighting feature code but did not enable it in the client.

jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts:62 + + handleNotification(params: HighlightingInformation) { +const tokenLines = params.lines.map((line): HighlightingLine => { hokein

[PATCH] D64931: Change X86 datalayout for three address spaces that specify pointer sizes.

lebedev.ri added a comment. In D64931#1622144 , @akhuang wrote: > > Can you post a reproducer? > > Turns out I just didn't have assertions enabled. With assertions the changed > test cases should fail. > > > I think this is precisely what was discussed

[PATCH] D65212: [analyzer] Fix exporting SARIF files from scan-build on Windows

jranieri-grammatech marked an inline comment as done. jranieri-grammatech added inline comments. Comment at: clang/tools/scan-build/libexec/ccc-analyzer:121 END { - if (defined $ResultFile && -z $ResultFile) { unlink($ResultFile); NoQ wrote: > Whoops. I

[PATCH] D65999: [ASTImporter] Import additional flags for functions.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:5239 +TEST_P(ASTImporterOptionSpecificTestBase, ImportOfDefaultImplicitFunctions) { + // Test that import of implicit functions works and the

[PATCH] D66001: [clangd] Added highlighting for constructor initializers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368434: [clangd] Added highlighting for constructor initializers. (authored by jvikstrom, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r368434 - [clangd] Added highlighting for constructor initializers.

Author: jvikstrom Date: Fri Aug 9 05:19:10 2019 New Revision: 368434 URL: http://llvm.org/viewvc/llvm-project?rev=368434=rev Log: [clangd] Added highlighting for constructor initializers. Summary: Constructor initializers were not being highlighted. This adds highlighting for them by using

[PATCH] D65912: [clang-tidy] Add new check for math constants

aaron.ballman added a comment. In D65912#1621898 , @ZaMaZaN4iK wrote: > The main reason why I've created this differential - asking to you about > usefulness of this check for clang-tidy. I understand that there are a some > TODO and formatting issues -

[PATCH] D65997: Add options rounding and exceptions to pragma fp

aaron.ballman added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3146 +The option ``rounding`` specifies rounding mode applied to floating point +operations. It may take one of the values: ``tonearest``, ``downward``, specifies rounding mode

[PATCH] D65994: Extended FPOptions with new attributes

aaron.ballman added a comment. In general, this seems reasonable, but is missing test code. Comment at: clang/include/clang/Basic/LangOptions.h:188 +/// Rounding to nearest, corresponds to "round.tonearest". +ToNearest, +/// Rounding toward -Inf, corresponds to

[PATCH] D65998: [clangd] Added the vscode SemanticHighlighting feature code but did not enable it in the client.

hokein added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts:37 +// experimental semantic highlighting. +export class Feature implements vscodelc.StaticFeature { + scopes: string[]; nit: name it

[PATCH] D65919: [clang-tidy] Add llvm-prefer-register-over-unsigned check and apply it to LLVM

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/llvm/PreferRegisterOverUnsignedCheck.cpp:53 + } + diag(UserVarDecl->getLocation(), "use '%0'", DiagnosticIDs::Note) + << Replacement dsanders wrote: > aaron.ballman wrote: > >

[PATCH] D66003: [RISCV] Make -march=rv{32, 64}gc the default in RISC-V Linux

rogfer01 created this revision. rogfer01 added reviewers: asb, lenary. Herald added subscribers: cfe-commits, s.egerton, Jim, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, edward-jones, zzheng, MaskRay, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, apazos,

[PATCH] D66002: [RISCV] Move architecture parsing code into its own function

rogfer01 created this revision. rogfer01 added reviewers: asb, lenary. Herald added subscribers: cfe-commits, s.egerton, Jim, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, edward-jones, zzheng, MaskRay, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, apazos,

[PATCH] D65634: [RISCV] Default to ilp32d/lp64d in RISC-V Linux

rogfer01 added a comment. Thanks for the clarification @asb. I've posted D66003 (depending on D66002 ) for that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65634/new/ https://reviews.llvm.org/D65634

[PATCH] D64753: [CrossTU][NFCI] Refactor loadExternalAST function

balazske added a comment. I discovered that there are problems with this change. The number of loaded AST units is not incremented correctly and the "CTU loaded AST file" is displayed for every access to a AST unit (even if it was got from cache). The problem is that the counting and print of

[PATCH] D65936: [clangd] Use raw rename functions to implement the rename.

hokein updated this revision to Diff 214349. hokein marked an inline comment as done. hokein added a comment. Add a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65936/new/ https://reviews.llvm.org/D65936 Files:

[PATCH] D65936: [clangd] Use raw rename functions to implement the rename.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368429: [clangd] Use raw rename functions to implement the rename. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r368429 - [clangd] Use raw rename functions to implement the rename.

Author: hokein Date: Fri Aug 9 03:55:22 2019 New Revision: 368429 URL: http://llvm.org/viewvc/llvm-project?rev=368429=rev Log: [clangd] Use raw rename functions to implement the rename. Summary: The API provided by refactoring lib doesn't provide enough flexibility to get clangd's rename to

[PATCH] D66001: [clangd] Added highlighting for constructor initializers.

jvikstrom updated this revision to Diff 214346. jvikstrom added a comment. Fixed case where initializer was base class initializer which would cause crash. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66001/new/ https://reviews.llvm.org/D66001

[PATCH] D65999: [ASTImporter] Import additional flags for functions.

martong added a comment. LGTM, but I don't exactly see how the first test is related. Could you please explain? Comment at: clang/unittests/AST/ASTImporterTest.cpp:5239 +TEST_P(ASTImporterOptionSpecificTestBase, ImportOfDefaultImplicitFunctions) { + // Test that import of

[PATCH] D66001: [clangd] Added highlighting for constructor initializers.

jvikstrom created this revision. jvikstrom added reviewers: hokein, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Constructor initializers were not being highlighted. This adds highlighting for them by using

[PATCH] D65999: [ASTImporter] Import additional flags for functions.

balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp. Herald added a reviewer: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. At AST import of function delcarations import the flags for

Re: r367802 - [Analyzer] Iterator Checkers - Fix for Crash on Iterator Differences

Merged to release_90 in r368427. On Mon, Aug 5, 2019 at 8:44 AM Adam Balogh via cfe-commits wrote: > > Author: baloghadamsoftware > Date: Sun Aug 4 23:45:41 2019 > New Revision: 367802 > > URL: http://llvm.org/viewvc/llvm-project?rev=367802=rev > Log: > [Analyzer] Iterator Checkers - Fix for

<    1   2   3   >