[PATCH] D67253: clang-misexpect: a standalone tool for verifying the use of __builtin_expect with PGO data

paulkirth updated this revision to Diff 220239. paulkirth added a comment. Addresses problems running the standalone tool w/ the libTooling executors. When using the CodeGenAction and setting LLVM backend options, I found several places where data races occurred. This seems like a more

[PATCH] D67590: Properly ignore mismatched exception specifiers in MSVC Compat mode.

alexfusco created this revision. alexfusco added a project: clang. Herald added a subscriber: cfe-commits. This fixes the error compiling _com_ptr_t described in https://bugs.llvm.org/show_bug.cgi?id=42842 In MSVCCompat mode, clang already attempts to downgrade these mismatches to a

r371924 - [Diagnostics] Added silence note for -Wsizeof-array-div; suggest extra parens

Author: xbolva00 Date: Sat Sep 14 12:38:55 2019 New Revision: 371924 URL: http://llvm.org/viewvc/llvm-project?rev=371924=rev Log: [Diagnostics] Added silence note for -Wsizeof-array-div; suggest extra parens Modified: cfe/trunk/lib/Sema/SemaExpr.cpp

[PATCH] D67585: [clang] [cmake] Make building dylib optional

beanz added a comment. In D67585#1670491 , @mgorny wrote: > But in that case, we should aim for consistency, i.e. remove the matching > option from LLVM. Yes! I want to do that too. After the mono-repo transition is finalized I think we need to invest

[PATCH] D67585: [clang] [cmake] Make building dylib optional

mgorny added a comment. But in that case, we should aim for consistency, i.e. remove the matching option from LLVM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67585/new/ https://reviews.llvm.org/D67585 ___ cfe-commits mailing list

[PATCH] D67585: [clang] [cmake] Make building dylib optional

beanz added a reviewer: compnerd. beanz added a comment. In D67585#1670433 , @mgorny wrote: > This is really much more work than disabling the one component I don't need > or care for, especially when I do shared lib build and therefore the > additional

[PATCH] D67588: Add builtin trait for add/remove cv (and similar)

lebedev.ri added a comment. > The `__remove_cv` test sees a 160% build time imporvement while the > `__add_cv` test sees an 8% improvement. Those numbers are specifically for those macrobenchmarks, right? What impact does this have on some real-world code? I'm just curious as to cost/benefit

[PATCH] D67588: Add builtin trait for add/remove cv (and similar)

zoecarver updated this revision to Diff 220227. zoecarver added a comment. Generate diff based on D67052 (arc wasn't working so I had to do it manually this time). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67588/new/

[PATCH] D67588: Add builtin trait for add/remove cv (and similar)

zoecarver created this revision. zoecarver added reviewers: EricWF, eli.friedman, rsmith, craig.topper, mclow.lists. zoecarver added projects: clang, libc++. zoecarver updated this revision to Diff 220226. zoecarver added a comment. - diff from D67052 , not

[PATCH] D67588: Add builtin trait for add/remove cv (and similar)

zoecarver updated this revision to Diff 220226. zoecarver added a comment. - diff from D67052 , not master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67588/new/ https://reviews.llvm.org/D67588 Files:

Re: r371918 - [Driver] Fix multiple bugs related to dependency file options: -M -MM -MD -MMD -MT -MQ

This looks similar to https://reviews.llvm.org/D67542 On Sat, Sep 14, 2019 at 1:59 AM Fangrui Song via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: maskray > Date: Fri Sep 13 23:01:22 2019 > New Revision: 371918 > > URL: http://llvm.org/viewvc/llvm-project?rev=371918=rev > Log: >

[PATCH] D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions.

Szelethus added a comment. Aha, so every user gets to create their own `PathDiagnosticConsumerOptions` object, makes sense! There is no interface misconception, because `-analyzer-config` will only configure what the analyzer would tinket with. I like this patch! If you dont mind, I'd prefer

[PATCH] D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr.

sebpop added a comment. I still see a link error on aarch64-linux on master: /usr/bin/ld: tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/AttrImpl.cpp.o: in function `clang::AttributeCommonInfo::getAttributeSpellingListIndex() const':

[PATCH] D67585: [clang] [cmake] Make building dylib optional

mgorny added a comment. In D67585#1670422 , @beanz wrote: > In D67585#1670420 , @mgorny wrote: > > > Sure but I want to build-test practically everything else. I wouldn't mind > > if this didn't basically kill my

[PATCH] D67585: [clang] [cmake] Make building dylib optional

beanz added a comment. In D67585#1670420 , @mgorny wrote: > Sure but I want to build-test practically everything else. I wouldn't mind if > this didn't basically kill my test system by resource exhaustion You can use the ‘LLVM_DISTRIBUTION_COMPONENTS’

[PATCH] D67585: [clang] [cmake] Make building dylib optional

mgorny added a comment. Sure but I want to build-test practically everything else. I wouldn't mind if this didn't basically kill my test system by resource exhaustion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67585/new/ https://reviews.llvm.org/D67585

[PATCH] D67585: [clang] [cmake] Make building dylib optional

mgorny added a comment. Also note that I'm leaving it enabled by default, so only people explicitly opting out would not be testing it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67585/new/ https://reviews.llvm.org/D67585 ___

[PATCH] D67585: [clang] [cmake] Make building dylib optional

beanz requested changes to this revision. beanz added a comment. This revision now requires changes to proceed. Please no. You don’t need to build the library. ‘check-clang’ doesn’t depend on it, so it should not impact your build and test cycles. We want it included in the ‘all’ target for

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length

Charusso added a comment. Hm, I wanted to upload the new patch here to see the changes with the diff-mode, but it does not work, sorry. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45050/new/ https://reviews.llvm.org/D45050

[PATCH] D67385: Pass -mcmodel to LTO plugin

khchen updated this revision to Diff 220218. khchen retitled this revision from "Pass -mcmodel to gold-pulgin" to "Pass -mcmodel to LTO plugin". khchen edited the summary of this revision. khchen added a comment. Herald added subscribers: steven_wu, inglorion. added a test CHANGES SINCE LAST

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length

Charusso updated this revision to Diff 220215. Charusso edited the summary of this revision. Charusso removed reviewers: hokein, ilya-biryukov, xbolva00, dyung. Charusso set the repository for this revision to rCTE Clang Tools Extra. Charusso added a comment. Herald added a project: clang. After

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

khchen updated this revision to Diff 220214. khchen edited the summary of this revision. khchen added a comment. Herald added subscribers: fedor.sergeev, aheejin, dschuff. This commit is inspired by @MaskRay's suggestion, I think maybe fix the insufficient of clang::driver:tools::AddGoldPlugin

[PATCH] D67585: [clang] [cmake] Make building dylib optional

mgorny created this revision. mgorny added reviewers: tstellar, sylvestre.ledru, smeenai, beanz. Similarly to how LLVM dylib can be disabled via LLVM_BUILD_LLVM_DYLIB, introduce CLANG_BUILD_CLANG_DYLIB to make it possible to disable building clang's dylib. This is useful for pure testing

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker added a comment. @rsmith Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D67584: [Support] Replace function with function_ref in writeFileAtomically. NFC

ilya-biryukov updated this revision to Diff 220209. ilya-biryukov added a comment. - Reformat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67584/new/ https://reviews.llvm.org/D67584 Files: llvm/include/llvm/Support/FileUtilities.h

[PATCH] D67584: [Support] Replace function with function_ref in writeFileAtomically. NFC

ilya-biryukov created this revision. ilya-biryukov added a reviewer: jkorous. Herald added subscribers: llvm-commits, jfb, dexonsmith, hiraditya. Herald added a project: LLVM. The latter is slightly more efficient and communicates the intent of the API: writeFileAtomically does not own or copy

r371920 - [clang-scan-deps] Add -M to work around -MT issue after r371918

Author: maskray Date: Sat Sep 14 00:25:27 2019 New Revision: 371920 URL: http://llvm.org/viewvc/llvm-project?rev=371920=rev Log: [clang-scan-deps] Add -M to work around -MT issue after r371918 gcc will complain if -MT is used but neither -M nor -MM is specified: > cc1: error: to generate