[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille updated this revision to Diff 224254. serge-sans-paille added a comment. Added documentation + release note entry Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68720 Files: clang/docs/Releas

[PATCH] D68377: [Builtins] Teach Clang about memccpy

xbolva00 abandoned this revision. xbolva00 added a comment. Abandoned since D67986 was abandoned too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68377/new/ https://reviews.llvm.org/D68377 ___ cfe-commits

[PATCH] D68193: In openFileForRead don't cache erroneous entries if the error relates to them being directories. Add tests.

dexonsmith accepted this revision. dexonsmith added a comment. LGTM too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68193/new/ https://reviews.llvm.org/D68193 ___ cfe-commits mailing list cfe-commit

r374276 - [ast] Fix indentation. NFC.

Author: hliao Date: Wed Oct 9 21:16:52 2019 New Revision: 374276 URL: http://llvm.org/viewvc/llvm-project?rev=374276&view=rev Log: [ast] Fix indentation. NFC. Modified: cfe/trunk/include/clang/AST/Decl.h Modified: cfe/trunk/include/clang/AST/Decl.h URL: http://llvm.org/viewvc/llvm-project/

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

nridge updated this revision to Diff 224241. nridge added a comment. Updated to use WalkUpFromDependentNameTypeLoc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67901/new/ https://reviews.llvm.org/D67901 Files: clang-tools-extra/clangd/SemanticH

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

nridge added a comment. Is this what you had in mind? I'm not seeing where the `kindForType` part comes in. In particular, it seems like it would be silly to call `kindForType` in `WalkUpFromDependentNameTypeLoc()`, because we //know// the answer will be `HighlightingKind::DependentType`. Re

[PATCH] D68637: [libTooling] Move Transformer files to their own directory/library.

ymandel marked 2 inline comments as done. ymandel added inline comments. Comment at: clang/lib/Tooling/Transformer/CMakeLists.txt:3 + +add_clang_library(clangTransformer + RangeSelector.cpp thakis wrote: > All the other libs in lib/Tooling/Foo are called clangTo

r374274 - [sema] Revise `getCurrentMangleNumberContext` interface. NFC.

Author: hliao Date: Wed Oct 9 20:14:51 2019 New Revision: 374274 URL: http://llvm.org/viewvc/llvm-project?rev=374274&view=rev Log: [sema] Revise `getCurrentMangleNumberContext` interface. NFC. - Prefer returning mulitple values using a tuple instead of additional pointers/references. Modified

[PATCH] D68637: [libTooling] Move Transformer files to their own directory/library.

thakis added inline comments. Comment at: clang/lib/Tooling/Transformer/CMakeLists.txt:3 + +add_clang_library(clangTransformer + RangeSelector.cpp All the other libs in lib/Tooling/Foo are called clangToolingFoo, not clangFoo. Can you please rename this library

[PATCH] D68637: [libTooling] Move Transformer files to their own directory/library.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfbdf83521b17: [libTooling] Move Transformer files to their own directory/library. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68637/

[clang-tools-extra] r374271 - [libTooling] Move Transformer files to their own directory/library.

Author: ymandel Date: Wed Oct 9 19:34:47 2019 New Revision: 374271 URL: http://llvm.org/viewvc/llvm-project?rev=374271&view=rev Log: [libTooling] Move Transformer files to their own directory/library. Summary: The Transformer library has been growing inside of lib/Tooling/Refactoring. However, i

[PATCH] D68252: [Stats] Add ALWAYS_ENABLED_STATISTIC enabled regardless of LLVM_ENABLE_STATS.

vsapsai marked 2 inline comments as done. vsapsai added a comment. Thanks for the review. Comment at: llvm/include/llvm/ADT/Statistic.h:47 -class Statistic { +class StatisticBase { public: dsanders wrote: > Do we actually need the common base class? I'm thin

[PATCH] D68756: [libc++][test] Change IsSmallObject's calculation for std::any's small object buffer

CaseyCarter marked an inline comment as done. CaseyCarter added inline comments. Comment at: libcxx/test/support/any_helpers.h:24 : public std::integral_constant::value I have no idea why this line is highlighted: there are no changes on this line in the di

[PATCH] D68252: [Stats] Add ALWAYS_ENABLED_STATISTIC enabled regardless of LLVM_ENABLE_STATS.

vsapsai updated this revision to Diff 224235. vsapsai marked an inline comment as done. vsapsai added a comment. Herald added a subscriber: jfb. - Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68252/new/ https://reviews.llvm.org/D68252 Files: clang/include/cl

[PATCH] D68756: [libc++][test] Change IsSmallObject's calculation for std::any's small object buffer

CaseyCarter created this revision. CaseyCarter added reviewers: mclow.lists, EricWF, ldionne. CaseyCarter added a project: libc++. Herald added subscribers: libcxx-commits, dexonsmith, christof. `sizeof(std::any) - sizeof(void*)` is correct for both libc++ and the MSVC standard library. Reposit

[PATCH] D68193: In openFileForRead don't cache erroneous entries if the error relates to them being directories. Add tests.

Bigcheese accepted this revision. Bigcheese added a comment. lgtm, but wait for Alex or Duncan to also take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68193/new/ https://reviews.llvm.org/D68193

[PATCH] D68193: In openFileForRead don't cache erroneous entries if the error relates to them being directories. Add tests.

kousikk updated this revision to Diff 224228. kousikk added a comment. Remove getError() function that's now unused Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68193/new/ https://reviews.llvm.org/D68193 Files: clang/include/clang/Tooling/Depen

[PATCH] D68193: In openFileForRead don't cache erroneous entries if the error relates to them being directories. Add tests.

Bigcheese added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningFilesystem.h:83 + std::error_code getError() const { +assert(isValid() && "not initialized"); Is this actually called anywhere? Repository: r

[PATCH] D68743: [ARM] Fix arm_neon.h with -flax-vector-conversions=none, part 2.

efriedma updated this revision to Diff 224229. efriedma edited the summary of this revision. efriedma added a comment. Found another broken case. Fix, and add more test coverage. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68743/new/ https://reviews.llvm.org/D

[PATCH] D68753: [CUDA][HIP} Add a test for constexpr default ctor

yaxunl created this revision. yaxunl added a reviewer: tra. https://reviews.llvm.org/D68753 Files: test/SemaCUDA/constexpr-ctor.cu Index: test/SemaCUDA/constexpr-ctor.cu === --- /dev/null +++ test/SemaCUDA/constexpr-ctor.cu @@ -0

r374269 - Re-land [mangle] Fix mangling where an extra mangle context is required.

Author: rnk Date: Wed Oct 9 18:14:22 2019 New Revision: 374269 URL: http://llvm.org/viewvc/llvm-project?rev=374269&view=rev Log: Re-land [mangle] Fix mangling where an extra mangle context is required. This reverts r374268 (git commit c34385d07c7d59447bf836b740f032235391d121) I think I reverted

r374268 - Revert [mangle] Fix mangling where an extra mangle context is required.

Author: rnk Date: Wed Oct 9 18:10:01 2019 New Revision: 374268 URL: http://llvm.org/viewvc/llvm-project?rev=374268&view=rev Log: Revert [mangle] Fix mangling where an extra mangle context is required. This reverts r374200 (git commit fd18e94697c987d5f24e25aa4e27ada3cce4) Causes crashes just

[PATCH] D68733: Use -fdebug-compilation-dir to form absolute paths in coverage mappings

This revision was automatically updated to reflect the committed changes. Closed by commit rGf6777964bde2: Use -fdebug-compilation-dir to form absolute paths in coverage mappings (authored by rnk). Changed prior to commit: https://reviews.llvm.org/D68733?vs=224172&id=224221#toc Repository: r

[PATCH] D68193: In openFileForRead don't cache erroneous entries if the error relates to them being directories. Add tests.

kousikk updated this revision to Diff 224219. kousikk added a comment. - Revert changes to createFileEntry since that may result in a race condition if stat is called before file open Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68193/new/ https:

r374266 - Use -fdebug-compilation-dir to form absolute paths in coverage mappings

Author: rnk Date: Wed Oct 9 17:54:33 2019 New Revision: 374266 URL: http://llvm.org/viewvc/llvm-project?rev=374266&view=rev Log: Use -fdebug-compilation-dir to form absolute paths in coverage mappings This allows users to explicitly request relative paths with `-fdebug-compilation-dir .`. Fixes

[PATCH] D68166: [Clang][OpenMP Offload] Add new tool for wrapping offload device binaries

sdmitriev added a comment. In D68166#1702487 , @thakis wrote: > Out of interest (or ignorance :) ), why is this a separate binary instead of > just part of the normal `clang` driver? C, C++, Objective-C, and assembly all > can do with a single driver, ye

[PATCH] D68720: Support -fstack-clash-protection for x86

xbolva00 added a comment. Please add info about this new feature to release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68720 ___ cfe-commits mailing list c

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev added a comment. I have uploaded the last part to https://reviews.llvm.org/D68746 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64943/new/ https://reviews.llvm.org/D64943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D68720: Support -fstack-clash-protection for x86

efriedma added a comment. > (b) is an issue, as pointed out in https://lwn.net/Articles/726587/ (grep for > valgrind) : from valgrind point of view, accessing un-allocated stack memory > triggers error, and we probably want to please valgrind > > Doing the call *after* the stack allocation is a

[PATCH] D68733: Use -fdebug-compilation-dir to form absolute paths in coverage mappings

rnk marked an inline comment as done. rnk added inline comments. Comment at: clang/test/CoverageMapping/debug-dir.cpp:14 +// +// RELATIVE: @__llvm_coverage_mapping = {{.*"\\01[^/]*foobar.*debug-dir\.cpp}} + vsk wrote: > Does the "[^/]" check work on Windows, or i

[PATCH] D67837: [CUDA][HIP] Fix host/device check with -fopenmp

This revision was automatically updated to reflect the committed changes. Closed by commit rG229c78d3a5d1: [CUDA][HIP] Fix host/device check with -fopenmp (authored by yaxunl). Changed prior to commit: https://reviews.llvm.org/D67837?vs=224126&id=224208#toc Repository: rG LLVM Github Monorep

r374263 - [CUDA][HIP] Fix host/device check with -fopenmp

Author: yaxunl Date: Wed Oct 9 16:54:10 2019 New Revision: 374263 URL: http://llvm.org/viewvc/llvm-project?rev=374263&view=rev Log: [CUDA][HIP] Fix host/device check with -fopenmp CUDA/HIP program may be compiled with -fopenmp. In this case, -fopenmp is only passed to host compilation to take a

[PATCH] D68733: Use -fdebug-compilation-dir to form absolute paths in coverage mappings

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks, lgtm! In PR43614 I mentioned adding an extra argument to llvm-cov to specify the base directory. On second thought, the existing `-path-equivalence` option should make that unnecessary.

[PATCH] D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour

rupprecht added a comment. Just wanna say huge +1 for this patch. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67122/new/ https://reviews.llvm.org/D67122 ___ cfe-commits mailing list cfe-commi

[PATCH] D68743: [ARM] Fix arm_neon.h with -flax-vector-conversions=none, part 2.

efriedma created this revision. efriedma added reviewers: rsmith, SjoerdMeijer. Herald added a subscriber: kristof.beyls. Herald added a project: clang. Just running -fsyntax-only over arm_neon.h doesn't cover some intrinsics which are defined using macros. Add more test coverage for that, then

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille added a comment. @efriedma alos compared to `probe-stack` with a function, this version has the ability to use existing MOV operations to avoid generating probes, which looks like a big plus to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

probinson added a comment. We really do want to pack the four mutually exclusive cases into two bits. I have tried to give more explicit comments inline to explain how you would do this. It really should work fine, recognizing that the "not defaulted" case is not explicitly represented in the

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille updated this revision to Diff 224196. serge-sans-paille added a comment. Move to `stack-probe` compatibility, using a dedicated name to trigger inline assembly. It looks better to me because 1. it leverage existing mechanics 2. it has a finer grain Repository: rG LLVM Githu

[PATCH] D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/docs/ReleaseNotes.rst:66 + defined if it adds a non-zero offset (or in C, any offset) to a null pointer, + or that forms a null pointer by subtracting

[PATCH] D68736: [MSVC] Automatically add atlmfc include and lib directories as system paths.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm I think the old VS Express editions used to exclude atlmfc, so there's the possibility that we'll be searching non-existent directories, but I think that's OK. Whoever wrote this code was prob

Re: r374006 - Reland 'Add VFS support for sanitizers' blacklist'

Ok, no worries. I understand the reason for the revert and will rewrite the patch. > On Oct 9, 2019, at 7:19 AM, Ilya Biryukov wrote: > > Fair enough, sorry about that. > > Nevertheless, I wanted to re-raise concerns about the approach taken in the > patch. It seems to assume invariants abou

[PATCH] D68736: [MSVC] Automatically add atlmfc include and lib directories as system paths.

zturner added a comment. In D68736#1702482 , @amccarth wrote: > > This matches the behavior of cl. > > Are you sure? In a bare environment, cl.exe doesn't include any system > paths, not even to the standard library. It actually uses the INCLUDE > envi

[PATCH] D68681: [libc++][test] Miscellaneous MSVC cleanups

CaseyCarter added a comment. In D68681#1702194 , @ldionne wrote: > You have commit access, right? If so, go ahead. Otherwise, LMK and I can > commit this for you. Yes, I apparently still have commit access ;) Thanks! Repository: rG LLVM Github Monor

[PATCH] D68736: [MSVC] Automatically add atlmfc include and lib directories as system paths.

amccarth added a comment. > This matches the behavior of cl. Are you sure? In a bare environment, cl.exe doesn't include any system paths, not even to the standard library. It actually uses the INCLUDE environment variable for those paths. Granted, VCVARSALL sets that (and other environment

[PATCH] D68166: [Clang][OpenMP Offload] Add new tool for wrapping offload device binaries

thakis added a comment. Out of interest (or ignorance :) ), why is this a separate binary instead of just part of the normal `clang` driver? C, C++, Objective-C, and assembly all can do with a single driver, yet the offload stuff now has both clang-offload-wrapper and clang-offload-bundler. Why

[PATCH] D68681: [libc++][test] Miscellaneous MSVC cleanups

This revision was automatically updated to reflect the committed changes. Closed by commit rGb2e3c83b0d64: [libc++][test] Miscellaneous MSVC cleanups (authored by CaseyCarter). Herald added a subscriber: christof. Herald added a project: libc++. Changed prior to commit: https://reviews.llvm.org

[PATCH] D68736: [MSVC] Automatically add atlmfc include and lib directories as system paths.

zturner created this revision. zturner added a reviewer: rnk. This matches the behavior of cl. https://reviews.llvm.org/D68736 Files: clang/lib/Driver/ToolChains/MSVC.cpp clang/lib/Driver/ToolChains/MSVC.h Index: clang/lib/Driver/ToolChains/MSVC.h =

[PATCH] D68733: Use -fdebug-compilation-dir to form absolute paths in coverage mappings

rnk created this revision. rnk added reviewers: vsk, arphaman. Herald added a subscriber: dexonsmith. Herald added a project: clang. This allows users to explicitly request relative paths with `-fdebug-compilation-dir .`. Fixes PR43614 Repository: rG LLVM Github Monorepo https://reviews.llvm

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

boga95 marked 2 inline comments as done. boga95 added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59516/new/ https://reviews.llvm.org/D59516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D68682: Clang-tidy fix removals removing all non-blank text from a line should remove the line

poelmanc marked an inline comment as done. poelmanc added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidy.cpp:27 #include "clang/ASTMatchers/ASTMatchFinder.h" +#include "clang/Basic/CharInfo.h" // for isWhiteSpace(char), isVerticalWhitespace(char) #include

[PATCH] D68716: [clang] prevent crash for nonnull attribut in constant context (Bug 43601)

Tyker updated this revision to Diff 224169. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68716/new/ https://reviews.llvm.org/D68716 Files: clang/lib/AST/ExprConstant.cpp clang/test/SemaCXX/attr-nonnull.cpp Index: clang/test/SemaCXX/attr-nonnull.cpp

[PATCH] D68193: In openFileForRead don't cache erroneous entries if the error relates to them being directories. Add tests.

Bigcheese added a comment. In D68193#1701426 , @kousikk wrote: > @arphaman I don't mind changing this if there are race conditions as you say, > but isn't the assumption of the tool that the filesystem remains unchanged > for a single run of the tool? If

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille added a comment. @efriedma : there's indeed an intersection with the `probe-stack` attribute. The `probe-stack` attribute (a) forces a function call, and (b) this function call only happens **before** the stack gets expanded. (a) is probably a performance issue in several case

[PATCH] D51741: [coro]Pass rvalue reference for named local variable to return_value

Quuxplusone added inline comments. Comment at: cfe/trunk/lib/Sema/SemaCoroutine.cpp:857-859 // FIXME: If the operand is a reference to a variable that's about to go out // of scope, we should treat the operand as an xvalue for this overload // resolution. ---

[PATCH] D68055: Add -fgnuc-version= to control __GNUC__ and other GCC macros

rnk updated this revision to Diff 224155. rnk added a comment. - Fix __GNUG__, tighten tests for it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68055/new/ https://reviews.llvm.org/D68055 Files: clang/docs/ReleaseNotes.rst clang/docs/UsersMan

[PATCH] D67159: [clang] New __attribute__((__clang_arm_mve_alias)).

aaron.ballman marked an inline comment as done. aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticASTKinds.td:539 "packed attribute is unnecessary for %0">, InGroup, DefaultIgnore; + } Spurious newline? Co

[PATCH] D68539: [clang-tidy] fix for readability-identifier-naming incorrectly fixes variables which become keywords

Daniel599 updated this revision to Diff 224151. Daniel599 added a comment. code-review fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68539/new/ https://reviews.llvm.org/D68539 Files: clang-tools-extra/clang-tidy/readability/IdentifierNamin

r374224 - [OPENMP50]Fix scoring of contexts with and without user provided scores.

Author: abataev Date: Wed Oct 9 13:54:06 2019 New Revision: 374224 URL: http://llvm.org/viewvc/llvm-project?rev=374224&view=rev Log: [OPENMP50]Fix scoring of contexts with and without user provided scores. The context selector with user provided score must have higher score than the context sele

[PATCH] D68539: [clang-tidy] fix for readability-identifier-naming incorrectly fixes variables which become keywords

Daniel599 marked 3 inline comments as done. Daniel599 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:868 + if (CheckNewIdentifier != Idents.end() && + CheckNewIdentifier->second->isKeyword(getLangOpts())) { +

[PATCH] D68660: [tooling] Teach Tooling to understand compilation with offloading.

tra added inline comments. Comment at: clang/lib/Tooling/Tooling.cpp:117 // The one job we find should be to invoke clang again. const auto &Cmd = cast(*Jobs.begin()); if (StringRef(Cmd.getCreator().getName()) != "clang") { hliao wrote: > tra wrote: > >

[PATCH] D68166: [Clang][OpenMP Offload] Add new tool for wrapping offload device binaries

This revision was automatically updated to reflect the committed changes. Closed by commit rGa0d83768f108: [Clang][OpenMP Offload] Add new tool for wrapping offload device binaries (authored by sdmitriev). Changed prior to commit: https://reviews.llvm.org/D68166?vs=223335&id=224146#toc Reposit

r374219 - [Clang][OpenMP Offload] Add new tool for wrapping offload device binaries

Author: sdmitriev Date: Wed Oct 9 13:42:58 2019 New Revision: 374219 URL: http://llvm.org/viewvc/llvm-project?rev=374219&view=rev Log: [Clang][OpenMP Offload] Add new tool for wrapping offload device binaries This patch removes the remaining part of the OpenMP offload linker scripts which was u

[PATCH] D68055: Add -fgnuc-version= to control __GNUC__ and other GCC macros

programmerjake requested changes to this revision. programmerjake added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:589 +if (LangOpts.CPlusPlus) { + Builder.defineMacro("__GNUG__", Twine(GNUCMinor));

[libunwind] r374218 - Bump version to 9.0.1

Author: tstellar Date: Wed Oct 9 13:41:02 2019 New Revision: 374218 URL: http://llvm.org/viewvc/llvm-project?rev=374218&view=rev Log: Bump version to 9.0.1 Modified: libunwind/branches/release_90/CMakeLists.txt Modified: libunwind/branches/release_90/CMakeLists.txt URL: http://llvm.org/vie

[PATCH] D68681: [libc++][test] Miscellaneous MSVC cleanups

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. You have commit access, right? If so, go ahead. Otherwise, LMK and I can commit this for you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68681/new/ https://reviews.llvm.org/D686

[PATCH] D51741: [coro]Pass rvalue reference for named local variable to return_value

aaronpuchert added a comment. In D51741#1702038 , @Quuxplusone wrote: > This patch is heavily heavily merge-conflicted by P1825 > . Just to be clear, this change is pretty old: it's a

[PATCH] D68055: Add -fgnuc-version= to control __GNUC__ and other GCC macros

rnk updated this revision to Diff 224141. rnk added a comment. - add docs, release note - keep __EXCEPTIONS if !ms - keep __private_extern__ if !ms - set __GNUG__ value with flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68055/new/ https://revi

[PATCH] D68725: [analyzer] MemoryBlockRegion: Generalize AllocaRegion

Charusso created this revision. Charusso added reviewers: NoQ, xazax.hun. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. This patch generalizes the `AllocaRegion` to store met

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc marked 5 inline comments as done. mibintc added inline comments. Comment at: clang/docs/UsersManual.rst:1330 + and ``fast``. + Details: + rjmccall wrote: > rjmccall wrote: > > "provided by other, single-purpose floating point options." > I don't know

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

rsmith updated this revision to Diff 224138. rsmith added a comment. Update documentation and release notes. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67678/new/ https://reviews.llvm.org/D67678 Files: docs/CommandGuide/clang.rst docs/ReleaseNotes.rst i

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 224136. mibintc retitled this revision from "[RFC] Add support for options -frounding-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior" to "Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception

[PATCH] D68716: [clang] prevent crash for nonnull attribut in constant context (Bug 43601)

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks. Comment at: clang/lib/AST/ExprConstant.cpp:5446 I != E; ++I) { if (!Evaluate(ArgValues[I - Args.begin()], Info, *I)) { // If we're checking for a

[PATCH] D68682: Clang-tidy fix removals removing all non-blank text from a line should remove the line

MyDeveloperDay added a comment. @poelmanc thank you for the very detailed explanation to what was probably my very naive point, I have to say with more information I am inclined to agree with you that perhaps you need to see all the replacements as a whole to make reasonable assumptions. But I

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

rsmith updated this revision to Diff 224130. rsmith added a comment. Remove special-casing of ARM NEON; let's wait for to get fixed before landing this. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67678/new/ https://reviews.llvm.org/D67678 Files: include/c

[PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

MyDeveloperDay added a comment. As this behaviour is not something clang-format should do because there are external tool that can do this for us, I thought I'd set myself a challenge of trying to write this with external tools, to prove to myself that it was indeed easy, what I want to achieve

[PATCH] D68551: [clang-format] [NFC] Ensure clang-format is itself clang-formatted.

Meinersbur added a comment. We should seek having only one formatting policy for the entire project, it's too confusing otherwise (e.g. LLVMSupport/ADT is also used by clang-format, are they force-formatted as well? What about the tools/utils subdirectories?). If you would like to gradually mov

[PATCH] D68722: Add an example showing the alternative to nested designators

shafik created this revision. shafik added a reviewer: rsmith. We have an example showing that a nested designators are a c99 extension but not an example showing how to achieve the same thing using a brace-init-list in a designated-initializer-clause. https://reviews.llvm.org/D68722 Files:

[PATCH] D66696: [ObjC generics] Fix not inheriting type bounds in categories/extensions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG02c2ab3d8872: [ObjC generics] Fix not inheriting type bounds in categories/extensions. (authored by vsapsai). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D66696: [ObjC generics] Fix not inheriting type bounds in categories/extensions.

vsapsai added a comment. Thanks for the review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66696/new/ https://reviews.llvm.org/D66696 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D68551: [clang-format] [NFC] Ensure clang-format is itself clang-formatted.

MyDeveloperDay added a comment. > Btw, I am the author of the CMakeLists snippet quoted by @MyDeveloperDay. > Before that, it was a shell script that didn't run on Windows. Making it part > of the regression test basically eliminated all discussion about code > formatting, but we had to run l

[PATCH] D67837: [CUDA][HIP] Fix host/device check with -fopenmp

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67837/new/ https://reviews.llvm.org/D67837 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D68683: ARM] Fix arm_neon.h with -flax-vector-conversions=none

rsmith added a comment. In D68683#1701769 , @rsmith wrote: > We also have a hack in the ARM and AArch64 target info to set the default for > lax vector conversions back to "all" when NEON is enabled that can now be > removed. Never mind, looks like I d

r374202 - [ObjC generics] Fix not inheriting type bounds in categories/extensions.

Author: vsapsai Date: Wed Oct 9 12:29:13 2019 New Revision: 374202 URL: http://llvm.org/viewvc/llvm-project?rev=374202&view=rev Log: [ObjC generics] Fix not inheriting type bounds in categories/extensions. When a category/extension doesn't repeat a type bound, corresponding type parameter is sub

[PATCH] D67837: [CUDA][HIP] Fix host/device check with -fopenmp

yaxunl added inline comments. Comment at: lib/Sema/SemaCUDA.cpp:604 // Do we know that we will eventually codegen the given function? static bool IsKnownEmitted(Sema &S, FunctionDecl *FD) { + return S.getEmissionStatus(FD) == Sema::FunctionEmissionStatus::Emitted;

[PATCH] D67837: [CUDA][HIP] Fix host/device check with -fopenmp

yaxunl updated this revision to Diff 224126. yaxunl marked 8 inline comments as done. yaxunl added a comment. revised by Alexey's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67837/new/ https://reviews.llvm.org/D67837 Files: include/clang/Sema/Sema.h lib/Sema/SemaCUDA.cp

[PATCH] D51741: [coro]Pass rvalue reference for named local variable to return_value

Quuxplusone added a comment. In D51741#1701757 , @aaronpuchert wrote: > This change breaks the following code that worked before: > > task f(MoveOnly &value) { > co_return value; > } > This patch is heavily heavily merge-conflicted by P1825

[PATCH] D68539: [clang-tidy] fix for readability-identifier-naming incorrectly fixes variables which become keywords

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:865 + IdentifierTable &Idents = Decl->getASTContext().Idents; + auto CheckNewIdentifier = Idents.find(Fixup); Can this be `const Ident

[PATCH] D68682: Clang-tidy fix removals removing all non-blank text from a line should remove the line

poelmanc added a comment. In D68682#1700908 , @Eugene.Zelenko wrote: > You may be interested to also look on PR43583 related to > readability-redundant-member-init. Thanks Eugene, I'm having trouble finding that. https://reviews.llvm.org/D43583 seems

[PATCH] D68720: Support -fstack-clash-protection for x86

efriedma added a comment. Sorry, I meant the "probe-stack" attribute. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68720 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D68720: Support -fstack-clash-protection for x86

efriedma added a comment. Is there some reason this isn't using the existing stack-probe-size attribute? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68720 ___ cfe

[PATCH] D68074: [clang-tidy] Add readability-make-member-function-const

mgehre marked 2 inline comments as done. mgehre added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-make-member-function-const.rst:10 +The check conservatively tries to preserve logical costness in favor of +physical costness. The only operati

[PATCH] D68660: [tooling] Teach Tooling to understand compilation with offloading.

hliao marked an inline comment as done. hliao added inline comments. Comment at: clang/lib/Tooling/Tooling.cpp:117 // The one job we find should be to invoke clang again. const auto &Cmd = cast(*Jobs.begin()); if (StringRef(Cmd.getCreator().getName()) != "clang") { -

[PATCH] D68715: [mangle] Fix mangling where an extra mangle context is required.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfd18e94697c9: [mangle] Fix mangling where an extra mangle context is required. (authored by hliao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68715/new/

[PATCH] D68715: [mangle] Fix mangling where an extra mangle context is required.

hliao added a comment. In D68715#1701986 , @efriedma wrote: > LGTM Thanks. BTW, shall I commit the refactoring code directly. That change just replaces the code returning multiple values from pointer/reference argument with a tuple. Repository: rG

r374200 - [mangle] Fix mangling where an extra mangle context is required.

Author: hliao Date: Wed Oct 9 12:08:52 2019 New Revision: 374200 URL: http://llvm.org/viewvc/llvm-project?rev=374200&view=rev Log: [mangle] Fix mangling where an extra mangle context is required. Summary: - [Itanium C++ ABI][1], for certain contexts like default parameter and etc., mangling nu

[PATCH] D68715: [mangle] Fix mangling where an extra mangle context is required.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68715/new/ https://reviews.llvm.org/D68715 ___

[PATCH] D68682: Clang-tidy fix removals removing all non-blank text from a line should remove the line

poelmanc updated this revision to Diff 224089. poelmanc retitled this revision from "Clang-tidy fixes should avoid creating new blank lines" to "Clang-tidy fix removals removing all non-blank text from a line should remove the line". poelmanc edited the summary of this revision. poelmanc added a

[PATCH] D68660: [tooling] Teach Tooling to understand compilation with offloading.

tra added inline comments. Comment at: clang/lib/Tooling/Tooling.cpp:117 // The one job we find should be to invoke clang again. const auto &Cmd = cast(*Jobs.begin()); if (StringRef(Cmd.getCreator().getName()) != "clang") { hliao wrote: > tra wrote: > >

[PATCH] D68074: [clang-tidy] Add readability-make-member-function-const

mgehre marked an inline comment as done. mgehre added inline comments. Comment at: clang-tools-extra/test/clang-tidy/readability-make-member-function-const.cpp:311 + // This member function must stay non-const, even though + // it only calls other private const member function

[PATCH] D51741: [coro]Pass rvalue reference for named local variable to return_value

modocache added a subscriber: lewissbaker. modocache added a comment. > Is that maybe intentional, and is the code not intended to compile? It looks like it should work to me, but maybe @lewissbaker or @GorNishanov can answer definitively. Comment at: cfe/trunk/lib/Sema/SemaC

  1   2   3   >