[PATCH] D68931: [clang] [clang-offload-bundler] Fix finding installed llvm-objcopy

This revision was automatically updated to reflect the committed changes. Closed by commit rGf89e758d886a: [clang] [clang-offload-bundler] Fix finding installed llvm-objcopy (authored by mgorny). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

r374754 - [clang] [clang-offload-bundler] Fix finding installed llvm-objcopy

Author: mgorny Date: Sun Oct 13 22:33:23 2019 New Revision: 374754 URL: http://llvm.org/viewvc/llvm-project?rev=374754=rev Log: [clang] [clang-offload-bundler] Fix finding installed llvm-objcopy Allow finding installed llvm-objcopy in PATH if it's not present in the directory containing

[clang-tools-extra] r374753 - clangd tests: use extended regex with sed

Author: nico Date: Sun Oct 13 20:44:47 2019 New Revision: 374753 URL: http://llvm.org/viewvc/llvm-project?rev=374753=rev Log: clangd tests: use extended regex with sed The escaped parens seem to confuse the combination of lit, cygwin quoting, and cygwin's sed. unxutils sed in cmd.exe is fine

[PATCH] D68931: [clang] [clang-offload-bundler] Fix finding installed llvm-objcopy

sdmitriev accepted this revision. sdmitriev added a comment. Looks good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68931/new/ https://reviews.llvm.org/D68931 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r374752 - convert another test to unix line endings

Author: nico Date: Sun Oct 13 19:21:12 2019 New Revision: 374752 URL: http://llvm.org/viewvc/llvm-project?rev=374752=rev Log: convert another test to unix line endings Modified: clang-tools-extra/trunk/clangd/test/symbol-info.test Modified:

[clang-tools-extra] r374751 - convert a test to unix line endings

Author: nico Date: Sun Oct 13 19:14:18 2019 New Revision: 374751 URL: http://llvm.org/viewvc/llvm-project?rev=374751=rev Log: convert a test to unix line endings Modified: clang-tools-extra/trunk/clangd/test/symbols.test Modified: clang-tools-extra/trunk/clangd/test/symbols.test URL:

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

dblaikie added a comment. In D68117#1707578 , @SouraVX wrote: > In D68117#1702595 , @probinson wrote: > > > We really do want to pack the four mutually exclusive cases into two bits. > > I have tried to give more

[clang-tools-extra] r374750 - fix typo in 374747

Author: nico Date: Sun Oct 13 18:44:29 2019 New Revision: 374750 URL: http://llvm.org/viewvc/llvm-project?rev=374750=rev Log: fix typo in 374747 Modified: clang-tools-extra/trunk/clangd/test/symbols.test Modified: clang-tools-extra/trunk/clangd/test/symbols.test URL:

[clang-tools-extra] r374749 - Prefer 'env not' over 'not env' in tests.

Author: nico Date: Sun Oct 13 18:41:56 2019 New Revision: 374749 URL: http://llvm.org/viewvc/llvm-project?rev=374749=rev Log: Prefer 'env not' over 'not env' in tests. That way, lit's builtin 'env' command can be used for the 'env' bit. Also it's clearer that way that the 'not' shouldn't cover

r374749 - Prefer 'env not' over 'not env' in tests.

Author: nico Date: Sun Oct 13 18:41:56 2019 New Revision: 374749 URL: http://llvm.org/viewvc/llvm-project?rev=374749=rev Log: Prefer 'env not' over 'not env' in tests. That way, lit's builtin 'env' command can be used for the 'env' bit. Also it's clearer that way that the 'not' shouldn't cover

[clang-tools-extra] r374747 - Make symbols.test pass on Windows.

Author: nico Date: Sun Oct 13 18:19:53 2019 New Revision: 374747 URL: http://llvm.org/viewvc/llvm-project?rev=374747=rev Log: Make symbols.test pass on Windows. See commit message of r374746 for details. Hopefully final bit of PR43592. Modified:

[PATCH] D66564: [clang-tidy] new performance struct pack align check

ffrankies added a comment. As per the previous discussion, the check has been moved into the `performance` module. In D66564#1670640 , @lebedev.ri wrote: > I, too, don't believe this is FPGA specific; it should likely go into `misc-` > or even

[PATCH] D66564: [clang-tidy] new performance struct pack align check

ffrankies updated this revision to Diff 224803. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66564/new/ https://reviews.llvm.org/D66564 Files: clang-tidy/performance/CMakeLists.txt clang-tidy/performance/PerformanceTidyModule.cpp clang-tidy/performance/StructPackAlignCheck.cpp

[PATCH] D66564: [clang-tidy] new performance struct pack align check

ffrankies updated this revision to Diff 224802. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66564/new/ https://reviews.llvm.org/D66564 Files: clang-tidy/performance/CMakeLists.txt clang-tidy/performance/PerformanceTidyModule.cpp clang-tidy/performance/StructPackAlignCheck.cpp

[PATCH] D62855: [clangd] Implementation of auto type expansion.

thakis added inline comments. Herald added a subscriber: usaxena95. Comment at: clang-tools-extra/trunk/clangd/test/code-action-request.test:54 +---

[PATCH] D65387: [clangd] Add a callback mechanism for handling responses from client.

thakis added inline comments. Herald added a subscriber: usaxena95. Comment at: clang-tools-extra/trunk/clangd/test/request-reply.test:6 +---

[clang-tools-extra] r374746 - Make code-action-request.test and request-reply.test pass on Windows.

Author: nico Date: Sun Oct 13 18:00:33 2019 New Revision: 374746 URL: http://llvm.org/viewvc/llvm-project?rev=374746=rev Log: Make code-action-request.test and request-reply.test pass on Windows. clangd's test:// scheme expands to /clangd-test on non-Win and to C:/clang-test on Win, so it can't

[clang-tools-extra] r374745 - Don't run background-index.test on Windows.

Author: nico Date: Sun Oct 13 17:45:02 2019 New Revision: 374745 URL: http://llvm.org/viewvc/llvm-project?rev=374745=rev Log: Don't run background-index.test on Windows. The test had a "UNSUPPORTED: win32" line, but the spelling of that changed in r339307 a year ago. Finally update this test

[PATCH] D66564: [clang-tidy] new performance struct pack align check

ffrankies updated this revision to Diff 224799. ffrankies retitled this revision from "[clang-tidy] new FPGA struct pack align check" to "[clang-tidy] new performance struct pack align check". ffrankies edited the summary of this revision. CHANGES SINCE LAST ACTION

[PATCH] D68391: [RISCV] Improve sysroot computation if no GCC install detected

luismarques added a comment. This is indeed an issue that would be nice to fix, I've often been annoyed by clang just defaulting to the root when some misconfiguration occurs. I have to wonder though, this patch only changes the clang RISC-V toolchain driver, but the problem isn't specific to

[PATCH] D67638: Improve __builtin_constant_p lowering

This revision was automatically updated to reflect the committed changes. Closed by commit rG529f4ed401ea: Improve __builtin_constant_p lowering (authored by joerg). Changed prior to commit: https://reviews.llvm.org/D67638?vs=220398=224796#toc Repository: rG LLVM Github Monorepo CHANGES

r374742 - Improve __builtin_constant_p lowering

Author: joerg Date: Sun Oct 13 15:33:46 2019 New Revision: 374742 URL: http://llvm.org/viewvc/llvm-project?rev=374742=rev Log: Improve __builtin_constant_p lowering __builtin_constant_p used to be short-cut evaluated to false when building with -O0. This is undesirable as it means that constant

[PATCH] D68931: [clang] [clang-offload-bundler] Fix finding installed llvm-objcopy

abrachet added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:469 // Find llvm-objcopy in order to create the bundle binary. ErrorOr Objcopy = sys::findProgramByName( "llvm-objcopy",

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

luismarques added a comment. The priority for this patch is to address the issues reported by @apazos but after that please check the clang-format output. There are some cases in this patch where it might make sense to use a different formatting than clang-format indicates, but the remaining

[PATCH] D68931: [clang] [clang-offload-bundler] Fix finding installed llvm-objcopy

mgorny created this revision. mgorny added reviewers: sdmitriev, ABataev. Herald added a reviewer: alexshap. Herald added a subscriber: abrachet. Allow finding installed llvm-objcopy in PATH if it's not present in the directory containing clang-offload-bundler. This is the case if clang is being

[PATCH] D68913: Adds fixit hints to the Wrange-loop-analysis

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:2759 SemaRef.Context.getLValueReferenceType(E->getType().withConst()); -SemaRef.Diag(VD->getBeginLoc(), diag::note_use_type_or_non_reference) -<< NonReferenceType <<

[PATCH] D68824: Fix __builtin_assume_aligned with too large values.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:6067-6070 +// Alignment calculations can wrap around if it's greater than 2**28. +unsigned MaximumAlignment = +Context.getTargetInfo().getTriple().isOSBinFormatCOFF() ? 8192 +

[PATCH] D67159: [clang] New __attribute__((__clang_arm_mve_alias)).

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67159/new/ https://reviews.llvm.org/D67159

[PATCH] D68581: Include leading attributes in DeclStmt's SourceRange

aaron.ballman added inline comments. Comment at: clang/test/AST/sourceranges.cpp:147 + +// CHECK-1Z: NamespaceDecl {{.*}} attributed_decl +namespace attributed_decl { I think these CHECK lines should just be a normal check instead of a C++17 check. CHANGES

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX added a comment. In D68117#1702595 , @probinson wrote: > We really do want to pack the four mutually exclusive cases into two bits. I > have tried to give more explicit comments inline to explain how you would do > this. It really should work

[PATCH] D41217: [Concepts] Concept Specialization Expressions

saar.raz marked 14 inline comments as done and 2 inline comments as done. saar.raz added inline comments. Comment at: lib/Sema/SemaConcept.cpp:51-68 + if (auto *BO = dyn_cast(ConstraintExpr)) { +if (BO->getOpcode() == BO_LAnd) { + if

[PATCH] D41217: [Concepts] Concept Specialization Expressions

saar.raz updated this revision to Diff 224789. saar.raz marked 2 inline comments as done. saar.raz added a comment. Address CR comments by rsmith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41217/new/ https://reviews.llvm.org/D41217 Files:

[clang-tools-extra] r374730 - Add missing "REQUIRES: shell" to system-include-extractor.test

Author: nico Date: Sun Oct 13 10:43:16 2019 New Revision: 374730 URL: http://llvm.org/viewvc/llvm-project?rev=374730=rev Log: Add missing "REQUIRES: shell" to system-include-extractor.test Part of PR43592. Modified: clang-tools-extra/trunk/clangd/test/system-include-extractor.test

[PATCH] D66485: [Clang][Bundler] Use llvm-objcopy for creating fat object files

mgorny added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:467 +ErrorOr Objcopy = sys::findProgramByName( +"llvm-objcopy", sys::path::parent_path(BundlerExecutable)); +if (!Objcopy) { This is broken for

[clang-tools-extra] r374727 - Make the last to clangd unit tests pass on Windows.

Author: nico Date: Sun Oct 13 10:19:00 2019 New Revision: 374727 URL: http://llvm.org/viewvc/llvm-project?rev=374727=rev Log: Make the last to clangd unit tests pass on Windows. (Some lit tests still fail.) See FIXME in diff for details. Part of PR43592. Modified:

[PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

thakis added a comment. > Could you or anyone else point me to a good example, I'd definitely like to > take a look. http://llvm-cs.pcc.me.uk/include/llvm/Support/SourceMgr.h/rSMDiagnostic -- > `via clang-format?` did you mean via clang.exe or clang-check.exe? I did > think of this when

[PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

MyDeveloperDay added a comment. In D68554#1707537 , @thakis wrote: > > Thanks for doing this, I am struggling to find the MacOS bot log that > > failed, are any available via Buildbot? (I notice the log looks like your > > own machine) > > The mac bots

[PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

mbrkusanin updated this revision to Diff 224603. mbrkusanin added a comment. - Rebase - Ping @echristo @craig.topper @tstellar @dylanmckay @petecoup If there are no objections then I'll split this into llvm, clang and lldb patches and commit them next week. CHANGES SINCE LAST ACTION

r374366 - In openFileForRead don't cache erroneous entries if the error relates to them being directories. Add tests.

Author: kousikk Date: Thu Oct 10 08:29:01 2019 New Revision: 374366 URL: http://llvm.org/viewvc/llvm-project?rev=374366=rev Log: In openFileForRead don't cache erroneous entries if the error relates to them being directories. Add tests. Summary: It seems that when the CachingFileSystem is first

[PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

thakis added a comment. > Thanks for doing this, I am struggling to find the MacOS bot log that failed, > are any available via Buildbot? (I notice the log looks like your own machine) The mac bots are on a different system for some reason: http://green.lab.llvm.org/green/ (see also

[PATCH] D67185: [RISCV] Add support for -ffixed-xX flags

luismarques accepted this revision. luismarques added a comment. This revision is now accepted and ready to land. Overall LGTM. Caveats: - Address the issues in the inline comments; - Shouldn't the TLS lowering also complain when `-ffixed-x4` is used? - Is there a way to ensure we don't forget

r374720 - [clang-format] Proposal for clang-format to give compiler style warnings

Author: paulhoad Date: Sun Oct 13 07:51:45 2019 New Revision: 374720 URL: http://llvm.org/viewvc/llvm-project?rev=374720=rev Log: [clang-format] Proposal for clang-format to give compiler style warnings relanding {D68554} with fixed lit tests, checked on Windows and MacOS Added:

[PATCH] D68539: [clang-tidy] fix for readability-identifier-naming incorrectly fixes variables which become keywords

Daniel599 updated this revision to Diff 224783. Daniel599 added a comment. Added check for macro definition, please re-review the enum `ShouldFixStatus` as now I use it as a switch-case within the diagnostic message. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] r374718 - Make most clangd unittests pass on Windows

Author: nico Date: Sun Oct 13 06:15:27 2019 New Revision: 374718 URL: http://llvm.org/viewvc/llvm-project?rev=374718=rev Log: Make most clangd unittests pass on Windows The Windows triple currently turns on delayed template parsing, which confuses several unit tests that use templates. For now,

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length

Charusso added a comment. I think everything is working fine on the build-bot side. One tiny issue on Windows left where the `getLength()` could not obtain the length properly: rL374713 , I will look into that. In D45050#1071898

r374717 - BlockInCriticalSectionChecker - silence static analyzer dyn_cast null dereference warning. NFCI.

Author: rksimon Date: Sun Oct 13 04:30:06 2019 New Revision: 374717 URL: http://llvm.org/viewvc/llvm-project?rev=374717=rev Log: BlockInCriticalSectionChecker - silence static analyzer dyn_cast null dereference warning. NFCI. The static analyzer is warning about a potential null dereference,

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length

Charusso added a comment. In D45050#1707489 , @xbolva00 wrote: > `typedef __SIZE_TYPE__ size_t;` Hm, yes, I have overestimated the uploaded solution: $ clang/test grep -rn 'typedef __SIZE_TYPE__ size_t;' | wc -l 60 $ clang/test grep -rn 'typedef

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length

xbolva00 added a comment. typedef __SIZE_TYPE__ size_t; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45050/new/ https://reviews.llvm.org/D45050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length

Charusso added a comment. In D45050#1707483 , @thakis wrote: > This fails on Windows: http://45.33.8.238/win/386/step_7.txt > > Please take a look, and if it's not immediately clear how to fix, b please > revert while you investigate. Oh, thanks! We

[clang-tools-extra] r374715 - [clang-tidy] bugprone-not-null-terminated-result: checker adjustments 4

Author: charusso Date: Sun Oct 13 03:59:30 2019 New Revision: 374715 URL: http://llvm.org/viewvc/llvm-project?rev=374715=rev Log: [clang-tidy] bugprone-not-null-terminated-result: checker adjustments 4 Modified:

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length

thakis added a comment. This fails on Windows: http://45.33.8.238/win/386/step_7.txt Please take a look, and if it's not immediately clear how to fix, b please revert while you investigate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45050/new/

[PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

MyDeveloperDay added a comment. > I've reverted this for now to green up the bots. > > For the reland, did y'all consider the impact of this on clang-format build > time (it now depends on Frontend and hence on Driver and Sema, and Sema is > slow to build) and binary size (it's now basically

[clang-tools-extra] r374713 - [clang-tidy] bugprone-not-null-terminated-result: checker adjustments 3

Author: charusso Date: Sun Oct 13 03:41:13 2019 New Revision: 374713 URL: http://llvm.org/viewvc/llvm-project?rev=374713=rev Log: [clang-tidy] bugprone-not-null-terminated-result: checker adjustments 3 On Windows the signed/unsigned int conversions of APInt seems broken, so that two of the test

[clang-tools-extra] r374712 - [clang-tidy] bugprone-not-null-terminated-result: checker adjustments 2

Author: charusso Date: Sun Oct 13 03:20:58 2019 New Revision: 374712 URL: http://llvm.org/viewvc/llvm-project?rev=374712=rev Log: [clang-tidy] bugprone-not-null-terminated-result: checker adjustments 2 Modified: clang-tools-extra/trunk/clang-tidy/bugprone/NotNullTerminatedResultCheck.cpp

[clang-tools-extra] r374711 - [clang-tidy] bugprone-not-null-terminated-result: checker adjustments

Author: charusso Date: Sun Oct 13 02:46:56 2019 New Revision: 374711 URL: http://llvm.org/viewvc/llvm-project?rev=374711=rev Log: [clang-tidy] bugprone-not-null-terminated-result: checker adjustments Modified: clang-tools-extra/trunk/clang-tidy/bugprone/NotNullTerminatedResultCheck.cpp

[PATCH] D68914: [clang-format] Remove duplciate code from Invalid BOM detection

MyDeveloperDay updated this revision to Diff 224776. MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added a comment. Updating with review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68914/new/ https://reviews.llvm.org/D68914 Files:

[PATCH] D68927: [clang-tools-extra] Fix overzealous linking of dylib to clangTidy

mgorny created this revision. mgorny added reviewers: sylvestre.ledru, beanz. Fix accidentally making clangTidy library link to dylib. This causes libclang.so to also link to dylib which results in duplicate symbols from shared and static libraries, and effectively to registering command-line

[clang-tools-extra] r374710 - [clang-tidy] bugprone-not-null-terminated-result: Sphinx adjustments 2

Author: charusso Date: Sun Oct 13 01:49:43 2019 New Revision: 374710 URL: http://llvm.org/viewvc/llvm-project?rev=374710=rev Log: [clang-tidy] bugprone-not-null-terminated-result: Sphinx adjustments 2 Modified:

[clang-tools-extra] r374709 - [clang-tidy] bugprone-not-null-terminated-result: Sphinx adjustments

Author: charusso Date: Sun Oct 13 01:41:24 2019 New Revision: 374709 URL: http://llvm.org/viewvc/llvm-project?rev=374709=rev Log: [clang-tidy] bugprone-not-null-terminated-result: Sphinx adjustments Modified:

[PATCH] D68877: [AArch64][SVE] Implement masked load intrinsics

dmgreen added subscribers: samparker, dmgreen. dmgreen added a comment. Sam has been looking at extending masked loads and stores in D68337 and related patches. There looks like there would be some overlap with this, especially in the target independent parts.

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length

This revision was automatically updated to reflect the committed changes. Closed by commit rG82f8f8b44cd0: [clang-tidy] New checker for not null-terminated result caused by strlen()… (authored by Charusso). Changed prior to commit: https://reviews.llvm.org/D45050?vs=221096=224773#toc

[clang-tools-extra] r374707 - [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length

Author: charusso Date: Sun Oct 13 01:28:27 2019 New Revision: 374707 URL: http://llvm.org/viewvc/llvm-project?rev=374707=rev Log: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length Summary: New checker called bugprone-not-null-terminated-result.