[PATCH] D69238: Fix clang-tidy readability-redundant-string-init for c++17/c++2a

poelmanc marked 3 inline comments as done. poelmanc added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/RedundantStringInitCheck.cpp:50 varDecl(hasType(hasUnqualifiedDesugaredType(recordType( hasDeclaration(cxxRecordDecl

[PATCH] D69548: Give clang-tidy readability-redundant-string-init a customizable list of string types to fix

poelmanc created this revision. poelmanc added a reviewer: MyDeveloperDay. poelmanc added a project: clang-tools-extra. Herald added subscribers: cfe-commits, mgehre. Herald added a project: clang. This patch adds a feature requested by @MyDeveloperDay at https://reviews.llvm.org/D69238, @MyDevel

Re: [llvm-dev] Zorg migration to GitHub/monorepo

Hello Nemanja, > a commit to a project that shouldn't trigger builds on a libcxx bot (i.e. the > change was in llvm). With all due respect, this does not sound right. I'm not sure how changes in a code a particular bot builds and tests should not trigger builds. In many cases this will lead to f

[PATCH] D69498: IR: Invert convergent attribute handling

kariddi added a comment. One thing to probably note is that its not only a "target specific" issue, but a language specific issue as well (IMHO). OpenCL, CUDA, SYCL are all languages (to name a few) that have a concept of "convergence" and its not related only to the fact that they mostly run o

[PATCH] D69544: [clangd] NFC, reuse the source manager variable in the RawStringLiteral apply method

arphaman created this revision. arphaman added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, ributzka, kadircet, dexonsmith, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69544 Files: clang-tools-extra/clangd

[PATCH] D69543: [WIP][clangd] Add a tweak refactoring to wrap Objective-C string literals in `NSLocalizedString` macros

arphaman created this revision. arphaman added reviewers: jkorous, ilya-biryukov. Herald added subscribers: usaxena95, ributzka, kadircet, dexonsmith, MaskRay, mgorny. Herald added a project: clang. This is a patch to add a refactoring to Clangd that mimics the existing refactoring action in Xco

[PATCH] D69540: [analyzer] DynamicSize: Remove 'getExtent()' from regions

Charusso marked 3 inline comments as done. Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:880 uint64_t Length = UINT64_MAX; - SVal Extent = Top->getExtent(SVB); + SVal Extent = Top->getMemRegionManager().getStaticSize(Top); if (O

[PATCH] D69540: [analyzer] DynamicSize: Remove 'getExtent()' from regions

Charusso created this revision. Charusso added a reviewer: NoQ. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, mgorny. This patch introduces a placeholder for representing th

[clang] dddec1f - [clang][clang-scan-deps] Add -fcxx-modules to test for Darwin.

Author: Michael Spencer Date: 2019-10-28T17:37:25-07:00 New Revision: dddec1f1840b8a019c8c89dd1e7961cf39d845d3 URL: https://github.com/llvm/llvm-project/commit/dddec1f1840b8a019c8c89dd1e7961cf39d845d3 DIFF: https://github.com/llvm/llvm-project/commit/dddec1f1840b8a019c8c89dd1e7961cf39d845d3.dif

[PATCH] D69498: IR: Invert convergent attribute handling

arsenm added a comment. I think the question should be what the IR policy is for properties that are required for correctness and not necessarily what most users will use. There's a general trend towards functions being correct by default, and attributes adding optimization possibilities. conve

[clang] 9ecd322 - [NFC] Fix some indentation disturbed in D67368

Author: Reid Kleckner Date: 2019-10-28T17:12:43-07:00 New Revision: 9ecd3225d134541bdfde18a6648edb8b9e048035 URL: https://github.com/llvm/llvm-project/commit/9ecd3225d134541bdfde18a6648edb8b9e048035 DIFF: https://github.com/llvm/llvm-project/commit/9ecd3225d134541bdfde18a6648edb8b9e048035.diff

Re: [llvm-dev] Zorg migration to GitHub/monorepo

I think what she is referring to was that the build seemed to be triggered by a commit to a project that shouldn't trigger builds on a libcxx bot (i.e. the change was in llvm). I have a somewhat orthogonal but related question. In the past, commits to compiler-rt did not trigger builds on llvm/cla

[PATCH] D69498: IR: Invert convergent attribute handling

jdoerfert added a comment. @rjmccall Thanks for the quick response! I tried to describe my view below. To avoid confusion on my side, could you maybe describe what you think when/which attribute should be created, derived, and used during the optimization pipeline? In D69498#1724232

Re: [PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

On Thu, Oct 24, 2019 at 3:24 PM Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > > On Oct 24, 2019, at 3:02 PM, David Blaikie via Phabricator < > revi...@reviews.llvm.org> wrote: > > dblaikie added a comment. > > In D67723#1720509 , @a

Re: r374837 - [clang] add requirements to -Wa,-W test cases.

Sounds good! Will start doing it. On Mon, Oct 28, 2019 at 4:29 PM David Blaikie wrote: > Thanks for the details! Generally it's fine to have these discussions > on-list, or at least to include a summary reply so it's clear loose ends > were tied up. > > On Mon, Oct 28, 2019 at 4:26 PM Jian Cai

Re: r374837 - [clang] add requirements to -Wa,-W test cases.

Thanks for the details! Generally it's fine to have these discussions on-list, or at least to include a summary reply so it's clear loose ends were tied up. On Mon, Oct 28, 2019 at 4:26 PM Jian Cai wrote: > Hi David, > > Thanks for the follow up. I already discussed it with Nico over email and >

Re: r374837 - [clang] add requirements to -Wa,-W test cases.

Hi David, Thanks for the follow up. I already discussed it with Nico over email and addressed his concerns on llvm-svn: 374932. I did not want to spam everyone with all our email exchanges so I did not include the list :). Thanks, Jian On Mon, Oct 28, 2019 at 3:37 PM David Blaikie wrote: > +1

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

AntonBikineev updated this revision to Diff 226773. AntonBikineev added a comment. Thanks for the suggestions! Added isTriviallyDestructible matcher to utils/Matchers.h. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69435/new/ https://reviews.llvm.org/D69435 Files: clang-tools-extra

Re: [clang] 9671d1d - [clang]Fixup clang -Werror, , -Wcovered-switch-default build failures

FWIW that probably produces a -Wreturn-type warning because other compilers don't conservatively assume that only the enumerator values can be in an enum variable (rather than all of its representable values). The subsequent -Wreturn-type warning was fixed in 45787e56829f (moving the unreachable to

Re: r374844 - Revert "Dead Virtual Function Elimination"

+1/ping on this - Jorge, could you include some details about the reason for the revert & the revision? On Mon, Oct 14, 2019 at 5:06 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi Jorge, > > Please mention the reason for a revert in revert commit messages. Also, > unti

Re: r374837 - [clang] add requirements to -Wa,-W test cases.

+1 to what Nico said/ping on this. Jian - could you see if these tests could be made portable as Nico's suggested? On Mon, Oct 14, 2019 at 3:54 PM Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hm, this means the test can't run on non-linux, so if someone breaks it on > e.g. w

[PATCH] D68377: [Builtins] Teach Clang about memccpy

This revision was automatically updated to reflect the committed changes. Closed by commit rGdfece0a108a7: [Builtins] Teach Clang about memccpy (authored by xbolva00). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68377/new/ https://reviews.llvm.org

[PATCH] D68377: [Builtins] Teach Clang about memccpy

xbolva00 updated this revision to Diff 226761. xbolva00 added a comment. Newline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68377/new/ https://reviews.llvm.org/D68377 Files: clang/include/clang/Basic/Builtins.def clang/test/CodeGen/builtin

Re: [clang] bd87916 - [clang] Add no_builtin attribute

I've reverted this change as it was causing ASan/MSan failures in check-clang, e.g. take a look at the bottom 2 failures here: http://lab.llvm.org:8014/builders/sanitizer-x86_64-linux-bootstrap/builds/124/steps/check-clang%20asan/logs/stdio or here http://lab.llvm.org:8014/builders/sanitizer-x86_64

[clang] ad531ff - Revert "[clang] Add no_builtin attribute"

Author: Vlad Tsyrklevich Date: 2019-10-28T15:21:59-07:00 New Revision: ad531fff81a2a266ffed1d7da778cb59c983 URL: https://github.com/llvm/llvm-project/commit/ad531fff81a2a266ffed1d7da778cb59c983 DIFF: https://github.com/llvm/llvm-project/commit/ad531fff81a2a266ffed1d7da778cb59c983.di

[PATCH] D69518: [Diagnostics] Warn for std::is_constant_evaluated in constexpr mode

xbolva00 updated this revision to Diff 226759. xbolva00 added a comment. New tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69518/new/ https://reviews.llvm.org/D69518 Files: clang/include/clang/AST/Expr.h clang/include/clang/Basic/Diagnos

[PATCH] D69518: [Diagnostics] Warn for std::is_constant_evaluated in constexpr mode

xbolva00 updated this revision to Diff 226758. xbolva00 added a comment. Support !E. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69518/new/ https://reviews.llvm.org/D69518 Files: clang/include/clang/AST/Expr.h clang/include/clang/Basic/Diagn

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

rjmccall added a comment. Is the exception-strictness of `-frounding-math` actually considered to be specified behavior, or is it just a consequence of the current implementation? There are definitely some optimizations that we can't do under strict FP exceptions that we can still do in princi

[clang] 38839d0 - Revert "[Concepts] Constraint Enforcement & Diagnostics"

Author: Vlad Tsyrklevich Date: 2019-10-28T15:00:40-07:00 New Revision: 38839d08b8e165dfaab0fa6acc77e620d6df294c URL: https://github.com/llvm/llvm-project/commit/38839d08b8e165dfaab0fa6acc77e620d6df294c DIFF: https://github.com/llvm/llvm-project/commit/38839d08b8e165dfaab0fa6acc77e620d6df294c.di

[PATCH] D66712: [Driver] Enable ShadowCallStack, not SafeStack, by default on AArch64 Fuchsia

leonardchan closed this revision. leonardchan added a comment. Manually closed since `git push` didn't seem to automatically close this. Committed under https://github.com/llvm/llvm-project/commit/85b718f53a3575bca2f1b7fdb1b3aaa6df7c10e3. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[clang] 7cd595d - Revert "Use -fdebug-compilation-dir to form absolute paths in coverage mappings"

Author: Reid Kleckner Date: 2019-10-28T14:40:17-07:00 New Revision: 7cd595df96d5929488063d8ff5cc3b5d800386da URL: https://github.com/llvm/llvm-project/commit/7cd595df96d5929488063d8ff5cc3b5d800386da DIFF: https://github.com/llvm/llvm-project/commit/7cd595df96d5929488063d8ff5cc3b5d800386da.diff

[PATCH] D67983: [ObjC] Diagnose implicit type coercion from ObjC 'Class' to object pointer types.

rjmccall added a comment. I was thinking that we could walk through the instance methods of the protocol and check whether the class has compatible declarations of class methods. But you're right, of course: we don't actually know what class we're working with, and we'd have to look through `[

[PATCH] D69498: IR: Invert convergent attribute handling

rjmccall added a comment. If you can come up with a way to make this change that doesn't require changes to non-GPU frontends or tests, I agree that treating functions as convergent by default makes sense for GPU targets. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69498/new/ https:

[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

vlad.tsyrklevich added a comment. I noticed in Decl.cpp your change deleted some whitespace that belonged there. Not a big deal, just try to remember to run clang-format-diff when you're submitting for review. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D69498: IR: Invert convergent attribute handling

rjmccall added a comment. The kind of tracking that you're doing of convergent operations is one example of a basically limitless set of "taint" analyses, of which half a dozen already exist in LLVM. I object to the idea that an arbitrary number of unrelated tests need to be changed every time

[PATCH] D69533: Thread safety analysis: Peel away NoOp implicit casts in initializers

aaronpuchert created this revision. aaronpuchert added reviewers: aaron.ballman, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. This happens when someone initializes a variable with guaranteed copy elision and an added const qualifier. Fixes PR43826. Repository:

[clang] 85b718f - [Driver] Enable ShadowCallStack, not SafeStack, by default on AArch64 Fuchsia

Author: Leonard Chan Date: 2019-10-28T14:19:38-07:00 New Revision: 85b718f53a3575bca2f1b7fdb1b3aaa6df7c10e3 URL: https://github.com/llvm/llvm-project/commit/85b718f53a3575bca2f1b7fdb1b3aaa6df7c10e3 DIFF: https://github.com/llvm/llvm-project/commit/85b718f53a3575bca2f1b7fdb1b3aaa6df7c10e3.diff

[PATCH] D68725: [analyzer] MemoryBlockRegion: Generalize AllocaRegion

Charusso added a comment. Thanks for the notes! In D68725#1722136 , @NoQ wrote: > Generally, there's no need to add more information to `MemRegion` and > `SymExpr` objects [...] Well, that was my first idea, then I saw we allow helper-methods inside r

[PATCH] D69181: [clang-tidy] Adding misc-signal-terminated-thread check

Eugene.Zelenko added a comment. Will be good idea to mention alias in Release Notes too (in aliases section, in alphabetical order). Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69181/new/ https://reviews.llvm.org/D69181 ___

[PATCH] D69181: [clang-tidy] Adding misc-signal-terminated-thread check

abelkocsis updated this revision to Diff 226746. abelkocsis added a comment. Alias added to //cert// module Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69181/new/ https://reviews.llvm.org/D69181 Files: clang-tools-extra/clang-tidy/bugprone/BadS

[PATCH] D69215: [DWARF5] Added support for deleted C++ special member functions.

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: llvm/docs/SourceLevelDebugging.rst:998 + +There are couple of new DWARF attributes defined to enhance debugging of C++ programs. LLVM can generate (or omit

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 226738. mibintc added a comment. I adopted the language that @rjmccall recommended for documenting frounding-math., also adding a sentence to describe effects on exception behavior control. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews

[PATCH] D69215: [DWARF5] Added support for deleted C++ special member functions.

SouraVX added a comment. Hi @aprantl, could you please review these changes, while I rework on the other one. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69215/new/ https://reviews.llvm.org/D69215 ___ cfe-commits mailing list cfe

[clang] f5094e1 - [Remarks] Fix Sphinx formatting

Author: Francis Visoiu Mistrih Date: 2019-10-28T13:13:39-07:00 New Revision: f5094e182947710f0b8dd4fafd23fd66634a3f19 URL: https://github.com/llvm/llvm-project/commit/f5094e182947710f0b8dd4fafd23fd66634a3f19 DIFF: https://github.com/llvm/llvm-project/commit/f5094e182947710f0b8dd4fafd23fd66634a3

[clang] 025166c - [Remarks] Add bitstream to the list of supported formats in clang

Author: Francis Visoiu Mistrih Date: 2019-10-28T13:08:05-07:00 New Revision: 025166cf48002317086db84f3a6eb7a2e2c10df2 URL: https://github.com/llvm/llvm-project/commit/025166cf48002317086db84f3a6eb7a2e2c10df2 DIFF: https://github.com/llvm/llvm-project/commit/025166cf48002317086db84f3a6eb7a2e2c10

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/TriviallyDestructibleCheck.cpp:27 + for (FieldDecl *Field : RecordDecl->fields()) { +const QualType FieldType = Field->getType(); +if (FieldType->isDependentType() || -

[PATCH] D67983: [ObjC] Diagnose implicit type coercion from ObjC 'Class' to object pointer types.

jyknight added a comment. In D67983#1723681 , @rjmccall wrote: > We could probably do a quick check to see if the class informally conforms to > the protocol. `+copyWithZone` seems to be marked unavailable in ARC; not > sure if that would cause problems

[PATCH] D69238: Fix clang-tidy readability-redundant-string-init for c++17/c++2a

MyDeveloperDay added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/RedundantStringInitCheck.cpp:50 varDecl(hasType(hasUnqualifiedDesugaredType(recordType( hasDeclaration(cxxRecordDecl(hasName("basic_string")),

[PATCH] D65761: Add Windows Control Flow Guard checks (/guard:cf).

thakis added a comment. All new files added in this patch had dos line endings. I fixed that in e59f7488 but going forward please configure your environment to create new files for LLVM with unix line endings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

Re: Zorg migration to GitHub/monorepo

Hi Diana, It is not clear from your description of what is the problem. Could you elaborate, please? I have looked at the build history closer and see that this build configuration depends on libcxx, libcxxabi, libunwind, llvm projects, and changes to any of these would trigger a build. Depending

[clang] f213207 - Lexer::ReadToEndOfLine - fix Token uninitialised value warnings. NFCI.

Author: Simon Pilgrim Date: 2019-10-28T18:28:18Z New Revision: f2132070d9a5a330400744aa14819344d0b44151 URL: https://github.com/llvm/llvm-project/commit/f2132070d9a5a330400744aa14819344d0b44151 DIFF: https://github.com/llvm/llvm-project/commit/f2132070d9a5a330400744aa14819344d0b44151.diff LOG:

[PATCH] D69498: IR: Invert convergent attribute handling

jdoerfert added a reviewer: JonChesterfield. jdoerfert added a comment. Before we get lost in review details let's make sure we agree that his is the right path. I mean, transition from `convergent` to `noconvergent` (or a similar spelling). I do support this by the way. In D69498#1723606

[PATCH] D69520: [libc++] Disallow dynamic -> static span conversions

jdoerrie updated this revision to Diff 226714. jdoerrie added a comment. Full patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69520/new/ https://reviews.llvm.org/D69520 Files: libcxx/include/span libcxx/test/std/containers/views/span.cons/span.fail.cpp libcxx/test/std/contain

[PATCH] D69520: [libc++] Disallow dynamic -> static span conversions

jdoerrie updated this revision to Diff 226713. jdoerrie added a comment. Formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69520/new/ https://reviews.llvm.org/D69520 Files: libcxx/test/std/containers/views/span.cons/span.pass.cpp Index: libcxx/test/std/containers/views/span.

[PATCH] D69520: [libc++] Disallow dynamic -> static span conversions

jdoerrie created this revision. jdoerrie added reviewers: mclow.lists, ldionne. Herald added a reviewer: EricWF. Herald added subscribers: libcxx-commits, dexonsmith, christof. [libc++] Disallow dynamic -> static span conversions This change disallows dynamic to static span conversions. This comp

[PATCH] D60220: [CUDA][Windows] Final fix for bug 38811 (Step 3 of 3)

emankov added a comment. >> It looks like CUDA doesn't support `double` argument for device function >> __isnan on FreeBSD. > > It's actually the opposite -- FreeBSD does not provide *host*-side > `__isnan(double)` -- the error complains that it's the host code that tried > to use `__isnan` an

[PATCH] D69518: [Diagnostics] Warn for std::is_constant_evaluated in constexpr mode

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:3679 + CallExpr *Call = dyn_cast(CondExpr->IgnoreParens()); + if (IsConstexpr && Call && Call->isCallToStdIsConstantEvaluated()) +Diag(Call->getBeginLoc(),

[PATCH] D69498: IR: Invert convergent attribute handling

arsenm marked an inline comment as done. arsenm added a comment. In D69498#1723606 , @rjmccall wrote: > A note on spelling: the no prefix seems to be used largely with verbs; it's > weird to use it here with an adjective, especially since noncovergent is

[PATCH] D69493: Add -fconvergent-functions flag

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. > The CUDA builtin library is apparently compiled in C++ mode, so the > assumption of convergent needs to be made in a typically non-SPMD > language. I think the key here is that we sometime

[clang] 7c86069 - [OPENMP]Fix PR43771: Do not capture contexprs variables.

Author: Alexey Bataev Date: 2019-10-28T13:29:02-04:00 New Revision: 7c860698208aee32df1883601b94924fa4a3d531 URL: https://github.com/llvm/llvm-project/commit/7c860698208aee32df1883601b94924fa4a3d531 DIFF: https://github.com/llvm/llvm-project/commit/7c860698208aee32df1883601b94924fa4a3d531.diff

[PATCH] D69518: [Diagnostics] Warn for std::is_constant_evaluated in constexpr mode

xbolva00 created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69518 Files: clang/include/clang/AST/Expr.h clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaExprCXX.cpp

[PATCH] D60220: [CUDA][Windows] Final fix for bug 38811 (Step 3 of 3)

tra added a comment. In D60220#1723458 , @emankov wrote: > In D60220#1723350 , @6yearold wrote: > > > I'm seeing quite similar errors on FreeBSD with Clang 8 and 9: > > Any idea how to fix this? > > > It looks like

[PATCH] D69238: Fix clang-tidy readability-redundant-string-init for c++17/c++2a

poelmanc marked 5 inline comments as done. poelmanc added a comment. Thanks for the feedback, the new patch removes the extra `const`, `clang::`, and braces on one-line `if` statements, and now explains the regex in readability-redundant-string-init.cpp. Comment at: clang-to

[PATCH] D69238: Fix clang-tidy readability-redundant-string-init for c++17/c++2a

poelmanc updated this revision to Diff 226695. poelmanc added a comment. Remove extra `const`, braces for one-line `if` statements, and `clang::`. Added a comment explaining the need for a regex on a warning test line. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://re

[PATCH] D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage

Eugene.Zelenko added a comment. Please take a look on PR43827. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67567/new/ https://reviews.llvm.org/D67567 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D68733: Use -fdebug-compilation-dir to form absolute paths in coverage mappings

liaoyuke added a comment. In D68733#1702609 , @vsk wrote: > Thanks, lgtm! > > In PR43614 I mentioned adding an extra argument to llvm-cov to specify the > base directory. On second thought, the existing `-path-equivalence` option > should make that unnec

[PATCH] D68539: [clang-tidy] fix for readability-identifier-naming incorrectly fixes variables which become keywords

Daniel599 added a comment. In D68539#1723629 , @aaron.ballman wrote: > Do you need someone to commit this on your behalf? Yes I would like to. Thank you :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68

[PATCH] D69292: Proposal to add -Wtautological-compare to -Wall

aaron.ballman added a comment. In D69292#1723720 , @xbolva00 wrote: > Just use > > // RUN: %clang_cc1 -fsyntax-only -verify -Wall %s > // RUN: %clang_cc1 -fsyntax-only -verify -Wtautological-bitwise-compare %s > > > in > > clang/test/SemaCXX/warn-bitwi

[PATCH] D68912: Adds -Wrange-loop-analysis to -Wall

aaron.ballman added a comment. In D68912#1723691 , @xbolva00 wrote: > >> Does this analysis require CFG support > > https://reviews.llvm.org/D69292 also requires CFG support. Yes, it does. > Generally, is CFG support ok for -Wall if the warning has few

[PATCH] D69292: Proposal to add -Wtautological-compare to -Wall

xbolva00 added a comment. Just use // RUN: %clang_cc1 -fsyntax-only -verify -Wall %s // RUN: %clang_cc1 -fsyntax-only -verify -Wtautological-bitwise-compare %s in clang/test/SemaCXX/warn-bitwise-compare.cpp ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69292/new/ https://reviews.l

[PATCH] D68912: Adds -Wrange-loop-analysis to -Wall

xbolva00 requested changes to this revision. xbolva00 added a comment. This revision now requires changes to proceed. >> Does this analysis require CFG support https://reviews.llvm.org/D69292 also requires CFG support. Generally, is CFG support ok for -Wall if the warning has few false positives

[PATCH] D69478: [Sema] Allow warnStackExhausted to show more info

aaron.ballman added a comment. I sort of feel like we don't want to go this route because we want to avoid calling `runWithSufficientStackSpace` whenever possible, but I am not strongly opposed to this patch. It should be combined with the usage of the new functionality, however, so that it get

[PATCH] D68377: [Builtins] Teach Clang about memccpy

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a minor testing nit. Comment at: clang/test/CodeGen/memccpy-libcall.c:13 +// CHECK: attributes #2 = { nobuiltin } \ No newline at end of file -

[PATCH] D67983: [ObjC] Diagnose implicit type coercion from ObjC 'Class' to object pointer types.

rjmccall added a comment. We could probably do a quick check to see if the class informally conforms to the protocol. `+copyWithZone` seems to be marked unavailable in ARC; not sure if that would cause problems for such a check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 93a3128 - Remove extra ';'. NFCI.

Author: Simon Pilgrim Date: 2019-10-28T16:32:02Z New Revision: 93a3128a67cc4372696eb3199bed23d7bac4a183 URL: https://github.com/llvm/llvm-project/commit/93a3128a67cc4372696eb3199bed23d7bac4a183 DIFF: https://github.com/llvm/llvm-project/commit/93a3128a67cc4372696eb3199bed23d7bac4a183.diff LOG:

[PATCH] D68028: [clang] Add no_builtin attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd8791610948: [clang] Add no_builtin attribute (authored by gchatelet). Changed prior to commit: https://reviews.llvm.org/D68028?vs=225618&id=226687#toc Repository: rG LLVM Github Monorepo CHANGES S

[clang] bd87916 - [clang] Add no_builtin attribute

Author: Guillaume Chatelet Date: 2019-10-28T17:30:11+01:00 New Revision: bd87916109483d33455cbf20da2309197b983cdd URL: https://github.com/llvm/llvm-project/commit/bd87916109483d33455cbf20da2309197b983cdd DIFF: https://github.com/llvm/llvm-project/commit/bd87916109483d33455cbf20da2309197b983cdd.

[PATCH] D67983: [ObjC] Diagnose implicit type coercion from ObjC 'Class' to object pointer types.

thakis added a comment. > While the default metaclass does in fact implement the one method NSCopying > declares, it's not possible within the language to declare that the Class -- > itself, as an instance -- implements the instance methods from the NSCopying > protocol. Should the compiler ju

[PATCH] D69517: [clangd] Add a hidden tweak to dump symbol under the curosr.

merge_guards_bot added a comment. Build result: fail - 59659 tests passed, 2 failed and 805 were skipped. failed: libc++.libcxx/thread/thread_threads/thread_thread_this/sleep_for.pass.cpp failed: LLVM.tools/llvm-ar/mri-utf8.test Log files: cmake-log.txt

[PATCH] D68912: Adds -Wrange-loop-analysis to -Wall

aaron.ballman added a comment. Does this analysis require CFG support or have a high false positive rate? We typically keep those out of `-Wall` because of performance concerns, so I am wondering if the diagnostic was kept out of `-Wall` for a reason. CHANGES SINCE LAST ACTION https://review

[PATCH] D68539: [clang-tidy] fix for readability-identifier-naming incorrectly fixes variables which become keywords

aaron.ballman added a comment. Do you need someone to commit this on your behalf? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68539/new/ https://reviews.llvm.org/D68539 ___ cfe-commits mailing list c

[PATCH] D69388: [clang-tidy] Fix modernize-use-nodiscard check for classes marked as [[nodiscard]]

sedykh.eugene added a comment. In D69388#1723589 , @aaron.ballman wrote: > Thank you for the patch, and welcome! LGTM aside from a minor nit. Do you > need someone to commit this on your behalf? Thank you. You mean I don't rights? Then, yes, I need som

[PATCH] D69414: [clang-tidy] Regenerate clang-tidy check list 📋

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69414/new/ https://reviews.llvm.org/D69414

[PATCH] D69388: [clang-tidy] Fix modernize-use-nodiscard check for classes marked as [[nodiscard]]

sedykh.eugene updated this revision to Diff 226677. sedykh.eugene added a comment. I removed using. Not a big deal. Thank you for the reviews! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69388/new/ https://reviews.llvm.org/D69388 Files: clang-t

[PATCH] D69292: Proposal to add -Wtautological-compare to -Wall

aaron.ballman added a comment. In D69292#1722162 , @thakis wrote: > This is imho basic enough that it doesn't need a test. A test for this > doesn't add any value that I can see. The value comes from having an explicit test to demonstrate the behavior i

[PATCH] D69506: [clangd] Add missing highlights for using decls.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. See the NITs, though Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:51 } + if (auto *USD = dyn_cast(D)) +return kindForDecl(USD->ge

[PATCH] D69506: [clangd] Add missing highlights for using decls.

merge_guards_bot added a comment. Build result: pass - 59702 tests passed, 0 failed and 763 were skipped. Log files: cmake-log.txt , ninja_check_all-log.txt

[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet added a comment. In D68028#1723568 , @aaron.ballman wrote: > LGTM! Thx a lot for bearing with me and for your valuable comments ! Really appreciate it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D69498: IR: Invert convergent attribute handling

rjmccall added a comment. In D69498#1723553 , @rjmccall wrote: > This certainly seems like a more tractable representation, although I suppose > it'd be a thorn in the side of (IR-level) outlining. Sorry, I mis-clicked and sent this review while I was s

[PATCH] D69145: Give readability-redundant-member-init an option IgnoreBaseInCopyConstructors to avoid breaking code with gcc -Werror=extra

aaron.ballman added a comment. In D69145#1720254 , @poelmanc wrote: > What do @malcolm.parsons, @alexfh, @hokein, @aaron.ballman, @lebedev.ri think > of @mgehre's suggestion to enable `IgnoreBaseInCopyConstructors` as the > default setting, so gcc users

[PATCH] D69517: [clangd] Add a hidden tweak to dump symbol under the curosr.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. This provides a convenient way to see the SymbolID/USR of the symbol, mainly for debugging purpose. Repository: rG LLV

[PATCH] D69388: [clang-tidy] Fix modernize-use-nodiscard check for classes marked as [[nodiscard]]

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thank you for the patch, and welcome! LGTM aside from a minor nit. Do you need someone to commit this on your behalf? Comment at: clang-tidy/modernize/UseNodis

[PATCH] D68028: [clang] Add no_builtin attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68028/new/ https://reviews.llvm.org/D68028

[PATCH] D69506: [clangd] Add missing highlights for using decls.

hokein added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:51 } + if (auto *UD = dyn_cast(D)) { +if (UD->shadow_size() == 0) ilya-biryukov wrote: > Could we reuse `kindForCandidateDecls` instead? > It's best to keep one wa

[PATCH] D69498: IR: Invert convergent attribute handling

rjmccall added a comment. This certainly seems like a more tractable representation, although I suppose it'd be a thorn in the side of (IR-level) outlining. A note on spelling: the `no` prefix seems to be used largely with verbs; it's weird to use it here with an adjective, especially since `no

[PATCH] D69506: [clangd] Add missing highlights for using decls.

hokein updated this revision to Diff 226673. hokein marked 3 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69506/new/ https://reviews.llvm.org/D69506 Files: clang-tools-extra/cla

[PATCH] D69238: Fix clang-tidy readability-redundant-string-init for c++17/c++2a

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/RedundantStringInitCheck.cpp:75 +// and if found, extend the SourceRange to start at 'Name'. +std::pair +CtorSourceRange(const MatchFinder::MatchResult &Result, You can dro

[PATCH] D68877: [AArch64][SVE] Implement masked load intrinsics

Yi-Hong.Lyu added a comment. Seem this commit broke buildbot http://lab.llvm.org:8011/builders/ppc64le-lld-multistage-test/builds/6881 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68877/new/ https://reviews.llvm.org/D68877

[PATCH] D67983: [ObjC] Diagnose implicit type coercion from ObjC 'Class' to object pointer types.

jyknight added a comment. In D67983#1723376 , @thakis wrote: > After this, Class can no longer be used as a key type in an Obj-C dictionary > literal. Is that intentional? Such code was already an on by default incompatible-pointer-types warning in Obj

[PATCH] D65761: Add Windows Control Flow Guard checks (/guard:cf).

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGd157a9bc8ba1: Add Windows Control Flow Guard checks (/guard:cf). (authored by ajpaverd, committed by theraven). Repositor

  1   2   >