[PATCH] D57829: [CUDA][HIP] Disable emitting llvm.linker.options in device compilation

yaxunl updated this revision to Diff 227216. yaxunl retitled this revision from "[HIP] Disable emitting llvm.linker.options in device compilation" to "[CUDA][HIP] Disable emitting llvm.linker.options in device compilation". yaxunl edited the summary of this revision. yaxunl added a comment. use

[PATCH] D57829: [HIP] Disable emitting llvm.linker.options in device compilation

yaxunl reclaimed this revision. yaxunl added a comment. we still need this CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57829/new/ https://reviews.llvm.org/D57829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

hliao added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:395-400 /// The number used to indicate this lambda expression for name /// mangling in the Itanium C++ ABI. unsigned ManglingNumber : 31; +/// The device side mangling number. +

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

hliao updated this revision to Diff 227214. hliao marked an inline comment as done. hliao added a comment. simplify again following suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69322/new/ https://reviews.llvm.org/D69322 Files:

[PATCH] D69626: Fix Microsoft compatibility handling of commas in nested macro expansions.

epastor added a comment. In D69626#1728113 , @thakis wrote: > Is this needed to parse system headers? Interesting question. This change isn't - but I presume the (pre-existing) introduction of IgnoredComma was. > In general, we try to emulate only

[PATCH] D69518: [Diagnostics] Warn for std::is_constant_evaluated in constexpr mode

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/DiagnosticASTKinds.td:333 +def warn_is_constant_evaluated_always_true_constexpr : Warning< + "'%0' will always evaluate to 'true'

[PATCH] D69626: Fix Microsoft compatibility handling of commas in nested macro expansions.

thakis added a comment. Is this needed to parse system headers? In general, we try to emulate only warts we must emulate, and if feasible we try to emit some -Wmicrosoft warning when the compat path is taken. (MSVC added /experimental:preprocessor like 2 years ago, but it hasn't made it to a

[PATCH] D67706: [clang][analyzer] Using CallDescription in StreamChecker.

Szelethus accepted this revision. Szelethus added a comment. Let's make it 3! Thank you so much for sticking by, I guess one of the reasons why a patch so obviously great and desired took so long is that we still didn't figure out how we imagine the `CallDescriptionMap` to be integrated into

[PATCH] D69643: [clang][ScanDeps] Fix issue with multiple commands with the same input.

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM, Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69643/new/ https://reviews.llvm.org/D69643

[PATCH] D69414: [clang-tidy] Regenerate clang-tidy check list 

This revision was automatically updated to reflect the committed changes. Closed by commit rG9baf4958cda4: [clang-tidy] Regenerate clang-tidy check list  (authored by stephanemoore). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69414/new/

[clang] c1d2927 - Run clang-format on lib/CodeGen/CGCall.h and fix indentation

Author: Akira Hatanaka Date: 2019-10-30T18:06:12-07:00 New Revision: c1d2927cc64731520e60ecd1fc0e0eeabdfbac40 URL: https://github.com/llvm/llvm-project/commit/c1d2927cc64731520e60ecd1fc0e0eeabdfbac40 DIFF:

[PATCH] D69651: [CMake] Add cross ARM toolchain CMake cache file.

vvereschaka created this revision. vvereschaka added reviewers: andreil99, gkistanova. Herald added subscribers: cfe-commits, kristof.beyls, mgorny. Herald added a project: clang. This cache file can be used to build CrossARM toolchain on Windows platform. Also it is going to be used by the

[clang] 004ed2b - Revert "[CodeView] Add option to disable inline line tables."

Author: Amy Huang Date: 2019-10-30T17:31:12-07:00 New Revision: 004ed2b0d1b86d424643ffc88fce20ad8bab6804 URL: https://github.com/llvm/llvm-project/commit/004ed2b0d1b86d424643ffc88fce20ad8bab6804 DIFF: https://github.com/llvm/llvm-project/commit/004ed2b0d1b86d424643ffc88fce20ad8bab6804.diff

[PATCH] D69498: IR: Invert convergent attribute handling

arsenm added a comment. As far as optimization inhibition is concerned, noconvergent will be inferred for all functions that don't call convergent intrinsics (i.e. the state of the world for all functions on all CPU targets). The frontend needing to do something for optimization comes up in

[PATCH] D69498: IR: Invert convergent attribute handling

arsenm added a comment. In D69498#1728039 , @tra wrote: > Perhaps we can deal with that by providing a way to specify per-module > default for the assumed convergence of the functions and then checking in the > back-end (only those that do care about

[PATCH] D69520: [libc++] Disallow dynamic -> static span conversions

jorgbrown added a comment. +1 Thanks also for fixing the return statement of testConversionSpan() in span.pass.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69520/new/ https://reviews.llvm.org/D69520 ___ cfe-commits mailing list

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D69618: NeonEmitter: clean up prototype modifiers

efriedma added a comment. It looks like this patch contains a few other changes, besides the changes to the prototypes. In particular, the change to CGBuiltin.cpp, and there are a few new lines in the .td files that don't correspond to anything in the old versions. Is that accidental, or is

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

thakis added a comment. I had some time to take a look. D69636 makes things work on mac. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63607/new/ https://reviews.llvm.org/D63607 ___ cfe-commits mailing

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

rsmith marked an inline comment as done. rsmith added inline comments. Comment at: docs/ReleaseNotes.rst:84 + In a future release of Clang, we intend to change the default to + ``-fno-lax-vector-conversions``. + efriedma wrote: > kristof.beyls wrote: > >

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

efriedma added inline comments. Comment at: docs/ReleaseNotes.rst:84 + In a future release of Clang, we intend to change the default to + ``-fno-lax-vector-conversions``. + kristof.beyls wrote: > efriedma wrote: > > rsmith wrote: > > > efriedma wrote: > > > >

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille added a comment. @sylvestre.ledru : quick backport for llvm9: https://sergesanspaille.fedorapeople.org/0001-Stack-clash-mir-attempt.patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68720

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

akhuang added a comment. Seems like this is good to be committed then. And it sounds like implementing more thresholds would be useful to do in the future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67723/new/ https://reviews.llvm.org/D67723

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6d0389038451: [CodeView] Add option to disable inline line tables. (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67723/new/

[clang] 6d03890 - [CodeView] Add option to disable inline line tables.

Author: Amy Huang Date: 2019-10-30T16:52:39-07:00 New Revision: 6d03890384517919a3ba7fe4c35535425f278f89 URL: https://github.com/llvm/llvm-project/commit/6d03890384517919a3ba7fe4c35535425f278f89 DIFF: https://github.com/llvm/llvm-project/commit/6d03890384517919a3ba7fe4c35535425f278f89.diff

[PATCH] D69498: IR: Invert convergent attribute handling

tra added a comment. Would I be too far off the mark to summarize the situation this way? - current default for unattributed functions is unsound for GPU back-ends, but is fine for most of the other back-ends. - it's easy to unintentionally end up using/mis-optimizing unattributed functions

[PATCH] D67706: [clang][analyzer] Using CallDescription in StreamChecker.

Charusso accepted this revision. Charusso marked an inline comment as done. Charusso added a comment. This revision is now accepted and ready to land. My concern was the too heavy `Optional` and `bool` usage. Cool patch! Comment at:

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille added a comment. @rnk what's your take on that version? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68720 ___ cfe-commits mailing list

[PATCH] D69649: [clang-format] Fix SpacesInSquareBrackets for Lambdas with Initial "" Parameter

mitchell-stellar created this revision. mitchell-stellar added reviewers: MyDeveloperDay, klimek, sammccall. mitchell-stellar added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch fixes an edge case in the `SpacesInSquareBrackets` option

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille updated this revision to Diff 227194. serge-sans-paille edited the summary of this revision. serge-sans-paille added a comment. Moved to a simpler, easier to review, less error prone implementation. Validates just fines on llvm bootstrap an cpython code base. @sylvestre.ledru

[PATCH] D67706: [clang][analyzer] Using CallDescription in StreamChecker.

NoQ accepted this revision. NoQ added a comment. Let's land this patch, given that it grew way too big for a refactoring pass, and let @balazske further clean things up later in his follow-up patches. This is already a large improvement and i'm very grateful! For the `Optional` vs. `bool`

Re: [clang] 33a745e - [clang][clang-scan-deps] Add support for extracting full module dependencies.

On Wed, Oct 30, 2019 at 3:54 PM Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > I XFAILED the test on Windows in 52194350cfe. The [/\\] regexes might need > to match two slashes, and the PREFIX variable ends up having inconsistent > slash direction. > Hmm, fixing the slashes

Zorg migration to GitHub/monorepo - Step 2

Hello everyone, As all of you know, the migration to github monorepo is done. The production master is currently working in a transition mode, when it supports both, bots already working with github, and bots still working with SVN. Today we will turn "github only" mode for the production

[clang] 17b64e3 - [clang][ScanDeps] Fix shadowing warning.

Author: Michael Spencer Date: 2019-10-30T15:53:38-07:00 New Revision: 17b64e36e90ad05a32a99b9f5784b55310cc10e8 URL: https://github.com/llvm/llvm-project/commit/17b64e36e90ad05a32a99b9f5784b55310cc10e8 DIFF:

Re: [clang] 33a745e - [clang][clang-scan-deps] Add support for extracting full module dependencies.

I XFAILED the test on Windows in 52194350cfe. The [/\\] regexes might need to match two slashes, and the PREFIX variable ends up having inconsistent slash direction. On Wed, Oct 30, 2019 at 3:27 PM Michael Spencer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Michael Spencer >

[clang] 5219435 - Disable new clang-scan-deps test on Windows due to backslash path matching problems

Author: Reid Kleckner Date: 2019-10-30T15:51:34-07:00 New Revision: 52194350cfe834f27e41771c315fe0656067fdc4 URL: https://github.com/llvm/llvm-project/commit/52194350cfe834f27e41771c315fe0656067fdc4 DIFF: https://github.com/llvm/llvm-project/commit/52194350cfe834f27e41771c315fe0656067fdc4.diff

[PATCH] D66827: Add support for MS qualifiers __ptr32, __ptr64, __sptr, __uptr.

akhuang added a comment. I split off the backend changes into a separate patch -> https://reviews.llvm.org/D69639 The issue with passing 0 for a pointer should be fixed there. @DarkShadow44 Some of the differences come from the fact that we're implementing the mixed pointer sizes with three

[clang] 33a745e - [clang][clang-scan-deps] Add support for extracting full module dependencies.

Author: Michael Spencer Date: 2019-10-30T15:27:27-07:00 New Revision: 33a745e6fe7e81d3793f7831d2832aa0785ef327 URL: https://github.com/llvm/llvm-project/commit/33a745e6fe7e81d3793f7831d2832aa0785ef327 DIFF:

[PATCH] D69518: [Diagnostics] Warn for std::is_constant_evaluated in constexpr mode

xbolva00 marked 2 inline comments as done. xbolva00 added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:10595 +const auto *Callee = Info.CurrentCall->getCallee(); +if (Info.InConstantContext && !Info.CheckingPotentialConstantExpression && +

[PATCH] D69518: [Diagnostics] Warn for std::is_constant_evaluated in constexpr mode

xbolva00 updated this revision to Diff 227191. xbolva00 added a comment. - Merge branch 'master' of https://github.com/llvm/llvm-project Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69518/new/ https://reviews.llvm.org/D69518 Files:

[PATCH] D69518: [Diagnostics] Warn for std::is_constant_evaluated in constexpr mode

xbolva00 updated this revision to Diff 227192. xbolva00 added a comment. - Merge branch 'master' of https://github.com/llvm/llvm-project === Removed old unused change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 1c88d66 - Revert "[clang][clang-scan-deps] Add support for extracting full module dependencies."

Author: Michael Spencer Date: 2019-10-30T15:16:38-07:00 New Revision: 1c88d662230e79bc2dd2283d753d950c1ad0bed6 URL: https://github.com/llvm/llvm-project/commit/1c88d662230e79bc2dd2283d753d950c1ad0bed6 DIFF:

[clang] 812bdb3 - [MS] Don't reference deleted copy ctors from catchable types

Author: Reid Kleckner Date: 2019-10-30T15:06:26-07:00 New Revision: 812bdb3c13210759341e8a1b08b864a539ce9dc7 URL: https://github.com/llvm/llvm-project/commit/812bdb3c13210759341e8a1b08b864a539ce9dc7 DIFF: https://github.com/llvm/llvm-project/commit/812bdb3c13210759341e8a1b08b864a539ce9dc7.diff

[PATCH] D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd8a4ef0e685c: [clang][clang-scan-deps] Add support for extracting full module dependencies. (authored by Bigcheese). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] d8a4ef0 - [clang][clang-scan-deps] Add support for extracting full module dependencies.

Author: Michael Spencer Date: 2019-10-30T14:46:17-07:00 New Revision: d8a4ef0e685cec1fc73d4953b48220b649d05b40 URL: https://github.com/llvm/llvm-project/commit/d8a4ef0e685cec1fc73d4953b48220b649d05b40 DIFF:

[PATCH] D69642: [analyzer] DynamicSize: Simplify the assumption creating of sizes

Charusso added a comment. @NoQ, I hope this is what you have suggested. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69642/new/ https://reviews.llvm.org/D69642 ___ cfe-commits mailing list

[PATCH] D69643: [clang][ScanDeps] Fix issue with multiple commands with the same input.

Bigcheese created this revision. Bigcheese added reviewers: arphaman, klimek. Bigcheese added a project: clang. Herald added a subscriber: dexonsmith. Previously, given a CompilationDatabase with two commands for the same source file we would report that file twice with the union of the

[PATCH] D69642: [analyzer] DynamicSize: Simplify the assumption creating of sizes

Charusso created this revision. Charusso added a reviewer: NoQ. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Charusso added a parent revision: D69599: [analyzer]

[PATCH] D69564: Include the mangled name in -ast-dump=json

MaskRay added a comment. > I am planning to use this feature to make update_cc_checks.py less fragile by > obtaining the mangled names directly from -ast-dump=json. `update_cc_checks.py` -> `update_cc_test_checks.py` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 3a0c86a - Add a test file that was missed in 4de6b1586807285e20a5db6596519c2336a64568

Author: Vladimir Plyashkun Date: 2019-10-30T16:55:43-04:00 New Revision: 3a0c86a179efcd5c108521afade3aab6083376f7 URL: https://github.com/llvm/llvm-project/commit/3a0c86a179efcd5c108521afade3aab6083376f7 DIFF:

[PATCH] D69316: [OpenMP 5.0] target update list items need not be contiguous (Sema)

cchen updated this revision to Diff 227174. cchen added a comment. Rebase and fix add OpenMP 50 guard Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69316/new/ https://reviews.llvm.org/D69316 Files: clang/lib/Sema/SemaOpenMP.cpp

[PATCH] D68539: [clang-tidy] fix for readability-identifier-naming incorrectly fixes variables which become keywords

aaron.ballman added a comment. In D68539#1727759 , @Daniel599 wrote: > In D68539#1727503 , @aaron.ballman > wrote: > > > Thank you for the patch! I've commit on your behalf in > >

[clang-tools-extra] 7b6174b - Add a test file that was missed in e477988309dbde214a6d16ec690a416882714aac

Author: Daniel Date: 2019-10-30T16:52:19-04:00 New Revision: 7b6174bb147957b4695023ae57c95ca07af7b917 URL: https://github.com/llvm/llvm-project/commit/7b6174bb147957b4695023ae57c95ca07af7b917 DIFF: https://github.com/llvm/llvm-project/commit/7b6174bb147957b4695023ae57c95ca07af7b917.diff LOG:

[PATCH] D68845: Don't emit unwanted constructor calls in co_return statements

aaronpuchert added inline comments. Comment at: clang/lib/Sema/SemaCoroutine.cpp:951 Stmt *Res = new (Context) CoreturnStmt(Loc, E, PCE, IsImplicit); return Res; Another interesting question is whether this `E` should include the xvalue cast, if we did

[PATCH] D69577: [clang-format] [PR35518] C++17 deduction guides are wrongly formatted

lichray added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1354 + static bool isDeductionGuide(FormatToken ) { +// Look for a deduction guide A()...) -> A<...>; +if (Current.Previous && Current.Previous->is(tok::r_paren) &&

[PATCH] D68539: [clang-tidy] fix for readability-identifier-naming incorrectly fixes variables which become keywords

Daniel599 added a comment. In D68539#1727503 , @aaron.ballman wrote: > Thank you for the patch! I've commit on your behalf in > e477988309dbde214a6d16ec690a416882714aac > Thank you

[clang] bb06149 - Fix __attribute__((enable_if)) to treat arguments with side-effects as

Author: Richard Smith Date: 2019-10-30T13:39:29-07:00 New Revision: bb061491316bbd516a7551fe36128ead0935010d URL: https://github.com/llvm/llvm-project/commit/bb061491316bbd516a7551fe36128ead0935010d DIFF: https://github.com/llvm/llvm-project/commit/bb061491316bbd516a7551fe36128ead0935010d.diff

[PATCH] D69316: [OpenMP 5.0] target update list items need not be contiguous (Sema)

cchen updated this revision to Diff 227169. cchen added a comment. Remove the restriction rule for array section to another patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69316/new/ https://reviews.llvm.org/D69316 Files:

[PATCH] D69356: [NFC] Rename LLVM_NO_DEAD_STRIP

daltenty added a comment. Revised direction in https://reviews.llvm.org/D69638 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69356/new/ https://reviews.llvm.org/D69356 ___ cfe-commits mailing list

[PATCH] D69638: [NFC] Add SUPPORT_PLUGINS to add_llvm_executable()

daltenty created this revision. Herald added subscribers: llvm-commits, cfe-commits, mgorny. Herald added projects: clang, LLVM. daltenty edited the summary of this revision. daltenty added reviewers: hubert.reinterpretcast, beanz, lhames. daltenty added a reverted change: D69356: [NFC] Rename

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

ABataev added a comment. Some of the previous comments are not fixed. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9100 +def note_omp_defaultmap_attr_none : Note< + "explicit data sharing attribute, data mapping attribute, or is_devise_ptr clause requested

[PATCH] D69498: IR: Invert convergent attribute handling

jdoerfert added a comment. In D69498#1727626 , @mehdi_amini wrote: > In D69498#1727546 , @jdoerfert wrote: > > > In D69498#1727419 , @mehdi_amini > > wrote: > > > > > In

[PATCH] D69498: IR: Invert convergent attribute handling

rjmccall added a comment. As I've said before, I absolutely view this polarity flip as good for GPU compilers, and I don't mind Clang needing to take some patches to update how we operate when targeting the GPU and to update some GPU-specific tests. I do not think we should view GPU targets

[PATCH] D69498: IR: Invert convergent attribute handling

arsenm added a comment. In D69498#1727626 , @mehdi_amini wrote: > In D69498#1727546 , @jdoerfert wrote: > > > In D69498#1727419 , @mehdi_amini > > wrote: > > > > > In

[PATCH] D14927: clang-format: Add SpaceBeforeTemplateParameterList option

MyDeveloperDay added a comment. Style guide suggesting enforcing a space after template keyword https://mesos.readthedocs.io/en/1.1.0/c++-style-guide/ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14927/new/ https://reviews.llvm.org/D14927

[PATCH] D69577: [clang-format] [PR35518] C++17 deduction guides are wrongly formatted

MyDeveloperDay updated this revision to Diff 227166. MyDeveloperDay added a comment. move detection of deduction guides into a function, add additional negative tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69577/new/ https://reviews.llvm.org/D69577 Files:

[PATCH] D68845: Don't emit unwanted constructor calls in co_return statements

aaronpuchert added a comment. Not answering inline because comments are getting longer. > I still think that it makes sense to do implicit-move on any control-flow > construct that "exits" the current function. Right now that's `return` and > `throw`, and they both do implicit-move (albeit

[PATCH] D69577: [clang-format] [PR35518] C++17 deduction guides are wrongly formatted

MyDeveloperDay marked 4 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1400-1403 +} else if (Current.Previous && Current.Previous->is(tok::r_paren) && + Current.startsSequence(tok::arrow,

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1969-1972 + (DSAStack->getDefaultDMIBAtLevel(Level, OMPC_DEFAULTMAP_scalar) == + DMIB_alloc || + DSAStack->getDefaultDMIBAtLevel(Level,

[PATCH] D69498: IR: Invert convergent attribute handling

dexonsmith added a comment. In D69498#1723606 , @rjmccall wrote: > Perhaps there should be a global metadata, or something in the > increasingly-misnamed "data layout" string, which says that convergence is > meaningful, and we should only add the

[PATCH] D69498: IR: Invert convergent attribute handling

mehdi_amini added a comment. In D69498#1727546 , @jdoerfert wrote: > In D69498#1727419 , @mehdi_amini > wrote: > > > In D69498#1727080 , @jdoerfert > > wrote: > > > > >

[PATCH] D69308: [analyzer] Test cases for the unsupported features for Clang Static Analyzer

NoQ added a comment. Another interesting problem that we forgot to mention on the open projects page is the modeling of C++17 bindings and decompositions: https://bugs.llvm.org/show_bug.cgi?id=43042 Also, in my opinion, out of all construction context problems mentioned on the open projects

[PATCH] D69632: [libTooling] Add Stencil constructor.

ymandel created this revision. ymandel added a reviewer: gribozavr. Herald added a project: clang. ymandel added a child revision: D69613: [libTooling] Simplify type structure of `Stencil`s.. Adds a constructor that takes a vector with which to initialize the `Parts` field and a corresponding

[PATCH] D69613: [libTooling] Simplify type structure of `Stencil`s.

ymandel updated this revision to Diff 227159. ymandel added a comment. rebasing onto parent Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69613/new/ https://reviews.llvm.org/D69613 Files: clang/include/clang/Tooling/Transformer/Stencil.h

[PATCH] D69613: [libTooling] Simplify type structure of `Stencil`s.

ymandel updated this revision to Diff 227156. ymandel added a comment. added simple overload of `cat` -- needed to support client transition to new type structure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69613/new/

[PATCH] D69308: [analyzer] Test cases for the unsupported features for Clang Static Analyzer

NoQ added a comment. In D69308#1727108 , @Szelethus wrote: > Would love to see this comment in its entirety on the open projects page :^) I'd rather have a mention that @dkrupp is already working on this project, so that if somebody wanted to help out

[PATCH] D69356: [NFC] Rename LLVM_NO_DEAD_STRIP

daltenty added a comment. In D69356#1727581 , @hubert.reinterpretcast wrote: > In D69356#1727484 , @beanz wrote: > > > We should not be adding more variables that are passed around by CMake's > > scope

[clang] 23df0c7 - Revert "[NFC] Rename LLVM_NO_DEAD_STRIP"

Author: David Tenty Date: 2019-10-30T14:56:20-04:00 New Revision: 23df0c783c7053ddcdf665ebc8ddda350abd5bf2 URL: https://github.com/llvm/llvm-project/commit/23df0c783c7053ddcdf665ebc8ddda350abd5bf2 DIFF: https://github.com/llvm/llvm-project/commit/23df0c783c7053ddcdf665ebc8ddda350abd5bf2.diff

[PATCH] D69356: [NFC] Rename LLVM_NO_DEAD_STRIP

hubert.reinterpretcast added a comment. In D69356#1727484 , @beanz wrote: > We should not be adding more variables that are passed around by CMake's > scope inheritance. Instead if we need to change this we should do it > correctly. Just to clarify,

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

rnk added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:395-400 /// The number used to indicate this lambda expression for name /// mangling in the Itanium C++ ABI. unsigned ManglingNumber : 31; +/// The device side mangling number. +

[PATCH] D69356: [NFC] Rename LLVM_NO_DEAD_STRIP

hubert.reinterpretcast added a comment. In D69356#1727381 , @beanz wrote: > (1) dead stripping support is useful independent of plugins, so it is > valuable to have that option be separate Okay. >> Just because the current implementation of plug-in

[PATCH] D68896: PR43080: Do not build context-sensitive expressions during name classification.

kianm added a comment. Hi, There is a problem with this commit because it asserts after errors have been recognized. I have attached a reduced test case. The assertion looks to occur here: clang: /home/kianm/llvm/dev/llvm-project/clang/lib/Parse/ParseExprCXX.cpp:585: clang::ExprResult

[PATCH] D69602: [analyzer] Test case for lambda capture by value modelling

NoQ added inline comments. Comment at: clang/test/Analysis/clangsa_unsupported_features/handle_constructors_for_lambda_captures.cpp:29 + operator=(incr_on_copy_for_simple_usage &) = delete; + ~incr_on_copy_for_simple_usage() = default; +}; NoQ wrote: > That's

[PATCH] D69498: IR: Invert convergent attribute handling

jdoerfert added a subscriber: hfinkel. jdoerfert added a comment. In D69498#1727419 , @mehdi_amini wrote: > In D69498#1727080 , @jdoerfert wrote: > > > Let me quote @arsenm here because this is so important:

[PATCH] D69602: [analyzer] Test case for lambda capture by value modelling

NoQ added a comment. I recommend starting with CFG tests for this feature. I.e., do `-analyzer-checker debug.DumpCFG` and make sure that every `CFGStmt` that corresponds to a constructor is a `CFGConstructor` (i.e., has a `ConstructionContext` explained in the dump). Cf.

[PATCH] D69582: Let clang driver support parallel jobs

thakis added inline comments. Comment at: clang/lib/Driver/Compilation.cpp:303 +} +std::thread Th(Work); +Th.detach(); Maybe a select() / fork() loop is a better approach than spawning one thread per subprocess? This is doing thread-level

[PATCH] D69582: Let clang driver support parallel jobs

rnk added subscribers: aganea, amccarth, rnk. rnk added a comment. +@aganea @amccarth Users have been asking for /MP support in clang-cl for a while, which is basically this. Is there anything in JobScheduler that could reasonably be moved down to llvm/lib/Support? I would also like to be

[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM, many thanks! Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp:293 + // Now try to generate edits for all the refs. + for (auto :

[PATCH] D68539: [clang-tidy] fix for readability-identifier-naming incorrectly fixes variables which become keywords

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the patch! I've commit on your behalf in e477988309dbde214a6d16ec690a416882714aac Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

Re: [clang-tools-extra] 0de262d - Move this release note to its appropriate location; NFC.

Unintentionally off-list; I thought I hit reply-all. :-D Would you like me to remove the entry for include-fixer? ~Aaron On Wed, Oct 30, 2019 at 2:17 PM Nico Weber wrote: > > (intentionally off-list?) > > On Wed, Oct 30, 2019 at 2:14 PM Aaron Ballman wrote: >> >> On Wed, Oct 30, 2019 at 1:57

[clang-tools-extra] e477988 - Fix readability-identifier-naming to prevent variables becoming keywords.

Author: Daniel Date: 2019-10-30T14:18:40-04:00 New Revision: e477988309dbde214a6d16ec690a416882714aac URL: https://github.com/llvm/llvm-project/commit/e477988309dbde214a6d16ec690a416882714aac DIFF: https://github.com/llvm/llvm-project/commit/e477988309dbde214a6d16ec690a416882714aac.diff LOG:

[PATCH] D69356: [NFC] Rename LLVM_NO_DEAD_STRIP

beanz added a comment. In D69356#1727451 , @daltenty wrote: > The intention of LLVM_SUPPORT_PLUGINS was as an internal option set by tools > which may have plugins and need to be built in a specific way (such as > avoiding deadstriping) if plugins are

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

thakis added a comment. Thanks! Looks like it's just the `-E` test that's causing problems; the test passes with that disabled: $ git diff diff --git a/clang/test/Driver/flang/flang.f90 b/clang/test/Driver/flang/flang.f90 index 97e4847f843..4cbc2cd8754 100644 ---

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the patch! I've committed on your behalf in 4de6b1586807285e20a5db6596519c2336a64568 . Repository: rCTE Clang Tools Extra CHANGES SINCE LAST

[clang-tools-extra] 4de6b15 - Add an option to hicpp-signed-bitwise for positive integer literals.

Author: Vladimir Plyashkun Date: 2019-10-30T14:11:29-04:00 New Revision: 4de6b1586807285e20a5db6596519c2336a64568 URL: https://github.com/llvm/llvm-project/commit/4de6b1586807285e20a5db6596519c2336a64568 DIFF:

[PATCH] D69628: [Clang] Pragma vectorize_width() implies vectorize(enable), take 3

Meinersbur requested changes to this revision. Meinersbur added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/CodeGen/CGLoopInfo.cpp:272-277 + if (Attrs.VectorizeWidth > 1 && + Attrs.VectorizeEnable == LoopAttributes::Unspecified) +

[PATCH] D69498: IR: Invert convergent attribute handling

arsenm added a comment. In D69498#1727419 , @mehdi_amini wrote: > In D69498#1727080 , @jdoerfert wrote: > > > Let me quote @arsenm here because this is so important: "Basically no > > frontend has gotten this

[PATCH] D69356: [NFC] Rename LLVM_NO_DEAD_STRIP

daltenty added a comment. > I'm actually opposed to that happening, on two fronts. > (2) we already have `LLVM_ENABLE_PLUGINS` why do we also need > `LLVM_SUPPORT_PLUGINS` seems like duplication and bad design. As I understand it LLVM_ENABLE_PLUGINS is a user-facing option which indicates

Re: [clang-tools-extra] 0de262d - Move this release note to its appropriate location; NFC.

Aren't include-fixer and clang-include-fixer the same thing? Why do we have to entries for it? On Wed, Oct 30, 2019 at 1:48 PM Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Aaron Ballman > Date: 2019-10-30T13:48:26-04:00 > New Revision:

[PATCH] D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403)

Eugene.Zelenko added a comment. In D55793#1727437 , @aaron.ballman wrote: > In D55793#1727423 , @Eugene.Zelenko > wrote: > > > @aaron.ballman: Please move Release Notes entry to new checks section (in > >

  1   2   >