[clang] 0f88cae - [Analyzer] Checker for Debugging Iterator Checkers

Author: Adam Balogh Date: 2019-11-08T08:59:50+01:00 New Revision: 0f88caeef8f2d4708f442d03db7723396712a143 URL: https://github.com/llvm/llvm-project/commit/0f88caeef8f2d4708f442d03db7723396712a143 DIFF: https://github.com/llvm/llvm-project/commit/0f88caeef8f2d4708f442d03db7723396712a143.diff

[PATCH] D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members))

MadCoder marked 2 inline comments as done. MadCoder added inline comments. Comment at: clang/lib/CodeGen/CGObjCMac.cpp:1588 // interface, we cannot perform this check. + // + // Note that for direct methods, because objc_msgSend is skipped, doh

[PATCH] D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members))

MadCoder created this revision. MadCoder added reviewers: rjmccall, jfb, doug.gregor, dexonsmith. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. __attribute__((objc_direct)) is an attribute on methods declaration and implementation, categories, or extensions

[PATCH] D69990: Populate CUDA flags on FreeBSD too, as many other toolchains do.

6yearold created this revision. Herald added subscribers: cfe-commits, emaste. Herald added a project: clang. This allows `clang` to be used to compile CUDA programs. Compiled simple helloworld.cu with this. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69990 Files:

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

ekatz added a comment. Yes, these changes regard to the same thing - the removal of the "Linkage-Spec LanguageIDs". As you described it nicely, it is for linkage only, meaning C vs C++. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69935/new/

[PATCH] D69292: Proposal to add -Wtautological-compare to -Wall

xbolva00 added a comment. Thanks. Looks good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69292/new/ https://reviews.llvm.org/D69292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert updated this revision to Diff 228364. jdoerfert added a comment. Do not eagerly create function declarations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69785/new/ https://reviews.llvm.org/D69785 Files:

[PATCH] D69292: Proposal to add -Wtautological-compare to -Wall

rtrieu updated this revision to Diff 228361. rtrieu added a comment. Add -Wall tests to check that certain warning groups are active with it and a test to check all warning groups that are turned on by -Wall. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69292/new/

[PATCH] D69984: [OpenMP][Opt] Annotate known runtime functions and deduplicate more

jdoerfert created this revision. jdoerfert added reviewers: kiranchandramohan, ABataev, RaviNarayanaswamy, gtbercea, grokos, sdmitriev, JonChesterfield, hfinkel, fghanim. Herald added a project: LLVM. jdoerfert removed a subscriber: cfe-commits. jdoerfert added a parent revision: D69930: [OpenMP]

[PATCH] D63636: [PowerPC][Altivec] Fix offsets for vec_xl and vec_xst

This revision was automatically updated to reflect the committed changes. Closed by commit rGe0407f549653: [PowerPC][Altivec] Fix offsets for vec_xl and vec_xst (authored by nemanjai). Herald added subscribers: shchenz, wuzish. Changed prior to commit:

[clang] e0407f5 - [PowerPC][Altivec] Fix offsets for vec_xl and vec_xst

Author: Nemanja Ivanovic Date: 2019-11-07T20:58:11-06:00 New Revision: e0407f54965318247c8fece2dfa5c9023acf0973 URL: https://github.com/llvm/llvm-project/commit/e0407f54965318247c8fece2dfa5c9023acf0973 DIFF:

[PATCH] D64024: [PowerPC][Altivec] Emit correct builtin for single precision vec_all_ne

This revision was automatically updated to reflect the committed changes. Closed by commit rG070e4027b024: [PowerPC][Altivec] Emit correct builtin for single precision vec_all_ne (authored by nemanjai). Changed prior to commit: https://reviews.llvm.org/D64024?vs=207374=228354#toc Repository:

[clang] 070e402 - [PowerPC][Altivec] Emit correct builtin for single precision vec_all_ne

Author: Nemanja Ivanovic Date: 2019-11-07T20:40:32-06:00 New Revision: 070e4027b02453f0962e5b61335a517581c5528f URL: https://github.com/llvm/llvm-project/commit/070e4027b02453f0962e5b61335a517581c5528f DIFF:

[PATCH] D69979: clang: Guess at some platform FTZ/DAZ default settings

craig.topper added a comment. I checked Redhat 7.4 that's on the server I'm using for work. And I had a coworker check his Ubuntu 18.04 system with this program. And both systems printed 1f80 as the value of MXCSR which shows FTZ and DAZ are both 0. Are you seeing something different?

[PATCH] D69981: [www] More HTTPS and outdated link fixes.

zoecarver added a comment. This LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69981/new/ https://reviews.llvm.org/D69981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64024: [PowerPC][Altivec] Emit correct builtin for single precision vec_all_ne

nemanjai added a comment. Herald added subscribers: shchenz, wuzish. In D64024#1565190 , @jsji wrote: > LGTM. > BTW, looks like we are missing test cases all `vector float` `vec_all*` and > `vec_any*` and also non-vsx path? The non-VSX path is tested

[PATCH] D69981: [www] More HTTPS and outdated link fixes.

STL_MSFT created this revision. STL_MSFT added reviewers: ldionne, zoecarver. Herald added a reviewer: bollu. Herald added subscribers: llvm-commits, arphaman, dexonsmith. Herald added projects: clang, LLVM. [www] More HTTPS and outdated link fixes. Repository: rG LLVM Github Monorepo

[PATCH] D69878: Consoldiate internal denormal flushing controls

arsenm updated this revision to Diff 228348. arsenm added a comment. Fix name in documentation CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69878/new/ https://reviews.llvm.org/D69878 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basic/CodeGenOptions.h

[PATCH] D69979: clang: Guess at some platform FTZ/DAZ default settings

arsenm created this revision. arsenm added reviewers: spatel, craig.topper, RKSimon, hfinkel, probinson. Herald added a subscriber: wdng. arsenm added a parent revision: D69978: Separately track input and output denormal mode. This is to avoid performance regressions when the default attribute

[PATCH] D69308: [analyzer] Test cases for the unsupported features for Clang Static Analyzer

This revision was automatically updated to reflect the committed changes. Closed by commit rG5e0fb6484207: [analyzer] Add test cases for the unsupported C++ constructor modeling. (authored by dergachev.a). Changed prior to commit: https://reviews.llvm.org/D69308?vs=227714=228344#toc

[PATCH] D66049: [analyzer] PR41729: Fix some false positives and improve strlcat and strlcpy modeling

This revision was automatically updated to reflect the committed changes. Closed by commit rGacac540422e8: [analyzer] PR41729: CStringChecker: Improve strlcat and strlcpy modeling. (authored by dergachev.a). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 5e0fb64 - [analyzer] Add test cases for the unsupported C++ constructor modeling.

Author: Artem Dergachev Date: 2019-11-07T17:15:53-08:00 New Revision: 5e0fb648420702e47c94de53757928360a106e8c URL: https://github.com/llvm/llvm-project/commit/5e0fb648420702e47c94de53757928360a106e8c DIFF:

[clang] acac540 - [analyzer] PR41729: CStringChecker: Improve strlcat and strlcpy modeling.

Author: Artem Dergachev Date: 2019-11-07T17:15:53-08:00 New Revision: acac540422e8cee4a77d10f087b2a2b67504b27b URL: https://github.com/llvm/llvm-project/commit/acac540422e8cee4a77d10f087b2a2b67504b27b DIFF:

[clang] 7215b7e - [creduce] Fixed a typo in the error message we're looking for.

Author: Artem Belevich Date: 2019-11-07T17:16:51-08:00 New Revision: 7215b7ef530bff896a1da70c6b062e9259f5fde7 URL: https://github.com/llvm/llvm-project/commit/7215b7ef530bff896a1da70c6b062e9259f5fde7 DIFF:

[PATCH] D69978: Separately track input and output denormal mode

arsenm created this revision. arsenm added reviewers: scanon, cameron.mcinally, spatel, andrew.w.kaylor, mibintc, SjoerdMeijer. Herald added subscribers: dexonsmith, hiraditya, tpr, nhaehnle, wdng, jvesely, jholewinski. Herald added a project: LLVM. arsenm added parent revisions: D69878:

[PATCH] D68108: Redeclare Objective-C property accessors inside the ObjCImplDecl in which they are synthesized.

aprantl added a comment. Thanks for patiently working through this with me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68108/new/ https://reviews.llvm.org/D68108 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D68162: [analyzer][MallocChecker][NFC] Communicate the allocation family to auxiliary functions with parameters

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks again!~ In D68162#1705928 , @Szelethus wrote: > I guess you two are right. Maybe the best solution would be collapse `const > CallExpr *` and

[PATCH] D68165: [analyzer][MallocChecker][NFC] Split checkPostCall up, deploy CallDescriptionMap

NoQ added a comment. I think my `strdup` comments weren't addressed >.< Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:378-379 + + using CheckFn = void (MallocChecker::*)(CheckerContext , const CallExpr *CE, +

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

NoQ accepted this revision. NoQ added a comment. @NoQ: "Why not simply remove taint?" @boga95: //*removes taint*// @NoQ: "Hmm, now that i think about it, adding a 'no taint' marker might actually work correctly more often." Like, if you have taint on `$x` and try to remove taint from

[PATCH] D65410: [PassManager] First Pass implementation at -O1 pass pipeline

echristo updated this revision to Diff 228339. echristo added a comment. Update to remove comments around SROA addition. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65410/new/ https://reviews.llvm.org/D65410 Files: clang/test/CodeGen/2008-07-30-implicit-initialization.c

RE: [clang] 03b84e4 - [clang] Report sanitizer blacklist as a dependency in cc1

Hi Jan, It looks like this commit is causing DFSAN failures on the sanitizer bots and our internal CI. Could you take a look? http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/24312/steps/64-bit%20check-dfsan/logs/stdio Thanks, Matthew > -Original Message- > From:

[PATCH] D65410: [PassManager] First Pass implementation at -O1 pass pipeline

echristo updated this revision to Diff 228338. echristo marked an inline comment as done. echristo added a comment. Herald added subscribers: aheejin, sbc100, nhaehnle, jvesely. I've gone ahead and enabled SROA here. In the testing I've done so far it's helped execute time quite a bit and

[PATCH] D69950: Reapply "Fix crash on switch conditions of non-integer types in templates"

gribozavr2 accepted this revision. gribozavr2 added a comment. LGTM for ClangTidy, assuming you ran `ninja check-all`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69950/new/ https://reviews.llvm.org/D69950 ___ cfe-commits mailing list

[PATCH] D69922: [OpenMP] Use the OpenMP-IR-Builder

jdoerfert updated this revision to Diff 228331. jdoerfert marked 2 inline comments as done. jdoerfert added a comment. Herald added a project: LLVM. Adjust tests as requested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69922/new/

[PATCH] D69971: clang-format: [JS] support null operators.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69971/new/ https://reviews.llvm.org/D69971

[PATCH] D69972: clang-format: [JS] test declared fields.

MyDeveloperDay added a comment. Thanks for this patch, this LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69972/new/ https://reviews.llvm.org/D69972 ___ cfe-commits mailing list

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert updated this revision to Diff 228327. jdoerfert added a comment. Adjust RTL attributes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69785/new/ https://reviews.llvm.org/D69785 Files: llvm/include/llvm/IR/DebugInfoMetadata.h

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert updated this revision to Diff 228328. jdoerfert added a comment. Remove accidental newline change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69785/new/ https://reviews.llvm.org/D69785 Files: llvm/include/llvm/IR/OpenMPConstants.h

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:4435-4437 +if (DMIB == DMIB_alloc) Kind = OMPC_MAP_alloc; +else if (DMIB == DMIB_to) Kind = OMPC_MAP_to; +else if (DMIB == DMIB_from) Kind =

[PATCH] D69972: clang-format: [JS] test declared fields.

mprobst created this revision. mprobst added a reviewer: krasimir. Herald added a project: clang. TypeScript now supports declaring fields: class Foo { declare field: string; } clang-format happens to already format this fine, so this change just adds a regression test. Repository:

[PATCH] D69969: [SEH] Defer checking filter expression types until instantiaton

This revision was automatically updated to reflect the committed changes. Closed by commit rG7177ce978e8f: [SEH] Defer checking filter expression types until instantiaton (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69969/new/

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert updated this revision to Diff 228320. jdoerfert added a comment. Use source location information to build the ident string and debug info. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69785/new/ https://reviews.llvm.org/D69785 Files:

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert added a comment. In D69785#1737581 , @lebedev.ri wrote: > As far as i can tell the builder does not add any debug info. > Should it? It does now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69970: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood (reland with fixes)

vsk added a comment. In D69970#1737814 , @dblaikie wrote: > The failure I am investigating from the original commit of this at Google > probably isn't related to the assertion failure that caused the revert of > this patch/being addressed by this

[PATCH] D69970: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood (reland with fixes)

dblaikie added a comment. The failure I am investigating from the original commit of this at Google probably isn't related to the assertion failure that caused the revert of this patch/being addressed by this recommit. So if you could hold off a bit while I try to help provide a reproduction

[PATCH] D69971: clang-format: [JS] support null operators.

mprobst created this revision. mprobst added a reviewer: krasimir. Herald added a project: clang. JavaScript / TypeScript is adding two new operators: the null propagating operator `?.` and the nullish coalescing operator `??`. const x = foo ?? 'default'; const z = foo?.bar?.baz; This

[clang] 7177ce9 - [SEH] Defer checking filter expression types until instantiaton

Author: Reid Kleckner Date: 2019-11-07T14:52:04-08:00 New Revision: 7177ce978e8f8e5409cec90bad07df92441656e3 URL: https://github.com/llvm/llvm-project/commit/7177ce978e8f8e5409cec90bad07df92441656e3 DIFF: https://github.com/llvm/llvm-project/commit/7177ce978e8f8e5409cec90bad07df92441656e3.diff

[libunwind] d3c7443 - Correctly update isSignalFrame when unwinding the stack via dwarf.

Author: Sterling Augustine Date: 2019-11-07T14:48:35-08:00 New Revision: d3c744313c3cca0c076f031ec71e66ca74b12f2a URL: https://github.com/llvm/llvm-project/commit/d3c744313c3cca0c076f031ec71e66ca74b12f2a DIFF:

[PATCH] D69925: remove redundant LLVM version from version string when setting CLANG_VENDOR

nickdesaulniers added a comment. Thanks for the review, leaving open for final comments, will merge tomorrow. FWIW, I think we can now purge "svn" from `BACKEND_PACKAGE_STRING` and other places in the tree. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69969: [SEH] Defer checking filter expression types until instantiaton

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69969/new/ https://reviews.llvm.org/D69969

[PATCH] D69925: remove redundant LLVM version from version string when setting CLANG_VENDOR

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. If we expect that CLANG_VERSION_STRING and BACKEND_PACKAGE_STRING are going to be the same, then the extra note isn't really buying us anything. LGTM Repository: rG LLVM Github

[PATCH] D69970: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood (reland with fixes)

vsk created this revision. vsk added reviewers: aprantl, djtodoro, dblaikie. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Currently, clang emits subprograms for declared functions when the target debugger or DWARF standard is known to support entry values

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

dblaikie added a comment. In D69935#1737615 , @ekatz wrote: > With this change (current trunk) you can write code as follows: > > extern "C++11" int x; > > > And it will pass compilation. No other compiler support it, nor it should, as > there is no

[PATCH] D69969: [SEH] Defer checking filter expression types until instantiaton

rnk created this revision. rnk added a reviewer: amccarth. Herald added a project: clang. While here, wordsmith the error a bit. Now clang says: error: filter expression has non-integral type 'Foo' Fixes PR43779 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69969 Files:

[PATCH] D69952: [OPENMP50]Generalize handling of context matching/scoring.

ABataev marked 3 inline comments as done. ABataev added inline comments. Comment at: clang/include/clang/Basic/OpenMPKinds.h:43 +/// Struct to store the context selectors info. +template > +struct OpenMPCtxSelectorData { jdoerfert wrote: > ABataev wrote: > >

[PATCH] D69290: [clang] Report sanitizer blacklist as a dependency in cc1 instead of driver

This revision was automatically updated to reflect the committed changes. Closed by commit rG03b84e4f6d0e: [clang] Report sanitizer blacklist as a dependency in cc1 (authored by jkorous). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D68720: Support -fstack-clash-protection for x86

sylvestre.ledru added a comment. In D68720#1733839 , @serge-sans-paille wrote: > @sylvestre.ledru did the testing and benchmarking on firefox (see > https://bugzilla.mozilla.org/show_bug.cgi?id=1588710#c12), everything seems > ok, let's move forward?

[PATCH] D69950: Reapply "Fix crash on switch conditions of non-integer types in templates"

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. I don't have experience with clang-tidy tests, but I think these two small, test-only changes are small enough that you can go ahead and commit them without review from a clang-tidy owner. lgtm

[clang] 03b84e4 - [clang] Report sanitizer blacklist as a dependency in cc1

Author: Jan Korous Date: 2019-11-07T14:06:43-08:00 New Revision: 03b84e4f6d0e1c04f22d69cc445f36e1f713beb4 URL: https://github.com/llvm/llvm-project/commit/03b84e4f6d0e1c04f22d69cc445f36e1f713beb4 DIFF: https://github.com/llvm/llvm-project/commit/03b84e4f6d0e1c04f22d69cc445f36e1f713beb4.diff

[PATCH] D69952: [OPENMP50]Generalize handling of context matching/scoring.

jdoerfert added inline comments. Comment at: clang/include/clang/Basic/OpenMPKinds.h:43 +/// Struct to store the context selectors info. +template > +struct OpenMPCtxSelectorData { ABataev wrote: > jdoerfert wrote: > > ABataev wrote: > > > jdoerfert wrote: > > >

[PATCH] D69664: [Diagnostics] Teach -Wnull-dereference about address_space attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rG01b10bc7b149: [Diagnostics] Teach -Wnull-dereference about address_space attribute (authored by xbolva00). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69664: [Diagnostics] Teach -Wnull-dereference about address_space attribute

xbolva00 updated this revision to Diff 228301. xbolva00 added a comment. Removed unused variable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69664/new/ https://reviews.llvm.org/D69664 Files: clang/lib/Sema/SemaExpr.cpp

[PATCH] D69664: [Diagnostics] Teach -Wnull-dereference about address_space attribute

xbolva00 updated this revision to Diff 228303. xbolva00 added a comment. Fixed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69664/new/ https://reviews.llvm.org/D69664 Files: clang/lib/Sema/SemaExpr.cpp clang/test/Sema/exprs.c

[PATCH] D69762: [Diagnostics] Try to improve warning message for -Wreturn-type

xbolva00 added a comment. I am not sure if "may" is ideal, it could suggest that compiler is not very sure and emits just some conservative message. "not all paths in this non-void {function,block} return a value" gives some extra confidence that compiler knows there is a buggy control path.

[PATCH] D69958: Improve VFS compatibility on Windows

rnk added a comment. This looks good to me. I had one suggestion, and I would also like to hear from another reviewer who has more ownership over VFS. Comment at: llvm/include/llvm/Support/VirtualFileSystem.h:657 + // slashes to match backslashes (and vice versa). + bool

[PATCH] D69664: [Diagnostics] Teach -Wnull-dereference about address_space attribute

xbolva00 updated this revision to Diff 228298. xbolva00 added a comment. More tests. Handle __attribute__((address_space(0))). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69664/new/ https://reviews.llvm.org/D69664 Files:

[PATCH] D69089: [Parser] #pragma clang transform

Meinersbur updated this revision to Diff 228297. Meinersbur added a comment. - Switch to monorepo - Move Transform.h/cpp to clangBasic - Separate Transform and TransformClause Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69089/new/

[PATCH] D69263: [clangd] Implement cross-file rename.

hokein updated this revision to Diff 228294. hokein marked 13 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69263/new/ https://reviews.llvm.org/D69263 Files:

[PATCH] D69762: [Diagnostics] Try to improve warning message for -Wreturn-type

Quuxplusone added a comment. In D69762#1737612 , @easyaspi314 wrote: > How about "this non-void {function|block} {may|does} not return a value" FWIW, I am happy with this clear and concise suggestion. :) Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D69263: [clangd] Implement cross-file rename.

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:345 + SourceLocation SourceLocationBeg = + SM.getMacroArgExpandedLocation(getBeginningOfIdentifier( + RInputs.Pos, SM, AST.getASTContext().getLangOpts()));

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

ekatz added a comment. With this change (current trunk) you can write code as follows: extern "C++11" int x; And it will pass compilation. No other compiler support it, nor it should, as there is no such thing as `extern "C++11"` nor `extern "C++14"`. Repository: rG LLVM Github Monorepo

[PATCH] D69762: [Diagnostics] Try to improve warning message for -Wreturn-type

easyaspi314 added a comment. How about "this non-void {function|block} {may|does} not return a value" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69762/new/ https://reviews.llvm.org/D69762 ___

[PATCH] D69878: Consoldiate internal denormal flushing controls

arsenm marked an inline comment as done. arsenm added a comment. In D69878#1736865 , @Anastasia wrote: > > Stop emitting the denorms-are-zero attribute for the OpenCL flag. It > > has no in-tree users. The meaning would also be target dependent, such > >

[PATCH] D69962: [CFG] Fix a flaky crash in CFGBlock::getLastCondition().

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/test/Analysis/a_flaky_crash.cpp:19 + +// 256 copies of the same run-line to make it crash more often when it breaks. + This is a trade-off between reliability and not increasing

[PATCH] D69762: [Diagnostics] Try to improve warning message for -Wreturn-type

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:579 def warn_maybe_falloff_nonvoid_function : Warning< - "control may reach end of non-void function">, + "not all control paths in this

[PATCH] D69962: [CFG] Fix a flaky crash in CFGBlock::getLastCondition().

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso. Herald added a project: clang. Herald added a subscriber: cfe-commits. Using an end iterator of an empty CFG block boiled down to dereferencing a garbage pointer.

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

lebedev.ri added a comment. As far as i can tell the builder does not add any debug info. Should it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69785/new/ https://reviews.llvm.org/D69785 ___

[PATCH] D58896: Suppress -Wchar-subscripts if the index is a literal char

xbolva00 added a comment. int('i') is nice fixit we could emit in this case! Thanks for this idea! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58896/new/ https://reviews.llvm.org/D58896 ___

[PATCH] D69925: remove redundant LLVM version from version string when setting CLANG_VENDOR

nickdesaulniers added a comment. Just grabbed a version string off a MBP: $ clang --version Apple LLVM version 10.0.1 (clang-1001.0.46.4) Target: x86_64-apple-darwin18.7.0 Thread model: posix InstalledDir: /Library/Developer/CommandLineTools/usr/bin So it looks like the Apple

[clang] b95bb08 - [CodeGenModule] Group blocks runtime globals together, NFC

Author: Vedant Kumar Date: 2019-11-07T12:46:26-08:00 New Revision: b95bb0847a1ea366dda69901c24415e0d00a9527 URL: https://github.com/llvm/llvm-project/commit/b95bb0847a1ea366dda69901c24415e0d00a9527 DIFF: https://github.com/llvm/llvm-project/commit/b95bb0847a1ea366dda69901c24415e0d00a9527.diff

[PATCH] D68912: Adds -Wrange-loop-analysis to -Wall

xbolva00 accepted this revision. xbolva00 added a comment. This revision is now accepted and ready to land. Formally unblocking this CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68912/new/ https://reviews.llvm.org/D68912 ___ cfe-commits

[PATCH] D69922: [OpenMP] Use the OpenMP-IR-Builder

jdoerfert marked 4 inline comments as done. jdoerfert added inline comments. Comment at: clang/test/Driver/fopenmp.c:130-131 +// CHECK-CC1-OPENMPIRBUILDER: "-cc1" +// CHECK-CC1-OPENMPIRBUILDER: "-fopenmp" +// CHECK-CC1-OPENMPIRBUILDER: "-fopenmp-enable-irbuilder" +//

[PATCH] D58896: Suppress -Wchar-subscripts if the index is a literal char

Quuxplusone added a comment. In D58896#1737242 , @edward-jones wrote: > In D58896#1737200 , @xbolva00 wrote: > > > Well, i am not sure if one twitter report is good motivation to criple > > warning. > > > The

[PATCH] D69762: [Diagnostics] Try to improve warning message for -Wreturn-type

Quuxplusone added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:579 def warn_maybe_falloff_nonvoid_function : Warning< - "control may reach end of non-void function">, + "not all control paths in this function return a value; non-void function

[PATCH] D69925: remove redundant LLVM version from version string when setting CLANG_VENDOR

nickdesaulniers added a comment. In D69925#1737361 , @arphaman wrote: > +1, Apple's clang has an `#ifdef 0` around this code. Is that +1 in favor of the patch as is, or +1 to @eli.friedman 's comment? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D69762: [Diagnostics] Try to improve warning message for -Wreturn-type

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:584-587 def err_maybe_falloff_nonvoid_block : Error< "control may reach end of non-void block">; def err_falloff_nonvoid_block : Error< "control reaches end of non-void

[PATCH] D69952: [OPENMP50]Generalize handling of context matching/scoring.

ABataev updated this revision to Diff 228290. ABataev added a comment. Rebase + address some comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69952/new/ https://reviews.llvm.org/D69952 Files: clang/include/clang/Basic/Attr.td

[PATCH] D69961: [clangd] Fix a regression of not showing documentation from forward declarations.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. There is a regression from https://reviews.llvm.org/D68467. Unlike class forward declarations, function ducomentation is

[PATCH] D68912: Adds -Wrange-loop-analysis to -Wall

Mordante added a comment. Thanks for the review. I also looked at some of the new warnings and I'm preparing patches to fix them. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68912/new/ https://reviews.llvm.org/D68912 ___ cfe-commits

[clang] 2b943c4 - [Sema] Fixes a crash with a templated destructor

Author: Mark de Wever Date: 2019-11-07T21:22:27+01:00 New Revision: 2b943c46873a6411c5a79dcd708d8c72ce5b3675 URL: https://github.com/llvm/llvm-project/commit/2b943c46873a6411c5a79dcd708d8c72ce5b3675 DIFF: https://github.com/llvm/llvm-project/commit/2b943c46873a6411c5a79dcd708d8c72ce5b3675.diff

[PATCH] D69225: Sema: Fixes a crash with a templated destructor

This revision was automatically updated to reflect the committed changes. Closed by commit rG2b943c46873a: [Sema] Fixes a crash with a templated destructor (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69225/new/

[PATCH] D68578: [HIP] Fix device stub name

rjmccall added a comment. There are a number of places in IRGen that pass around `GlobalDecl`s with the expectation that that's sufficient to uniquely identify a symbol. The fact that IRGen breaks down the GD at the last second before passing it to the mangler, rather than passing it to the

[PATCH] D67460: clang-tidy: modernize-use-using work with multi-argument templates

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I'm a bit worried that this manual parsing technique will need fixing again in the future, but I think this is at least a reasonable incremental improvement. LGTM with a minor

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with a nit Comment at: llvm/include/llvm/IR/OpenMPConstants.h:1 +//===- IR/OpenMPConstants.h - OpenMP related constants & helper - C++ -*-===// +//

[PATCH] D69952: [OPENMP50]Generalize handling of context matching/scoring.

ABataev marked an inline comment as done. ABataev added inline comments. Comment at: clang/include/clang/Basic/OpenMPKinds.h:56 + OpenMPContextSelectorKind Ctx, const U ) + : CtxSet(CtxSet), Ctx(Ctx), Names(Names.begin(), Names.end()) {} +};

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8d8f9c244074: [clang] Add -fdebug-default-version for specifying the default DWARF version (authored by dblaikie). Changed prior to commit: https://reviews.llvm.org/D69822?vs=228250=228287#toc

[clang] 8d8f9c2 - [clang] Add -fdebug-default-version for specifying the default DWARF version

Author: David Blaikie Date: 2019-11-07T12:05:58-08:00 New Revision: 8d8f9c24407461fadf1730e80ebcf7c767254715 URL: https://github.com/llvm/llvm-project/commit/8d8f9c24407461fadf1730e80ebcf7c767254715 DIFF: https://github.com/llvm/llvm-project/commit/8d8f9c24407461fadf1730e80ebcf7c767254715.diff

[PATCH] D69855: [clang-tidy] Fix llvm-namespace-comment for macro expansions

aaron.ballman added a comment. There's a design question about why it should accept the expanded macro name instead of requiring the user to write the macro. I am worried about allowing the expanded form because the presumable use of a macro is to control the name, so this invites name

[PATCH] D69762: [Diagnostics] Try to improve warning message for -Wreturn-type

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:584-587 def err_maybe_falloff_nonvoid_block : Error< "control may reach end of non-void block">; def err_falloff_nonvoid_block : Error<

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

bader added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1034 + let Spellings = [Clang<"sycl_kernel">]; + let Subjects = SubjectList<[Function]>; + let LangOpts = [SYCL]; aaron.ballman wrote: > Shouldn't this be `FunctionTemplate` instead?

  1   2   3   >