[PATCH] D70553: [clang-apply-replacements] Add command line option to overwrite readonly files.

aaron.ballman added a comment. Can you add a test case for this functionality? Comment at: clang-tools-extra/clang-apply-replacements/tool/ClangApplyReplacementsMain.cpp:52 +static cl::opt ForceOverwriteReadOnly( +"force", cl::desc("Overwrite read-only files when applying

[PATCH] D70368: [clang-tidy] Rewrite modernize-avoid-bind check

aaron.ballman accepted this revision. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM once you handle the last remaining nits from @Eugene.Zelenko. Comment at: clang-tools-extra/clang-tidy/mode

[PATCH] D68912: Adds -Wrange-loop-analysis to -Wall

xbolva00 added a comment. In D68912#1754660 , @xbolva00 wrote: > I think you can commit it, you already fixed some warnings. Oh, I hit this (-Werror bots) hard :D Some bots use -Werror. So when build is warning-free, then please commit this patch. CHA

[PATCH] D61837: Make it possible control matcher traversal kind with ASTContext

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a few minor nits. Comment at: clang/include/clang/AST/ASTContext.h:3009 class ParentMap; - std::unique_ptr Parents; + std::map> Parents; --

[PATCH] D70625: [DebugInfo][BPF] Support to emit debugInfo for extern variables

yonghong-song added a comment. @dblaikie Thanks for the review. To address your comments below: > the title talks about global variables > the description talks about extern types (guessing that's just a typo?) The title is "Support to emit debugInfo for extern variables". In the description,

[PATCH] D70627: [AST] Split out Attrs.h for table generated *Attr classes

aaron.ballman added a comment. Basically LGTM but I am hoping we can get a better name than `Attr.h` and `Attrs.h`. Comment at: clang/include/clang/AST/Attrs.h:1 +//===--- Attr.h - Classes for representing attributes --*- C++ -*-===// +// This should r

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3445 + let Spellings = [Clang<"acquire_handle">]; + let Subjects = SubjectList<[Function, ParmVar], ErrorDiag>; + let Documentation = [AcquireHandleDocs]; xazax.hun wrote: > aar

[PATCH] D70596: [analyzer][docs] NFC: Extend documentation for MallocOverflow checker

This revision was automatically updated to reflect the committed changes. Closed by commit rG79e2325f145d: [analyzer][docs] NFC: Extend documentation for MallocOverflow checker (authored by boga95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70596

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

This revision was automatically updated to reflect the committed changes. boga95 marked 2 inline comments as done. Closed by commit rG89bc4c662c6c: [analyzer] Add custom filter functions for GenericTaintChecker (authored by boga95). Changed prior to commit: https://reviews.llvm.org/D59516?vs=22

[clang] 89bc4c6 - [analyzer] Add custom filter functions for GenericTaintChecker

Author: Borsik Gabor Date: 2019-11-23T20:12:15+01:00 New Revision: 89bc4c662c6c316f037347bf46efb9dc7584b15a URL: https://github.com/llvm/llvm-project/commit/89bc4c662c6c316f037347bf46efb9dc7584b15a DIFF: https://github.com/llvm/llvm-project/commit/89bc4c662c6c316f037347bf46efb9dc7584b15a.diff

[PATCH] D69855: [clang-tidy] Fix llvm-namespace-comment for macro expansions

aaron.ballman closed this revision. aaron.ballman added a comment. In D69855#1754047 , @twardakm wrote: > @aaron.ballman thanks for the review :) Can you please push the change on my > behalf? I don't have commit rights. I've commit on your behalf in 47

[clang-tools-extra] 4736d63 - Fix llvm-namespace-comment for macro expansions

Author: Marcin Twardak Date: 2019-11-23T13:08:14-05:00 New Revision: 4736d63f752f8d13f4c6a9afd558565c32119718 URL: https://github.com/llvm/llvm-project/commit/4736d63f752f8d13f4c6a9afd558565c32119718 DIFF: https://github.com/llvm/llvm-project/commit/4736d63f752f8d13f4c6a9afd558565c32119718.diff

[PATCH] D69391: Add #pragma clang loop ivdep

YashasAndaluri updated this revision to Diff 230767. YashasAndaluri edited the summary of this revision. YashasAndaluri added a comment. Added IvdepEnable loop attribute and `llvm.loop.vectorize.ivdep.enable` metadata. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69391/new/ https://re

[PATCH] D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG0010ea4224c7: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux (authored by aaronpuchert). Repository: rG L

[clang] 0010ea4 - [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux

Author: Aaron Puchert Date: 2019-11-23T16:00:53+01:00 New Revision: 0010ea4224c7ff6b5aebeecacf10a7ced7d390b7 URL: https://github.com/llvm/llvm-project/commit/0010ea4224c7ff6b5aebeecacf10a7ced7d390b7 DIFF: https://github.com/llvm/llvm-project/commit/0010ea4224c7ff6b5aebeecacf10a7ced7d390b7.diff

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

thakis added a comment. In D70500#1757738 , @thakis wrote: > ps: The test fails for me, probably because I don't have wasm-opt on PATH? > How does this work on the regular bots? Do they all have emscripten installed? Looks like it might fail with LLVM_A

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

thakis added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:137 + getFilePaths().push_back(getDriver().SysRoot + "/lib/" + MultiarchTriple + + "/llvm-lto"); +} sunfish wrote: > sbc100 wrote: > > Is

[clang] ed33cb5 - [RISCV] Add missing REQUIRES to clang tests

Author: David Zarzycki Date: 2019-11-23T14:47:09+02:00 New Revision: ed33cb5b147402c06a3e0a9082b0f991a9d91a1b URL: https://github.com/llvm/llvm-project/commit/ed33cb5b147402c06a3e0a9082b0f991a9d91a1b DIFF: https://github.com/llvm/llvm-project/commit/ed33cb5b147402c06a3e0a9082b0f991a9d91a1b.diff

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

thakis added a comment. ps: The test fails for me, probably because I don't have wasm-opt on PATH? How does this work on the regular bots? Do they all have emscripten installed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70500/new/ https://revi

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

thakis reopened this revision. thakis added a comment. This revision is now accepted and ready to land. Please don't add code to the driver that runs programs off PATH. Nothing else does this. If you need to run an external program, look for it next to the compiler, like we do for gas with -fno-

[PATCH] D70633: clang-format-vs : Fix Unicode Replacements

empty2fill created this revision. empty2fill added reviewers: clang-format, hans. empty2fill added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. Use UTF-8 for communication with clang-format and convert the replacements offset/length to characters

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 updated this revision to Diff 230756. lh123 added a comment. Expand response files before `inferMissingCompileCommands` and `inferTargetAndDriverMode` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70222/new/ https://reviews.llvm.org/D70222 Files: clang/include/clang/Tooling/Co

[Diffusion] rG825235c140e7: Revert "[Sema] Use the canonical type in function isVector"

SjoerdMeijer added a comment. I don't think I have full context of the problem but in this diff I see type `__fp16`, which is the storage-only type. But if we are talking about v8.2-A and FP16, then we are talking about the native type (e.g. source-language type `_Float16`), and for that yo

[PATCH] D69628: [Clang] Pragma vectorize_width() implies vectorize(enable), take 3

SjoerdMeijer marked an inline comment as done. SjoerdMeijer added inline comments. Comment at: clang/lib/CodeGen/CGLoopInfo.cpp:302-306 +// Imply vectorize.enable when it is not already disabled/enabled. +Args.push_back( +MDNode::get(Ctx, {MDString::get(Ctx, "llvm

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 updated this revision to Diff 230752. lh123 added a comment. Herald added a subscriber: mgorny. Address comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70222/new/ https://reviews.llvm.org/D70222 Files: clang/include/clang/Tooling/CompilationDatabase.h clang/lib/Tooling/