[PATCH] D70973: [OPENMP50]Treat context selectors as expressions, not just strings.

jdoerfert added a comment. In D70973#1793061 , @jdoerfert wrote: > I haven't forgotten about this! With the other two changes to the declare > variant going to happen now,as well, I figured we should look at this again > from a high-level. > > My plan no

[PATCH] D71830: [OpenMP] Reusable OpenMP context/traits handling

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings . {icon times-circle color=red} clang-forma

[PATCH] D71716: [ItaniumCXXABI] Don't mark an extern_weak init function as dso_local on windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG86c9831bb40d: [ItaniumCXXABI] Don't mark an extern_weak init function as dso_local on windows (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[clang] b714583 - [OpenCL] Add atomic builtin functions

Author: Sven van Haastregt Date: 2019-12-23T12:29:01Z New Revision: b714583fd09683458be9eb03a9faef656a8ccf49 URL: https://github.com/llvm/llvm-project/commit/b714583fd09683458be9eb03a9faef656a8ccf49 DIFF: https://github.com/llvm/llvm-project/commit/b714583fd09683458be9eb03a9faef656a8ccf49.diff

[clang] eca4006 - [NFC] Move OptionUtils from Basic to Driver

Author: Yaxun (Sam) Liu Date: 2019-12-23T08:11:23-05:00 New Revision: eca40066ebb5759aa44d21833c7a1fd7dd2361af URL: https://github.com/llvm/llvm-project/commit/eca40066ebb5759aa44d21833c7a1fd7dd2361af DIFF: https://github.com/llvm/llvm-project/commit/eca40066ebb5759aa44d21833c7a1fd7dd2361af.dif

[PATCH] D71802: [NFC] Move OptionUtils from Basic to Driver

This revision was automatically updated to reflect the committed changes. Closed by commit rGeca40066ebb5: [NFC] Move OptionUtils from Basic to Driver (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D71802?vs=235036&id=235134#toc Repositor

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

djtodoro added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:169 +* C DebugInfo API ``LLVMDIBuilderCreateTypedef`` is updated to include an extra +argument ``AlignInBits``, to facilitate / propagate specified Alignment information

[PATCH] D71830: [OpenMP] Reusable OpenMP context/traits handling

JonChesterfield added a comment. Big patch but looks like a net decrease in complexity. Please could you clang format the areas phabricator is complaining about? Reading through on a browser looks great. I'll take a closer look in a real editor once Christmas is out of the way. Thanks for posti

[clang] 0860db9 - [OPENMP50]Codegen for nontemporal clause.

Author: Alexey Bataev Date: 2019-12-23T10:04:46-05:00 New Revision: 0860db966a7d2ab61b26e41426a55189986924b4 URL: https://github.com/llvm/llvm-project/commit/0860db966a7d2ab61b26e41426a55189986924b4 DIFF: https://github.com/llvm/llvm-project/commit/0860db966a7d2ab61b26e41426a55189986924b4.diff

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0860db966a7d: [OPENMP50]Codegen for nontemporal clause. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71708/new/ https://reviews.llvm

[PATCH] D71842: Allow newlines in AST Matchers in clang-query files

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D71842 Files: clang-tools-extra/clang-query/Query.cpp clang-tools-extra/clang-query/

[PATCH] D71830: [OpenMP] Reusable OpenMP context/traits handling

jdoerfert added a comment. In D71830#1794920 , @JonChesterfield wrote: > Big patch but looks like a net decrease in complexity. Please could you clang > format the areas phabricator is complaining about? I'll go over it. (FWIW, I do clang format my pat

[PATCH] D71666: [clang-tidy] Fix readability-const-return-type identifying the wrong `const` token

ilya updated this revision to Diff 235156. ilya added a comment. Update LexerUtils.h documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71666/new/ https://reviews.llvm.org/D71666 Files: clang-tools-extra/clang-tidy/readability/ConstRet

[PATCH] D71830: [OpenMP] Reusable OpenMP context/traits handling

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60967 tests passed, 0 failed and 726 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D71666: [clang-tidy] Fix readability-const-return-type identifying the wrong `const` token

ilya marked 2 inline comments as done. ilya added a comment. @aaron.ballman, thanks for reviewing. Do you mind submitting this, as I don't have commit access? Comment at: clang-tools-extra/clang-tidy/utils/LexerUtils.h:95-97 +/// Assuming that ``Range`` spans a CVR-qualified t

[PATCH] D71666: [clang-tidy] Fix readability-const-return-type identifying the wrong `const` token

ilya updated this revision to Diff 235157. ilya marked an inline comment as done. ilya added a comment. Doxygen format the documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71666/new/ https://reviews.llvm.org/D71666 Files: clang-tools

[clang-tools-extra] d2c9c91 - Move from a long list of checkers to tables

Author: Sylvestre Ledru Date: 2019-12-23T18:44:31+01:00 New Revision: d2c9c9157b0528436d3b9f5e22c872f0ee6509a2 URL: https://github.com/llvm/llvm-project/commit/d2c9c9157b0528436d3b9f5e22c872f0ee6509a2 DIFF: https://github.com/llvm/llvm-project/commit/d2c9c9157b0528436d3b9f5e22c872f0ee6509a2.dif

[PATCH] D36051: Move from a long list of checkers to tables

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGd2c9c9157b05: Move from a long list of checkers to tables (authored by sylvestre.ledru). Repository: rG LLVM Github Mon

[PATCH] D71791: [CFG] Fix an assertion failure with static initializers

xazax.hun updated this revision to Diff 235161. xazax.hun added a comment. I decided to fix the unittests. Having CFGs full of dangling pointers to the AST does not look fun at all, so I think this change was long overdue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71791/new/ https:

[PATCH] D69272: Restricted variant of '#pragma STDC FENV_ACCESS'

kpn added a comment. In D69272#1794630 , @sepavloff wrote: > Putting restriction on use of the pragma is of course, a temporary solution, > it is not usable in all cases. But for some cases it is usable in production > code. Where small pieces of code ma

[PATCH] D70689: [analyzer] Fix SARIF column locations

jranieri-grammatech marked an inline comment as not done. jranieri-grammatech added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SarifDiagnostics.cpp:157 + const MemoryBuffer *Buf = SM.getBuffer(LocInfo.first); + assert(Buf && "got a NULL buffer for the location's

[clang] d35bcbb - [Sema][X86] Consider target attribute into the checks in validateOutputSize and validateInputSize.

Author: Craig Topper Date: 2019-12-23T11:23:30-08:00 New Revision: d35bcbbb5dab0e29b21a586505f5b274377cc41b URL: https://github.com/llvm/llvm-project/commit/d35bcbbb5dab0e29b21a586505f5b274377cc41b DIFF: https://github.com/llvm/llvm-project/commit/d35bcbbb5dab0e29b21a586505f5b274377cc41b.diff

[PATCH] D68627: [Sema][X86] Consider target attribute into the checks in validateOutputSize and validateInputSize.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd35bcbbb5dab: [Sema][X86] Consider target attribute into the checks in validateOutputSize and… (authored by craig.topper). Changed prior to commit: https://reviews.llvm.org/D68627?vs=232666&id=235168#to

[PATCH] D71846: Fix for https://bugs.llvm.org/show_bug.cgi?id=44364

njames93 created this revision. njames93 added a reviewer: clang-tools-extra. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds a new ASTMatcher condition called 'hasInitStorage()' that matches if and switch statements with initializer. Then tweaks the clang-tidy 'reada

[PATCH] D70265: [clang-tidy] Add clang tidy check I.2 to cppcoreguidelines

vingeldal updated this revision to Diff 235176. vingeldal marked 7 inline comments as done. vingeldal added a comment. Updating D70265 : [clang-tidy] Add clang tidy check I.2 to cppcoreguidelines - Added an option to not check member variables. - Add checking for

[PATCH] D70265: [clang-tidy] Add clang tidy check I.2 to cppcoreguidelines

vingeldal added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidNonConstGlobalVariablesCheck.cpp:64 + + if (Variable) { +diag(Variable->getLocation(), "variable %0 is non-const and globally " JonasToth wrote: > each of those

[clang] 4b64e03 - ASTContext: fix declaration of ParsedTargetAttr [-Wmismatched-tags] after D68627

Author: Fangrui Song Date: 2019-12-23T12:38:37-08:00 New Revision: 4b64e034612017fcc97b64d6031319cf18dbbb88 URL: https://github.com/llvm/llvm-project/commit/4b64e034612017fcc97b64d6031319cf18dbbb88 DIFF: https://github.com/llvm/llvm-project/commit/4b64e034612017fcc97b64d6031319cf18dbbb88.diff

[PATCH] D68627: [Sema][X86] Consider target attribute into the checks in validateOutputSize and validateInputSize.

MaskRay added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:116 class ObjCTypeParamDecl; +class ParsedTargetAttr; class Preprocessor; This should be `struct`. I fixed it it in 4b64e034612017fcc97b64d6031319cf18dbbb88 Repository: rG LLVM

[PATCH] D70527: [clang] Fix the canonicalization of paths in -fdiagnostics-absolute-paths

MaskRay added inline comments. Comment at: clang/test/Frontend/absolute-paths-symlinks.c:15 + +// REQUIRES: shell rnk wrote: > I wish we had a more precise feature to indicate symlink support, but this is > what we do elsewhere, so there's nothing to do here. I

[PATCH] D70527: [clang] Fix the canonicalization of paths in -fdiagnostics-absolute-paths

MaskRay added inline comments. Comment at: clang/lib/Basic/FileManager.cpp:562 - CanonicalDirNames.insert({Dir, CanonicalName}); + CanonicalNames.insert({Dir, CanonicalName}); + return CanonicalName; There is no need to change now, but I think try_emplace ma

[PATCH] D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item

ilya marked an inline comment as done. ilya added a comment. In D71714#1791464 , @riccibruno wrote: > These are not the only AST nodes representing cast expressions (there is also > `CXXFunctionalCastExpr`, ...). What about replacing the > `IgnoreParenIm

[PATCH] D68627: [Sema][X86] Consider target attribute into the checks in validateOutputSize and validateInputSize.

craig.topper marked an inline comment as done. craig.topper added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:116 class ObjCTypeParamDecl; +class ParsedTargetAttr; class Preprocessor; MaskRay wrote: > This should be `struct`. I fixed it it

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

dblaikie added a comment. In D70696#1794440 , @rnk wrote: > Three of these tests have been failing for me locally since this patch landed: > > Failing Tests (3): > Clang :: CodeGen/debug-info-extern-basic.c > Clang :: CodeGen/debug-info-exter

[PATCH] D71848: Allow the discovery of Android NDK's triple-prefixed binaries.

brianpl updated this revision to Diff 235182. brianpl added a comment. Fix a typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71848/new/ https://reviews.llvm.org/D71848 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/android-triple-ver

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

abelkocsis updated this revision to Diff 235180. abelkocsis added a comment. Checker is moved to bugprone section, tests added. C checker is improved, and documentations are synchronised. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70876/new/ htt

[PATCH] D71848: Allow the discovery of Android NDK's triple-prefixed binaries.

brianpl created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. brianpl added a reviewer: jyknight. brianpl updated this revision to Diff 235182. brianpl added a comment. Fix a typo. Currently, tool discovery checks for a tool with its target triple as a pre

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-spuriously-wake-up-functions.rst:4 +bugprone-spuriously-wake-up-functions += + Please make length same as in title. Repository:

[PATCH] D71791: [CFG] Fix an assertion failure with static initializers

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. In D71791#1795093 , @xazax.hun wrote: > I decided to fix the unittests. Having CFGs full of dangling pointers to the > AST does not look fun at a

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

yonghong-song added a comment. > Could you link to particular bots that have logs showing they ran this test? > (perhaps the logs have been retired by now, though - since this patch was > reverted :/ - but then at least seeing which bots run BPF tests would be > helpful) @dblaikie Actually, I

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

sylvestre.ledru added a comment. Is this failure expected? https://bugs.llvm.org/show_bug.cgi?id=44370 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64454/new/ https://reviews.llvm.org/D64454 ___ cfe-commits mailing l

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

dblaikie added a comment. In D70696#1795302 , @yonghong-song wrote: > > Could you link to particular bots that have logs showing they ran this > > test? (perhaps the logs have been retired by now, though - since this patch > > was reverted :/ - but then

[PATCH] D71791: [CFG] Fix an assertion failure with static initializers

NoQ accepted this revision. NoQ added a comment. Woohoo tests!~~ Comment at: clang/unittests/Analysis/CFGBuildResult.h:69 + Finder.matchAST(AST->getASTContext()); + Callback.TheBuildResult.setAST(std::move(AST)); return std::move(Callback.TheBuildResult);

[PATCH] D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item

ilya updated this revision to Diff 235184. ilya added a comment. 1. Refactor `CheckArrayAccess()` to take `AllowPastTheEnd` parameter to avoid a false positive array out-of-bounds warning for `&(cond ? arr1[N] : arr2[N])`. 2. Use `IgnoreParenCasts()` instead of `IgnoreParenImpCasts()` in `CheckA

[clang] 379613d - [CFG] Fix an assertion failure with static initializers

Author: Gabor Horvath Date: 2019-12-23T16:35:37-08:00 New Revision: 379613d7c7fa9698a2c300f4067165b5309a5e6e URL: https://github.com/llvm/llvm-project/commit/379613d7c7fa9698a2c300f4067165b5309a5e6e DIFF: https://github.com/llvm/llvm-project/commit/379613d7c7fa9698a2c300f4067165b5309a5e6e.diff

[PATCH] D71791: [CFG] Fix an assertion failure with static initializers

This revision was automatically updated to reflect the committed changes. Closed by commit rG379613d7c7fa: [CFG] Fix an assertion failure with static initializers (authored by xazax.hun). Changed prior to commit: https://reviews.llvm.org/D71791?vs=235161&id=235185#toc Repository: rG LLVM Git

[PATCH] D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item

ilya marked an inline comment as done. ilya added a comment. Implemented @riccibruno's and @rsmith's comments. While I agree with the general notion about the flaws with the current implementation, I feel that the more major refactoring proposed in this review is out of the scope of this minor f

[PATCH] D71709: Give frontend dump flags consistent names (*-dump instead of dump-*)

herzka updated this revision to Diff 235188. herzka added a comment. rebase, restore changes to CC1Options.td that I left out of last revision Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71709/new/ https://reviews.llvm.org/D71709 Files: clang/

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

yonghong-song added a comment. @dblaikie The root cause has been identified by @rnk . A clang plugin is used which requires the following patch: https://github.com/llvm/llvm-project/commit/5128026467cbc17bfc796d94bc8e40e52a9b0752 which has been merged. The original extern variable debug info

[PATCH] D71830: [OpenMP] Reusable OpenMP context/traits handling

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff.

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

dblaikie added a comment. In D70696#1795427 , @yonghong-song wrote: > @dblaikie The root cause has been identified by @rnk . A clang plugin is used > which requires the following patch: > > > https://github.com/llvm/llvm-project/commit/5128026467cbc17

[PATCH] D71830: [OpenMP] Reusable OpenMP context/traits handling

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff.