Re: [clang] ce1f95a - Reland "[clang] Remove the DIFlagArgumentNotModified debug info flag"

Hi David, It's a good question. Current approach of the debug entry values will consider an entry value as a valid value until the variable gets modified. Please consider this. void fn(int a) { ... a++; } If there is an instruction that does not affect the code generated, e.g. an ADD

[PATCH] D69272: Enable '#pragma STDC FENV_ACCESS' in frontend

sepavloff updated this revision to Diff 235392. sepavloff added a comment. Updated patch Removed the previous limitation on use of the pragma, which restricted the pragma to the topmost block only. It should favor users who do not bother about performance but want the usage be as defined by the

[PATCH] D64573: [Syntax] Allow to mutate syntax trees

ilya-biryukov added a comment. Thanks for the fixes! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64573/new/ https://reviews.llvm.org/D64573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D70290: [OpenMP] Use the OpenMPIRBuilder for "omp parallel"

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61124 tests passed, 1 failed and 728 were skipped. failed: Clang.OpenMP/cancel_codegen.cpp {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D70290: [OpenMP] Use the OpenMPIRBuilder for "omp parallel"

jdoerfert updated this revision to Diff 235390. jdoerfert added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Rebase + add a test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70290/new/

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

junparser added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1227 + MPM.addPass(createModuleToPostOrderCGSCCPassAdaptor(CoroSplitPass())); + MPM.addPass(createModuleToFunctionPassAdaptor(CoroElidePass())); +

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

craig.topper added a comment. In D62731#1796962 , @AntonYudintsev wrote: > I have found bug in clang-cl (win32 clang), related to recent inroduction of > ffp-exception-behavior. > Unfortunately, I don't have a working patch yet, and since LLVM

Re: [clang] 522ee29 - Allow newlines in AST Matchers in clang-query files

Reverted in https://github.com/llvm/llvm-project/commit/5ca97d0defeed38feec2352692f6bb80297d6712 On Thu, Dec 26, 2019 at 12:41 PM Stephen Kelly via cfe-commits wrote: > > > Author: Stephen Kelly > Date: 2019-12-26T20:40:33Z > New Revision: 522ee29a4fb3814db604b585c8637247477ec057 > > URL: >

[PATCH] D71846: [ASTMatchers] Fix for https://bugs.llvm.org/show_bug.cgi?id=44364

njames93 added a comment. Should also point out that clang-format now has a better time reformatting as i expanded the replacements range to include the entire else block rather than the start and end braces CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71846/new/

[clang-tools-extra] 5ca97d0 - Revert "Allow newlines in AST Matchers in clang-query files" + 1

Author: Evgenii Stepanov Date: 2019-12-26T18:07:20-08:00 New Revision: 5ca97d0defeed38feec2352692f6bb80297d6712 URL: https://github.com/llvm/llvm-project/commit/5ca97d0defeed38feec2352692f6bb80297d6712 DIFF:

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

chandlerc added a comment. Can we add an LLVM test w/ the metadata so that we have an entirely LLVM test flow that ensures the pass builder DTRT? (I still would include the Clang side test which is also very useful to test integrating Clang w/ different flows through the pass manager.)

[PATCH] D71846: [ASTMatchers] Fix for https://bugs.llvm.org/show_bug.cgi?id=44364

njames93 updated this revision to Diff 235384. njames93 edited the summary of this revision. njames93 added a comment. Think all the test cases are working, but they look like they could do with a clean up from someone who may know the clang-tidy-checks system better than myself CHANGES SINCE

Re: [PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

You can sign up for an account by emailing the admin account. On Thu, Dec 26, 2019, 5:04 PM Anton Yudintsev via Phabricator < revi...@reviews.llvm.org> wrote: > AntonYudintsev added a comment. > > I have found bug in clang-cl (win32 clang), related to recent inroduction > of

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

AntonYudintsev added a comment. I have found bug in clang-cl (win32 clang), related to recent inroduction of ffp-exception-behavior. Unfortunately, I don't have a working patch yet, and since LLVM bugtracker registration is closed, I can not even submit a bug. So, if it is not a trouble for

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

mehdi_amini added inline comments. Comment at: llvm/lib/Passes/PassBuilder.cpp:484 +LPM2.addPass(LoopFullUnrollPass(Level, +/*OnlyWhenForced=*/!PTO.LoopUnrolling, PTO.ForgetAllSCEVInLoopUnroll));

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

MaskRay added inline comments. Comment at: clang/test/Misc/loop-opt-setup.c:13 +int B(void) { +#pragma clang loop unroll(full) + for (int i = 0; i < 16; ++i) The test seems to pass without the code change (llvm/lib/Passes/PassBuilder.cpp) below. Repository:

[clang] 2369560 - Fix -Wunused-lambda-capture warnings.

Author: Eric Christopher Date: 2019-12-26T15:27:21-08:00 New Revision: 2369560f4a7720b19edfbf9de14ef061307ff773 URL: https://github.com/llvm/llvm-project/commit/2369560f4a7720b19edfbf9de14ef061307ff773 DIFF:

[PATCH] D70265: [clang-tidy] Add clang tidy check I.2 to cppcoreguidelines

sylvestre.ledru added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/list.rst:198 cppcoreguidelines-avoid-magic-numbers (redirects to readability-magic-numbers) + cppcoreguidelines-avoid-non-const-global-variables

Re: [clang] 3f4b70c - Revert "[clang][modules] Add support for merging lifetime-extended temporaries"

Please include details about the reason for the revert (links to and quotes from buildbots are helpful, etc) in the commit message - so others can follow along more easily (if they're seeing a local regression, they might be able to check if this revert is likely to address it - if they want to

Re: [clang] ce1f95a - Reland "[clang] Remove the DIFlagArgumentNotModified debug info flag"

On Wed, Nov 20, 2019 at 1:08 AM Djordje Todorovic via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Djordje Todorovic > Date: 2019-11-20T10:08:07+01:00 > New Revision: ce1f95a6e077693f93d8869245f911aff3eb7e4c > > URL: >

[PATCH] D71846: [ASTMatchers] Fix for https://bugs.llvm.org/show_bug.cgi?id=44364

njames93 added a comment. So I wasn't happy with the vagueness of the else after return check implementation. Almost finished rewriting the check to properly handle the if statements with condition variables based on scope restrictions and where decls are used etc. int

[clang] 522ee29 - Allow newlines in AST Matchers in clang-query files

Author: Stephen Kelly Date: 2019-12-26T20:40:33Z New Revision: 522ee29a4fb3814db604b585c8637247477ec057 URL: https://github.com/llvm/llvm-project/commit/522ee29a4fb3814db604b585c8637247477ec057 DIFF: https://github.com/llvm/llvm-project/commit/522ee29a4fb3814db604b585c8637247477ec057.diff

[clang] 831b636 - Revert "Allow newlines in AST Matchers in clang-query files"

Author: Stephen Kelly Date: 2019-12-26T20:16:23Z New Revision: 831b636861ea33c3cc1c1c28384fb1800facf792 URL: https://github.com/llvm/llvm-project/commit/831b636861ea33c3cc1c1c28384fb1800facf792 DIFF: https://github.com/llvm/llvm-project/commit/831b636861ea33c3cc1c1c28384fb1800facf792.diff

[PATCH] D71842: Allow newlines in AST Matchers in clang-query files

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a3ecf4dc7ec: Allow newlines in AST Matchers in clang-query files (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D71842?vs=235353=235370#toc Repository: rG LLVM Github

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

echristo added a comment. Ping ping goes the trolley. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71687/new/ https://reviews.llvm.org/D71687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] 6a3ecf4 - Allow newlines in AST Matchers in clang-query files

Author: Stephen Kelly Date: 2019-12-26T20:00:59Z New Revision: 6a3ecf4dc7ec299394e71b3124df2b3a34ed4ac3 URL: https://github.com/llvm/llvm-project/commit/6a3ecf4dc7ec299394e71b3124df2b3a34ed4ac3 DIFF: https://github.com/llvm/llvm-project/commit/6a3ecf4dc7ec299394e71b3124df2b3a34ed4ac3.diff

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

tejohnson created this revision. tejohnson added reviewers: pcc, evgeny777, steven_wu. Herald added subscribers: dang, dexonsmith, MaskRay, hiraditya, arichardson, inglorion, Prazek, emaste. Herald added a reviewer: espindola. Herald added projects: clang, LLVM. Third part in series to support

[PATCH] D71846: [ASTMatchers] Fix for https://bugs.llvm.org/show_bug.cgi?id=44364

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a minor style nit. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:4325-4326 + internal::Matcher,

[PATCH] D71842: Allow newlines in AST Matchers in clang-query files

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some `auto` -> `auto *` nits. Comment at: clang-tools-extra/clang-query/QueryParser.cpp:243-244 -return new LetQuery(Name, Value); +

[PATCH] D71842: Allow newlines in AST Matchers in clang-query files

steveire marked 2 inline comments as done. steveire added inline comments. Comment at: clang-tools-extra/clang-query/QueryParser.cpp:243-244 -return new LetQuery(Name, Value); +auto Q = new LetQuery(Name, Value); +Q->RemainingContent = Line; +return Q;

[PATCH] D71911: [ThinLTO] Summarize vcall_visibility metadata

tejohnson created this revision. tejohnson added reviewers: pcc, evgeny777, steven_wu. Herald added subscribers: arphaman, dexonsmith, hiraditya, inglorion, Prazek, mehdi_amini. Herald added projects: clang, LLVM. Second patch in series to support Safe Whole Program Devirtualization Enablement,

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SpuriouslyWakeUpFunctionsCheck.cpp:22 + auto hasUniqueLock = hasDescendant(declRefExpr(hasDeclaration( + varDecl(hasType(asString("std::unique_lock")); + These

[PATCH] D70289: [OpenMP][NFCI] Use the libFrontend ProcBindKind in Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG6c5d1f40ff8d: [OpenMP][NFCI] Use the libFrontend ProcBindKind in Clang (authored by jdoerfert). Herald added a subscriber: hiraditya. Herald added a project: LLVM. Changed prior to commit:

[PATCH] D70265: [clang-tidy] Add clang tidy check I.2 to cppcoreguidelines

aaron.ballman added inline comments. Herald added a subscriber: whisperity. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidNonConstGlobalVariablesCheck.cpp:64 + + if (Variable) { +diag(Variable->getLocation(), "variable %0 is non-const and globally "

[PATCH] D71842: Allow newlines in AST Matchers in clang-query files

steveire marked 9 inline comments as done. steveire added inline comments. Comment at: clang-tools-extra/clang-query/Query.cpp:111 + } + int maxLength = firstLine.size(); std::string prefixText = "Matcher: "; aaron.ballman wrote: > `MaxLength`

[PATCH] D71907: [WPD/VFE] Always emit vcall_visibility metadata for -fwhole-program-vtables

tejohnson marked an inline comment as done. tejohnson added inline comments. Comment at: llvm/lib/IR/Metadata.cpp:1505 + // updating. + eraseMetadata(LLVMContext::MD_vcall_visibility); addMetadata(LLVMContext::MD_vcall_visibility, The erasing of old

[PATCH] D71842: Allow newlines in AST Matchers in clang-query files

steveire updated this revision to Diff 235353. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71842/new/ https://reviews.llvm.org/D71842 Files: clang-tools-extra/clang-query/Query.cpp

[clang] 6c5d1f4 - [OpenMP][NFCI] Use the libFrontend ProcBindKind in Clang

Author: Johannes Doerfert Date: 2019-12-26T11:04:07-06:00 New Revision: 6c5d1f40ff8deb2c001736c5a5bc085322910ad1 URL: https://github.com/llvm/llvm-project/commit/6c5d1f40ff8deb2c001736c5a5bc085322910ad1 DIFF:

[PATCH] D71707: clang-tidy: new bugprone-pointer-cast-widening

aaron.ballman added a comment. Herald added a subscriber: whisperity. In D71707#1791394 , @jankratochvil wrote: > In D71707#1791280 , @labath wrote: > > > - disallowing casts to intptr_t seems too restrictive -- I

[PATCH] D71907: [WPD/VFE] Always emit vcall_visibility metadata for -fwhole-program-vtables

tejohnson created this revision. tejohnson added reviewers: pcc, ostannard, evgeny777, steven_wu. Herald added subscribers: dexonsmith, hiraditya, Prazek, mehdi_amini. Herald added projects: clang, LLVM. First patch to support Safe Whole Program Devirtualization Enablement, see RFC here:

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

modocache created this revision. modocache added reviewers: GorNishanov, lewissbaker, chandlerc, junparser. Herald added subscribers: cfe-commits, EricWF. Herald added a project: clang. Depends on https://reviews.llvm.org/D71902. The last in a series of six patches that ports the LLVM coroutines

[PATCH] D70527: [clang] Fix the canonicalization of paths in -fdiagnostics-absolute-paths

Ka-Ka marked 3 inline comments as done. Ka-Ka added a comment. I have now updated the testcase according to comments by @MaskRay in commit 073cdb239044 Thanks for post-commit review comments. Repository: rG LLVM Github

[clang] 073cdb2 - [clang][test] Minor fixes in testcase absolute-paths-symlinks.c

Author: Karl-Johan Karlsson Date: 2019-12-26T09:33:21+01:00 New Revision: 073cdb239044dc056a3c79b995265f640ffb40e6 URL: https://github.com/llvm/llvm-project/commit/073cdb239044dc056a3c79b995265f640ffb40e6 DIFF: