[PATCH] D70568: [Support] Possibly use exception handler in the Crash Recovery Context in the same way as global exceptions

mstorsjo added inline comments. Comment at: llvm/lib/Support/CrashRecoveryContext.cpp:269 + const_cast(CRCI)->HandleCrash( + (int)ExceptionInfo->ExceptionRecord->ExceptionCode, ExceptionInfo); This implicitly converts a pointer to `uintptr_t`, which is

[PATCH] D72304: Summary: Add OpenMP Directives (master and critical) to OMPBuilder, and use them in clang.

jdoerfert added a comment. In D72304#1815793 , @fghanim wrote: > > Commits need a message that explains the change. > > Also the "Summary" should not be in the commit title. > > Is this something for future commits or do you want me to change these? >

[PATCH] D72304: Summary: Add OpenMP Directives (master and critical) to OMPBuilder, and use them in clang.

fghanim marked 10 inline comments as done. fghanim added a comment. > Commits need a message that explains the change. > Also the "Summary" should not be in the commit title. Is this something for future commits or do you want me to change these? If the latter, how do I do that? > This adds

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

0x8000- added a comment. One more mis-constification that I can't explain, nor reduce to a small test case (when I extract the code, the check behaves as expected / desired) namespace util { struct StringIgnoreInitialHash : public std::unary_function { size_t

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

0x8000- added a comment. Summary of "misses" One: uint32_t counter = 0; BOOST_FOREACH(const Foo* foo, *theFoos) { if (foo->getType() == someType) { ++counter; } } The -fix makes the counter const :), so obviously it breaks compilation. Two: It marks a

[PATCH] D72500: [clangd] Show hower info for expressions

lh123 added a comment. In D72500#1813975 , @sammccall wrote: > I think we should avoid triggering for literals. Maybe some exceptions, but a > hover saying that 0 is an int with value 0 seems silly. Yes, hovering over `IntegerLiteral/FloatingLiteral`

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

0x8000- added a comment. I have built diff14 and tried to apply it on an internal code base with ~7500 translation units. $ python3 /opt/clang10/share/clang/run-clang-tidy.py -clang-tidy-binary /opt/clang10/bin/clang-tidy -clang-apply-replacements

[PATCH] D71823: Support Swift calling convention for WebAssembly targets

kateinoigakukun marked an inline comment as done. kateinoigakukun added inline comments. Comment at: clang/lib/Basic/Targets/WebAssembly.h:122 +case CC_Swift: + return CCCR_OK; +default: sbc100 wrote: > This seems to disagree with the longer list in

[PATCH] D72239: [clang-tidy] new opencl recursion not supported check

ffrankies added a comment. In D72239#1815583 , @JonasToth wrote: > The other recursion check seems more sophisticated. What is your take on it? > Would you consider it better as well, what is your opinion on it? I agree, I would go with the other check

[PATCH] D70568: [Support] Possibly use exception handler in the Crash Recovery Context in the same way as global exceptions

This revision was automatically updated to reflect the committed changes. Closed by commit rGa1f16998f371: [Support] Optionally call signal handlers when a function wrapped by the the… (authored by aganea). Changed prior to commit: https://reviews.llvm.org/D70568?vs=237038=237518#toc

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61775 tests passed, 0 failed and 780 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

njames93 updated this revision to Diff 237517. njames93 added a comment. - Rebased onto trunk fixing merge issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/ https://reviews.llvm.org/D72553 Files:

[PATCH] D72560: Add -Wrange-loop-analysis changes to ReleaseNotes

Mordante marked 2 inline comments as done. Mordante added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72560/new/ https://reviews.llvm.org/D72560 ___ cfe-commits

[clang] dc422e9 - Add -Wrange-loop-analysis changes to ReleaseNotes

Author: Mark de Wever Date: 2020-01-11T19:56:34+01:00 New Revision: dc422e968e73790178e500f506e8fb7cfa1e62ea URL: https://github.com/llvm/llvm-project/commit/dc422e968e73790178e500f506e8fb7cfa1e62ea DIFF: https://github.com/llvm/llvm-project/commit/dc422e968e73790178e500f506e8fb7cfa1e62ea.diff

[PATCH] D72560: Add -Wrange-loop-analysis changes to ReleaseNotes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with some suggestions. Comment at: clang/docs/ReleaseNotes.rst:69 + copy being made when the result is bound to an rvalue reference. It no longer +

[clang] 23a799a - Revert "[ASTMatchers] extract public matchers from const-analysis into own patch"

Author: Jonas Toth Date: 2020-01-11T19:41:27+01:00 New Revision: 23a799adf0abbe9a7be1494d5efd1ab3215ee4fb URL: https://github.com/llvm/llvm-project/commit/23a799adf0abbe9a7be1494d5efd1ab3215ee4fb DIFF: https://github.com/llvm/llvm-project/commit/23a799adf0abbe9a7be1494d5efd1ab3215ee4fb.diff

[PATCH] D72560: Add -Wrange-loop-analysis changes to ReleaseNotes

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61772 tests passed, 0 failed and 780 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D72505: [ASTMatchers] extract public matchers from const-analysis into own patch

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c48ea68e491: [ASTMatchers] extract public matchers from const-analysis into own patch (authored by JonasToth). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 4c48ea6 - [ASTMatchers] extract public matchers from const-analysis into own patch

Author: Jonas Toth Date: 2020-01-11T19:21:03+01:00 New Revision: 4c48ea68e491cb42f1b5d43ffba89f6a7f0dadc4 URL: https://github.com/llvm/llvm-project/commit/4c48ea68e491cb42f1b5d43ffba89f6a7f0dadc4 DIFF: https://github.com/llvm/llvm-project/commit/4c48ea68e491cb42f1b5d43ffba89f6a7f0dadc4.diff

[PATCH] D72560: Add -Wrange-loop-analysis changes to ReleaseNotes

Mordante created this revision. Mordante added reviewers: aaron.ballman, xbolva00. Mordante added a project: clang. This reflects the recent changes done. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72560 Files: clang/docs/ReleaseNotes.rst Index:

[PATCH] D72505: [ASTMatchers] extract public matchers from const-analysis into own patch

JonasToth updated this revision to Diff 237514. JonasToth added a comment. - remove merge conflict markers in docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72505/new/ https://reviews.llvm.org/D72505 Files:

[PATCH] D72505: [ASTMatchers] extract public matchers from const-analysis into own patch

JonasToth updated this revision to Diff 237511. JonasToth added a comment. - fix compilation error, missing getType Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72505/new/ https://reviews.llvm.org/D72505 Files:

[PATCH] D72362: [clang-tidy] misc-no-recursion: a new check

lebedev.ri marked 8 inline comments as done. lebedev.ri added a comment. Thanks for taking a look. Some deflective replies inline. Comment at: clang-tools-extra/clang-tidy/misc/NoRecursionCheck.cpp:21 + +inline bool operator==(const CallGraphNode::CallRecord , +

[PATCH] D72505: [ASTMatchers] extract public matchers from const-analysis into own patch

JonasToth updated this revision to Diff 237510. JonasToth marked 3 inline comments as done. JonasToth added a comment. - add test for K functions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72505/new/ https://reviews.llvm.org/D72505 Files:

[PATCH] D71823: Support Swift calling convention for WebAssembly targets

sbc100 added inline comments. Comment at: clang/lib/Basic/Targets/WebAssembly.h:122 +case CC_Swift: + return CCCR_OK; +default: This seems to disagree with the longer list in `callingConvSupported`.Is this going to generate unnecessary

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth added a comment. > Thank you for looking into this; I'll start building diff14 to test locally. Thanks :) > I'm good with merging this checker as-is, as long as it is not enabled by > default. Which part shall be disabled in your opinion? The whole check? that would not work xD But

[PATCH] D72362: [clang-tidy] misc-no-recursion: a new check

JonasToth added a comment. So that is were the CTU question comes from? :) Comment at: clang-tools-extra/clang-tidy/misc/NoRecursionCheck.cpp:21 + +inline bool operator==(const CallGraphNode::CallRecord , + const CallGraphNode::CallRecord ) {

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

0x8000- added a comment. In D54943#1815568 , @JonasToth wrote: > @0x8000- i did remove `dependentTypes` from matching. Locally that works > with your reported test-case (i was running clang-tidy wrong :(). > > I do understand the `auto &` issues

[PATCH] D72239: [clang-tidy] new opencl recursion not supported check

JonasToth added a comment. The other recursion check seems more sophisticated. What is your take on it? Would you consider it better as well, what is your opinion on it? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72239/new/

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

njames93 updated this revision to Diff 237505. njames93 added a comment. - Fix perf alias documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/ https://reviews.llvm.org/D72553 Files:

[PATCH] D72052: [UserManual] Update the C++ standard support

Mordante marked 2 inline comments as done. Mordante added inline comments. Comment at: clang/docs/UsersManual.rst:2557 clang fully implements all of standard C++98 except for exported +templates (which were removed in C++11), and all of standards C++11, C++14,

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

Mordante added a comment. In D72553#1815558 , @njames93 wrote: > - 99% sure I have all incriments renamed now I checked and can't find them anymore, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] fce887b - GlobalModuleIndex - Fix use-after-move clang static analyzer warning.

Author: Simon Pilgrim Date: 2020-01-11T16:43:02Z New Revision: fce887beb79780d0e0b19e8ab6176978a3dce9b8 URL: https://github.com/llvm/llvm-project/commit/fce887beb79780d0e0b19e8ab6176978a3dce9b8 DIFF: https://github.com/llvm/llvm-project/commit/fce887beb79780d0e0b19e8ab6176978a3dce9b8.diff

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth added a comment. @0x8000- i did remove `dependentTypes` from matching. Locally that works with your reported test-case (i was running clang-tidy wrong :(). I do understand the `auto &` issues now (i think). If the type is deduced to a template-type or something that depends the

[PATCH] D72052: [UserManual] Update the C++ standard support

xbolva00 added a comment. +1 Comment at: clang/docs/UsersManual.rst:2557 clang fully implements all of standard C++98 except for exported +templates (which were removed in C++11), and all of standards C++11, C++14, Clang ? :) Repository: rG LLVM Github

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth updated this revision to Diff 237503. JonasToth added a comment. - fix false positive with ignoring dependentTypes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://reviews.llvm.org/D54943 Files:

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/performance-prefer-pre-increment.rst:8 + +The cert-oop54-cpp check is an alias, please see +`llvm-prefer-pre-increment `_ Please fix check name. Repository: rG LLVM

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

njames93 updated this revision to Diff 237502. njames93 added a comment. - 99% sure I have all incriments renamed now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/ https://reviews.llvm.org/D72553 Files:

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/llvm/PreferPreincrementCheck.cpp:38 + // returned. Reordering those would change the behaviour of the expression. + // FIXME: Add any more parents which could use the result of the operation. + auto

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth updated this revision to Diff 237501. JonasToth added a comment. - remove pointee-analysis artifacts as this will be done later - remove unnecessary comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/

[clang] ded237b - Fix "pointer is null" static analyzer warning. NFCI.

Author: Simon Pilgrim Date: 2020-01-11T16:02:22Z New Revision: ded237b58d56299f90ef44853ef79b039248b85e URL: https://github.com/llvm/llvm-project/commit/ded237b58d56299f90ef44853ef79b039248b85e DIFF: https://github.com/llvm/llvm-project/commit/ded237b58d56299f90ef44853ef79b039248b85e.diff

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

njames93 updated this revision to Diff 237500. njames93 added a comment. - Renamed incriment in test cases to increment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/ https://reviews.llvm.org/D72553 Files:

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

njames93 updated this revision to Diff 237499. njames93 marked 2 inline comments as done. njames93 added a comment. - Added alias for performance module - renamed check to prefer-pre-increment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

Mordante added a comment. I only have some naming nits - incriment -> increment - decriment -> decrement Maybe rename the check llvm-prefer-preincrement -> llvm-prefer-pre-increment and rename the files and classes PreferPreincrementCheck -> PreferPreIncrementCheck Comment

[PATCH] D72052: [UserManual] Update the C++ standard support

Mordante added a comment. Friendly ping, it would be nice to get this in the next release. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72052/new/ https://reviews.llvm.org/D72052 ___ cfe-commits

[PATCH] D72378: [clang-tidy] Add `bugprone-reserved-identifier`

Mordante added a comment. Adding `Depends on D72284` would add the patches to the stack. I like the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72378/new/ https://reviews.llvm.org/D72378 ___

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

Eugene.Zelenko added a comment. In D72553#1815497 , @njames93 wrote: > could this do with an alias into performance? Sure. At least such tricky questions were asked on interviews decade ago :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

0x8000- added a comment. In D54943#1815473 , @JonasToth wrote: > In D54943#1815358 , @0x8000- > wrote: > > > Here is a minimal example that shows the problem: > > > I can not reproduce that case :( > It

[PATCH] D72212: [Sema] Improve -Wrange-loop-analysis warnings

This revision was automatically updated to reflect the committed changes. Mordante marked 3 inline comments as done. Closed by commit rG9c74fb402e1b: [Sema] Improve -Wrange-loop-analysis warnings. (authored by Mordante). Changed prior to commit:

[PATCH] D72212: [Sema] Improve -Wrange-loop-analysis warnings

Mordante marked 8 inline comments as done. Mordante added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:2812-2813 - // TODO: Determine a maximum size that a POD type can be before a diagnostic - // should be emitted. Also, only ignore POD types with trivial copy

[clang] 9c74fb4 - [Sema] Improve -Wrange-loop-analysis warnings.

Author: Mark de Wever Date: 2020-01-11T15:34:02+01:00 New Revision: 9c74fb402e1b7aad4a509a49ab4792154b8ba2c8 URL: https://github.com/llvm/llvm-project/commit/9c74fb402e1b7aad4a509a49ab4792154b8ba2c8 DIFF: https://github.com/llvm/llvm-project/commit/9c74fb402e1b7aad4a509a49ab4792154b8ba2c8.diff

[PATCH] D71512: [clang-format] Fix short block when braking after control statement

Bouska added a comment. Ping @MyDeveloperDay @klimek CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71512/new/ https://reviews.llvm.org/D71512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D72498: [clangd] Print underlying type for decltypes in hover

lh123 added a comment. In D72498#1813902 , @ilya-biryukov wrote: > Could it be the case that we want to show the canonical types (i.e. without > all syntax sugar)? > Maybe we want both the normal type and the canonical type? +1,I think it would be

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

njames93 updated this revision to Diff 237492. njames93 marked an inline comment as done. njames93 added a comment. Figured out what memset you meant... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72488/new/ https://reviews.llvm.org/D72488

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

njames93 marked an inline comment as done. njames93 added a comment. could this do with an alias into performance? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/ https://reviews.llvm.org/D72553

[PATCH] D72227: [Driver][X86] Add -malign-branch* and -malign-branch-within-32B-boundaries

skan updated this revision to Diff 237491. skan retitled this revision from "Add options for clang to align branches within 32B boundary" to "[Driver][X86] Add -malign-branch* and -malign-branch-within-32B-boundaries". skan edited the summary of this revision. CHANGES SINCE LAST ACTION

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

njames93 updated this revision to Diff 237490. njames93 added a comment. - Small refactor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/ https://reviews.llvm.org/D72553 Files: clang-tools-extra/clang-tidy/llvm/CMakeLists.txt

[PATCH] D72401: Fixes for spaces around C# object initializers

krasimir added inline comments. Comment at: clang/unittests/Format/FormatTestCSharp.cpp:379 + FormatStyle Style = getGoogleStyle(FormatStyle::LK_CSharp); + Style.SpaceBeforeParens = FormatStyle::SBPO_Always; + Is this needed for the formatting below? I find it

[PATCH] D72401: Fixes for spaces around C# object initializers

krasimir requested changes to this revision. krasimir added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Format/TokenAnnotator.cpp:2869 +// space before '{' in "new MyType {" +if (Left.is(TT_Unknown) && Right.is(tok::l_brace) &&

[PATCH] D72144: Treat C# `using` as a control statement

krasimir requested changes to this revision. krasimir added inline comments. This revision now requires changes to proceed. Comment at: clang/unittests/Format/FormatTestCSharp.cpp:257 + "}", + Style); + Please also add a test for

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth added a comment. In D54943#1815358 , @0x8000- wrote: > Here is a minimal example that shows the problem: > > #include > > template > struct DoGooder > { > DoGooder(void* accessor, SomeValue value) > { > } > >

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille updated this revision to Diff 237486. serge-sans-paille added a comment. - update warn_fe_stack_clash_protection_inline_asm location. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68720

[PATCH] D72304: Summary: Add OpenMP Directives (master and critical) to OMPBuilder, and use them in clang.

jdoerfert added a comment. I added quite a bunch of inline comments again :( and some high level stuff below. --- Commits need a message that explains the change. Also the "Summary" should not be in the commit title. --- This adds support for clang to build the directives via the