[clang] c985e7b - Revert "[Concepts] Profile TypeConstraints in ProfileTemplateParameterList"

Author: Saar Raz Date: 2020-01-23T09:57:20+02:00 New Revision: c985e7b07db2660b14508d3da45d55f3d4490019 URL: https://github.com/llvm/llvm-project/commit/c985e7b07db2660b14508d3da45d55f3d4490019 DIFF: https://github.com/llvm/llvm-project/commit/c985e7b07db2660b14508d3da45d55f3d4490019.diff

[clang] 0e3ae35 - [Concepts] Profile TypeConstraints in ProfileTemplateParameterList

Author: Saar Raz Date: 2020-01-23T09:47:55+02:00 New Revision: 0e3ae353a47273825cd2f20f4777dcb5731cf8ec URL: https://github.com/llvm/llvm-project/commit/0e3ae353a47273825cd2f20f4777dcb5731cf8ec DIFF: https://github.com/llvm/llvm-project/commit/0e3ae353a47273825cd2f20f4777dcb5731cf8ec.diff

[PATCH] D72730: [clang-tidy] run-clang-tidy -export-fixes exports only fixes, not all warnings

kimgr added a comment. A small Python suggestion. Comment at: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py:112 + + if "Notes" in diag: +for note in diag["Notes"]: This double lookup is unnecessary, you can do `for note in diag.get("Notes", []):`

[PATCH] D68520: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON

mgorny added inline comments. Comment at: clang/tools/clang-shlib/CMakeLists.txt:28 +foreach(lib ${interface}) + string(REGEX MATCH "^clang" is_clang_lib ${lib}) + if (NOT is_clang_lib) Any reason not to use `if(${lib} MATCHES ...)`?

[PATCH] D61366: [libcxx] [test] Don't assert that moved-from containers with non-POCMA allocators are empty.

BillyONeal closed this revision. BillyONeal added a comment. https://github.com/llvm/llvm-project/commit/45f630d729e2cce044ed48e6eaf4b8e61e06fede Committed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61366/new/ https://reviews.llvm.org/D61366

[PATCH] D72959: Relative VTables ABI on Fuchsia

rjmccall added a comment. There's two independently-useful things here for the relocation, right? First, it's useful to be able to express a relocation to a symbol that has the semantics of a particular function but doesn't necessarily have its address, and that concept could be used across

[PATCH] D73186: [AST] Add fixed-point multiplication constant evaluation.

rjmccall added inline comments. Comment at: clang/lib/Basic/FixedPoint.cpp:242 + } else +Overflowed = Result < Min || Result > Max; + If the maximum expressible value is *k*, and the fully-precise multiplication yields *k+e* for some epsilon *e* that isn't

[PATCH] D68520: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62114 tests passed, 0 failed and 808 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73185: [AST] Add fixed-point subtraction constant evaluation.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM other than the request to split the commit. Comment at: clang/include/clang/Basic/FixedPoint.h:82 + unsigned IsSaturated: 1; + unsigned HasUnsignedPadding :

[PATCH] D68520: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON

tstellar updated this revision to Diff 239764. tstellar added a comment. Rewrite patch to use cmake features available with cmake >= 3.4. The previous version used a 3.6 feature: list(FILTER ...) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73245: Don't define std::max_align_t if not used in C++03 mode

joerg added a comment. libc++ generally tries to play nice with C++03 code. It doesn't go out of its way to break it and keeping it usable helps dealing with a lot of rusty old code. That's what the patch is all about, not breaking things for no good reason. CHANGES SINCE LAST ACTION

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

rsmith added a comment. In D67678#1834957 , @rsmith wrote: > I'll split out the new flag at least and re-land for Clang 10, while we > figure out how to set the default. Looks like there's nothing to re-land here: only the change of default was

[PATCH] D73245: Don't define std::max_align_t if not used in C++03 mode

EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. the library has never had a C++03 mode, and I am against adding one now. I want libc++ to move away from C++03, not towards it CHANGES SINCE LAST ACTION

[PATCH] D73208: [objc_direct] fix codegen for mismatched Decl/Impl return types

MadCoder added a comment. In D73208#1835051 , @dexonsmith wrote: > Why isn't a similar dance needed for non-direct methods? because non direct methods do not need an `llvm::Function` to be synthesized at the call-site. direct methods do, and they form

[PATCH] D73236: [clang-tidy] Add clang-tidy headers to clang distribution

smeenai added a comment. This LGTM, but I'll give the clang-tidy developers some time to weigh in. Comment at: clang-tools-extra/clang-tidy/CMakeLists.txt:106 +) + add_custom_target(clang-tidy-headers DEPENDS clang-headers) + set_target_properties(clang-tidy-headers

[PATCH] D73236: [clang-tidy] Add clang-tidy headers to clang distribution

DmitryPolukhin updated this revision to Diff 239746. DmitryPolukhin added a comment. - added clang-tidy-header component Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73236/new/ https://reviews.llvm.org/D73236 Files:

[PATCH] D73188: [AST] Improve overflow diagnostics for fixed-point constant evaluation.

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. Could you also add a few test lines showing this warning doesn't appear for operations where the result is a saturated type? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D73245: Don't define std::max_align_t if not used in C++03 mode

joerg created this revision. joerg added a reviewer: mclow.lists. Herald added a subscriber: christof. max_align_t has been introduced by C++11 and C99. When an older language mode is explicitly requested, the system headers might not provide. Don't define it in this case unless other headers

[PATCH] D73236: [clang-tidy] Add clang-tidy headers to clang distribution

DmitryPolukhin updated this revision to Diff 239741. DmitryPolukhin added a comment. Herald added a subscriber: mgehre. - moved header installation to clang-tidy cmake file Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73236/new/

[PATCH] D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62115 tests passed, 0 failed and 808 were skipped. {icon times-circle color=red} clang-tidy: fail. clang-tidy found 1 errors and 0 warnings

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

tejohnson marked an inline comment as done. tejohnson added inline comments. Comment at: llvm/test/Transforms/WholeProgramDevirt/uniform-retval.ll:28 %result = call i32 %fptr_casted(i8* %obj) - ; CHECK-NOT: call + ; CHECK-NOT: call i32 % ; CHECK: ret i32 123

[PATCH] D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

njames93 updated this revision to Diff 239734. njames93 added a comment. - Address nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73098/new/ https://reviews.llvm.org/D73098 Files:

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

tejohnson created this revision. tejohnson added reviewers: pcc, evgeny777. Herald added subscribers: arphaman, dexonsmith, steven_wu, hiraditya, Prazek, mehdi_amini. Herald added projects: clang, LLVM. Currently type test assume sequences inserted for devirtualization are removed during WPD.

[clang] 4751e4f - Revert "[cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON"

Author: Tom Stellard Date: 2020-01-22T16:12:45-08:00 New Revision: 4751e4f8c24bc07fdb668dc49ee559b97c1e3c22 URL: https://github.com/llvm/llvm-project/commit/4751e4f8c24bc07fdb668dc49ee559b97c1e3c22 DIFF: https://github.com/llvm/llvm-project/commit/4751e4f8c24bc07fdb668dc49ee559b97c1e3c22.diff

[PATCH] D71980: [clang-tidy] Disable Checks on If constexpr statements in template Instantiations for BugproneBranchClone and ReadabilityBracesAroundStatements

hans added a comment. Cherry-picked to 10.x in 1f98c2b586e4ebce68d75856699059663a052cb7 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71980/new/ https://reviews.llvm.org/D71980

[PATCH] D68520: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON

This revision was automatically updated to reflect the committed changes. Closed by commit rGdf839cfda09d: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON (authored by tstellar). Changed prior to commit: https://reviews.llvm.org/D68520?vs=223325=239726#toc

[clang] df839cf - [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON

Author: Tom Stellard Date: 2020-01-22T16:00:56-08:00 New Revision: df839cfda09dbadc26b8be635f27da75f1f27190 URL: https://github.com/llvm/llvm-project/commit/df839cfda09dbadc26b8be635f27da75f1f27190 DIFF: https://github.com/llvm/llvm-project/commit/df839cfda09dbadc26b8be635f27da75f1f27190.diff

[PATCH] D73236: [clang-tidy] Add clang-tidy headers to clang distribution

smeenai added a comment. Can you upload the patch with context (`git diff -U` if you're using the web interface or via arcanist)? You'll want to add install targets for this, by adding a `COMPONENT` to the `install` command and referencing that in the target. See

[PATCH] D73208: [objc_direct] fix codegen for mismatched Decl/Impl return types

dexonsmith added a comment. Why isn't a similar dance needed for non-direct methods? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73208/new/ https://reviews.llvm.org/D73208 ___ cfe-commits mailing

[PATCH] D73099: [Alignment][NFC] Deprecate Align::None()

xbolva00 added a comment. +1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73099/new/ https://reviews.llvm.org/D73099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

kkwli0 updated this revision to Diff 239719. kkwli0 marked 2 inline comments as done. kkwli0 added a comment. Herald added a subscriber: jfb. Address review comments and rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72901/new/ https://reviews.llvm.org/D72901 Files:

[PATCH] D71823: Support Swift calling convention for WebAssembly targets

kateinoigakukun added a comment. In D71823#1834488 , @dschuff wrote: > Sorry we left this dangling for so long. This little change looks fine; I > guess you must be in the process of porting swift to wasm? Do you have any > more detailed plans for that

[PATCH] D73236: [clang-tidy] Add clang-tidy headers to clang distribution

DmitryPolukhin created this revision. DmitryPolukhin added a reviewer: smeenai. DmitryPolukhin added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. Herald added a reviewer: jdoerfert. Herald added a project: clang. Clang releases include static libraries for clang-tidy

[PATCH] D73237: [CUDA] Fix order of memcpy arguments in __shfl_*(<64-bit type>).

tra created this revision. tra added a reviewer: jlebar. Herald added subscribers: sanjoy.google, bixia. Herald added a project: clang. Wrong argument order resulted in broken shfl ops for 64-bit types. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73237 Files:

[PATCH] D72242: Fix crash on value dependent bitfields in if conditions in templates

eandrews added a comment. In D72242#1820908 , @rnk wrote: > I think I liked the first version of this patch better. I would say, if the > AST after instantiation remains the same as it was before D69950 > , then the

[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

kkwli0 marked 13 inline comments as done. kkwli0 added inline comments. Comment at: clang/docs/OpenMPSupport.rst:216

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

rsmith added a comment. In D67678#1834542 , @steven_wu wrote: > @rsmith This also breaks macOS SDK. Can we revert this as we discuss a less > aggressive option? (This was already reverted a couple of days ago.) Do you have a timeline for how long it

[clang] b32013b - [www] Update cxx_status page to list changes on the Clang 10 branch as

Author: Richard Smith Date: 2020-01-22T14:48:56-08:00 New Revision: b32013baec1d9d6adcebdd9b523d308e8a1af856 URL: https://github.com/llvm/llvm-project/commit/b32013baec1d9d6adcebdd9b523d308e8a1af856 DIFF: https://github.com/llvm/llvm-project/commit/b32013baec1d9d6adcebdd9b523d308e8a1af856.diff

[PATCH] D73231: [CUDA] Assume the latest known CUDA version if we've found an unknown one.

tra created this revision. tra added reviewers: timshen, yaxunl. Herald added subscribers: sanjoy.google, bixia. Herald added a project: clang. This makes clang somewhat forward-compatible with new CUDA releases without having to patch it for every minor release without adding any new function.

[PATCH] D73229: [analyzer] Improve FuchsiaHandleChecker's diagnostic messages

xazax.hun created this revision. xazax.hun added reviewers: NoQ, haowei. xazax.hun added a project: clang. Herald added subscribers: Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. I found that this information is useful when

[clang] 16b9410 - [X86] Cast to __v4hi instead of __m64 in the implementation of _mm_extract_pi16 and _mm_insert_pi16.

Author: Craig Topper Date: 2020-01-22T16:00:23-06:00 New Revision: 16b9410caa35da976fa5f3cf6dd3d6f3776d51ca URL: https://github.com/llvm/llvm-project/commit/16b9410caa35da976fa5f3cf6dd3d6f3776d51ca DIFF: https://github.com/llvm/llvm-project/commit/16b9410caa35da976fa5f3cf6dd3d6f3776d51ca.diff

[PATCH] D73120: [Clang] Alternate fix for "expansion of response files in -Wp after integrated-cc1 change"

This revision was automatically updated to reflect the committed changes. aganea marked an inline comment as done. Closed by commit rG68d7f06092e5: Clang] Fix expansion of response files in -Wp after integrated-cc1 change (authored by aganea). Changed prior to commit:

[PATCH] D73120: [Clang] Alternate fix for "expansion of response files in -Wp after integrated-cc1 change"

aganea marked 3 inline comments as done. aganea added inline comments. Comment at: clang/test/Driver/Wp-args.c:27 + +// RSP: inception hans wrote: > aganea wrote: > > hans wrote: > > > Why inception? I feel like I'm missing something :) > > Could be anything

[clang] 68d7f06 - Clang] Fix expansion of response files in -Wp after integrated-cc1 change

Author: Alexandre Ganea Date: 2020-01-22T16:53:44-05:00 New Revision: 68d7f06092e56b17eb0cddf560a9d9fe8afb7dd8 URL: https://github.com/llvm/llvm-project/commit/68d7f06092e56b17eb0cddf560a9d9fe8afb7dd8 DIFF:

[clang] 90f58ea - [ODRHash] Factor out functionality for CXXRecord ODR diagnostics (NFCI)

Author: Bruno Cardoso Lopes Date: 2020-01-22T13:33:17-08:00 New Revision: 90f58eaeff5f1d5017e7b689fac79180cdfa0160 URL: https://github.com/llvm/llvm-project/commit/90f58eaeff5f1d5017e7b689fac79180cdfa0160 DIFF:

[PATCH] D73224: [hip] Remove `-Werror=format-nonliteral`

hliao added a comment. Have to remove this as it causes compilation failures on irrelevant host code during device compilation. Maybe we need to introduce a new warning option to issue that warning on device code only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73224: [hip] Remove `-Werror=format-nonliteral`

hliao created this revision. hliao added reviewers: sameerds, yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. - It won't distinguish host and device code and trigger compilation failure on irrelevant code. Repository: rG LLVM Github Monorepo

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked 2 inline comments as done. mibintc added a comment. A couple inline replies to @sepavloff ; I'll be uploading another revision. Comment at: clang/lib/Parse/ParsePragma.cpp:2537 +if (!Actions.CurContext->isTranslationUnit()) { +//FIXME this seems to be the

[PATCH] D73219: [objc_direct] do not add direct properties to the serialization array

dexonsmith added inline comments. Comment at: clang/lib/CodeGen/CGObjCMac.cpp:3316-3319 else if (const ObjCCategoryDecl *CD = dyn_cast(OCD)) { for (const auto *P : CD->protocols()) PushProtocolProperties(PropertySet, Properties, P, IsClassProperty); }

[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

dreachem added inline comments. Comment at: clang/docs/OpenMPSupport.rst:210 +--+--+--+---+ -|

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

dmajor added a comment. I noticed that this was merged to the 10.0 release branch. Should the merge be reverted while the dust settles on the trunk implementation? FWIW this change breaks code in skia, as used in both Firefox and Chromium. I see that crbug.com/1042470 added the flag as a

[PATCH] D72373: [clang-tidy] extend misc-misplaced-const to detect using besides typedef

aaron.ballman added a comment. In D72373#1834591 , @AlexanderLanin wrote: > Updated misc-misplaced-const.c to reflect new output and fixed one wrong col > in misc-misplaced-const.cpp - I really do not understand how that happened. > Rebased and

[clang-tools-extra] 84c5f19 - Extend misc-misplaced-const to detect using declarations as well as typedef

Author: Alexander Lanin Date: 2020-01-22T15:26:11-05:00 New Revision: 84c5f196370065388779cd96d033c84d31031543 URL: https://github.com/llvm/llvm-project/commit/84c5f196370065388779cd96d033c84d31031543 DIFF:

[clang] 8edf037 - Add a bit of documentation on attribute spellings that were missing.

Author: Aaron Ballman Date: 2020-01-22T15:22:40-05:00 New Revision: 8edf037aebdf473c225dffe23d5f96c6de429294 URL: https://github.com/llvm/llvm-project/commit/8edf037aebdf473c225dffe23d5f96c6de429294 DIFF: https://github.com/llvm/llvm-project/commit/8edf037aebdf473c225dffe23d5f96c6de429294.diff

[PATCH] D73219: [objc_direct] do not add direct properties to the serialization array

MadCoder created this revision. MadCoder added reviewers: ahatanak, arphaman, dexonsmith, erik.pilkington. MadCoder added a project: clang. Herald added a subscriber: cfe-commits. If we do, then the property_list_t length is wrong and class_getProperty gets very sad. Radar-Id:

[PATCH] D72144: Treat C# `using` as a control statement

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. In D72144#1834265 , @jbcoe wrote: > Removed test snippets that did not exercise new code. Actually i would prefer we didn't

[PATCH] D72373: [clang-tidy] extend misc-misplaced-const to detect using besides typedef

AlexanderLanin updated this revision to Diff 239665. AlexanderLanin added a comment. Updated misc-misplaced-const.c to reflect new output and fixed one wrong col in misc-misplaced-const.cpp - I really do not understand how that happened. Rebased and verified with check-clang-tools. CHANGES

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

MyDeveloperDay added inline comments. Comment at: clang/docs/ReleaseNotes.rst:164 + +- Clang-format now supports JavaScript null operators. + is this line part of this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73120: [Clang] Alternate fix for "expansion of response files in -Wp after integrated-cc1 change"

hans added inline comments. Comment at: clang/test/Driver/Wp-args.c:27 + +// RSP: inception aganea wrote: > hans wrote: > > Why inception? I feel like I'm missing something :) > Could be anything else :) Because `-rewrite-macros` prints this .c with > comments,

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

arphaman added a comment. This also breaks the macOS SDK. @rsmith could you please disable this change for Darwin when you're recommitting this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67678/new/ https://reviews.llvm.org/D67678

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

steven_wu added a comment. @rsmith This also breaks macOS SDK. Can we revert this as we discuss a less aggressive option? Here is an example in macOS SDK (from /usr/include/simd/logic.h): static inline SIMD_CFUNC simd_bool simd_any(simd_int2 x) { return

[PATCH] D73120: [Clang] Alternate fix for "expansion of response files in -Wp after integrated-cc1 change"

aganea marked 2 inline comments as done. aganea added inline comments. Comment at: clang/test/Driver/Wp-args.c:27 + +// RSP: inception hans wrote: > Why inception? I feel like I'm missing something :) Could be anything else :) Because `-rewrite-macros` prints

[PATCH] D71566: New checks for fortified sprintf

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62112 tests passed, 0 failed and 808 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73120: [Clang] Alternate fix for "expansion of response files in -Wp after integrated-cc1 change"

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Looks reasonable to me. Comment at: clang/test/Driver/Wp-args.c:27 + +// RSP: inception Why inception? I feel like I'm missing something :) CHANGES SINCE LAST

[PATCH] D72747: [objc_direct] Allow for direct messages be sent to `self` when it is a Class

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72747/new/ https://reviews.llvm.org/D72747 ___ cfe-commits mailing list

[PATCH] D73218: [clangd] Show background index status using LSP 3.15 work-done progress notifications

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon times-circle color=red} clang-tidy: fail. clang-tidy found 1 errors and 11 warnings . {icon times-circle

[PATCH] D71823: Support Swift calling convention for WebAssembly targets

dschuff accepted this revision. dschuff added a comment. This revision is now accepted and ready to land. Sorry we left this dangling for so long. This little change looks fine; I guess you must be in the process of porting swift to wasm? Do you have any more detailed plans for that written

[PATCH] D72703: Add a warning, flags and pragmas to limit the number of pre-processor tokens in a translation unit

rnk added a comment. I like the `max_tokens_here` / `max_tokens_total` variants. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72703/new/ https://reviews.llvm.org/D72703 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D73218: [clangd] Show background index status using LSP 3.15 work-done progress notifications

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon times-circle color=red} clang-tidy: fail. clang-tidy found 1 errors and 11 warnings . {icon check-circle

[PATCH] D73218: [clangd] Show background index status using LSP 3.15 work-done progress notifications

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon times-circle color=red} clang-tidy: fail. clang-tidy found 1 errors and 11 warnings . {icon check-circle

[PATCH] D73218: [clangd] Show background index status using LSP 3.15 work-done progress notifications

sammccall updated this revision to Diff 239653. sammccall added a comment. revert accidental change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73218/new/ https://reviews.llvm.org/D73218 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D71566: New checks for fortified sprintf

serge-sans-paille updated this revision to Diff 239654. serge-sans-paille added a comment. Remove useless assert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71566/new/ https://reviews.llvm.org/D71566 Files:

[PATCH] D71566: New checks for fortified sprintf

serge-sans-paille added a comment. In D71566#1832394 , @aaron.ballman wrote: > (There are still some minor whitespace nits to resolve as well.) Strange, everything is passed through clang-format-diff :-/ Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D73218: [clangd] Show background index status using LSP 3.15 work-done progress notifications

sammccall updated this revision to Diff 239652. sammccall added a comment. Revert changes to VSCode client. This experimental version of the VSCode libs is fairly new and some corp mirrors we care about are behind ;-) also clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D73218: [clangd] Show background index status using LSP 3.15 work-done progress notifications

sammccall created this revision. sammccall added reviewers: kadircet, usaxena95. Herald added subscribers: llvm-commits, cfe-commits, jfb, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added projects: clang, LLVM. sammccall updated this revision to Diff 239652. sammccall added a comment.

[clang] c2a250e - [Concepts] Fix bug when referencing function parameters in instantiated function template requires clause

Author: Saar Raz Date: 2020-01-22T20:43:38+02:00 New Revision: c2a250e1c43c05925fe040dc9624403af7879453 URL: https://github.com/llvm/llvm-project/commit/c2a250e1c43c05925fe040dc9624403af7879453 DIFF: https://github.com/llvm/llvm-project/commit/c2a250e1c43c05925fe040dc9624403af7879453.diff

[PATCH] D73162: [test] Avoid loop-unroll.c test getting confused by fadd in git revision

asbirlea added a comment. SGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73162/new/ https://reviews.llvm.org/D73162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D73203: [clang-tidy] Prevent a remove only fixit causing a conflict when enclosed by another fixit

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62056 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72810: [LifetimeAnalysis] Add support for lifetime annotations on functions

xazax.hun marked 6 inline comments as done. xazax.hun added inline comments. Comment at: clang/include/clang/AST/LifetimeAttr.h:143 +using LifetimeContractSet = std::set; +using LifetimeContractMap = std::map; + gribozavr2 wrote: > These names are not

[PATCH] D73162: [test] Avoid loop-unroll.c test getting confused by fadd in git revision

fhahn added a comment. I think we could also just add a single match for something after the generated functions, to limit the scope of CHECK-NOT, e.g add something like `CHECK : !0 =` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73162/new/

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

tejohnson updated this revision to Diff 239646. tejohnson added a comment. Address remaining comment by blocking type test insertion for public std visibility Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71913/new/

[PATCH] D73162: [test] Avoid loop-unroll.c test getting confused by fadd in git revision

asbirlea accepted this revision. asbirlea added a comment. This revision is now accepted and ready to land. Oh, wow! Might I ask you add the same for fmul? We may get a revision like that next time :). Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72996: [Sema] Attempt to perform call-size-specific `__attribute__((alloc_align(param_idx)))` validation

lebedev.ri updated this revision to Diff 239642. lebedev.ri marked 4 inline comments as done. lebedev.ri added a comment. `isValueDependent()` already implies `isTypeDependent()`, don't recheck it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72810: [LifetimeAnalysis] Add support for lifetime annotations on functions

xazax.hun updated this revision to Diff 239644. xazax.hun marked 10 inline comments as done. xazax.hun added a comment. - Address most of the review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72810/new/ https://reviews.llvm.org/D72810 Files:

[PATCH] D72996: [Sema] Attempt to perform call-size-specific `__attribute__((alloc_align(param_idx)))` validation

lebedev.ri added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4479 +const Expr *Arg = Args[AA->getParamIndex().getASTIndex()]; +if (!Arg->isTypeDependent() && !Arg->isValueDependent()) { + llvm::APSInt I(64); lebedev.ri wrote: >

[clang] 635cbef - [CMake][Fuchsia] Disable in-process cc1

Author: Petr Hosek Date: 2020-01-22T10:11:54-08:00 New Revision: 635cbef5056e069679a25b75faf25ed27adf6a48 URL: https://github.com/llvm/llvm-project/commit/635cbef5056e069679a25b75faf25ed27adf6a48 DIFF: https://github.com/llvm/llvm-project/commit/635cbef5056e069679a25b75faf25ed27adf6a48.diff

[PATCH] D72829: Implement -fsemantic-interposition

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: llvm/include/llvm/IR/GlobalValue.h:287 + bool isDSOPreemptable() const { return !IsDSOLocal; } + MaskRay wrote: > It seems that this

[PATCH] D73203: [clang-tidy] Prevent a remove only fixit causing a conflict when enclosed by another fixit

njames93 updated this revision to Diff 239636. njames93 marked 3 inline comments as done. njames93 added a comment. - remove unnecessary auto Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73203/new/ https://reviews.llvm.org/D73203 Files:

[PATCH] D73203: [clang-tidy] Prevent a remove only fixit causing a conflict when enclosed by another fixit

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:726 + unsigned ErrorIndex = ErrorAndDiscarded.first; + const auto = ErrorAndDiscarded.second; + if (!Apply[ErrorIndex]) Eugene.Zelenko wrote:

[PATCH] D72144: Treat C# `using` as a control statement

jbcoe updated this revision to Diff 239629. jbcoe added a comment. Removed test snippets that did not exercise new code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72144/new/ https://reviews.llvm.org/D72144 Files: clang/lib/Format/TokenAnnotator.cpp

[clang] dfe9f13 - Revert "Unconditionally enable lvalue function designators; NFC"

Author: Aaron Ballman Date: 2020-01-22T12:40:39-05:00 New Revision: dfe9f130e07c929d21f8122272077495de531a38 URL: https://github.com/llvm/llvm-project/commit/dfe9f130e07c929d21f8122272077495de531a38 DIFF: https://github.com/llvm/llvm-project/commit/dfe9f130e07c929d21f8122272077495de531a38.diff

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

hans added a comment. In D72982#1832462 , @aganea wrote: > In D72982#1832233 , @aganea wrote: > > > In D72982#1832209 , @phosek wrote: > > > > > We're seeing

[PATCH] D73203: [clang-tidy] Prevent a remove only fixit causing a conflict when enclosed by another fixit

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:726 + unsigned ErrorIndex = ErrorAndDiscarded.first; + const auto = ErrorAndDiscarded.second; + if (!Apply[ErrorIndex]) Please don't

[PATCH] D72810: [LifetimeAnalysis] Add support for lifetime annotations on functions

gribozavr2 added a comment. I'd also appreciate if you updated the docs for the changes done in this patch. Comment at: clang/include/clang/AST/LifetimeAttr.h:22 + +/// This represents an abstract memory location that is used in the lifetime +/// contract representation.

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

tejohnson marked an inline comment as done. tejohnson added inline comments. Comment at: clang/test/CodeGenCXX/lto-visibility-inference.cpp:73 c1->f(); - // ITANIUM-NOT: type.test{{.*}}!"_ZTS2C2" + // ITANIUM: type.test{{.*}}!"_ZTS2C2" // MS: type.test{{.*}}!"?AUC2@@"

[PATCH] D72703: Add a warning, flags and pragmas to limit the number of pre-processor tokens in a translation unit

hans added a comment. In D72703#1832678 , @rnk wrote: > I waited to see if there was any other feedback, but I'm in favor of this. > > Should we try to come up with better pragma names? `clang max_tokens` doesn't > seem to call to mind what it does: warn

[PATCH] D72703: Add a warning, flags and pragmas to limit the number of pre-processor tokens in a translation unit

hans added a comment. In D72703#1833018 , @kimgr wrote: > I just want to say that finding the correlation between token count and > compile time is a bit of a breakthrough! I assume the same correlation could also be found with lines of code, but I

[PATCH] D73208: [objc_direct] fix codegen for mismatched Decl/Impl return types

MadCoder created this revision. MadCoder added reviewers: dexonsmith, ahatanak, erik.pilkington, arphaman. MadCoder added a project: clang. Herald added a subscriber: cfe-commits. For non direct methods, the codegen uses the type of the Implementation. Because Objective-C rules allow some

[PATCH] D72747: [objc_direct] Allow for direct messages be sent to `self` when it is a Class

MadCoder updated this revision to Diff 239615. MadCoder added a comment. with the test for real CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72747/new/ https://reviews.llvm.org/D72747 Files: clang/lib/Sema/SemaExprObjC.cpp clang/test/SemaObjC/method-direct-arc.m

[PATCH] D72903: [HIP] use GetProgramPath for executable discovery

hans added a comment. In D72903#1832070 , @yaxunl wrote: > Sorry for the delay. I have no objection to cherrypick this change to release > 10. Thanks. I've cherry-picked it as 3cce3790072249cbe51b96cea26bc78019c11fd0

  1   2   3   >