[clang] fe0d1b6 - [Clang] Warn about 'z' printf modifier in old MSVC.

Author: Simon Tatham Date: 2020-01-28T09:04:45Z New Revision: fe0d1b6a8ac5048b8007e5e7cc2aeb4e3291bda0 URL: https://github.com/llvm/llvm-project/commit/fe0d1b6a8ac5048b8007e5e7cc2aeb4e3291bda0 DIFF: https://github.com/llvm/llvm-project/commit/fe0d1b6a8ac5048b8007e5e7cc2aeb4e3291bda0.diff LOG:

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

kadircet added a comment. tests look good, but please upload the logs to the bug report for investigation. Comment at: clang-tools-extra/clangd/QueryDriverDatabase.cpp:137 +llvm::StringRef Arg = CommandLine[I]; +if (llvm::any_of(FlagsToPreserve, [&Arg](auto &&S) { retur

[PATCH] D73457: [Clang] Warn about 'z' printf modifier in old MSVC.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfe0d1b6a8ac5: [Clang] Warn about 'z' printf modifier in old MSVC. (authored by simon_tatham). Changed prior to commit: https://reviews.llvm.org/D73457?vs=240626&id=240796#toc Repository: rG LLVM Gith

[PATCH] D69585: PerformPendingInstatiations() already in the PCH

llunak marked 2 inline comments as done. llunak added inline comments. Comment at: clang/lib/Sema/Sema.cpp:985-986 + +// FIXME: Instantiating implicit templates already in the PCH breaks some +// OpenMP-specific code paths, see https://reviews.llvm.org/D69585 . +if(La

[PATCH] D73457: [Clang] Warn about 'z' printf modifier in old MSVC.

simon_tatham added a comment. In D73457#1842605 , @amccarth wrote: > clang will still (by default) use the MS runtime libraries for Windows > builds, in which case it's important for the compatibility version to match > the one for the libraries that are

[PATCH] D71965: include missing for std::abort

kadircet closed this revision. kadircet added a comment. Looks like this has landed with https://github.com/llvm/llvm-project/commit/58592f6c49249293f79698cfcb31dba532e12603 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71965/new/ https://reviews.

[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: clang/include/clang/AST/DependencyFlags.h:17-28 +enum class DependencyFlags : uint8_t { + Type = 1, + Value = 2, + Instantiation = 4, + UnexpandedPack = 8, + + // Shorthands for

[clang-tools-extra] af071f0 - [clangd] Improve ObjC property handling in SelectionTree.

Author: Sam McCall Date: 2020-01-28T11:07:19+01:00 New Revision: af071f03f379f7f1071e9da23ee4ca26d2c5c509 URL: https://github.com/llvm/llvm-project/commit/af071f03f379f7f1071e9da23ee4ca26d2c5c509 DIFF: https://github.com/llvm/llvm-project/commit/af071f03f379f7f1071e9da23ee4ca26d2c5c509.diff LO

[clang-tools-extra] f4871ea - [clangd] Support pseudo-obj expr, opaque values, and property references in findExplicitReferences()

Author: Sam McCall Date: 2020-01-28T11:13:33+01:00 New Revision: f4871ead55f59a7dfee56ea97c32b5df4209d9ce URL: https://github.com/llvm/llvm-project/commit/f4871ead55f59a7dfee56ea97c32b5df4209d9ce DIFF: https://github.com/llvm/llvm-project/commit/f4871ead55f59a7dfee56ea97c32b5df4209d9ce.diff LO

[PATCH] D72448: [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers

njames93 marked 2 inline comments as done. njames93 added a comment. Hmm a lot of the code in the redundant-string-init check is designed to be macro unsafe. Not sure the best way to follow up, discard the old macro behaviour or keep it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D72508: [clangd] Support pseudo-obj expr, opaque values, and property references in findExplicitReferences()

sammccall updated this revision to Diff 240809. sammccall marked 4 inline comments as done. sammccall added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72508/new/ https://reviews.llvm.org/D72508 Files: clang-tools-e

[PATCH] D72508: [clangd] Support pseudo-obj expr, opaque values, and property references in findExplicitReferences()

This revision was automatically updated to reflect the committed changes. Closed by commit rGf4871ead55f5: [clangd] Support pseudo-obj expr, opaque values, and property references in… (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D72634: [clangd] Improve ObjC property handling in SelectionTree.

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf071f03f379: [clangd] Improve ObjC property handling in SelectionTree. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72634/new/ ht

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille marked 3 inline comments as done. serge-sans-paille added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:488 + if (Context.getLangOpts().SemanticInterposition && + (Context.getLangOpts().PICLevel && !Context.getLangOpts().PIE)) +// Re

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille updated this revision to Diff 240813. serge-sans-paille added a comment. @MaskRay should we add a verifier step to check that pie/pic/semanticinterposition module flags are consistent, or leave that to clang ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] a31a61d - [clangd][Hover] Handle uninstantiated templates

Author: Kadir Cetinkaya Date: 2020-01-28T11:22:02+01:00 New Revision: a31a61dafeaa9110687110fc127ea6f7c91dd3e6 URL: https://github.com/llvm/llvm-project/commit/a31a61dafeaa9110687110fc127ea6f7c91dd3e6 DIFF: https://github.com/llvm/llvm-project/commit/a31a61dafeaa9110687110fc127ea6f7c91dd3e6.dif

[PATCH] D73344: [clangd][Hover] Handle uninstantiated templates

This revision was automatically updated to reflect the committed changes. Closed by commit rGa31a61dafeaa: [clangd][Hover] Handle uninstantiated templates (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73344/new/ https://revie

[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

njames93 added a comment. In D72527#1843475 , @Eugene.Zelenko wrote: > As I wrote, I don't have GitHub commit access, so I need help with commit. Needs rebasing on trunk, ReleaseNotes.rst is causing conflicts Repository: rG LLVM Github Monorepo CHA

[PATCH] D73536: [analyser][taint] Remove taint from symbolic expressions if used in comparisons

steakhal created this revision. steakhal added reviewers: NoQ, Szelethus. steakhal added a project: clang. Herald added subscribers: cfe-commits, JDevlieghere. steakhal added a subscriber: boga95. **Remove taint from symbolic expressions if used in comparison expressions.** **Problem statement an

[PATCH] D72508: [clangd] Support pseudo-obj expr, opaque values, and property references in findExplicitReferences()

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62195 tests passed, 0 failed and 815 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

topisani updated this revision to Diff 240815. topisani marked an inline comment as done. topisani added a comment. Address CR Comments I couldn't think of a good way to check for `--sysroot /my/sysroot` in the test in posix shell, so i hope the grep usage is OK. CHANGES SINCE LAST ACTION ht

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

sammccall added a comment. This check as configured for LLVM itself is pretty noisy, generating warnings like: > warning: 'auto *CTSD' can be declared as 'const auto *CTSD' > [llvm-qualified-auto] which the LLVM dev guide doesn't have an opinion about. AFAICS there's no option to disable just

[PATCH] D72530: Set traversal explicitly where needed in clang-tidy

steveire updated this revision to Diff 240816. steveire added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72530/new/ https://reviews.llvm.org/D72530 Files: clang-tools-extra/clang-tidy/abseil/DurationDivisionCheck.cpp clang

[PATCH] D73367: [clangd] Go-to-definition on 'override' jumps to overridden method(s)

sammccall added a comment. (the clang-tidy check doesn't reflect a style guideline and I'm not sure it's a good idea, raised on D72217 which added it) Comment at: clang-tools-extra/clangd/XRefs.cpp:287 +// We may be overridding multipl

[PATCH] D73367: [clangd] Go-to-definition on 'override' jumps to overridden method(s)

sammccall updated this revision to Diff 240819. sammccall marked an inline comment as done. sammccall added a comment. address comment and clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73367/new/ https://reviews.llvm.org/D73367 Files:

[PATCH] D72829: Implement -fsemantic-interposition

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62258 tests passed, 0 failed and 827 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `gi

[PATCH] D73537: [clangd] add CODE_OWNERS

sammccall created this revision. sammccall added a reviewer: klimek. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73537 Files: clang-tools-e

[clang-tools-extra] dea1147 - [clangd] use SCOPED_TRACE to better trace the testcase in test failure, NFC

Author: Haojian Wu Date: 2020-01-28T12:23:26+01:00 New Revision: dea11473db38d03cbfd77f0d46e92dceb202a24a URL: https://github.com/llvm/llvm-project/commit/dea11473db38d03cbfd77f0d46e92dceb202a24a DIFF: https://github.com/llvm/llvm-project/commit/dea11473db38d03cbfd77f0d46e92dceb202a24a.diff LO

[PATCH] D73367: [clangd] Go-to-definition on 'override' jumps to overridden method(s)

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62255 tests passed, 0 failed and 827 were skipped. {icon times-circle color=red} clang-tidy: fail. clang-tidy found 0 errors and 1 warnings

[PATCH] D73537: [clangd] add CODE_OWNERS

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73537/new/ https://reviews.llvm.org/D73537 ___ c

[PATCH] D73538: [clangd] Make bin/llvm-lit run standalone clangd tests

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. Currently clangd lit tests can't be run in isolation because we don't set some of the config pa

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

hokein updated this revision to Diff 240822. hokein marked an inline comment as done. hokein added a comment. move the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73450/new/ https://reviews.llvm.org/D73450 Files: clang-tools-extra/cla

[PATCH] D73463: [clangd] use SCOPED_TRACE to better trace the testcase in test failure, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rGdea11473db38: [clangd] use SCOPED_TRACE to better trace the testcase in test failure, NFC (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:466 auto DeclsUnderCursor = locateDeclAt(AST, IdentifierToken->location()); if (DeclsUnderCursor.empty()) kadircet wrote: > hok

[PATCH] D73537: [clangd] add CODE_OWNERS

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62195 tests passed, 0 failed and 815 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

alexfh added a comment. In D72527#1843475 , @Eugene.Zelenko wrote: > As I wrote, I don't have GitHub commit access, so I need help with commit. Sorry, missed that part of the patch description. As per Nathan's comment, please rebase the patch. Reposi

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

kadircet added inline comments. Comment at: clang-tools-extra/clangd/QueryDriverDatabase.cpp:144 + }); + if (Found != std::end(ArgsToPreserve)) { +Arg.consume_front(*Found); nit: early exit with ``` if(Found == std::end(ArgsToPreserve)) co

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

njames93 added a comment. In D72217#1844112 , @sammccall wrote: > This check as configured for LLVM itself is pretty noisy, generating warnings > like: > > > warning: 'auto *CTSD' can be declared as 'const auto *CTSD' > > [llvm-qualified-auto] > > which

[PATCH] D73541: [Clang] Added method getTokenLocations to StringLiteral

njames93 created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. njames93 edited the summary of this revision. njames93 edited the summary of this revision. njames93 added a reviewer: rsmith. Adds a helper method `ArrayRef getTokenLocations() const` to `clang

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

gchatelet created this revision. gchatelet added reviewers: efriedma, courbet, tejohnson. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. This is a follow up on D61634 and the last step to implement http://list

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

sammccall added a comment. In D72217#1844204 , @njames93 wrote: > https://llvm.org/docs/CodingStandards.html#beware-unnecessary-copies-with-auto > > // Copy pointers, but make it clear that they're pointers. > for (const auto *Ptr : Container) { observ

[PATCH] D73538: [clangd] Make bin/llvm-lit run standalone clangd tests

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62255 tests passed, 0 failed and 827 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62202 tests passed, 0 failed and 815 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `gi

[PATCH] D72824: [X86] Add combination for fma and fneg on X86 under strict FP.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3d1f0ce3b9f8: [X86] Add combination for fma and fneg on X86 under strict FP. (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72824/new/

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:466 auto DeclsUnderCursor = locateDeclAt(AST, IdentifierToken->location()); if (DeclsUnderCursor.empty()) hokein wrote: > kadircet wrote: > > hokein wrote: > > > kadi

[PATCH] D73541: [Clang] Added method getTokenLocations to StringLiteral

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62255 tests passed, 0 failed and 827 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73367: [clangd] Go-to-definition on 'override' jumps to overridden method(s)

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73367/new/ https://reviews.llvm.org/D73367 ___

[clang] 3239b50 - [FPEnv] Add pragma FP_CONTRACT support under strict FP.

Author: Wang, Pengfei Date: 2020-01-28T20:43:43+08:00 New Revision: 3239b5034ee97b63572e61713b15be8444eeab25 URL: https://github.com/llvm/llvm-project/commit/3239b5034ee97b63572e61713b15be8444eeab25 DIFF: https://github.com/llvm/llvm-project/commit/3239b5034ee97b63572e61713b15be8444eeab25.diff

[PATCH] D72820: [FPEnv] Add pragma FP_CONTRACT support under strict FP.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3239b5034ee9: [FPEnv] Add pragma FP_CONTRACT support under strict FP. (authored by pengfei). Changed prior to commit: https://reviews.llvm.org/D72820?vs=240474&id=240840#toc Repository: rG LLVM Githu

[PATCH] D72448: [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers

aaron.ballman added a comment. In D72448#1844032 , @njames93 wrote: > Hmm a lot of the code in the redundant-string-init check is designed to be > macro unsafe. Not sure the best way to follow up, discard the old macro > behaviour or keep it Designed t

[PATCH] D72531: Set traversal explicitly where needed in tests

steveire updated this revision to Diff 240841. steveire added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72531/new/ https://reviews.llvm.org/D72531 Files: clang/unittests/AST/ASTImporterTest.cpp clang/unittests/AST/SourceL

[PATCH] D73464: [clang] Add TagDecl AST matcher

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Do you need someone to commit on your behalf? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73464/new/ https://reviews.llvm.

[PATCH] D72448: [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers

njames93 added a comment. In D72448#1844309 , @aaron.ballman wrote: > In D72448#1844032 , @njames93 wrote: > > > Hmm a lot of the code in the redundant-string-init check is designed to be > > macro unsafe. Not sur

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

njames93 added a comment. In D72217#1844262 , @sammccall wrote: > The text/rule there is explicitly about avoiding/clarifying copies - the > examples indeed use 'const' but AFAICT the "don't copy" reasoning only > applies to including *&. > > FWIW I thin

[clang] aec6210 - [ASTMatchers] Add cxxNoexceptExpr AST matcher

Author: Nathan Date: 2020-01-28T13:12:28Z New Revision: aec6210367de714caf876fe19c4b475889890e21 URL: https://github.com/llvm/llvm-project/commit/aec6210367de714caf876fe19c4b475889890e21 DIFF: https://github.com/llvm/llvm-project/commit/aec6210367de714caf876fe19c4b475889890e21.diff LOG: [ASTMa

[PATCH] D73439: [ASTMatchers] Add cxxNoexceptExpr AST matcher

This revision was automatically updated to reflect the committed changes. Closed by commit rGaec6210367de: [ASTMatchers] Add cxxNoexceptExpr AST matcher (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73439/new/ https://reviews

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

aaron.ballman added a comment. In D72217#1844262 , @sammccall wrote: > In D72217#1844204 , @njames93 wrote: > > > https://llvm.org/docs/CodingStandards.html#beware-unnecessary-copies-with-auto > > > > // Copy poin

[PATCH] D72448: [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers

aaron.ballman added a comment. In D72448#1844320 , @njames93 wrote: > In D72448#1844309 , @aaron.ballman > wrote: > > > In D72448#1844032 , @njames93 > > wrote: > > > > > H

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UnintendedADLCheck.h:27 + const bool IgnoreOverloadedOperators; + const std::vector Whitelist; + I'd prefer a more descriptive name for this (and the user-facing option + do

[PATCH] D73545: Fix a crash when casting _Complex and ignoring the results

aaron.ballman created this revision. aaron.ballman added reviewers: rjmccall, jyknight, lebedev.ri. Performing a cast where the result is ignored causes Clang to crash when performing codegen for the conversion: _Complex int a; void fn1() { (_Complex double) a; } This patch addresses the cr

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille updated this revision to Diff 240844. serge-sans-paille added a comment. Make some tests more portable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68720 Files: clang/docs/ClangCommandLine

[PATCH] D72820: [FPEnv] Add pragma FP_CONTRACT support under strict FP.

jhenderson added inline comments. Comment at: llvm/docs/LangRef.rst:16145 +'``llvm.experimental.constrained.fmuladd``' Intrinsic +^^^ + This underline isn't long enough and is breaking the sphinx build bot. Please

[PATCH] D73354: clang-format: insert trailing commas into containers.

mprobst updated this revision to Diff 240847. mprobst marked 16 inline comments as done. mprobst added a comment. - - only run comma insertion for JavaScript. - review fixes - Fix col limit - test for comma insertion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D73356: [ARM,MVE] Add intrinsics for vdupq.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73356/new/ https://reviews.llvm.org/D73356

[PATCH] D73354: clang-format: insert trailing commas into containers.

mprobst marked 3 inline comments as done. mprobst added inline comments. Comment at: clang/include/clang/Format/Format.h:552 +/// Insert trailing commas in container literals that were wrapped over +/// multiple lines. +TCS_Wrapped, sammccall wrote: >

[PATCH] D52136: [clang-tidy] Add modernize-concat-nested-namespaces check

grandinj added a comment. Herald added a project: LLVM. Hi Thanks a lot for this checker - would it be possible to enhance it to also update stuff in associated header files? Thanks Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52136/new/ https://reviews.llvm.o

[PATCH] D72820: [FPEnv] Add pragma FP_CONTRACT support under strict FP.

pengfei marked an inline comment as done. pengfei added inline comments. Comment at: llvm/docs/LangRef.rst:16145 +'``llvm.experimental.constrained.fmuladd``' Intrinsic +^^^ + jhenderson wrote: > This underline isn't

[clang] aaae6b1 - Revert "PR44684: Look through parens and similar constructs when determining"

Author: Nico Weber Date: 2020-01-28T09:03:27-05:00 New Revision: aaae6b1b617378362462c1685e754813ed82b394 URL: https://github.com/llvm/llvm-project/commit/aaae6b1b617378362462c1685e754813ed82b394 DIFF: https://github.com/llvm/llvm-project/commit/aaae6b1b617378362462c1685e754813ed82b394.diff LO

[PATCH] D73335: clang-format: [JS] options for arrow functions.

mprobst marked 2 inline comments as done. mprobst added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3165 + } +} + RKSimon wrote: > @mprobst - this is breaking buildbots: > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-and

Re: [clang] af80b8c - PR44684: Look through parens and similar constructs when determining

I reverted this for now in aaae6b1b617378362462c1685e754813ed82b394 . The commit message of the revert has a link to a bot on the official waterfall as well (but it's the same error as on my bots). On Mon, Jan 27, 2020 at 10:05 PM Nico Weber wrote: > This seems to break check-clang-tools on non-

[PATCH] D73464: [clang] Add TagDecl AST matcher

f00kat marked an inline comment as done. f00kat added a comment. In D73464#1844310 , @aaron.ballman wrote: > LGTM! Do you need someone to commit on your behalf? Yes, please. I don`t know how :) Comment at: clang/lib/ASTMatchers/Dynam

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

hokein updated this revision to Diff 240853. hokein marked an inline comment as done. hokein added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73450/new/ https://reviews.llvm.org/D73450 Files: clang-tools-extra/clan

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:466 auto DeclsUnderCursor = locateDeclAt(AST, IdentifierToken->location()); if (DeclsUnderCursor.empty()) kadircet wrote: > hokein wrote: > > kadircet wrote: > > > hoke

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

antiagainst marked 2 inline comments as done. antiagainst added inline comments. Herald added a reviewer: mclow.lists. Comment at: mlir/lib/Conversion/LinalgToSPIRV/LinalgToSPIRV.cpp:27 +/// types. +static inline bool areAllValuesMemref(Operation *op) { + auto isOfMemrefType = [

[PATCH] D73354: clang-format: insert trailing commas into containers.

MyDeveloperDay added a comment. Nit: Could you add an entry for ReleaseNotes.rst and regenerate the ClangFormatStyleOption.rst with the docs/tools/dump_style.py Comment at: clang/unittests/Format/FormatTestJS.cpp:1229 " (param): param is {\n" -

[PATCH] D73548: [clang-tidy] Added option for disabling const qualifiers in readability-qualified-auto

njames93 created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Adds an option called `AddConstQualifier` to readability-qualified-auto to toggle adding const to the auto typed pointers and references. By default its enabled but in the LLVM module

[PATCH] D68720: Support -fstack-clash-protection for x86

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62269 tests passed, 0 failed and 827 were skipped. {icon times-circle color=red} clang-tidy: fail. clang-tidy found 0 errors and 16 warnings

[clang] e916c8d - Revert "[Clang] Warn about 'z' printf modifier in old MSVC."

Author: Nico Weber Date: 2020-01-28T09:27:54-05:00 New Revision: e916c8dfe461e272aa7ea115851db7ddda36b971 URL: https://github.com/llvm/llvm-project/commit/e916c8dfe461e272aa7ea115851db7ddda36b971 DIFF: https://github.com/llvm/llvm-project/commit/e916c8dfe461e272aa7ea115851db7ddda36b971.diff LO

[PATCH] D73457: [Clang] Warn about 'z' printf modifier in old MSVC.

thakis added a comment. This breaks tests on Windows: http://45.33.8.238/win/6812/step_7.txt Since we auto-detect -fmsc-version if it's not explicitly installed and since this warning is on by default, it makes the test suite depend on the environment a good bit. Given how old 2015 is by now, I

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

antiagainst updated this revision to Diff 240861. antiagainst added a comment. Clean up unrelated commits again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73437/new/ https://reviews.llvm.org/D73437 Files: mlir/include/mlir/Conversion/LinalgTo

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

njames93 added a comment. https://reviews.llvm.org/D73548 Next step is to fire off an email to llvm-dev about adding it to the coding standard :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72217/new/ https://reviews.llvm.org/D72217 _

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

antiagainst added a comment. Messed up the revision history with Arc... Please show the diff between "Diff 1" and "Diff 4" to check the modifications. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73437/new/ https://reviews.llvm.org/D73437

[PATCH] D73548: [clang-tidy] Added option for disabling const qualifiers in readability-qualified-auto

lebedev.ri added a comment. SGTM, but please wait for the reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73548/new/ https://reviews.llvm.org/D73548 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D73548: [clang-tidy] Added option for disabling const qualifiers in readability-qualified-auto

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/QualifiedAutoCheck.cpp:209 + llvm::StringRef PtrConst = + (AddConstQualifier && isPointerConst(Var->getType())) ? "const " : ""; l

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:225 TargetIDs.insert(SymbolID(USR)); - std::vector Results; nit: maybe revert this o

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62199 tests passed, 0 failed and 815 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `gi

[PATCH] D73457: [Clang] Warn about 'z' printf modifier in old MSVC.

simon_tatham added a comment. I wanted this to go in because I'm actually using it – pre-2015 C libraries are useful to link against if you need an application to run on very old versions of Windows, and that means you need the compiler to warn you if you do something those libraries don't supp

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62202 tests passed, 0 failed and 815 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73551: [AArch64][SVE] Add remaining SVE2 intrinsics for uniform DSP operations

kmclaughlin created this revision. kmclaughlin added reviewers: efriedma, sdesmalen, dancgr, cameron.mcinally, c-rhodes. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: LLVM. kmclaughlin added a parent revisi

[clang] 9d212e8 - [clang-format] Handle quotes and escaped braces in C# interpolated strings

Author: Jonathan Coe Date: 2020-01-28T14:46:27Z New Revision: 9d212e83e920363762eb265293adf0bd6fda5a13 URL: https://github.com/llvm/llvm-project/commit/9d212e83e920363762eb265293adf0bd6fda5a13 DIFF: https://github.com/llvm/llvm-project/commit/9d212e83e920363762eb265293adf0bd6fda5a13.diff LOG:

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff

[PATCH] D73492: [clang-format] Handle quotes and escaped braces in C# interpolated strings

This revision was automatically updated to reflect the committed changes. Closed by commit rG9d212e83e920: [clang-format] Handle quotes and escaped braces in C# interpolated strings (authored by Jonathan Coe ). Herald added a project: clang. Herald added a subscriber: cfe-commit

[PATCH] D73548: [clang-tidy] Added option for disabling const qualifiers in readability-qualified-auto

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62260 tests passed, 0 failed and 827 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62199 tests passed, 0 failed and 815 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73548: [clang-tidy] Added option for disabling const qualifiers in readability-qualified-auto

Quuxplusone added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-qualified-auto.rst:41 + auto *const Bar = cast(Baz2); + auto *volatile FooBar = cast(Baz3); + Is it worth adding an example of a double pointer? auto Bar

[PATCH] D73354: clang-format: insert trailing commas into containers.

mprobst updated this revision to Diff 240873. mprobst marked an inline comment as done. mprobst added a comment. - - only run comma insertion for JavaScript. - review fixes - Fix col limit - test for comma insertion - - validate options, reject bin packing + trailing commas Repository: rG LLVM

[PATCH] D73354: clang-format: insert trailing commas into containers.

mprobst marked 6 inline comments as done. mprobst added a comment. PTAL. Comment at: clang/include/clang/Format/Format.h:552 +/// Insert trailing commas in container literals that were wrapped over +/// multiple lines. +TCS_Wrapped, mprobst wrote: >

[PATCH] D73538: [clangd] Make bin/llvm-lit run standalone clangd tests

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb74d2e1bdec: [clangd] Make bin/llvm-lit run standalone clangd tests (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73538/new/ https:

[clang-tools-extra] cb74d2e - [clangd] Make bin/llvm-lit run standalone clangd tests

Author: Kadir Cetinkaya Date: 2020-01-28T16:17:58+01:00 New Revision: cb74d2e1bdec8510f4ddd41e1ec879d745f40597 URL: https://github.com/llvm/llvm-project/commit/cb74d2e1bdec8510f4ddd41e1ec879d745f40597 DIFF: https://github.com/llvm/llvm-project/commit/cb74d2e1bdec8510f4ddd41e1ec879d745f40597.dif

[PATCH] D73495: [CodeGen] Attach no-builtin attributes to function definitions with no Decl

thegameg marked 2 inline comments as done. thegameg added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1917 const auto *NBA = Fn->getAttr(); -bool HasWildcard = NBA && llvm::is_contained(NBA->builtinNames(), "*"); -if (getLangOpts().NoBuiltin

  1   2   3   >