[PATCH] D74830: [clang][Index] Fix the incomplete instantiations in libindex.

kadircet added inline comments. Comment at: clang/lib/Index/IndexingContext.cpp:217 +// Fallback to primary template if this is an incomplete specialization. +if (SD->getTemplateSpecializationKind() == TSK_Undeclared) + return SD->getSpecializedTemplate()->getTemplat

[PATCH] D74830: [clang][Index] Fix the incomplete instantiations in libindex.

kadircet added inline comments. Comment at: clang/lib/Index/IndexingContext.cpp:175 + if (TKind == TSK_Undeclared) +return dyn_cast(D); + i believe this might as well be an explicit instantiation, e.g. ``` template struct Foo{}; template <> struct Foo; vo

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

tnorth updated this revision to Diff 245592. tnorth added a comment. Fix comment to file: instead of the incorrect file= Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 Files: docs/ClangFormat.rst docs/ClangFormatStyl

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

tnorth marked 2 inline comments as done. tnorth added inline comments. Comment at: include/clang/Format/Format.h:2341 /// directory if ``FileName`` is empty. +/// * "file=" to explicitly specify the configuration file to use. /// lebedev.ri wrote: > So is it `:

[PATCH] D74871: Fix interaction between -fdiscard-value-names and LLVM Bitcode

serge-sans-paille updated this revision to Diff 245594. serge-sans-paille added a comment. Finally, the test case :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74871/new/ https://reviews.llvm.org/D74871 Files: clang/include/clang/Basic/Diagn

[PATCH] D74829: [clang-rename] Add the USR of incomplete decl to the USRSet.

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Let me try to reproduce it in Clang-Rename. If I don't respond by tomorrow, feel free to submit the patch. Comment at: clang/lib/Tooling/Refactoring/Rename/USRFindingAct

[PATCH] D74692: [clang-tidy] Make bugprone-use-after-move ignore std::move for const values

zinovy.nis added a comment. In D74692#1884054 , @Quuxplusone wrote: > (I sent this to the mailing list, but I guess it doesn't show up here unless > I do it through Phab. Quoting myself—) > > I see your point about how users who care should always be pass

[PATCH] D74830: [clang][Index] Fix the incomplete instantiations in libindex.

hokein updated this revision to Diff 245601. hokein marked 4 inline comments as done. hokein added a comment. address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74830/new/ https://reviews.llvm.org/D74830 Files: clang-tools-ex

[PATCH] D74830: [clang][Index] Fix the incomplete instantiations in libindex.

hokein added inline comments. Comment at: clang/lib/Index/IndexingContext.cpp:175 + if (TKind == TSK_Undeclared) +return dyn_cast(D); + kadircet wrote: > kadircet wrote: > > i believe this might as well be an explicit instantiation, e.g. > > > > ``` > > tem

[PATCH] D74830: [clang][Index] Fix the incomplete instantiations in libindex.

kadircet added inline comments. Comment at: clang/lib/Index/IndexingContext.cpp:217 +// Fallback to primary template if this is an incomplete specialization. +if (SD->getTemplateSpecializationKind() == TSK_Undeclared) + return SD->getSpecializedTemplate()->getTemplat

[PATCH] D74871: Fix interaction between -fdiscard-value-names and LLVM Bitcode

serge-sans-paille updated this revision to Diff 245606. serge-sans-paille added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Other approach to the problem: modify `Value::SetNameImpl` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74830: [clang][Index] Fix the incomplete instantiations in libindex.

hokein added inline comments. Comment at: clang/test/Index/Core/index-instantiated-source.cpp:103 +// explicit instantiations. +template class Foo; +Foo t3; kadircet wrote: > yes this is an explicit instantiation and will have TSKKind set properly. > > but i was

[PATCH] D74830: [clang][Index] Fix the incomplete instantiations in libindex.

hokein updated this revision to Diff 245608. hokein marked 3 inline comments as done. hokein added a comment. Add an explicit template declaration (not definition) testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74830/new/ https://reviews.l

[PATCH] D74845: [ARM,MVE] Add vqdmull[b,t]q intrinsic families

miyuki added a comment. The Windows failure is similar to https://github.com/google/llvm-premerge-checks/issues/132, it looks like an infrastructure issue to me, so I am going to ignore it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74845/new/

[clang] f4fd7db - [ARM,MVE] Add vqdmull[b,t]q intrinsic families

Author: Mikhail Maltsev Date: 2020-02-20T10:51:19Z New Revision: f4fd7dbf85e278eff303514760bff4773a87e601 URL: https://github.com/llvm/llvm-project/commit/f4fd7dbf85e278eff303514760bff4773a87e601 DIFF: https://github.com/llvm/llvm-project/commit/f4fd7dbf85e278eff303514760bff4773a87e601.diff LO

[PATCH] D74845: [ARM,MVE] Add vqdmull[b,t]q intrinsic families

This revision was automatically updated to reflect the committed changes. Closed by commit rGf4fd7dbf85e2: [ARM,MVE] Add vqdmull[b,t]q intrinsic families (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74845/new/ https://reviews.

[PATCH] D74830: [clang][Index] Fix the incomplete instantiations in libindex.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, please fix the formatting warnings though (at least the ones in the implementation) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7483

[clang] c8f9e52 - [clang-tidy] misc-no-recursion: point to the function defs, not decls

Author: Roman Lebedev Date: 2020-02-20T14:17:30+03:00 New Revision: c8f9e526bc5319f2d0beed4012fbf17b11e15161 URL: https://github.com/llvm/llvm-project/commit/c8f9e526bc5319f2d0beed4012fbf17b11e15161 DIFF: https://github.com/llvm/llvm-project/commit/c8f9e526bc5319f2d0beed4012fbf17b11e15161.diff

[PATCH] D74830: [clang][Index] Fix the incomplete instantiations in libindex.

hokein added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74830/new/ https://reviews.llvm.org/D74830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D74830: [clang][Index] Fix the incomplete instantiations in libindex.

hokein updated this revision to Diff 245611. hokein added a comment. Fix the format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74830/new/ https://reviews.llvm.org/D74830 Files: clang-tools-extra/clangd/unittests/XRefsTests.cpp clang/lib/In

[PATCH] D74131: [analyzer][taint] Add isTainted debug expression inspection check

steakhal added a comment. Herald added a subscriber: martong. If this patch is good to go, could someone commit it? I don't have commit access (yet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74131/new/ https://reviews.llvm.org/D74131 __

[PATCH] D74015: [AIX][Frontend] C++ ABI customizations for AIX boilerplate

cebowleratibm added a comment. In D74015#1882933 , @sfertile wrote: > Patch LGTM as far a formatting/naming/testing etc. C++ specifics is outside > my wheelhouse though, so I can't confirm things like the tail padding rules > are correct for AIX. Because

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

joerg marked an inline comment as done. joerg added inline comments. Comment at: libcxx/include/new:229-237 +#if !defined(_LIBCPP_CXX03_LANG) +using __libcpp_max_align_t = max_align_t; +#else +union __libcpp_max_align_t { + void * __f1; + long long int __f2; + long double __f3

[PATCH] D74844: [clangd] Get rid of Lexer usage in CodeComplete

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:593 + llvm::StringRef SpelledSpecifier = + syntax::FileRange(CCSema.SourceMgr, SemaSpecifier->getBeginLoc(), +SemaSpecifi

[PATCH] D74878: [remark][diagnostics] [codegen] Fix PR44896

hans added a comment. See also https://reviews.llvm.org/D74871 I don't know which is the better fix here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74878/new/ https://reviews.llvm.org/D74878 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D74871: Fix interaction between -fdiscard-value-names and LLVM Bitcode

hans added a reviewer: xur. hans added a comment. Thanks for looking into this, Serge! I used your test case to bisect where the crashing started, and ended up at 60d39479221d6bc09060f7816bcd7c54eb286603 Someone else noted t

[PATCH] D74878: [remark][diagnostics] [codegen] Fix PR44896

lebedev.ri added a comment. This seems like the reasonable fix to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74878/new/ https://reviews.llvm.org/D74878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D73996: [Sema] Demote call-site-based 'alignment is a power of two' check for AllocAlignAttr into a warning

lebedev.ri updated this revision to Diff 245622. lebedev.ri added a comment. Rebased, NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73996/new/ https://reviews.llvm.org/D73996 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/l

[PATCH] D73020: [Sema] Perform call checking when building CXXNewExpr

lebedev.ri updated this revision to Diff 245625. lebedev.ri added a comment. Rebased ontop of patch demoting call-site-based align attr checking from error into a warning, NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73020/new/ https://revie

[clang] 9ea5d17 - [Sema] Demote call-site-based 'alignment is a power of two' check for AllocAlignAttr into a warning

Author: Roman Lebedev Date: 2020-02-20T16:39:26+03:00 New Revision: 9ea5d17cc9544838c73e593de4ef224d54fa1cff URL: https://github.com/llvm/llvm-project/commit/9ea5d17cc9544838c73e593de4ef224d54fa1cff DIFF: https://github.com/llvm/llvm-project/commit/9ea5d17cc9544838c73e593de4ef224d54fa1cff.diff

[clang] 2f215cf - Revert "Reland "[DebugInfo] Enable the debug entry values feature by default""

Author: Djordje Todorovic Date: 2020-02-20T14:41:39+01:00 New Revision: 2f215cf36adced6bf1abda4bdbbc6422c1369353 URL: https://github.com/llvm/llvm-project/commit/2f215cf36adced6bf1abda4bdbbc6422c1369353 DIFF: https://github.com/llvm/llvm-project/commit/2f215cf36adced6bf1abda4bdbbc6422c1369353.d

[PATCH] D73996: [Sema] Demote call-site-based 'alignment is a power of two' check for AllocAlignAttr into a warning

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ea5d17cc954: [Sema] Demote call-site-based 'alignment is a power of two' check for… (authored by lebedev.ri). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] bb9e92b - [clang][Index] Fix the incomplete instantiations in libindex.

Author: Haojian Wu Date: 2020-02-20T14:42:30+01:00 New Revision: bb9e92bad55f65f2de58bf29548bdfd3dea2d7ab URL: https://github.com/llvm/llvm-project/commit/bb9e92bad55f65f2de58bf29548bdfd3dea2d7ab DIFF: https://github.com/llvm/llvm-project/commit/bb9e92bad55f65f2de58bf29548bdfd3dea2d7ab.diff LO

[PATCH] D74830: [clang][Index] Fix the incomplete instantiations in libindex.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbb9e92bad55f: [clang][Index] Fix the incomplete instantiations in libindex. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74830/new/ h

[PATCH] D74564: libclang: Add static build support for Windows

cristian.adam marked an inline comment as done. cristian.adam added inline comments. Comment at: clang/tools/libclang/CMakeLists.txt:117 if(ENABLE_SHARED) + target_compile_definitions(libclang PUBLIC CINDEX_EXPORTS) if(WIN32) thakis wrote: > Is this enough?

[PATCH] D74709: [clangd] Allow renaming class templates in cross-file rename.

hokein added a comment. In D74709#1882451 , @kbobyrev wrote: > I think we might still give a warning of some sort that this is known to > produce results that are not always correct. Otherwise it might feel like a > bug/unknown behavior. I agree that i

[PATCH] D74900: [clangd] Fix the incomplete template specialization in findTarget.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. hokein updated this revision to Diff 245645. hokein added a comment. Fix an accident change. FindTarget does

[PATCH] D74564: libclang: Add static build support for Windows

thakis added a comment. Another question: We have a bot that builds LLVM with this cmake config: 'cmake', '-GNinja', '-DCMAKE_BUILD_TYPE=Release', '-DLLVM_ENABLE_ASSERTIONS=OFF', '-DLLVM_ENABLE_PROJECTS=clang;compiler-rt;lld;chrometools;clang-tools-extra', '-DLLVM_TARGETS_TO_BUILD=AArch64;ARM;

[PATCH] D74850: [clangd] Migrate Lexer usages in TypeHierarchy to TokenBuffers

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/XRefs.cpp:613 + }); + if (!NameTok) +return llvm::None; I think you're trying to test if NameTok has

[PATCH] D74900: [clangd] Fix the incomplete template specialization in findTarget.

hokein updated this revision to Diff 245645. hokein added a comment. Fix an accident change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74900/new/ https://reviews.llvm.org/D74900 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tools-ex

[PATCH] D28820: Warn when calling a non interrupt function from an interrupt on ARM

jroelofs added a comment. Herald added a subscriber: kristof.beyls. In D28820#945118 , @kc.austin2017 wrote: > In D28820#944865 , @jroelofs wrote: > > > https://bugs.llvm.org/show_bug.cgi?id=35527 > > > > https://bugs

[PATCH] D74834: [clangd] Expose the rename LimitFiles option to the C++ API, NFC.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.h:145 -/// Enable cross-file rename feature. -bool CrossFileRename = false; +/// Options for rename. +RenameOptions RenameOpts; rename is just a normal API call,

[PATCH] D74116: [Sema][C++] Propagate conversion type in order to specialize the diagnostics

Anastasia updated this revision to Diff 245647. Anastasia added a comment. - Always set `isInvalid` for all error cases. - Hoist setting `isInvalid` together with an error diagnostic. - Updated more tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74116/new/ https://reviews.llvm.org

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

martong updated this revision to Diff 245651. martong marked 8 inline comments as done. martong added a comment. - Add new Checker that does the report - Refactor with negated RangeValues - Add overload to findFunctionSummary - Add tests for symbolic values - Add test file for bug path Repositor

[PATCH] D74709: [clangd] Allow renaming class templates in cross-file rename.

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Okay, that is unfortunate, but I think trying to rename these classes with some inaccuracy is better than failing right away. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

martong added a comment. I've done a major refactor with the handling of argument constraints. I am now reusing `ValueRange::apply` in `checkPreCall` on "negated" value ranges to check if the constraint is violated. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunc

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

martong updated this revision to Diff 245652. martong added a comment. - Remove leftover call from test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73898/new/ https://reviews.llvm.org/D73898 Files: clang/include/clang/StaticAnalyzer/Checkers/C

[PATCH] D74564: libclang: Add static build support for Windows

cristian.adam added a comment. > Given that this is currently a breaking change: Does it make sense to re-use > LLVM_ENABLE_PIC for this, which currently doesn't have an effect on Windows > anywhere? Maybe there should be a dedicated "I want libclang to be a static > library" opt-in? And maybe

[PATCH] D74116: [Sema][C++] Propagate conversion type in order to specialize the diagnostics

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74116/new/ https://reviews.llvm.org/D74116 ___ cfe-commits mailing list

[PATCH] D74564: libclang: Add static build support for Windows

thakis added a comment. Great, thanks. Since we're currently broken due to this change, any ETA for the follow-up? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74564/new/ https://reviews.llvm.org/D74564

[PATCH] D74847: [CodeGen][RISCV] Fix clang/test/CodeGen/atomic_ops.c for RISC-V

luismarques added a comment. In D74847#1883028 , @efriedma wrote: > I'm not really a big fan of running tests with the host target triple, > anyway; it seems to create work with almost no benefit. I'd be happy to just > run the test with one target that

[PATCH] D74564: libclang: Add static build support for Windows

cristian.adam added a comment. In D74564#1884675 , @thakis wrote: > Great, thanks. Since we're currently broken due to this change, any ETA for > the follow-up? I'll submit it today. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D73380: [clang] Annotating C++'s `operator new` with more attributes

lebedev.ri updated this revision to Diff 245656. lebedev.ri added a comment. Rebased, NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73380/new/ https://reviews.llvm.org/D73380 Files: clang/include/clang/AST/Decl.h clang/include/clang/Sema/

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. Reverted again with rG2f215cf36adc . The investigation is needed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

ostannard added a comment. There's a failure on an ARM 2-stage buildbot which looks related to this: http://lab.llvm.org:8011/builders/clang-cmake-thumbv7-full-sh/builds/3920/steps/build%20stage%202/logs/stdio I can reproduce the crash on the buildbot machine, so hopefully I'll have a standalon

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. Nice! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. @ostannard Thanks for reporting that! Please share the case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

ostannard added a comment. Reproducer for that crash: P8198 P8199 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534 ___ cfe-commits ma

[PATCH] D74906: [clang][analyzer] Modify include AllocationState.h in PutenvWithAutoChecker.cpp

usaxena95 created this revision. usaxena95 added a reviewer: kadircet. Herald added subscribers: cfe-commits, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. PutenvWithAutoChecker.cpp used to inclu

[clang] cb54c13 - [clang][analyzer] Modify include AllocationState.h in PutenvWithAutoChecker.cpp

Author: Utkarsh Saxena Date: 2020-02-20T17:17:36+01:00 New Revision: cb54c13c217b3e5fcda5c97bab229c1f9c3934b7 URL: https://github.com/llvm/llvm-project/commit/cb54c13c217b3e5fcda5c97bab229c1f9c3934b7 DIFF: https://github.com/llvm/llvm-project/commit/cb54c13c217b3e5fcda5c97bab229c1f9c3934b7.diff

[PATCH] D74906: [clang][analyzer] Modify include AllocationState.h in PutenvWithAutoChecker.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb54c13c217b: [clang][analyzer] Modify include AllocationState.h in PutenvWithAutoChecker.cpp (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

sammccall added a comment. @rsmith Friendly ping. Do you want to review this/other patches in this sequence, or should we be a bit bolder and pull you in when we're uncertain in principle what to do? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[PATCH] D74878: [remark][diagnostics] [codegen] Fix PR44896

serge-sans-paille added a comment. @lebedev.ri maybe we should at least warn the user if there was a flag at clang level to force discarding? That's what I've been doing in https://reviews.llvm.org/D74871?id=245594 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74878/new/ https://revie

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1514 + void visitUsedDecl(SourceLocation Loc, Decl *D) { +if (auto *TD = dyn_cast(D)) { + for (auto *DD : TD->decls()) { rjmccall wrote: > yaxunl

[PATCH] D74907: libclang: Make shared object symbol exporting by default

cristian.adam created this revision. cristian.adam added reviewers: yvvan, mstorsjo, thakis. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. https://reviews.llvm.org/D74564 enabled static building for libclang, and for non CMake consumers they had to set the `CMAKE_E

[PATCH] D74564: libclang: Add static build support for Windows

cristian.adam added a comment. > I'll submit it today. Done, see: https://reviews.llvm.org/D74907 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74564/new/ https://reviews.llvm.org/D74564 ___ cfe-commi

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

bader added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1514 + void visitUsedDecl(SourceLocation Loc, Decl *D) { +if (auto *TD = dyn_cast(D)) { + for (auto *DD : TD->decls()) { yaxunl wrote: > rjmccall wrote: > > yaxunl wrote: > > > rjmccall wr

[PATCH] D74907: libclang: Make shared object symbol exporting by default

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! Does this make it so that libclang.dll is built again with -DLLVM_ENABLE_PIC=NO on Window? From what I understand, it doesn't. Is that correct? If so, could you reinstantiate that too?

[PATCH] D74878: [remark][diagnostics] [codegen] Fix PR44896

xur added a comment. In D74878#1884769 , @serge-sans-paille wrote: > @lebedev.ri maybe we should at least warn the user if there was a flag at > clang level to force discarding? That's what I've been doing in > https://reviews.llvm.org/D74871?id=245594

[PATCH] D74907: libclang: Make shared object symbol exporting by default

cristian.adam marked an inline comment as done. cristian.adam added inline comments. Comment at: clang/include/clang-c/Platform.h:33 #endif -#elif defined(CINDEX_EXPORTS) +#elif defined(CINDEX_EXPORTS) && defined(__GNUC__) #define CINDEX_LINKAGE __attribute__((visibility("d

[PATCH] D74907: libclang: Make shared object symbol exporting by default

cristian.adam added a comment. In D74907#1884795 , @thakis wrote: > Thanks! Does this make it so that libclang.dll is built again with > -DLLVM_ENABLE_PIC=NO on Window? From what I understand, it doesn't. Is that > correct? If so, could you reinstantiate

[PATCH] D74907: libclang: Make shared object symbol exporting by default

cristian.adam added a comment. I do not have commit rights, I need help to submit this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74907/new/ https://reviews.llvm.org/D74907 ___ cfe-commits ma

[clang-tools-extra] db8911a - [clang-tidy] rename_check.py: maintain alphabetical order in Renamed checks section

Author: Eugene Zelenko Date: 2020-02-20T17:31:08Z New Revision: db8911aad726d050fb36f17f2978bd35f69165cc URL: https://github.com/llvm/llvm-project/commit/db8911aad726d050fb36f17f2978bd35f69165cc DIFF: https://github.com/llvm/llvm-project/commit/db8911aad726d050fb36f17f2978bd35f69165cc.diff LOG

[PATCH] D74910: [OpenCL] Remove spurious atomic_fetch_min/max builtins

svenvh created this revision. svenvh added reviewers: Anastasia, yaxunl. Herald added subscribers: cfe-commits, kristina, jfb. Herald added a project: clang. These declarations use a mix of unsigned and signed argument and return types. This is not defined in OpenCL v2.0 s6.13.11. Repository:

[PATCH] D73580: [clang-tidy] rename_check.py: maintain alphabetical order in Renamed checks section

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb8911aad726: [clang-tidy] rename_check.py: maintain alphabetical order in Renamed checks… (authored by Eugene.Zelenko, committed by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D73580: [clang-tidy] rename_check.py: maintain alphabetical order in Renamed checks section

njames93 added a comment. In D73580#1884042 , @Eugene.Zelenko wrote: > In D73580#1883861 , @njames93 wrote: > > > LGTM, For what this is trying to achieve I have no issue, follow up patches > > can be submitted fo

[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

rsmith added a comment. In D71920#1884740 , @sammccall wrote: > @rsmith Friendly ping. Do you want to review this/other patches in this > sequence, or should we be a bit bolder and pull you in when we're uncertain > in principle what to do? I'm fine wi

[PATCH] D74910: [OpenCL] Remove spurious atomic_fetch_min/max builtins

yaxunl added a comment. Are you sure this change will not break OpenCL conformance tests? I remember they are there for some reason. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74910/new/ https://reviews.llvm.org/D74910 _

[PATCH] D74912: [AArch64][SVE] Add SVE2 intrinsics for bit permutation & table lookup

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, andwar, dancgr, cameron.mcinally, efriedma. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: LLVM. Implements the following intrinsic

[PATCH] D74907: libclang: Make shared object symbol exporting by default

thakis added a comment. In D74907#1884842 , @cristian.adam wrote: > In D74907#1884795 , @thakis wrote: > > > Thanks! Does this make it so that libclang.dll is built again with > > -DLLVM_ENABLE_PIC=NO on Window? F

[clang] 6fa3894 - [clang] Fix search path logic for C_INCLUDE_DIRS

Author: Louis Dionne Date: 2020-02-20T12:35:15-05:00 New Revision: 6fa3894c4e771c773712b1ae777f78c1c922a908 URL: https://github.com/llvm/llvm-project/commit/6fa3894c4e771c773712b1ae777f78c1c922a908 DIFF: https://github.com/llvm/llvm-project/commit/6fa3894c4e771c773712b1ae777f78c1c922a908.diff

[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

rsmith added a comment. In D71920#1870195 , @sammccall wrote: > If you'd like to have `concept::Requirement` use a similar bitfield, I'd just > like to confirm my understanding of the current code before refactoring it: > > - there's just one `Dependent`

[PATCH] D69221: [clang][darwin] Fix search path logic for C_INCLUDE_DIRS

This revision was automatically updated to reflect the committed changes. Closed by commit rG6fa3894c4e77: [clang] Fix search path logic for C_INCLUDE_DIRS (authored by ldionne). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69221/new/ https://revie

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao updated this revision to Diff 245682. hliao added a comment. Skip non-function or non-TU context so far as more cases need considering. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71227/new/ https://reviews.llvm.org/D71227 Files: clang/i

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao marked 2 inline comments as done. hliao added inline comments. Comment at: clang/include/clang/Sema/Sema.h:11442 + ContextDecl = getCUDACurrentNonLocalVariable(); +return ContextDecl; + } rjmccall wrote: > This is tricky because we could be in a n

[PATCH] D74907: libclang: Make shared object symbol exporting by default

cristian.adam updated this revision to Diff 245683. cristian.adam added a comment. `-DLLVM_ENABLE_PIC=OFF` on Windows if `LIBCLANG_BUILD_STATIC` is not set to `ON` will generate a SHARED libclang.dll Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[PATCH] D74910: [OpenCL] Remove spurious atomic_fetch_min/max builtins

b-sumner added a comment. I recall we agreed that conformance tests using mixed types were broken, so this change should be OK. Hopefully this will not affect users. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74910/new/ https://reviews.llvm.org/D74910 ___

[PATCH] D74907: libclang: Make shared object symbol exporting by default

cristian.adam added a comment. > The problem is (I believe) that `add_clang_library(libclang ` is passed > `${ENABLE_SHARED}` and that used to be true on Windows but no longer is after > your change (due to the change in line 80 in your original change), so > libclang.dll isn't built at all any

[PATCH] D74907: libclang: Make shared object symbol exporting by default

cristian.adam added a comment. > The problem is (I believe) that `add_clang_library(libclang ` is passed > `${ENABLE_SHARED}` and that used to be true on Windows but no longer is after > your change (due to the change in line 80 in your original change), so > libclang.dll isn't built at all any

[PATCH] D74812: [Sema] Teach -Warm-interrupt-safety about func ptrs

efriedma added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:5931 + if (Caller->hasAttr()) { +const Decl *CalleeDecl = FDecl; +if (const auto *UO = dyn_cast(Fn->IgnoreParens())) { jroelofs wrote: > This feels very fragile, and I kn

[PATCH] D74847: [CodeGen][RISCV] Fix clang/test/CodeGen/atomic_ops.c for RISC-V

efriedma added a comment. Yes, makes sense Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74847/new/ https://reviews.llvm.org/D74847 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D74704: Support -fuse-ld=lld for riscv

serge-sans-paille added a comment. For the record: http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/4749/steps/test-check-clang/logs/FAIL%3A%20Clang%3A%3Ariscv64-toolchain.c fails Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74704

[PATCH] D74907: libclang: Make shared object symbol exporting by default

thakis accepted this revision. thakis added a comment. Thanks! Let me try landing this and see what happens :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74907/new/ https://reviews.llvm.org/D74907 _

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

zoecarver created this revision. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. This patch adds a virtual method `getCPUCacheLineSize()` to `TargetInfo`. Currently, I've only (partially) implemented the method in `X86TargetInfo`. It's extremely important tha

[clang] a11ff39 - [clang-format] Merge name and colon into a single token for C# named arguments

Author: Jonathan Coe Date: 2020-02-20T19:23:38Z New Revision: a11ff39ba2ad3975a40e2684948a4dd2ada89bd3 URL: https://github.com/llvm/llvm-project/commit/a11ff39ba2ad3975a40e2684948a4dd2ada89bd3 DIFF: https://github.com/llvm/llvm-project/commit/a11ff39ba2ad3975a40e2684948a4dd2ada89bd3.diff LOG:

[PATCH] D74894: [clang-format] Merge name and colon into a single token for C# named arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rGa11ff39ba2ad: [clang-format] Merge name and colon into a single token for C# named arguments (authored by Jonathan Coe ). Herald added a project: clang. Herald added a subscriber: cfe-co

[clang] 7a7c753 - libclang: Make shared object symbol exporting by default

Author: Cristian Adam Date: 2020-02-20T14:26:25-05:00 New Revision: 7a7c753b0cca6abb61f054842fb087dfc30dc563 URL: https://github.com/llvm/llvm-project/commit/7a7c753b0cca6abb61f054842fb087dfc30dc563 DIFF: https://github.com/llvm/llvm-project/commit/7a7c753b0cca6abb61f054842fb087dfc30dc563.diff

[clang] 2f56789 - [clang][doxygen] Fix false -Wdocumentation warning for tag typedefs

Author: Jan Korous Date: 2020-02-20T11:32:30-08:00 New Revision: 2f56789c8fe8edb57bc7a193592ecd35a393fe4a URL: https://github.com/llvm/llvm-project/commit/2f56789c8fe8edb57bc7a193592ecd35a393fe4a DIFF: https://github.com/llvm/llvm-project/commit/2f56789c8fe8edb57bc7a193592ecd35a393fe4a.diff LO

[PATCH] D66822: Hardware cache line size builtins

zoecarver added a comment. In D66822#1656476 , @jfb wrote: > 1. Add to target infrastructure Refs D74918 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66822/new/ https:/

[PATCH] D74746: [clang][doxygen] Fix -Wdocumentation warning for tag typedefs

This revision was automatically updated to reflect the committed changes. Closed by commit rG2f56789c8fe8: [clang][doxygen] Fix false -Wdocumentation warning for tag typedefs (authored by jkorous). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: h

  1   2   >