[clang-tools-extra] 2bb7774 - [clangd] Get rid of getBeginningOfIdentifier helper

Author: Kadir Cetinkaya Date: 2020-02-27T09:34:45+01:00 New Revision: 2bb7774ddf002668816fdb7c4a5b8da322fe284e URL: https://github.com/llvm/llvm-project/commit/2bb7774ddf002668816fdb7c4a5b8da322fe284e DIFF: https://github.com/llvm/llvm-project/commit/2bb7774ddf002668816fdb7c4a5b8da322fe284e.dif

[clang-tools-extra] f31fc10 - [clangd] Get rid of lexer usage in AST.cpp

Author: Kadir Cetinkaya Date: 2020-02-27T09:54:21+01:00 New Revision: f31fc1043d384e0b699fcb114694a5d8e1f51784 URL: https://github.com/llvm/llvm-project/commit/f31fc1043d384e0b699fcb114694a5d8e1f51784 DIFF: https://github.com/llvm/llvm-project/commit/f31fc1043d384e0b699fcb114694a5d8e1f51784.dif

[PATCH] D75229: Add signal-in-multithreaded-program check

abelkocsis created this revision. abelkocsis added reviewers: aaron.ballman, alexfh, hokein, jfb. abelkocsis added projects: clang, clang-tools-extra. Herald added subscribers: cfe-commits, mgehre, dexonsmith, mgorny. According to https://wiki.sei.cmu.edu/confluence/display/c/CON37-C.+Do+not+call

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

gamesh411 added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:697-699 + // The behavior is undefined if the value of the argument is not + // representable as unsigned char or is not equal to EOF. See e.g. C99 + // 7

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

balazske added a comment. It may be useful to make a "macro value map" kind of object. Some macros can be added to it as a string, and it is possible to lookup for an `Expr` if one of the added macros is used there. This can be done by checking the concrete (numeric) value of the `Expr` and com

[PATCH] D75230: [clangd] Get rid of lexer usage in ObjCLocalizeStringLiteral tweak

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D75230 Files: clang-tools-extra/clangd/

[clang] 8c26f42 - [clang, ARM, MVE] Remove redundant #includes in test file.

Author: Simon Tatham Date: 2020-02-27T09:39:35Z New Revision: 8c26f42fe90e3f8612d2f57a3c9c5e7fcff5e91e URL: https://github.com/llvm/llvm-project/commit/8c26f42fe90e3f8612d2f57a3c9c5e7fcff5e91e DIFF: https://github.com/llvm/llvm-project/commit/8c26f42fe90e3f8612d2f57a3c9c5e7fcff5e91e.diff LOG:

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

balazske added a comment. something like this: class MacroUsageDetector { public: void addMacroName(StringRef MName); bool isMacroUsed(StringRef MName, Expr *E, ???); APSInt getMacroValue(StringRef MName); }; Or one that handles a single macro? Repository: rG LLVM Github Mo

[PATCH] D74973: [analyzer] StdLibraryFunctionsChecker refactor w/ inheritance

gamesh411 added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:151 + + using ValueConstraintPtr = std::shared_ptr; + /// The complete list of constraints that defines a single branch. martong wrote: > Note here, we

[PATCH] D75125: [Docs][OpenCL] Release 10.0 notes for OpenCL

Anastasia added a comment. @hans, what is the current process for committing to the release branch? Would you be able to commit this or would you prefer that I commit myself? Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75125/new/ https://reviews.llvm.org/D75125 ___

[PATCH] D75125: [Docs][OpenCL] Release 10.0 notes for OpenCL

Anastasia added a comment. > Thanks for writing notes! Go ahead and push directly to the branch when > you're ready. Sorry. Missed this somehow! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75125/new/ https://reviews.llvm.org/D75125 ___

[clang] 548e540 - [clang-format] Handle commas in [] in C#

Author: Jonathan Coe Date: 2020-02-27T11:49:30Z New Revision: 548e540d2ced9f5a596e0433f544c560a842a6a7 URL: https://github.com/llvm/llvm-project/commit/548e540d2ced9f5a596e0433f544c560a842a6a7 DIFF: https://github.com/llvm/llvm-project/commit/548e540d2ced9f5a596e0433f544c560a842a6a7.diff LOG:

[PATCH] D75125: [Docs][OpenCL] Release 10.0 notes for OpenCL

hans added a comment. In D75125#1895060 , @Anastasia wrote: > @hans, what is the current process for committing to the release branch? > Would you be able to commit this or would you prefer that I commit myself? > > Thank you! You can just push it to th

[PATCH] D75068: libclang: Add static build support for Windows

cristian.adam added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75068/new/ https://reviews.llvm.org/D75068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

tnorth added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D74910: [OpenCL] Remove spurious atomic_fetch_min/max builtins

Anastasia added a comment. I would say if we are not aware of any test that this change breaks, let's go ahead and commit this? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74910/new/ https://reviews.llvm.org/D74910 __

[clang] 5122e82 - [driver][darwin] Don't use -platform_version flag by default (PR44813)

Author: Hans Wennborg Date: 2020-02-27T13:48:26+01:00 New Revision: 5122e828701c88f8d53ee881bc68f3904454d154 URL: https://github.com/llvm/llvm-project/commit/5122e828701c88f8d53ee881bc68f3904454d154 DIFF: https://github.com/llvm/llvm-project/commit/5122e828701c88f8d53ee881bc68f3904454d154.diff

[PATCH] D74784: [driver][darwin] Don't use -platform_version flag by default

hans added a comment. In D74784#1894484 , @dmajor wrote: > Thanks! I'm still working on getting commit access, would one of you be able > to submit for me? I've committed as 5122e828701c88f8d53ee881bc68f3904454d154

[PATCH] D75022: clang-format: Extend AllowShortLoopsOnASingleLine to do ... while loops.

mitchell-stellar added a comment. Not that I am aware of. Whoever ends up doing the merge will likely run the necessary tests before committing. If you've run as many as you can, then hopefully all will be fine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75022/new/ https://reviews.

[PATCH] D75163: [analyzer][StreamChecker] Adding precall and refactoring.

Szelethus added a comment. To summarize, we're moving every stream check (illegal call to a stream management function with a null stream, or a closed stream, etc) to `preCall`, and leave only the modeling portions in `evalCall`. Makes sense! You did an amazing job here! I like the new infrastr

[PATCH] D75056: [Driver] Default to -fno-common for all targets

SjoerdMeijer updated this revision to Diff 246917. SjoerdMeijer edited the summary of this revision. SjoerdMeijer added a comment. > Are there any tests remaining that check that with -fcommon, IR generation > creates "common" variables, now that all these tests have been modified? I've added a

[PATCH] D75244: [clang-format] Recognize C# named argument colons as a token type

jbcoe created this revision. jbcoe added a reviewer: krasimir. jbcoe added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. No longer merge 'name' and ':' into a single token. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D75244 F

[PATCH] D75244: [clang-format] Recognize C# named argument colons as a token type

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. This is very nice! Brings the C# handling of the colon closer to other languages. Comment at: clang/lib/Format/TokenAnnotator.cpp:3499 const FormatToken &Left = *Righ

[PATCH] D74387: [SYCL] Do not diagnose use of __float128

Fznamznon added a comment. @rjmccall, Thank you very much for so detailed response, It really helps. I started working on implementation and I have a couple of questions/problems with this particular appoach. > - If `foo` uses `__float128` (whether in its signature or internally), that > is in

[clang] 7ea9a6e - Revert "make -fmodules-codegen and -fmodules-debuginfo work also with PCHs"

Author: Hans Wennborg Date: 2020-02-27T14:33:43+01:00 New Revision: 7ea9a6e0220da36ff2fd1fbc29c2755be23e5166 URL: https://github.com/llvm/llvm-project/commit/7ea9a6e0220da36ff2fd1fbc29c2755be23e5166 DIFF: https://github.com/llvm/llvm-project/commit/7ea9a6e0220da36ff2fd1fbc29c2755be23e5166.diff

[PATCH] D74846: fix -fcodegen-modules code when used with PCH (PR44953)

hans added a comment. I've reverted cbc9d22e49b434b6ceb2eb94b67079d02e0a7b74 on master in 7ea9a6e0220da36ff2fd1fbc29c2755be23e5166 until it can be resolve

[PATCH] D75244: [clang-format] Recognize C# named argument colons as a token type

jbcoe updated this revision to Diff 246924. jbcoe added a comment. Consolidate if blocks following review comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75244/new/ https://reviews.llvm.org/D75244 Files: clang/lib/Format/FormatToken.h clang/lib/Format/FormatTokenLexer.cpp

[clang] 7dfe0cc - [clang-format] Recognize C# named argument colons as a token type

Author: Jonathan Coe Date: 2020-02-27T13:47:29Z New Revision: 7dfe0cc7f5765dc729685a0aa468cdf54a265a11 URL: https://github.com/llvm/llvm-project/commit/7dfe0cc7f5765dc729685a0aa468cdf54a265a11 DIFF: https://github.com/llvm/llvm-project/commit/7dfe0cc7f5765dc729685a0aa468cdf54a265a11.diff LOG:

[clang-tools-extra] aa324c5 - [clangd][NFC] Don't query the index if the rename symbol is function

Author: Haojian Wu Date: 2020-02-27T15:04:51+01:00 New Revision: aa324c5441f229bd1ff07407affeab95740328fe URL: https://github.com/llvm/llvm-project/commit/aa324c5441f229bd1ff07407affeab95740328fe DIFF: https://github.com/llvm/llvm-project/commit/aa324c5441f229bd1ff07407affeab95740328fe.diff LO

[PATCH] D75249: [clangd] Use tokenize instead of raw lexer in SourceCode/lex

kadircet created this revision. kadircet added reviewers: hokein, sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D75249 Files: clang-tools-ext

[PATCH] D74846: fix -fcodegen-modules code when used with PCH (PR44953)

aganea added a comment. Thanks @hans! Nevertheless I think this is a good change and we should push it for 11.0. I was indeed seeing better timings on our end with what @llunak was proposing, we are heavy users of PCH headers (and migrating to modules is not trivial in our case, lots of code br

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

Eugene.Zelenko added a comment. Will be good idea to make callers function list configurable through option. See other checks as example. Comment at: clang-tools-extra/clang-tidy/bugprone/SignalInMultithreadedProgramCheck.cpp:20 +void SignalInMultithreadedProgramCheck::regist

RE: r355698 - Re-fix _lrotl/_lrotr to always take Long, no matter the platform.

Right, the intent was to get this to match Microsoft’s behavior better while still making sense on other platforms. IIRC this was in order to fix a codegen bug due to type mismatches, though I don’t completely remember (as it was nearly a year ago). From: James Y Knight Sent: Wednesday, Febru

[PATCH] D75153: [ThinLTO] Allow usage of all SMT threads in the system

aganea added a comment. If a simpler (more yucky?) patch is needed to fix what @thakis was suggesting in https://reviews.llvm.org/D71775#1891709, and if we don't want this extra new flag, we can also check the CPU brand for "AMD Opteron", and keep the old behavior in that case. Repository:

Re: r329762 - Introduce a new builtin, __builtin_dump_struct, that is useful for dumping structure contents at runtime in circumstances where debuggers may not be easily available (such as in kernel w

On Wed, Feb 26, 2020 at 1:48 PM Aaron Ballman wrote: > > On Tue, Feb 25, 2020 at 4:36 PM Richard Smith wrote: > > > > It looks like we forgot to document this builtin. Can some documentation be > > added? > > If Paul doesn't get to it first, I can try to stub some out. I added some basic docume

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

erichkeane added a comment. Ping! I believe this should be ready for review and does everything requested in the CFEDev conversation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73967/new/ https://reviews.llvm.org/D73967 ___ cfe-commits

[clang] f35f59a - Adding some documentation for __builtin_dump_struct.

Author: Aaron Ballman Date: 2020-02-27T09:30:17-05:00 New Revision: f35f59ac36db3c5fe636f6899d98ac690126a4f7 URL: https://github.com/llvm/llvm-project/commit/f35f59ac36db3c5fe636f6899d98ac690126a4f7 DIFF: https://github.com/llvm/llvm-project/commit/f35f59ac36db3c5fe636f6899d98ac690126a4f7.diff

[PATCH] D75251: [clangd] Move the format rename edits from clangdserver to rename API, NFC.

hokein created this revision. hokein added a reviewer: kbobyrev. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. would make the rename API more nature, respecting the parameter Options.WantFormat. Repository: rG LLVM Gi

[PATCH] D75057: Syndicate, test and fix base64 implementation

serge-sans-paille added a comment. Up? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75057/new/ https://reviews.llvm.org/D75057 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D75107: [clang-tidy] hicpp-signed-bitwise IgnorePositiveIntegerLiterals now partially recursive

aaron.ballman added a comment. What about bit shifting operations? e.g., `~(1 << 2)` or `8 >> (1 << 2)` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75107/new/ https://reviews.llvm.org/D75107 ___ cfe-

[PATCH] D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp:399-400 +Check->diag(MoveArgLoc, +"std::move of the const expression has no effect; " +"remove std::move() or make the variable non-con

[PATCH] D75252: [ARM,MVE] Add ACLE intrinsics for VQMOV[U]N family.

simon_tatham created this revision. simon_tatham added reviewers: MarkMurrayARM, dmgreen, miyuki, ostannard. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. These instructions work like VMOVN (narrowing a vector of wide values to h

[PATCH] D75254: [ARM,MVE] Add ACLE intrinsics for VCVT.F32.F16 family.

simon_tatham created this revision. simon_tatham added reviewers: MarkMurrayARM, dmgreen, miyuki, ostannard. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. These instructions make a vector of `<4 x float>` by widening every other

[PATCH] D75255: [ARM,MVE] Add ACLE intrinsics for VCVT[ANPM] family.

simon_tatham created this revision. simon_tatham added reviewers: MarkMurrayARM, dmgreen, miyuki, ostannard. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. These instructions convert a vector of floats to a vector of integers of t

[clang] 4569b3a - Revert "Devirtualize a call on alloca without waiting for post inline cleanup and next"

Author: Kirill Bobyrev Date: 2020-02-27T15:58:39+01:00 New Revision: 4569b3a86f8a4b1b8ad28fe2321f936f9d7ffd43 URL: https://github.com/llvm/llvm-project/commit/4569b3a86f8a4b1b8ad28fe2321f936f9d7ffd43 DIFF: https://github.com/llvm/llvm-project/commit/4569b3a86f8a4b1b8ad28fe2321f936f9d7ffd43.diff

[PATCH] D75159: [clang-tidy] Fix PR#37210 'Out-of-class template constructor only half-fixed with modernize-pass-by-value'

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75159/new/ https://reviews.llvm.org/D75159 _

Re: [clang] 4569b3a - Revert "Devirtualize a call on alloca without waiting for post inline cleanup and next"

Is there a reproducer in progress? On Thu, Feb 27, 2020 at 5:59 PM Kirill Bobyrev via cfe-commits wrote: > > > Author: Kirill Bobyrev > Date: 2020-02-27T15:58:39+01:00 > New Revision: 4569b3a86f8a4b1b8ad28fe2321f936f9d7ffd43 > > URL: > https://github.com/llvm/llvm-project/commit/4569b3a86f8a4b1b

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

mibintc added a comment. Added a couple inline comments Comment at: clang/docs/ReleaseNotes.rst:62 + permit non-power of 2 integers, exposing the LLVM integer types. Since a major + motivating use case for these types is to limit 'bit' useage, these types don't + automatic

[PATCH] D31338: Move ParsedAttrInfos into a registry and point to one in ParsedAttr

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I like this approach much better, thank you for working on it! LGTM Comment at: clang/include/clang/Basic/AttributeCommonInfo.h:140 + /// will be normalized to

Re: [clang] 4569b3a - Revert "Devirtualize a call on alloca without waiting for post inline cleanup and next"

I've messaged the author internally and pointed to the failing targets. On Thu, Feb 27, 2020 at 4:04 PM Roman Lebedev wrote: > Is there a reproducer in progress? > > On Thu, Feb 27, 2020 at 5:59 PM Kirill Bobyrev via cfe-commits > wrote: > > > > > > Author: Kirill Bobyrev > > Date: 2020-02-27T1

[PATCH] D71775: [ThreadPool] On Windows, extend usage to all CPU sockets and all NUMA groups

aganea marked an inline comment as done. aganea added inline comments. Comment at: llvm/lib/Support/Threading.cpp:94 + // uselessly induce more context-switching and cache eviction. + if (!ThreadsRequested || ThreadsRequested > (unsigned)MaxThreadCount) +return MaxThreadCou

[clang] ee1b2e7 - [Hexagon] Do not use init_arrays by default

Author: Krzysztof Parzyszek Date: 2020-02-27T09:16:25-06:00 New Revision: ee1b2e7ded12ef6e11ce35bb9929490ac9e7fa4f URL: https://github.com/llvm/llvm-project/commit/ee1b2e7ded12ef6e11ce35bb9929490ac9e7fa4f DIFF: https://github.com/llvm/llvm-project/commit/ee1b2e7ded12ef6e11ce35bb9929490ac9e7fa4f

[clang] bd97704 - [SYCL] Driver option to select SYCL version

Author: Ruyman Date: 2020-02-27T15:08:42+03:00 New Revision: bd97704eb5a95ecb048ce343c1a4be5d94e5 URL: https://github.com/llvm/llvm-project/commit/bd97704eb5a95ecb048ce343c1a4be5d94e5 DIFF: https://github.com/llvm/llvm-project/commit/bd97704eb5a95ecb048ce343c1a4be5d94e5.diff LOG: [

[PATCH] D75249: [clangd] Use tokenize instead of raw lexer in SourceCode/lex

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/SourceCode.cpp:728 + case Default: +llvm_unreachable("Using and Default handled above."); + } -

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin updated this revision to Diff 246944. DmitryPolukhin added a comment. Fix issue with config inheritance and caching configs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75184/new/ https://reviews.llvm.org/D75184 Files: clang-tool

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

erichkeane marked 2 inline comments as done. erichkeane added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:1215 + /// Return an extended integer type with the specified underlying type and bit + /// count. mibintc wrote: > Is this commen

[PATCH] D75259: [clangd] Get rid of unnecssary source transformations in locateMacroAt

kadircet created this revision. kadircet added reviewers: sammccall, hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. All callers are already passing spelling locations to locateMacroAt. Also there's no point at lo

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

erichkeane updated this revision to Diff 246947. erichkeane added a comment. @mibintc 's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73967/new/ https://reviews.llvm.org/D73967 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst clang/include/clang/AST/

[clang] 00072c0 - [WebAssembly] Mangle the argc/argv `main` as `__wasm_argc_argv`.

Author: Dan Gohman Date: 2020-02-27T07:55:36-08:00 New Revision: 00072c08c75050ae2c835b7bb0e505475dbcd7b9 URL: https://github.com/llvm/llvm-project/commit/00072c08c75050ae2c835b7bb0e505475dbcd7b9 DIFF: https://github.com/llvm/llvm-project/commit/00072c08c75050ae2c835b7bb0e505475dbcd7b9.diff LO

[PATCH] D75057: Syndicate, test and fix base64 implementation

hokein added a comment. thanks for doing this! didn't look into details yet. Could you explain what was the bug in the previous code? since this patch contains some refactoring changes, it is not quite straightforward to spot it. Comment at: llvm/unittests/Support/Base64Test.

[PATCH] D75139: [hexagon] Pickup the default crt and libs when the musl target is selected

bcain accepted this revision. bcain added a comment. This revision is now accepted and ready to land. Herald added a subscriber: ormris. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75139/new/ https://reviews.llvm.org/D75139 __

[PATCH] D75261: [clang-format] Recognize C# nullable types

jbcoe created this revision. jbcoe added a reviewer: krasimir. jbcoe added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. Do not confuse C# nullable types with conditional expressions. Do not put a space before the `?` in `[access-modifier] Type? v

[PATCH] D75163: [analyzer][StreamChecker] Adding precall and refactoring.

balazske updated this revision to Diff 246955. balazske added a comment. - Improved comments in the code. - Added function to get stream arg. - Changed error messages. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75163/new/ https://reviews.llvm.or

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

ABataev added inline comments. Comment at: clang/include/clang/AST/Type.h:6196 +// A fixed int type of a specified bitwidth. +class ExtIntType : public Type, public llvm::FoldingSetNode { Use `///` style Comment at: clang/include/clang/AST/Ty

[PATCH] D74910: [OpenCL] Remove spurious atomic_fetch_min/max builtins

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74910/new/ https://reviews.llvm.org/D74910 ___ cfe-c

[PATCH] D75163: [analyzer][StreamChecker] Adding precall and refactoring.

balazske marked 10 inline comments as done. balazske added a comment. Error messages are now in similar form as the null stream pointer case. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:76-92 + {{"fopen"}, {{}, &StreamChecker::evalFopen, ArgNone}}, +

[PATCH] D31342: Add ParsedAttrInfo::handleDeclAttribute

john.brawn marked 2 inline comments as done. john.brawn added inline comments. Comment at: clang/docs/ClangPlugins.rst:74 + + class ExampleAttrInfo : public ParsedAttrInfo { + public: aaron.ballman wrote: > We should be documenting the fields of `ParsedAttrInfo

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

thakis added a comment. This landed here: https://github.com/llvm/llvm-project/commit/bd97704eb5a95ecb048ce343c1a4be5d94e5 It broke tests on mac: http://45.33.8.238/mac/9011/step_7.txt Please take a look, and if it takes a while please revert while you investigate. Repository: rG LLVM G

[Diffusion] rG396b7253944e: [OpenMP][Opt] Combine `struct ident_t*` during deduplication

aprantl added inline comments. BRANCHES master /clang/test/OpenMP/PR44893.c:3 A test with no CHECK lines also passes if you symlink /bin/true to clang :-) It also doesn't indicate what is being relevant and when it comes to maintaining / updating the test we won't know what is important to ke

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

erichkeane updated this revision to Diff 246958. erichkeane marked 8 inline comments as done. erichkeane added a comment. Changes requested by @ABataev CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73967/new/ https://reviews.llvm.org/D73967 Files: clang/docs/LanguageExtensions.rst

[clang] 740ed61 - Revert "[SYCL] Driver option to select SYCL version"

Author: Alexey Bader Date: 2020-02-27T16:23:54+03:00 New Revision: 740ed617f7d4d16e7883636c5eff994f8be7eba4 URL: https://github.com/llvm/llvm-project/commit/740ed617f7d4d16e7883636c5eff994f8be7eba4 DIFF: https://github.com/llvm/llvm-project/commit/740ed617f7d4d16e7883636c5eff994f8be7eba4.diff

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader added a comment. In D72857#1895625 , @thakis wrote: > This landed here: > https://github.com/llvm/llvm-project/commit/bd97704eb5a95ecb048ce343c1a4be5d94e5 > > It broke tests on mac: http://45.33.8.238/mac/9011/step_7.txt > > Please take a look,

[PATCH] D75125: [Docs][OpenCL] Release 10.0 notes for OpenCL

svenvh closed this revision. svenvh added a comment. Committed in e5cb70267e7 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75125/new/ https://reviews.llvm.org/D75125 _

[PATCH] D75261: [clang-format] Recognize C# nullable types

jbcoe marked an inline comment as done. jbcoe added inline comments. Comment at: clang/unittests/Format/FormatTestCSharp.cpp:178 verifyFormat( - "public Person(string firstName, string lastName, int? age=null)"); + "public Person(string firstName, string lastName, in

[PATCH] D75130: Remove BinaryOperator::CreateFNeg

simoll updated this revision to Diff 246974. simoll added a comment. - rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75130/new/ https://reviews.llvm.org/D75130 Files: clang/test/CodeGen/complex-math.c llvm/include/llvm/IR/InstrTypes.h

[clang] ddd1127 - Remove BinaryOperator::CreateFNeg

Author: Simon Moll Date: 2020-02-27T09:06:03-08:00 New Revision: ddd11273d9d0807e25a34181e5978e3307d78dc2 URL: https://github.com/llvm/llvm-project/commit/ddd11273d9d0807e25a34181e5978e3307d78dc2 DIFF: https://github.com/llvm/llvm-project/commit/ddd11273d9d0807e25a34181e5978e3307d78dc2.diff LO

[PATCH] D74846: fix -fcodegen-modules code when used with PCH (PR44953)

hans added a comment. In D74846#1895319 , @aganea wrote: > Thanks @hans! Nevertheless I think this is a good change and we should push > it for 11.0. I was indeed seeing better timings on our end with what @llunak > was proposing, we are heavy users of P

[PATCH] D75271: [Analyzer][NFC] Add AnalyzerOptions parameter to shouldRegisterXXX() functions

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: Szelethus, NoQ. baloghadamsoftware added a project: clang. Herald added subscribers: martong, steakhal, phosek, Charusso, gamesh411, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Herald

[clang] 75d4d4b - Add an attribute registry so plugins can add attributes

Author: John Brawn Date: 2020-02-27T17:23:16Z New Revision: 75d4d4bd028f6a5f24ef41dbbc45bed65b2305cf URL: https://github.com/llvm/llvm-project/commit/75d4d4bd028f6a5f24ef41dbbc45bed65b2305cf DIFF: https://github.com/llvm/llvm-project/commit/75d4d4bd028f6a5f24ef41dbbc45bed65b2305cf.diff LOG: Ad

[PATCH] D31342: Add ParsedAttrInfo::handleDeclAttribute

aaron.ballman added a reviewer: rsmith. aaron.ballman added a subscriber: rsmith. aaron.ballman added a comment. Adding @rsmith for questions about stability guarantees. Comment at: clang/docs/ClangPlugins.rst:74 + + class ExampleAttrInfo : public ParsedAttrInfo { + public: -

[PATCH] D75271: [Analyzer][NFC] Add AnalyzerOptions parameter to shouldRegisterXXX() functions

Charusso added a comment. I am so sorry to mention, but we need the `AnalysisManager` to pass around which manages the analysis, therefore it knows both the `LangOptions` and `AnalyzerOptions`. Also this entire callback should be removed ideally: it has to be a virtual function defaulting to `r

[PATCH] D31342: Add ParsedAttrInfo::handleDeclAttribute

john.brawn updated this revision to Diff 246987. john.brawn added a comment. Update based on review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31342/new/ https://reviews.llvm.org/D31342 Files: clang/docs/ClangPlugins.rst clang/docs/InternalsManual.rst clang/include/c

[PATCH] D69591: Devirtualize a call on alloca without waiting for post inline cleanup and next DevirtSCCRepeatedPass iteration.

yamauchi added a comment. This was reverted due to some internal compilation crashes as https://github.com/llvm/llvm-project/commit/4569b3a86f8a4b1b8ad28fe2321f936f9d7ffd43 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69591/new/ https://reviews.l

[PATCH] D75271: [Analyzer][NFC] Add AnalyzerOptions parameter to shouldRegisterXXX() functions

Charusso added a comment. PS: The `CheckerManager` also could serve this behavior as `registerXXX()` already passing around that manager, but I believe the `AnalysisManager` supposed to manage the analysis. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D66564: [clang-tidy] new altera struct pack align check

aaron.ballman added a comment. Are you aware of plans that you or others have for adding additional checks to the new `altera` module? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66564/new/ https://reviews.llvm.org/D66564 ___ cfe-commits

[PATCH] D31343: Add an attribute plugin example

john.brawn updated this revision to Diff 246989. john.brawn marked an inline comment as done. john.brawn added a comment. Update based on review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31343/new/ https://reviews.llvm.org/D31343 Files: clang/examples/Attribute/Attribut

[PATCH] D75171: [Analyzer] Fix for incorrect use of container and iterator checkers

baloghadamsoftware added a comment. In D75171#1893811 , @Szelethus wrote: > Im sorry, i though we talked about internal code and we're stuck with the > checker interface -- this should definitely be solved by changing the > parameter of the `shouldRegist

[PATCH] D31343: Add an attribute plugin example

john.brawn marked 5 inline comments as done. john.brawn added inline comments. Comment at: clang/examples/Attribute/Attribute.cpp:25 +struct ExampleAttrInfo : public ParsedAttrInfo { + ExampleAttrInfo() { +// Set the kind to NoSemaHandlerAttribute to make sure clang doesn't

[PATCH] D75176: [clangd] Get rid of getBeginningOfIdentifier helper

This revision was automatically updated to reflect the committed changes. kadircet marked 2 inline comments as done. Closed by commit rG2bb7774ddf00: [clangd] Get rid of getBeginningOfIdentifier helper (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D75176?vs=246729&id

[PATCH] D75271: [Analyzer][NFC] Add AnalyzerOptions parameter to shouldRegisterXXX() functions

baloghadamsoftware added a comment. It is impossible to use `CheckerManager` as parameter for `shouldRegisterXXX()` because `CheckerRegistry` does not have it. If I add `CheckerManager` to `CheckerRegistry` then the `printXXX()` functions will not work because they do not have `CheckerManager`

[PATCH] D75193: [clangd] Get rid of lexer usage in AST.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rGf31fc1043d38: [clangd] Get rid of lexer usage in AST.cpp (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75193/new/ https://reviews.ll

[PATCH] D75182: [clang-format] Handle commas in [] in C#

This revision was automatically updated to reflect the committed changes. Closed by commit rG548e540d2ced: [clang-format] Handle commas in [] in C# (authored by Jonathan Coe ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75182/new

[PATCH] D66564: [clang-tidy] new altera struct pack align check

Eugene.Zelenko added a comment. In D66564#1895916 , @aaron.ballman wrote: > Are you aware of plans that you or others have for adding additional checks > to the new `altera` module? There are several patches for `altera` module already. CHANGES SINCE

[PATCH] D74784: [driver][darwin] Don't use -platform_version flag by default

This revision was automatically updated to reflect the committed changes. Closed by commit rG5122e828701c: [driver][darwin] Don't use -platform_version flag by default (PR44813) (authored by hans). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74784/

[PATCH] D75244: [clang-format] Recognize C# named argument colons as a token type

This revision was automatically updated to reflect the committed changes. Closed by commit rG7dfe0cc7f576: [clang-format] Recognize C# named argument colons as a token type (authored by Jonathan Coe ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd97704e: [SYCL] Driver option to select SYCL version (authored by Ruyk, committed by bader). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72857/new/ h

[PATCH] D70700: [WebAssembly] Mangle the argc/argv `main` as `__main_argc_argv`

This revision was automatically updated to reflect the committed changes. Closed by commit rG00072c08c750: [WebAssembly] Mangle the argc/argv `main` as `__wasm_argc_argv`. (authored by sunfishcode). Changed prior to commit: https://reviews.llvm.org/D70700?vs=234942&id=247011#toc Repository:

[PATCH] D75130: Remove BinaryOperator::CreateFNeg

This revision was automatically updated to reflect the committed changes. Closed by commit rGddd11273d9d0: Remove BinaryOperator::CreateFNeg (authored by simoll). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75130/new/ https://reviews.llvm.org/D751

[PATCH] D31338: Move ParsedAttrInfos into a registry and point to one in ParsedAttr

This revision was automatically updated to reflect the committed changes. Closed by commit rG75d4d4bd028f: Add an attribute registry so plugins can add attributes (authored by john.brawn). Changed prior to commit: https://reviews.llvm.org/D31338?vs=246763&id=247014#toc Repository: rG LLVM Gi

[PATCH] D75139: [hexagon] Pickup the default crt and libs when the musl target is selected

sidneym marked an inline comment as done. sidneym added inline comments. Comment at: clang/lib/Driver/ToolChains/Hexagon.cpp:290 +} +if (!Args.hasArg(options::OPT_shared)) + CmdArgs.push_back("-dynamic-linker=/lib/ld-musl-hexagon.so.1"); the default

  1   2   3   >