[PATCH] D75811: [CUDA] Choose default architecture based on CUDA installation

tambre added inline comments. Comment at: clang/lib/Driver/Driver.cpp:2579 + if (Version == CudaVersion::UNKNOWN) { +C.getDriver().Diag(clang::diag::err_drv_cuda_unknown_version) +<< VersionString; This error is hit when simply running `c

[PATCH] D75700: [NFC] Let mangler accept GlobalDecl

This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG29e1a16be821: [NFC] Let mangler accept GlobalDecl (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[clang] 29e1a16 - [NFC] Let mangler accept GlobalDecl

Author: Yaxun (Sam) Liu Date: 2020-03-07T23:51:41-05:00 New Revision: 29e1a16be8216066d1ed733a763a749aed13ff47 URL: https://github.com/llvm/llvm-project/commit/29e1a16be8216066d1ed733a763a749aed13ff47 DIFF: https://github.com/llvm/llvm-project/commit/29e1a16be8216066d1ed733a763a749aed13ff47.dif

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 updated this revision to Diff 248975. MarcusJohnson91 added a comment. Updated the release notes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75791/new/ https://reviews.llvm.org/D75791 Files: clang/docs/ReleaseNotes.rst Index: clang/docs/ReleaseNotes.rst ==

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 updated this revision to Diff 248974. MarcusJohnson91 added a comment. Removed the debugging comments I added to FormatTest.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75791/new/ https://reviews.llvm.org/D75791 Files: clang/include/clang/Format/Format.h clang/

[PATCH] D72635: Allow arbitrary capability name in Thread Safety Analysis

aaronpuchert added a comment. @aaron.ballman, I've just noted that one of the `-Wthread-safety-attributes` warnings says > //A// attribute can only be applied in a context annotated with > ‘capability(“mutex”)’ a

[PATCH] D75758: [Sema] Add -Wpointer-to-enum-cast and -Wvoid-pointer-to-enum-cast

MaskRay added inline comments. Comment at: clang/lib/Sema/SemaCast.cpp:2783 +Diag = diag::ext_ms_pointer_to_int_cast; + else if (SrcType->isVoidPointerType()) +if (DestType->isEnumeralType()) A ternary operator is better here. I'll fix it.

[PATCH] D75758: [Sema] Add -Wpointer-to-enum-cast and -Wvoid-pointer-to-enum-cast

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a41b31fcdfc: [Sema] Add -Wpointer-to-enum-cast and -Wvoid-pointer-to-enum-cast (authored by nathanchance, committed by MaskRay). Changed prior to commit: https://reviews.llvm.org/D75758?vs=248824&id=24

[clang] 2a41b31 - [Sema] Add -Wpointer-to-enum-cast and -Wvoid-pointer-to-enum-cast

Author: Nathan Chancellor Date: 2020-03-07T16:43:39-08:00 New Revision: 2a41b31fcdfcb67ab7038fc2ffb606fd50b83a84 URL: https://github.com/llvm/llvm-project/commit/2a41b31fcdfcb67ab7038fc2ffb606fd50b83a84 DIFF: https://github.com/llvm/llvm-project/commit/2a41b31fcdfcb67ab7038fc2ffb606fd50b83a84.d

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza marked an inline comment as done. lanza added a comment. > Adding some more knowledgeable reviewers for comments on your RFC. I pointed > out a few minor nits, but I'll hold off on a technical review until the > ObjC-specific details are worked out and there is buy-in on the feature. Than

[PATCH] D66094: [CodeGen] Emit destructor calls for non-trivial C structs returned by function calls and loaded from volatile objects

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGExprAgg.cpp:822 +Dest.setExternallyDestructed(); + } + I don't think `setExternallyDestructed` can be used to communicate outwards like this; the code isn't set up to just do modificati

[clang] 2b17438 - [Index/USRGeneration] Make sure that ObjC properties in categories also get namescoped properly for USR generation

Author: Argyrios Kyrtzidis Date: 2020-03-07T15:07:37-08:00 New Revision: 2b17438a92ea1ea178d9e14219a8e6ba01d4f04d URL: https://github.com/llvm/llvm-project/commit/2b17438a92ea1ea178d9e14219a8e6ba01d4f04d DIFF: https://github.com/llvm/llvm-project/commit/2b17438a92ea1ea178d9e14219a8e6ba01d4f04d.

[PATCH] D75758: [Sema] Add -Wpointer-to-enum-cast and -Wvoid-pointer-to-enum-cast

nathanchance marked an inline comment as done. nathanchance added a comment. Thanks for the review and accepting. I do not have commit rights, would you mind doing that on my behalf? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75758/new/ https:/

[PATCH] D64464: [CodeGen] Emit destructor calls to destruct compound literals

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGBlocks.cpp:869 + if (auto *BD = C.dyn_cast()) +enterBlockScope(*this, BD); } I wonder if we could just switch blocks to the same thing. Comment at: clang/lib/Sema/S

[PATCH] D75700: [NFC] Let mangler accept GlobalDecl

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/AST/Expr.cpp:693 else - MC->mangleName(ND, Out); + GD = GlobalDecl(ND); +MC->mangleName(GD, Out); rjmccall wrote: > This will need an e

[PATCH] D75210: [Attr] Allow ParsedAttr to be constructor for any Attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from the issue with keeping the comment up to date from Erich (but please only land this once D75779 is approved, as that's what carr

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thank you for working on this, this LGTM! If you wanted a follow-up patch beyond adding semantic support for the `inline` keyword, I think it might make sense to investigate divo

[PATCH] D75701: Initialize IsSurrogate

This revision was automatically updated to reflect the committed changes. Closed by commit rGa5704f92b835: [Sema] Initialize IsSurrogate (authored by espindola, committed by MaskRay). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D75701: Initialize IsSurrogate

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Confirmed that the patch fixes `valgrind clang -cc1 -S -std=c++17 -o native-stack.s native-stack.ii` for a -O0 -g Debug build. `-DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=on` does

[PATCH] D75803: [clang-tidy] [NFC] Remove unnecessary matchers

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75803/new/ https://reviews.llvm.org/D75803

[PATCH] D75800: [ASTMatchers] adds isComparisonOperator to BinaryOperator and CXXOperatorCallExpr

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75800/new/ https://reviews.llvm.org/D75800

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

rjmccall added a comment. I'm fine with people developing a proposal for this openly, but it needs to be said that language changes cannot just be made in open-source; they have to go through the official language review process, which for Objective-C is an internal committee within Apple. The

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

rjmccall added inline comments. Comment at: clang/include/clang/Sema/Sema.h:1470 +/// diagnostics should be emitted. +SmallVector DeclsToCheckForDeferredDiags; + This needs to be saved and restored in modules / PCH. Comment at: clang/li

[clang] a5704f9 - [Sema] Initialize IsSurrogate

Author: Rafael Ávila de Espíndola Date: 2020-03-07T12:24:35-08:00 New Revision: a5704f92b835d1810d83a223f70dfe6c92a34c03 URL: https://github.com/llvm/llvm-project/commit/a5704f92b835d1810d83a223f70dfe6c92a34c03 DIFF: https://github.com/llvm/llvm-project/commit/a5704f92b835d1810d83a223f70dfe6c92

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

rjmccall added a comment. In D72841#1908084 , @mibintc wrote: > @rjmccall suggested that I needed to remove FPOptions from the Stmt class > since the sizeof assertion failed. I moved that information into the relevant > expression nodes and fixed a few s

[PATCH] D75811: [CUDA] Choose default architecture based on CUDA installation

tambre updated this revision to Diff 248949. tambre added a comment. Add missing error message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75811/new/ https://reviews.llvm.org/D75811 Files: clang/include/clang/Basic/Cuda.h clang/include/clang

[PATCH] D58164: Block+lambda: allow reference capture

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, I think this is a reasonable fix. If @rsmith has thoughts about this, I guess they'll have to happen post-review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75700: [NFC] Let mangler accept GlobalDecl

rjmccall accepted this revision. rjmccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/ItaniumMangle.cpp:1563 + else +GD = GlobalDecl(dyn_cast(DC)); + return GD; rjmccall wrote: > `cast`? But I'm not sur

[clang] 118b057 - [SYCL] Driver option to select SYCL version

Author: Ruyman Date: 2020-03-07T18:28:54+03:00 New Revision: 118b057f1268d1789e40ffceb214e73772df04f4 URL: https://github.com/llvm/llvm-project/commit/118b057f1268d1789e40ffceb214e73772df04f4 DIFF: https://github.com/llvm/llvm-project/commit/118b057f1268d1789e40ffceb214e73772df04f4.diff LOG: [

[PATCH] D75779: [OpenMP] `omp begin/end declare variant` - part 2, semantic analysis

jdoerfert added a comment. There will be an update later today or tomorrow, I am making the actual target offloading CUDA interoperability "work" right now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75779/new/ https://reviews.llvm.org/D75779

[PATCH] D75811: [CUDA] Choose default architecture based on CUDA installation

tambre added inline comments. Comment at: clang/lib/Driver/Driver.cpp:642 + *this, CudaTriple, *HostTC, C.getInputArgs(), OFK); + C.getArgs().AddJoinedArg( + nullptr, getOpts().getOption(options::OPT_cuda_version_EQ), This isn't very pr

[PATCH] D75811: [CUDA] Choose default architecture based on CUDA installation

tambre created this revision. tambre added reviewers: tra, jlebar. Herald added a project: clang. Herald added a subscriber: cfe-commits. tambre added inline comments. Comment at: clang/lib/Driver/Driver.cpp:642 + *this, CudaTriple, *HostTC, C.getInputArgs(), OFK); +

[clang] a4e71f0 - Assume ieee behavior without denormal-fp-math attribute

Author: Matt Arsenault Date: 2020-03-07T12:10:56-05:00 New Revision: a4e71f01c08fbaeaccfe3e11cc08790432cc7e45 URL: https://github.com/llvm/llvm-project/commit/a4e71f01c08fbaeaccfe3e11cc08790432cc7e45 DIFF: https://github.com/llvm/llvm-project/commit/a4e71f01c08fbaeaccfe3e11cc08790432cc7e45.diff

[PATCH] D75209: [OPENMP][NVPTX]Fix PR45003: add support for complex functions.

jdoerfert added a comment. In D75209#1910047 , @ABataev wrote: > In D75209#1909976 , @jdoerfert wrote: > > > I am unsure we need this with the proper math support. Sema patch for that > > is going for review today.

[PATCH] D75678: [analyzer] Skip analysis of inherited ctor as top-level function

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:511 + // + // Also, we cannot model the parameters. CXXInheritedCtorInitExpr doesn't + // take arguments and doesn't model parameter initialization because there is I

[PATCH] D75788: [WIP][OpenMP] Reuse CUDA wrappers in `nvptx` target regions.

jdoerfert updated this revision to Diff 248937. jdoerfert added a comment. Add complex test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75788/new/ https://reviews.llvm.org/D75788 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/lib/He

[PATCH] D75678: [analyzer] Skip analysis of inherited ctor as top-level function

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks great, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75678/new/ https://reviews.llvm.org/D75678 _

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 added a comment. In D75791#1911133 , @MyDeveloperDay wrote: > you need documentation and release note changes too The comments were only for testing, I'll remove them. The tests had to change because the behavior has changed slightly.

Re: [clang] d052a57 - [c++2a] Allow comparison functions to be explicitly defaulted.

Following this commit, the error recovery for invalid cases that explicitly define (out-of-line) a member function template as deleted and attempts to instantiate said function appears broken. :4:35: error: deleted definition must be first declaration template void A::f() = delete;

[PATCH] D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts

Quuxplusone added a comment. Anyway, I still don't see the point of this patch. It seems like you're just duplicating the work of `performance-move-const-arg`. People who want to be shown notes about moves-of-const-args should just enable that check instead. CHANGES SINCE LAST ACTION https:/

[PATCH] D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts

Quuxplusone added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-use-after-move.cpp:342 + // CHECK-NOTES: [[@LINE-5]]:20: note: variable 'a' implicitly captured const here }; } zinovy.nis wrote: > aaron.ballman wro

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added a comment. you need documentation and release note changes too Comment at: clang/unittests/Format/FormatTest.cpp:31 +class FormatTest +: public ::testing::Test { // FormatTest is a Fixture, data is reused protected: is this comment nec

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1088 if (FormatTok->Tok.is(tok::l_brace)) { -if (Style.BraceWrapping.AfterExternBlock) { - parseBlock(/*MustBeDeclaration=*/true); -} else { +if (Sty

[PATCH] D75806: [CUDA] Add CUDA 10.2 detection

tambre created this revision. tambre added reviewers: tra, jlebar. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D75806 Files: clang/include/clang/Basic/Cuda.h clang/lib/Basic/Cuda.cpp clang/lib/Driver/

[PATCH] D68578: [HIP] Fix device stub name

yaxunl updated this revision to Diff 248927. yaxunl added a comment. update patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68578/new/ https://reviews.llvm.org/D68578 Files: clang/include/clang/AST/GlobalDecl.h clang/lib/AST/Expr.cpp clang/lib/AST/ItaniumMangle.cpp clang/li

[PATCH] D75700: [NFC] Let mangler accept GlobalDecl

yaxunl updated this revision to Diff 248926. yaxunl marked 6 inline comments as done. yaxunl added a comment. revised by John's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75700/new/ https://reviews.llvm.org/D75700 Files: clang/include/clang/AST/GlobalDecl.h clang/inclu

[PATCH] D75805: Make malign-double effective only for x86

kamleshbhalui created this revision. kamleshbhalui added a reviewer: rnk. kamleshbhalui added a project: clang. Herald added a subscriber: cfe-commits. Making -malign-double effective only for x86. Fixes. https://bugs.llvm.org/show_bug.cgi?id=45136 Repository: rG LLVM Github Monorepo https:/

[PATCH] D75800: [ASTMatchers] adds isComparisonOperator to BinaryOperator and CXXOperatorCallExpr

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp:570 const auto RelationalExpr = ignoringParenImpCasts(binaryOperator( - isComparisonOperator(), expr().bind(Id), + ma

[PATCH] D75803: [clang-tidy] [NFC] Remove unnecessary matchers

njames93 created this revision. Herald added subscribers: cfe-commits, kbarton, xazax.hun, nemanjai. Herald added a project: clang. njames93 added a parent revision: D75800: [ASTMatchers] adds isComparisonOperator to BinaryOperator and CXXOperatorCallExpr. Herald added a subscriber: wuzish. njames

[PATCH] D75749: [clang-tidy] extend bugprone-signed-char-misuse check.

ztamas updated this revision to Diff 248917. ztamas added a comment. Update code based on reviewer comments. - Update docs: comparison -> equality/inequality comparison. - Use hasAnyOperatorName - Plus fix a typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D75749: [clang-tidy] extend bugprone-signed-char-misuse check.

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignedCharMisuseCheck.cpp:97 + const auto CompareOperator = + expr(binaryOperator(anyOf(hasOperatorName("=="), hasOperatorName("!=")), + anyOf(allOf(hasLHS(SignedCharC

[PATCH] D75800: [ASTMatchers] adds isComparisonOperator to BinaryOperator and CXXOperatorCallExpr

njames93 created this revision. njames93 added reviewers: aaron.ballman, gribozavr2. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D75800 Files: clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cp

[PATCH] D75749: [clang-tidy] extend bugprone-signed-char-misuse check.

ztamas updated this revision to Diff 248912. ztamas added a comment. Use quotes in warning message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75749/new/ https://reviews.llvm.org/D75749 Files: clang-tools-extra/clang-tidy/bugprone/SignedCharM

[PATCH] D75749: [clang-tidy] extend bugprone-signed-char-misuse check.

ztamas marked an inline comment as done. ztamas added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignedCharMisuseCheck.cpp:97 + const auto CompareOperator = + expr(binaryOperator(anyOf(hasOperatorName("=="), hasOperatorName("!=")), +

[PATCH] D75749: [clang-tidy] extend bugprone-signed-char-misuse check.

ztamas updated this revision to Diff 248909. ztamas added a comment. One more unneeded allOf and clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75749/new/ https://reviews.llvm.org/D75749 Files: clang-tools-extra/clang-tidy/bugprone/S

[PATCH] D75749: [clang-tidy] extend bugprone-signed-char-misuse check.

ztamas updated this revision to Diff 248907. ztamas added a comment. Fix pre-merge check error Plus remove unneeded "no warning" comments and add a missing quote mark in docs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75749/new/ https://review

[PATCH] D75749: [clang-tidy] extend bugprone-signed-char-misuse check.

ztamas updated this revision to Diff 248908. ztamas added a comment. Changed code based on reviewer comments. - Removed unneeded allOf() - Remove unneeded ';' - Added new line at the end of the file - Moved variable declarations inside if() Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D75749: [clang-tidy] extend bugprone-signed-char-misuse check.

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignedCharMisuseCheck.cpp:74 +void SignedCharMisuseCheck::registerMatchers(MatchFinder *Finder) { + const auto IntegerType = qualType(allOf(isInteger(), unless(isAnyCharacter()), +

[PATCH] D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts

zinovy.nis added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-use-after-move.cpp:342 + // CHECK-NOTES: [[@LINE-5]]:20: note: variable 'a' implicitly captured const here }; } aaron.ballman wrote: > One more test c

[PATCH] D75739: [clangd][vscode] Enable dot-to-arrow fixes in clangd completion.

njames93 added a comment. How does this handle cases where an object overloads the `->` operator or worse still overloads the operator and has conflicting names when accessed with `. ` or `->`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75739/n

[PATCH] D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts

zinovy.nis updated this revision to Diff 248905. zinovy.nis marked 4 inline comments as done. zinovy.nis added a comment. Cosmetic and style fixes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74692/new/ https://reviews.llvm.org/D74692 Files: clang-tools-extra/clang-tidy/bugprone/Us