aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

Thank you for working on this, this LGTM! If you wanted a follow-up patch 
beyond adding semantic support for the `inline` keyword, I think it might make 
sense to investigate divorcing the qualifier parsing from the `DeclSpec` 
interface. These are ASM statements, not declarations, so the fact that we're 
using a DeclSpec to smuggle the qualifiers around is a bit unexpected. However, 
I don't think that work needs to hold up this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75563/new/

https://reviews.llvm.org/D75563



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to