[clang-tools-extra] 223a43e - [clang-tidy] [NFC] Remove unnecessary matchers

Author: Nathan James Date: 2020-03-09T07:38:15Z New Revision: 223a43ee8d899a0522bebe8291470b77e7dc7ab1 URL: https://github.com/llvm/llvm-project/commit/223a43ee8d899a0522bebe8291470b77e7dc7ab1 DIFF: https://github.com/llvm/llvm-project/commit/223a43ee8d899a0522bebe8291470b77e7dc7ab1.diff LOG:

[PATCH] D75803: [clang-tidy] [NFC] Remove unnecessary matchers

This revision was automatically updated to reflect the committed changes. Closed by commit rG223a43ee8d89: [clang-tidy] [NFC] Remove unnecessary matchers (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D75803?vs=248918&id=249040#toc Repository: rG LLVM Github Monore

[PATCH] D65591: [AST] Add a flag indicating if any subexpression had errors

hokein updated this revision to Diff 249039. hokein added a comment. - rebase to master - fix the crash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65591/new/ https://reviews.llvm.org/D65591 Files: clang/include/clang/AST/ASTDumperUtils.h cl

[clang-tools-extra] 2ce821c - Fix build failure from rG223a43ee8d89

Author: Nathan James Date: 2020-03-09T08:12:52Z New Revision: 2ce821cbc90aa987fc370ec578ff92a3327f49ed URL: https://github.com/llvm/llvm-project/commit/2ce821cbc90aa987fc370ec578ff92a3327f49ed DIFF: https://github.com/llvm/llvm-project/commit/2ce821cbc90aa987fc370ec578ff92a3327f49ed.diff LOG:

[PATCH] D73720: [Analyzer] Use note tags to track container begin and and changes

baloghadamsoftware added a comment. I wonder whether I should change "to/from the left" to "towards/from the front" and "to/from the right" to "towards/from the right"? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73720/new/ https://reviews.llvm.org/D73720 _

[PATCH] D75171: [Analyzer] Fix for incorrect use of container and iterator checkers

baloghadamsoftware updated this revision to Diff 249043. baloghadamsoftware added a comment. Correct diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75171/new/ https://reviews.llvm.org/D75171 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/StaticAnalyzer/Che

[PATCH] D75739: [clangd][vscode] Enable dot-to-arrow fixes in clangd completion.

hokein updated this revision to Diff 249046. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75739/new/ https://reviews.llvm.org/D75739 Files: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.t

[PATCH] D75739: [clangd][vscode] Enable dot-to-arrow fixes in clangd completion.

hokein marked 2 inline comments as done. hokein added a comment. In D75739#1909637 , @sammccall wrote: > So the core of this is a better version of my patch, thanks! > It does work around the problem with dot-to-arrow, which is useful and we > should def

[PATCH] D75614: [Analyzer][StreamChecker] Check for opened stream before operations.

balazske updated this revision to Diff 249044. balazske added a comment. rebase to master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75614/new/ https://reviews.llvm.org/D75614 Files: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp clang

[clang] ce1a862 - [Analyzer][StreamChecker] Check for opened stream before operations.

Author: Balázs Kéri Date: 2020-03-09T11:00:03+01:00 New Revision: ce1a86251bb42fbbc7cc21feb416ed7a0bf411b7 URL: https://github.com/llvm/llvm-project/commit/ce1a86251bb42fbbc7cc21feb416ed7a0bf411b7 DIFF: https://github.com/llvm/llvm-project/commit/ce1a86251bb42fbbc7cc21feb416ed7a0bf411b7.diff L

[clang] 2c36c23 - Recommit "[Driver] Default to -fno-common for all targets"

Author: Sjoerd Meijer Date: 2020-03-09T10:07:37Z New Revision: 2c36c23f3476baf3b9283ea387c579419a70b112 URL: https://github.com/llvm/llvm-project/commit/2c36c23f3476baf3b9283ea387c579419a70b112 DIFF: https://github.com/llvm/llvm-project/commit/2c36c23f3476baf3b9283ea387c579419a70b112.diff LOG:

[PATCH] D75839: [Analyzer] Mark constant member functions const in CheckerManager

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, Szelethus. baloghadamsoftware added a project: clang. Herald added subscribers: martong, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Most

[PATCH] D74619: [ARM] Enabling range checks on Neon intrinsics' lane arguments

dnsampaio added inline comments. Comment at: clang/test/CodeGen/arm-neon-range-checks.c:7 +void test_vdot_lane(int32x2_t r, int8x8_t a, int8x8_t b) { + vdot_lane_s32(r, a, b, -1); // expected-error {{argument value -1 is outside the valid range}} + vdot_lane_s32(r, a, b, 2); /

[PATCH] D75614: [Analyzer][StreamChecker] Check for opened stream before operations.

This revision was automatically updated to reflect the committed changes. Closed by commit rGce1a86251bb4: [Analyzer][StreamChecker] Check for opened stream before operations. (authored by balazske). Changed prior to commit: https://reviews.llvm.org/D75614?vs=249044&id=249049#toc Repository:

[clang] c8cd1a9 - [AArch64] Add support for Fujitsu A64FX

Author: KAWASHIMA Takahiro Date: 2020-03-09T19:15:09+09:00 New Revision: c8cd1a994d28e5e822bd0d3c9a6b0aae2abb510f URL: https://github.com/llvm/llvm-project/commit/c8cd1a994d28e5e822bd0d3c9a6b0aae2abb510f DIFF: https://github.com/llvm/llvm-project/commit/c8cd1a994d28e5e822bd0d3c9a6b0aae2abb510f.

[clang] 25f2639 - [OpenCL] Fix 'any' and 'all' builtins

Author: Sven van Haastregt Date: 2020-03-09T10:26:11Z New Revision: 25f2639fab1187c3aca5570f23809721cc0a8f76 URL: https://github.com/llvm/llvm-project/commit/25f2639fab1187c3aca5570f23809721cc0a8f76 DIFF: https://github.com/llvm/llvm-project/commit/25f2639fab1187c3aca5570f23809721cc0a8f76.diff

[clang] f35d112 - Revert "Recommit "[Driver] Default to -fno-common for all targets""

Author: Sjoerd Meijer Date: 2020-03-09T10:37:28Z New Revision: f35d112efdb33abee853aeab8a5ed4a4743e204d URL: https://github.com/llvm/llvm-project/commit/f35d112efdb33abee853aeab8a5ed4a4743e204d DIFF: https://github.com/llvm/llvm-project/commit/f35d112efdb33abee853aeab8a5ed4a4743e204d.diff LOG:

[PATCH] D64464: [CodeGen] Emit destructor calls to destruct compound literals

martong resigned from this revision. martong added a comment. Looks good from the ASTImporter's point of view. I don't have the competence to review the rest, so I am resigning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64464/new/ https://revi

[PATCH] D75594: [AArch64] Add support for Fujitsu A64FX

This revision was automatically updated to reflect the committed changes. Closed by commit rGc8cd1a994d28: [AArch64] Add support for Fujitsu A64FX (authored by kawashima-fj). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINC

[clang] 8d67bcf - [ASTImporter] Added visibility check for variable templates.

Author: Balázs Kéri Date: 2020-03-09T11:57:55+01:00 New Revision: 8d67bcf93c1ecb65d30f5e9b56b4f0c493bde1c3 URL: https://github.com/llvm/llvm-project/commit/8d67bcf93c1ecb65d30f5e9b56b4f0c493bde1c3 DIFF: https://github.com/llvm/llvm-project/commit/8d67bcf93c1ecb65d30f5e9b56b4f0c493bde1c3.diff L

[clang] 59a960b - [analyzer] Skip analysis of inherited ctor as top-level function

Author: Gabor Marton Date: 2020-03-09T12:05:11+01:00 New Revision: 59a960b83c2d1559f31e1dd75728dd24fae2f68c URL: https://github.com/llvm/llvm-project/commit/59a960b83c2d1559f31e1dd75728dd24fae2f68c DIFF: https://github.com/llvm/llvm-project/commit/59a960b83c2d1559f31e1dd75728dd24fae2f68c.diff

[clang] c15c68a - [CallSiteInfo] Enable the call site info only for -g + optimizations

Author: Djordje Todorovic Date: 2020-03-09T12:12:44+01:00 New Revision: c15c68abdc6f1afece637bdedba808676191a8e6 URL: https://github.com/llvm/llvm-project/commit/c15c68abdc6f1afece637bdedba808676191a8e6 DIFF: https://github.com/llvm/llvm-project/commit/c15c68abdc6f1afece637bdedba808676191a8e6.d

[PATCH] D75068: libclang: Add static build support for Windows

cristian.adam added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75068/new/ https://reviews.llvm.org/D75068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D75271: [analyzer][NFC] Change LangOptions to CheckerManager in the shouldRegister* functions.

baloghadamsoftware accepted this revision. baloghadamsoftware added a comment. This revision is now accepted and ready to land. OK, I agree, these issues should be solved in other patches. I already solved one, but the other one is strange. I will open a BugZilla ticket for it. CHANGES SINCE LA

[PATCH] D75175: [CallSiteInfo] Enable the call site info only for -g + optimizations

This revision was automatically updated to reflect the committed changes. Closed by commit rGc15c68abdc6f: [CallSiteInfo] Enable the call site info only for -g + optimizations (authored by djtodoro). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D75678: [analyzer] Skip analysis of inherited ctor as top-level function

martong marked 2 inline comments as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:511 + // + // Also, we cannot model the parameters. CXXInheritedCtorInitExpr doesn't + // take arguments and doesn't model parameter init

[PATCH] D75732: [ASTImporter] Added visibility check for variable templates.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8d67bcf93c1e: [ASTImporter] Added visibility check for variable templates. (authored by balazske). Changed prior to commit: https://reviews.llvm.org/D75732?vs=248692&id=249059#toc Repository: rG LLVM

[PATCH] D75805: Make malign-double effective only for x86

kamleshbhalui updated this revision to Diff 249054. kamleshbhalui added a reviewer: MaskRay. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75805/new/ https://reviews.llvm.org/D75805 Files: clang/lib/Frontend/CompilerInvocation.cpp Index: clang/lib/Frontend/CompilerInvocation.cpp

[PATCH] D75678: [analyzer] Skip analysis of inherited ctor as top-level function

This revision was automatically updated to reflect the committed changes. martong marked an inline comment as done. Closed by commit rG59a960b83c2d: [analyzer] Skip analysis of inherited ctor as top-level function (authored by martong). Changed prior to commit: https://reviews.llvm.org/D75678?v

[PATCH] D74766: [ARM] Fixing range checks for Neon's vqdmulhq_lane and vqrdmulhq_lane intrinsics

dnsampaio added inline comments. Comment at: clang/test/CodeGen/arm-neon-range-checks.c:284-285 +void test_vqdmulhq_lane(int32x4_t a, int32x2_t b) { + vqdmulhq_lane_s32(a, b, -1); // expected-error {{argument value -1 is outside the valid range}} + vqdmulhq_lane_s32(a, b, 2);

[PATCH] D75841: [ASTMatchers] Add hasAnyOverloadedOperatorName matcher

njames93 created this revision. njames93 added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D75841 Files: clang/docs/LibASTMatchersReference.html clang/include/clang/ASTMatcher

[PATCH] D75714: Add Optional overload to DiagnosticBuilder operator <

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang/include/clang/Basic/Diagnostic.h:1318 + const llvm::Optional &Opt) { + if (Opt) { +DB << *Opt; Should this be disabled on f

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin added a comment. @alexfh could you please take another look, I added more tests and updated the doc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75184/new/ https://reviews.llvm.org/D75184 ___

[PATCH] D75839: [Analyzer] Mark constant member functions const in CheckerManager

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM, go for it! I don't think you need to wait for any more reviews on this before commiting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D75842: [Analyzer] Bugfix for CheckerRegistry

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, Szelethus. baloghadamsoftware added a project: clang. Herald added subscribers: martong, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. `Chec

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin updated this revision to Diff 249065. DmitryPolukhin marked an inline comment as done. DmitryPolukhin added a comment. Herald added a subscriber: arphaman. Also updated rst file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75184/new/

[PATCH] D75843: [ARM,CDE] Implement CDE feature test macros

miyuki created this revision. miyuki added reviewers: simon_tatham, dmgreen, ostannard, MarkMurrayARM. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. This patch implements feature test macros for the CDE extension according to the upcoming ACLE spe

Re: [clang] 8e4a867 - Revert "PR45083: Mark statement expressions as being dependent if they contain"

On Sat, Mar 7, 2020 at 12:47 AM Richard Smith via cfe-commits wrote: > > On Fri, 6 Mar 2020 at 02:11, Stephan Herhut via cfe-commits > wrote: >> >> Author: Stephan Herhut >> Date: 2020-03-06T11:09:45+01:00 >> New Revision: 8e4a8677be3061317056335d298d85ce60c23dff >> >> URL: >> https://github.co

[PATCH] D75360: [analyzer][NFC] Tie CheckerRegistry to CheckerManager, allow CheckerManager to be constructed for non-analysis purposes

baloghadamsoftware added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/CheckerManager.h:178 + const CheckerRegistry &getCheckerRegistry() { return Registry; } + DiagnosticsEngine &getDiagnostics() { return Diags; } Please mark these get

[PATCH] D75842: [Analyzer] Bugfix for CheckerRegistry

baloghadamsoftware added a comment. I looked in the `unittests` directory but could not find tests for dependency handling. @Szelethus, feel free to commandeer this patch if you know how to test it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75

[PATCH] D75842: [Analyzer] Bugfix for CheckerRegistry

baloghadamsoftware added a comment. In D75842#1912246 , @xazax.hun wrote: > If we disable the dependency of a checker explicitly I think we should at > least emit a warning. I agree, but I do not thik that this should be part of this patch. This is only

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

tbaeder created this revision. tbaeder added reviewers: tstellar, serge-sans-paille. tbaeder added a project: clang. Herald added a subscriber: cfe-commits. Otherwise the source range of the passed-in ParsedAttributesWithRange ends up being invalid and the resulting error messages rather useless.

[PATCH] D75842: [Analyzer] Bugfix for CheckerRegistry

xazax.hun added a comment. If we disable the dependency of a checker explicitly I think we should at least emit a warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75842/new/ https://reviews.llvm.org/D75842

[clang-tools-extra] 6ba0a4e - [clangd][vscode] Enable dot-to-arrow fixes in clangd completion.

Author: Haojian Wu Date: 2020-03-09T14:02:08+01:00 New Revision: 6ba0a4ec3bbfe71050b7b5c87f46820f3500e211 URL: https://github.com/llvm/llvm-project/commit/6ba0a4ec3bbfe71050b7b5c87f46820f3500e211 DIFF: https://github.com/llvm/llvm-project/commit/6ba0a4ec3bbfe71050b7b5c87f46820f3500e211.diff LO

[clang] 57f70d1 - [Analyzer] Mark constant member functions const in CheckerManager

Author: Adam Balogh Date: 2020-03-09T14:11:30+01:00 New Revision: 57f70d187706f572227b74c82c7446a3096f862f URL: https://github.com/llvm/llvm-project/commit/57f70d187706f572227b74c82c7446a3096f862f DIFF: https://github.com/llvm/llvm-project/commit/57f70d187706f572227b74c82c7446a3096f862f.diff L

[PATCH] D75685: Add MS Mangling for OpenCL Pipe types, add mangling test.

erichkeane added a comment. Ping! @Anastasia I was hoping for your input on this, since it is OpenCLC++. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75685/new/ https://reviews.llvm.org/D75685 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D75842: [Analyzer] Bugfix for CheckerRegistry

Szelethus added a subscriber: dcoughlin. Szelethus added a comment. In D75842#1912249 , @baloghadamsoftware wrote: > In D75842#1912246 , @xazax.hun wrote: > > > If we disable the dependency of a checker explicitly

[PATCH] D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. No further comments from me, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75621/new/ https://reviews.llvm.org/D75621 ___

[PATCH] D75842: [Analyzer] Bugfix for CheckerRegistry

xazax.hun added a comment. I am not sure if I would call this a bugfix. Enabling a checker without one of its dependency will potentially cause the checker to misbehave. I am uncomfortable changing the current behavior to a more dangerous one without any diagnostics. Including the diagnostic wi

[PATCH] D51762: First part of the calendar stuff

ldionne accepted this revision. ldionne added a comment. Herald added subscribers: Charusso, dexonsmith. Committed in 5b08c1742a536f54bd5e270b00ff851cbc7314ef CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51762/new/ https://reviews.llvm.org/D51762

[PATCH] D75839: [Analyzer] Mark constant member functions const in CheckerManager

This revision was automatically updated to reflect the committed changes. Closed by commit rG57f70d187706: [Analyzer] Mark constant member functions const in CheckerManager (authored by baloghadamsoftware). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D75739: [clangd][vscode] Enable dot-to-arrow fixes in clangd completion.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6ba0a4ec3bbf: [clangd][vscode] Enable dot-to-arrow fixes in clangd completion. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75739/new/

[PATCH] D75714: Add Optional overload to DiagnosticBuilder operator <

lebedev.ri added a comment. What's the use case here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75714/new/ https://reviews.llvm.org/D75714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D75768: Add a warning for builtin_return_address/frame_address with > 0 argument

lebedev.ri resigned from this revision. lebedev.ri added a reviewer: aaron.ballman. lebedev.ri added a comment. This seems reasonable to me but i'll defer to other reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75768/new/ https://reviews.

[PATCH] D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions

njames93 accepted this revision. njames93 added a comment. LGTM Comment at: clang-tools-extra/clang-tidy/utils/FileExtensionsUtils.h:44-46 bool parseFileExtensions(StringRef AllFileExtensions, - FileExtensionsSet &FileExtensions, char Delimiter); +

[PATCH] D75749: [clang-tidy] extend bugprone-signed-char-misuse check.

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LGTM However, how does this handle cases when the type is written as `char`. They can be signed/unsigned based on what platform is being targeted. But on a platform where `char` is signed

[PATCH] D75842: [Analyzer] Bugfix for CheckerRegistry

baloghadamsoftware added a comment. In D75842#1912293 , @xazax.hun wrote: > I am not sure if I would call this a bugfix. Enabling a checker without one > of its dependency will potentially cause the checker to misbehave. I am > uncomfortable changing the

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

balazske updated this revision to Diff 249085. balazske added a comment. Removed support for `fseek`, added `clearerr`. This is now error handling only without fseek. No functions set the error flags so test for clearerr is not possible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D75843: [ARM,CDE] Implement CDE feature test macros

simon_tatham requested changes to this revision. simon_tatham added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Basic/TargetInfo.h:213 + unsigned ARMCDECorpocMask : 8; + Typo: `Corpoc` → `Coproc`. Lots of tho

[PATCH] D75714: Add Optional overload to DiagnosticBuilder operator <

njames93 added a comment. In D75714#1912326 , @lebedev.ri wrote: > What's the use case here? Mainly syntactic sugar, If you have a function that maybe returns a `FixItHint` or `SourceRange` you can pass it directly to the `DiagnosticBuilder`. Reposito

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added a comment. In D72841#1911330 , @rjmccall wrote: > In D72841#1908084 , @mibintc wrote: > > > @rjmccall suggested that I needed to remove FPOptions from the Stmt class > > since the sizeof assertion fai

[PATCH] D75842: [Analyzer] Bugfix for CheckerRegistry

xazax.hun added a comment. In D75842#1912364 , @baloghadamsoftware wrote: > In D75842#1912293 , @xazax.hun wrote: > > > I am not sure if I would call this a bugfix. Enabling a checker without one > > of its depend

[PATCH] D75739: [clangd][vscode] Enable dot-to-arrow fixes in clangd completion.

sammccall added a comment. In D75739#1912051 , @hokein wrote: > In D75739#1909637 , @sammccall wrote: > > > So the core of this is a better version of my patch, thanks! > > It does work around the problem with dot-

[clang-tools-extra] e669d81 - [clangd] Bump vscode-clangd v0.0.21.

Author: Haojian Wu Date: 2020-03-09T15:36:49+01:00 New Revision: e669d81715b591e18d51d7ebe82fe448345b6664 URL: https://github.com/llvm/llvm-project/commit/e669d81715b591e18d51d7ebe82fe448345b6664 DIFF: https://github.com/llvm/llvm-project/commit/e669d81715b591e18d51d7ebe82fe448345b6664.diff LO

[PATCH] D75714: Add Optional overload to DiagnosticBuilder operator <

aaron.ballman added a comment. In D75714#1912400 , @njames93 wrote: > In D75714#1912326 , @lebedev.ri > wrote: > > > What's the use case here? > > > Mainly syntactic sugar, If you have a function that maybe returns

[PATCH] D75690: [SVE][Inline-Asm] Add constraints for SVE ACLE types

kmclaughlin updated this revision to Diff 249092. kmclaughlin added a comment. - Added -emit-llvm to the RUN line of aarch64-sve-inline-asm-datatypes.c test. Added some more tests here for the Upl & y constraints and removed aarch64-sve-inline-asm-vec-low.c. - Addressed formatting suggestions on

[PATCH] D75690: [SVE][Inline-Asm] Add constraints for SVE ACLE types

kmclaughlin marked 2 inline comments as done. kmclaughlin added a comment. Thanks for reviewing this, @efriedma! Comment at: clang/lib/Basic/Targets/AArch64.h:95 +case 'U': // Three-character constraint; add "@3" hint for later parsing. + R = std::string("@3") + std:

[PATCH] D75740: [ASTImporter] Corrected import of repeated friend declarations.

balazske updated this revision to Diff 249100. balazske marked 2 inline comments as done. balazske added a comment. Fixes according to comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75740/new/ https://reviews.llvm.org/D75740 Files: clan

[PATCH] D75740: [ASTImporter] Corrected import of repeated friend declarations.

balazske marked 9 inline comments as done. balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3640 + auto *RD = cast(FD->getLexicalDeclContext()); + if (FD->getFriendType()) { +QualType TypeOfFriend = FD->getFriendType()->getType().getCanonicalType();

[PATCH] D75714: Add Optional overload to DiagnosticBuilder operator <

gribozavr2 added a comment. I can see it being useful for fix-its and source ranges, however I have a concern about it accidentally eating arguments that were supposed to go into a format string. For that, I second Aaron's suggestion to implement an extension for format strings. If you don't wa

[PATCH] D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions

jroelofs marked an inline comment as done. jroelofs added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/FileExtensionsUtils.h:44-46 bool parseFileExtensions(StringRef AllFileExtensions, - FileExtensionsSet &FileExtensions, char Delimiter

[PATCH] D72874: [clangd] Add a textual fallback for go-to-definition

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:258 + +// For now, only consider exact name matches, including case. +// This is to avoid too many false positives. sammccall wrote: > nr

[PATCH] D75843: [ARM,CDE] Implement CDE feature test macros

miyuki updated this revision to Diff 249103. miyuki added a comment. Fixed typos and formatting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75843/new/ https://reviews.llvm.org/D75843 Files: clang/include/clang/Basic/TargetInfo.h clang/lib/Basic/TargetInfo.cpp clang/lib/Basic/T

[clang] 7b66160 - Fix Target Multiversioning renaming.

Author: Erich Keane Date: 2020-03-09T08:29:18-07:00 New Revision: 7b661608287e84d6bec24262a0a42c1d8b65fcc6 URL: https://github.com/llvm/llvm-project/commit/7b661608287e84d6bec24262a0a42c1d8b65fcc6 DIFF: https://github.com/llvm/llvm-project/commit/7b661608287e84d6bec24262a0a42c1d8b65fcc6.diff L

[PATCH] D72635: Allow arbitrary capability name in Thread Safety Analysis

aaron.ballman added a comment. In D72635#1911844 , @aaronpuchert wrote: > In D72635#1911671 , @aaron.ballman > wrote: > > > However, do we want to diagnose when the capability strings are different? > > > Hmm, int

[PATCH] D75843: [ARM,CDE] Implement CDE feature test macros

simon_tatham added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:492 HW_FP |= HW_FP_SP | HW_FP_HP; +} else if (Feature >= "+cdecp0" && Feature <= "+cdecp7") { + unsigned Coproc = Feature.back() - '0'; As far as I can see, feature na

[PATCH] D75850: [ARM, CDE] Generalize MVE intrinsics infrastructure to support CDE

miyuki created this revision. miyuki added reviewers: simon_tatham, MarkMurrayARM, ostannard, dmgreen. Herald added subscribers: llvm-commits, cfe-commits, danielkiss, kristof.beyls, mgorny. Herald added projects: clang, LLVM. miyuki added a parent revision: D75843: [ARM,CDE] Implement CDE feature

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

balazske updated this revision to Diff 249107. balazske added a comment. Fixed lint warnings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75682/new/ https://reviews.llvm.org/D75682 Files: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp c

[PATCH] D75768: Add a warning for builtin_return_address/frame_address with > 0 argument

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I did a bit of research and I don't think i know of anything better than 'most' here, and noone else had an opinion at the end of last week so I'll take that silence as consent. Appro

[PATCH] D71018: [ASTImporter] Improved import of TypeSourceInfo (TypeLoc)

martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3281 + // Import the function parameters. + SmallVector Parameters; balazske wrote: > shafik wrote: > > I am curious, why move this chunk of code up? > See comments at line 8238? I moved

[PATCH] D75843: [ARM,CDE] Implement CDE feature test macros

miyuki marked an inline comment as done. miyuki added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:492 HW_FP |= HW_FP_SP | HW_FP_HP; +} else if (Feature >= "+cdecp0" && Feature <= "+cdecp7") { + unsigned Coproc = Feature.back() - '0'; -

[PATCH] D71018: [ASTImporter] Improved import of TypeSourceInfo (TypeLoc)

martong updated this revision to Diff 249106. martong marked 10 inline comments as done. martong added a comment. - Remove default visit functions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71018/new/ https://reviews.llvm.org/D71018 Files: cl

[PATCH] D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/FileExtensionsUtils.h:44-46 bool parseFileExtensions(StringRef AllFileExtensions, - FileExtensionsSet &FileExtensions, char Delimiter); + FileExtensions

[PATCH] D74054: [clangd] Include the underlying decls in go-to-definition.

hokein added a comment. friendly ping, this patch should be ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74054/new/ https://reviews.llvm.org/D74054 ___ cfe-commits mailing list cfe-c

[PATCH] D75579: [WIP] Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by libraries

serge-sans-paille updated this revision to Diff 249109. serge-sans-paille added a comment. @MaskRay The library version prooved to be a bad path: we wanted clang-cpp to always link to a shared library, which interacts in ungraceful ways with BUILD_SHARED_LIBS. This is another attempt that looks

[PATCH] D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions

jroelofs marked an inline comment as done. jroelofs added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/FileExtensionsUtils.h:44-46 bool parseFileExtensions(StringRef AllFileExtensions, - FileExtensionsSet &FileExtensions, char Delimiter

[clang] 58884eb - [analyzer][NFC] Refactor the checker registration unit test file

Author: Kirstóf Umann Date: 2020-03-09T16:38:30+01:00 New Revision: 58884eb6489880646896d72fcd723813f8a13299 URL: https://github.com/llvm/llvm-project/commit/58884eb6489880646896d72fcd723813f8a13299 DIFF: https://github.com/llvm/llvm-project/commit/58884eb6489880646896d72fcd723813f8a13299.diff

[PATCH] D75843: [ARM,CDE] Implement CDE feature test macros

miyuki updated this revision to Diff 249115. miyuki added a comment. Fix condition check CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75843/new/ https://reviews.llvm.org/D75843 Files: clang/include/clang/Basic/TargetInfo.h clang/lib/Basic/TargetInfo.cpp clang/lib/Basic/Targets/A

[PATCH] D75805: Make malign-double effective only for x86

MaskRay added a comment. `-Xclang -malign-double` passes a CC1 option. This is like poking into the compiler internals. The interface is not stable, and some flags may not make sense (they can be precluded by clang/lib/Driver logic), so I am not sure why it is reported as a bug in the first pla

[PATCH] D75851: [Analyzer][StreamChecker] Added evaluation of fseek.

balazske created this revision. Herald added subscribers: cfe-commits, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: clang. balazske added a parent revisio

[PATCH] D75842: [Analyzer] Bugfix for CheckerRegistry

Szelethus added a comment. The thing to note here is checkers that are not `isDisabled()` won't get enabled, only if they are `isEnabled()` as well :) Please add a unit test, otherwise LGTM. I just landed D67335 , so it should be easy to do. Repository: rG L

[PATCH] D75714: Add Optional overload to DiagnosticBuilder operator <

njames93 updated this revision to Diff 249121. njames93 added a comment. - Removed template in favour of specific overloads Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75714/new/ https://reviews.llvm.org/D75714 Files: clang/include/clang/Basic

[PATCH] D75788: [WIP][OpenMP] Reuse CUDA wrappers in `nvptx` target regions.

tra added a comment. Couple of nits below. LGTM for CUDA headers otherwise. Comment at: clang/lib/Headers/__clang_cuda_math_forward_declares.h:42-43 __DEVICE__ long long abs(long long); -__DEVICE__ double abs(double); -__DEVICE__ float abs(float); -#endif Shou

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

rjmccall added a comment. In D72841#1912416 , @mibintc wrote: > In D72841#1911330 , @rjmccall wrote: > > > In D72841#1908084 , @mibintc wrote: > > > > > @rjmccall suggested t

[PATCH] D67335: [analyzer][NFC] Refactor the checker registration unit test file

This revision was automatically updated to reflect the committed changes. Closed by commit rG58884eb64898: [analyzer][NFC] Refactor the checker registration unit test file (authored by Szelethus). Herald added subscribers: martong, steakhal. Changed prior to commit: https://reviews.llvm.org/D67

[clang] cdeeb54 - [ARM,CDE] Implement CDE feature test macros

Author: Mikhail Maltsev Date: 2020-03-09T16:14:06Z New Revision: cdeeb548bbebdff7661fb20b72839b920be0adbe URL: https://github.com/llvm/llvm-project/commit/cdeeb548bbebdff7661fb20b72839b920be0adbe DIFF: https://github.com/llvm/llvm-project/commit/cdeeb548bbebdff7661fb20b72839b920be0adbe.diff LO

[PATCH] D75524: [www] cxx_status: Update Reflection TS to Cologne draft

hubert.reinterpretcast added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75524/new/ https://reviews.llvm.org/D75524 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D68578: [HIP] Fix device stub name

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Few nits. LGTM otherwise. Comment at: clang/include/clang/AST/GlobalDecl.h:61 assert(!isa(D) && "Use other ctor with dtor decls!"); +assert(!D->hasAttr() && "Use other cto

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

njames93 added a comment. How are local and global options handled. For example in root .clang-tidy: CheckOptions: - key: some-check.GlobalOption value: '1' and in a subfolder .clang-tidy: CheckOptions: - key: GlobalOption value:

[PATCH] D75523: [www] cxx_status: Update title to mention C++20

hubert.reinterpretcast added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75523/new/ https://reviews.llvm.org/D75523 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

  1   2   3   >