[PATCH] D77408: [clang] Annotate trivial getters and setters on hover.

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rGa975fde23a5e: [clang] Annotate trivial getters and setters on hover. (authored by sammccall). Changed prior to commit:

[clang-tools-extra] a975fde - [clang] Annotate trivial getters and setters on hover.

Author: Sam McCall Date: 2020-04-04T07:15:12+02:00 New Revision: a975fde23a5e64721d75022b2a072a0b19f4b279 URL: https://github.com/llvm/llvm-project/commit/a975fde23a5e64721d75022b2a072a0b19f4b279 DIFF: https://github.com/llvm/llvm-project/commit/a975fde23a5e64721d75022b2a072a0b19f4b279.diff

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

sconstab added inline comments. Comment at: llvm/lib/Target/X86/ImmutableGraph.h:318 +} +auto *VertexArray = new Node[VertexSize + 1 /* terminator node */]; +auto *EdgeArray = new Edge[EdgeSize]; mattdr wrote: > As a general rule `new` is a

[PATCH] D73290: [PowerPC] Add clang -msvr4-struct-return for 32-bit ELF

jhibbits edited reviewers, added: jhibbits; removed: chmeee. jhibbits accepted this revision. jhibbits added a comment. This revision is now accepted and ready to land. Code looks fine, and others have tested it. Good to see a reversion of the ABI to expected for GCC compatibility on the BSDs.

[PATCH] D68049: Propeller: Clang options for basic block sections

tmsriram added inline comments. Comment at: clang/test/CodeGen/basicblock-sections.c:35 +// +// BB_WORLD: .section .text.world,"ax",@progbits +// BB_WORLD: world MaskRay wrote: > I haven't read through the previous threads whether we should use a .c -> .s >

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

craig.topper updated this revision to Diff 255000. craig.topper added a comment. Remove underscores from names. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75936/new/ https://reviews.llvm.org/D75936 Files: clang/include/clang/Driver/Options.td

[PATCH] D68049: Propeller: Clang options for basic block sections

tmsriram updated this revision to Diff 254999. tmsriram marked 4 inline comments as done. tmsriram added a comment. Fix test and make error check at driver. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68049/new/ https://reviews.llvm.org/D68049 Files:

[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

rsmith added a comment. In D77184#1961214 , @rsmith wrote: > In D77184#1961208 , @rsmith wrote: > > > This has broken my ability to run the `check-clang` target on Linux. There > > are symlinks in the path from

[clang] 179f4ba - Don't treat a CXXScopeSpec with a nested name specifier but no location

Author: Richard Smith Date: 2020-04-03T20:20:48-07:00 New Revision: 179f4baba0672a5e85c5db91095c4cd701a2d32d URL: https://github.com/llvm/llvm-project/commit/179f4baba0672a5e85c5db91095c4cd701a2d32d DIFF: https://github.com/llvm/llvm-project/commit/179f4baba0672a5e85c5db91095c4cd701a2d32d.diff

[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

rsmith added a comment. In D77184#1961208 , @rsmith wrote: > This has broken my ability to run the `check-clang` target on Linux. There > are symlinks in the path from which I run my builds, and this patch is > computing incorrect relative paths in that

[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

rsmith added a comment. This has broken my ability to run the `check-clang` target on Linux. There are symlinks in the path from which I run my builds, and this patch is computing incorrect relative paths in that situation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77414: [OpenMP] Add match_{all,any,none} declare variant selector extensions.

jdoerfert updated this revision to Diff 254983. jdoerfert added a comment. Allow the new match clauses to be used in `begin/end declare variant` as well (with their respective effect) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77414/new/

[PATCH] D77451: Accept -x cu to indicate language is CUDA, transfer CUDA language flag to header-file arguments

ADRAADRA created this revision. ADRAADRA added a reviewer: tra. ADRAADRA added a project: clang. Herald added subscribers: cfe-commits, yaxunl. - accept -x cu to indicate language is CUDA - transfer CUDA language flag to header-file arguments Repository: rG LLVM Github Monorepo

[clang] 4ede887 - PR45402: Make the restrictions on constant evaluation of memcmp and

Author: Richard Smith Date: 2020-04-03T18:26:14-07:00 New Revision: 4ede8879924c08ae5b495d3f421c167d822a60be URL: https://github.com/llvm/llvm-project/commit/4ede8879924c08ae5b495d3f421c167d822a60be DIFF: https://github.com/llvm/llvm-project/commit/4ede8879924c08ae5b495d3f421c167d822a60be.diff

[PATCH] D76269: [opaque pointer types] Remove deprecated Instruction/IRBuilder APIs.

efriedma updated this revision to Diff 254971. efriedma added a comment. Herald added a project: LLVM. Commited the non-header changes separately Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76269/new/ https://reviews.llvm.org/D76269 Files:

[clang] b11decc - [clang codegen][opaque pointers] Remove use of deprecated constructor

Author: Eli Friedman Date: 2020-04-03T18:00:33-07:00 New Revision: b11decc221a65d2c7290b93a4662a607a63b6d86 URL: https://github.com/llvm/llvm-project/commit/b11decc221a65d2c7290b93a4662a607a63b6d86 DIFF: https://github.com/llvm/llvm-project/commit/b11decc221a65d2c7290b93a4662a607a63b6d86.diff

[clang] 83fa811 - [clang][opaque pointers] Fix up a bunch of "getType()->getElementType()"

Author: Eli Friedman Date: 2020-04-03T18:00:33-07:00 New Revision: 83fa811e5bf5b291eafd900f3072b961f64f039c URL: https://github.com/llvm/llvm-project/commit/83fa811e5bf5b291eafd900f3072b961f64f039c DIFF: https://github.com/llvm/llvm-project/commit/83fa811e5bf5b291eafd900f3072b961f64f039c.diff

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

craig.topper updated this revision to Diff 254962. craig.topper marked an inline comment as done. craig.topper added a comment. Fix include guard on ImmutableGraph.h CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75936/new/ https://reviews.llvm.org/D75936 Files:

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/ImmutableGraph.h:46-56 + using NodeValueT = _NodeValueT; + using EdgeValueT = _EdgeValueT; + using size_type = _SizeT; + class Node; + class Edge { +friend class ImmutableGraph; +template friend

[PATCH] D77432: [DebugInfo] Change to constructor homing debug info mode: skip constexpr constructed types

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Sounds good to me, lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77432/new/ https://reviews.llvm.org/D77432

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

mattdr added a comment. Adding a few early style notes for the next round, but overall echo @chandlerc that this seems significantly outside of normal LLVM code. Comment at: llvm/lib/Target/X86/ImmutableGraph.h:26 + +#ifndef IMMUTABLEGRAPH_H +#define IMMUTABLEGRAPH_H

[PATCH] D77436: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77436/new/ https://reviews.llvm.org/D77436 ___

[clang] 1d42c0d - Revert "[X86] Add a Pass that builds a Condensed CFG for Load Value Injection (LVI) Gadgets"

Author: Craig Topper Date: 2020-04-03T16:56:08-07:00 New Revision: 1d42c0db9a2b27c149c5bac373caa5a6d38d1f74 URL: https://github.com/llvm/llvm-project/commit/1d42c0db9a2b27c149c5bac373caa5a6d38d1f74 DIFF: https://github.com/llvm/llvm-project/commit/1d42c0db9a2b27c149c5bac373caa5a6d38d1f74.diff

[PATCH] D72872: [ObjC generics] Fix not inheriting type bounds in categories/extensions.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa8c8b627f23f: [ObjC generics] Fix not inheriting type bounds in categories/extensions. (authored by vsapsai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77432: [DebugInfo] Change to constructor homing debug info mode: skip constexpr constructed types

akhuang marked an inline comment as done. akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2263 if (DebugKind == codegenoptions::DebugInfoConstructor && - !CXXDecl->isLambda() && !isClassOrMethodDLLImport(CXXDecl)) { -for (const auto *Ctor

[PATCH] D73245: Avoid using std::max_align_t in pre-C++11 mode

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rG98f77828a98f: Avoid using std::max_align_t in pre-C++11 mode (authored by joerg). Herald added a project: libc++.

[PATCH] D77440: [Hexagon] Update include paths for linux/musl

sidneym created this revision. sidneym added reviewers: kparzysz, bcain, bcahoon, adasgupt. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update CXX paths for linux/musl. And update the sysroot expectation to match other targets. At this point I might pull out

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

chandlerc added inline comments. Comment at: llvm/lib/Target/X86/ImmutableGraph.h:46-56 + using NodeValueT = _NodeValueT; + using EdgeValueT = _EdgeValueT; + using size_type = _SizeT; + class Node; + class Edge { +friend class ImmutableGraph; +template friend class

[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

asbirlea updated this revision to Diff 254943. asbirlea marked 16 inline comments as done. asbirlea added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77341/new/ https://reviews.llvm.org/D77341 Files:

[PATCH] D72872: [ObjC generics] Fix not inheriting type bounds in categories/extensions.

vsapsai added a comment. Thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72872/new/ https://reviews.llvm.org/D72872 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

asbirlea added inline comments. Comment at: llvm/include/llvm/Support/GenericDomTreeConstruction.h:185 + std::make_pair(GDTmp, BB); + for (auto : children(GDNodePair)) { +const NodePtr Succ = Pair.second; kuhar wrote: > Won't children

[PATCH] D77432: [DebugInfo] Change to constructor homing debug info mode: skip constexpr constructed types

akhuang updated this revision to Diff 254942. akhuang added a comment. Change check to hasConstexprNonCopyMoveConstructor() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77432/new/ https://reviews.llvm.org/D77432 Files:

[clang] e62dc1f - [MS] Fix assert handling enum forward decls in hasVisibleDefinition

Author: Reid Kleckner Date: 2020-04-03T16:46:07-07:00 New Revision: e62dc1f6252c1dcdcc2a64e8e3b07a32412e9d89 URL: https://github.com/llvm/llvm-project/commit/e62dc1f6252c1dcdcc2a64e8e3b07a32412e9d89 DIFF: https://github.com/llvm/llvm-project/commit/e62dc1f6252c1dcdcc2a64e8e3b07a32412e9d89.diff

[clang] a8c8b62 - [ObjC generics] Fix not inheriting type bounds in categories/extensions.

Author: Volodymyr Sapsai Date: 2020-04-03T16:29:02-07:00 New Revision: a8c8b627f23f204fb621bd2a8c495cfc8bc16ae7 URL: https://github.com/llvm/llvm-project/commit/a8c8b627f23f204fb621bd2a8c495cfc8bc16ae7 DIFF:

[PATCH] D76572: Replace `T(x)` with `reinterpret_cast(x)` everywhere it means reinterpret_cast. No functional change

ahatanak added a comment. I'm not sure which part I'm supposed to look at, but the changes LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76572/new/ https://reviews.llvm.org/D76572 ___

[PATCH] D77436: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang created this revision. akhuang added reviewers: rnk, dblaikie, aprantl. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change adds DIFlagNonTrivial to forward declarations of DICompositeType. It adds the flag to nontrivial types and types with unknown

[PATCH] D77432: [DebugInfo] Change to constructor homing debug info mode: skip literal types

dblaikie added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2263 if (DebugKind == codegenoptions::DebugInfoConstructor && - !CXXDecl->isLambda() && !isClassOrMethodDLLImport(CXXDecl)) { -for (const auto *Ctor : CXXDecl->ctors()) { +

[PATCH] D77432: [DebugInfo] Change to constructor homing debug info mode: skip literal types

rnk added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2263 if (DebugKind == codegenoptions::DebugInfoConstructor && - !CXXDecl->isLambda() && !isClassOrMethodDLLImport(CXXDecl)) { -for (const auto *Ctor : CXXDecl->ctors()) { +

[PATCH] D75431: [analyzer][NFC] Merge checkNewAllocator's paramaters into CXXAllocatorCall

Szelethus added a comment. Hmm, upon taking a look at alignment new in previous patches, I think implementing a checker for MEM57-CPP. Avoid using default operator new for over-aligned types

[PATCH] D77432: [DebugInfo] Change to constructor homing debug info mode: skip literal types

dblaikie added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77432/new/ https://reviews.llvm.org/D77432 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D76782: [CodeGenObjC] Fix a crash when attempting to copy a zero-sized bit-field in a non-trivial C struct

ahatanak added a comment. Thanks for fixing this! Comment at: clang/lib/CodeGen/CGNonTrivialStruct.cpp:545 LValue DstLV, SrcLV; if (FD) { + // No need to copy zero-length bit-fields. Can you add the same check to

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

george.burgess.iv added a comment. For a more direct comparison, I offer https://godbolt.org/z/fqAhUC . The lack of optimization in the later case is because we're forced to mark the call to `__builtin_memcpy` in the inline memcpy as `nobuiltin`. If we instead rename things, this issue doesn't

[PATCH] D77379: [FPEnv] Use single enum to represent rounding mode

rjmccall added inline comments. Comment at: llvm/include/llvm/ADT/FloatingPointMode.h:26 +/// assigned to the rounding modes must agree with the values used by FLT_ROUNDS +/// (C11, 5.2.4.2.2p8). +enum class RoundingMode : int8_t { I agree that we should use

[clang] ba8b305 - [Driver] Handle all optimization-record options for Darwin LTO

Author: Francis Visoiu Mistrih Date: 2020-04-03T15:30:08-07:00 New Revision: ba8b3052b59ebee4311d10bee5209dac8747acea URL: https://github.com/llvm/llvm-project/commit/ba8b3052b59ebee4311d10bee5209dac8747acea DIFF:

[PATCH] D77085: [clang-tidy] Added support for validating configuration options

njames93 marked 8 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.cpp:25 + llvm::raw_svector_ostream Output(Buffer); + Output << "warning: Option not found '" << OptionName << "'\n"; + return

[PATCH] D75044: [AArch64] __builtin_extract_return_addr for PAuth.

danielkiss updated this revision to Diff 254921. danielkiss added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75044/new/ https://reviews.llvm.org/D75044 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/arm64-extractreturnaddress.c

[PATCH] D77028: [NFC] Refactor DeferredDiagsEmitter and skip redundant visit

rjmccall added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1508 void checkFunc(SourceLocation Loc, FunctionDecl *FD) { +auto DiagsCountIt = DiagsCount.find(FD); FunctionDecl *Caller = UseStack.empty() ? nullptr : UseStack.back(); yaxunl

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel updated this revision to Diff 254917. atmnpatel added a comment. Fixes clang-tidy check, and hopefully the other unrelated test failure too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D75591 Files:

[PATCH] D77244: [part 1] sancov/inline-bool-flag instrumentation.

pratyai updated this revision to Diff 254919. pratyai retitled this revision from "sancov/inline-bool-flag feature + tests + docs." to "[part 1] sancov/inline-bool-flag instrumentation.". pratyai added a comment. Herald added a project: LLVM. Dropped files from outside llvm/.../Instrumentation*

[PATCH] D77432: [DebugInfo] Change to constructor homing debug info mode: skip literal types

akhuang created this revision. akhuang added reviewers: rnk, dblaikie. Herald added subscribers: cfe-commits, aprantl. Herald added a project: clang. In constructor type homing mode sometimes complete debug info for constexpr types was missing, because there was not a constructor emitted. This

[PATCH] D76572: Replace `T(x)` with `reinterpret_cast(x)` everywhere it means reinterpret_cast. No functional change

Bigcheese accepted this revision. Bigcheese added a comment. LGTM for llvm/{lib,include/llvm}/Object/* and llvm/tools/llvm-readobj/*. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76572/new/ https://reviews.llvm.org/D76572

[PATCH] D76572: Replace `T(x)` with `reinterpret_cast(x)` everywhere it means reinterpret_cast. No functional change

lebedev.ri added a comment. All these changes are rather NFCI, i'm not sure each one needs to be reviewed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76572/new/ https://reviews.llvm.org/D76572 ___

[PATCH] D77431: [X86] Add tests to clang Driver to ensure that SLH/Retpoline features are not enabled with LVI-hardening

sconstab created this revision. sconstab added a reviewer: craig.topper. https://reviews.llvm.org/D77431 Files: clang/test/Driver/x86-target-features.c Index: clang/test/Driver/x86-target-features.c === ---

[PATCH] D76572: Replace `T(x)` with `reinterpret_cast(x)` everywhere it means reinterpret_cast. No functional change

Quuxplusone added subscribers: kparzysz, Bigcheese. Quuxplusone added a comment. Ah. Then I'm not sure who else to ping, or even which pieces remain in need of review. CODE_OWNERS.TXT isn't being very helpful here... @kparzysz for HexagonCommonGEP.cpp ("Hexagon backend")? @Bigcheese for Binary.h

[PATCH] D77290: [OpenMP] Specialize OpenMP calls after template instantiation

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:1698 + auto *CE = cast(R.get()); + return SemaRef.ActOnOpenMPCall(R, nullptr, CE->getRParenLoc(), +

[PATCH] D76572: Replace `T(x)` with `reinterpret_cast(x)` everywhere it means reinterpret_cast. No functional change

hubert.reinterpretcast added a comment. I am guessing @DiggerLin was pinged with regards to `XCOFFObjectFile.cpp`. @jhenderson already reviewed and approved the changes to that file (it falls under libObject). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76184: [OpenMP][NFC] Remove the need to include `OpenMPClause.h`

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGba1ffd25c1f7: [OpenMP][NFC] Remove the need to include `OpenMPClause.h` (authored by rnk). Changed prior to commit:

[PATCH] D77290: [OpenMP] Specialize OpenMP calls after template instantiation

mikerice added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:1698 + auto *CE = cast(R.get()); + return SemaRef.ActOnOpenMPCall(R, nullptr, CE->getRParenLoc(), + MultiExprArg(CE->getArgs(), CE->getNumArgs()),

[PATCH] D77085: [clang-tidy] Added support for validating configuration options

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.cpp:25 + llvm::raw_svector_ostream Output(Buffer); + Output << "warning: Option not found '" << OptionName << "'\n"; + return std::string(Buffer); aaron.ballman

[clang-tools-extra] ba1ffd2 - [OpenMP][NFC] Remove the need to include `OpenMPClause.h`

Author: Reid Kleckner Date: 2020-04-03T13:27:52-07:00 New Revision: ba1ffd25c1f7a3564136b13e49fb1a7185561613 URL: https://github.com/llvm/llvm-project/commit/ba1ffd25c1f7a3564136b13e49fb1a7185561613 DIFF: https://github.com/llvm/llvm-project/commit/ba1ffd25c1f7a3564136b13e49fb1a7185561613.diff

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

This revision was automatically updated to reflect the committed changes. Closed by commit rGc74dd640fd74: [X86] Add a Pass that builds a Condensed CFG for Load Value Injection (LVI)… (authored by sconstab, committed by craig.topper). Herald added a project: clang. Changed prior to commit:

[clang] c74dd64 - [X86] Add a Pass that builds a Condensed CFG for Load Value Injection (LVI) Gadgets

Author: Scott Constable Date: 2020-04-03T13:02:04-07:00 New Revision: c74dd640fd740c6928f66a39c7c15a014af3f66f URL: https://github.com/llvm/llvm-project/commit/c74dd640fd740c6928f66a39c7c15a014af3f66f DIFF:

[PATCH] D77028: [NFC] Refactor DeferredDiagsEmitter and skip redundant visit

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1508 void checkFunc(SourceLocation Loc, FunctionDecl *FD) { +auto DiagsCountIt = DiagsCount.find(FD); FunctionDecl *Caller = UseStack.empty() ? nullptr :

[PATCH] D66490: [NewPM] Enable the New Pass Manager by Default in Clang

leonardchan added a comment. > It seems that we can go ahead with this patch if there's no other objections. > I reran a `ninja check-clang` with this patch and all tests seem to pass (at > least when running on x64-linux). Actually disregard this. It seems that there are some compiler-rt

[PATCH] D77150: [Analyzer] New Option for ContainerModeling: AggressiveEraseModeling

Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:647-653 CmdLineOption ]>, Ah, okay, I see which one you refer to. We should totally make this non-user facing as well. Repository: rG LLVM Github

[PATCH] D77085: [clang-tidy] Added support for validating configuration options

njames93 updated this revision to Diff 254890. njames93 added a comment. - Address nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77085/new/ https://reviews.llvm.org/D77085 Files: clang-tools-extra/clang-tidy/ClangTidyCheck.cpp

[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

thakis added a comment. I pushed Andrew's fix (thanks!) (with minor formatting tweaks) in dbb0d8ecb3a024bd6817ebd8ad8c5c199a51d933 . Let me know if you still see issues. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D77390: Fix __builtin_amdgcn_workgroup_size_x/y/z return type

yaxunl closed this revision. yaxunl added a comment. b72fce1ffd0a0de5b46b486c7030d54cc5d8c225 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77390/new/ https://reviews.llvm.org/D77390

[PATCH] D77427: [X86] Add tests to clang Driver to ensure that SLH/Retpoline features are not enabled with LVI-CFI

sconstab created this revision. sconstab added a reviewer: craig.topper. https://reviews.llvm.org/D77427 Files: clang/test/Driver/x86-target-features.c Index: clang/test/Driver/x86-target-features.c === ---

[PATCH] D76184: [OpenMP][NFC] Remove the need to include `OpenMPClause.h`

rnk commandeered this revision. rnk edited reviewers, added: jdoerfert; removed: rnk. rnk added a comment. This revision now requires review to proceed. I got it building... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76184/new/

[PATCH] D76184: [OpenMP][NFC] Remove the need to include `OpenMPClause.h`

rnk updated this revision to Diff 254889. rnk added a comment. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous. - seems to build all.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76184/new/ https://reviews.llvm.org/D76184

[PATCH] D76572: Replace `T(x)` with `reinterpret_cast(x)` everywhere it means reinterpret_cast. No functional change

Quuxplusone marked an inline comment as done. Quuxplusone added a comment. @DiggerLin @ahatanak @espindola @reames Gentle ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76572/new/ https://reviews.llvm.org/D76572

[clang] 9f1c35d - Revert "[PowerPC] Replace subtract-from-zero float in version with fneg in PowerPC special fma compiler builtins"

Author: Kevin P. Neal Date: 2020-04-03T15:47:19-04:00 New Revision: 9f1c35d8b14f026b7bc4b21b9eecafbbb42c42a2 URL: https://github.com/llvm/llvm-project/commit/9f1c35d8b14f026b7bc4b21b9eecafbbb42c42a2 DIFF: https://github.com/llvm/llvm-project/commit/9f1c35d8b14f026b7bc4b21b9eecafbbb42c42a2.diff

[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

thakis added a comment. grimar, andrewng: You both have checkout and build on different drives too, yes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77184/new/ https://reviews.llvm.org/D77184 ___

[PATCH] D76949: Replace subtract-from-zero float in version with fneg in PowerPC special fma compiler builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rGba87430cadb2: [PowerPC] Replace subtract-from-zero float in version with fneg in PowerPC… (authored by ajwock, committed by kpn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75661: Remove SequentialType from the type heirarchy.

ctetreau added a comment. Herald added a subscriber: grosul1. What's the status on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75661/new/ https://reviews.llvm.org/D75661 ___ cfe-commits

[PATCH] D70366: Add new 'flatten' LLVM attribute to fix clang's 'flatten' function attribute

erichkeane added a comment. The semantics of this llvm attribute seem to better match 'flatten'. However, it is unfortunate that this doesn't change any clang tests. Can you add/alter a test in clang to validate the IR? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70366/new/

[clang] d7a0516 - Fix typo in test.

Author: Kevin P. Neal Date: 2020-04-03T15:23:49-04:00 New Revision: d7a0516ddcfe373bb780d6fc19d76fe74ecc0061 URL: https://github.com/llvm/llvm-project/commit/d7a0516ddcfe373bb780d6fc19d76fe74ecc0061 DIFF: https://github.com/llvm/llvm-project/commit/d7a0516ddcfe373bb780d6fc19d76fe74ecc0061.diff

[clang] ba87430 - [PowerPC] Replace subtract-from-zero float in version with fneg in PowerPC special fma compiler builtins

Author: Andrew Wock Date: 2020-04-03T14:59:33-04:00 New Revision: ba87430cadb2d5d0ee8e4b75101d7abcf6b321bf URL: https://github.com/llvm/llvm-project/commit/ba87430cadb2d5d0ee8e4b75101d7abcf6b321bf DIFF: https://github.com/llvm/llvm-project/commit/ba87430cadb2d5d0ee8e4b75101d7abcf6b321bf.diff

[PATCH] D70366: Add new 'flatten' LLVM attribute to fix clang's 'flatten' function attribute

lebedev.ri added a comment. In D70366#1960300 , @jdoerfert wrote: > I'm fine with this. I would hope a C/C++/Clang person will also take a look > though. This is missing clang codegen test[s]. Seems to look fine to me otherwise. CHANGES SINCE LAST

[PATCH] D77249: [MSan] Pass command line options to MSan with new pass manager

leonardchan added inline comments. Comment at: compiler-rt/test/msan/chained_origin_empty_stack_npm.cpp:4 +// this test. +// RUN: %clangxx_msan -fsanitize-memory-track-origins=2 \ +// RUN: -fexperimental-new-pass-manager -O3 %s -o %t && \ nemanjai wrote: >

[PATCH] D70366: Add new 'flatten' LLVM attribute to fix clang's 'flatten' function attribute

jdoerfert added a comment. I'm fine with this. I would hope a C/C++/Clang person will also take a look though. Comment at: llvm/docs/LangRef.rst:1398 +This attribute is similar to ``alwaysinline``, but also applies recursively to +all inlined function calls.

[PATCH] D77199: [clang-tidy] Address false positive in modernize-use-default-member-init

This revision was automatically updated to reflect the committed changes. Closed by commit rG2c7ea1c4c5f7: [clang-tidy] Address false positive in modernize-use-default-member-init (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77199: [clang-tidy] Address false positive in modernize-use-default-member-init

njames93 updated this revision to Diff 254870. njames93 added a comment. - Added test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77199/new/ https://reviews.llvm.org/D77199 Files:

[PATCH] D77054: [AArch64][SVE] Add SVE intrinsics for saturating add & subtract

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77054/new/ https://reviews.llvm.org/D77054 ___ cfe-commits mailing list

[PATCH] D73245: Avoid using std::max_align_t in pre-C++11 mode

ldionne accepted this revision. ldionne added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73245/new/ https://reviews.llvm.org/D73245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77385: [clangd] Add index inspection helper tool

sammccall added a comment. Yeah, I think adding a dump/export command to dexp would be nice. We'd have to make dexp keep the parsed input file around, or just the path and reopen it when the command is issued, but that seems OK to me. (One of the costs of adding a new binary is you have to at

[PATCH] D66490: [NewPM] Enable the New Pass Manager by Default in Clang

leonardchan added a comment. In D66490#1958747 , @aeubanks wrote: > In D66490#1638708 , @hfinkel wrote: > > > In D66490#1638162 , @rupprecht > > wrote: > > > > > We already

[PATCH] D77156: [CMAKE] Plumb include_directories() into tablegen()

stephenneuendorffer edited the summary of this revision. stephenneuendorffer updated this revision to Diff 254867. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77156/new/ https://reviews.llvm.org/D77156 Files: clang/cmake/modules/AddClang.cmake

[PATCH] D77408: [clang] Annotate trivial getters and setters on hover.

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:376 +llvm::Optional fieldName(const Expr *E) { + const auto *ReturnedMember = llvm::dyn_cast(E->IgnoreCasts()); + const auto *Field =

[clang-tools-extra] 2c7ea1c - [clang-tidy] Address false positive in modernize-use-default-member-init

Author: Nathan James Date: 2020-04-03T19:43:46+01:00 New Revision: 2c7ea1c4c5f7dde562bac684a59ad67f1f062726 URL: https://github.com/llvm/llvm-project/commit/2c7ea1c4c5f7dde562bac684a59ad67f1f062726 DIFF: https://github.com/llvm/llvm-project/commit/2c7ea1c4c5f7dde562bac684a59ad67f1f062726.diff

[clang] 0c0831f - [CMAKE] Plumb include_directories() into tablegen()

Author: Stephen Neuendorffer Date: 2020-04-03T11:23:38-07:00 New Revision: 0c0831f74b7181268a777a39ee087c9337ffa0c5 URL: https://github.com/llvm/llvm-project/commit/0c0831f74b7181268a777a39ee087c9337ffa0c5 DIFF:

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn updated this revision to Diff 254861. fhahn added a comment. Specify that standard conversion rules do not apply to assignments for matrix types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76612/new/ https://reviews.llvm.org/D76612

[PATCH] D77420: Also look for devtoolset-9 gcc toolchain

stephan.dollberg created this revision. stephan.dollberg added a reviewer: chandlerc. Herald added a project: clang. devtoolset-9 has been out for a while so also look for it. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77420 Files: clang/lib/Driver/ToolChains/Gnu.cpp

[PATCH] D75364: [clang-format] Handle macros in function params and return value

mitchell-stellar added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:7359 verifyIndependentOfContext("bool a = f() && final.f();"); + verifyFormat("int f(M(x) *p1 = nullptr, M(x) *p2, volatile M(x) *p3);"); + verifyFormat("M(x) *foo();");

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

rjmccall added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:394 + return true; + } + sepavloff wrote: > rjmccall wrote: > > sepavloff wrote: > > > erichkeane wrote: > > > > rjmccall wrote: > > > > > erichkeane wrote: > > > > > >

[PATCH] D77411: [analyzer] StdLibraryFunctionsChecker: Add test for function with default parameter

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Yay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77411/new/ https://reviews.llvm.org/D77411

[PATCH] D77419: [libTooling] Simplify the representation of Transformer's RewriteRules.

ymandel created this revision. ymandel added a reviewer: gribozavr2. Herald added a subscriber: jfb. Herald added a project: clang. This revision simplifies the representation of edits in rewrite rules. The simplified form is more general, allowing the user more flexibility in building custom

[PATCH] D76083: [clang-tidy] Expand the list of functions in bugprone-unused-return-value

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueCheck.cpp:98 + "::access;" + "::bind;" + "::connect;"

[PATCH] D77385: [clangd] Add index inspection helper tool

mnauw added a comment. Thanks for having a look at this patch. My use-case/goal would be to have a way to run/do a command that reads some index and dumps it (in e.g. YAML) to (e.g.) stdout. That way it can be inspected/viewed all at once by plain viewer. And not only symbols, refs, but also

  1   2   3   >