craig.topper added inline comments.

================
Comment at: llvm/lib/Target/X86/ImmutableGraph.h:46-56
+  using NodeValueT = _NodeValueT;
+  using EdgeValueT = _EdgeValueT;
+  using size_type = _SizeT;
+  class Node;
+  class Edge {
+    friend class ImmutableGraph;
+    template <typename> friend class ImmutableGraphBuilder;
----------------
chandlerc wrote:
> Folks, this isn't even close to following LLVM's coding conventions or naming 
> conventions.
> 
> These violate the C++ standard.
> 
> This shouldn't have been landed as-is. Can you all back this out and actually 
> dig into the review and get this to match LLVM's actual coding style and 
> standards?
Reverted at 1d42c0db9a2b27c149c5bac373caa5a6d38d1f74


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75936/new/

https://reviews.llvm.org/D75936



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to