[PATCH] D77502: [clang][CodeGen] Handle throw expression in conditional operator constant folding

rsmith added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:4337 +EmitCXXThrowExpr(ThrowExpr); +return EmitLValue(dead); + } The IR we emit for the dead operand is unreachable; it's a bit wasteful to generate it here and

[PATCH] D77484: [Vector] Pass VectLib to LTO backend so TLI build correct vector function list

ruiu added inline comments. Comment at: lld/ELF/Config.h:132 callGraphProfile; + llvm::TargetLibraryInfoImpl::VectorLibrary VectLib; bool allowMultipleDefinition; We name variables after their corresponding command line flags, so this should be

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao updated this revision to Diff 255219. hliao added a comment. Rebase to the latest trunk. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71227/new/ https://reviews.llvm.org/D71227 Files: clang/include/clang/Sema/Sema.h

[PATCH] D77113: [OpenMP][NFC] Move and simplify directive -> allowed clause mapping

This revision was automatically updated to reflect the committed changes. Closed by commit rG931c0cd713ee: [OpenMP][NFC] Move and simplify directive - allowed clause mapping (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77112: [OpenMP][NFCI] Move OpenMP clause information to `lib/Frontend/OpenMP`

jdoerfert added a comment. In D77112#1962936 , @thakis wrote: > Broke clang-tools-extra again: > http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/46759/steps/build%20stage%201/logs/stdio Fixed in 8ea07f62a6f06bdb7da981425227995423867a4d

[PATCH] D77520: Treat default values in LangOptions.def in the scope of enums

sepavloff created this revision. sepavloff added reviewers: rjmccall, rnk, arsenm. Herald added a subscriber: wdng. Herald added a project: clang. If an option specified in LangOptions.def is of enum type, its default value should be a member of that enum, so scope qualifier may always be added

[clang] 931c0cd - [OpenMP][NFC] Move and simplify directive -> allowed clause mapping

Author: Johannes Doerfert Date: 2020-04-06T00:04:08-05:00 New Revision: 931c0cd713ee9b082389727bed1b518c6a44344f URL: https://github.com/llvm/llvm-project/commit/931c0cd713ee9b082389727bed1b518c6a44344f DIFF:

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

sameerds requested changes to this revision. sameerds added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Basic/Builtins.def:1583 +// Second argument : target specific sync scope string +BUILTIN(__builtin_memory_fence, "vUicC*",

[PATCH] D77112: [OpenMP][NFCI] Move OpenMP clause information to `lib/Frontend/OpenMP`

thakis added a comment. Broke clang-tools-extra again: http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/46759/steps/build%20stage%201/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77112/new/ https://reviews.llvm.org/D77112

[clang-tools-extra] 8ea07f6 - [OpenMP] Add extra qualification to OpenMP clause id

Author: Johannes Doerfert Date: 2020-04-05T23:10:58-05:00 New Revision: 8ea07f62a6f06bdb7da981425227995423867a4d URL: https://github.com/llvm/llvm-project/commit/8ea07f62a6f06bdb7da981425227995423867a4d DIFF:

[PATCH] D77028: [NFC] Refactor DeferredDiagsEmitter and skip redundant visit

yaxunl marked 3 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1508 void checkFunc(SourceLocation Loc, FunctionDecl *FD) { +auto DiagsCountIt = DiagsCount.find(FD); FunctionDecl *Caller = UseStack.empty() ? nullptr :

[PATCH] D77414: [OpenMP] Add match_{all,any,none} declare variant selector extensions.

jdoerfert marked an inline comment as done. jdoerfert added a comment. Will fix the other two nits too. Comment at: clang/lib/Parse/ParseOpenMP.cpp:1823 ASTContext = Actions.getASTContext(); -TI.getAsVariantMatchInfo(ASTCtx, VMI, /* DeviceSetOnly */ true); +

[PATCH] D77290: [OpenMP] Specialize OpenMP calls after template instantiation

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:1693 +ExprResult TemplateInstantiator::TransformCallExpr(CallExpr *E) { + ExprResult R = TreeTransform::TransformCallExpr(E); + if

[PATCH] D68115: Zero initialize padding in unions

jfb added a comment. > That sounds reasonable to me. So the behavior we're looking for is: > > - If `-ftrivial-auto-init` is off, then we guarantee to zero padding when the > language spec requires it, and otherwise provide no such guarantee. > - If `-ftrivial-auto-init=zeroes` then we

[PATCH] D77194: [clang] Persist Attr::IsPackExpansion into the PCH

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b3b7556e9ab: [clang] Persist Attr::IsPackExpansion into the PCH (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77194/new/

[clang] 8b3b755 - [clang] Persist Attr::IsPackExpansion into the PCH

Author: Nathan Ridge Date: 2020-04-05T23:32:03-04:00 New Revision: 8b3b7556e9ab6084e9fd337d64dac1c165867d32 URL: https://github.com/llvm/llvm-project/commit/8b3b7556e9ab6084e9fd337d64dac1c165867d32 DIFF: https://github.com/llvm/llvm-project/commit/8b3b7556e9ab6084e9fd337d64dac1c165867d32.diff

[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

kuhar added inline comments. Comment at: llvm/include/llvm/IR/CFGDiff.h:198 +namespace { +template kuhar wrote: > What benefit does an anonymous namespace in a header have over a named one, > e.g., `detail`/`impl`? Doesn't it make it more difficult to

[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

kuhar added a comment. In D77341#1960854 , @asbirlea wrote: > Address comments. Thanks for the changes and explanations. It think with a few more tweaks this will be a good refactoring step towards phasing out BUI. Comment at:

[PATCH] D76646: Rename/refactor isIntegerConstantExpression to getIntegerConstantExpression

dblaikie added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76646/new/ https://reviews.llvm.org/D76646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77519: Fix __is_pointer builtin type trait to work with Objective-C pointer types.

zoecarver created this revision. Herald added projects: clang, libc++. Herald added subscribers: libcxx-commits, cfe-commits. Herald added a reviewer: libc++. zoecarver added reviewers: ldionne, rsmith, EricWF. Herald added a subscriber: dexonsmith. 5ade17e

[PATCH] D68115: Zero initialize padding in unions

rsmith added a comment. In D68115#1962863 , @jfb wrote: > In D68115#1962833 , @rsmith wrote: > > > I think the majority opinion expressed on this review at this point favors > > not guaranteeing

[PATCH] D77414: [OpenMP] Add match_{all,any,none} declare variant selector extensions.

jdoerfert updated this revision to Diff 255212. jdoerfert added a comment. Rebase and fix a problem with evaluation of non-constants Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77414/new/ https://reviews.llvm.org/D77414 Files:

[PATCH] D68115: Zero initialize padding in unions

jfb added a comment. In D68115#1962833 , @rsmith wrote: > In D68115#1946990 , @jfb wrote: > > > In D68115#1946757 , @rsmith wrote: > > > > > In D68115#1946668

[PATCH] D77290: [OpenMP] Specialize OpenMP calls after template instantiation

jdoerfert updated this revision to Diff 255210. jdoerfert added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77290/new/ https://reviews.llvm.org/D77290 Files: clang/lib/Sema/SemaTemplateInstantiate.cpp

[PATCH] D77414: [OpenMP] Add match_{all,any,none} declare variant selector extensions.

mikerice added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:1823 ASTContext = Actions.getASTContext(); -TI.getAsVariantMatchInfo(ASTCtx, VMI, /* DeviceSetOnly */ true); +TI.getAsVariantMatchInfo(ASTCtx, VMI); OMPContext

[clang] e9644e6 - DebugInfo: Fix default template parameter computation for dependent non-type template parameters

Author: David Blaikie Date: 2020-04-05T16:31:30-07:00 New Revision: e9644e6f4f21e6b6177ef9085cdc9ed9f44b7783 URL: https://github.com/llvm/llvm-project/commit/e9644e6f4f21e6b6177ef9085cdc9ed9f44b7783 DIFF: https://github.com/llvm/llvm-project/commit/e9644e6f4f21e6b6177ef9085cdc9ed9f44b7783.diff

[PATCH] D68115: Zero initialize padding in unions

rsmith added a comment. In D68115#1946990 , @jfb wrote: > In D68115#1946757 , @rsmith wrote: > > > In D68115#1946668 , > > @hubert.reinterpretcast wrote: > > > > > It

Re: [libcxx-dev] [clang] 4ede887 - PR45402: Make the restrictions on constant evaluation of memcmp and

On Sun, 5 Apr 2020 at 15:41, David Zarzycki via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Subjectively speaking, using char8_t instead of char shouldn’t feel like a > regression. So yes, making the builtin mem* functions work with char8_t > again seems right. As for strlen, I can see

Re: [libcxx-dev] [clang] 4ede887 - PR45402: Make the restrictions on constant evaluation of memcmp and

Subjectively speaking, using char8_t instead of char shouldn’t feel like a regression. So yes, making the builtin mem* functions work with char8_t again seems right. As for strlen, I can see arguments either way. Personally, if you’re concerned about clever macros, then I’d make the overload

[clang] 944db8a - Permit constant evaluation of mixed __builtin_memcmp between char and

Author: Richard Smith Date: 2020-04-05T15:35:32-07:00 New Revision: 944db8a433f591e514219c12fa33b7e8fdd5e883 URL: https://github.com/llvm/llvm-project/commit/944db8a433f591e514219c12fa33b7e8fdd5e883 DIFF: https://github.com/llvm/llvm-project/commit/944db8a433f591e514219c12fa33b7e8fdd5e883.diff

Re: [libcxx-dev] [clang] 4ede887 - PR45402: Make the restrictions on constant evaluation of memcmp and

On Sun, 5 Apr 2020 at 15:17, Richard Smith wrote: > On Sun, 5 Apr 2020 at 14:44, David Zarzycki via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> We have overloaded builtins. Can that not solve __builtin_strlen? >> > > I suppose it could, but we generally want __builtin_ to behave >

[clang] 7f24db0 - Add documentation and testing for

Author: Richard Smith Date: 2020-04-05T15:24:49-07:00 New Revision: 7f24db01751da6953782630bb42dcca8a111590b URL: https://github.com/llvm/llvm-project/commit/7f24db01751da6953782630bb42dcca8a111590b DIFF: https://github.com/llvm/llvm-project/commit/7f24db01751da6953782630bb42dcca8a111590b.diff

Re: [libcxx-dev] [clang] 4ede887 - PR45402: Make the restrictions on constant evaluation of memcmp and

On Sun, 5 Apr 2020 at 14:44, David Zarzycki via cfe-commits < cfe-commits@lists.llvm.org> wrote: > We have overloaded builtins. Can that not solve __builtin_strlen? > I suppose it could, but we generally want __builtin_ to behave the same as . (The difference would not be visible most of the

[PATCH] D77484: [Vector] Pass VectLib to LTO backend so TLI build correct vector function list

tejohnson added a comment. In D77484#1962667 , @wenlei wrote: > > Linking against two vectlibs may cause name conflicts or other issues. > > Of all three supported match libraries, all functions from Accelerate are > prefixed with `v`; all MASS library

Re: [libcxx-dev] [clang] 4ede887 - PR45402: Make the restrictions on constant evaluation of memcmp and

We have overloaded builtins. Can that not solve __builtin_strlen? -- Sent from my iPhone > On Apr 5, 2020, at 14:53, Richard Smith wrote: > >  > Thanks. We need to figure out what the right way to support char8_t with > string builtins is. These ones could work in principle, whereas things

[PATCH] D77507: [clangd] Fix HitMapping assertion in Tokens.cpp

vabridgers updated this revision to Diff 255193. vabridgers added a comment. Remove extraneous test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77507/new/ https://reviews.llvm.org/D77507 Files: clang/lib/Tooling/Syntax/Tokens.cpp

[PATCH] D77484: [Vector] Pass VectLib to LTO backend so TLI build correct vector function list

wenlei added a comment. > Linking against two vectlibs may cause name conflicts or other issues. Of all three supported match libraries, all functions from Accelerate are prefixed with `v`; all MASS library functions are suffixed with `_massv`; and all SVML functions are prefixed with

[PATCH] D77507: [clangd] Fix HitMapping assertion in Tokens.cpp

vabridgers created this revision. vabridgers added reviewers: ilya-biryukov, sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Extend test cases for tokens, and remove assertion that is unneeded and hitting in

Re: [libcxx-dev] [clang] 4ede887 - PR45402: Make the restrictions on constant evaluation of memcmp and

Thanks. We need to figure out what the right way to support char8_t with string builtins is. These ones could work in principle, whereas things like __builtin_strlen would never work because they take operands of the wrong types (and we can't cast const char8_t* -> const char* in a constant

[PATCH] D71739: [WIP] Use operand bundles to encode alignment assumptions

Tyker added a comment. In D71739#1961508 , @jdoerfert wrote: > @lebedev.ri We'd need to identify other uses of the alignment encoding > in-tree so we can replace them as well. Also, this patch uses not only the > alignment but also the offset in the

[PATCH] D77484: [Vector] Pass VectLib to LTO backend so TLI build correct vector function list

tejohnson added a comment. In D77484#1962581 , @hoyFB wrote: > In D77484#1962445 , @tejohnson wrote: > > > We're trying to move towards encoding all of this in the IR. And in fact, I > > recently implemented a

[PATCH] D77028: [NFC] Refactor DeferredDiagsEmitter and skip redundant visit

rjmccall added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1508 void checkFunc(SourceLocation Loc, FunctionDecl *FD) { +auto DiagsCountIt = DiagsCount.find(FD); FunctionDecl *Caller = UseStack.empty() ? nullptr : UseStack.back(); yaxunl

[PATCH] D77484: [Vector] Pass VectLib to LTO backend so TLI build correct vector function list

hoyFB added a comment. In D77484#1962445 , @tejohnson wrote: > We're trying to move towards encoding all of this in the IR. And in fact, I > recently implemented a series of patches to make the TLI to be built > per-function, and along with some patches

Re: [clang] a8c8b62 - [ObjC generics] Fix not inheriting type bounds in categories/extensions.

The test here flakily fails, maybe 1 in 10 times: http://45.33.8.238/mac/11180/step_7.txt error: 'error' diagnostics seen but not expected: File /Users/thakis/src/llvm-project/clang/test/SemaObjC/parameterized_classes_subst.m Line 479: type argument 'T' (aka 'id') does not satisfy the bound

[PATCH] D77502: [clang][CodeGen] Handle throw expression in conditional operator constant folding

tambre updated this revision to Diff 255175. tambre added a comment. Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77502/new/ https://reviews.llvm.org/D77502 Files: clang/lib/CodeGen/CGExpr.cpp

[PATCH] D77484: [Vector] Pass VectLib to LTO backend so TLI build correct vector function list

wenlei added a comment. In D77484#1962445 , @tejohnson wrote: > We're trying to move towards encoding all of this in the IR. And in fact, I > recently implemented a series of patches to make the TLI to be built > per-function, and along with some

[PATCH] D77503: [ASTMatchers] Fixed CastKind being parsed incorrectly for dynamic matchers

njames93 created this revision. njames93 added a reviewer: klimek. Herald added a project: clang. Herald added a subscriber: cfe-commits. Requires hasCastKind arguments to have `CK_` prefixed to bring it in line with the documentation and other matchers that take enumerations. Repository: rG

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

saiislam updated this revision to Diff 255173. saiislam added a comment. Removed OpenCL specific dependencies Now it takes target-specific sync scope as an string. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75917/new/

[clang] e01ec11 - make ccabe93298 more robust

Author: Nico Weber Date: 2020-04-05T13:07:50-04:00 New Revision: e01ec11882d3a2af509ec5caf248ecd79485240c URL: https://github.com/llvm/llvm-project/commit/e01ec11882d3a2af509ec5caf248ecd79485240c DIFF: https://github.com/llvm/llvm-project/commit/e01ec11882d3a2af509ec5caf248ecd79485240c.diff

[clang] ccabe93 - clang: Make tests using symlinks more consistent.

Author: Nico Weber Date: 2020-04-05T12:56:41-04:00 New Revision: ccabe9329857141e0b676951ff89092d7f88bed0 URL: https://github.com/llvm/llvm-project/commit/ccabe9329857141e0b676951ff89092d7f88bed0 DIFF: https://github.com/llvm/llvm-project/commit/ccabe9329857141e0b676951ff89092d7f88bed0.diff

[PATCH] D77028: [NFC] Refactor DeferredDiagsEmitter and skip redundant visit

yaxunl marked 3 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1508 void checkFunc(SourceLocation Loc, FunctionDecl *FD) { +auto DiagsCountIt = DiagsCount.find(FD); FunctionDecl *Caller = UseStack.empty() ? nullptr :

RE: [clang] b670ab7 - recommit 1b978ddba05c [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

[AMD Official Use Only - Internal Distribution Only] The issue is addressed by https://reviews.llvm.org/D77028 Sam -Original Message- From: Joerg Sonnenberger Sent: Sunday, April 5, 2020 9:48 AM To: Liu, Yaxun (Sam) ; Yaxun Liu Cc: cfe-commits@lists.llvm.org Subject: Re: [clang]

[PATCH] D77493: [clang-tidy] Add do-not-refer-atomic-twice check

abelkocsis updated this revision to Diff 255170. abelkocsis added a comment. Small fixes in doc and test files. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77493/new/ https://reviews.llvm.org/D77493 Files:

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

Charusso added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignalInMultithreadedProgramCheck.cpp:33-50 +void SignalInMultithreadedProgramCheck::registerMatchers(MatchFinder *Finder) { + auto signalCall = + callExpr( +

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

aykevl added a comment. @xbolva00 I could, but to me this is not trivial (I'm not familiar with the code and I'm not sure what I would break). If it's easy for you, then please do (otherwise I can send a patch for review). I have already worked around this issue in a different way (by running

[PATCH] D63852: [Clang] Move assembler into a separate file

aykevl added a comment. Ping? I'm not sure who to add as a reviewer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63852/new/ https://reviews.llvm.org/D63852 ___ cfe-commits mailing list

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

abelkocsis updated this revision to Diff 255169. abelkocsis marked an inline comment as done. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75229/new/ https://reviews.llvm.org/D75229 Files:

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

abelkocsis marked 2 inline comments as done. abelkocsis added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignalInMultithreadedProgramCheck.cpp:33-50 +void SignalInMultithreadedProgramCheck::registerMatchers(MatchFinder *Finder) { + auto signalCall = +

[PATCH] D77493: [clang-tidy] Add do-not-refer-atomic-twice check

njames93 added a comment. In my mind this check is definitely in the realm of the static analyser, clang-tidy just isn't designed for this. Comment at: clang-tools-extra/docs/clang-tidy/checks/list.rst:137 `cppcoreguidelines-avoid-goto `_, +

[PATCH] D77502: [clang][CodeGen] Handle throw expression in conditional operator constant folding

tambre created this revision. tambre added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. tambre edited the summary of this revision. We're smart and do constant folding when emitting conditional operators. Thus we emit the live value as a lvalue. This

[PATCH] D77484: [Vector] Pass VectLib to LTO backend so TLI build correct vector function list

tejohnson added a subscriber: gchatelet. tejohnson added a comment. We're trying to move towards encoding all of this in the IR. And in fact, I recently implemented a series of patches to make the TLI to be built per-function, and along with some patches from @gchatelet to encode -fno-builtin*

[PATCH] D77482: [clang-tools-extra] NFC: Fix trivial typo in documents and comments

Eugene.Zelenko added a comment. In D77482#1962272 , @kiszk wrote: > I have done in https://reviews.llvm.org/D77458 Just abandon this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77482/new/

[PATCH] D77499: [ASTMatchers] Matchers that take enumerations args provide hints with invalid arguments

njames93 created this revision. njames93 added a reviewer: klimek. Herald added subscribers: cfe-commits, mgorny. Herald added a reviewer: jdoerfert. Herald added a project: clang. njames93 edited the summary of this revision. Herald added a subscriber: dexonsmith. This adds support for giving

[PATCH] D77498: [Hexagon] Select lld as the default linker for linux-musl target

sidneym created this revision. sidneym added reviewers: adasgupt, bcain, kparzysz, bcahoon, shankare. Herald added a project: clang. Herald added a subscriber: cfe-commits. When the target is hexagon-unknown-linux-musl select lld as the default linker. Repository: rG LLVM Github Monorepo

Re: [clang] b670ab7 - recommit 1b978ddba05c [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

On Mon, Mar 23, 2020 at 09:09:31AM -0700, Yaxun Liu via cfe-commits wrote: > > Author: Yaxun (Sam) Liu > Date: 2020-03-23T12:09:07-04:00 > New Revision: b670ab7b6b3d2f26179213be1da1d4ba376f50a3 > > URL: > https://github.com/llvm/llvm-project/commit/b670ab7b6b3d2f26179213be1da1d4ba376f50a3 >

[PATCH] D77482: [clang-tools-extra] NFC: Fix trivial typo in documents and comments

kiszk added a comment. I have done in https://reviews.llvm.org/D77458 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77482/new/ https://reviews.llvm.org/D77482 ___ cfe-commits mailing list

[PATCH] D77474: [analyzer][MallocChecker] Make NewDeleteLeaks depend on DynamicMemoryModeling rather than NewDelete

Szelethus added a comment. Btw this branch is about 7 months old, and I just now remembered why I haven't rushed publishing it. My ultimate idea (as opposed to the two detailed in the summary) was to introduce a subchecker system in MallocChecker, which also strongly ties into D67336

[PATCH] D77491: [Sema] Fix incompatible builtin redeclarations in non-global scope

tambre created this revision. tambre added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. We didn't mark them previously as non-builtin in non-global scope if we determined they were incompatible redeclarations. This caused problems down the line with

[clang] 2c88a48 - [clang] Make libcxx test suite pass again after memcmp changes

Author: David Zarzycki Date: 2020-04-05T07:16:47-04:00 New Revision: 2c88a485c71155c19e512f22c54e63ee337282a3 URL: https://github.com/llvm/llvm-project/commit/2c88a485c71155c19e512f22c54e63ee337282a3 DIFF:

Re: [libcxx-dev] [clang] 4ede887 - PR45402: Make the restrictions on constant evaluation of memcmp and

Hi Richard, I'm going to commit a narrow fix to clang to make the libcxx test suite pass again by allowing char8_t again. If you feel that this is the wrong long-term solution, please help the libcxx folks with whatever adjustments they need. Thanks! Dave On Sat, Apr 4, 2020, at 9:55 AM,

[PATCH] D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts

zinovy.nis updated this revision to Diff 255128. zinovy.nis added a comment. Rebase over the current master. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74692/new/ https://reviews.llvm.org/D74692 Files: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp

[PATCH] D77458: [clang-tools-extra] NFC: Fix trivial typo in documents and comments

kiszk updated this revision to Diff 255120. kiszk added a comment. This include the fix of the build failure at http://lab.llvm.org:8011/builders/clang-cmake-armv7-global-isel/builds/7450/steps/ninja%20check%201/logs/FAIL%3A%20Clang%20Tools%3A%3Afuchsia-multiple-inheritance.cpp CHANGES SINCE

[clang-tools-extra] dd5571d - [clang-tools-extra] NFC: Fix trivial typo in documents and comments

Author: Kazuaki Ishizaki Date: 2020-04-05T15:28:40+09:00 New Revision: dd5571d51a0f6164cb66d02c8cd0e7032e42abe4 URL: https://github.com/llvm/llvm-project/commit/dd5571d51a0f6164cb66d02c8cd0e7032e42abe4 DIFF:

[PATCH] D77458: [clang-tools-extra] NFC: Fix trivial typo in documents and comments

kiszk updated this revision to Diff 255119. kiszk added a comment. This includes a fix to break the llvm build CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77458/new/ https://reviews.llvm.org/D77458 Files: clang-tools-extra/clang-change-namespace/ChangeNamespace.cpp

[PATCH] D77484: [Vector] Pass VectLib to LTO backend so TLI build correct vector function list

MaskRay added a comment. Added usual lld and LTO side reviewers. I am just a bit worried that option name changes like this patch and D77231 could accidentally slip through if I did not react in time... Repository: rG LLVM Github Monorepo CHANGES SINCE