[PATCH] D77621: ADT: SmallVector size/capacity use word-size integers when elements are small

smeenai added inline comments. Comment at: llvm/include/llvm/ADT/SmallVector.h:52 + // The maximum size depends on size_type used. + static constexpr size_t SizeMax() { +return std::numeric_limits::max(); browneee wrote: > dexonsmith wrote: > > STL data str

[PATCH] D72281: [Matrix] Add matrix type to Clang.

rjmccall added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:1274 + TRY_TO(TraverseType(TL.getTypePtr()->getElementType())); +}) + Might as well do this instead of accumulating the technical debt. MatrixTypeLoc should store the att

[PATCH] D78035: [PoC][RISCV] enable LTO/ThinLTO on RISCV

khchen updated this revision to Diff 261132. khchen retitled this revision from "[PoC][RISCV] enable LTO/ThinLTO on RISCV " to "[PoC][RISCV] enable LTO/ThinLTO on RISCV". khchen edited the summary of this revision. khchen added a comment. Herald added a project: clang. Herald added a subscriber: c

[PATCH] D78655: [HIP] Let lambda be host device by default

hliao added a comment. In D78655#2003837 , @yaxunl wrote: > In D78655#2003681 , @hliao wrote: > > > I though the goal of adding HD/D attributes for lambda is to make the > > static check easier as lambda used in de

[PATCH] D78655: [HIP] Let lambda be host device by default

hliao added a comment. In D78655#2011823 , @pfultz2 wrote: > > says we capture host variable reference in a device lambda. > > Is that required to be an error? I know @AlexVlx added support to hcc at one > point to capture host variables by reference. So

[PATCH] D78655: [HIP] Let lambda be host device by default

pfultz2 added a subscriber: AlexVlx. pfultz2 added a comment. > says we capture host variable reference in a device lambda. Is that required to be an error? I know @AlexVlx added support to hcc at one point to capture host variables by reference. So it seems to be possible for it to work correc

[PATCH] D78694: [clang-format] Fix lambda with ellipsis in return type

johnchen902 added a comment. Well... I don't know how to land this. I guess I don't have commit access anyway. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78694/new/ https://reviews.llvm.org/D78694 ___ cfe-commits mailing list cfe-commit

[PATCH] D77168: Add a flag to debug automatic variable initialization

jfb added a comment. I think you want to emit a diagnostic any time auto-init doesn't happen because of this new flag. With the code simplification I propose, it would be pretty hard to introduce a regression... and it someone does it wouldn't be a silent one :) Comment at:

Buildbot numbers for the last week of 04/19/2020 - 04/25/2020

Hello everyone, Below are some buildbot numbers for the last week of 04/19/2020 - 04/25/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from gre

Buildbot numbers for the last week of 04/12/2020 - 04/18/2020

Hello everyone, Below are some buildbot numbers for the last week of 04/12/2020 - 04/18/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from gre

[PATCH] D79094: [SemaObjC] Warn on visibility attributes on an @implementation

ahatanak added a comment. What if someone wants to use the attribute on either the interface or the implementation but can't modify the header? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79094/new/ https://reviews.llvm.org/D79094 ___ cf

[PATCH] D79094: [SemaObjC] Warn on visibility attributes on an @implementation

ahatanak added a comment. This seems fine to me unless there are cases where the user wants to use it on the implementation. I can't think of a case where that is needed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79094/new/ https://reviews.llvm.org/D79094 ___

[PATCH] D77221: [AVR] Rework MCU family detection to support more AVR MCUs

aykevl added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. A thought: should the AVR family be included in the target triple? Like `avr5-unknown-unknown` (similar to `armv6m-none-eabi`, `armv7m-none-eabi`, etc). The different variations do sometimes change the

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

kbobyrev added a comment. In D79014#2011034 , @sammccall wrote: > I think there's more, just running a local shared build so I can catch them > (I should really have done this ahead of time). Ah, I've done that (since I primarily build in the shared mod

[PATCH] D78979: OpenCL: Include builtin header by default

jvesely added a comment. In D78979#2006901 , @yaxunl wrote: > In D78979#2006847 , @arsenm wrote: > > > I'm also wondering if using -nogpulib for the corresponding linker purpose > > was correct, since in the OpenCL

[PATCH] D79147: [WIP] Merge -debug-info-kind=constructor into -debug-info-kind=limited

akhuang created this revision. Herald added subscribers: lldb-commits, cfe-commits, aprantl. Herald added projects: clang, LLDB. There will be an RFC for this in cfe-dev. This reduces the amount of class debug info emitted in Limited debug info mode. Repository: rG LLVM Github Monorepo https:

[PATCH] D79142: [clangd] Render doc-comment code spans with `backticks` in plaintext mode

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D79142 Files: clang-tools-extra/cla

[PATCH] D74813: [RFC] Add hash of block contents to function block names

dexonsmith added a comment. In D74813#2011083 , @alexbdv wrote: > @dexonsmith what regression are you referring to ? > What this change is effectively doing now is changing the numbering of the > blocks from incremental to hash-based. > So the demangle

[PATCH] D79139: [clangd] Fix whitespace between chunks in markdown paragraphs.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Old model: chunks are always separated by one space. This makes it impossible to render "Foo `bar`.

[PATCH] D79079: [clangd] Make use of URIs in FileShardedIndex

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/FileIndex.h:59 +/// A container of slabs associated with a key. It can be updated at key +/// granularity, replacing all

[PATCH] D78659: Add nomerge function attribute to supress tail merge optimization in simplifyCFG

rnk added a comment. I think this looks good, but I would like to get a second opinion from Alina (@asbirlea). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78659/new/ https://reviews.llvm.org/D78659 ___ cfe-commits mailing list cfe-commit

[PATCH] D77456: [clangd] Parse `foo` in documentation comments and render as code.

This revision was automatically updated to reflect the committed changes. Closed by commit rG30d17d885283: [clangd] Parse `foo` in documentation comments and render as code. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D77456?vs=255010&id=261063#toc Repository:

[PATCH] D79079: [clangd] Make use of URIs in FileShardedIndex

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/Background.cpp:183 const auto &IGN = IndexIt.getValue(); // Note that sources do not contain any information regarding missing // headers, since we

[PATCH] D78659: Add nomerge function attribute to supress tail merge optimization in simplifyCFG

zequanwu updated this revision to Diff 261059. zequanwu marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78659/new/ https://reviews.llvm.org/D78659 Files: llvm/docs/LangRef.rst llvm/include/llvm/Bitcode/LLVMBitCodes.h llvm/include/llvm/IR/Attributes.t

[PATCH] D79079: [clangd] Make use of URIs in FileShardedIndex

kadircet updated this revision to Diff 261061. kadircet marked 2 inline comments as done. kadircet added a comment. - Update FileSymbols to express keys are not necessarily file paths. - Use Uri for keys of PreambleSymbols Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D77456: [clangd] Parse `foo` in documentation comments and render as code.

sammccall marked an inline comment as done. sammccall added a comment. Discussed offline, will follow up with fix for spaces and preserving backticks in text. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77456/new/ https://reviews.llvm.org/D77456

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

jsji added a comment. Thanks all, yes, it is passing now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79014/new/ https://reviews.llvm.org/D79014 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[libclc] 174c41d - libclc: Pass system libraries to the linker after llvm libraries

Author: Tom Stellard Date: 2020-04-29T15:34:54-07:00 New Revision: 174c41defc63db4ac7594e00a5044672ff624a31 URL: https://github.com/llvm/llvm-project/commit/174c41defc63db4ac7594e00a5044672ff624a31 DIFF: https://github.com/llvm/llvm-project/commit/174c41defc63db4ac7594e00a5044672ff624a31.diff

[clang-tools-extra] 30d17d8 - [clangd] Parse `foo` in documentation comments and render as code.

Author: Sam McCall Date: 2020-04-30T00:22:15+02:00 New Revision: 30d17d88528329558b6df22cc9595eae95a9f77c URL: https://github.com/llvm/llvm-project/commit/30d17d88528329558b6df22cc9595eae95a9f77c DIFF: https://github.com/llvm/llvm-project/commit/30d17d88528329558b6df22cc9595eae95a9f77c.diff LO

Re: [PATCH] D78853: [Analysis] Fix null pointer dereference warnings [1/n]

Am 29.04.20 um 23:11 schrieb Mandeep Singh Grang: > My previous email details why we are doing > this: http://lists.llvm.org/pipermail/llvm-dev/2020-April/141167.html > Basically, we ran the PREfast static analysis tool on LLVM/Clang and > it reported a lot of warnings. I guess some of them are fal

[PATCH] D79121: Add nomerge function attribute to clang

rnk added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1799 + let Spellings = [Clang<"nomerge">]; + let Subjects = SubjectList<[Function]>; + let Documentation = [NoMergeDocs]; Clang supports many function-like things that are not functions,

[PATCH] D49890: Clang-Tidy Export Problem

ngzhian added a comment. I found this patch while searching for a similar problem I faced while tryin to use clang-tidy to fix some warnings in V8 (Chrome's JavaScript engine). The setup for our compilation is as such: - basedir - src/ - out/ -arch1/ - .o files, generated files -

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

rjmccall added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78785/new/ https://reviews.llvm.org/D78785 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang] 5b862b6 - Fix ext-int Sema test that didn't specify a triple.

Author: Erich Keane Date: 2020-04-29T14:34:53-07:00 New Revision: 5b862b6aa7705fdbd893dc5946289631e7b6d662 URL: https://github.com/llvm/llvm-project/commit/5b862b6aa7705fdbd893dc5946289631e7b6d662 DIFF: https://github.com/llvm/llvm-project/commit/5b862b6aa7705fdbd893dc5946289631e7b6d662.diff L

[PATCH] D78659: Add nomerge function attribute to supress tail merge optimization in simplifyCFG

rnk added a comment. This looks pretty close, let's do one more iteration. Comment at: llvm/include/llvm/IR/InstrTypes.h:1720 + /// Determine if the invoke cannot be tail merged. + bool cannotMerge() const { return hasFnAttr(Attribute::NoMerge); } Let's say

[PATCH] D68049: Propeller: Clang options for basic block sections

tmsriram added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68049/new/ https://reviews.llvm.org/D68049 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D78756: [SveEmitter] Add builtins for svreinterpret

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7880 +return Builder.CreateBitCast(Val, Ty); + } + sdesmalen wrote: > efriedma wrote: > > sdesmalen wrote: > > > efriedma wrote: > > > > I'm vaguely suspicious this might be wrong fo

[PATCH] D78827: Add support for #pragma clang fp reassoc(on|off) -- floating point control of associative math transformations

mibintc updated this revision to Diff 261036. mibintc added a comment. Thanks for your review @sepavloff and @erichkeane, I have responded to your feedback and reverted the name back to reassoc which is what Serge prefers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. Sorry please adjust the patch to remove the un-related changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78982/new/ https://reviews.llvm.org/D78982 __

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. LGTM with minor comment. Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:2143 + case GlobalValue::AvailableExternallyLinkage: +report_fatal_error("Unhandled AvailableExtern

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:1143 Style.PenaltyReturnTypeOnItsOwnLine = 1000; + Style.AllowShortEnumsOnASingleLine = (Language != FormatStyle::LK_Cpp); Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_None;

Re: [PATCH] D78853: [Analysis] Fix null pointer dereference warnings [1/n]

My previous email details why we are doing this: http://lists.llvm.org/pipermail/llvm-dev/2020-April/141167.html Basically, we ran the PREfast static analysis tool on LLVM/Clang and it reported a lot of warnings. I guess some of them are false positives after all. As David suggests that maybe I sh

[PATCH] D74813: [RFC] Add hash of block contents to function block names

alexbdv added a comment. @dexonsmith what regression are you referring to ? What this change is effectively doing now is changing the numbering of the blocks from incremental to hash-based. So the demangler functionality remains the same (i think) - I saw that it is ignoring the (currently incr

[PATCH] D78756: [SveEmitter] Add builtins for svreinterpret

sdesmalen marked an inline comment as done. sdesmalen added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7880 +return Builder.CreateBitCast(Val, Ty); + } + efriedma wrote: > sdesmalen wrote: > > efriedma wrote: > > > I'm vaguely suspicious th

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

sammccall added a comment. In D79014#2011034 , @sammccall wrote: > I think there's more, just running a local shared build so I can catch them > (I should really have done this ahead of time). OK, this now builds for me in shared mode after e7a7deb60ab

[PATCH] D78762: build: use `find_package(Python3)` if available

thakis added a comment. I attempted a fix in e071ea48e923651ae21b9b684b0473248630322c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78762/new/ https://reviews.llvm.org/D78762

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

erichkeane added a comment. Alright then, I've disabled by default(911add149af563a5a61458de0dd730e3f5348623 ). I'll enable 1 at a time as I fix the calling conventions in D79118 . Repository:

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

sammccall added a comment. I think there's more, just running a local shared build so I can catch them (I should really have done this ahead of time). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79014/new/ https://reviews.llvm.org/D79014

[clang] 911add1 - Disable _ExtInt by default

Author: Erich Keane Date: 2020-04-29T13:48:12-07:00 New Revision: 911add149af563a5a61458de0dd730e3f5348623 URL: https://github.com/llvm/llvm-project/commit/911add149af563a5a61458de0dd730e3f5348623 DIFF: https://github.com/llvm/llvm-project/commit/911add149af563a5a61458de0dd730e3f5348623.diff L

[clang-tools-extra] e7a7deb - [clangd] Fix BUILD_SHARED_LIBS build more.

Author: Sam McCall Date: 2020-04-29T22:46:41+02:00 New Revision: e7a7deb60ab0ee4ccd9e1f0de8e164b615344ae2 URL: https://github.com/llvm/llvm-project/commit/e7a7deb60ab0ee4ccd9e1f0de8e164b615344ae2 DIFF: https://github.com/llvm/llvm-project/commit/e7a7deb60ab0ee4ccd9e1f0de8e164b615344ae2.diff LO

[PATCH] D74813: [RFC] Add hash of block contents to function block names

dexonsmith added a comment. In D74813#2010859 , @erik.pilkington wrote: > In D74813#2010767 , @alexbdv wrote: > > > @erik.pilkington would the hash-based numbering be OK for now ? > > > Feel free to drop the demang

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

DiggerLin updated this revision to Diff 261004. DiggerLin marked an inline comment as done. DiggerLin added a comment. take out the functionality of "remove -u from clang" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76932/new/ https://reviews.ll

[PATCH] D78762: build: use `find_package(Python3)` if available

thakis added a comment. I believe this breaks check-builtins on macOS. See https://bugs.chromium.org/p/chromium/issues/detail?id=1076480 for details. The `split()` on the subprocess output throws since it wants a b'.' on py3, but that code has an unqualified except block. That means (I think) w

[PATCH] D79121: Add nomerge function attribute to clang

zequanwu created this revision. zequanwu added a reviewer: rnk. zequanwu added a project: clang. Herald added a subscriber: cfe-commits. Related to D78659 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D79121 Files: clang/include/clang/Basic/

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao updated this revision to Diff 261003. hliao added a comment. Rebase to trunk and resolve the conflict. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71227/new/ https://reviews.llvm.org/D71227 Files: clang/include/clang/Sema/Sema.h clang/

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

kbobyrev added a comment. Ah, sorry, stale tab :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79014/new/ https://reviews.llvm.org/D79014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

kbobyrev added a comment. In D79014#2010746 , @jsji wrote: > Looks like this is causing buildbot failure when built with > `-DBUILD_SHARED_LIBS=ON`. > > http://lab.llvm.org:8011/builders/clang-ppc64le-rhel/builds/3077/steps/build%20stage%201/logs/stdio

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

erichkeane added a comment. See my audit/WIP on calling conventions here: https://reviews.llvm.org/D79118 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78785/new/ https://reviews.llvm.org/D78785 ___ cf

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

rjmccall added a comment. In D78785#2010738 , @erichkeane wrote: > In D78785#2010654 , @rjmccall wrote: > > > Every target does something similar, they just all do it in different ways > > because they're mostly wr

[PATCH] D74813: [RFC] Add hash of block contents to function block names

erik.pilkington edited reviewers, added: rjmccall; removed: libc++abi. erik.pilkington added a comment. In D74813#2010767 , @alexbdv wrote: > @erik.pilkington would the hash-based numbering be OK for now ? Feel free to drop the demangler changes for now,

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

sammccall added a comment. In D79014#2010746 , @jsji wrote: > Looks like this is causing buildbot failure when built with > `-DBUILD_SHARED_LIBS=ON`. > > http://lab.llvm.org:8011/builders/clang-ppc64le-rhel/builds/3077/steps/build%20stage%201/logs/stdio

[PATCH] D79117: [clang] [Darwin] Add reverse mappings for aarch64/aarch64_32 to darwin arch names

mstorsjo created this revision. mstorsjo added a reviewer: t.p.northover. Herald added subscribers: danielkiss, kristof.beyls. Herald added a project: clang. These are mapped in MachO::getMachOArchName already, but were missing in ToolChain::getDefaultUniversalArchName. Having these reverse mapp

[clang-tools-extra] bc029fa - [clangd] Still need pthreads in clangDaemon.

Author: Sam McCall Date: 2020-04-29T21:41:12+02:00 New Revision: bc029fa6c5cdc28fa2087f721e5ffe27d9b24ecd URL: https://github.com/llvm/llvm-project/commit/bc029fa6c5cdc28fa2087f721e5ffe27d9b24ecd DIFF: https://github.com/llvm/llvm-project/commit/bc029fa6c5cdc28fa2087f721e5ffe27d9b24ecd.diff LO

[PATCH] D79113: Revert "Remove false positive in AvoidNonConstGlobalVariables."

vingeldal created this revision. Herald added subscribers: cfe-commits, kbarton, nemanjai. Herald added a project: clang. vingeldal added reviewers: aaron.ballman, lebedev.ri, JonasToth, gribozavr2. Herald added a subscriber: wuzish. There was concernes about a false positive in clang-tidy check A

[PATCH] D71124: [RISCV] support clang driver to select cpu

lenary added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. This is looking good. I remember we discussed this on the LLVM call a few weeks ago - there was a discussion as to whether we should be prioritising `-march` or `-mcpu` - do you recall the outcome of

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

jsji added a comment. Herald added a subscriber: wuzish. Looks like this is causing buildbot failure when built with `-DBUILD_SHARED_LIBS=ON`. http://lab.llvm.org:8011/builders/clang-ppc64le-rhel/builds/3077/steps/build%20stage%201/logs/stdio FAILED: lib/libclangDaemon.so.11git : && /home/b

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

erichkeane added a comment. In D78785#2010654 , @rjmccall wrote: > Every target does something similar, they just all do it in different ways > because they're mostly written by different people. > > We should restrict this feature to targets where we've

[PATCH] D74813: [RFC] Add hash of block contents to function block names

alexbdv added a comment. @erik.pilkington would the hash-based numbering be OK for now ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74813/new/ https://reviews.llvm.org/D74813 ___ cfe-commits mailing

[PATCH] D78979: OpenCL: Include builtin header by default

Anastasia added a comment. In D78979#2010527 , @svenvh wrote: > In D78979#2007643 , @Anastasia wrote: > > > > Would it not become confusing since the builtins are going to be included > > > by default? Should we re

[PATCH] D78979: OpenCL: Include builtin header by default

Anastasia added a comment. In D78979#2007760 , @yaxunl wrote: > In D78979#2007643 , @Anastasia wrote: > > > ah I guess if we leave it under `-cc1 ` we will have the command line > > interface as follows: > > > > -

[clang] b5a4dee - [NFC] Split ext-int calling convention tests into their own file.

Author: Erich Keane Date: 2020-04-29T12:20:21-07:00 New Revision: b5a4deec6a70da8a1024a2227be66f88e9276b08 URL: https://github.com/llvm/llvm-project/commit/b5a4deec6a70da8a1024a2227be66f88e9276b08 DIFF: https://github.com/llvm/llvm-project/commit/b5a4deec6a70da8a1024a2227be66f88e9276b08.diff L

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

erichkeane added a comment. 2 small things, @rjmccall and @sepavloff , anything else? Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:870 +def err_pragma_fenv_requires_precise : Error< + "'#pragma STDC FENV_ACCESS ON' is illegal when precise is disabled">; def w

[PATCH] D79087: [SVE][Codegen] Lower legal min & max operations

efriedma added a subscriber: huihuiz. efriedma added inline comments. Comment at: llvm/lib/Target/AArch64/SVEInstrFormats.td:3851 + def : SVE_1_Op_Imm_Arith_Pred_Pat(NAME # _S)>; + def : SVE_1_Op_Imm_Arith_Pred_Pat(NAME # _D)>; } I don't see any test for this

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

rjmccall added a comment. Every target does something similar, they just all do it in different ways because they're mostly written by different people. We should restrict this feature to targets where we've adequately audited the ABI. It's not a feature until the ABI work is done. Repositor

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a1d9c0f5ac8: Fix x86/x86_64 calling convention for _ExtInt (authored by erichkeane). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D79076: [clang] [MinGW] Add the compiler rt libdirs to the search path

This revision was automatically updated to reflect the committed changes. Closed by commit rGa0e53de472c5: [clang] [MinGW] Add the compiler rt libdirs to the search path (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79076/new/

[PATCH] D78756: [SveEmitter] Add builtins for svreinterpret

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7880 +return Builder.CreateBitCast(Val, Ty); + } + sdesmalen wrote: > efriedma wrote: > > I'm vaguely suspicious this might be wrong for big-endian targets. I mean, > > this isn't

[PATCH] D79106: [clangd] Move inserted include from detail -> documentation.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Many clients try to display all the detail inline, with poor results. Repository: rG LLVM

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked an inline comment as done. mibintc added inline comments. Comment at: clang/include/clang/AST/Expr.h:2701 + FPOptions FPFeatures; + mibintc wrote: > erichkeane wrote: > > This type already has trailing-storage type stuff. I think in the past >

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

erichkeane added a comment. In D78785#2010546 , @rjmccall wrote: > Could you answer my question up-thread about whether ExtInt is currently > target-limited? If it isn't, we need to more broadly audit targets. Yikes! I missed that question, I'm sorry

[clang] 5a1d9c0 - Fix x86/x86_64 calling convention for _ExtInt

Author: Erich Keane Date: 2020-04-29T11:04:25-07:00 New Revision: 5a1d9c0f5ac85b486a539b1d9558205821f17b33 URL: https://github.com/llvm/llvm-project/commit/5a1d9c0f5ac85b486a539b1d9558205821f17b33 DIFF: https://github.com/llvm/llvm-project/commit/5a1d9c0f5ac85b486a539b1d9558205821f17b33.diff L

[clang] a0e53de - [clang] [MinGW] Add the compiler rt libdirs to the search path

Author: Martin Storsjö Date: 2020-04-29T20:35:50+03:00 New Revision: a0e53de472c5b9538884f23eb8f47c3bc734b345 URL: https://github.com/llvm/llvm-project/commit/a0e53de472c5b9538884f23eb8f47c3bc734b345 DIFF: https://github.com/llvm/llvm-project/commit/a0e53de472c5b9538884f23eb8f47c3bc734b345.diff

[PATCH] D78903: [Driver] Add option -fproc-stat-report

aganea added inline comments. Comment at: clang/docs/UsersManual.rst:770 + $ cat abc + clang-11,"/tmp/foo-123456.o",92000,84000,87536 + ld,"a.out",900,8000,53568 sepavloff wrote: > aganea wrote: > > Please add a header to the output .CSV, specifying the uni

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

rjmccall added a comment. Could you answer my question up-thread about whether ExtInt is currently target-limited? If it isn't, we need to more broadly audit targets. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78785/new/ https://reviews.llvm.org/D78785 __

[PATCH] D78979: OpenCL: Include builtin header by default

svenvh added a comment. In D78979#2007643 , @Anastasia wrote: > > Would it not become confusing since the builtins are going to be included > > by default? Should we rename the flag at least? Also ideally it should be > > documented in https://clang.llvm

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware updated this revision to Diff 260944. baloghadamsoftware added a comment. Now I made some good progress, thank you @NoQ for your suggestions. Not all of them are implemented yet (currently the +-1 with the indices seem to be working, thus I will fix that part later), but now I

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78785/new/ https://reviews.llvm.org/D78785 ___ cfe-commits mailing list c

[PATCH] D78903: [Driver] Add option -fproc-stat-report

sepavloff marked 3 inline comments as done. sepavloff added inline comments. Comment at: clang/docs/UsersManual.rst:770 + $ cat abc + clang-11,"/tmp/foo-123456.o",92000,84000,87536 + ld,"a.out",900,8000,53568 aganea wrote: > Please add a header to the outpu

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

asmith marked 2 inline comments as done. asmith added inline comments. Comment at: clang/lib/Format/Format.cpp:1143 Style.PenaltyReturnTypeOnItsOwnLine = 1000; + Style.AllowShortEnumsOnASingleLine = (Language != FormatStyle::LK_Cpp); Style.AllowShortFunctionsOnASingleLine

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

asmith updated this revision to Diff 260932. asmith retitled this revision from "[clang-format] Fix Microsoft style for C++ enums" to "[clang-format] Fix Microsoft style for enums". asmith edited the summary of this revision. asmith added a comment. Enable for C# CHANGES SINCE LAST ACTION htt

[PATCH] D79095: [clang-format] NFC Correct clang-format headers file so documentation can be once again autogenerated

krasimir added a comment. Awesome! Thank you! Now that we've got "clang/phabricator/lint/git" robots that leave comments on patches, we may want to think about a way to have this automatically enforced in the future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D78118: [analyzer] StdLibraryFunctionsChecker: Add option to display loaded summaries

martong updated this revision to Diff 260930. martong marked 2 inline comments as done. martong added a comment. - Use Decl::print and 'for: ' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78118/new/ https://reviews.llvm.org/D78118 Files: clang/

[PATCH] D79095: [clang-format] NFC Correct clang-format headers file so documentation can be once again autogenerated

MyDeveloperDay added a comment. In D79095#2010250 , @krasimir wrote: > Awesome! Thank you! > Now that we've got "clang/phabricator/lint/git" robots that leave comments > on patches, we may want to think about a way to have this automatically > enforced

[PATCH] D78118: [analyzer] StdLibraryFunctionsChecker: Add option to display loaded summaries

martong marked 4 inline comments as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:651 +// Get the declaration of a function proto as written in the source file. +StringRef ToString(const FunctionDecl *FD)

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

yroux added inline comments. Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp:5606 + // candidates. + auto CantGuaranteeValueAcrossCall = [&TRI](outliner::Candidate &C) { +// If the unsafe registers in this block are all dead, then we don't need yroux w

[PATCH] D79095: [clang-format] NFC Correct clang-format headers file so documentation can be once again autogenerated

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:1752 LngFunctionDeclaration(); +**InsertTrailingCommas** (``TrailingCommaStyle``) NOT

[PATCH] D79095: [clang-format] NFC Correct clang-format headers file so documentation can be once again autogenerated

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: mprobst, krasimir, mitchell-stellar, asmith. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay edited the summary of this revision. MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline com

[PATCH] D78982: [clang-format] Fix Microsoft style for C++ enums

MyDeveloperDay added a comment. see D79095: [clang-format] NFC Correct clang-format headers file so documentation can be once again autogenerated this should be handled separately. Comment at: clang/docs/ClangFormatStyleOptions.rst:721 - -**I

[PATCH] D78982: [clang-format] Fix Microsoft style for C++ enums

asmith added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:721 - -**InsertTrailingCommas** (``TrailingCommaStyle``) can be set to ``TCS_Wrapped`` - to insert trailing commas in container literals (arrays and objects) that wrap MyDeveloperD

[PATCH] D79094: [SemaObjC] Warn on visibility attributes on an @implementation

erik.pilkington created this revision. erik.pilkington added reviewers: rjmccall, aaron.ballman. Herald added subscribers: ributzka, dexonsmith, jkorous. D60542 added support for attributes on `@implementation`s, but CodeGen always looks for visibility attributes

  1   2   >