[PATCH] D78429: [clangd] Metric tracking through Tracer

kadircet updated this revision to Diff 261441. kadircet marked 4 inline comments as done. kadircet added a comment. - Change IsEmpty with SizeIs - Make TestTracer thread-safe Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78429/new/ https://reviews.

[PATCH] D79232: [analyzer] Refactor range inference for symbolic expressions

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. This change intr

[clang] c298e5a - [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

Author: Samuel Thibault Date: 2020-05-01T12:12:27+02:00 New Revision: c298e5a022928b59941d74680a41fc9c76038b2a URL: https://github.com/llvm/llvm-project/commit/c298e5a022928b59941d74680a41fc9c76038b2a DIFF: https://github.com/llvm/llvm-project/commit/c298e5a022928b59941d74680a41fc9c76038b2a.dif

[clang] 68e89c5 - [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

Author: Samuel Thibault Date: 2020-05-01T12:37:12+02:00 New Revision: 68e89c5b96038e00aeeffa642c415cfc0bcaa3dc URL: https://github.com/llvm/llvm-project/commit/68e89c5b96038e00aeeffa642c415cfc0bcaa3dc DIFF: https://github.com/llvm/llvm-project/commit/68e89c5b96038e00aeeffa642c415cfc0bcaa3dc.dif

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

samparker added a comment. Thanks for adding the MVE changes, but I also still don't see any DSP tests, i.e QADD, SADD16. Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp:5753 + // ahead and skip over them. + if (MI.isKill()) +return outliner::InstrType::Invisible; -

[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

CarolineConcatto updated this revision to Diff 261451. CarolineConcatto marked 3 inline comments as done. CarolineConcatto added a comment. This patch updates the flag name from ffc-fortran-name to cfc-fortran-name, where cfc stands for custom frontend compiler. Moreover, the tests need pruning t

[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

CarolineConcatto added inline comments. Comment at: clang/test/Driver/flang/clang-driver-2-frontend01.f90:10 +! RUN: cp %clang %t1 +! RUN: %clang --driver-mode=flang -fortran-fe %basename_t.tmp1 -### %s 2>&1 | FileCheck --check-prefixes=ALL %s + awarzynski wrote

[PATCH] D79044: [AIX] Avoid structor alias; die before bad alias codegen

jasonliu accepted this revision. jasonliu added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79044/new/ https://reviews.llvm.org/D79044 __

[PATCH] D79213: [hip] Add noalias on restrict qualified coerced hip pointers

yaxunl added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2556-2563 + // Restrict qualified HIP pointers that were coerced to global pointers + // can be marked with the noalias attribute. + if (isCoercedHIPGlobalPointer(*this, getLangOpts(), ArgI, Ty)

[clang] b9d50bd - Fix pr31836 on Windows too, and correctly handle repeated separators.

Author: Nico Weber Date: 2020-05-01T14:17:01-04:00 New Revision: b9d50bdff211eb806dce5bc42167a6b9c0cac6e6 URL: https://github.com/llvm/llvm-project/commit/b9d50bdff211eb806dce5bc42167a6b9c0cac6e6 DIFF: https://github.com/llvm/llvm-project/commit/b9d50bdff211eb806dce5bc42167a6b9c0cac6e6.diff LO

[clang] cac8cd0 - [clang] [unittest/AST] Fix linking to LLVMTestingSupport

Author: Michał Górny Date: 2020-05-01T21:22:51+02:00 New Revision: cac8cd0a16e9c0410e33aaca93c760c503eeb68e URL: https://github.com/llvm/llvm-project/commit/cac8cd0a16e9c0410e33aaca93c760c503eeb68e DIFF: https://github.com/llvm/llvm-project/commit/cac8cd0a16e9c0410e33aaca93c760c503eeb68e.diff

[clang] 7585ba2 - [clang][OpenMP] Fix mangling of linear parameters.

Author: Francesco Petrogalli Date: 2020-05-01T21:19:00Z New Revision: 7585ba208e67443d0fbc883db320934c65312b02 URL: https://github.com/llvm/llvm-project/commit/7585ba208e67443d0fbc883db320934c65312b02 DIFF: https://github.com/llvm/llvm-project/commit/7585ba208e67443d0fbc883db320934c65312b02.dif

[clang] 334931f - [SveEmitter] Add builtins for shifts.

Author: Sander de Smalen Date: 2020-05-01T22:27:24+01:00 New Revision: 334931f54b959c3ef03386770877789d4167d24f URL: https://github.com/llvm/llvm-project/commit/334931f54b959c3ef03386770877789d4167d24f DIFF: https://github.com/llvm/llvm-project/commit/334931f54b959c3ef03386770877789d4167d24f.di

[PATCH] D79087: [SVE][Codegen] Lower legal min & max operations

kmclaughlin updated this revision to Diff 261462. kmclaughlin added a comment. - Added tests for the intrinsics where the second operand is an immediate - Changed the range SelectSVESignedArithImm checks for, as the range for the immediates of smin & smax is -128 to +127 (inclusive) CHANGES SIN

[PATCH] D79236: [docs] Regenerate DiagnosticsReference.rst

rsandifo-arm created this revision. rsandifo-arm added reviewers: aaron.ballman, efriedma, rjmccall. Herald added subscribers: cfe-commits, s.egerton, jfb, simoncook, aheejin. Herald added a reviewer: jdoerfert. Herald added a project: clang. rsandifo-arm added a child revision: D79244: [Sema] Put

[PATCH] D79087: [SVE][Codegen] Lower legal min & max operations

kmclaughlin marked an inline comment as done. kmclaughlin added inline comments. Comment at: llvm/lib/Target/AArch64/SVEInstrFormats.td:3851 + def : SVE_1_Op_Imm_Arith_Pred_Pat(NAME # _S)>; + def : SVE_1_Op_Imm_Arith_Pred_Pat(NAME # _D)>; } efriedma wrote: > k

[PATCH] D79237: [CUDA][HIP] Fix constexpr variables for C++17

yaxunl created this revision. yaxunl added reviewers: tra, rjmccall. constexpr variables are compile time constants and implicitly const, therefore they are safe to emit on both device and host side. Besides, in many cases they are intended for both device and host, therefore it makes sense to emi

[PATCH] D72281: [Matrix] Add matrix type to Clang.

fhahn updated this revision to Diff 261476. fhahn added a comment. Switch mangling to use a vendor extended type qualifier, hoist code for loading/storing of matrix values to separate functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72281/

[PATCH] D79244: [Sema] Put existing warning under -Wexcess-initializers

rsandifo-arm created this revision. rsandifo-arm added reviewers: sdesmalen, efriedma, rovka, rjmccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. rsandifo-arm added a parent revision: D79236: [docs] Regenerate DiagnosticsReference.rst. rsandifo-arm added a child revisi

[PATCH] D78827: Add support for #pragma clang fp reassoc(on|off) -- floating point control of associative math transformations

rjmccall added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3159 +controlled with this pragma. +``#pragma clang fp allow_reassociation`` allows control over the reassociation +of floating point expressions. When enabled, this pragma allows the expression ---

[PATCH] D76689: [Sema][SVE] Fix handling of initialisers for built-in SVE types

rsandifo-arm updated this revision to Diff 261483. rsandifo-arm added a comment. Don't refer to the sizeless types as "scalars" Also add more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76689/new/ https://reviews.llvm.org/D76689 Files:

[PATCH] D79223: Fix pr31836 on Windows too, and correctly handle repeated separators.

thakis updated this revision to Diff 261481. thakis edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79223/new/ https://reviews.llvm.org/D79223 Files: clang/lib/Lex/PPDirectives.cpp clang/test/Lexer/case-insensitive-include-ms.c clang/test/Lexer/ca

[PATCH] D72281: [Matrix] Add matrix type to Clang.

fhahn marked 2 inline comments as done. fhahn added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:3349 +void CXXNameMangler::mangleType(const MatrixType *T) { + Out << "Dm" << T->getNumRows() << "_" << T->getNumColumns() << '_'; + mangleType(T->getElementType());

[PATCH] D76689: [Sema][SVE] Fix handling of initialisers for built-in SVE types

rsandifo-arm added a comment. In D76689#1939834 , @efriedma wrote: > Semantically, this makes sense. > > I'm not really happy with the use of the term "scalar initializer" to refer > to initializing a vector. Seems likely to confuse users. Yeah, fair p

[PATCH] D79139: [clangd] Fix whitespace between chunks in markdown paragraphs.

kadircet accepted this revision. kadircet marked an inline comment as done. kadircet added a comment. This revision is now accepted and ready to land. thanks lgtm! Comment at: clang-tools-extra/clangd/FormattedString.cpp:439 + bool AdjacentCode = + !Chunks.empty() && Chun

[PATCH] D79249: [NOT FOR REVIEW] Experimental support for zero-or-trap behavior foruninitialized variables.

rsmith created this revision. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert, hiraditya. Herald added projects: clang, LLVM. rsmith updated this revision to Diff 261511. rsmith added a comment. - The second operand of 'store' is the pointer, not the first. Add @llvm.trapping.()

[PATCH] D77056: [Sema][SVE] Allow non-member operators for SVE types

rsandifo-arm added a comment. I'd like to promote this from an RFC to an RFA. The associated cfe-dev discussion was: http://lists.llvm.org/pipermail/cfe-dev/2020-March/065060.html continuing into April here: http://lists.llvm.org/pipermail/cfe-dev/2020-April/065069.html I don't think there w

[PATCH] D79213: [hip] Add noalias on restrict qualified coerced hip pointers

hliao added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2556-2563 + // Restrict qualified HIP pointers that were coerced to global pointers + // can be marked with the noalias attribute. + if (isCoercedHIPGlobalPointer(*this, getLangOpts(), ArgI, Ty)

[PATCH] D79223: Fix pr31836 on Windows too, and correctly handle repeated separators.

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. OK as is, but please consider re-using `llvm::sys::path` to distinguish separators. Please also check that there are no regressions in the clang VFS tests. Comment at:

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 marked 7 inline comments as done. wxz2020 added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:89 CPU = llvm::sys::getHostCPUName(); - if (CPU == "generic") { DavidSpickett wrote: > Remove stray change. Removed ===

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 updated this revision to Diff 261497. wxz2020 marked an inline comment as done. wxz2020 added a comment. fixed all the feedback suggestions. Thanks, Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78129/new/ https://reviews.llvm.org/D78129 F

[PATCH] D78660: [SemaObjC] Add a warning for dictionary literals with duplicate keys

erik.pilkington added a comment. Ping! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78660/new/ https://reviews.llvm.org/D78660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[PATCH] D79223: Fix pr31836 on Windows too, and correctly handle repeated separators.

thakis closed this revision. thakis marked an inline comment as done. thakis added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79223/new/ https://reviews.llvm.org/D79223 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D79249: [NOT FOR REVIEW] Experimental support for zero-or-trap behavior foruninitialized variables.

rsmith updated this revision to Diff 261511. rsmith added a comment. - The second operand of 'store' is the pointer, not the first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79249/new/ https://reviews.llvm.org/D79249 Files: clang/lib/CodeGen

[PATCH] D78980: Elaborate more on --rocm-path flag.

arsenm marked an inline comment as done. arsenm added inline comments. Comment at: clang/include/clang/Driver/Options.td:612 def rocm_path_EQ : Joined<["--"], "rocm-path=">, Group, - HelpText<"ROCm installation path">; + HelpText<"ROCm installation path, used for finding and a

[PATCH] D76496: [clang-tidy] add support to 3-arg find() in StringFindStartswith

niko updated this revision to Diff 261512. niko added a comment. [clang-tidy] add 3-arg support to StringFindStartswith via string_view Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76496/new/ https://reviews.llvm.org/D76496 Files: clang-tools-e

[PATCH] D76496: [clang-tidy] add support to 3-arg find() in StringFindStartswith

niko added a comment. In D76496#1976713 , @njames93 wrote: > In D76496#1949851 , @niko wrote: > > > Correct me if I'm wrong, but that seems to be in violation of IWYU? Maybe > > I'm misreading this, or is the idea

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D75591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D78979: OpenCL: Include builtin header by default

arsenm added a comment. In D78979#2011582 , @jvesely wrote: > In D78979#2006901 , @yaxunl wrote: > > > In D78979#2006847 , @arsenm wrote: > > > > > I'm also wondering if usin

[PATCH] D78429: [clangd] Metric tracking through Tracer

kadircet updated this revision to Diff 261514. kadircet added a comment. - Track renamed files instead of occurences Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78429/new/ https://reviews.llvm.org/D78429 Files: clang-tools-extra/clangd/ClangdL

[PATCH] D78655: [HIP] Let lambda be host device by default

pfultz2 added a comment. > It captures addresses as seen at the point in time on the processor which > executed the constructor. Yea and the same happens when assigning the address to a pointer, which is later used on a different device. > Another point that capturing lambdas are not something

[PATCH] D78979: OpenCL: Include builtin header by default

arsenm added a comment. In D78979#2010739 , @Anastasia wrote: > In D78979#2010527 , @svenvh wrote: > > > In D78979#2007643 , @Anastasia > > wrote: > > > > > > Would it not b

[PATCH] D79186: [OPENMP]Consider 'omp_null_allocator' as a predefined allocator.

ABataev updated this revision to Diff 261513. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79186/new/ https://reviews.llvm.org/D79186 Files: clang/include/clang/Basic/Attr.td clang/lib/CodeGen/CGOpenMPRuntime.c

[PATCH] D77910: AMDGPU: Define cl_khr_gl_sharing as a supported extension

arsenm added a comment. In D77910#1989163 , @b-sumner wrote: > In D77910#1988807 , @arsenm wrote: > > > In D77910#1981828 , @b-sumner > > wrote: > > > > > In D77910#1981429

[PATCH] D77836: [Attribute] Fix noderef attribute false-negatives

leonardchan added inline comments. Comment at: clang/lib/Sema/SemaCast.cpp:2557-2558 return; +CheckNoDeref(Self, SrcExpr.get()->getType(), ResultType, + OpRange.getBegin()); } rsmith wrote: > Should we be checking thi

[PATCH] D77836: [Attribute] Fix noderef attribute false-negatives

leonardchan updated this revision to Diff 261519. leonardchan marked 6 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77836/new/ https://reviews.llvm.org/D77836 Files: clang/include/clang/Sema/Initialization.h clang/lib/S

[PATCH] D79118: Implement _ExtInt ABI for all ABIs in Clang, enable type for ABIs

erichkeane updated this revision to Diff 261523. erichkeane retitled this revision from "[WIP] _ExtInt calling convention Audit" to "Implement _ExtInt ABI for all ABIs in Clang, enable type for ABIs". erichkeane edited the summary of this revision. erichkeane added a subscriber: cfe-commits. erich

[PATCH] D79118: Implement _ExtInt ABI for all ABIs in Clang, enable type for ABIs

erichkeane updated this revision to Diff 261524. erichkeane edited the summary of this revision. erichkeane added a comment. Herald added a subscriber: wuzish. Remove test for which there is no longer a target where extint isn't supported (thus I cannot spell the condition). Also, clang-formatte

[PATCH] D74668: [Clang][BPF] implement __builtin_btf_type_id() builtin function

anakryiko added a comment. Let's extend __builtin_btf_type_id() to accept second argument specifying whether it's local BTF ID (from program's BTF) or target BTF ID (from kernel/module BTF)? We can probably make it an enum just like with preserve_access_index() built-in, for easy future extensi

[PATCH] D79224: [WebAssembly] Renumber SIMD opcodes

tlively updated this revision to Diff 261532. tlively added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Remove i64x2 conversion ops in clang as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79224/new/ ht

[PATCH] D78750: [SveEmitter] Add builtins for svdupq and svdupq_lane

sdesmalen added a comment. In D78750#2009037 , @efriedma wrote: > Is there some reason you decided to implement these particular functions as > inline functions directly in the header? Earlier implementations of the ACLE had a lot more things done in th

[PATCH] D78740: [clangd] Handle PresumedLocations in IncludeCollector

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Headers.cpp:40 + auto PreLoc = SM.getPresumedLoc(HashLoc); + if (auto FE = SM.getFileManager().getFile(PreLoc.getFilename())) { +if (SM.getFileEntryForID(SM.getMainFileID()) == *FE) { -

[PATCH] D79265: Let normalize() for posix style convert backslash to slash unconditionally.

thakis created this revision. thakis added a reviewer: compnerd. Herald added a subscriber: hiraditya. Herald added a project: LLVM. Currently, normalize() for posix replaces backslashes to slashes, except that two backslashes in sequence are kept as-is. clang calls normalize() to convert \ to /

[PATCH] D78750: [SveEmitter] Add builtins for svdupq and svdupq_lane

sdesmalen updated this revision to Diff 261537. sdesmalen added a comment. - Moved dupq implementation to CGBuiltins CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78750/new/ https://reviews.llvm.org/D78750 Files: clang/include/clang/Basic/arm_sve.td clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D78750: [SveEmitter] Add builtins for svdupq and svdupq_lane

sdesmalen updated this revision to Diff 261545. sdesmalen added a comment. - Re-added patch with diff context. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78750/new/ https://reviews.llvm.org/D78750 Files: clang/include/clang/Basic/arm_sve.td clang/lib/CodeGen/CGBuiltin.cpp clan

[PATCH] D78750: [SveEmitter] Add builtins for svdupq and svdupq_lane

sdesmalen marked an inline comment as done. sdesmalen added inline comments. Comment at: clang/utils/TableGen/SveEmitter.cpp:98 + bool isScalarPredicate() const { +return !Float && Predicate && NumVectors == 0; + } note: the changes to isScalarPredicate and

[PATCH] D79210: Let clang print registered targets for --version

yaxunl added a comment. Is it OK to commit this? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79210/new/ https://reviews.llvm.org/D79210 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[PATCH] D79224: [WebAssembly] Renumber SIMD opcodes

tlively marked 3 inline comments as done. tlively added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:186 // 64x2 conversions are not in the spec -if (!Subtarget->hasUnimplementedSIMD128()) - for (auto Op : ahe

[PATCH] D78933: [analyzer] RangeConstraintManager optimizations in comparison expressions

ASDenysPetrov updated this revision to Diff 261552. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78933/new/ https://reviews.llvm.org/D78933 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp clang/test/Analysis/constraint_manager_conditions.cpp Index: clang/test/Analys

[PATCH] D78933: [analyzer] RangeConstraintManager optimizations in comparison expressions

ASDenysPetrov updated this revision to Diff 261556. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78933/new/ https://reviews.llvm.org/D78933 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp clang/test/Analysis/constraint_manager_conditions.cpp Index: clang/test/Analys

[PATCH] D78933: [analyzer] RangeConstraintManager optimizations in comparison expressions

ASDenysPetrov updated this revision to Diff 261563. ASDenysPetrov edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78933/new/ https://reviews.llvm.org/D78933 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp clang/test/Analysis/constrai

[PATCH] D79210: Let clang print registered targets for --version

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Yeah, it's fine. We might want to put it behind a "long information" option, but for now it's ok. Keep an eye open if someone complains please. CHANGES SINCE LAST ACTION https://reviews

[PATCH] D79274: Fix template class debug info for Visual Studio visualizers

amccarth created this revision. amccarth added reviewers: rnk, hans. Herald added a subscriber: aprantl. An earlier change eliminated spaces between the close brackets of nested template lists. Unfortunately that prevents the Windows debuggers from matching some types to their corresponding visua

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

efriedma added inline comments. Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp:5607 + // * Register R12(IP), + // * Condition codes (and thus the CPSR register) + // If you control all the instructions that execute, you don't need to worry about what th

[PATCH] D79276: [FileCheck] Support comment directives

jdenny created this revision. jdenny added reviewers: probinson, thopre, hfinkel, jhenderson, jroelofs, jdoerfert. Herald added subscribers: cfe-commits, hiraditya, arichardson, Anastasia. Herald added projects: clang, LLVM. Sometimes you want to disable a FileCheck directive without removing it

[clang] e0f5284 - [WebAssembly] Renumber SIMD opcodes

Author: Thomas Lively Date: 2020-05-01T17:20:49-07:00 New Revision: e0f52842c8bcf1e0a59d2535072795597571adb6 URL: https://github.com/llvm/llvm-project/commit/e0f52842c8bcf1e0a59d2535072795597571adb6 DIFF: https://github.com/llvm/llvm-project/commit/e0f52842c8bcf1e0a59d2535072795597571adb6.diff

[PATCH] D74668: [Clang][BPF] implement __builtin_btf_type_id() builtin function

yonghong-song added a comment. In D74668#2015294 , @anakryiko wrote: > Let's extend __builtin_btf_type_id() to accept second argument specifying > whether it's local BTF ID (from program's BTF) or target BTF ID (from > kernel/module BTF)? We can probably

[PATCH] D78965: [clang][OpenMP] Fix mangling of linear parameters.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7585ba208e67: [clang][OpenMP] Fix mangling of linear parameters. (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78965/new/ https:/

[PATCH] D77168: Add a flag to debug automatic variable initialization

jcai19 updated this revision to Diff 261595. jcai19 marked 3 inline comments as done. jcai19 added a comment. Update based on comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77168/new/ https://reviews.llvm.org/D77168 Files: clang/include

[PATCH] D79224: [WebAssembly] Renumber SIMD opcodes

This revision was automatically updated to reflect the committed changes. Closed by commit rGe0f52842c8bc: [WebAssembly] Renumber SIMD opcodes (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79224/new/ https://reviews.llvm.org/D

[PATCH] D77168: Add a flag to debug automatic variable initialization

jcai19 marked an inline comment as done. jcai19 added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:1817 + CGM.countAutoVarInit(); +} + jfb wrote: > This isn't the right place to stop auto-init: we can get past this point even > without auto

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

efriedma added inline comments. Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp:5806 +if (Opc == ARM::BL || Opc == ARM::tBL || Opc == ARM::BLX || +Opc == ARM::tBLXr || Opc == ARM::tBLXi) + UnknownCallOutlineType = outliner::InstrType::LegalTerminator; --

[PATCH] D79279: Allow volatile parameters to __builtin_mem{cpy,move,set}

jfb created this revision. Herald added subscribers: cfe-commits, ributzka, dexonsmith, jkorous, JDevlieghere. Herald added a project: clang. These builtins are often used (or should be used) in places where time-of-check time-of-use security issues are important (e.g. copying from untrusted buff

[PATCH] D77168: Add a flag to debug automatic variable initialization

jcai19 updated this revision to Diff 261597. jcai19 added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77168/new/ https://reviews.llvm.org/D77168 Files: clang/include/clang/Basic/LangOptions.def clang/include/clang/Driver/Options.td

[PATCH] D78750: [SveEmitter] Add builtins for svdupq and svdupq_lane

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:8054 + +Value *Alloca = Builder.CreateAlloca(EltTy, Builder.getInt32(NumOpnds)); +for (unsigned I = 0; I < NumOpnds; ++I) Please use something like `CreateTempAlloca(llvm::ArrayTy

[PATCH] D77982: [Windows SEH] Fix the frame-ptr of a nested-filter within a _finally

tentzen added a reviewer: asl. tentzen added a comment. Hi, Anton, I found you are the Code Owner of "Exception handling, Windows CodeGen, ARM EABI". could you please provide a quick review here? thanks, Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D79087: [SVE][Codegen] Lower legal min & max operations

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79087/new/ https://reviews.llvm.org/D79087 ___ cfe-commits mailing list cfe-commi

[PATCH] D76689: [Sema][SVE] Fix handling of initialisers for built-in SVE types

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76689/new/ https://reviews.llvm.org/D76689 ___

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

Xiangling_L updated this revision to Diff 261602. Xiangling_L added a comment. Herald added a reviewer: aaron.ballman. Fix a minor issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74166/new/ https://reviews.llvm.org/D74166 Files: clang/includ

[PATCH] D78969: [clang][OpenMP] Fix getNDSWDS for aarch64.

fpetrogalli updated this revision to Diff 261610. fpetrogalli added a comment. I have added (indirect) testing of the values of NDS and WDS. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78969/new/ https://reviews.llvm.org/D78969 Files: clang/li

[PATCH] D78969: [clang][OpenMP] Fix getNDSWDS for aarch64.

fpetrogalli updated this revision to Diff 261611. fpetrogalli added a comment. Removed single use variable definition. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78969/new/ https://reviews.llvm.org/D78969 Files: clang/lib/CodeGen/CGOpenMPRunt

[PATCH] D79279: Allow volatile parameters to __builtin_mem{cpy,move,set}

rjmccall added a comment. Most of the complexity of this patch is introduced by the decision to type-check these calls with a volatile-typed parameter, which seems like it does nothing but cause problems. If your goal is to make these functions do the right thing when given arbitrary pointer t

[PATCH] D79236: [docs] Regenerate DiagnosticsReference.rst

rjmccall added a comment. There's no good reason for this file to exist; documenting the warning options is useful, but the file should be generated as an intermediate output of the documentation build and then ultimately fed into Sphinx. There's even a TODO in the docs about it: > TODO: Gener

[clang] f3a3db8 - Add the missing '='. NFC.

Author: Michael Liao Date: 2020-05-02T01:07:44-04:00 New Revision: f3a3db8627e9fa673fa413a2e41fe5443db7c6c3 URL: https://github.com/llvm/llvm-project/commit/f3a3db8627e9fa673fa413a2e41fe5443db7c6c3 DIFF: https://github.com/llvm/llvm-project/commit/f3a3db8627e9fa673fa413a2e41fe5443db7c6c3.diff

[PATCH] D72281: [Matrix] Add matrix type to Clang.

rjmccall added inline comments. Comment at: clang/include/clang/Basic/TypeNodes.td:73 def ExtVectorType : TypeNode; +def MatrixType : TypeNode; def FunctionType : TypeNode; I think some parts of your life might be easier if there were a common base class here.

[PATCH] D79118: Implement _ExtInt ABI for all ABIs in Clang, enable type for ABIs

rjmccall added a comment. A little cavalier with `byval`; I gave it a thorough audit, but you might want your own pass. Comment at: clang/lib/CodeGen/ABIInfo.h:107 +// only difference is that this considers _ExtInt as well. +bool isPromotableIntegerType(QualType Ty) co

[PATCH] D79232: [analyzer] Refactor range inference for symbolic expressions

NoQ added a subscriber: steakhal. NoQ added a comment. Very nice, i like this architecture. @baloghadamsoftware @steakhal @ASDenysPetrov will you be able to plug D49074 /D50256 /D77792 /D77802 <

[PATCH] D74051: Move update_cc_test_checks.py tests to clang

mgorny reopened this revision. mgorny added a comment. This revision is now accepted and ready to land. This broke running clang tests stand-alone: Traceback (most recent call last): File "/var/tmp/portage/sys-devel/clang-11.0.0./work/x/y/clang-abi_x86_64.amd64/bin/../../llvm/utils/lit

LLVM lab network works on May 2nd at 11:00 am PDT

Hello everyone, LLVM buildmaster will be unavailable tomorrow on Saturday, May 2nd at 11:00AM PDT due to network maintenance works. Hopefully this will take about half hour. Thank you for understanding. Thanks Galina ___ cfe-commits mailing list

[PATCH] D74051: Move update_cc_test_checks.py tests to clang

lebedev.ri added a comment. In D74051#2016078 , @mgorny wrote: > This broke running clang tests stand-alone: > > Traceback (most recent call last): > File > "/var/tmp/portage/sys-devel/clang-11.0.0./work/x/y/clang-abi_x86_64.amd64/bin/../../llvm