[PATCH] D71124: [RISCV] support clang driver to select cpu

khchen updated this revision to Diff 261741. khchen added a comment. address kito's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71124/new/ https://reviews.llvm.org/D71124 Files: clang/lib/Basic/Targets/RISCV.cpp clang/lib/Basic/Targe

[PATCH] D77168: Add a flag to debug automatic variable initialization

jcai19 updated this revision to Diff 261740. jcai19 added a comment. Issue a warning when the proposed flag is used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77168/new/ https://reviews.llvm.org/D77168 Files: clang/include/clang/Basic/Diagno

[PATCH] D79201: [clang-format] : Fix additional pointer alignment for overloaded operators

Abpostelnicu requested changes to this revision. Abpostelnicu added a comment. This revision now requires changes to proceed. As per what @sammccall said. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79201/new/ https://reviews.llvm.org/D79201 _

[PATCH] D78442: Create a warning flag for 'warn_conv_*_not_used'

rdwampler updated this revision to Diff 261731. rdwampler added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78442/new/ https://reviews.llvm.org/D78442 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticSemaKinds.td clang/t

[PATCH] D77802: [analyzer] Improved RangeSet::Negate support of unsigned ranges

NoQ added a comment. The math looks correct, thank you for fixing the crash and adding support for more cases! Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:261-262 +// remove adjacent ranges +newRanges = F.remove(newRanges, *iter1); +newRang

[PATCH] D79232: [analyzer] Refactor range inference for symbolic expressions

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:340-345 +// TODO #2: We didn't go into the nested expressions before, so it +// might cause us spending much more time doing the inference. +// This can be a problem for de

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/CallEvent.cpp:614 + SVB.makeLoc(MRMgr.getParamRegion(ICC->getInheritingConstructor(), + Idx, CalleeCtx)); +Bindings.push_back(std::make_pair(ParamLoc, A

[PATCH] D78457: [analyzer][Z3-refutation] Fix a refutation BugReporterVisitor bug

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:2871 + // Overwrite the associated constraint of the Symbol. + Constraints = CF.remove(Constraints, Sym); Constraints = CF.add(Constraints, Sym, C.second); --

[PATCH] D79186: [OPENMP]Consider 'omp_null_allocator' as a predefined allocator.

ABataev added a comment. In D79186#2016737 , @jdoerfert wrote: > In D79186#2013689 , @ABataev wrote: > > > In D79186#2013603 , @jdoerfert > > wrote: > > > > > What would you

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

llunak updated this revision to Diff 261722. llunak added a comment. Reopening because of https://reviews.llvm.org/D74846, updated version includes the partial revert from there. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69778/new/ https://reviews.llvm.org/D

[PATCH] D74846: fix -fcodegen-modules code when used with PCH (PR44953)

llunak abandoned this revision. llunak added a comment. This review did make sense when it was created, it's just that it took so long to get this processed that it was simpler to revert the original patch. Anyway, I've merged the change to https://reviews.llvm.org/D69778 . Repository: rC Cl

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

llunak reopened this revision. llunak added a comment. This revision is now accepted and ready to land. Reopening because of https://reviews.llvm.org/D74846, updated version includes the partial revert from there. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D697

[PATCH] D79293: [clang-format] [PR45218] Fix an issue where < and > and >> in a for loop gets incorrectly interpreted at a TemplateOpener/Closer

curdeius added a comment. > This fix tries to avoid that issue by determining that a ";" between the < > and > would not be a template (I couldn't think of an example where that > would be the case, but I'm sure there are.. For what is worth, with lambdas in unevaluated context (C++20), you can

[clang-tools-extra] 6fe20a4 - [clangd] Fix yet-another gratuitous llvm::Error crash

Author: Sam McCall Date: 2020-05-03T22:13:58+02:00 New Revision: 6fe20a44fd3fc95198b3b38dc1080266be4ef004 URL: https://github.com/llvm/llvm-project/commit/6fe20a44fd3fc95198b3b38dc1080266be4ef004 DIFF: https://github.com/llvm/llvm-project/commit/6fe20a44fd3fc95198b3b38dc1080266be4ef004.diff LO

[PATCH] D79290: Update suffix check and cast non-suffix types

hubert.reinterpretcast added a comment. In D79290#2016608 , @v.g.vassilev wrote: > @hubert.reinterpretcast, this patch is part of our internal forks which we > would like to put upstream. The author of the previous patch does not have > bandwidth to wor

[PATCH] D79302: [clangd] Propogate context in LSPServer tests

kadircet updated this revision to Diff 261717. kadircet added a comment. - Drop LSP latency test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79302/new/ https://reviews.llvm.org/D79302 Files: clang-tools-extra/clangd/unittests/ClangdLSPServerTe

[PATCH] D79302: [clangd] Propogate context in LSPServer tests

kadircet updated this revision to Diff 261715. kadircet added a comment. - Call sync instead of waiting on context destruction Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79302/new/ https://reviews.llvm.org/D79302 Files: clang-tools-extra/clan

[clang-tools-extra] 81e48ae - [clangd] Reland LSP latency test

Author: Kadir Cetinkaya Date: 2020-05-03T21:06:57+02:00 New Revision: 81e48ae2b4a55cb79a0f104d5562bbf3a22ec4ff URL: https://github.com/llvm/llvm-project/commit/81e48ae2b4a55cb79a0f104d5562bbf3a22ec4ff DIFF: https://github.com/llvm/llvm-project/commit/81e48ae2b4a55cb79a0f104d5562bbf3a22ec4ff.dif

Re: [PATCH] D79302: [clangd] Propogate context in LSPServer tests

i was trying to provide a more generic "callback" mechanism, but you are right, it is not needed for this test. going to keep context prop logic though, as it might be necessary later on. SG? On Sun, May 3, 2020 at 9:09 PM Sam McCall via Phabricator < revi...@reviews.llvm.org> wrote: > sammccall

[PATCH] D79279: Allow volatile parameters to __builtin_mem{cpy,move,set}

rjmccall added a comment. In D79279#2016604 , @jfb wrote: > In D79279#2016573 , @rjmccall wrote: > > > In D79279#2016570 , @rjmccall > > wrote: > > > > > I do think this is

[PATCH] D79302: [clangd] Propogate context in LSPServer tests

sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/ClangdLSPServerTests.cpp:164 +WithContextValue Ctx( +llvm::make_scope_exit([&CallFinished] { CallFinished.notify(); })); +llvm::consumeError(Client.call(MethodName, {}).take().takeErro

[PATCH] D79293: [clang-format] [PR45218] Fix an issue where < and > and >> in a for loop gets incorrectly interpreted at a TemplateOpener/Closer

MyDeveloperDay updated this revision to Diff 261705. MyDeveloperDay added a comment. Add more test cases to try to ensure TemplateOpener/Closer type isn't assigned incorrectly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79293/new/ https://reviews.llvm.org/D79293 Files: clang/lib/

[PATCH] D79186: [OPENMP]Consider 'omp_null_allocator' as a predefined allocator.

jdoerfert added a comment. In D79186#2013689 , @ABataev wrote: > In D79186#2013603 , @jdoerfert wrote: > > > What would you think about moving the allocator definitions to OMPKinds.def > > instead of listing them e

[PATCH] D79121: Add nomerge function attribute to clang

zequanwu updated this revision to Diff 261698. zequanwu marked 4 inline comments as done. zequanwu added a comment. Add Sema test. Check if nomerge attribute has no arguments and statement contains call expressions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79121/new/ https://revie

[PATCH] D78969: [clang][OpenMP] Fix getNDSWDS for aarch64.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78969/new/ https://reviews.llvm.org/D78969

[PATCH] D78457: [analyzer][Z3-refutation] Fix a refutation BugReporterVisitor bug

mikhail.ramalho added a comment. Nice work, @steakhal! I remember discussing with @NoQ a way of going backward on the bug report, from the error node, and never add constraints of symbols that were already collected; that way we would always have the tighter constraints. I don't quite remember

[clang-tools-extra] 7016043 - [clangd] Change include to be relative to current directory

Author: Kadir Cetinkaya Date: 2020-05-03T18:09:50+02:00 New Revision: 7016043d0d5f2d0b27d84d1c767b7b9d2d90b2b8 URL: https://github.com/llvm/llvm-project/commit/7016043d0d5f2d0b27d84d1c767b7b9d2d90b2b8 DIFF: https://github.com/llvm/llvm-project/commit/7016043d0d5f2d0b27d84d1c767b7b9d2d90b2b8.dif

Re: [PATCH] D79302: [clangd] Propogate context in LSPServer tests

On Sun, May 3, 2020, 3:22 PM Kadir Cetinkaya via Phabricator < revi...@reviews.llvm.org> wrote: > kadircet marked 3 inline comments as done. > kadircet added inline comments. > > > > Comment at: clang-tools-extra/clangd/unittests/LSPClient.cpp:120 > + auto Req = std::move(Req

[PATCH] D79302: [clangd] Propogate context in LSPServer tests

kadircet marked 3 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/LSPClient.cpp:120 + auto Req = std::move(Requests.front()); + // Leave request on the queue so that waiters can see it. Lock.unlock(); --

[PATCH] D79302: [clangd] Propogate context in LSPServer tests

kadircet updated this revision to Diff 261694. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79302/new/ https://reviews.llvm.org/D79302 Files: clang-tools-ex

[clang-tools-extra] af28c74 - [clangd] Drop duplicate header

Author: Kadir Cetinkaya Date: 2020-05-03T15:20:20+02:00 New Revision: af28c74e8fc5739b419e61ba91d5a052d6c4cd2c URL: https://github.com/llvm/llvm-project/commit/af28c74e8fc5739b419e61ba91d5a052d6c4cd2c DIFF: https://github.com/llvm/llvm-project/commit/af28c74e8fc5739b419e61ba91d5a052d6c4cd2c.dif

[PATCH] D79302: [clangd] Propogate context in LSPServer tests

sammccall added a comment. Hmm, I wonder if we should have a Context.bind(function) -> function. I guess it runs into the usual thing of not being able to deduce a functor's signature, so you get an ugly templated return type.. Comment at: clang-tools-extra/clangd/unittests/LS

[PATCH] D79302: [clangd] Propogate context in LSPServer tests

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This enables users to wait until async request completes. Taking a response isn't enough, as receiving

[clang-tools-extra] 6c24b59 - [clangd] Fix name hiding in TestTracer and disable racy test for now

Author: Kadir Cetinkaya Date: 2020-05-03T11:51:23+02:00 New Revision: 6c24b59ca15a577d52bb900016016b8794900588 URL: https://github.com/llvm/llvm-project/commit/6c24b59ca15a577d52bb900016016b8794900588 DIFF: https://github.com/llvm/llvm-project/commit/6c24b59ca15a577d52bb900016016b8794900588.dif

[PATCH] D78429: [clangd] Metric tracking through Tracer

This revision was automatically updated to reflect the committed changes. kadircet marked 2 inline comments as done. Closed by commit rGe64f99c51a8e: [clangd] Metric tracking through Tracer (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D78429?vs=261514&id=261686#toc

[clang-tools-extra] e64f99c - [clangd] Metric tracking through Tracer

Author: Kadir Cetinkaya Date: 2020-05-03T10:50:32+02:00 New Revision: e64f99c51a8e4476981ffdc9632b57b9fd3b5286 URL: https://github.com/llvm/llvm-project/commit/e64f99c51a8e4476981ffdc9632b57b9fd3b5286 DIFF: https://github.com/llvm/llvm-project/commit/e64f99c51a8e4476981ffdc9632b57b9fd3b5286.dif