[PATCH] D79701: [clangd] Add metrics for selection tree and recovery expressions.

2020-05-12 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 263382. hokein marked 2 inline comments as done. hokein added a comment. address comments, and remove the fixme. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79701/new/ https://reviews.llvm.org/D79701 Files:

[PATCH] D79770: [RISCV] Fix passing two floating-point values in complex separately by two GPRs on RV64

2020-05-12 Thread Luís Marques via Phabricator via cfe-commits
luismarques added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10241-10242 // Pass floating point values via FPRs if possible. - if (IsFixed && Ty->isFloatingType() && FLen >= Size && ArgFPRsLeft) { + if (IsFixed && Ty->isFloatingType() &&

[clang] 40ef427 - get rid of the NDEBUG usage in RecoveryExpr, NFC.

2020-05-12 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2020-05-12T10:19:58+02:00 New Revision: 40ef4274600316ed12a26a73265cf34432e1fbf7 URL: https://github.com/llvm/llvm-project/commit/40ef4274600316ed12a26a73265cf34432e1fbf7 DIFF: https://github.com/llvm/llvm-project/commit/40ef4274600316ed12a26a73265cf34432e1fbf7.diff

[PATCH] D79770: [RISCV] Fix passing two floating-point values in complex separately by two GPRs on RV64

2020-05-12 Thread Jim Lin via Phabricator via cfe-commits
Jim created this revision. Jim added reviewers: asb, luismarques, lenary. Herald added subscribers: cfe-commits, evandro, apazos, sameer.abuasal, pzheng, s.egerton, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217,

[PATCH] D79201: [clang-format] : Fix additional pointer alignment for overloaded operators

2020-05-12 Thread Andi via Phabricator via cfe-commits
Abpostelnicu accepted this revision. Abpostelnicu added a comment. This revision is now accepted and ready to land. Sorry, totally forgot about this, thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79201/new/ https://reviews.llvm.org/D79201

[PATCH] D79201: [clang-format] : Fix additional pointer alignment for overloaded operators

2020-05-12 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. @Abpostelnicu as you requested changes I need an "Accept" from you CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79201/new/ https://reviews.llvm.org/D79201 ___ cfe-commits mailing list

[PATCH] D68049: Propeller: Clang options for basic block sections

2020-05-12 Thread Sriraman Tallam via Phabricator via cfe-commits
tmsriram updated this revision to Diff 263371. tmsriram marked 5 inline comments as done and an inline comment as not done. tmsriram added a comment. Address reviewer comments: 1. Use Diagnostic instead of errs 2. Move test input to Inputs/ 3. Fix option description. CHANGES SINCE LAST ACTION

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

2020-05-12 Thread Balázs Kéri via Phabricator via cfe-commits
balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ValistChecker.cpp:176-180 if (const auto *DeclReg = Reg->getAs()) { if (isa(DeclReg->getDecl())) Reg = C.getState()->getSVal(SV.castAs()).getAsRegion(); + } else if (const auto

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

2020-05-12 Thread Pavel Labath via Phabricator via cfe-commits
labath added inline comments. Comment at: llvm/cmake/config-ix.cmake:514 + if(ZLIB_FOUND) +set(LLVM_ENABLE_ZLIB "YES" CACHE STRING + "Use zlib for compression/decompression if available. Can be ON, OFF, or FORCE_ON" JDevlieghere wrote: > phosek wrote:

[PATCH] D79691: [clangd] Have suppression comments take precedence over warning-as-error

2020-05-12 Thread Nathan Ridge via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG5a7276b35485: [clangd] Have suppression comments take precedence over warning-as-error (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79691: [clangd] Have suppression comments take precedence over warning-as-error

2020-05-12 Thread Nathan Ridge via Phabricator via cfe-commits
nridge updated this revision to Diff 263361. nridge added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79691/new/ https://reviews.llvm.org/D79691 Files: clang-tools-extra/clangd/ParsedAST.cpp

[clang-tools-extra] 5a7276b - [clangd] Have suppression comments take precedence over warning-as-error

2020-05-12 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2020-05-12T02:29:03-04:00 New Revision: 5a7276b3548589590b81975d5c3e487dd91ac097 URL: https://github.com/llvm/llvm-project/commit/5a7276b3548589590b81975d5c3e487dd91ac097 DIFF: https://github.com/llvm/llvm-project/commit/5a7276b3548589590b81975d5c3e487dd91ac097.diff

[PATCH] D77249: [MSan] Pass command line options to MSan with new pass manager

2020-05-12 Thread Jinsong Ji via Phabricator via cfe-commits
jsji added a comment. Herald added a subscriber: wuzish. NOTE that https://reviews.llvm.org/D79445 has committed a similar fix and fixed most of the failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77249/new/

Bug in QualTypeNames.cpp and adding an option to prepend "::" to fully qualified names.

2020-05-12 Thread Jean-Baptiste Lespiau via cfe-commits
Hi, *Context and history:* I have found a bug in CLIF , which does not correctly fully qualify templated names when they are nested, e.g. ::tensorfn::Nested< ::std::variant > should have been: ::tensorfn::Nested<

Re: [PATCH] D79504: [Clang] Wrong return type of atomic_is_lock_free

2020-05-12 Thread kamlesh kumar via cfe-commits
Name: Kamlesh Kumar Email: kamleshbha...@gmail.com On Mon, May 11, 2020, 6:22 PM Louis Dionne via Phabricator < revi...@reviews.llvm.org> wrote: > ldionne added a comment. > > What name and email do you want this committed with? > > > CHANGES SINCE LAST ACTION >

<    1   2